commit fd11ce5fafeb599822f6a0b6a4071a8cf6ccc01a
author Qiongcheng Luo <qiongcheng.luo@sonymobile.com> Fri Aug 04 14:34:34 2017 +0800
committer yuuki, habu <yuuki.habu@sony.com> Thu Sep 07 15:40:09 2017 +0900
tree 5d94b46099250e575a2e09980642d3dc50245a71
parent 6c7ef2e8d7538e8d9b38e724cffd5cf81c7dad10

Fix Crash CarrierDefaultApp due to exception

[Issue]
CarrierDefaultApp crashes due to null pointer exception.

[Cause of defect]
To call mUrl.toString() even if mUrl is null and mUrl is already
checked if it is null just before.

[How to fix]
Check the null status of mUrl when call its toString() method.

Bug: 65393337

Change-Id: I4b4b1f125aac7e30ca18be22d7adc358cab83b2f

packages/CarrierDefaultApp/src/com/android/carrierdefaultapp/CaptivePortalLoginActivity.java

diff --git a/packages/CarrierDefaultApp/src/com/android/carrierdefaultapp/CaptivePortalLoginActivity.java b/packages/CarrierDefaultApp/src/com/android/carrierdefaultapp/CaptivePortalLoginActivity.java
index c1f03fd..fbed837 100644
--- a/packages/CarrierDefaultApp/src/com/android/carrierdefaultapp/CaptivePortalLoginActivity.java
+++ b/packages/CarrierDefaultApp/src/com/android/carrierdefaultapp/CaptivePortalLoginActivity.java
@@ -170,7 +170,8 @@
     }
 
     private void done(boolean success) {
-        if (DBG) logd(String.format("Result success %b for %s", success, mUrl.toString()));
+        if (DBG) logd(String.format("Result success %b for %s", success,
+                mUrl != null ? mUrl.toString() : "null"));
         if (success) {
             // Trigger re-evaluation upon success http response code
             CarrierActionUtils.applyCarrierAction(