commit fe19f1234e460a22e43a53665db1c48613844fa6
author Matthew Xie <mattx@google.com> Thu Jul 12 16:03:32 2012 -0700
committer Android (Google) Code Review <android-gerrit@google.com> Mon Jul 16 21:30:45 2012 -0700
tree 43d2967d27df85f154d32c2c2af75cb15bc47584
parent 6fde3098074ab2551867d1cd919958383b15725f

Add TODO comments to remove start/stopReverseTethering

Change start/stopReverseTethering permission from CHANGE_NETWORK_STATE
to CONNECTIVITY_INTERNAL

Change-Id: Iac76d5af6418e6a3e2d2f77bf713466981285e1a

services/java/com/android/server/NetworkManagementService.java

diff --git a/services/java/com/android/server/NetworkManagementService.java b/services/java/com/android/server/NetworkManagementService.java
index ccba0d2..648dfff 100644
--- a/services/java/com/android/server/NetworkManagementService.java
+++ b/services/java/com/android/server/NetworkManagementService.java
@@ -780,11 +780,12 @@
         event.checkCode(TetherStatusResult);
         return event.getMessage().endsWith("started");
     }
+
+    // TODO(BT) Remove
     public void startReverseTethering(String iface)
              throws IllegalStateException {
         if (DBG) Slog.d(TAG, "startReverseTethering in");
-        mContext.enforceCallingOrSelfPermission(
-                android.Manifest.permission.CHANGE_NETWORK_STATE, "NetworkManagementService");
+        mContext.enforceCallingOrSelfPermission(CONNECTIVITY_INTERNAL, TAG);
         // cmd is "tether start first_start first_stop second_start second_stop ..."
         // an odd number of addrs will fail
         String cmd = "tether start-reverse";
@@ -798,9 +799,10 @@
         BluetoothTetheringDataTracker.getInstance().startReverseTether(iface);
 
     }
+
+    // TODO(BT) Remove
     public void stopReverseTethering() throws IllegalStateException {
-        mContext.enforceCallingOrSelfPermission(
-                android.Manifest.permission.CHANGE_NETWORK_STATE, "NetworkManagementService");
+        mContext.enforceCallingOrSelfPermission(CONNECTIVITY_INTERNAL, TAG);
         try {
             mConnector.doCommand("tether stop-reverse");
         } catch (NativeDaemonConnectorException e) {