blob: cc640f03edba9e54061504be638f289b74417599 [file] [log] [blame]
Fyodor Kupolov74876572015-02-23 17:14:45 -08001/*
2 * Copyright (C) 2015 The Android Open Source Project
3 *
4 * Licensed under the Apache License, Version 2.0 (the "License");
5 * you may not use this file except in compliance with the License.
6 * You may obtain a copy of the License at
7 *
8 * http://www.apache.org/licenses/LICENSE-2.0
9 *
10 * Unless required by applicable law or agreed to in writing, software
11 * distributed under the License is distributed on an "AS IS" BASIS,
12 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13 * See the License for the specific language governing permissions and
14 * limitations under the License
15 */
16
17package com.android.server.pm;
18
Fyodor Kupolovb94c1652015-03-03 12:25:30 -080019import android.annotation.Nullable;
Fyodor Kupolova627c092015-05-05 18:44:39 -070020import android.content.Context;
Fyodor Kupolov74876572015-02-23 17:14:45 -080021import android.content.pm.ApplicationInfo;
22import android.content.pm.PackageParser;
Nicolas Geoffray8d144eb2018-11-15 12:59:52 +000023import android.content.pm.SharedLibraryInfo;
Calin Juravle6ae39fc2018-01-19 20:32:47 -080024import android.content.pm.dex.ArtManager;
Calin Juravlecc651942018-02-01 17:20:51 +000025import android.content.pm.dex.DexMetadataHelper;
Calin Juravleadbadd52017-03-28 18:19:15 -070026import android.os.FileUtils;
Fyodor Kupolova627c092015-05-05 18:44:39 -070027import android.os.PowerManager;
Fyodor Kupolov28f28552017-05-02 12:11:02 -070028import android.os.SystemClock;
Nicolas Geoffray20a894e2017-09-08 13:01:40 +010029import android.os.SystemProperties;
Fyodor Kupolov74876572015-02-23 17:14:45 -080030import android.os.UserHandle;
Fyodor Kupolova627c092015-05-05 18:44:39 -070031import android.os.WorkSource;
Fyodor Kupolov74876572015-02-23 17:14:45 -080032import android.util.Log;
33import android.util.Slog;
34
Calin Juravle2d4b6ad72017-01-04 13:22:14 -080035import com.android.internal.annotations.GuardedBy;
Narayan Kamath88eea9e2016-05-02 14:44:31 +010036import com.android.internal.util.IndentingPrintWriter;
Jeff Sharkey740f5232016-12-09 14:31:26 -070037import com.android.server.pm.Installer.InstallerException;
Calin Juravle0610dd12018-07-20 15:51:17 -070038import com.android.server.pm.dex.ArtManagerService;
Victor Hsieh785d6182018-04-19 14:26:28 -070039import com.android.server.pm.dex.DexManager;
Calin Juravle1d0e83d2017-07-17 15:12:01 -070040import com.android.server.pm.dex.DexoptOptions;
Calin Juravle19da1cf2017-07-12 18:52:49 -070041import com.android.server.pm.dex.DexoptUtils;
Calin Juravlef1ff36f2017-07-22 12:33:41 -070042import com.android.server.pm.dex.PackageDexUsage;
Jeff Sharkeyfdeeeea2016-01-11 17:34:24 -070043
Fyodor Kupolovb94c1652015-03-03 12:25:30 -080044import java.io.File;
Fyodor Kupolov74876572015-02-23 17:14:45 -080045import java.io.IOException;
Calin Juravle2d4b6ad72017-01-04 13:22:14 -080046import java.util.ArrayList;
Calin Juravle4c2b9552017-08-10 17:23:00 -070047import java.util.Arrays;
Fyodor Kupolov74876572015-02-23 17:14:45 -080048import java.util.List;
Calin Juravle41a57a62017-08-06 19:20:19 -070049import java.util.Map;
Fyodor Kupolov74876572015-02-23 17:14:45 -080050
51import dalvik.system.DexFile;
Fyodor Kupolov74876572015-02-23 17:14:45 -080052
David Brazdil06ae4b82018-11-02 18:01:45 +000053import static android.content.pm.ApplicationInfo.HIDDEN_API_ENFORCEMENT_DISABLED;
Mathew Inwoode3299532018-02-22 13:19:53 +000054
Todd Kennedyfa54ab72015-09-25 07:46:12 -070055import static com.android.server.pm.Installer.DEXOPT_BOOTCOMPLETE;
56import static com.android.server.pm.Installer.DEXOPT_DEBUGGABLE;
Andreas Gampebdd30d82016-03-20 11:32:11 -070057import static com.android.server.pm.Installer.DEXOPT_PROFILE_GUIDED;
Todd Kennedyfa54ab72015-09-25 07:46:12 -070058import static com.android.server.pm.Installer.DEXOPT_PUBLIC;
Calin Juravlec22c30e2017-01-16 19:18:48 -080059import static com.android.server.pm.Installer.DEXOPT_SECONDARY_DEX;
60import static com.android.server.pm.Installer.DEXOPT_FORCE;
61import static com.android.server.pm.Installer.DEXOPT_STORAGE_CE;
62import static com.android.server.pm.Installer.DEXOPT_STORAGE_DE;
David Sehr2118ec42017-10-25 14:28:29 -070063import static com.android.server.pm.Installer.DEXOPT_IDLE_BACKGROUND_JOB;
David Brazdilf7e31c02018-02-13 17:04:26 +000064import static com.android.server.pm.Installer.DEXOPT_ENABLE_HIDDEN_API_CHECKS;
Mathieu Chartierfa3e9762018-03-06 18:28:22 -080065import static com.android.server.pm.Installer.DEXOPT_GENERATE_COMPACT_DEX;
Mathieu Chartiera9c34332018-03-12 17:11:07 -070066import static com.android.server.pm.Installer.DEXOPT_GENERATE_APP_IMAGE;
Fyodor Kupolov74876572015-02-23 17:14:45 -080067import static com.android.server.pm.InstructionSets.getAppDexInstructionSets;
68import static com.android.server.pm.InstructionSets.getDexCodeInstructionSets;
Calin Juravle2d4b6ad72017-01-04 13:22:14 -080069
Fyodor Kupolov28f28552017-05-02 12:11:02 -070070import static com.android.server.pm.PackageManagerService.WATCHDOG_TIMEOUT;
Nicolas Geoffrayb0818e82017-05-05 10:23:19 +010071
Calin Juravle4bc8f4d2018-02-12 12:00:44 -080072import static com.android.server.pm.PackageManagerServiceCompilerMapping.getReasonName;
73
Nicolas Geoffrayd093b202017-05-03 13:11:58 +010074import static dalvik.system.DexFile.getSafeModeCompilerFilter;
Calin Juravle2d4b6ad72017-01-04 13:22:14 -080075import static dalvik.system.DexFile.isProfileGuidedCompilerFilter;
Fyodor Kupolov74876572015-02-23 17:14:45 -080076
77/**
78 * Helper class for running dexopt command on packages.
79 */
Calin Juravlec22c30e2017-01-16 19:18:48 -080080public class PackageDexOptimizer {
Fyodor Kupolovb94c1652015-03-03 12:25:30 -080081 private static final String TAG = "PackageManager.DexOptimizer";
82 static final String OAT_DIR_NAME = "oat";
83 // TODO b/19550105 Remove error codes and use exceptions
Calin Juravlec22c30e2017-01-16 19:18:48 -080084 public static final int DEX_OPT_SKIPPED = 0;
85 public static final int DEX_OPT_PERFORMED = 1;
86 public static final int DEX_OPT_FAILED = -1;
Fyodor Kupolov28f28552017-05-02 12:11:02 -070087 // One minute over PM WATCHDOG_TIMEOUT
88 private static final long WAKELOCK_TIMEOUT_MS = WATCHDOG_TIMEOUT + 1000 * 60;
Fyodor Kupolov74876572015-02-23 17:14:45 -080089
Calin Juravleaae35762017-02-14 17:53:13 -080090 /** Special library name that skips shared libraries check during compilation. */
91 public static final String SKIP_SHARED_LIBRARY_CHECK = "&";
92
Fyodor Kupolov28f28552017-05-02 12:11:02 -070093 @GuardedBy("mInstallLock")
Andreas Gampea8908752015-11-10 08:58:14 -080094 private final Installer mInstaller;
95 private final Object mInstallLock;
Fyodor Kupolov74876572015-02-23 17:14:45 -080096
Fyodor Kupolov28f28552017-05-02 12:11:02 -070097 @GuardedBy("mInstallLock")
Fyodor Kupolova627c092015-05-05 18:44:39 -070098 private final PowerManager.WakeLock mDexoptWakeLock;
99 private volatile boolean mSystemReady;
100
Andreas Gampea8908752015-11-10 08:58:14 -0800101 PackageDexOptimizer(Installer installer, Object installLock, Context context,
102 String wakeLockTag) {
103 this.mInstaller = installer;
104 this.mInstallLock = installLock;
105
106 PowerManager powerManager = (PowerManager)context.getSystemService(Context.POWER_SERVICE);
107 mDexoptWakeLock = powerManager.newWakeLock(PowerManager.PARTIAL_WAKE_LOCK, wakeLockTag);
108 }
109
110 protected PackageDexOptimizer(PackageDexOptimizer from) {
111 this.mInstaller = from.mInstaller;
112 this.mInstallLock = from.mInstallLock;
113 this.mDexoptWakeLock = from.mDexoptWakeLock;
114 this.mSystemReady = from.mSystemReady;
Fyodor Kupolov74876572015-02-23 17:14:45 -0800115 }
116
Calin Juravledb4a79a2015-12-23 18:55:08 +0200117 static boolean canOptimizePackage(PackageParser.Package pkg) {
Nicolas Geoffray20a894e2017-09-08 13:01:40 +0100118 // We do not dexopt a package with no code.
119 if ((pkg.applicationInfo.flags & ApplicationInfo.FLAG_HAS_CODE) == 0) {
120 return false;
121 }
122
Nicolas Geoffray20a894e2017-09-08 13:01:40 +0100123 return true;
Calin Juravledb4a79a2015-12-23 18:55:08 +0200124 }
125
Fyodor Kupolov74876572015-02-23 17:14:45 -0800126 /**
127 * Performs dexopt on all code paths and libraries of the specified package for specified
128 * instruction sets.
129 *
Andreas Gampea8908752015-11-10 08:58:14 -0800130 * <p>Calls to {@link com.android.server.pm.Installer#dexopt} on {@link #mInstaller} are
131 * synchronized on {@link #mInstallLock}.
Fyodor Kupolov74876572015-02-23 17:14:45 -0800132 */
Nicolas Geoffray8d144eb2018-11-15 12:59:52 +0000133 int performDexOpt(PackageParser.Package pkg, List<SharedLibraryInfo> sharedLibraries,
Calin Juravle1d0e83d2017-07-17 15:12:01 -0700134 String[] instructionSets, CompilerStats.PackageStats packageStats,
Calin Juravle3b74c412017-08-03 19:48:37 -0700135 PackageDexUsage.PackageUseInfo packageUseInfo, DexoptOptions options) {
Calin Juravlec6540da2017-11-15 16:28:01 -0800136 if (pkg.applicationInfo.uid == -1) {
137 throw new IllegalArgumentException("Dexopt for " + pkg.packageName
138 + " has invalid uid.");
139 }
Calin Juravle2d4b6ad72017-01-04 13:22:14 -0800140 if (!canOptimizePackage(pkg)) {
141 return DEX_OPT_SKIPPED;
142 }
Andreas Gampea8908752015-11-10 08:58:14 -0800143 synchronized (mInstallLock) {
Fyodor Kupolov28f28552017-05-02 12:11:02 -0700144 final long acquireTime = acquireWakeLockLI(pkg.applicationInfo.uid);
Fyodor Kupolova627c092015-05-05 18:44:39 -0700145 try {
Calin Juravle1d0e83d2017-07-17 15:12:01 -0700146 return performDexOptLI(pkg, sharedLibraries, instructionSets,
Calin Juravle3b74c412017-08-03 19:48:37 -0700147 packageStats, packageUseInfo, options);
Fyodor Kupolova627c092015-05-05 18:44:39 -0700148 } finally {
Fyodor Kupolov28f28552017-05-02 12:11:02 -0700149 releaseWakeLockLI(acquireTime);
Fyodor Kupolova627c092015-05-05 18:44:39 -0700150 }
Fyodor Kupolov74876572015-02-23 17:14:45 -0800151 }
152 }
153
Andreas Gampea8908752015-11-10 08:58:14 -0800154 /**
Calin Juravle2d4b6ad72017-01-04 13:22:14 -0800155 * Performs dexopt on all code paths of the given package.
156 * It assumes the install lock is held.
157 */
158 @GuardedBy("mInstallLock")
Nicolas Geoffray8d144eb2018-11-15 12:59:52 +0000159 private int performDexOptLI(PackageParser.Package pkg,
160 List<SharedLibraryInfo> sharedLibraries,
Calin Juravle1d0e83d2017-07-17 15:12:01 -0700161 String[] targetInstructionSets, CompilerStats.PackageStats packageStats,
Calin Juravle3b74c412017-08-03 19:48:37 -0700162 PackageDexUsage.PackageUseInfo packageUseInfo, DexoptOptions options) {
Calin Juravle2d4b6ad72017-01-04 13:22:14 -0800163 final String[] instructionSets = targetInstructionSets != null ?
164 targetInstructionSets : getAppDexInstructionSets(pkg.applicationInfo);
165 final String[] dexCodeInstructionSets = getDexCodeInstructionSets(instructionSets);
Jeff Hao5def5e52017-04-19 14:42:16 -0700166 final List<String> paths = pkg.getAllCodePaths();
Jeff Sharkeya73e1652017-11-15 19:07:14 -0700167
168 int sharedGid = UserHandle.getSharedAppGid(pkg.applicationInfo.uid);
169 if (sharedGid == -1) {
170 Slog.wtf(TAG, "Well this is awkward; package " + pkg.applicationInfo.name + " had UID "
171 + pkg.applicationInfo.uid, new Throwable());
172 sharedGid = android.os.Process.NOBODY_UID;
173 }
Calin Juravle2d4b6ad72017-01-04 13:22:14 -0800174
Calin Juravle19da1cf2017-07-12 18:52:49 -0700175 // Get the class loader context dependencies.
176 // For each code path in the package, this array contains the class loader context that
177 // needs to be passed to dexopt in order to ensure correct optimizations.
Calin Juravleda098152017-09-01 17:30:01 -0700178 boolean[] pathsWithCode = new boolean[paths.size()];
179 pathsWithCode[0] = (pkg.applicationInfo.flags & ApplicationInfo.FLAG_HAS_CODE) != 0;
180 for (int i = 1; i < paths.size(); i++) {
181 pathsWithCode[i] = (pkg.splitFlags[i - 1] & ApplicationInfo.FLAG_HAS_CODE) != 0;
182 }
Calin Juravle19da1cf2017-07-12 18:52:49 -0700183 String[] classLoaderContexts = DexoptUtils.getClassLoaderContexts(
Calin Juravleda098152017-09-01 17:30:01 -0700184 pkg.applicationInfo, sharedLibraries, pathsWithCode);
Calin Juravle2d4b6ad72017-01-04 13:22:14 -0800185
Calin Juravle4c2b9552017-08-10 17:23:00 -0700186 // Sanity check that we do not call dexopt with inconsistent data.
187 if (paths.size() != classLoaderContexts.length) {
188 String[] splitCodePaths = pkg.applicationInfo.getSplitCodePaths();
189 throw new IllegalStateException("Inconsistent information "
190 + "between PackageParser.Package and its ApplicationInfo. "
191 + "pkg.getAllCodePaths=" + paths
192 + " pkg.applicationInfo.getBaseCodePath=" + pkg.applicationInfo.getBaseCodePath()
193 + " pkg.applicationInfo.getSplitCodePaths="
194 + (splitCodePaths == null ? "null" : Arrays.toString(splitCodePaths)));
195 }
196
Calin Juravle2d4b6ad72017-01-04 13:22:14 -0800197 int result = DEX_OPT_SKIPPED;
Jeff Hao5def5e52017-04-19 14:42:16 -0700198 for (int i = 0; i < paths.size(); i++) {
199 // Skip paths that have no code.
Calin Juravleda098152017-09-01 17:30:01 -0700200 if (!pathsWithCode[i]) {
Jeff Hao5def5e52017-04-19 14:42:16 -0700201 continue;
202 }
Calin Juravleda098152017-09-01 17:30:01 -0700203 if (classLoaderContexts[i] == null) {
204 throw new IllegalStateException("Inconsistent information in the "
205 + "package structure. A split is marked to contain code "
206 + "but has no dependency listed. Index=" + i + " path=" + paths.get(i));
207 }
208
Jeff Hao5def5e52017-04-19 14:42:16 -0700209 // Append shared libraries with split dependencies for this split.
210 String path = paths.get(i);
Calin Juravleb6f844d2017-07-17 15:23:21 -0700211 if (options.getSplitName() != null) {
212 // We are asked to compile only a specific split. Check that the current path is
213 // what we are looking for.
214 if (!options.getSplitName().equals(new File(path).getName())) {
215 continue;
216 }
217 }
218
Calin Juravle6ae39fc2018-01-19 20:32:47 -0800219 String profileName = ArtManager.getProfileName(i == 0 ? null : pkg.splitNames[i - 1]);
220
Calin Juravlecc651942018-02-01 17:20:51 +0000221 String dexMetadataPath = null;
222 if (options.isDexoptInstallWithDexMetadata()) {
223 File dexMetadataFile = DexMetadataHelper.findDexMetadataForFile(new File(path));
224 dexMetadataPath = dexMetadataFile == null
225 ? null : dexMetadataFile.getAbsolutePath();
226 }
227
Calin Juravle3b74c412017-08-03 19:48:37 -0700228 final boolean isUsedByOtherApps = options.isDexoptAsSharedLibrary()
Calin Juravle52a452c2017-08-04 01:42:17 -0700229 || packageUseInfo.isUsedByOtherApps(path);
Calin Juravle3b74c412017-08-03 19:48:37 -0700230 final String compilerFilter = getRealCompilerFilter(pkg.applicationInfo,
231 options.getCompilerFilter(), isUsedByOtherApps);
232 final boolean profileUpdated = options.isCheckForProfileUpdates() &&
Calin Juravle6ae39fc2018-01-19 20:32:47 -0800233 isProfileUpdated(pkg, sharedGid, profileName, compilerFilter);
Calin Juravle3b74c412017-08-03 19:48:37 -0700234
235 // Get the dexopt flags after getRealCompilerFilter to make sure we get the correct
236 // flags.
Andreas Gampec041c332017-11-01 17:05:53 -0700237 final int dexoptFlags = getDexFlags(pkg, compilerFilter, options);
Calin Juravle3b74c412017-08-03 19:48:37 -0700238
Calin Juravle2d4b6ad72017-01-04 13:22:14 -0800239 for (String dexCodeIsa : dexCodeInstructionSets) {
Calin Juravle19da1cf2017-07-12 18:52:49 -0700240 int newResult = dexOptPath(pkg, path, dexCodeIsa, compilerFilter,
241 profileUpdated, classLoaderContexts[i], dexoptFlags, sharedGid,
Calin Juravle4bc8f4d2018-02-12 12:00:44 -0800242 packageStats, options.isDowngrade(), profileName, dexMetadataPath,
243 options.getCompilationReason());
Calin Juravle2d4b6ad72017-01-04 13:22:14 -0800244 // The end result is:
245 // - FAILED if any path failed,
246 // - PERFORMED if at least one path needed compilation,
247 // - SKIPPED when all paths are up to date
248 if ((result != DEX_OPT_FAILED) && (newResult != DEX_OPT_SKIPPED)) {
249 result = newResult;
250 }
251 }
252 }
253 return result;
254 }
255
256 /**
257 * Performs dexopt on the {@code path} belonging to the package {@code pkg}.
258 *
259 * @return
260 * DEX_OPT_FAILED if there was any exception during dexopt
261 * DEX_OPT_PERFORMED if dexopt was performed successfully on the given path.
262 * DEX_OPT_SKIPPED if the path does not need to be deopt-ed.
263 */
264 @GuardedBy("mInstallLock")
265 private int dexOptPath(PackageParser.Package pkg, String path, String isa,
Calin Juravle576e6c02017-09-12 00:58:33 -0700266 String compilerFilter, boolean profileUpdated, String classLoaderContext,
Calin Juravle6ae39fc2018-01-19 20:32:47 -0800267 int dexoptFlags, int uid, CompilerStats.PackageStats packageStats, boolean downgrade,
Calin Juravle4bc8f4d2018-02-12 12:00:44 -0800268 String profileName, String dexMetadataPath, int compilationReason) {
Calin Juravle576e6c02017-09-12 00:58:33 -0700269 int dexoptNeeded = getDexoptNeeded(path, isa, compilerFilter, classLoaderContext,
270 profileUpdated, downgrade);
Calin Juravle2d4b6ad72017-01-04 13:22:14 -0800271 if (Math.abs(dexoptNeeded) == DexFile.NO_DEXOPT_NEEDED) {
272 return DEX_OPT_SKIPPED;
273 }
274
275 // TODO(calin): there's no need to try to create the oat dir over and over again,
276 // especially since it involve an extra installd call. We should create
277 // if (if supported) on the fly during the dexopt call.
278 String oatDir = createOatDirIfSupported(pkg, isa);
279
280 Log.i(TAG, "Running dexopt (dexoptNeeded=" + dexoptNeeded + ") on: " + path
281 + " pkg=" + pkg.applicationInfo.packageName + " isa=" + isa
282 + " dexoptFlags=" + printDexoptFlags(dexoptFlags)
Calin Juravle576e6c02017-09-12 00:58:33 -0700283 + " targetFilter=" + compilerFilter + " oatDir=" + oatDir
284 + " classLoaderContext=" + classLoaderContext);
Calin Juravle2d4b6ad72017-01-04 13:22:14 -0800285
286 try {
287 long startTime = System.currentTimeMillis();
288
Shubham Ajmera246dccf2017-05-24 17:46:36 -0700289 // TODO: Consider adding 2 different APIs for primary and secondary dexopt.
290 // installd only uses downgrade flag for secondary dex files and ignores it for
291 // primary dex files.
Calin Juravle2d4b6ad72017-01-04 13:22:14 -0800292 mInstaller.dexopt(path, uid, pkg.packageName, isa, dexoptNeeded, oatDir, dexoptFlags,
Calin Juravle576e6c02017-09-12 00:58:33 -0700293 compilerFilter, pkg.volumeUuid, classLoaderContext, pkg.applicationInfo.seInfo,
Calin Juravle6ae39fc2018-01-19 20:32:47 -0800294 false /* downgrade*/, pkg.applicationInfo.targetSdkVersion,
Calin Juravle0610dd12018-07-20 15:51:17 -0700295 profileName, dexMetadataPath,
296 getAugmentedReasonName(compilationReason, dexMetadataPath != null));
Calin Juravle2d4b6ad72017-01-04 13:22:14 -0800297
298 if (packageStats != null) {
299 long endTime = System.currentTimeMillis();
300 packageStats.setCompileTime(path, (int)(endTime - startTime));
301 }
302 return DEX_OPT_PERFORMED;
303 } catch (InstallerException e) {
304 Slog.w(TAG, "Failed to dexopt", e);
305 return DEX_OPT_FAILED;
306 }
307 }
308
Calin Juravle0610dd12018-07-20 15:51:17 -0700309 private String getAugmentedReasonName(int compilationReason, boolean useDexMetadata) {
310 String annotation = useDexMetadata
311 ? ArtManagerService.DEXOPT_REASON_WITH_DEX_METADATA_ANNOTATION : "";
312 return getReasonName(compilationReason) + annotation;
313 }
314
Calin Juravle2d4b6ad72017-01-04 13:22:14 -0800315 /**
Calin Juravlec22c30e2017-01-16 19:18:48 -0800316 * Performs dexopt on the secondary dex {@code path} belonging to the app {@code info}.
317 *
318 * @return
319 * DEX_OPT_FAILED if there was any exception during dexopt
320 * DEX_OPT_PERFORMED if dexopt was performed successfully on the given path.
321 * NOTE that DEX_OPT_PERFORMED for secondary dex files includes the case when the dex file
322 * didn't need an update. That's because at the moment we don't get more than success/failure
323 * from installd.
324 *
325 * TODO(calin): Consider adding return codes to installd dexopt invocation (rather than
326 * throwing exceptions). Or maybe make a separate call to installd to get DexOptNeeded, though
327 * that seems wasteful.
328 */
Calin Juravlef1ff36f2017-07-22 12:33:41 -0700329 public int dexOptSecondaryDexPath(ApplicationInfo info, String path,
330 PackageDexUsage.DexUseInfo dexUseInfo, DexoptOptions options) {
Calin Juravlec6540da2017-11-15 16:28:01 -0800331 if (info.uid == -1) {
332 throw new IllegalArgumentException("Dexopt for path " + path + " has invalid uid.");
333 }
Calin Juravlec22c30e2017-01-16 19:18:48 -0800334 synchronized (mInstallLock) {
Fyodor Kupolov28f28552017-05-02 12:11:02 -0700335 final long acquireTime = acquireWakeLockLI(info.uid);
Calin Juravlec22c30e2017-01-16 19:18:48 -0800336 try {
Calin Juravlef1ff36f2017-07-22 12:33:41 -0700337 return dexOptSecondaryDexPathLI(info, path, dexUseInfo, options);
Calin Juravlec22c30e2017-01-16 19:18:48 -0800338 } finally {
Fyodor Kupolov28f28552017-05-02 12:11:02 -0700339 releaseWakeLockLI(acquireTime);
Calin Juravlec22c30e2017-01-16 19:18:48 -0800340 }
341 }
342 }
343
344 @GuardedBy("mInstallLock")
Fyodor Kupolov28f28552017-05-02 12:11:02 -0700345 private long acquireWakeLockLI(final int uid) {
346 // During boot the system doesn't need to instantiate and obtain a wake lock.
347 // PowerManager might not be ready, but that doesn't mean that we can't proceed with
348 // dexopt.
349 if (!mSystemReady) {
350 return -1;
351 }
352 mDexoptWakeLock.setWorkSource(new WorkSource(uid));
353 mDexoptWakeLock.acquire(WAKELOCK_TIMEOUT_MS);
354 return SystemClock.elapsedRealtime();
355 }
356
357 @GuardedBy("mInstallLock")
358 private void releaseWakeLockLI(final long acquireTime) {
359 if (acquireTime < 0) {
360 return;
361 }
362 try {
363 if (mDexoptWakeLock.isHeld()) {
364 mDexoptWakeLock.release();
365 }
366 final long duration = SystemClock.elapsedRealtime() - acquireTime;
367 if (duration >= WAKELOCK_TIMEOUT_MS) {
368 Slog.wtf(TAG, "WakeLock " + mDexoptWakeLock.getTag()
369 + " time out. Operation took " + duration + " ms. Thread: "
370 + Thread.currentThread().getName());
371 }
372 } catch (Exception e) {
373 Slog.wtf(TAG, "Error while releasing " + mDexoptWakeLock.getTag() + " lock", e);
374 }
375 }
376
377 @GuardedBy("mInstallLock")
Calin Juravlef1ff36f2017-07-22 12:33:41 -0700378 private int dexOptSecondaryDexPathLI(ApplicationInfo info, String path,
379 PackageDexUsage.DexUseInfo dexUseInfo, DexoptOptions options) {
380 if (options.isDexoptOnlySharedDex() && !dexUseInfo.isUsedByOtherApps()) {
381 // We are asked to optimize only the dex files used by other apps and this is not
382 // on of them: skip it.
383 return DEX_OPT_SKIPPED;
384 }
385
386 String compilerFilter = getRealCompilerFilter(info, options.getCompilerFilter(),
387 dexUseInfo.isUsedByOtherApps());
Calin Juravleefb1c942017-04-04 20:31:44 -0700388 // Get the dexopt flags after getRealCompilerFilter to make sure we get the correct flags.
Nicolas Geoffray3b4359a2017-05-25 13:53:22 +0100389 // Secondary dex files are currently not compiled at boot.
Andreas Gampec041c332017-11-01 17:05:53 -0700390 int dexoptFlags = getDexFlags(info, compilerFilter, options) | DEXOPT_SECONDARY_DEX;
Calin Juravlec22c30e2017-01-16 19:18:48 -0800391 // Check the app storage and add the appropriate flags.
Calin Juravleadbadd52017-03-28 18:19:15 -0700392 if (info.deviceProtectedDataDir != null &&
393 FileUtils.contains(info.deviceProtectedDataDir, path)) {
Calin Juravlec22c30e2017-01-16 19:18:48 -0800394 dexoptFlags |= DEXOPT_STORAGE_DE;
Calin Juravleadbadd52017-03-28 18:19:15 -0700395 } else if (info.credentialProtectedDataDir != null &&
396 FileUtils.contains(info.credentialProtectedDataDir, path)) {
Calin Juravlec22c30e2017-01-16 19:18:48 -0800397 dexoptFlags |= DEXOPT_STORAGE_CE;
398 } else {
399 Slog.e(TAG, "Could not infer CE/DE storage for package " + info.packageName);
400 return DEX_OPT_FAILED;
401 }
Calin Juravlec22c30e2017-01-16 19:18:48 -0800402 Log.d(TAG, "Running dexopt on: " + path
Calin Juravlef1ff36f2017-07-22 12:33:41 -0700403 + " pkg=" + info.packageName + " isa=" + dexUseInfo.getLoaderIsas()
Calin Juravlec22c30e2017-01-16 19:18:48 -0800404 + " dexoptFlags=" + printDexoptFlags(dexoptFlags)
405 + " target-filter=" + compilerFilter);
406
Calin Juravle27f92622017-10-04 10:53:09 -0700407 // TODO(calin): b/64530081 b/66984396. Use SKIP_SHARED_LIBRARY_CHECK for the context
408 // (instead of dexUseInfo.getClassLoaderContext()) in order to compile secondary dex files
409 // in isolation (and avoid to extract/verify the main apk if it's in the class path).
410 // Note this trades correctness for performance since the resulting slow down is
411 // unacceptable in some cases until b/64530081 is fixed.
412 String classLoaderContext = SKIP_SHARED_LIBRARY_CHECK;
Calin Juravle4bc8f4d2018-02-12 12:00:44 -0800413 int reason = options.getCompilationReason();
Calin Juravlec22c30e2017-01-16 19:18:48 -0800414 try {
Calin Juravlef1ff36f2017-07-22 12:33:41 -0700415 for (String isa : dexUseInfo.getLoaderIsas()) {
Calin Juravlec22c30e2017-01-16 19:18:48 -0800416 // Reuse the same dexopt path as for the primary apks. We don't need all the
417 // arguments as some (dexopNeeded and oatDir) will be computed by installd because
418 // system server cannot read untrusted app content.
419 // TODO(calin): maybe add a separate call.
420 mInstaller.dexopt(path, info.uid, info.packageName, isa, /*dexoptNeeded*/ 0,
421 /*oatDir*/ null, dexoptFlags,
Nick Kralevich005f9592018-08-14 11:11:02 -0700422 compilerFilter, info.volumeUuid, classLoaderContext, info.seInfo,
Calin Juravlecc651942018-02-01 17:20:51 +0000423 options.isDowngrade(), info.targetSdkVersion, /*profileName*/ null,
Calin Juravle4bc8f4d2018-02-12 12:00:44 -0800424 /*dexMetadataPath*/ null, getReasonName(reason));
Calin Juravlec22c30e2017-01-16 19:18:48 -0800425 }
426
427 return DEX_OPT_PERFORMED;
428 } catch (InstallerException e) {
429 Slog.w(TAG, "Failed to dexopt", e);
430 return DEX_OPT_FAILED;
431 }
432 }
433
434 /**
Andreas Gampea8908752015-11-10 08:58:14 -0800435 * Adjust the given dexopt-needed value. Can be overridden to influence the decision to
436 * optimize or not (and in what way).
437 */
438 protected int adjustDexoptNeeded(int dexoptNeeded) {
439 return dexoptNeeded;
440 }
441
442 /**
443 * Adjust the given dexopt flags that will be passed to the installer.
444 */
445 protected int adjustDexoptFlags(int dexoptFlags) {
446 return dexoptFlags;
447 }
448
Narayan Kamath88eea9e2016-05-02 14:44:31 +0100449 /**
450 * Dumps the dexopt state of the given package {@code pkg} to the given {@code PrintWriter}.
451 */
Calin Juravle41a57a62017-08-06 19:20:19 -0700452 void dumpDexoptState(IndentingPrintWriter pw, PackageParser.Package pkg,
453 PackageDexUsage.PackageUseInfo useInfo) {
Narayan Kamath88eea9e2016-05-02 14:44:31 +0100454 final String[] instructionSets = getAppDexInstructionSets(pkg.applicationInfo);
455 final String[] dexCodeInstructionSets = getDexCodeInstructionSets(instructionSets);
456
457 final List<String> paths = pkg.getAllCodePathsExcludingResourceOnly();
458
Calin Juravle41a57a62017-08-06 19:20:19 -0700459 for (String path : paths) {
460 pw.println("path: " + path);
461 pw.increaseIndent();
462
463 for (String isa : dexCodeInstructionSets) {
Calin Juravle41a57a62017-08-06 19:20:19 -0700464 try {
Calin Juravle7fc0f632018-03-30 12:38:59 -0700465 DexFile.OptimizationInfo info = DexFile.getDexFileOptimizationInfo(path, isa);
466 pw.println(isa + ": [status=" + info.getStatus()
467 +"] [reason=" + info.getReason() + "]");
Calin Juravle41a57a62017-08-06 19:20:19 -0700468 } catch (IOException ioe) {
Calin Juravleab49fc42018-03-28 19:00:18 -0700469 pw.println(isa + ": [Exception]: " + ioe.getMessage());
Calin Juravle41a57a62017-08-06 19:20:19 -0700470 }
Calin Juravle41a57a62017-08-06 19:20:19 -0700471 }
472
473 if (useInfo.isUsedByOtherApps(path)) {
Calin Juravle94837e32017-09-26 13:23:00 -0700474 pw.println("used by other apps: " + useInfo.getLoadingPackages(path));
Calin Juravle41a57a62017-08-06 19:20:19 -0700475 }
476
477 Map<String, PackageDexUsage.DexUseInfo> dexUseInfoMap = useInfo.getDexUseInfoMap();
478
479 if (!dexUseInfoMap.isEmpty()) {
480 pw.println("known secondary dex files:");
481 pw.increaseIndent();
482 for (Map.Entry<String, PackageDexUsage.DexUseInfo> e : dexUseInfoMap.entrySet()) {
483 String dex = e.getKey();
484 PackageDexUsage.DexUseInfo dexUseInfo = e.getValue();
485 pw.println(dex);
486 pw.increaseIndent();
Calin Juravlecf722222017-09-18 17:40:48 -0700487 // TODO(calin): get the status of the oat file (needs installd call)
Calin Juravle41a57a62017-08-06 19:20:19 -0700488 pw.println("class loader context: " + dexUseInfo.getClassLoaderContext());
489 if (dexUseInfo.isUsedByOtherApps()) {
Calin Juravle94837e32017-09-26 13:23:00 -0700490 pw.println("used by other apps: " + dexUseInfo.getLoadingPackages());
Calin Juravle41a57a62017-08-06 19:20:19 -0700491 }
492 pw.decreaseIndent();
493 }
494 pw.decreaseIndent();
495 }
496 pw.decreaseIndent();
Narayan Kamath88eea9e2016-05-02 14:44:31 +0100497 }
498 }
499
Calin Juravle2d4b6ad72017-01-04 13:22:14 -0800500 /**
501 * Returns the compiler filter that should be used to optimize the package code.
502 * The target filter will be updated if the package code is used by other apps
503 * or if it has the safe mode flag set.
504 */
Calin Juravlec22c30e2017-01-16 19:18:48 -0800505 private String getRealCompilerFilter(ApplicationInfo info, String targetCompilerFilter,
506 boolean isUsedByOtherApps) {
507 int flags = info.flags;
Calin Juravle2d4b6ad72017-01-04 13:22:14 -0800508 boolean vmSafeMode = (flags & ApplicationInfo.FLAG_VM_SAFE_MODE) != 0;
Victor Hsieh785d6182018-04-19 14:26:28 -0700509 // When a priv app is configured to run out of box, only verify it.
510 if (info.isPrivilegedApp() && DexManager.isPackageSelectedToRunOob(info.packageName)) {
511 return "verify";
Nicolas Geoffray11d21a292018-01-24 14:07:14 +0000512 }
Mathieu Chartier41e4a372016-09-02 16:36:42 -0700513 if (vmSafeMode) {
Nicolas Geoffrayd093b202017-05-03 13:11:58 +0100514 return getSafeModeCompilerFilter(targetCompilerFilter);
Mathieu Chartier41e4a372016-09-02 16:36:42 -0700515 }
516
Calin Juravlec22c30e2017-01-16 19:18:48 -0800517 if (isProfileGuidedCompilerFilter(targetCompilerFilter) && isUsedByOtherApps) {
Calin Juravlef53201f2017-09-15 11:09:29 -0700518 // If the dex files is used by other apps, apply the shared filter.
519 return PackageManagerServiceCompilerMapping.getCompilerFilterForReason(
520 PackageManagerService.REASON_SHARED);
Andreas Gampebdd30d82016-03-20 11:32:11 -0700521 }
522
Calin Juravle2d4b6ad72017-01-04 13:22:14 -0800523 return targetCompilerFilter;
Fyodor Kupolov74876572015-02-23 17:14:45 -0800524 }
525
Fyodor Kupolovb94c1652015-03-03 12:25:30 -0800526 /**
Calin Juravle2d4b6ad72017-01-04 13:22:14 -0800527 * Computes the dex flags that needs to be pass to installd for the given package and compiler
528 * filter.
529 */
Nicolas Geoffray3b4359a2017-05-25 13:53:22 +0100530 private int getDexFlags(PackageParser.Package pkg, String compilerFilter,
Andreas Gampec041c332017-11-01 17:05:53 -0700531 DexoptOptions options) {
532 return getDexFlags(pkg.applicationInfo, compilerFilter, options);
Calin Juravlec22c30e2017-01-16 19:18:48 -0800533 }
534
Mathieu Chartiera9c34332018-03-12 17:11:07 -0700535 private boolean isAppImageEnabled() {
536 return SystemProperties.get("dalvik.vm.appimageformat", "").length() > 0;
537 }
538
Andreas Gampec041c332017-11-01 17:05:53 -0700539 private int getDexFlags(ApplicationInfo info, String compilerFilter, DexoptOptions options) {
Calin Juravlec22c30e2017-01-16 19:18:48 -0800540 int flags = info.flags;
Calin Juravle2d4b6ad72017-01-04 13:22:14 -0800541 boolean debuggable = (flags & ApplicationInfo.FLAG_DEBUGGABLE) != 0;
Calin Juravleff3e4a12018-02-01 17:23:13 +0000542 // Profile guide compiled oat files should not be public unles they are based
543 // on profiles from dex metadata archives.
544 // The flag isDexoptInstallWithDexMetadata applies only on installs when we know that
545 // the user does not have an existing profile.
Calin Juravle2d4b6ad72017-01-04 13:22:14 -0800546 boolean isProfileGuidedFilter = isProfileGuidedCompilerFilter(compilerFilter);
Calin Juravleff3e4a12018-02-01 17:23:13 +0000547 boolean isPublic = !info.isForwardLocked() &&
548 (!isProfileGuidedFilter || options.isDexoptInstallWithDexMetadata());
Calin Juravle2d4b6ad72017-01-04 13:22:14 -0800549 int profileFlag = isProfileGuidedFilter ? DEXOPT_PROFILE_GUIDED : 0;
David Brazdilf7e31c02018-02-13 17:04:26 +0000550 // Some apps are executed with restrictions on hidden API usage. If this app is one
551 // of them, pass a flag to dexopt to enable the same restrictions during compilation.
Mathew Inwoode3299532018-02-22 13:19:53 +0000552 // TODO we should pass the actual flag value to dexopt, rather than assuming blacklist
David Brazdil06ae4b82018-11-02 18:01:45 +0000553 int hiddenApiFlag = info.getHiddenApiEnforcementPolicy() == HIDDEN_API_ENFORCEMENT_DISABLED
Mathew Inwoode3299532018-02-22 13:19:53 +0000554 ? 0
555 : DEXOPT_ENABLE_HIDDEN_API_CHECKS;
Mathieu Chartiera6d43e42018-03-08 13:11:40 -0800556 // Avoid generating CompactDex for modes that are latency critical.
Mathieu Chartierfa3e9762018-03-06 18:28:22 -0800557 final int compilationReason = options.getCompilationReason();
558 boolean generateCompactDex = true;
559 switch (compilationReason) {
560 case PackageManagerService.REASON_FIRST_BOOT:
561 case PackageManagerService.REASON_BOOT:
562 case PackageManagerService.REASON_INSTALL:
563 generateCompactDex = false;
564 }
Mathieu Chartiera9c34332018-03-12 17:11:07 -0700565 // Use app images only if it is enabled and we are compiling
566 // profile-guided (so the app image doesn't conservatively contain all classes).
567 // If the app didn't request for the splits to be loaded in isolation or if it does not
568 // declare inter-split dependencies, then all the splits will be loaded in the base
569 // apk class loader (in the order of their definition, otherwise disable app images
570 // because they are unsupported for multiple class loaders. b/7269679
571 boolean generateAppImage = isProfileGuidedFilter && (info.splitDependencies == null ||
572 !info.requestsIsolatedSplitLoading()) && isAppImageEnabled();
Calin Juravle2d4b6ad72017-01-04 13:22:14 -0800573 int dexFlags =
574 (isPublic ? DEXOPT_PUBLIC : 0)
Calin Juravle2d4b6ad72017-01-04 13:22:14 -0800575 | (debuggable ? DEXOPT_DEBUGGABLE : 0)
576 | profileFlag
Andreas Gampec041c332017-11-01 17:05:53 -0700577 | (options.isBootComplete() ? DEXOPT_BOOTCOMPLETE : 0)
David Brazdil464ed3d2018-01-18 15:25:18 +0000578 | (options.isDexoptIdleBackgroundJob() ? DEXOPT_IDLE_BACKGROUND_JOB : 0)
Mathieu Chartierfa3e9762018-03-06 18:28:22 -0800579 | (generateCompactDex ? DEXOPT_GENERATE_COMPACT_DEX : 0)
Mathieu Chartiera9c34332018-03-12 17:11:07 -0700580 | (generateAppImage ? DEXOPT_GENERATE_APP_IMAGE : 0)
David Brazdil464ed3d2018-01-18 15:25:18 +0000581 | hiddenApiFlag;
Calin Juravle2d4b6ad72017-01-04 13:22:14 -0800582 return adjustDexoptFlags(dexFlags);
583 }
584
585 /**
586 * Assesses if there's a need to perform dexopt on {@code path} for the given
587 * configuration (isa, compiler filter, profile).
588 */
589 private int getDexoptNeeded(String path, String isa, String compilerFilter,
Calin Juravle576e6c02017-09-12 00:58:33 -0700590 String classLoaderContext, boolean newProfile, boolean downgrade) {
Calin Juravle2d4b6ad72017-01-04 13:22:14 -0800591 int dexoptNeeded;
592 try {
Calin Juravle576e6c02017-09-12 00:58:33 -0700593 dexoptNeeded = DexFile.getDexOptNeeded(path, isa, compilerFilter, classLoaderContext,
594 newProfile, downgrade);
Calin Juravle2d4b6ad72017-01-04 13:22:14 -0800595 } catch (IOException ioe) {
596 Slog.w(TAG, "IOException reading apk: " + path, ioe);
597 return DEX_OPT_FAILED;
598 }
599 return adjustDexoptNeeded(dexoptNeeded);
600 }
601
602 /**
Calin Juravle2d4b6ad72017-01-04 13:22:14 -0800603 * Checks if there is an update on the profile information of the {@code pkg}.
604 * If the compiler filter is not profile guided the method returns false.
605 *
606 * Note that this is a "destructive" operation with side effects. Under the hood the
607 * current profile and the reference profile will be merged and subsequent calls
608 * may return a different result.
609 */
Calin Juravle6ae39fc2018-01-19 20:32:47 -0800610 private boolean isProfileUpdated(PackageParser.Package pkg, int uid, String profileName,
611 String compilerFilter) {
Calin Juravle2d4b6ad72017-01-04 13:22:14 -0800612 // Check if we are allowed to merge and if the compiler filter is profile guided.
613 if (!isProfileGuidedCompilerFilter(compilerFilter)) {
614 return false;
615 }
616 // Merge profiles. It returns whether or not there was an updated in the profile info.
617 try {
Calin Juravle6ae39fc2018-01-19 20:32:47 -0800618 return mInstaller.mergeProfiles(uid, pkg.packageName, profileName);
Calin Juravle2d4b6ad72017-01-04 13:22:14 -0800619 } catch (InstallerException e) {
620 Slog.w(TAG, "Failed to merge profiles", e);
621 }
622 return false;
623 }
624
625 /**
626 * Creates oat dir for the specified package if needed and supported.
627 * In certain cases oat directory
Fyodor Kupolovb94c1652015-03-03 12:25:30 -0800628 * <strong>cannot</strong> be created:
629 * <ul>
630 * <li>{@code pkg} is a system app, which is not updated.</li>
631 * <li>Package location is not a directory, i.e. monolithic install.</li>
632 * </ul>
633 *
Richard Uhler7b08b352015-03-25 16:25:57 -0700634 * @return Absolute path to the oat directory or null, if oat directory
635 * cannot be created.
Fyodor Kupolovb94c1652015-03-03 12:25:30 -0800636 */
637 @Nullable
Todd Kennedy27c24fb2015-09-17 16:49:25 -0700638 private String createOatDirIfSupported(PackageParser.Package pkg, String dexInstructionSet) {
Fyodor Kupolovebcac162015-09-09 15:56:45 -0700639 if (!pkg.canHaveOatDir()) {
Fyodor Kupolovb94c1652015-03-03 12:25:30 -0800640 return null;
641 }
642 File codePath = new File(pkg.codePath);
643 if (codePath.isDirectory()) {
Calin Juravle2d4b6ad72017-01-04 13:22:14 -0800644 // TODO(calin): why do we create this only if the codePath is a directory? (i.e for
645 // cluster packages). It seems that the logic for the folder creation is
646 // split between installd and here.
Fyodor Kupolovb94c1652015-03-03 12:25:30 -0800647 File oatDir = getOatDir(codePath);
Jeff Sharkeyfdeeeea2016-01-11 17:34:24 -0700648 try {
Andreas Gampea8908752015-11-10 08:58:14 -0800649 mInstaller.createOatDir(oatDir.getAbsolutePath(), dexInstructionSet);
Jeff Sharkeyfdeeeea2016-01-11 17:34:24 -0700650 } catch (InstallerException e) {
651 Slog.w(TAG, "Failed to create oat dir", e);
652 return null;
653 }
Richard Uhler7b08b352015-03-25 16:25:57 -0700654 return oatDir.getAbsolutePath();
Fyodor Kupolovb94c1652015-03-03 12:25:30 -0800655 }
656 return null;
657 }
658
659 static File getOatDir(File codePath) {
660 return new File(codePath, OAT_DIR_NAME);
661 }
662
Fyodor Kupolova627c092015-05-05 18:44:39 -0700663 void systemReady() {
664 mSystemReady = true;
665 }
Andreas Gampea8908752015-11-10 08:58:14 -0800666
Calin Juravle2d4b6ad72017-01-04 13:22:14 -0800667 private String printDexoptFlags(int flags) {
668 ArrayList<String> flagsList = new ArrayList<>();
669
670 if ((flags & DEXOPT_BOOTCOMPLETE) == DEXOPT_BOOTCOMPLETE) {
671 flagsList.add("boot_complete");
672 }
673 if ((flags & DEXOPT_DEBUGGABLE) == DEXOPT_DEBUGGABLE) {
674 flagsList.add("debuggable");
675 }
676 if ((flags & DEXOPT_PROFILE_GUIDED) == DEXOPT_PROFILE_GUIDED) {
677 flagsList.add("profile_guided");
678 }
679 if ((flags & DEXOPT_PUBLIC) == DEXOPT_PUBLIC) {
680 flagsList.add("public");
681 }
Calin Juravlec22c30e2017-01-16 19:18:48 -0800682 if ((flags & DEXOPT_SECONDARY_DEX) == DEXOPT_SECONDARY_DEX) {
683 flagsList.add("secondary");
684 }
685 if ((flags & DEXOPT_FORCE) == DEXOPT_FORCE) {
686 flagsList.add("force");
687 }
688 if ((flags & DEXOPT_STORAGE_CE) == DEXOPT_STORAGE_CE) {
689 flagsList.add("storage_ce");
690 }
691 if ((flags & DEXOPT_STORAGE_DE) == DEXOPT_STORAGE_DE) {
692 flagsList.add("storage_de");
693 }
David Sehr2118ec42017-10-25 14:28:29 -0700694 if ((flags & DEXOPT_IDLE_BACKGROUND_JOB) == DEXOPT_IDLE_BACKGROUND_JOB) {
695 flagsList.add("idle_background_job");
696 }
David Brazdilf7e31c02018-02-13 17:04:26 +0000697 if ((flags & DEXOPT_ENABLE_HIDDEN_API_CHECKS) == DEXOPT_ENABLE_HIDDEN_API_CHECKS) {
698 flagsList.add("enable_hidden_api_checks");
David Brazdil464ed3d2018-01-18 15:25:18 +0000699 }
Calin Juravlec22c30e2017-01-16 19:18:48 -0800700
Calin Juravle2d4b6ad72017-01-04 13:22:14 -0800701 return String.join(",", flagsList);
702 }
703
Andreas Gampea8908752015-11-10 08:58:14 -0800704 /**
705 * A specialized PackageDexOptimizer that overrides already-installed checks, forcing a
706 * dexopt path.
707 */
708 public static class ForcedUpdatePackageDexOptimizer extends PackageDexOptimizer {
709
710 public ForcedUpdatePackageDexOptimizer(Installer installer, Object installLock,
711 Context context, String wakeLockTag) {
712 super(installer, installLock, context, wakeLockTag);
713 }
714
715 public ForcedUpdatePackageDexOptimizer(PackageDexOptimizer from) {
716 super(from);
717 }
718
719 @Override
Andreas Gampea8908752015-11-10 08:58:14 -0800720 protected int adjustDexoptNeeded(int dexoptNeeded) {
Nicolas Geoffray96d12a92017-05-03 11:51:53 +0100721 if (dexoptNeeded == DexFile.NO_DEXOPT_NEEDED) {
722 // Ensure compilation by pretending a compiler filter change on the
723 // apk/odex location (the reason for the '-'. A positive value means
724 // the 'oat' location).
725 return -DexFile.DEX2OAT_FOR_FILTER;
726 }
727 return dexoptNeeded;
Andreas Gampea8908752015-11-10 08:58:14 -0800728 }
Calin Juravlec22c30e2017-01-16 19:18:48 -0800729
730 @Override
731 protected int adjustDexoptFlags(int flags) {
732 // Add DEXOPT_FORCE flag to signal installd that it should force compilation
733 // and discard dexoptanalyzer result.
734 return flags | DEXOPT_FORCE;
735 }
Andreas Gampea8908752015-11-10 08:58:14 -0800736 }
Fyodor Kupolov74876572015-02-23 17:14:45 -0800737}