blob: 46ad7cbe49e9227e081a77c82d82add923f4661b [file] [log] [blame]
Adam Lesinski6f6ceb72014-11-14 14:48:12 -08001/*
2 * Copyright (C) 2015 The Android Open Source Project
3 *
4 * Licensed under the Apache License, Version 2.0 (the "License");
5 * you may not use this file except in compliance with the License.
6 * You may obtain a copy of the License at
7 *
8 * http://www.apache.org/licenses/LICENSE-2.0
9 *
10 * Unless required by applicable law or agreed to in writing, software
11 * distributed under the License is distributed on an "AS IS" BASIS,
12 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13 * See the License for the specific language governing permissions and
14 * limitations under the License.
15 */
16
17#include "ResourceParser.h"
Adam Lesinskice5e56e2016-10-21 17:56:45 -070018
19#include <sstream>
20#include <string>
21
Adam Lesinski6f6ceb72014-11-14 14:48:12 -080022#include "ResourceTable.h"
Adam Lesinski1ab598f2015-08-14 14:26:04 -070023#include "ResourceUtils.h"
Adam Lesinski6f6ceb72014-11-14 14:48:12 -080024#include "ResourceValues.h"
Adam Lesinski00451162017-10-03 07:44:08 -070025#include "io/StringStream.h"
Adam Lesinskid0f116b2016-07-08 15:00:32 -070026#include "test/Test.h"
Adam Lesinski467f1712015-11-16 17:35:44 -080027#include "xml/XmlPullParser.h"
Adam Lesinski6f6ceb72014-11-14 14:48:12 -080028
Adam Lesinskiefeb7af2017-08-02 14:57:43 -070029using ::aapt::io::StringInputStream;
Adam Lesinskia45893a2017-05-30 15:19:02 -070030using ::aapt::test::StrValueEq;
Adam Lesinskibab4ef52017-06-01 15:22:57 -070031using ::aapt::test::ValueEq;
MÃ¥rten Kongstad24c9aa62018-06-20 08:46:41 +020032using ::android::ConfigDescription;
Adam Lesinskia45893a2017-05-30 15:19:02 -070033using ::android::Res_value;
Adam Lesinski71be7052017-12-12 16:48:07 -080034using ::android::ResTable_map;
Adam Lesinskie597d682017-06-01 17:16:44 -070035using ::android::StringPiece;
36using ::testing::Eq;
Adam Lesinskia45893a2017-05-30 15:19:02 -070037using ::testing::IsEmpty;
38using ::testing::IsNull;
Adam Lesinskie597d682017-06-01 17:16:44 -070039using ::testing::NotNull;
Adam Lesinskibab4ef52017-06-01 15:22:57 -070040using ::testing::Pointee;
Adam Lesinskia45893a2017-05-30 15:19:02 -070041using ::testing::SizeIs;
Adam Lesinski71be7052017-12-12 16:48:07 -080042using ::testing::StrEq;
Adam Lesinskid5083f62017-01-16 15:07:21 -080043
Adam Lesinski6f6ceb72014-11-14 14:48:12 -080044namespace aapt {
45
Adam Lesinskibab4ef52017-06-01 15:22:57 -070046constexpr const char* kXmlPreamble = "<?xml version=\"1.0\" encoding=\"utf-8\"?>\n";
Adam Lesinski6f6ceb72014-11-14 14:48:12 -080047
Adam Lesinski1ab598f2015-08-14 14:26:04 -070048TEST(ResourceParserSingleTest, FailToParseWithNoRootResourcesElement) {
Adam Lesinskice5e56e2016-10-21 17:56:45 -070049 std::unique_ptr<IAaptContext> context = test::ContextBuilder().Build();
Adam Lesinskicacb28f2016-10-19 12:18:14 -070050 ResourceTable table;
Adam Lesinskice5e56e2016-10-21 17:56:45 -070051 ResourceParser parser(context->GetDiagnostics(), &table, Source{"test"}, {});
Adam Lesinskiefeb7af2017-08-02 14:57:43 -070052
53 std::string input = kXmlPreamble;
54 input += R"(<attr name="foo"/>)";
55 StringInputStream in(input);
56 xml::XmlPullParser xml_parser(&in);
Adam Lesinskice5e56e2016-10-21 17:56:45 -070057 ASSERT_FALSE(parser.Parse(&xml_parser));
Adam Lesinski769de982015-04-10 19:43:55 -070058}
59
Adam Lesinskice5e56e2016-10-21 17:56:45 -070060class ResourceParserTest : public ::testing::Test {
61 public:
Adam Lesinskibab4ef52017-06-01 15:22:57 -070062 void SetUp() override {
63 context_ = test::ContextBuilder().Build();
64 }
Adam Lesinski1ab598f2015-08-14 14:26:04 -070065
Adam Lesinskice5e56e2016-10-21 17:56:45 -070066 ::testing::AssertionResult TestParse(const StringPiece& str) {
67 return TestParse(str, ConfigDescription{});
Adam Lesinskicacb28f2016-10-19 12:18:14 -070068 }
Adam Lesinski52364f72016-01-11 13:10:24 -080069
Adam Lesinskibab4ef52017-06-01 15:22:57 -070070 ::testing::AssertionResult TestParse(const StringPiece& str, const ConfigDescription& config) {
Adam Lesinskicacb28f2016-10-19 12:18:14 -070071 ResourceParserOptions parserOptions;
Adam Lesinskibab4ef52017-06-01 15:22:57 -070072 ResourceParser parser(context_->GetDiagnostics(), &table_, Source{"test"}, config,
73 parserOptions);
Adam Lesinskiefeb7af2017-08-02 14:57:43 -070074
75 std::string input = kXmlPreamble;
76 input += "<resources>\n";
77 input.append(str.data(), str.size());
78 input += "\n</resources>";
79 StringInputStream in(input);
80 xml::XmlPullParser xmlParser(&in);
Adam Lesinskice5e56e2016-10-21 17:56:45 -070081 if (parser.Parse(&xmlParser)) {
Adam Lesinskicacb28f2016-10-19 12:18:14 -070082 return ::testing::AssertionSuccess();
Adam Lesinski6f6ceb72014-11-14 14:48:12 -080083 }
Adam Lesinskicacb28f2016-10-19 12:18:14 -070084 return ::testing::AssertionFailure();
85 }
Adam Lesinskice5e56e2016-10-21 17:56:45 -070086
87 protected:
88 ResourceTable table_;
89 std::unique_ptr<IAaptContext> context_;
Adam Lesinski6f6ceb72014-11-14 14:48:12 -080090};
91
Adam Lesinski6f6ceb72014-11-14 14:48:12 -080092TEST_F(ResourceParserTest, ParseQuotedString) {
Adam Lesinskia45893a2017-05-30 15:19:02 -070093 ASSERT_TRUE(TestParse(R"(<string name="foo"> " hey there " </string>)"));
Adam Lesinski6f6ceb72014-11-14 14:48:12 -080094
Adam Lesinskice5e56e2016-10-21 17:56:45 -070095 String* str = test::GetValue<String>(&table_, "string/foo");
Adam Lesinskia45893a2017-05-30 15:19:02 -070096 ASSERT_THAT(str, NotNull());
97 EXPECT_THAT(*str, StrValueEq(" hey there "));
98 EXPECT_THAT(str->untranslatable_sections, IsEmpty());
Adam Lesinski2eed52e2018-02-21 15:55:58 -080099
100 ASSERT_TRUE(TestParse(R"(<string name="bar">Isn\'t it cool?</string>)"));
101 str = test::GetValue<String>(&table_, "string/bar");
102 ASSERT_THAT(str, NotNull());
103 EXPECT_THAT(*str, StrValueEq("Isn't it cool?"));
104
105 ASSERT_TRUE(TestParse(R"(<string name="baz">"Isn't it cool?"</string>)"));
106 str = test::GetValue<String>(&table_, "string/baz");
107 ASSERT_THAT(str, NotNull());
108 EXPECT_THAT(*str, StrValueEq("Isn't it cool?"));
Adam Lesinski6f6ceb72014-11-14 14:48:12 -0800109}
110
111TEST_F(ResourceParserTest, ParseEscapedString) {
Adam Lesinskia45893a2017-05-30 15:19:02 -0700112 ASSERT_TRUE(TestParse(R"(<string name="foo">\?123</string>)"));
Adam Lesinski6f6ceb72014-11-14 14:48:12 -0800113
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700114 String* str = test::GetValue<String>(&table_, "string/foo");
Adam Lesinskia45893a2017-05-30 15:19:02 -0700115 ASSERT_THAT(str, NotNull());
116 EXPECT_THAT(*str, StrValueEq("?123"));
117 EXPECT_THAT(str->untranslatable_sections, IsEmpty());
Adam Lesinski549e4372017-06-27 18:39:07 -0700118
119 ASSERT_TRUE(TestParse(R"(<string name="bar">This isn\’t a bad string</string>)"));
120 str = test::GetValue<String>(&table_, "string/bar");
121 ASSERT_THAT(str, NotNull());
122 EXPECT_THAT(*str, StrValueEq("This isn’t a bad string"));
Adam Lesinski6f6ceb72014-11-14 14:48:12 -0800123}
124
Adam Lesinski9f222042015-11-04 13:51:45 -0800125TEST_F(ResourceParserTest, ParseFormattedString) {
Adam Lesinskia45893a2017-05-30 15:19:02 -0700126 ASSERT_FALSE(TestParse(R"(<string name="foo">%d %s</string>)"));
127 ASSERT_TRUE(TestParse(R"(<string name="foo">%1$d %2$s</string>)"));
Adam Lesinski9f222042015-11-04 13:51:45 -0800128}
129
Adam Lesinski8c3f31f2016-09-07 13:45:13 -0700130TEST_F(ResourceParserTest, ParseStyledString) {
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700131 // Use a surrogate pair unicode point so that we can verify that the span
Adam Lesinski75421622017-01-06 15:20:04 -0800132 // indices use UTF-16 length and not UTF-8 length.
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700133 std::string input =
Adam Lesinski8049f3d2017-03-31 18:28:14 -0700134 "<string name=\"foo\">This is my aunt\u2019s <b>fickle <small>string</small></b></string>";
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700135 ASSERT_TRUE(TestParse(input));
Adam Lesinski8c3f31f2016-09-07 13:45:13 -0700136
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700137 StyledString* str = test::GetValue<StyledString>(&table_, "string/foo");
Adam Lesinskia45893a2017-05-30 15:19:02 -0700138 ASSERT_THAT(str, NotNull());
Adam Lesinski8c3f31f2016-09-07 13:45:13 -0700139
Adam Lesinski2eed52e2018-02-21 15:55:58 -0800140 EXPECT_THAT(str->value->value, StrEq("This is my aunt\u2019s fickle string"));
Adam Lesinskia45893a2017-05-30 15:19:02 -0700141 EXPECT_THAT(str->value->spans, SizeIs(2));
142 EXPECT_THAT(str->untranslatable_sections, IsEmpty());
Adam Lesinski8c3f31f2016-09-07 13:45:13 -0700143
Adam Lesinski2eed52e2018-02-21 15:55:58 -0800144 EXPECT_THAT(*str->value->spans[0].name, StrEq("b"));
145 EXPECT_THAT(str->value->spans[0].first_char, Eq(18u));
Adam Lesinskia45893a2017-05-30 15:19:02 -0700146 EXPECT_THAT(str->value->spans[0].last_char, Eq(30u));
Adam Lesinski8049f3d2017-03-31 18:28:14 -0700147
Adam Lesinski2eed52e2018-02-21 15:55:58 -0800148 EXPECT_THAT(*str->value->spans[1].name, StrEq("small"));
149 EXPECT_THAT(str->value->spans[1].first_char, Eq(25u));
Adam Lesinskia45893a2017-05-30 15:19:02 -0700150 EXPECT_THAT(str->value->spans[1].last_char, Eq(30u));
Adam Lesinski8c3f31f2016-09-07 13:45:13 -0700151}
152
153TEST_F(ResourceParserTest, ParseStringWithWhitespace) {
Adam Lesinskia45893a2017-05-30 15:19:02 -0700154 ASSERT_TRUE(TestParse(R"(<string name="foo"> This is what I think </string>)"));
Adam Lesinski8c3f31f2016-09-07 13:45:13 -0700155
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700156 String* str = test::GetValue<String>(&table_, "string/foo");
Adam Lesinskia45893a2017-05-30 15:19:02 -0700157 ASSERT_THAT(str, NotNull());
Adam Lesinski2eed52e2018-02-21 15:55:58 -0800158 EXPECT_THAT(*str->value, StrEq("This is what I think"));
Adam Lesinskia45893a2017-05-30 15:19:02 -0700159 EXPECT_THAT(str->untranslatable_sections, IsEmpty());
Adam Lesinski8c3f31f2016-09-07 13:45:13 -0700160
Adam Lesinskia45893a2017-05-30 15:19:02 -0700161 ASSERT_TRUE(TestParse(R"(<string name="foo2">" This is what I think "</string>)"));
Adam Lesinski8c3f31f2016-09-07 13:45:13 -0700162
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700163 str = test::GetValue<String>(&table_, "string/foo2");
Adam Lesinskia45893a2017-05-30 15:19:02 -0700164 ASSERT_THAT(str, NotNull());
165 EXPECT_THAT(*str, StrValueEq(" This is what I think "));
Adam Lesinski8c3f31f2016-09-07 13:45:13 -0700166}
167
Ryan Mitchell9beaa9c2018-03-28 18:22:57 -0700168TEST_F(ResourceParserTest, ParseStringTruncateASCII) {
169 // Tuncate leading and trailing whitespace
170 EXPECT_TRUE(TestParse(R"(<string name="foo">&#32;Hello&#32;</string>)"));
171
172 String* str = test::GetValue<String>(&table_, "string/foo");
173 ASSERT_THAT(str, NotNull());
174 EXPECT_THAT(*str->value, StrEq("Hello"));
175 EXPECT_THAT(str->untranslatable_sections, IsEmpty());
176
177 // AAPT does not truncate unicode whitespace
178 EXPECT_TRUE(TestParse(R"(<string name="foo2">\u0020\Hello\u0020</string>)"));
179
180 str = test::GetValue<String>(&table_, "string/foo2");
181 ASSERT_THAT(str, NotNull());
182 EXPECT_THAT(*str->value, StrEq(" Hello "));
183 EXPECT_THAT(str->untranslatable_sections, IsEmpty());
184
185 // Preserve non-ASCII whitespace including extended ASCII characters
Ryan Mitchell0f326752019-03-11 11:00:25 -0700186 EXPECT_TRUE(TestParse(R"(<string name="foo3">&#160;Hello&#x202F;World&#160;</string>)"));
Ryan Mitchell9beaa9c2018-03-28 18:22:57 -0700187
188 str = test::GetValue<String>(&table_, "string/foo3");
189 ASSERT_THAT(str, NotNull());
Ryan Mitchell0f326752019-03-11 11:00:25 -0700190 EXPECT_THAT(*str->value, StrEq("\xC2\xA0Hello\xE2\x80\xAFWorld\xC2\xA0"));
Ryan Mitchell9beaa9c2018-03-28 18:22:57 -0700191 EXPECT_THAT(str->untranslatable_sections, IsEmpty());
192
193 EXPECT_TRUE(TestParse(R"(<string name="foo4">2005年6月1日</string>)"));
194
195 str = test::GetValue<String>(&table_, "string/foo4");
196 ASSERT_THAT(str, NotNull());
197 EXPECT_THAT(*str->value, StrEq("2005年6月1日"));
198 EXPECT_THAT(str->untranslatable_sections, IsEmpty());
199}
200
Adam Lesinski2eed52e2018-02-21 15:55:58 -0800201TEST_F(ResourceParserTest, ParseStyledStringWithWhitespace) {
202 std::string input = R"(<string name="foo"> <b> My <i> favorite</i> string </b> </string>)";
203 ASSERT_TRUE(TestParse(input));
204
205 StyledString* str = test::GetValue<StyledString>(&table_, "string/foo");
206 ASSERT_THAT(str, NotNull());
207 EXPECT_THAT(str->value->value, StrEq(" My favorite string "));
208 EXPECT_THAT(str->untranslatable_sections, IsEmpty());
209
210 ASSERT_THAT(str->value->spans, SizeIs(2u));
211 EXPECT_THAT(*str->value->spans[0].name, StrEq("b"));
212 EXPECT_THAT(str->value->spans[0].first_char, Eq(1u));
213 EXPECT_THAT(str->value->spans[0].last_char, Eq(21u));
214
215 EXPECT_THAT(*str->value->spans[1].name, StrEq("i"));
216 EXPECT_THAT(str->value->spans[1].first_char, Eq(5u));
217 EXPECT_THAT(str->value->spans[1].last_char, Eq(13u));
218}
219
Mihai Nitad1a65212019-03-26 13:47:45 -0700220TEST_F(ResourceParserTest, ParseStringTranslatableAttribute) {
221 // If there is no translate attribute the default is 'true'
222 EXPECT_TRUE(TestParse(R"(<string name="foo1">Translate</string>)"));
223 String* str = test::GetValue<String>(&table_, "string/foo1");
224 ASSERT_THAT(str, NotNull());
225 ASSERT_TRUE(str->IsTranslatable());
226
227 // Explicit 'true' translate attribute
228 EXPECT_TRUE(TestParse(R"(<string name="foo2" translatable="true">Translate</string>)"));
229 str = test::GetValue<String>(&table_, "string/foo2");
230 ASSERT_THAT(str, NotNull());
231 ASSERT_TRUE(str->IsTranslatable());
232
233 // Explicit 'false' translate attribute
234 EXPECT_TRUE(TestParse(R"(<string name="foo3" translatable="false">Do not translate</string>)"));
235 str = test::GetValue<String>(&table_, "string/foo3");
236 ASSERT_THAT(str, NotNull());
237 ASSERT_FALSE(str->IsTranslatable());
238
239 // Invalid value for the translate attribute, should be boolean ('true' or 'false')
240 EXPECT_FALSE(TestParse(R"(<string name="foo4" translatable="yes">Translate</string>)"));
241}
242
Adam Lesinski75421622017-01-06 15:20:04 -0800243TEST_F(ResourceParserTest, IgnoreXliffTagsOtherThanG) {
Adam Lesinskia45893a2017-05-30 15:19:02 -0700244 std::string input = R"(
Adam Lesinski75421622017-01-06 15:20:04 -0800245 <string name="foo" xmlns:xliff="urn:oasis:names:tc:xliff:document:1.2">
Adam Lesinskia45893a2017-05-30 15:19:02 -0700246 There are <xliff:source>no</xliff:source> apples</string>)";
Adam Lesinski75421622017-01-06 15:20:04 -0800247 ASSERT_TRUE(TestParse(input));
248
249 String* str = test::GetValue<String>(&table_, "string/foo");
Adam Lesinskia45893a2017-05-30 15:19:02 -0700250 ASSERT_THAT(str, NotNull());
251 EXPECT_THAT(*str, StrValueEq("There are no apples"));
252 EXPECT_THAT(str->untranslatable_sections, IsEmpty());
Adam Lesinski75421622017-01-06 15:20:04 -0800253}
254
255TEST_F(ResourceParserTest, NestedXliffGTagsAreIllegal) {
Adam Lesinskia45893a2017-05-30 15:19:02 -0700256 std::string input = R"(
Adam Lesinski75421622017-01-06 15:20:04 -0800257 <string name="foo" xmlns:xliff="urn:oasis:names:tc:xliff:document:1.2">
Adam Lesinskia45893a2017-05-30 15:19:02 -0700258 Do not <xliff:g>translate <xliff:g>this</xliff:g></xliff:g></string>)";
Adam Lesinski75421622017-01-06 15:20:04 -0800259 EXPECT_FALSE(TestParse(input));
260}
261
262TEST_F(ResourceParserTest, RecordUntranslateableXliffSectionsInString) {
Adam Lesinskia45893a2017-05-30 15:19:02 -0700263 std::string input = R"(
Adam Lesinski75421622017-01-06 15:20:04 -0800264 <string name="foo" xmlns:xliff="urn:oasis:names:tc:xliff:document:1.2">
Adam Lesinskia45893a2017-05-30 15:19:02 -0700265 There are <xliff:g id="count">%1$d</xliff:g> apples</string>)";
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700266 ASSERT_TRUE(TestParse(input));
Adam Lesinski1ab598f2015-08-14 14:26:04 -0700267
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700268 String* str = test::GetValue<String>(&table_, "string/foo");
Adam Lesinskia45893a2017-05-30 15:19:02 -0700269 ASSERT_THAT(str, NotNull());
270 EXPECT_THAT(*str, StrValueEq("There are %1$d apples"));
Adam Lesinski75421622017-01-06 15:20:04 -0800271
Adam Lesinski2eed52e2018-02-21 15:55:58 -0800272 ASSERT_THAT(str->untranslatable_sections, SizeIs(1));
273 EXPECT_THAT(str->untranslatable_sections[0].start, Eq(10u));
Adam Lesinskia45893a2017-05-30 15:19:02 -0700274 EXPECT_THAT(str->untranslatable_sections[0].end, Eq(14u));
Adam Lesinski75421622017-01-06 15:20:04 -0800275}
276
277TEST_F(ResourceParserTest, RecordUntranslateableXliffSectionsInStyledString) {
Adam Lesinskia45893a2017-05-30 15:19:02 -0700278 std::string input = R"(
Adam Lesinski75421622017-01-06 15:20:04 -0800279 <string name="foo" xmlns:xliff="urn:oasis:names:tc:xliff:document:1.2">
Adam Lesinskia45893a2017-05-30 15:19:02 -0700280 There are <b><xliff:g id="count">%1$d</xliff:g></b> apples</string>)";
Adam Lesinski75421622017-01-06 15:20:04 -0800281 ASSERT_TRUE(TestParse(input));
282
283 StyledString* str = test::GetValue<StyledString>(&table_, "string/foo");
Adam Lesinskia45893a2017-05-30 15:19:02 -0700284 ASSERT_THAT(str, NotNull());
Adam Lesinski2eed52e2018-02-21 15:55:58 -0800285 EXPECT_THAT(str->value->value, Eq(" There are %1$d apples"));
Adam Lesinski75421622017-01-06 15:20:04 -0800286
Adam Lesinski2eed52e2018-02-21 15:55:58 -0800287 ASSERT_THAT(str->untranslatable_sections, SizeIs(1));
288 EXPECT_THAT(str->untranslatable_sections[0].start, Eq(11u));
289 EXPECT_THAT(str->untranslatable_sections[0].end, Eq(15u));
290
291 ASSERT_THAT(str->value->spans, SizeIs(1u));
292 EXPECT_THAT(*str->value->spans[0].name, StrEq("b"));
293 EXPECT_THAT(str->value->spans[0].first_char, Eq(11u));
294 EXPECT_THAT(str->value->spans[0].last_char, Eq(14u));
Adam Lesinski1ab598f2015-08-14 14:26:04 -0700295}
296
Adam Lesinskidfa5e072015-05-12 21:42:59 -0700297TEST_F(ResourceParserTest, ParseNull) {
Adam Lesinskia45893a2017-05-30 15:19:02 -0700298 std::string input = R"(<integer name="foo">@null</integer>)";
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700299 ASSERT_TRUE(TestParse(input));
Adam Lesinskidfa5e072015-05-12 21:42:59 -0700300
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700301 // The Android runtime treats a value of android::Res_value::TYPE_NULL as
302 // a non-existing value, and this causes problems in styles when trying to
Adam Lesinski75421622017-01-06 15:20:04 -0800303 // resolve an attribute. Null values must be encoded as android::Res_value::TYPE_REFERENCE
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700304 // with a data value of 0.
Adam Lesinskibab4ef52017-06-01 15:22:57 -0700305 Reference* null_ref = test::GetValue<Reference>(&table_, "integer/foo");
306 ASSERT_THAT(null_ref, NotNull());
307 EXPECT_FALSE(null_ref->name);
308 EXPECT_FALSE(null_ref->id);
Adam Lesinskia45893a2017-05-30 15:19:02 -0700309 EXPECT_THAT(null_ref->reference_type, Eq(Reference::Type::kResource));
Adam Lesinskidfa5e072015-05-12 21:42:59 -0700310}
311
312TEST_F(ResourceParserTest, ParseEmpty) {
Adam Lesinskia45893a2017-05-30 15:19:02 -0700313 std::string input = R"(<integer name="foo">@empty</integer>)";
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700314 ASSERT_TRUE(TestParse(input));
Adam Lesinskidfa5e072015-05-12 21:42:59 -0700315
Adam Lesinskibab4ef52017-06-01 15:22:57 -0700316 BinaryPrimitive* integer = test::GetValue<BinaryPrimitive>(&table_, "integer/foo");
Adam Lesinskia45893a2017-05-30 15:19:02 -0700317 ASSERT_THAT(integer, NotNull());
318 EXPECT_THAT(integer->value.dataType, Eq(Res_value::TYPE_NULL));
319 EXPECT_THAT(integer->value.data, Eq(Res_value::DATA_NULL_EMPTY));
Adam Lesinskidfa5e072015-05-12 21:42:59 -0700320}
321
Adam Lesinski6f6ceb72014-11-14 14:48:12 -0800322TEST_F(ResourceParserTest, ParseAttr) {
Adam Lesinskia45893a2017-05-30 15:19:02 -0700323 std::string input = R"(
324 <attr name="foo" format="string"/>
325 <attr name="bar"/>)";
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700326 ASSERT_TRUE(TestParse(input));
Adam Lesinski6f6ceb72014-11-14 14:48:12 -0800327
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700328 Attribute* attr = test::GetValue<Attribute>(&table_, "attr/foo");
Adam Lesinskia45893a2017-05-30 15:19:02 -0700329 ASSERT_THAT(attr, NotNull());
330 EXPECT_THAT(attr->type_mask, Eq(ResTable_map::TYPE_STRING));
Adam Lesinski6f6ceb72014-11-14 14:48:12 -0800331
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700332 attr = test::GetValue<Attribute>(&table_, "attr/bar");
Adam Lesinskia45893a2017-05-30 15:19:02 -0700333 ASSERT_THAT(attr, NotNull());
334 EXPECT_THAT(attr->type_mask, Eq(ResTable_map::TYPE_ANY));
Adam Lesinski6f6ceb72014-11-14 14:48:12 -0800335}
336
Adam Lesinskia45893a2017-05-30 15:19:02 -0700337// Old AAPT allowed attributes to be defined under different configurations, but ultimately
338// stored them with the default configuration. Check that we have the same behavior.
Adam Lesinskibab4ef52017-06-01 15:22:57 -0700339TEST_F(ResourceParserTest, ParseAttrAndDeclareStyleableUnderConfigButRecordAsNoConfig) {
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700340 const ConfigDescription watch_config = test::ParseConfigOrDie("watch");
Adam Lesinskibab4ef52017-06-01 15:22:57 -0700341 std::string input = R"(
342 <attr name="foo" />
343 <declare-styleable name="bar">
Ryan Mitchellacde95c32019-04-23 05:44:21 -0700344 <attr name="baz" format="reference"/>
Adam Lesinskibab4ef52017-06-01 15:22:57 -0700345 </declare-styleable>)";
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700346 ASSERT_TRUE(TestParse(input, watch_config));
Adam Lesinski52364f72016-01-11 13:10:24 -0800347
Adam Lesinskia45893a2017-05-30 15:19:02 -0700348 EXPECT_THAT(test::GetValueForConfig<Attribute>(&table_, "attr/foo", watch_config), IsNull());
349 EXPECT_THAT(test::GetValueForConfig<Attribute>(&table_, "attr/baz", watch_config), IsNull());
350 EXPECT_THAT(test::GetValueForConfig<Styleable>(&table_, "styleable/bar", watch_config), IsNull());
Adam Lesinski52364f72016-01-11 13:10:24 -0800351
Adam Lesinskia45893a2017-05-30 15:19:02 -0700352 EXPECT_THAT(test::GetValue<Attribute>(&table_, "attr/foo"), NotNull());
353 EXPECT_THAT(test::GetValue<Attribute>(&table_, "attr/baz"), NotNull());
354 EXPECT_THAT(test::GetValue<Styleable>(&table_, "styleable/bar"), NotNull());
Adam Lesinski52364f72016-01-11 13:10:24 -0800355}
356
Adam Lesinskia5870652015-11-20 15:32:30 -0800357TEST_F(ResourceParserTest, ParseAttrWithMinMax) {
Adam Lesinskia45893a2017-05-30 15:19:02 -0700358 std::string input = R"(<attr name="foo" min="10" max="23" format="integer"/>)";
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700359 ASSERT_TRUE(TestParse(input));
Adam Lesinskia5870652015-11-20 15:32:30 -0800360
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700361 Attribute* attr = test::GetValue<Attribute>(&table_, "attr/foo");
Adam Lesinskia45893a2017-05-30 15:19:02 -0700362 ASSERT_THAT(attr, NotNull());
363 EXPECT_THAT(attr->type_mask, Eq(ResTable_map::TYPE_INTEGER));
364 EXPECT_THAT(attr->min_int, Eq(10));
365 EXPECT_THAT(attr->max_int, Eq(23));
Adam Lesinskia5870652015-11-20 15:32:30 -0800366}
367
368TEST_F(ResourceParserTest, FailParseAttrWithMinMaxButNotInteger) {
Adam Lesinskia45893a2017-05-30 15:19:02 -0700369 ASSERT_FALSE(TestParse(R"(<attr name="foo" min="10" max="23" format="string"/>)"));
Adam Lesinskia5870652015-11-20 15:32:30 -0800370}
371
Adam Lesinski6f6ceb72014-11-14 14:48:12 -0800372TEST_F(ResourceParserTest, ParseUseAndDeclOfAttr) {
Adam Lesinskia45893a2017-05-30 15:19:02 -0700373 std::string input = R"(
374 <declare-styleable name="Styleable">
375 <attr name="foo" />
376 </declare-styleable>
377 <attr name="foo" format="string"/>)";
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700378 ASSERT_TRUE(TestParse(input));
Adam Lesinski6f6ceb72014-11-14 14:48:12 -0800379
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700380 Attribute* attr = test::GetValue<Attribute>(&table_, "attr/foo");
Adam Lesinskia45893a2017-05-30 15:19:02 -0700381 ASSERT_THAT(attr, NotNull());
382 EXPECT_THAT(attr->type_mask, Eq(ResTable_map::TYPE_STRING));
Adam Lesinski6f6ceb72014-11-14 14:48:12 -0800383}
384
385TEST_F(ResourceParserTest, ParseDoubleUseOfAttr) {
Adam Lesinskia45893a2017-05-30 15:19:02 -0700386 std::string input = R"(
387 <declare-styleable name="Theme">
388 <attr name="foo" />
389 </declare-styleable>
390 <declare-styleable name="Window">
391 <attr name="foo" format="boolean"/>
392 </declare-styleable>)";
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700393 ASSERT_TRUE(TestParse(input));
Adam Lesinski6f6ceb72014-11-14 14:48:12 -0800394
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700395 Attribute* attr = test::GetValue<Attribute>(&table_, "attr/foo");
Adam Lesinskia45893a2017-05-30 15:19:02 -0700396 ASSERT_THAT(attr, NotNull());
397 EXPECT_THAT(attr->type_mask, Eq(ResTable_map::TYPE_BOOLEAN));
Adam Lesinski6f6ceb72014-11-14 14:48:12 -0800398}
399
400TEST_F(ResourceParserTest, ParseEnumAttr) {
Adam Lesinskia45893a2017-05-30 15:19:02 -0700401 std::string input = R"(
402 <attr name="foo">
403 <enum name="bar" value="0"/>
404 <enum name="bat" value="1"/>
405 <enum name="baz" value="2"/>
406 </attr>)";
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700407 ASSERT_TRUE(TestParse(input));
Adam Lesinski6f6ceb72014-11-14 14:48:12 -0800408
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700409 Attribute* enum_attr = test::GetValue<Attribute>(&table_, "attr/foo");
Adam Lesinskia45893a2017-05-30 15:19:02 -0700410 ASSERT_THAT(enum_attr, NotNull());
411 EXPECT_THAT(enum_attr->type_mask, Eq(ResTable_map::TYPE_ENUM));
412 ASSERT_THAT(enum_attr->symbols, SizeIs(3));
Adam Lesinski6f6ceb72014-11-14 14:48:12 -0800413
Adam Lesinskia45893a2017-05-30 15:19:02 -0700414 ASSERT_TRUE(enum_attr->symbols[0].symbol.name);
415 EXPECT_THAT(enum_attr->symbols[0].symbol.name.value().entry, Eq("bar"));
416 EXPECT_THAT(enum_attr->symbols[0].value, Eq(0u));
Adam Lesinski6f6ceb72014-11-14 14:48:12 -0800417
Adam Lesinskia45893a2017-05-30 15:19:02 -0700418 ASSERT_TRUE(enum_attr->symbols[1].symbol.name);
419 EXPECT_THAT(enum_attr->symbols[1].symbol.name.value().entry, Eq("bat"));
420 EXPECT_THAT(enum_attr->symbols[1].value, Eq(1u));
Adam Lesinski6f6ceb72014-11-14 14:48:12 -0800421
Adam Lesinskia45893a2017-05-30 15:19:02 -0700422 ASSERT_TRUE(enum_attr->symbols[2].symbol.name);
423 EXPECT_THAT(enum_attr->symbols[2].symbol.name.value().entry, Eq("baz"));
424 EXPECT_THAT(enum_attr->symbols[2].value, Eq(2u));
Adam Lesinski6f6ceb72014-11-14 14:48:12 -0800425}
426
427TEST_F(ResourceParserTest, ParseFlagAttr) {
Adam Lesinskia45893a2017-05-30 15:19:02 -0700428 std::string input = R"(
429 <attr name="foo">
430 <flag name="bar" value="0"/>
431 <flag name="bat" value="1"/>
432 <flag name="baz" value="2"/>
433 </attr>)";
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700434 ASSERT_TRUE(TestParse(input));
Adam Lesinski6f6ceb72014-11-14 14:48:12 -0800435
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700436 Attribute* flag_attr = test::GetValue<Attribute>(&table_, "attr/foo");
Adam Lesinskia45893a2017-05-30 15:19:02 -0700437 ASSERT_THAT(flag_attr, NotNull());
438 EXPECT_THAT(flag_attr->type_mask, Eq(ResTable_map::TYPE_FLAGS));
439 ASSERT_THAT(flag_attr->symbols, SizeIs(3));
Adam Lesinski6f6ceb72014-11-14 14:48:12 -0800440
Adam Lesinskia45893a2017-05-30 15:19:02 -0700441 ASSERT_TRUE(flag_attr->symbols[0].symbol.name);
442 EXPECT_THAT(flag_attr->symbols[0].symbol.name.value().entry, Eq("bar"));
443 EXPECT_THAT(flag_attr->symbols[0].value, Eq(0u));
Adam Lesinski6f6ceb72014-11-14 14:48:12 -0800444
Adam Lesinskia45893a2017-05-30 15:19:02 -0700445 ASSERT_TRUE(flag_attr->symbols[1].symbol.name);
446 EXPECT_THAT(flag_attr->symbols[1].symbol.name.value().entry, Eq("bat"));
447 EXPECT_THAT(flag_attr->symbols[1].value, Eq(1u));
Adam Lesinski6f6ceb72014-11-14 14:48:12 -0800448
Adam Lesinskia45893a2017-05-30 15:19:02 -0700449 ASSERT_TRUE(flag_attr->symbols[2].symbol.name);
450 EXPECT_THAT(flag_attr->symbols[2].symbol.name.value().entry, Eq("baz"));
451 EXPECT_THAT(flag_attr->symbols[2].value, Eq(2u));
Adam Lesinski6f6ceb72014-11-14 14:48:12 -0800452
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700453 std::unique_ptr<BinaryPrimitive> flag_value =
454 ResourceUtils::TryParseFlagSymbol(flag_attr, "baz|bat");
Adam Lesinskia45893a2017-05-30 15:19:02 -0700455 ASSERT_THAT(flag_value, NotNull());
456 EXPECT_THAT(flag_value->value.data, Eq(1u | 2u));
Adam Lesinski6f6ceb72014-11-14 14:48:12 -0800457}
458
459TEST_F(ResourceParserTest, FailToParseEnumAttrWithNonUniqueKeys) {
Adam Lesinskia45893a2017-05-30 15:19:02 -0700460 std::string input = R"(
461 <attr name="foo">
462 <enum name="bar" value="0"/>
463 <enum name="bat" value="1"/>
464 <enum name="bat" value="2"/>
465 </attr>)";
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700466 ASSERT_FALSE(TestParse(input));
Adam Lesinski6f6ceb72014-11-14 14:48:12 -0800467}
468
469TEST_F(ResourceParserTest, ParseStyle) {
Adam Lesinskia45893a2017-05-30 15:19:02 -0700470 std::string input = R"(
471 <style name="foo" parent="@style/fu">
472 <item name="bar">#ffffffff</item>
473 <item name="bat">@string/hey</item>
474 <item name="baz"><b>hey</b></item>
475 </style>)";
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700476 ASSERT_TRUE(TestParse(input));
Adam Lesinski6f6ceb72014-11-14 14:48:12 -0800477
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700478 Style* style = test::GetValue<Style>(&table_, "style/foo");
Adam Lesinskia45893a2017-05-30 15:19:02 -0700479 ASSERT_THAT(style, NotNull());
480 ASSERT_TRUE(style->parent);
481 EXPECT_THAT(style->parent.value().name, Eq(make_value(test::ParseNameOrDie("style/fu"))));
482 ASSERT_THAT(style->entries, SizeIs(3));
Adam Lesinski6f6ceb72014-11-14 14:48:12 -0800483
Adam Lesinskia45893a2017-05-30 15:19:02 -0700484 EXPECT_THAT(style->entries[0].key.name, Eq(make_value(test::ParseNameOrDie("attr/bar"))));
485 EXPECT_THAT(style->entries[1].key.name, Eq(make_value(test::ParseNameOrDie("attr/bat"))));
486 EXPECT_THAT(style->entries[2].key.name, Eq(make_value(test::ParseNameOrDie("attr/baz"))));
Adam Lesinski6f6ceb72014-11-14 14:48:12 -0800487}
488
Adam Lesinski769de982015-04-10 19:43:55 -0700489TEST_F(ResourceParserTest, ParseStyleWithShorthandParent) {
Adam Lesinskia45893a2017-05-30 15:19:02 -0700490 ASSERT_TRUE(TestParse(R"(<style name="foo" parent="com.app:Theme"/>)"));
Adam Lesinski769de982015-04-10 19:43:55 -0700491
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700492 Style* style = test::GetValue<Style>(&table_, "style/foo");
Adam Lesinskia45893a2017-05-30 15:19:02 -0700493 ASSERT_THAT(style, NotNull());
494 ASSERT_TRUE(style->parent);
495 EXPECT_THAT(style->parent.value().name, Eq(make_value(test::ParseNameOrDie("com.app:style/Theme"))));
Adam Lesinski769de982015-04-10 19:43:55 -0700496}
497
Adam Lesinski24aad162015-04-24 19:19:30 -0700498TEST_F(ResourceParserTest, ParseStyleWithPackageAliasedParent) {
Adam Lesinskia45893a2017-05-30 15:19:02 -0700499 std::string input = R"(
500 <style xmlns:app="http://schemas.android.com/apk/res/android"
501 name="foo" parent="app:Theme"/>)";
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700502 ASSERT_TRUE(TestParse(input));
Adam Lesinski24aad162015-04-24 19:19:30 -0700503
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700504 Style* style = test::GetValue<Style>(&table_, "style/foo");
Adam Lesinskia45893a2017-05-30 15:19:02 -0700505 ASSERT_THAT(style, NotNull());
506 ASSERT_TRUE(style->parent);
507 ASSERT_TRUE(style->parent.value().name);
508 EXPECT_THAT(style->parent.value().name, Eq(make_value(test::ParseNameOrDie("android:style/Theme"))));
Adam Lesinski24aad162015-04-24 19:19:30 -0700509}
510
511TEST_F(ResourceParserTest, ParseStyleWithPackageAliasedItems) {
Adam Lesinskia45893a2017-05-30 15:19:02 -0700512 std::string input = R"(
513 <style xmlns:app="http://schemas.android.com/apk/res/android" name="foo">
514 <item name="app:bar">0</item>
515 </style>)";
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700516 ASSERT_TRUE(TestParse(input));
Adam Lesinski24aad162015-04-24 19:19:30 -0700517
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700518 Style* style = test::GetValue<Style>(&table_, "style/foo");
Adam Lesinskia45893a2017-05-30 15:19:02 -0700519 ASSERT_THAT(style, NotNull());
520 ASSERT_THAT(style->entries, SizeIs(1));
521 EXPECT_THAT(style->entries[0].key.name, Eq(make_value(test::ParseNameOrDie("android:attr/bar"))));
Adam Lesinski24aad162015-04-24 19:19:30 -0700522}
523
Ryan Mitchell633d7962018-06-11 15:29:21 -0700524TEST_F(ResourceParserTest, ParseStyleWithRawStringItem) {
525 std::string input = R"(
526 <style name="foo">
527 <item name="bar">
528 com.helloworld.AppClass
529 </item>
530 </style>)";
531 ASSERT_TRUE(TestParse(input));
532
533 Style* style = test::GetValue<Style>(&table_, "style/foo");
534 ASSERT_THAT(style, NotNull());
535 EXPECT_THAT(style->entries[0].value, NotNull());
536 RawString* value = ValueCast<RawString>(style->entries[0].value.get());
537 EXPECT_THAT(value, NotNull());
538 EXPECT_THAT(*value->value, StrEq(R"(com.helloworld.AppClass)"));
539}
540
541
Adam Lesinskibdaa0922015-05-08 20:16:23 -0700542TEST_F(ResourceParserTest, ParseStyleWithInferredParent) {
Adam Lesinskia45893a2017-05-30 15:19:02 -0700543 ASSERT_TRUE(TestParse(R"(<style name="foo.bar"/>)"));
Adam Lesinskibdaa0922015-05-08 20:16:23 -0700544
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700545 Style* style = test::GetValue<Style>(&table_, "style/foo.bar");
Adam Lesinskia45893a2017-05-30 15:19:02 -0700546 ASSERT_THAT(style, NotNull());
547 ASSERT_TRUE(style->parent);
548 EXPECT_THAT(style->parent.value().name, Eq(make_value(test::ParseNameOrDie("style/foo"))));
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700549 EXPECT_TRUE(style->parent_inferred);
Adam Lesinskibdaa0922015-05-08 20:16:23 -0700550}
551
Adam Lesinskia45893a2017-05-30 15:19:02 -0700552TEST_F(ResourceParserTest, ParseStyleWithInferredParentOverridenByEmptyParentAttribute) {
553 ASSERT_TRUE(TestParse(R"(<style name="foo.bar" parent=""/>)"));
Adam Lesinskibdaa0922015-05-08 20:16:23 -0700554
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700555 Style* style = test::GetValue<Style>(&table_, "style/foo.bar");
Adam Lesinskia45893a2017-05-30 15:19:02 -0700556 ASSERT_THAT(style, NotNull());
557 EXPECT_FALSE(style->parent);
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700558 EXPECT_FALSE(style->parent_inferred);
Adam Lesinskibdaa0922015-05-08 20:16:23 -0700559}
560
Adam Lesinski24b8ff02015-12-16 14:01:57 -0800561TEST_F(ResourceParserTest, ParseStyleWithPrivateParentReference) {
Adam Lesinskia45893a2017-05-30 15:19:02 -0700562 ASSERT_TRUE(TestParse(R"(<style name="foo" parent="*android:style/bar" />)"));
Adam Lesinski24b8ff02015-12-16 14:01:57 -0800563
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700564 Style* style = test::GetValue<Style>(&table_, "style/foo");
Adam Lesinskia45893a2017-05-30 15:19:02 -0700565 ASSERT_THAT(style, NotNull());
566 ASSERT_TRUE(style->parent);
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700567 EXPECT_TRUE(style->parent.value().private_reference);
Adam Lesinski24b8ff02015-12-16 14:01:57 -0800568}
569
Adam Lesinski6f6ceb72014-11-14 14:48:12 -0800570TEST_F(ResourceParserTest, ParseAutoGeneratedIdReference) {
Adam Lesinskia45893a2017-05-30 15:19:02 -0700571 ASSERT_TRUE(TestParse(R"(<string name="foo">@+id/bar</string>)"));
572 ASSERT_THAT(test::GetValue<Id>(&table_, "id/bar"), NotNull());
Adam Lesinski6f6ceb72014-11-14 14:48:12 -0800573}
574
575TEST_F(ResourceParserTest, ParseAttributesDeclareStyleable) {
Adam Lesinskia45893a2017-05-30 15:19:02 -0700576 std::string input = R"(
577 <declare-styleable name="foo">
578 <attr name="bar" />
579 <attr name="bat" format="string|reference"/>
580 <attr name="baz">
581 <enum name="foo" value="1"/>
582 </attr>
583 </declare-styleable>)";
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700584 ASSERT_TRUE(TestParse(input));
Adam Lesinski6f6ceb72014-11-14 14:48:12 -0800585
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700586 Maybe<ResourceTable::SearchResult> result =
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700587 table_.FindResource(test::ParseNameOrDie("styleable/foo"));
Adam Lesinskia45893a2017-05-30 15:19:02 -0700588 ASSERT_TRUE(result);
Adam Lesinski71be7052017-12-12 16:48:07 -0800589 EXPECT_THAT(result.value().entry->visibility.level, Eq(Visibility::Level::kPublic));
Adam Lesinski9f222042015-11-04 13:51:45 -0800590
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700591 Attribute* attr = test::GetValue<Attribute>(&table_, "attr/bar");
Ryan Mitchellacde95c32019-04-23 05:44:21 -0700592 ASSERT_THAT(attr, IsNull());
Adam Lesinski6f6ceb72014-11-14 14:48:12 -0800593
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700594 attr = test::GetValue<Attribute>(&table_, "attr/bat");
Adam Lesinskia45893a2017-05-30 15:19:02 -0700595 ASSERT_THAT(attr, NotNull());
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700596 EXPECT_TRUE(attr->IsWeak());
Adam Lesinski6f6ceb72014-11-14 14:48:12 -0800597
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700598 attr = test::GetValue<Attribute>(&table_, "attr/baz");
Adam Lesinskia45893a2017-05-30 15:19:02 -0700599 ASSERT_THAT(attr, NotNull());
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700600 EXPECT_TRUE(attr->IsWeak());
Adam Lesinskia45893a2017-05-30 15:19:02 -0700601 EXPECT_THAT(attr->symbols, SizeIs(1));
Adam Lesinski9ba47d82015-10-13 11:37:10 -0700602
Adam Lesinskia45893a2017-05-30 15:19:02 -0700603 EXPECT_THAT(test::GetValue<Id>(&table_, "id/foo"), NotNull());
Adam Lesinski9ba47d82015-10-13 11:37:10 -0700604
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700605 Styleable* styleable = test::GetValue<Styleable>(&table_, "styleable/foo");
Adam Lesinskia45893a2017-05-30 15:19:02 -0700606 ASSERT_THAT(styleable, NotNull());
607 ASSERT_THAT(styleable->entries, SizeIs(3));
Adam Lesinski6f6ceb72014-11-14 14:48:12 -0800608
Adam Lesinskia45893a2017-05-30 15:19:02 -0700609 EXPECT_THAT(styleable->entries[0].name, Eq(make_value(test::ParseNameOrDie("attr/bar"))));
610 EXPECT_THAT(styleable->entries[1].name, Eq(make_value(test::ParseNameOrDie("attr/bat"))));
611 EXPECT_THAT(styleable->entries[2].name, Eq(make_value(test::ParseNameOrDie("attr/baz"))));
Adam Lesinski6f6ceb72014-11-14 14:48:12 -0800612}
613
Donald Chaif80d0ae2020-01-06 13:52:41 -0800614TEST_F(ResourceParserTest, ParseDeclareStyleablePreservingVisibility) {
615 StringInputStream input(R"(
616 <resources>
617 <declare-styleable name="foo">
618 <attr name="myattr" />
619 </declare-styleable>
620 <declare-styleable name="bar">
621 <attr name="myattr" />
622 </declare-styleable>
623 <public type="styleable" name="bar" />
624 </resources>)");
625 ResourceParser parser(context_->GetDiagnostics(), &table_, Source{"test"},
626 ConfigDescription::DefaultConfig(),
627 ResourceParserOptions{.preserve_visibility_of_styleables = true});
628
629 xml::XmlPullParser xml_parser(&input);
630 ASSERT_TRUE(parser.Parse(&xml_parser));
631
632 EXPECT_EQ(
633 table_.FindResource(test::ParseNameOrDie("styleable/foo")).value().entry->visibility.level,
634 Visibility::Level::kUndefined);
635 EXPECT_EQ(
636 table_.FindResource(test::ParseNameOrDie("styleable/bar")).value().entry->visibility.level,
637 Visibility::Level::kPublic);
638}
639
Adam Lesinski467f1712015-11-16 17:35:44 -0800640TEST_F(ResourceParserTest, ParsePrivateAttributesDeclareStyleable) {
Adam Lesinskia45893a2017-05-30 15:19:02 -0700641 std::string input = R"(
642 <declare-styleable xmlns:privAndroid="http://schemas.android.com/apk/prv/res/android"
643 name="foo">
644 <attr name="*android:bar" />
645 <attr name="privAndroid:bat" />
646 </declare-styleable>)";
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700647 ASSERT_TRUE(TestParse(input));
648 Styleable* styleable = test::GetValue<Styleable>(&table_, "styleable/foo");
Adam Lesinskia45893a2017-05-30 15:19:02 -0700649 ASSERT_THAT(styleable, NotNull());
650 ASSERT_THAT(styleable->entries, SizeIs(2));
Adam Lesinski467f1712015-11-16 17:35:44 -0800651
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700652 EXPECT_TRUE(styleable->entries[0].private_reference);
Adam Lesinskia45893a2017-05-30 15:19:02 -0700653 ASSERT_TRUE(styleable->entries[0].name);
654 EXPECT_THAT(styleable->entries[0].name.value().package, Eq("android"));
Adam Lesinski467f1712015-11-16 17:35:44 -0800655
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700656 EXPECT_TRUE(styleable->entries[1].private_reference);
Adam Lesinskia45893a2017-05-30 15:19:02 -0700657 ASSERT_TRUE(styleable->entries[1].name);
658 EXPECT_THAT(styleable->entries[1].name.value().package, Eq("android"));
Adam Lesinski467f1712015-11-16 17:35:44 -0800659}
660
Adam Lesinski6f6ceb72014-11-14 14:48:12 -0800661TEST_F(ResourceParserTest, ParseArray) {
Adam Lesinskia45893a2017-05-30 15:19:02 -0700662 std::string input = R"(
663 <array name="foo">
664 <item>@string/ref</item>
665 <item>hey</item>
666 <item>23</item>
667 </array>)";
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700668 ASSERT_TRUE(TestParse(input));
Adam Lesinski6f6ceb72014-11-14 14:48:12 -0800669
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700670 Array* array = test::GetValue<Array>(&table_, "array/foo");
Adam Lesinskia45893a2017-05-30 15:19:02 -0700671 ASSERT_THAT(array, NotNull());
Adam Lesinski4ffea042017-08-10 15:37:28 -0700672 ASSERT_THAT(array->elements, SizeIs(3));
Adam Lesinski6f6ceb72014-11-14 14:48:12 -0800673
Adam Lesinski4ffea042017-08-10 15:37:28 -0700674 EXPECT_THAT(ValueCast<Reference>(array->elements[0].get()), NotNull());
675 EXPECT_THAT(ValueCast<String>(array->elements[1].get()), NotNull());
676 EXPECT_THAT(ValueCast<BinaryPrimitive>(array->elements[2].get()), NotNull());
Adam Lesinski6f6ceb72014-11-14 14:48:12 -0800677}
678
Adam Lesinski9ba47d82015-10-13 11:37:10 -0700679TEST_F(ResourceParserTest, ParseStringArray) {
Adam Lesinskia45893a2017-05-30 15:19:02 -0700680 std::string input = R"(
Adam Lesinskid5fd76a2017-05-16 12:18:08 -0700681 <string-array name="foo">
682 <item>"Werk"</item>"
Adam Lesinskia45893a2017-05-30 15:19:02 -0700683 </string-array>)";
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700684 ASSERT_TRUE(TestParse(input));
Adam Lesinskia45893a2017-05-30 15:19:02 -0700685 EXPECT_THAT(test::GetValue<Array>(&table_, "array/foo"), NotNull());
Adam Lesinski9ba47d82015-10-13 11:37:10 -0700686}
687
Adam Lesinskid5fd76a2017-05-16 12:18:08 -0700688TEST_F(ResourceParserTest, ParseArrayWithFormat) {
Adam Lesinskia45893a2017-05-30 15:19:02 -0700689 std::string input = R"(
Adam Lesinskid5fd76a2017-05-16 12:18:08 -0700690 <array name="foo" format="string">
691 <item>100</item>
Adam Lesinskia45893a2017-05-30 15:19:02 -0700692 </array>)";
Adam Lesinskid5fd76a2017-05-16 12:18:08 -0700693 ASSERT_TRUE(TestParse(input));
694
695 Array* array = test::GetValue<Array>(&table_, "array/foo");
Adam Lesinskia45893a2017-05-30 15:19:02 -0700696 ASSERT_THAT(array, NotNull());
Adam Lesinski4ffea042017-08-10 15:37:28 -0700697 ASSERT_THAT(array->elements, SizeIs(1));
Adam Lesinskid5fd76a2017-05-16 12:18:08 -0700698
Adam Lesinski4ffea042017-08-10 15:37:28 -0700699 String* str = ValueCast<String>(array->elements[0].get());
Adam Lesinskia45893a2017-05-30 15:19:02 -0700700 ASSERT_THAT(str, NotNull());
701 EXPECT_THAT(*str, StrValueEq("100"));
Adam Lesinskid5fd76a2017-05-16 12:18:08 -0700702}
703
704TEST_F(ResourceParserTest, ParseArrayWithBadFormat) {
Adam Lesinskia45893a2017-05-30 15:19:02 -0700705 std::string input = R"(
Adam Lesinskid5fd76a2017-05-16 12:18:08 -0700706 <array name="foo" format="integer">
707 <item>Hi</item>
Adam Lesinskia45893a2017-05-30 15:19:02 -0700708 </array>)";
Adam Lesinskid5fd76a2017-05-16 12:18:08 -0700709 ASSERT_FALSE(TestParse(input));
710}
711
Adam Lesinski6f6ceb72014-11-14 14:48:12 -0800712TEST_F(ResourceParserTest, ParsePlural) {
Adam Lesinskia45893a2017-05-30 15:19:02 -0700713 std::string input = R"(
714 <plurals name="foo">
715 <item quantity="other">apples</item>
716 <item quantity="one">apple</item>
717 </plurals>)";
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700718 ASSERT_TRUE(TestParse(input));
Adam Lesinski8f7c5502017-03-02 17:45:01 -0800719
720 Plural* plural = test::GetValue<Plural>(&table_, "plurals/foo");
Adam Lesinskia45893a2017-05-30 15:19:02 -0700721 ASSERT_THAT(plural, NotNull());
722 EXPECT_THAT(plural->values[Plural::Zero], IsNull());
723 EXPECT_THAT(plural->values[Plural::Two], IsNull());
724 EXPECT_THAT(plural->values[Plural::Few], IsNull());
725 EXPECT_THAT(plural->values[Plural::Many], IsNull());
Adam Lesinski8f7c5502017-03-02 17:45:01 -0800726
Adam Lesinskia45893a2017-05-30 15:19:02 -0700727 EXPECT_THAT(plural->values[Plural::One], NotNull());
728 EXPECT_THAT(plural->values[Plural::Other], NotNull());
Adam Lesinski6f6ceb72014-11-14 14:48:12 -0800729}
730
731TEST_F(ResourceParserTest, ParseCommentsWithResource) {
Adam Lesinskia45893a2017-05-30 15:19:02 -0700732 std::string input = R"(
733 <!--This is a comment-->
734 <string name="foo">Hi</string>)";
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700735 ASSERT_TRUE(TestParse(input));
Adam Lesinski6f6ceb72014-11-14 14:48:12 -0800736
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700737 String* value = test::GetValue<String>(&table_, "string/foo");
Adam Lesinskia45893a2017-05-30 15:19:02 -0700738 ASSERT_THAT(value, NotNull());
739 EXPECT_THAT(value->GetComment(), Eq("This is a comment"));
Adam Lesinskie78fd612015-10-22 12:48:43 -0700740}
Adam Lesinski1ab598f2015-08-14 14:26:04 -0700741
Adam Lesinskie78fd612015-10-22 12:48:43 -0700742TEST_F(ResourceParserTest, DoNotCombineMultipleComments) {
Adam Lesinskia45893a2017-05-30 15:19:02 -0700743 std::string input = R"(
744 <!--One-->
745 <!--Two-->
746 <string name="foo">Hi</string>)";
Adam Lesinskie78fd612015-10-22 12:48:43 -0700747
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700748 ASSERT_TRUE(TestParse(input));
Adam Lesinskie78fd612015-10-22 12:48:43 -0700749
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700750 String* value = test::GetValue<String>(&table_, "string/foo");
Adam Lesinskia45893a2017-05-30 15:19:02 -0700751 ASSERT_THAT(value, NotNull());
752 EXPECT_THAT(value->GetComment(), Eq("Two"));
Adam Lesinskie78fd612015-10-22 12:48:43 -0700753}
754
755TEST_F(ResourceParserTest, IgnoreCommentBeforeEndTag) {
Adam Lesinskia45893a2017-05-30 15:19:02 -0700756 std::string input = R"(
757 <!--One-->
758 <string name="foo">
759 Hi
760 <!--Two-->
761 </string>)";
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700762 ASSERT_TRUE(TestParse(input));
Adam Lesinskie78fd612015-10-22 12:48:43 -0700763
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700764 String* value = test::GetValue<String>(&table_, "string/foo");
Adam Lesinskia45893a2017-05-30 15:19:02 -0700765 ASSERT_THAT(value, NotNull());
766 EXPECT_THAT(value->GetComment(), Eq("One"));
Adam Lesinski6f6ceb72014-11-14 14:48:12 -0800767}
768
Adam Lesinskica5638f2015-10-21 14:42:43 -0700769TEST_F(ResourceParserTest, ParseNestedComments) {
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700770 // We only care about declare-styleable and enum/flag attributes because
Adam Lesinskia45893a2017-05-30 15:19:02 -0700771 // comments from those end up in R.java
772 std::string input = R"(
773 <declare-styleable name="foo">
774 <!-- The name of the bar -->
775 <attr name="barName" format="string|reference" />
776 </declare-styleable>
Adam Lesinskica5638f2015-10-21 14:42:43 -0700777
Adam Lesinskia45893a2017-05-30 15:19:02 -0700778 <attr name="foo">
779 <!-- The very first -->
780 <enum name="one" value="1" />
781 </attr>)";
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700782 ASSERT_TRUE(TestParse(input));
Adam Lesinskica5638f2015-10-21 14:42:43 -0700783
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700784 Styleable* styleable = test::GetValue<Styleable>(&table_, "styleable/foo");
Adam Lesinskia45893a2017-05-30 15:19:02 -0700785 ASSERT_THAT(styleable, NotNull());
786 ASSERT_THAT(styleable->entries, SizeIs(1));
787 EXPECT_THAT(styleable->entries[0].GetComment(), Eq("The name of the bar"));
Adam Lesinskica5638f2015-10-21 14:42:43 -0700788
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700789 Attribute* attr = test::GetValue<Attribute>(&table_, "attr/foo");
Adam Lesinskia45893a2017-05-30 15:19:02 -0700790 ASSERT_THAT(attr, NotNull());
791 ASSERT_THAT(attr->symbols, SizeIs(1));
792 EXPECT_THAT(attr->symbols[0].symbol.GetComment(), Eq("The very first"));
Adam Lesinskica5638f2015-10-21 14:42:43 -0700793}
794
Adam Lesinskia45893a2017-05-30 15:19:02 -0700795// Declaring an ID as public should not require a separate definition (as an ID has no value).
Adam Lesinski6f6ceb72014-11-14 14:48:12 -0800796TEST_F(ResourceParserTest, ParsePublicIdAsDefinition) {
Adam Lesinskia45893a2017-05-30 15:19:02 -0700797 ASSERT_TRUE(TestParse(R"(<public type="id" name="foo"/>)"));
798 ASSERT_THAT(test::GetValue<Id>(&table_, "id/foo"), NotNull());
Adam Lesinski6f6ceb72014-11-14 14:48:12 -0800799}
800
Adam Lesinskie4bb9eb2016-02-12 22:18:51 -0800801TEST_F(ResourceParserTest, KeepAllProducts) {
Adam Lesinskia45893a2017-05-30 15:19:02 -0700802 std::string input = R"(
803 <string name="foo" product="phone">hi</string>
804 <string name="foo" product="no-sdcard">ho</string>
805 <string name="bar" product="">wee</string>
806 <string name="baz">woo</string>
807 <string name="bit" product="phablet">hoot</string>
808 <string name="bot" product="default">yes</string>)";
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700809 ASSERT_TRUE(TestParse(input));
Adam Lesinski9ba47d82015-10-13 11:37:10 -0700810
Adam Lesinskia45893a2017-05-30 15:19:02 -0700811 ASSERT_THAT(test::GetValueForConfigAndProduct<String>(&table_, "string/foo", ConfigDescription::DefaultConfig(), "phone"), NotNull());
812 ASSERT_THAT(test::GetValueForConfigAndProduct<String>(&table_, "string/foo",ConfigDescription::DefaultConfig(), "no-sdcard"), NotNull());
813 ASSERT_THAT(test::GetValueForConfigAndProduct<String>(&table_, "string/bar", ConfigDescription::DefaultConfig(), ""), NotNull());
814 ASSERT_THAT(test::GetValueForConfigAndProduct<String>(&table_, "string/baz", ConfigDescription::DefaultConfig(), ""), NotNull());
815 ASSERT_THAT(test::GetValueForConfigAndProduct<String>(&table_, "string/bit", ConfigDescription::DefaultConfig(), "phablet"), NotNull());
816 ASSERT_THAT(test::GetValueForConfigAndProduct<String>(&table_, "string/bot", ConfigDescription::DefaultConfig(), "default"), NotNull());
Adam Lesinski9ba47d82015-10-13 11:37:10 -0700817}
818
Adam Lesinski27afb9e2015-11-06 18:25:04 -0800819TEST_F(ResourceParserTest, AutoIncrementIdsInPublicGroup) {
Adam Lesinskia45893a2017-05-30 15:19:02 -0700820 std::string input = R"(
821 <public-group type="attr" first-id="0x01010040">
822 <public name="foo" />
823 <public name="bar" />
824 </public-group>)";
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700825 ASSERT_TRUE(TestParse(input));
Adam Lesinski27afb9e2015-11-06 18:25:04 -0800826
Adam Lesinskia45893a2017-05-30 15:19:02 -0700827 Maybe<ResourceTable::SearchResult> result = table_.FindResource(test::ParseNameOrDie("attr/foo"));
828 ASSERT_TRUE(result);
Adam Lesinski27afb9e2015-11-06 18:25:04 -0800829
Adam Lesinskia45893a2017-05-30 15:19:02 -0700830 ASSERT_TRUE(result.value().package->id);
831 ASSERT_TRUE(result.value().type->id);
832 ASSERT_TRUE(result.value().entry->id);
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700833 ResourceId actual_id(result.value().package->id.value(),
834 result.value().type->id.value(),
835 result.value().entry->id.value());
Adam Lesinskia45893a2017-05-30 15:19:02 -0700836 EXPECT_THAT(actual_id, Eq(ResourceId(0x01010040)));
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700837
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700838 result = table_.FindResource(test::ParseNameOrDie("attr/bar"));
Adam Lesinskia45893a2017-05-30 15:19:02 -0700839 ASSERT_TRUE(result);
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700840
Adam Lesinskia45893a2017-05-30 15:19:02 -0700841 ASSERT_TRUE(result.value().package->id);
842 ASSERT_TRUE(result.value().type->id);
843 ASSERT_TRUE(result.value().entry->id);
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700844 actual_id = ResourceId(result.value().package->id.value(),
845 result.value().type->id.value(),
846 result.value().entry->id.value());
Adam Lesinskia45893a2017-05-30 15:19:02 -0700847 EXPECT_THAT(actual_id, Eq(ResourceId(0x01010041)));
Adam Lesinski27afb9e2015-11-06 18:25:04 -0800848}
849
Adam Lesinski71be7052017-12-12 16:48:07 -0800850TEST_F(ResourceParserTest, StrongestSymbolVisibilityWins) {
851 std::string input = R"(
852 <!-- private -->
853 <java-symbol type="string" name="foo" />
854 <!-- public -->
855 <public type="string" name="foo" id="0x01020000" />
856 <!-- private2 -->
857 <java-symbol type="string" name="foo" />)";
858 ASSERT_TRUE(TestParse(input));
859
860 Maybe<ResourceTable::SearchResult> result =
861 table_.FindResource(test::ParseNameOrDie("string/foo"));
862 ASSERT_TRUE(result);
863
864 ResourceEntry* entry = result.value().entry;
865 ASSERT_THAT(entry, NotNull());
866 EXPECT_THAT(entry->visibility.level, Eq(Visibility::Level::kPublic));
867 EXPECT_THAT(entry->visibility.comment, StrEq("public"));
868}
869
Adam Lesinskifa105052015-11-07 13:34:39 -0800870TEST_F(ResourceParserTest, ExternalTypesShouldOnlyBeReferences) {
Adam Lesinskia45893a2017-05-30 15:19:02 -0700871 ASSERT_TRUE(TestParse(R"(<item type="layout" name="foo">@layout/bar</item>)"));
872 ASSERT_FALSE(TestParse(R"(<item type="layout" name="bar">"this is a string"</item>)"));
Adam Lesinskifa105052015-11-07 13:34:39 -0800873}
874
Adam Lesinski4488f1c2017-05-26 17:33:38 -0700875TEST_F(ResourceParserTest, AddResourcesElementShouldAddEntryWithUndefinedSymbol) {
Adam Lesinskia45893a2017-05-30 15:19:02 -0700876 ASSERT_TRUE(TestParse(R"(<add-resource name="bar" type="string" />)"));
Adam Lesinskia6fe3452015-12-09 15:20:52 -0800877
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700878 Maybe<ResourceTable::SearchResult> result =
Adam Lesinskice5e56e2016-10-21 17:56:45 -0700879 table_.FindResource(test::ParseNameOrDie("string/bar"));
Adam Lesinskia45893a2017-05-30 15:19:02 -0700880 ASSERT_TRUE(result);
Adam Lesinskicacb28f2016-10-19 12:18:14 -0700881 const ResourceEntry* entry = result.value().entry;
Adam Lesinskia45893a2017-05-30 15:19:02 -0700882 ASSERT_THAT(entry, NotNull());
Adam Lesinski71be7052017-12-12 16:48:07 -0800883 EXPECT_THAT(entry->visibility.level, Eq(Visibility::Level::kUndefined));
884 EXPECT_TRUE(entry->allow_new);
Adam Lesinskia6fe3452015-12-09 15:20:52 -0800885}
886
Adam Lesinski7ff3ee12015-12-14 16:08:50 -0800887TEST_F(ResourceParserTest, ParseItemElementWithFormat) {
Adam Lesinskia45893a2017-05-30 15:19:02 -0700888 ASSERT_TRUE(TestParse(R"(<item name="foo" type="integer" format="float">0.3</item>)"));
Adam Lesinski7ff3ee12015-12-14 16:08:50 -0800889
Adam Lesinskie597d682017-06-01 17:16:44 -0700890 BinaryPrimitive* val = test::GetValue<BinaryPrimitive>(&table_, "integer/foo");
891 ASSERT_THAT(val, NotNull());
Adam Lesinskia45893a2017-05-30 15:19:02 -0700892 EXPECT_THAT(val->value.dataType, Eq(Res_value::TYPE_FLOAT));
Adam Lesinski7ff3ee12015-12-14 16:08:50 -0800893
Adam Lesinskia45893a2017-05-30 15:19:02 -0700894 ASSERT_FALSE(TestParse(R"(<item name="bar" type="integer" format="fraction">100</item>)"));
Adam Lesinskie597d682017-06-01 17:16:44 -0700895}
896
897// An <item> without a format specifier accepts all types of values.
898TEST_F(ResourceParserTest, ParseItemElementWithoutFormat) {
Adam Lesinskia45893a2017-05-30 15:19:02 -0700899 ASSERT_TRUE(TestParse(R"(<item name="foo" type="integer">100%p</item>)"));
Adam Lesinskie597d682017-06-01 17:16:44 -0700900
901 BinaryPrimitive* val = test::GetValue<BinaryPrimitive>(&table_, "integer/foo");
902 ASSERT_THAT(val, NotNull());
Adam Lesinskia45893a2017-05-30 15:19:02 -0700903 EXPECT_THAT(val->value.dataType, Eq(Res_value::TYPE_FRACTION));
Adam Lesinski7ff3ee12015-12-14 16:08:50 -0800904}
905
Adam Lesinski86d67df2017-01-31 13:47:27 -0800906TEST_F(ResourceParserTest, ParseConfigVaryingItem) {
Adam Lesinskia45893a2017-05-30 15:19:02 -0700907 ASSERT_TRUE(TestParse(R"(<item name="foo" type="configVarying">Hey</item>)"));
908 ASSERT_THAT(test::GetValue<String>(&table_, "configVarying/foo"), NotNull());
Adam Lesinski86d67df2017-01-31 13:47:27 -0800909}
910
911TEST_F(ResourceParserTest, ParseBagElement) {
Adam Lesinskia45893a2017-05-30 15:19:02 -0700912 std::string input = R"(
913 <bag name="bag" type="configVarying">
914 <item name="test">Hello!</item>
915 </bag>)";
Adam Lesinski86d67df2017-01-31 13:47:27 -0800916 ASSERT_TRUE(TestParse(input));
917
918 Style* val = test::GetValue<Style>(&table_, "configVarying/bag");
Adam Lesinskia45893a2017-05-30 15:19:02 -0700919 ASSERT_THAT(val, NotNull());
920 ASSERT_THAT(val->entries, SizeIs(1));
Adam Lesinski86d67df2017-01-31 13:47:27 -0800921
Adam Lesinskia45893a2017-05-30 15:19:02 -0700922 EXPECT_THAT(val->entries[0].key, Eq(Reference(test::ParseNameOrDie("attr/test"))));
923 EXPECT_THAT(ValueCast<RawString>(val->entries[0].value.get()), NotNull());
Adam Lesinski86d67df2017-01-31 13:47:27 -0800924}
925
Adam Lesinskibab4ef52017-06-01 15:22:57 -0700926TEST_F(ResourceParserTest, ParseElementWithNoValue) {
927 std::string input = R"(
928 <item type="drawable" format="reference" name="foo" />
929 <string name="foo" />)";
930 ASSERT_TRUE(TestParse(input));
931 ASSERT_THAT(test::GetValue(&table_, "drawable/foo"), Pointee(ValueEq(Reference())));
932
933 String* str = test::GetValue<String>(&table_, "string/foo");
934 ASSERT_THAT(str, NotNull());
Adam Lesinskia45893a2017-05-30 15:19:02 -0700935 EXPECT_THAT(*str, StrValueEq(""));
Adam Lesinskibab4ef52017-06-01 15:22:57 -0700936}
937
Adam Lesinskib9f05482017-06-02 16:32:37 -0700938TEST_F(ResourceParserTest, ParsePlatformIndependentNewline) {
Adam Lesinskia45893a2017-05-30 15:19:02 -0700939 ASSERT_TRUE(TestParse(R"(<string name="foo">%1$s %n %2$s</string>)"));
Adam Lesinskib9f05482017-06-02 16:32:37 -0700940}
941
Ryan Mitchelle4e989c2018-10-29 02:21:50 -0700942TEST_F(ResourceParserTest, ParseOverlayable) {
Ryan Mitchell54237ff2018-12-13 15:44:29 -0800943 std::string input = R"(
944 <overlayable name="Name" actor="overlay://theme">
Winsonb2d7f532019-02-04 16:32:43 -0800945 <policy type="signature">
946 <item type="string" name="foo" />
947 <item type="drawable" name="bar" />
948 </policy>
Adam Lesinski46c4d722017-08-23 13:03:56 -0700949 </overlayable>)";
950 ASSERT_TRUE(TestParse(input));
Adam Lesinski71be7052017-12-12 16:48:07 -0800951
Ryan Mitchelle4e989c2018-10-29 02:21:50 -0700952 auto search_result = table_.FindResource(test::ParseNameOrDie("string/foo"));
Adam Lesinski71be7052017-12-12 16:48:07 -0800953 ASSERT_TRUE(search_result);
954 ASSERT_THAT(search_result.value().entry, NotNull());
Ryan Mitchell54237ff2018-12-13 15:44:29 -0800955 ASSERT_TRUE(search_result.value().entry->overlayable_item);
956 OverlayableItem& result_overlayable_item = search_result.value().entry->overlayable_item.value();
957 EXPECT_THAT(result_overlayable_item.overlayable->name, Eq("Name"));
958 EXPECT_THAT(result_overlayable_item.overlayable->actor, Eq("overlay://theme"));
Winsonb2d7f532019-02-04 16:32:43 -0800959 EXPECT_THAT(result_overlayable_item.policies, Eq(OverlayableItem::Policy::kSignature));
Ryan Mitchelle4e989c2018-10-29 02:21:50 -0700960
961 search_result = table_.FindResource(test::ParseNameOrDie("drawable/bar"));
962 ASSERT_TRUE(search_result);
963 ASSERT_THAT(search_result.value().entry, NotNull());
Ryan Mitchell54237ff2018-12-13 15:44:29 -0800964 ASSERT_TRUE(search_result.value().entry->overlayable_item);
965 result_overlayable_item = search_result.value().entry->overlayable_item.value();
966 EXPECT_THAT(result_overlayable_item.overlayable->name, Eq("Name"));
967 EXPECT_THAT(result_overlayable_item.overlayable->actor, Eq("overlay://theme"));
Winsonb2d7f532019-02-04 16:32:43 -0800968 EXPECT_THAT(result_overlayable_item.policies, Eq(OverlayableItem::Policy::kSignature));
Ryan Mitchell54237ff2018-12-13 15:44:29 -0800969}
970
971TEST_F(ResourceParserTest, ParseOverlayableRequiresName) {
972 EXPECT_FALSE(TestParse(R"(<overlayable actor="overlay://theme" />)"));
973 EXPECT_TRUE(TestParse(R"(<overlayable name="Name" />)"));
974 EXPECT_TRUE(TestParse(R"(<overlayable name="Name" actor="overlay://theme" />)"));
975}
976
977TEST_F(ResourceParserTest, ParseOverlayableBadActorFail) {
978 EXPECT_FALSE(TestParse(R"(<overlayable name="Name" actor="overley://theme" />)"));
Ryan Mitchelle4e989c2018-10-29 02:21:50 -0700979}
980
981TEST_F(ResourceParserTest, ParseOverlayablePolicy) {
Ryan Mitchell54237ff2018-12-13 15:44:29 -0800982 std::string input = R"(
983 <overlayable name="Name">
Ryan Mitchelle4e989c2018-10-29 02:21:50 -0700984 <policy type="product">
985 <item type="string" name="bar" />
986 </policy>
Ryan Mitchelle4e989c2018-10-29 02:21:50 -0700987 <policy type="system">
988 <item type="string" name="fiz" />
989 </policy>
990 <policy type="vendor">
991 <item type="string" name="fuz" />
992 </policy>
993 <policy type="public">
994 <item type="string" name="faz" />
995 </policy>
Winsonb2d7f532019-02-04 16:32:43 -0800996 <policy type="signature">
997 <item type="string" name="foz" />
998 </policy>
Ryan Mitchell939df092019-04-09 17:13:50 -0700999 <policy type="odm">
1000 <item type="string" name="biz" />
1001 </policy>
1002 <policy type="oem">
1003 <item type="string" name="buz" />
1004 </policy>
Ryan Mitchelle4e989c2018-10-29 02:21:50 -07001005 </overlayable>)";
1006 ASSERT_TRUE(TestParse(input));
1007
Winsonb2d7f532019-02-04 16:32:43 -08001008 auto search_result = table_.FindResource(test::ParseNameOrDie("string/bar"));
Ryan Mitchelle4e989c2018-10-29 02:21:50 -07001009 ASSERT_TRUE(search_result);
1010 ASSERT_THAT(search_result.value().entry, NotNull());
Ryan Mitchell54237ff2018-12-13 15:44:29 -08001011 ASSERT_TRUE(search_result.value().entry->overlayable_item);
1012 OverlayableItem result_overlayable_item = search_result.value().entry->overlayable_item.value();
1013 EXPECT_THAT(result_overlayable_item.overlayable->name, Eq("Name"));
Ryan Mitchell54237ff2018-12-13 15:44:29 -08001014 EXPECT_THAT(result_overlayable_item.policies, Eq(OverlayableItem::Policy::kProduct));
Ryan Mitchelle4e989c2018-10-29 02:21:50 -07001015
Ryan Mitchelle4e989c2018-10-29 02:21:50 -07001016 search_result = table_.FindResource(test::ParseNameOrDie("string/fiz"));
1017 ASSERT_TRUE(search_result);
1018 ASSERT_THAT(search_result.value().entry, NotNull());
Ryan Mitchell54237ff2018-12-13 15:44:29 -08001019 ASSERT_TRUE(search_result.value().entry->overlayable_item);
1020 result_overlayable_item = search_result.value().entry->overlayable_item.value();
1021 EXPECT_THAT(result_overlayable_item.overlayable->name, Eq("Name"));
1022 EXPECT_THAT(result_overlayable_item.policies, Eq(OverlayableItem::Policy::kSystem));
Ryan Mitchelle4e989c2018-10-29 02:21:50 -07001023
1024 search_result = table_.FindResource(test::ParseNameOrDie("string/fuz"));
1025 ASSERT_TRUE(search_result);
1026 ASSERT_THAT(search_result.value().entry, NotNull());
Ryan Mitchell54237ff2018-12-13 15:44:29 -08001027 ASSERT_TRUE(search_result.value().entry->overlayable_item);
1028 result_overlayable_item = search_result.value().entry->overlayable_item.value();
1029 EXPECT_THAT(result_overlayable_item.overlayable->name, Eq("Name"));
1030 EXPECT_THAT(result_overlayable_item.policies, Eq(OverlayableItem::Policy::kVendor));
Ryan Mitchelle4e989c2018-10-29 02:21:50 -07001031
1032 search_result = table_.FindResource(test::ParseNameOrDie("string/faz"));
1033 ASSERT_TRUE(search_result);
1034 ASSERT_THAT(search_result.value().entry, NotNull());
Ryan Mitchell54237ff2018-12-13 15:44:29 -08001035 ASSERT_TRUE(search_result.value().entry->overlayable_item);
1036 result_overlayable_item = search_result.value().entry->overlayable_item.value();
1037 EXPECT_THAT(result_overlayable_item.overlayable->name, Eq("Name"));
1038 EXPECT_THAT(result_overlayable_item.policies, Eq(OverlayableItem::Policy::kPublic));
Winsonb2d7f532019-02-04 16:32:43 -08001039
1040 search_result = table_.FindResource(test::ParseNameOrDie("string/foz"));
1041 ASSERT_TRUE(search_result);
1042 ASSERT_THAT(search_result.value().entry, NotNull());
1043 ASSERT_TRUE(search_result.value().entry->overlayable_item);
1044 result_overlayable_item = search_result.value().entry->overlayable_item.value();
1045 EXPECT_THAT(result_overlayable_item.overlayable->name, Eq("Name"));
1046 EXPECT_THAT(result_overlayable_item.policies, Eq(OverlayableItem::Policy::kSignature));
Ryan Mitchell939df092019-04-09 17:13:50 -07001047
1048 search_result = table_.FindResource(test::ParseNameOrDie("string/biz"));
1049 ASSERT_TRUE(search_result);
1050 ASSERT_THAT(search_result.value().entry, NotNull());
1051 ASSERT_TRUE(search_result.value().entry->overlayable_item);
1052 result_overlayable_item = search_result.value().entry->overlayable_item.value();
1053 EXPECT_THAT(result_overlayable_item.overlayable->name, Eq("Name"));
1054 EXPECT_THAT(result_overlayable_item.policies, Eq(OverlayableItem::Policy::kOdm));
1055
1056 search_result = table_.FindResource(test::ParseNameOrDie("string/buz"));
1057 ASSERT_TRUE(search_result);
1058 ASSERT_THAT(search_result.value().entry, NotNull());
1059 ASSERT_TRUE(search_result.value().entry->overlayable_item);
1060 result_overlayable_item = search_result.value().entry->overlayable_item.value();
1061 EXPECT_THAT(result_overlayable_item.overlayable->name, Eq("Name"));
1062 EXPECT_THAT(result_overlayable_item.policies, Eq(OverlayableItem::Policy::kOem));
Winsonb2d7f532019-02-04 16:32:43 -08001063}
1064
1065TEST_F(ResourceParserTest, ParseOverlayableNoPolicyError) {
1066 std::string input = R"(
1067 <overlayable name="Name">
1068 <item type="string" name="foo" />
1069 </overlayable>)";
1070 EXPECT_FALSE(TestParse(input));
1071
1072 input = R"(
1073 <overlayable name="Name">
1074 <policy>
1075 <item name="foo" />
1076 </policy>
1077 </overlayable>)";
1078 EXPECT_FALSE(TestParse(input));
Ryan Mitchelle4e989c2018-10-29 02:21:50 -07001079}
1080
1081TEST_F(ResourceParserTest, ParseOverlayableBadPolicyError) {
1082 std::string input = R"(
Ryan Mitchell54237ff2018-12-13 15:44:29 -08001083 <overlayable name="Name">
Ryan Mitchelle4e989c2018-10-29 02:21:50 -07001084 <policy type="illegal_policy">
1085 <item type="string" name="foo" />
1086 </policy>
1087 </overlayable>)";
1088 EXPECT_FALSE(TestParse(input));
1089
1090 input = R"(
Ryan Mitchell54237ff2018-12-13 15:44:29 -08001091 <overlayable name="Name">
Ryan Mitchelle4e989c2018-10-29 02:21:50 -07001092 <policy type="product">
1093 <item name="foo" />
1094 </policy>
1095 </overlayable>)";
1096 EXPECT_FALSE(TestParse(input));
1097
1098 input = R"(
Ryan Mitchell54237ff2018-12-13 15:44:29 -08001099 <overlayable name="Name">
Ryan Mitchelle4e989c2018-10-29 02:21:50 -07001100 <policy type="vendor">
1101 <item type="string" />
1102 </policy>
1103 </overlayable>)";
1104 EXPECT_FALSE(TestParse(input));
1105}
1106
1107TEST_F(ResourceParserTest, ParseOverlayableMultiplePolicy) {
1108 std::string input = R"(
Ryan Mitchell54237ff2018-12-13 15:44:29 -08001109 <overlayable name="Name">
Ryan Mitchell02d9c1e2019-01-11 16:36:58 -08001110 <policy type="vendor|public">
Ryan Mitchelle4e989c2018-10-29 02:21:50 -07001111 <item type="string" name="foo" />
1112 </policy>
1113 <policy type="product|system">
1114 <item type="string" name="bar" />
1115 </policy>
1116 </overlayable>)";
1117 ASSERT_TRUE(TestParse(input));
1118
1119 auto search_result = table_.FindResource(test::ParseNameOrDie("string/foo"));
1120 ASSERT_TRUE(search_result);
1121 ASSERT_THAT(search_result.value().entry, NotNull());
Ryan Mitchell54237ff2018-12-13 15:44:29 -08001122 ASSERT_TRUE(search_result.value().entry->overlayable_item);
1123 OverlayableItem result_overlayable_item = search_result.value().entry->overlayable_item.value();
1124 EXPECT_THAT(result_overlayable_item.overlayable->name, Eq("Name"));
1125 EXPECT_THAT(result_overlayable_item.policies, Eq(OverlayableItem::Policy::kVendor
Ryan Mitchell02d9c1e2019-01-11 16:36:58 -08001126 | OverlayableItem::Policy::kPublic));
Ryan Mitchelle4e989c2018-10-29 02:21:50 -07001127
1128 search_result = table_.FindResource(test::ParseNameOrDie("string/bar"));
1129 ASSERT_TRUE(search_result);
1130 ASSERT_THAT(search_result.value().entry, NotNull());
Ryan Mitchell54237ff2018-12-13 15:44:29 -08001131 ASSERT_TRUE(search_result.value().entry->overlayable_item);
1132 result_overlayable_item = search_result.value().entry->overlayable_item.value();
1133 EXPECT_THAT(result_overlayable_item.overlayable->name, Eq("Name"));
1134 EXPECT_THAT(result_overlayable_item.policies, Eq(OverlayableItem::Policy::kProduct
1135 | OverlayableItem::Policy::kSystem));
Adam Lesinski71be7052017-12-12 16:48:07 -08001136}
1137
1138TEST_F(ResourceParserTest, DuplicateOverlayableIsError) {
1139 std::string input = R"(
Ryan Mitchell54237ff2018-12-13 15:44:29 -08001140 <overlayable name="Name">
Adam Lesinski71be7052017-12-12 16:48:07 -08001141 <item type="string" name="foo" />
1142 <item type="string" name="foo" />
1143 </overlayable>)";
1144 EXPECT_FALSE(TestParse(input));
Ryan Mitchelle4e989c2018-10-29 02:21:50 -07001145
1146 input = R"(
Ryan Mitchell54237ff2018-12-13 15:44:29 -08001147 <overlayable name="Name">
Ryan Mitchelle4e989c2018-10-29 02:21:50 -07001148 <item type="string" name="foo" />
1149 </overlayable>
Ryan Mitchell54237ff2018-12-13 15:44:29 -08001150 <overlayable name="Name">
Ryan Mitchelle4e989c2018-10-29 02:21:50 -07001151 <item type="string" name="foo" />
1152 </overlayable>)";
1153 EXPECT_FALSE(TestParse(input));
1154
1155 input = R"(
Ryan Mitchell54237ff2018-12-13 15:44:29 -08001156 <overlayable name="Name">
1157 <item type="string" name="foo" />
1158 </overlayable>
1159 <overlayable name="Other">
1160 <item type="string" name="foo" />
1161 </overlayable>)";
1162 EXPECT_FALSE(TestParse(input));
1163
1164 input = R"(
1165 <overlayable name="Name" actor="overlay://my.actor.one">
1166 <item type="string" name="foo" />
1167 </overlayable>
1168 <overlayable name="Other" actor="overlay://my.actor.two">
1169 <item type="string" name="foo" />
1170 </overlayable>)";
1171 EXPECT_FALSE(TestParse(input));
1172
1173 input = R"(
1174 <overlayable name="Name">
Ryan Mitchelle4e989c2018-10-29 02:21:50 -07001175 <policy type="product">
1176 <item type="string" name="foo" />
1177 <item type="string" name="foo" />
1178 </policy>
1179 </overlayable>)";
1180 EXPECT_FALSE(TestParse(input));
1181
1182 input = R"(
Ryan Mitchell54237ff2018-12-13 15:44:29 -08001183 <overlayable name="Name">
Ryan Mitchelle4e989c2018-10-29 02:21:50 -07001184 <policy type="product">
1185 <item type="string" name="foo" />
1186 </policy>
Ryan Mitchell1bb1fe02018-11-16 11:21:41 -08001187 <item type="string" name="foo" />
1188 </overlayable>)";
1189 EXPECT_FALSE(TestParse(input));
1190
1191 input = R"(
Ryan Mitchell54237ff2018-12-13 15:44:29 -08001192 <overlayable name="Name">
Ryan Mitchell1bb1fe02018-11-16 11:21:41 -08001193 <policy type="product">
1194 <item type="string" name="foo" />
1195 </policy>
1196 <policy type="vendor">
1197 <item type="string" name="foo" />
1198 </policy>
1199 </overlayable>)";
1200 EXPECT_FALSE(TestParse(input));
1201
1202 input = R"(
Ryan Mitchell54237ff2018-12-13 15:44:29 -08001203 <overlayable name="Name">
Ryan Mitchell1bb1fe02018-11-16 11:21:41 -08001204 <policy type="product">
1205 <item type="string" name="foo" />
1206 </policy>
Ryan Mitchelle4e989c2018-10-29 02:21:50 -07001207 </overlayable>
1208
Ryan Mitchell54237ff2018-12-13 15:44:29 -08001209 <overlayable name="Name">
Ryan Mitchelle4e989c2018-10-29 02:21:50 -07001210 <policy type="product">
1211 <item type="string" name="foo" />
1212 </policy>
1213 </overlayable>)";
1214 EXPECT_FALSE(TestParse(input));
1215}
1216
Ryan Mitchelle4e989c2018-10-29 02:21:50 -07001217TEST_F(ResourceParserTest, NestPolicyInOverlayableError) {
1218 std::string input = R"(
Ryan Mitchell54237ff2018-12-13 15:44:29 -08001219 <overlayable name="Name">
Ryan Mitchelle4e989c2018-10-29 02:21:50 -07001220 <policy type="vendor|product">
Ryan Mitchell02d9c1e2019-01-11 16:36:58 -08001221 <policy type="public">
Ryan Mitchelle4e989c2018-10-29 02:21:50 -07001222 <item type="string" name="foo" />
1223 </policy>
1224 </policy>
1225 </overlayable>)";
1226 EXPECT_FALSE(TestParse(input));
Adam Lesinski46c4d722017-08-23 13:03:56 -07001227}
1228
y9efbbef2018-04-18 11:29:09 -07001229TEST_F(ResourceParserTest, ParseIdItem) {
1230 std::string input = R"(
1231 <item name="foo" type="id">@id/bar</item>
1232 <item name="bar" type="id"/>
1233 <item name="baz" type="id"></item>)";
1234 ASSERT_TRUE(TestParse(input));
1235
1236 ASSERT_THAT(test::GetValue<Reference>(&table_, "id/foo"), NotNull());
1237 ASSERT_THAT(test::GetValue<Id>(&table_, "id/bar"), NotNull());
1238 ASSERT_THAT(test::GetValue<Id>(&table_, "id/baz"), NotNull());
1239
Ryan Mitchelleaf77e12018-04-25 15:00:50 -07001240 input = R"(
1241 <id name="foo2">@id/bar</id>
1242 <id name="bar2"/>
1243 <id name="baz2"></id>)";
1244 ASSERT_TRUE(TestParse(input));
1245
1246 ASSERT_THAT(test::GetValue<Reference>(&table_, "id/foo2"), NotNull());
1247 ASSERT_THAT(test::GetValue<Id>(&table_, "id/bar2"), NotNull());
1248 ASSERT_THAT(test::GetValue<Id>(&table_, "id/baz2"), NotNull());
1249
y9efbbef2018-04-18 11:29:09 -07001250 // Reject attribute references
Ryan Mitchelleaf77e12018-04-25 15:00:50 -07001251 input = R"(<item name="foo3" type="id">?attr/bar"</item>)";
y9efbbef2018-04-18 11:29:09 -07001252 ASSERT_FALSE(TestParse(input));
1253
1254 // Reject non-references
Ryan Mitchelleaf77e12018-04-25 15:00:50 -07001255 input = R"(<item name="foo4" type="id">0x7f010001</item>)";
y9efbbef2018-04-18 11:29:09 -07001256 ASSERT_FALSE(TestParse(input));
Ryan Mitchelleaf77e12018-04-25 15:00:50 -07001257 input = R"(<item name="foo5" type="id">@drawable/my_image</item>)";
y9efbbef2018-04-18 11:29:09 -07001258 ASSERT_FALSE(TestParse(input));
Ryan Mitchelleaf77e12018-04-25 15:00:50 -07001259 input = R"(<item name="foo6" type="id"><string name="biz"></string></item>)";
y9efbbef2018-04-18 11:29:09 -07001260 ASSERT_FALSE(TestParse(input));
1261
1262 // Ids that reference other resource ids cannot be public
Ryan Mitchelleaf77e12018-04-25 15:00:50 -07001263 input = R"(<public name="foo7" type="id">@id/bar7</item>)";
y9efbbef2018-04-18 11:29:09 -07001264 ASSERT_FALSE(TestParse(input));
1265}
1266
Ryan Mitchellcb76d732018-06-05 10:15:04 -07001267TEST_F(ResourceParserTest, ParseCData) {
Ryan Mitchell1d358ff2019-03-06 15:06:49 -08001268 // Double quotes should still change the state of whitespace processing
1269 std::string input = R"(<string name="foo">Hello<![CDATA[ "</string>' ]]> World</string>)";
Ryan Mitchellcb76d732018-06-05 10:15:04 -07001270 ASSERT_TRUE(TestParse(input));
Ryan Mitchell1d358ff2019-03-06 15:06:49 -08001271 auto output = test::GetValue<String>(&table_, "string/foo");
Ryan Mitchellcb76d732018-06-05 10:15:04 -07001272 ASSERT_THAT(output, NotNull());
Ryan Mitchell1d358ff2019-03-06 15:06:49 -08001273 EXPECT_THAT(*output, StrValueEq(std::string("Hello </string>' World").data()));
Ryan Mitchellcb76d732018-06-05 10:15:04 -07001274
Ryan Mitchell1d358ff2019-03-06 15:06:49 -08001275 input = R"(<string name="foo2"><![CDATA[Hello
1276 World]]></string>)";
Ryan Mitchellcb76d732018-06-05 10:15:04 -07001277 ASSERT_TRUE(TestParse(input));
1278 output = test::GetValue<String>(&table_, "string/foo2");
1279 ASSERT_THAT(output, NotNull());
Ryan Mitchell1d358ff2019-03-06 15:06:49 -08001280 EXPECT_THAT(*output, StrValueEq(std::string("Hello World").data()));
Ryan Mitchellcb76d732018-06-05 10:15:04 -07001281
Ryan Mitchell1d358ff2019-03-06 15:06:49 -08001282 // Cdata blocks should have their whitespace trimmed
Ryan Mitchellcb76d732018-06-05 10:15:04 -07001283 input = R"(<string name="foo3"> <![CDATA[ text ]]> </string>)";
1284 ASSERT_TRUE(TestParse(input));
1285 output = test::GetValue<String>(&table_, "string/foo3");
1286 ASSERT_THAT(output, NotNull());
Ryan Mitchell1d358ff2019-03-06 15:06:49 -08001287 EXPECT_THAT(*output, StrValueEq(std::string("text").data()));
Ryan Mitchellcb76d732018-06-05 10:15:04 -07001288
1289 input = R"(<string name="foo4"> <![CDATA[]]> </string>)";
1290 ASSERT_TRUE(TestParse(input));
1291 output = test::GetValue<String>(&table_, "string/foo4");
1292 ASSERT_THAT(output, NotNull());
1293 EXPECT_THAT(*output, StrValueEq(std::string("").data()));
1294
1295 input = R"(<string name="foo5"> <![CDATA[ ]]> </string>)";
1296 ASSERT_TRUE(TestParse(input));
1297 output = test::GetValue<String>(&table_, "string/foo5");
1298 ASSERT_THAT(output, NotNull());
Ryan Mitchell1d358ff2019-03-06 15:06:49 -08001299 EXPECT_THAT(*output, StrValueEq(std::string("").data()));
1300
1301 // Single quotes must still be escaped
1302 input = R"(<string name="foo6"><![CDATA[some text and ' apostrophe]]></string>)";
1303 ASSERT_FALSE(TestParse(input));
Ryan Mitchellcb76d732018-06-05 10:15:04 -07001304}
1305
Adam Lesinskicacb28f2016-10-19 12:18:14 -07001306} // namespace aapt