blob: ebab1a72a227f4557175a26ac8f9afccef403d0d [file] [log] [blame]
Fyodor Kupolov74876572015-02-23 17:14:45 -08001/*
2 * Copyright (C) 2015 The Android Open Source Project
3 *
4 * Licensed under the Apache License, Version 2.0 (the "License");
5 * you may not use this file except in compliance with the License.
6 * You may obtain a copy of the License at
7 *
8 * http://www.apache.org/licenses/LICENSE-2.0
9 *
10 * Unless required by applicable law or agreed to in writing, software
11 * distributed under the License is distributed on an "AS IS" BASIS,
12 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13 * See the License for the specific language governing permissions and
14 * limitations under the License
15 */
16
17package com.android.server.pm;
18
Fyodor Kupolovb94c1652015-03-03 12:25:30 -080019import android.annotation.Nullable;
Fyodor Kupolova627c092015-05-05 18:44:39 -070020import android.content.Context;
Fyodor Kupolov74876572015-02-23 17:14:45 -080021import android.content.pm.ApplicationInfo;
22import android.content.pm.PackageParser;
Calin Juravle6ae39fc2018-01-19 20:32:47 -080023import android.content.pm.dex.ArtManager;
Calin Juravlecc651942018-02-01 17:20:51 +000024import android.content.pm.dex.DexMetadataHelper;
Calin Juravleadbadd52017-03-28 18:19:15 -070025import android.os.FileUtils;
Fyodor Kupolova627c092015-05-05 18:44:39 -070026import android.os.PowerManager;
Fyodor Kupolov28f28552017-05-02 12:11:02 -070027import android.os.SystemClock;
Nicolas Geoffray20a894e2017-09-08 13:01:40 +010028import android.os.SystemProperties;
Fyodor Kupolov74876572015-02-23 17:14:45 -080029import android.os.UserHandle;
Fyodor Kupolova627c092015-05-05 18:44:39 -070030import android.os.WorkSource;
Fyodor Kupolov74876572015-02-23 17:14:45 -080031import android.util.Log;
32import android.util.Slog;
33
Calin Juravle2d4b6ad72017-01-04 13:22:14 -080034import com.android.internal.annotations.GuardedBy;
Narayan Kamath88eea9e2016-05-02 14:44:31 +010035import com.android.internal.util.IndentingPrintWriter;
Jeff Sharkey740f5232016-12-09 14:31:26 -070036import com.android.server.pm.Installer.InstallerException;
Calin Juravle1d0e83d2017-07-17 15:12:01 -070037import com.android.server.pm.dex.DexoptOptions;
Calin Juravle19da1cf2017-07-12 18:52:49 -070038import com.android.server.pm.dex.DexoptUtils;
Calin Juravlef1ff36f2017-07-22 12:33:41 -070039import com.android.server.pm.dex.PackageDexUsage;
Jeff Sharkeyfdeeeea2016-01-11 17:34:24 -070040
Fyodor Kupolovb94c1652015-03-03 12:25:30 -080041import java.io.File;
Fyodor Kupolov74876572015-02-23 17:14:45 -080042import java.io.IOException;
Calin Juravle2d4b6ad72017-01-04 13:22:14 -080043import java.util.ArrayList;
Calin Juravle4c2b9552017-08-10 17:23:00 -070044import java.util.Arrays;
Fyodor Kupolov74876572015-02-23 17:14:45 -080045import java.util.List;
Calin Juravle41a57a62017-08-06 19:20:19 -070046import java.util.Map;
Fyodor Kupolov74876572015-02-23 17:14:45 -080047
48import dalvik.system.DexFile;
Fyodor Kupolov74876572015-02-23 17:14:45 -080049
Mathew Inwoode3299532018-02-22 13:19:53 +000050import static android.content.pm.ApplicationInfo.HIDDEN_API_ENFORCEMENT_NONE;
51
Todd Kennedyfa54ab72015-09-25 07:46:12 -070052import static com.android.server.pm.Installer.DEXOPT_BOOTCOMPLETE;
53import static com.android.server.pm.Installer.DEXOPT_DEBUGGABLE;
Andreas Gampebdd30d82016-03-20 11:32:11 -070054import static com.android.server.pm.Installer.DEXOPT_PROFILE_GUIDED;
Todd Kennedyfa54ab72015-09-25 07:46:12 -070055import static com.android.server.pm.Installer.DEXOPT_PUBLIC;
Calin Juravlec22c30e2017-01-16 19:18:48 -080056import static com.android.server.pm.Installer.DEXOPT_SECONDARY_DEX;
57import static com.android.server.pm.Installer.DEXOPT_FORCE;
58import static com.android.server.pm.Installer.DEXOPT_STORAGE_CE;
59import static com.android.server.pm.Installer.DEXOPT_STORAGE_DE;
David Sehr2118ec42017-10-25 14:28:29 -070060import static com.android.server.pm.Installer.DEXOPT_IDLE_BACKGROUND_JOB;
David Brazdilf7e31c02018-02-13 17:04:26 +000061import static com.android.server.pm.Installer.DEXOPT_ENABLE_HIDDEN_API_CHECKS;
Mathieu Chartierfa3e9762018-03-06 18:28:22 -080062import static com.android.server.pm.Installer.DEXOPT_GENERATE_COMPACT_DEX;
Mathieu Chartiera9c34332018-03-12 17:11:07 -070063import static com.android.server.pm.Installer.DEXOPT_GENERATE_APP_IMAGE;
Fyodor Kupolov74876572015-02-23 17:14:45 -080064import static com.android.server.pm.InstructionSets.getAppDexInstructionSets;
65import static com.android.server.pm.InstructionSets.getDexCodeInstructionSets;
Calin Juravle2d4b6ad72017-01-04 13:22:14 -080066
Fyodor Kupolov28f28552017-05-02 12:11:02 -070067import static com.android.server.pm.PackageManagerService.WATCHDOG_TIMEOUT;
Nicolas Geoffrayb0818e82017-05-05 10:23:19 +010068
Calin Juravle4bc8f4d2018-02-12 12:00:44 -080069import static com.android.server.pm.PackageManagerServiceCompilerMapping.getReasonName;
70
Nicolas Geoffrayd093b202017-05-03 13:11:58 +010071import static dalvik.system.DexFile.getSafeModeCompilerFilter;
Calin Juravle2d4b6ad72017-01-04 13:22:14 -080072import static dalvik.system.DexFile.isProfileGuidedCompilerFilter;
Fyodor Kupolov74876572015-02-23 17:14:45 -080073
74/**
75 * Helper class for running dexopt command on packages.
76 */
Calin Juravlec22c30e2017-01-16 19:18:48 -080077public class PackageDexOptimizer {
Fyodor Kupolovb94c1652015-03-03 12:25:30 -080078 private static final String TAG = "PackageManager.DexOptimizer";
79 static final String OAT_DIR_NAME = "oat";
80 // TODO b/19550105 Remove error codes and use exceptions
Calin Juravlec22c30e2017-01-16 19:18:48 -080081 public static final int DEX_OPT_SKIPPED = 0;
82 public static final int DEX_OPT_PERFORMED = 1;
83 public static final int DEX_OPT_FAILED = -1;
Fyodor Kupolov28f28552017-05-02 12:11:02 -070084 // One minute over PM WATCHDOG_TIMEOUT
85 private static final long WAKELOCK_TIMEOUT_MS = WATCHDOG_TIMEOUT + 1000 * 60;
Fyodor Kupolov74876572015-02-23 17:14:45 -080086
Calin Juravleaae35762017-02-14 17:53:13 -080087 /** Special library name that skips shared libraries check during compilation. */
88 public static final String SKIP_SHARED_LIBRARY_CHECK = "&";
89
Fyodor Kupolov28f28552017-05-02 12:11:02 -070090 @GuardedBy("mInstallLock")
Andreas Gampea8908752015-11-10 08:58:14 -080091 private final Installer mInstaller;
92 private final Object mInstallLock;
Fyodor Kupolov74876572015-02-23 17:14:45 -080093
Fyodor Kupolov28f28552017-05-02 12:11:02 -070094 @GuardedBy("mInstallLock")
Fyodor Kupolova627c092015-05-05 18:44:39 -070095 private final PowerManager.WakeLock mDexoptWakeLock;
96 private volatile boolean mSystemReady;
97
Andreas Gampea8908752015-11-10 08:58:14 -080098 PackageDexOptimizer(Installer installer, Object installLock, Context context,
99 String wakeLockTag) {
100 this.mInstaller = installer;
101 this.mInstallLock = installLock;
102
103 PowerManager powerManager = (PowerManager)context.getSystemService(Context.POWER_SERVICE);
104 mDexoptWakeLock = powerManager.newWakeLock(PowerManager.PARTIAL_WAKE_LOCK, wakeLockTag);
105 }
106
107 protected PackageDexOptimizer(PackageDexOptimizer from) {
108 this.mInstaller = from.mInstaller;
109 this.mInstallLock = from.mInstallLock;
110 this.mDexoptWakeLock = from.mDexoptWakeLock;
111 this.mSystemReady = from.mSystemReady;
Fyodor Kupolov74876572015-02-23 17:14:45 -0800112 }
113
Calin Juravledb4a79a2015-12-23 18:55:08 +0200114 static boolean canOptimizePackage(PackageParser.Package pkg) {
Nicolas Geoffray20a894e2017-09-08 13:01:40 +0100115 // We do not dexopt a package with no code.
116 if ((pkg.applicationInfo.flags & ApplicationInfo.FLAG_HAS_CODE) == 0) {
117 return false;
118 }
119
Nicolas Geoffray20a894e2017-09-08 13:01:40 +0100120 return true;
Calin Juravledb4a79a2015-12-23 18:55:08 +0200121 }
122
Fyodor Kupolov74876572015-02-23 17:14:45 -0800123 /**
124 * Performs dexopt on all code paths and libraries of the specified package for specified
125 * instruction sets.
126 *
Andreas Gampea8908752015-11-10 08:58:14 -0800127 * <p>Calls to {@link com.android.server.pm.Installer#dexopt} on {@link #mInstaller} are
128 * synchronized on {@link #mInstallLock}.
Fyodor Kupolov74876572015-02-23 17:14:45 -0800129 */
Jeff Haoc7b94822016-03-16 15:56:07 -0700130 int performDexOpt(PackageParser.Package pkg, String[] sharedLibraries,
Calin Juravle1d0e83d2017-07-17 15:12:01 -0700131 String[] instructionSets, CompilerStats.PackageStats packageStats,
Calin Juravle3b74c412017-08-03 19:48:37 -0700132 PackageDexUsage.PackageUseInfo packageUseInfo, DexoptOptions options) {
Calin Juravlec6540da2017-11-15 16:28:01 -0800133 if (pkg.applicationInfo.uid == -1) {
134 throw new IllegalArgumentException("Dexopt for " + pkg.packageName
135 + " has invalid uid.");
136 }
Calin Juravle2d4b6ad72017-01-04 13:22:14 -0800137 if (!canOptimizePackage(pkg)) {
138 return DEX_OPT_SKIPPED;
139 }
Andreas Gampea8908752015-11-10 08:58:14 -0800140 synchronized (mInstallLock) {
Fyodor Kupolov28f28552017-05-02 12:11:02 -0700141 final long acquireTime = acquireWakeLockLI(pkg.applicationInfo.uid);
Fyodor Kupolova627c092015-05-05 18:44:39 -0700142 try {
Calin Juravle1d0e83d2017-07-17 15:12:01 -0700143 return performDexOptLI(pkg, sharedLibraries, instructionSets,
Calin Juravle3b74c412017-08-03 19:48:37 -0700144 packageStats, packageUseInfo, options);
Fyodor Kupolova627c092015-05-05 18:44:39 -0700145 } finally {
Fyodor Kupolov28f28552017-05-02 12:11:02 -0700146 releaseWakeLockLI(acquireTime);
Fyodor Kupolova627c092015-05-05 18:44:39 -0700147 }
Fyodor Kupolov74876572015-02-23 17:14:45 -0800148 }
149 }
150
Andreas Gampea8908752015-11-10 08:58:14 -0800151 /**
Calin Juravle2d4b6ad72017-01-04 13:22:14 -0800152 * Performs dexopt on all code paths of the given package.
153 * It assumes the install lock is held.
154 */
155 @GuardedBy("mInstallLock")
156 private int performDexOptLI(PackageParser.Package pkg, String[] sharedLibraries,
Calin Juravle1d0e83d2017-07-17 15:12:01 -0700157 String[] targetInstructionSets, CompilerStats.PackageStats packageStats,
Calin Juravle3b74c412017-08-03 19:48:37 -0700158 PackageDexUsage.PackageUseInfo packageUseInfo, DexoptOptions options) {
Calin Juravle2d4b6ad72017-01-04 13:22:14 -0800159 final String[] instructionSets = targetInstructionSets != null ?
160 targetInstructionSets : getAppDexInstructionSets(pkg.applicationInfo);
161 final String[] dexCodeInstructionSets = getDexCodeInstructionSets(instructionSets);
Jeff Hao5def5e52017-04-19 14:42:16 -0700162 final List<String> paths = pkg.getAllCodePaths();
Jeff Sharkeya73e1652017-11-15 19:07:14 -0700163
164 int sharedGid = UserHandle.getSharedAppGid(pkg.applicationInfo.uid);
165 if (sharedGid == -1) {
166 Slog.wtf(TAG, "Well this is awkward; package " + pkg.applicationInfo.name + " had UID "
167 + pkg.applicationInfo.uid, new Throwable());
168 sharedGid = android.os.Process.NOBODY_UID;
169 }
Calin Juravle2d4b6ad72017-01-04 13:22:14 -0800170
Calin Juravle19da1cf2017-07-12 18:52:49 -0700171 // Get the class loader context dependencies.
172 // For each code path in the package, this array contains the class loader context that
173 // needs to be passed to dexopt in order to ensure correct optimizations.
Calin Juravleda098152017-09-01 17:30:01 -0700174 boolean[] pathsWithCode = new boolean[paths.size()];
175 pathsWithCode[0] = (pkg.applicationInfo.flags & ApplicationInfo.FLAG_HAS_CODE) != 0;
176 for (int i = 1; i < paths.size(); i++) {
177 pathsWithCode[i] = (pkg.splitFlags[i - 1] & ApplicationInfo.FLAG_HAS_CODE) != 0;
178 }
Calin Juravle19da1cf2017-07-12 18:52:49 -0700179 String[] classLoaderContexts = DexoptUtils.getClassLoaderContexts(
Calin Juravleda098152017-09-01 17:30:01 -0700180 pkg.applicationInfo, sharedLibraries, pathsWithCode);
Calin Juravle2d4b6ad72017-01-04 13:22:14 -0800181
Calin Juravle4c2b9552017-08-10 17:23:00 -0700182 // Sanity check that we do not call dexopt with inconsistent data.
183 if (paths.size() != classLoaderContexts.length) {
184 String[] splitCodePaths = pkg.applicationInfo.getSplitCodePaths();
185 throw new IllegalStateException("Inconsistent information "
186 + "between PackageParser.Package and its ApplicationInfo. "
187 + "pkg.getAllCodePaths=" + paths
188 + " pkg.applicationInfo.getBaseCodePath=" + pkg.applicationInfo.getBaseCodePath()
189 + " pkg.applicationInfo.getSplitCodePaths="
190 + (splitCodePaths == null ? "null" : Arrays.toString(splitCodePaths)));
191 }
192
Calin Juravle2d4b6ad72017-01-04 13:22:14 -0800193 int result = DEX_OPT_SKIPPED;
Jeff Hao5def5e52017-04-19 14:42:16 -0700194 for (int i = 0; i < paths.size(); i++) {
195 // Skip paths that have no code.
Calin Juravleda098152017-09-01 17:30:01 -0700196 if (!pathsWithCode[i]) {
Jeff Hao5def5e52017-04-19 14:42:16 -0700197 continue;
198 }
Calin Juravleda098152017-09-01 17:30:01 -0700199 if (classLoaderContexts[i] == null) {
200 throw new IllegalStateException("Inconsistent information in the "
201 + "package structure. A split is marked to contain code "
202 + "but has no dependency listed. Index=" + i + " path=" + paths.get(i));
203 }
204
Jeff Hao5def5e52017-04-19 14:42:16 -0700205 // Append shared libraries with split dependencies for this split.
206 String path = paths.get(i);
Calin Juravleb6f844d2017-07-17 15:23:21 -0700207 if (options.getSplitName() != null) {
208 // We are asked to compile only a specific split. Check that the current path is
209 // what we are looking for.
210 if (!options.getSplitName().equals(new File(path).getName())) {
211 continue;
212 }
213 }
214
Calin Juravle6ae39fc2018-01-19 20:32:47 -0800215 String profileName = ArtManager.getProfileName(i == 0 ? null : pkg.splitNames[i - 1]);
216
Calin Juravlecc651942018-02-01 17:20:51 +0000217 String dexMetadataPath = null;
218 if (options.isDexoptInstallWithDexMetadata()) {
219 File dexMetadataFile = DexMetadataHelper.findDexMetadataForFile(new File(path));
220 dexMetadataPath = dexMetadataFile == null
221 ? null : dexMetadataFile.getAbsolutePath();
222 }
223
Calin Juravle3b74c412017-08-03 19:48:37 -0700224 final boolean isUsedByOtherApps = options.isDexoptAsSharedLibrary()
Calin Juravle52a452c2017-08-04 01:42:17 -0700225 || packageUseInfo.isUsedByOtherApps(path);
Calin Juravle3b74c412017-08-03 19:48:37 -0700226 final String compilerFilter = getRealCompilerFilter(pkg.applicationInfo,
227 options.getCompilerFilter(), isUsedByOtherApps);
228 final boolean profileUpdated = options.isCheckForProfileUpdates() &&
Calin Juravle6ae39fc2018-01-19 20:32:47 -0800229 isProfileUpdated(pkg, sharedGid, profileName, compilerFilter);
Calin Juravle3b74c412017-08-03 19:48:37 -0700230
231 // Get the dexopt flags after getRealCompilerFilter to make sure we get the correct
232 // flags.
Andreas Gampec041c332017-11-01 17:05:53 -0700233 final int dexoptFlags = getDexFlags(pkg, compilerFilter, options);
Calin Juravle3b74c412017-08-03 19:48:37 -0700234
Calin Juravle2d4b6ad72017-01-04 13:22:14 -0800235 for (String dexCodeIsa : dexCodeInstructionSets) {
Calin Juravle19da1cf2017-07-12 18:52:49 -0700236 int newResult = dexOptPath(pkg, path, dexCodeIsa, compilerFilter,
237 profileUpdated, classLoaderContexts[i], dexoptFlags, sharedGid,
Calin Juravle4bc8f4d2018-02-12 12:00:44 -0800238 packageStats, options.isDowngrade(), profileName, dexMetadataPath,
239 options.getCompilationReason());
Calin Juravle2d4b6ad72017-01-04 13:22:14 -0800240 // The end result is:
241 // - FAILED if any path failed,
242 // - PERFORMED if at least one path needed compilation,
243 // - SKIPPED when all paths are up to date
244 if ((result != DEX_OPT_FAILED) && (newResult != DEX_OPT_SKIPPED)) {
245 result = newResult;
246 }
247 }
248 }
249 return result;
250 }
251
252 /**
253 * Performs dexopt on the {@code path} belonging to the package {@code pkg}.
254 *
255 * @return
256 * DEX_OPT_FAILED if there was any exception during dexopt
257 * DEX_OPT_PERFORMED if dexopt was performed successfully on the given path.
258 * DEX_OPT_SKIPPED if the path does not need to be deopt-ed.
259 */
260 @GuardedBy("mInstallLock")
261 private int dexOptPath(PackageParser.Package pkg, String path, String isa,
Calin Juravle576e6c02017-09-12 00:58:33 -0700262 String compilerFilter, boolean profileUpdated, String classLoaderContext,
Calin Juravle6ae39fc2018-01-19 20:32:47 -0800263 int dexoptFlags, int uid, CompilerStats.PackageStats packageStats, boolean downgrade,
Calin Juravle4bc8f4d2018-02-12 12:00:44 -0800264 String profileName, String dexMetadataPath, int compilationReason) {
Calin Juravle576e6c02017-09-12 00:58:33 -0700265 int dexoptNeeded = getDexoptNeeded(path, isa, compilerFilter, classLoaderContext,
266 profileUpdated, downgrade);
Calin Juravle2d4b6ad72017-01-04 13:22:14 -0800267 if (Math.abs(dexoptNeeded) == DexFile.NO_DEXOPT_NEEDED) {
268 return DEX_OPT_SKIPPED;
269 }
270
271 // TODO(calin): there's no need to try to create the oat dir over and over again,
272 // especially since it involve an extra installd call. We should create
273 // if (if supported) on the fly during the dexopt call.
274 String oatDir = createOatDirIfSupported(pkg, isa);
275
276 Log.i(TAG, "Running dexopt (dexoptNeeded=" + dexoptNeeded + ") on: " + path
277 + " pkg=" + pkg.applicationInfo.packageName + " isa=" + isa
278 + " dexoptFlags=" + printDexoptFlags(dexoptFlags)
Calin Juravle576e6c02017-09-12 00:58:33 -0700279 + " targetFilter=" + compilerFilter + " oatDir=" + oatDir
280 + " classLoaderContext=" + classLoaderContext);
Calin Juravle2d4b6ad72017-01-04 13:22:14 -0800281
282 try {
283 long startTime = System.currentTimeMillis();
284
Shubham Ajmera246dccf2017-05-24 17:46:36 -0700285 // TODO: Consider adding 2 different APIs for primary and secondary dexopt.
286 // installd only uses downgrade flag for secondary dex files and ignores it for
287 // primary dex files.
Calin Juravle2d4b6ad72017-01-04 13:22:14 -0800288 mInstaller.dexopt(path, uid, pkg.packageName, isa, dexoptNeeded, oatDir, dexoptFlags,
Calin Juravle576e6c02017-09-12 00:58:33 -0700289 compilerFilter, pkg.volumeUuid, classLoaderContext, pkg.applicationInfo.seInfo,
Calin Juravle6ae39fc2018-01-19 20:32:47 -0800290 false /* downgrade*/, pkg.applicationInfo.targetSdkVersion,
Calin Juravle4bc8f4d2018-02-12 12:00:44 -0800291 profileName, dexMetadataPath, getReasonName(compilationReason));
Calin Juravle2d4b6ad72017-01-04 13:22:14 -0800292
293 if (packageStats != null) {
294 long endTime = System.currentTimeMillis();
295 packageStats.setCompileTime(path, (int)(endTime - startTime));
296 }
297 return DEX_OPT_PERFORMED;
298 } catch (InstallerException e) {
299 Slog.w(TAG, "Failed to dexopt", e);
300 return DEX_OPT_FAILED;
301 }
302 }
303
304 /**
Calin Juravlec22c30e2017-01-16 19:18:48 -0800305 * Performs dexopt on the secondary dex {@code path} belonging to the app {@code info}.
306 *
307 * @return
308 * DEX_OPT_FAILED if there was any exception during dexopt
309 * DEX_OPT_PERFORMED if dexopt was performed successfully on the given path.
310 * NOTE that DEX_OPT_PERFORMED for secondary dex files includes the case when the dex file
311 * didn't need an update. That's because at the moment we don't get more than success/failure
312 * from installd.
313 *
314 * TODO(calin): Consider adding return codes to installd dexopt invocation (rather than
315 * throwing exceptions). Or maybe make a separate call to installd to get DexOptNeeded, though
316 * that seems wasteful.
317 */
Calin Juravlef1ff36f2017-07-22 12:33:41 -0700318 public int dexOptSecondaryDexPath(ApplicationInfo info, String path,
319 PackageDexUsage.DexUseInfo dexUseInfo, DexoptOptions options) {
Calin Juravlec6540da2017-11-15 16:28:01 -0800320 if (info.uid == -1) {
321 throw new IllegalArgumentException("Dexopt for path " + path + " has invalid uid.");
322 }
Calin Juravlec22c30e2017-01-16 19:18:48 -0800323 synchronized (mInstallLock) {
Fyodor Kupolov28f28552017-05-02 12:11:02 -0700324 final long acquireTime = acquireWakeLockLI(info.uid);
Calin Juravlec22c30e2017-01-16 19:18:48 -0800325 try {
Calin Juravlef1ff36f2017-07-22 12:33:41 -0700326 return dexOptSecondaryDexPathLI(info, path, dexUseInfo, options);
Calin Juravlec22c30e2017-01-16 19:18:48 -0800327 } finally {
Fyodor Kupolov28f28552017-05-02 12:11:02 -0700328 releaseWakeLockLI(acquireTime);
Calin Juravlec22c30e2017-01-16 19:18:48 -0800329 }
330 }
331 }
332
333 @GuardedBy("mInstallLock")
Fyodor Kupolov28f28552017-05-02 12:11:02 -0700334 private long acquireWakeLockLI(final int uid) {
335 // During boot the system doesn't need to instantiate and obtain a wake lock.
336 // PowerManager might not be ready, but that doesn't mean that we can't proceed with
337 // dexopt.
338 if (!mSystemReady) {
339 return -1;
340 }
341 mDexoptWakeLock.setWorkSource(new WorkSource(uid));
342 mDexoptWakeLock.acquire(WAKELOCK_TIMEOUT_MS);
343 return SystemClock.elapsedRealtime();
344 }
345
346 @GuardedBy("mInstallLock")
347 private void releaseWakeLockLI(final long acquireTime) {
348 if (acquireTime < 0) {
349 return;
350 }
351 try {
352 if (mDexoptWakeLock.isHeld()) {
353 mDexoptWakeLock.release();
354 }
355 final long duration = SystemClock.elapsedRealtime() - acquireTime;
356 if (duration >= WAKELOCK_TIMEOUT_MS) {
357 Slog.wtf(TAG, "WakeLock " + mDexoptWakeLock.getTag()
358 + " time out. Operation took " + duration + " ms. Thread: "
359 + Thread.currentThread().getName());
360 }
361 } catch (Exception e) {
362 Slog.wtf(TAG, "Error while releasing " + mDexoptWakeLock.getTag() + " lock", e);
363 }
364 }
365
366 @GuardedBy("mInstallLock")
Calin Juravlef1ff36f2017-07-22 12:33:41 -0700367 private int dexOptSecondaryDexPathLI(ApplicationInfo info, String path,
368 PackageDexUsage.DexUseInfo dexUseInfo, DexoptOptions options) {
369 if (options.isDexoptOnlySharedDex() && !dexUseInfo.isUsedByOtherApps()) {
370 // We are asked to optimize only the dex files used by other apps and this is not
371 // on of them: skip it.
372 return DEX_OPT_SKIPPED;
373 }
374
375 String compilerFilter = getRealCompilerFilter(info, options.getCompilerFilter(),
376 dexUseInfo.isUsedByOtherApps());
Calin Juravleefb1c942017-04-04 20:31:44 -0700377 // Get the dexopt flags after getRealCompilerFilter to make sure we get the correct flags.
Nicolas Geoffray3b4359a2017-05-25 13:53:22 +0100378 // Secondary dex files are currently not compiled at boot.
Andreas Gampec041c332017-11-01 17:05:53 -0700379 int dexoptFlags = getDexFlags(info, compilerFilter, options) | DEXOPT_SECONDARY_DEX;
Calin Juravlec22c30e2017-01-16 19:18:48 -0800380 // Check the app storage and add the appropriate flags.
Calin Juravleadbadd52017-03-28 18:19:15 -0700381 if (info.deviceProtectedDataDir != null &&
382 FileUtils.contains(info.deviceProtectedDataDir, path)) {
Calin Juravlec22c30e2017-01-16 19:18:48 -0800383 dexoptFlags |= DEXOPT_STORAGE_DE;
Calin Juravleadbadd52017-03-28 18:19:15 -0700384 } else if (info.credentialProtectedDataDir != null &&
385 FileUtils.contains(info.credentialProtectedDataDir, path)) {
Calin Juravlec22c30e2017-01-16 19:18:48 -0800386 dexoptFlags |= DEXOPT_STORAGE_CE;
387 } else {
388 Slog.e(TAG, "Could not infer CE/DE storage for package " + info.packageName);
389 return DEX_OPT_FAILED;
390 }
Calin Juravlec22c30e2017-01-16 19:18:48 -0800391 Log.d(TAG, "Running dexopt on: " + path
Calin Juravlef1ff36f2017-07-22 12:33:41 -0700392 + " pkg=" + info.packageName + " isa=" + dexUseInfo.getLoaderIsas()
Calin Juravlec22c30e2017-01-16 19:18:48 -0800393 + " dexoptFlags=" + printDexoptFlags(dexoptFlags)
394 + " target-filter=" + compilerFilter);
395
Calin Juravle27f92622017-10-04 10:53:09 -0700396 // TODO(calin): b/64530081 b/66984396. Use SKIP_SHARED_LIBRARY_CHECK for the context
397 // (instead of dexUseInfo.getClassLoaderContext()) in order to compile secondary dex files
398 // in isolation (and avoid to extract/verify the main apk if it's in the class path).
399 // Note this trades correctness for performance since the resulting slow down is
400 // unacceptable in some cases until b/64530081 is fixed.
401 String classLoaderContext = SKIP_SHARED_LIBRARY_CHECK;
Calin Juravle4bc8f4d2018-02-12 12:00:44 -0800402 int reason = options.getCompilationReason();
Calin Juravlec22c30e2017-01-16 19:18:48 -0800403 try {
Calin Juravlef1ff36f2017-07-22 12:33:41 -0700404 for (String isa : dexUseInfo.getLoaderIsas()) {
Calin Juravlec22c30e2017-01-16 19:18:48 -0800405 // Reuse the same dexopt path as for the primary apks. We don't need all the
406 // arguments as some (dexopNeeded and oatDir) will be computed by installd because
407 // system server cannot read untrusted app content.
408 // TODO(calin): maybe add a separate call.
409 mInstaller.dexopt(path, info.uid, info.packageName, isa, /*dexoptNeeded*/ 0,
410 /*oatDir*/ null, dexoptFlags,
Calin Juravlef1ff36f2017-07-22 12:33:41 -0700411 compilerFilter, info.volumeUuid, classLoaderContext, info.seInfoUser,
Calin Juravlecc651942018-02-01 17:20:51 +0000412 options.isDowngrade(), info.targetSdkVersion, /*profileName*/ null,
Calin Juravle4bc8f4d2018-02-12 12:00:44 -0800413 /*dexMetadataPath*/ null, getReasonName(reason));
Calin Juravlec22c30e2017-01-16 19:18:48 -0800414 }
415
416 return DEX_OPT_PERFORMED;
417 } catch (InstallerException e) {
418 Slog.w(TAG, "Failed to dexopt", e);
419 return DEX_OPT_FAILED;
420 }
421 }
422
423 /**
Andreas Gampea8908752015-11-10 08:58:14 -0800424 * Adjust the given dexopt-needed value. Can be overridden to influence the decision to
425 * optimize or not (and in what way).
426 */
427 protected int adjustDexoptNeeded(int dexoptNeeded) {
428 return dexoptNeeded;
429 }
430
431 /**
432 * Adjust the given dexopt flags that will be passed to the installer.
433 */
434 protected int adjustDexoptFlags(int dexoptFlags) {
435 return dexoptFlags;
436 }
437
Narayan Kamath88eea9e2016-05-02 14:44:31 +0100438 /**
439 * Dumps the dexopt state of the given package {@code pkg} to the given {@code PrintWriter}.
440 */
Calin Juravle41a57a62017-08-06 19:20:19 -0700441 void dumpDexoptState(IndentingPrintWriter pw, PackageParser.Package pkg,
442 PackageDexUsage.PackageUseInfo useInfo) {
Narayan Kamath88eea9e2016-05-02 14:44:31 +0100443 final String[] instructionSets = getAppDexInstructionSets(pkg.applicationInfo);
444 final String[] dexCodeInstructionSets = getDexCodeInstructionSets(instructionSets);
445
446 final List<String> paths = pkg.getAllCodePathsExcludingResourceOnly();
447
Calin Juravle41a57a62017-08-06 19:20:19 -0700448 for (String path : paths) {
449 pw.println("path: " + path);
450 pw.increaseIndent();
451
452 for (String isa : dexCodeInstructionSets) {
Calin Juravle41a57a62017-08-06 19:20:19 -0700453 try {
Calin Juravle7fc0f632018-03-30 12:38:59 -0700454 DexFile.OptimizationInfo info = DexFile.getDexFileOptimizationInfo(path, isa);
455 pw.println(isa + ": [status=" + info.getStatus()
456 +"] [reason=" + info.getReason() + "]");
Calin Juravle41a57a62017-08-06 19:20:19 -0700457 } catch (IOException ioe) {
Calin Juravleab49fc42018-03-28 19:00:18 -0700458 pw.println(isa + ": [Exception]: " + ioe.getMessage());
Calin Juravle41a57a62017-08-06 19:20:19 -0700459 }
Calin Juravle41a57a62017-08-06 19:20:19 -0700460 }
461
462 if (useInfo.isUsedByOtherApps(path)) {
Calin Juravle94837e32017-09-26 13:23:00 -0700463 pw.println("used by other apps: " + useInfo.getLoadingPackages(path));
Calin Juravle41a57a62017-08-06 19:20:19 -0700464 }
465
466 Map<String, PackageDexUsage.DexUseInfo> dexUseInfoMap = useInfo.getDexUseInfoMap();
467
468 if (!dexUseInfoMap.isEmpty()) {
469 pw.println("known secondary dex files:");
470 pw.increaseIndent();
471 for (Map.Entry<String, PackageDexUsage.DexUseInfo> e : dexUseInfoMap.entrySet()) {
472 String dex = e.getKey();
473 PackageDexUsage.DexUseInfo dexUseInfo = e.getValue();
474 pw.println(dex);
475 pw.increaseIndent();
Calin Juravlecf722222017-09-18 17:40:48 -0700476 // TODO(calin): get the status of the oat file (needs installd call)
Calin Juravle41a57a62017-08-06 19:20:19 -0700477 pw.println("class loader context: " + dexUseInfo.getClassLoaderContext());
478 if (dexUseInfo.isUsedByOtherApps()) {
Calin Juravle94837e32017-09-26 13:23:00 -0700479 pw.println("used by other apps: " + dexUseInfo.getLoadingPackages());
Calin Juravle41a57a62017-08-06 19:20:19 -0700480 }
481 pw.decreaseIndent();
482 }
483 pw.decreaseIndent();
484 }
485 pw.decreaseIndent();
Narayan Kamath88eea9e2016-05-02 14:44:31 +0100486 }
487 }
488
Calin Juravle2d4b6ad72017-01-04 13:22:14 -0800489 /**
490 * Returns the compiler filter that should be used to optimize the package code.
491 * The target filter will be updated if the package code is used by other apps
492 * or if it has the safe mode flag set.
493 */
Calin Juravlec22c30e2017-01-16 19:18:48 -0800494 private String getRealCompilerFilter(ApplicationInfo info, String targetCompilerFilter,
495 boolean isUsedByOtherApps) {
496 int flags = info.flags;
Calin Juravle2d4b6ad72017-01-04 13:22:14 -0800497 boolean vmSafeMode = (flags & ApplicationInfo.FLAG_VM_SAFE_MODE) != 0;
Nicolas Geoffray11d21a292018-01-24 14:07:14 +0000498 // When pm.dexopt.priv-apps-oob is true, we only verify privileged apps.
499 if (info.isPrivilegedApp() &&
500 SystemProperties.getBoolean("pm.dexopt.priv-apps-oob", false)) {
501 return "verify";
502 }
Mathieu Chartier41e4a372016-09-02 16:36:42 -0700503 if (vmSafeMode) {
Nicolas Geoffrayd093b202017-05-03 13:11:58 +0100504 return getSafeModeCompilerFilter(targetCompilerFilter);
Mathieu Chartier41e4a372016-09-02 16:36:42 -0700505 }
506
Calin Juravlec22c30e2017-01-16 19:18:48 -0800507 if (isProfileGuidedCompilerFilter(targetCompilerFilter) && isUsedByOtherApps) {
Calin Juravlef53201f2017-09-15 11:09:29 -0700508 // If the dex files is used by other apps, apply the shared filter.
509 return PackageManagerServiceCompilerMapping.getCompilerFilterForReason(
510 PackageManagerService.REASON_SHARED);
Andreas Gampebdd30d82016-03-20 11:32:11 -0700511 }
512
Calin Juravle2d4b6ad72017-01-04 13:22:14 -0800513 return targetCompilerFilter;
Fyodor Kupolov74876572015-02-23 17:14:45 -0800514 }
515
Fyodor Kupolovb94c1652015-03-03 12:25:30 -0800516 /**
Calin Juravle2d4b6ad72017-01-04 13:22:14 -0800517 * Computes the dex flags that needs to be pass to installd for the given package and compiler
518 * filter.
519 */
Nicolas Geoffray3b4359a2017-05-25 13:53:22 +0100520 private int getDexFlags(PackageParser.Package pkg, String compilerFilter,
Andreas Gampec041c332017-11-01 17:05:53 -0700521 DexoptOptions options) {
522 return getDexFlags(pkg.applicationInfo, compilerFilter, options);
Calin Juravlec22c30e2017-01-16 19:18:48 -0800523 }
524
Mathieu Chartiera9c34332018-03-12 17:11:07 -0700525 private boolean isAppImageEnabled() {
526 return SystemProperties.get("dalvik.vm.appimageformat", "").length() > 0;
527 }
528
Andreas Gampec041c332017-11-01 17:05:53 -0700529 private int getDexFlags(ApplicationInfo info, String compilerFilter, DexoptOptions options) {
Calin Juravlec22c30e2017-01-16 19:18:48 -0800530 int flags = info.flags;
Calin Juravle2d4b6ad72017-01-04 13:22:14 -0800531 boolean debuggable = (flags & ApplicationInfo.FLAG_DEBUGGABLE) != 0;
Calin Juravleff3e4a12018-02-01 17:23:13 +0000532 // Profile guide compiled oat files should not be public unles they are based
533 // on profiles from dex metadata archives.
534 // The flag isDexoptInstallWithDexMetadata applies only on installs when we know that
535 // the user does not have an existing profile.
Calin Juravle2d4b6ad72017-01-04 13:22:14 -0800536 boolean isProfileGuidedFilter = isProfileGuidedCompilerFilter(compilerFilter);
Calin Juravleff3e4a12018-02-01 17:23:13 +0000537 boolean isPublic = !info.isForwardLocked() &&
538 (!isProfileGuidedFilter || options.isDexoptInstallWithDexMetadata());
Calin Juravle2d4b6ad72017-01-04 13:22:14 -0800539 int profileFlag = isProfileGuidedFilter ? DEXOPT_PROFILE_GUIDED : 0;
David Brazdilf7e31c02018-02-13 17:04:26 +0000540 // Some apps are executed with restrictions on hidden API usage. If this app is one
541 // of them, pass a flag to dexopt to enable the same restrictions during compilation.
Mathew Inwoode3299532018-02-22 13:19:53 +0000542 // TODO we should pass the actual flag value to dexopt, rather than assuming blacklist
543 int hiddenApiFlag = info.getHiddenApiEnforcementPolicy() == HIDDEN_API_ENFORCEMENT_NONE
544 ? 0
545 : DEXOPT_ENABLE_HIDDEN_API_CHECKS;
Mathieu Chartiera6d43e42018-03-08 13:11:40 -0800546 // Avoid generating CompactDex for modes that are latency critical.
Mathieu Chartierfa3e9762018-03-06 18:28:22 -0800547 final int compilationReason = options.getCompilationReason();
548 boolean generateCompactDex = true;
549 switch (compilationReason) {
550 case PackageManagerService.REASON_FIRST_BOOT:
551 case PackageManagerService.REASON_BOOT:
552 case PackageManagerService.REASON_INSTALL:
553 generateCompactDex = false;
554 }
Mathieu Chartiera9c34332018-03-12 17:11:07 -0700555 // Use app images only if it is enabled and we are compiling
556 // profile-guided (so the app image doesn't conservatively contain all classes).
557 // If the app didn't request for the splits to be loaded in isolation or if it does not
558 // declare inter-split dependencies, then all the splits will be loaded in the base
559 // apk class loader (in the order of their definition, otherwise disable app images
560 // because they are unsupported for multiple class loaders. b/7269679
561 boolean generateAppImage = isProfileGuidedFilter && (info.splitDependencies == null ||
562 !info.requestsIsolatedSplitLoading()) && isAppImageEnabled();
Calin Juravle2d4b6ad72017-01-04 13:22:14 -0800563 int dexFlags =
564 (isPublic ? DEXOPT_PUBLIC : 0)
Calin Juravle2d4b6ad72017-01-04 13:22:14 -0800565 | (debuggable ? DEXOPT_DEBUGGABLE : 0)
566 | profileFlag
Andreas Gampec041c332017-11-01 17:05:53 -0700567 | (options.isBootComplete() ? DEXOPT_BOOTCOMPLETE : 0)
David Brazdil464ed3d2018-01-18 15:25:18 +0000568 | (options.isDexoptIdleBackgroundJob() ? DEXOPT_IDLE_BACKGROUND_JOB : 0)
Mathieu Chartierfa3e9762018-03-06 18:28:22 -0800569 | (generateCompactDex ? DEXOPT_GENERATE_COMPACT_DEX : 0)
Mathieu Chartiera9c34332018-03-12 17:11:07 -0700570 | (generateAppImage ? DEXOPT_GENERATE_APP_IMAGE : 0)
David Brazdil464ed3d2018-01-18 15:25:18 +0000571 | hiddenApiFlag;
Calin Juravle2d4b6ad72017-01-04 13:22:14 -0800572 return adjustDexoptFlags(dexFlags);
573 }
574
575 /**
576 * Assesses if there's a need to perform dexopt on {@code path} for the given
577 * configuration (isa, compiler filter, profile).
578 */
579 private int getDexoptNeeded(String path, String isa, String compilerFilter,
Calin Juravle576e6c02017-09-12 00:58:33 -0700580 String classLoaderContext, boolean newProfile, boolean downgrade) {
Calin Juravle2d4b6ad72017-01-04 13:22:14 -0800581 int dexoptNeeded;
582 try {
Calin Juravle576e6c02017-09-12 00:58:33 -0700583 dexoptNeeded = DexFile.getDexOptNeeded(path, isa, compilerFilter, classLoaderContext,
584 newProfile, downgrade);
Calin Juravle2d4b6ad72017-01-04 13:22:14 -0800585 } catch (IOException ioe) {
586 Slog.w(TAG, "IOException reading apk: " + path, ioe);
587 return DEX_OPT_FAILED;
588 }
589 return adjustDexoptNeeded(dexoptNeeded);
590 }
591
592 /**
Calin Juravle2d4b6ad72017-01-04 13:22:14 -0800593 * Checks if there is an update on the profile information of the {@code pkg}.
594 * If the compiler filter is not profile guided the method returns false.
595 *
596 * Note that this is a "destructive" operation with side effects. Under the hood the
597 * current profile and the reference profile will be merged and subsequent calls
598 * may return a different result.
599 */
Calin Juravle6ae39fc2018-01-19 20:32:47 -0800600 private boolean isProfileUpdated(PackageParser.Package pkg, int uid, String profileName,
601 String compilerFilter) {
Calin Juravle2d4b6ad72017-01-04 13:22:14 -0800602 // Check if we are allowed to merge and if the compiler filter is profile guided.
603 if (!isProfileGuidedCompilerFilter(compilerFilter)) {
604 return false;
605 }
606 // Merge profiles. It returns whether or not there was an updated in the profile info.
607 try {
Calin Juravle6ae39fc2018-01-19 20:32:47 -0800608 return mInstaller.mergeProfiles(uid, pkg.packageName, profileName);
Calin Juravle2d4b6ad72017-01-04 13:22:14 -0800609 } catch (InstallerException e) {
610 Slog.w(TAG, "Failed to merge profiles", e);
611 }
612 return false;
613 }
614
615 /**
616 * Creates oat dir for the specified package if needed and supported.
617 * In certain cases oat directory
Fyodor Kupolovb94c1652015-03-03 12:25:30 -0800618 * <strong>cannot</strong> be created:
619 * <ul>
620 * <li>{@code pkg} is a system app, which is not updated.</li>
621 * <li>Package location is not a directory, i.e. monolithic install.</li>
622 * </ul>
623 *
Richard Uhler7b08b352015-03-25 16:25:57 -0700624 * @return Absolute path to the oat directory or null, if oat directory
625 * cannot be created.
Fyodor Kupolovb94c1652015-03-03 12:25:30 -0800626 */
627 @Nullable
Todd Kennedy27c24fb2015-09-17 16:49:25 -0700628 private String createOatDirIfSupported(PackageParser.Package pkg, String dexInstructionSet) {
Fyodor Kupolovebcac162015-09-09 15:56:45 -0700629 if (!pkg.canHaveOatDir()) {
Fyodor Kupolovb94c1652015-03-03 12:25:30 -0800630 return null;
631 }
632 File codePath = new File(pkg.codePath);
633 if (codePath.isDirectory()) {
Calin Juravle2d4b6ad72017-01-04 13:22:14 -0800634 // TODO(calin): why do we create this only if the codePath is a directory? (i.e for
635 // cluster packages). It seems that the logic for the folder creation is
636 // split between installd and here.
Fyodor Kupolovb94c1652015-03-03 12:25:30 -0800637 File oatDir = getOatDir(codePath);
Jeff Sharkeyfdeeeea2016-01-11 17:34:24 -0700638 try {
Andreas Gampea8908752015-11-10 08:58:14 -0800639 mInstaller.createOatDir(oatDir.getAbsolutePath(), dexInstructionSet);
Jeff Sharkeyfdeeeea2016-01-11 17:34:24 -0700640 } catch (InstallerException e) {
641 Slog.w(TAG, "Failed to create oat dir", e);
642 return null;
643 }
Richard Uhler7b08b352015-03-25 16:25:57 -0700644 return oatDir.getAbsolutePath();
Fyodor Kupolovb94c1652015-03-03 12:25:30 -0800645 }
646 return null;
647 }
648
649 static File getOatDir(File codePath) {
650 return new File(codePath, OAT_DIR_NAME);
651 }
652
Fyodor Kupolova627c092015-05-05 18:44:39 -0700653 void systemReady() {
654 mSystemReady = true;
655 }
Andreas Gampea8908752015-11-10 08:58:14 -0800656
Calin Juravle2d4b6ad72017-01-04 13:22:14 -0800657 private String printDexoptFlags(int flags) {
658 ArrayList<String> flagsList = new ArrayList<>();
659
660 if ((flags & DEXOPT_BOOTCOMPLETE) == DEXOPT_BOOTCOMPLETE) {
661 flagsList.add("boot_complete");
662 }
663 if ((flags & DEXOPT_DEBUGGABLE) == DEXOPT_DEBUGGABLE) {
664 flagsList.add("debuggable");
665 }
666 if ((flags & DEXOPT_PROFILE_GUIDED) == DEXOPT_PROFILE_GUIDED) {
667 flagsList.add("profile_guided");
668 }
669 if ((flags & DEXOPT_PUBLIC) == DEXOPT_PUBLIC) {
670 flagsList.add("public");
671 }
Calin Juravlec22c30e2017-01-16 19:18:48 -0800672 if ((flags & DEXOPT_SECONDARY_DEX) == DEXOPT_SECONDARY_DEX) {
673 flagsList.add("secondary");
674 }
675 if ((flags & DEXOPT_FORCE) == DEXOPT_FORCE) {
676 flagsList.add("force");
677 }
678 if ((flags & DEXOPT_STORAGE_CE) == DEXOPT_STORAGE_CE) {
679 flagsList.add("storage_ce");
680 }
681 if ((flags & DEXOPT_STORAGE_DE) == DEXOPT_STORAGE_DE) {
682 flagsList.add("storage_de");
683 }
David Sehr2118ec42017-10-25 14:28:29 -0700684 if ((flags & DEXOPT_IDLE_BACKGROUND_JOB) == DEXOPT_IDLE_BACKGROUND_JOB) {
685 flagsList.add("idle_background_job");
686 }
David Brazdilf7e31c02018-02-13 17:04:26 +0000687 if ((flags & DEXOPT_ENABLE_HIDDEN_API_CHECKS) == DEXOPT_ENABLE_HIDDEN_API_CHECKS) {
688 flagsList.add("enable_hidden_api_checks");
David Brazdil464ed3d2018-01-18 15:25:18 +0000689 }
Calin Juravlec22c30e2017-01-16 19:18:48 -0800690
Calin Juravle2d4b6ad72017-01-04 13:22:14 -0800691 return String.join(",", flagsList);
692 }
693
Andreas Gampea8908752015-11-10 08:58:14 -0800694 /**
695 * A specialized PackageDexOptimizer that overrides already-installed checks, forcing a
696 * dexopt path.
697 */
698 public static class ForcedUpdatePackageDexOptimizer extends PackageDexOptimizer {
699
700 public ForcedUpdatePackageDexOptimizer(Installer installer, Object installLock,
701 Context context, String wakeLockTag) {
702 super(installer, installLock, context, wakeLockTag);
703 }
704
705 public ForcedUpdatePackageDexOptimizer(PackageDexOptimizer from) {
706 super(from);
707 }
708
709 @Override
Andreas Gampea8908752015-11-10 08:58:14 -0800710 protected int adjustDexoptNeeded(int dexoptNeeded) {
Nicolas Geoffray96d12a92017-05-03 11:51:53 +0100711 if (dexoptNeeded == DexFile.NO_DEXOPT_NEEDED) {
712 // Ensure compilation by pretending a compiler filter change on the
713 // apk/odex location (the reason for the '-'. A positive value means
714 // the 'oat' location).
715 return -DexFile.DEX2OAT_FOR_FILTER;
716 }
717 return dexoptNeeded;
Andreas Gampea8908752015-11-10 08:58:14 -0800718 }
Calin Juravlec22c30e2017-01-16 19:18:48 -0800719
720 @Override
721 protected int adjustDexoptFlags(int flags) {
722 // Add DEXOPT_FORCE flag to signal installd that it should force compilation
723 // and discard dexoptanalyzer result.
724 return flags | DEXOPT_FORCE;
725 }
Andreas Gampea8908752015-11-10 08:58:14 -0800726 }
Fyodor Kupolov74876572015-02-23 17:14:45 -0800727}