blob: 9d6476a858dd738bc72e3e767d144c6a1e38981e [file] [log] [blame]
Adam Lesinski6f6ceb72014-11-14 14:48:12 -08001/*
2 * Copyright (C) 2015 The Android Open Source Project
3 *
4 * Licensed under the Apache License, Version 2.0 (the "License");
5 * you may not use this file except in compliance with the License.
6 * You may obtain a copy of the License at
7 *
8 * http://www.apache.org/licenses/LICENSE-2.0
9 *
10 * Unless required by applicable law or agreed to in writing, software
11 * distributed under the License is distributed on an "AS IS" BASIS,
12 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13 * See the License for the specific language governing permissions and
14 * limitations under the License.
15 */
16
17#include "ConfigDescription.h"
Adam Lesinski769de982015-04-10 19:43:55 -070018#include "NameMangler.h"
Adam Lesinski6f6ceb72014-11-14 14:48:12 -080019#include "ResourceTable.h"
20#include "ResourceValues.h"
Adam Lesinski1ab598f2015-08-14 14:26:04 -070021#include "ValueVisitor.h"
22#include "util/Util.h"
Adam Lesinski6f6ceb72014-11-14 14:48:12 -080023
24#include <algorithm>
25#include <androidfw/ResourceTypes.h>
26#include <memory>
27#include <string>
28#include <tuple>
29
30namespace aapt {
31
Adam Lesinski6f6ceb72014-11-14 14:48:12 -080032static bool lessThanType(const std::unique_ptr<ResourceTableType>& lhs, ResourceType rhs) {
33 return lhs->type < rhs;
34}
35
Adam Lesinski1ab598f2015-08-14 14:26:04 -070036template <typename T>
37static bool lessThanStructWithName(const std::unique_ptr<T>& lhs,
38 const StringPiece16& rhs) {
Adam Lesinski6f6ceb72014-11-14 14:48:12 -080039 return lhs->name.compare(0, lhs->name.size(), rhs.data(), rhs.size()) < 0;
40}
41
Adam Lesinski1ab598f2015-08-14 14:26:04 -070042ResourceTablePackage* ResourceTable::findPackage(const StringPiece16& name) {
43 const auto last = packages.end();
44 auto iter = std::lower_bound(packages.begin(), last, name,
45 lessThanStructWithName<ResourceTablePackage>);
46 if (iter != last && name == (*iter)->name) {
47 return iter->get();
48 }
49 return nullptr;
Adam Lesinski6f6ceb72014-11-14 14:48:12 -080050}
51
Adam Lesinski1ab598f2015-08-14 14:26:04 -070052ResourceTablePackage* ResourceTable::findPackageById(uint8_t id) {
53 for (auto& package : packages) {
54 if (package->id && package->id.value() == id) {
55 return package.get();
Adam Lesinski6f6ceb72014-11-14 14:48:12 -080056 }
57 }
Adam Lesinski1ab598f2015-08-14 14:26:04 -070058 return nullptr;
Adam Lesinski6f6ceb72014-11-14 14:48:12 -080059}
60
Adam Lesinski9ba47d82015-10-13 11:37:10 -070061ResourceTablePackage* ResourceTable::createPackage(const StringPiece16& name, Maybe<uint8_t> id) {
Adam Lesinski1ab598f2015-08-14 14:26:04 -070062 ResourceTablePackage* package = findOrCreatePackage(name);
Adam Lesinski9ba47d82015-10-13 11:37:10 -070063 if (id && !package->id) {
Adam Lesinski1ab598f2015-08-14 14:26:04 -070064 package->id = id;
65 return package;
Adam Lesinski6f6ceb72014-11-14 14:48:12 -080066 }
Adam Lesinski1ab598f2015-08-14 14:26:04 -070067
Adam Lesinski9ba47d82015-10-13 11:37:10 -070068 if (id && package->id && package->id.value() != id.value()) {
69 return nullptr;
Adam Lesinski1ab598f2015-08-14 14:26:04 -070070 }
Adam Lesinski9ba47d82015-10-13 11:37:10 -070071 return package;
Adam Lesinski6f6ceb72014-11-14 14:48:12 -080072}
73
Adam Lesinski1ab598f2015-08-14 14:26:04 -070074ResourceTablePackage* ResourceTable::findOrCreatePackage(const StringPiece16& name) {
75 const auto last = packages.end();
76 auto iter = std::lower_bound(packages.begin(), last, name,
77 lessThanStructWithName<ResourceTablePackage>);
78 if (iter != last && name == (*iter)->name) {
79 return iter->get();
Adam Lesinski6f6ceb72014-11-14 14:48:12 -080080 }
81
Adam Lesinski1ab598f2015-08-14 14:26:04 -070082 std::unique_ptr<ResourceTablePackage> newPackage = util::make_unique<ResourceTablePackage>();
83 newPackage->name = name.toString();
84 return packages.emplace(iter, std::move(newPackage))->get();
85}
86
87ResourceTableType* ResourceTablePackage::findType(ResourceType type) {
88 const auto last = types.end();
89 auto iter = std::lower_bound(types.begin(), last, type, lessThanType);
90 if (iter != last && (*iter)->type == type) {
91 return iter->get();
Adam Lesinski6f6ceb72014-11-14 14:48:12 -080092 }
Adam Lesinski1ab598f2015-08-14 14:26:04 -070093 return nullptr;
94}
95
96ResourceTableType* ResourceTablePackage::findOrCreateType(ResourceType type) {
97 const auto last = types.end();
98 auto iter = std::lower_bound(types.begin(), last, type, lessThanType);
99 if (iter != last && (*iter)->type == type) {
100 return iter->get();
101 }
Adam Lesinskia6fe3452015-12-09 15:20:52 -0800102 return types.emplace(iter, new ResourceTableType(type))->get();
Adam Lesinski1ab598f2015-08-14 14:26:04 -0700103}
104
105ResourceEntry* ResourceTableType::findEntry(const StringPiece16& name) {
106 const auto last = entries.end();
107 auto iter = std::lower_bound(entries.begin(), last, name,
108 lessThanStructWithName<ResourceEntry>);
109 if (iter != last && name == (*iter)->name) {
110 return iter->get();
111 }
112 return nullptr;
113}
114
115ResourceEntry* ResourceTableType::findOrCreateEntry(const StringPiece16& name) {
116 auto last = entries.end();
117 auto iter = std::lower_bound(entries.begin(), last, name,
118 lessThanStructWithName<ResourceEntry>);
119 if (iter != last && name == (*iter)->name) {
120 return iter->get();
121 }
Adam Lesinskia6fe3452015-12-09 15:20:52 -0800122 return entries.emplace(iter, new ResourceEntry(name))->get();
Adam Lesinski1ab598f2015-08-14 14:26:04 -0700123}
Adam Lesinski6f6ceb72014-11-14 14:48:12 -0800124
Adam Lesinskie4bb9eb2016-02-12 22:18:51 -0800125ResourceConfigValue* ResourceEntry::findValue(const ConfigDescription& config) {
126 return findValue(config, StringPiece());
127}
128
129struct ConfigKey {
130 const ConfigDescription* config;
131 const StringPiece& product;
132};
133
134bool ltConfigKeyRef(const std::unique_ptr<ResourceConfigValue>& lhs, const ConfigKey& rhs) {
135 int cmp = lhs->config.compare(*rhs.config);
136 if (cmp == 0) {
137 cmp = StringPiece(lhs->product).compare(rhs.product);
138 }
139 return cmp < 0;
140}
141
142ResourceConfigValue* ResourceEntry::findValue(const ConfigDescription& config,
143 const StringPiece& product) {
144 auto iter = std::lower_bound(values.begin(), values.end(),
145 ConfigKey{ &config, product }, ltConfigKeyRef);
146 if (iter != values.end()) {
147 ResourceConfigValue* value = iter->get();
148 if (value->config == config && StringPiece(value->product) == product) {
149 return value;
150 }
151 }
152 return nullptr;
153}
154
155ResourceConfigValue* ResourceEntry::findOrCreateValue(const ConfigDescription& config,
156 const StringPiece& product) {
157 auto iter = std::lower_bound(values.begin(), values.end(),
158 ConfigKey{ &config, product }, ltConfigKeyRef);
159 if (iter != values.end()) {
160 ResourceConfigValue* value = iter->get();
161 if (value->config == config && StringPiece(value->product) == product) {
162 return value;
163 }
164 }
165 ResourceConfigValue* newValue = values.insert(
166 iter, util::make_unique<ResourceConfigValue>(config, product))->get();
167 return newValue;
168}
169
170std::vector<ResourceConfigValue*> ResourceEntry::findAllValues(const ConfigDescription& config) {
171 std::vector<ResourceConfigValue*> results;
172
173 auto iter = values.begin();
174 for (; iter != values.end(); ++iter) {
175 ResourceConfigValue* value = iter->get();
176 if (value->config == config) {
177 results.push_back(value);
178 ++iter;
179 break;
180 }
181 }
182
183 for (; iter != values.end(); ++iter) {
184 ResourceConfigValue* value = iter->get();
185 if (value->config == config) {
186 results.push_back(value);
187 }
188 }
189 return results;
190}
191
Adam Lesinski6f6ceb72014-11-14 14:48:12 -0800192/**
193 * The default handler for collisions. A return value of -1 means keep the
194 * existing value, 0 means fail, and +1 means take the incoming value.
195 */
Adam Lesinski1ab598f2015-08-14 14:26:04 -0700196int ResourceTable::resolveValueCollision(Value* existing, Value* incoming) {
197 Attribute* existingAttr = valueCast<Attribute>(existing);
198 Attribute* incomingAttr = valueCast<Attribute>(incoming);
Adam Lesinski6f6ceb72014-11-14 14:48:12 -0800199
Adam Lesinski1ab598f2015-08-14 14:26:04 -0700200 if (!incomingAttr) {
201 if (incoming->isWeak()) {
Adam Lesinski6f6ceb72014-11-14 14:48:12 -0800202 // We're trying to add a weak resource but a resource
203 // already exists. Keep the existing.
204 return -1;
Adam Lesinski1ab598f2015-08-14 14:26:04 -0700205 } else if (existing->isWeak()) {
Adam Lesinski6f6ceb72014-11-14 14:48:12 -0800206 // Override the weak resource with the new strong resource.
207 return 1;
208 }
209 // The existing and incoming values are strong, this is an error
210 // if the values are not both attributes.
211 return 0;
212 }
213
Adam Lesinski1ab598f2015-08-14 14:26:04 -0700214 if (!existingAttr) {
215 if (existing->isWeak()) {
Adam Lesinski6f6ceb72014-11-14 14:48:12 -0800216 // The existing value is not an attribute and it is weak,
217 // so take the incoming attribute value.
218 return 1;
219 }
220 // The existing value is not an attribute and it is strong,
221 // so the incoming attribute value is an error.
222 return 0;
223 }
224
Adam Lesinski1ab598f2015-08-14 14:26:04 -0700225 assert(incomingAttr && existingAttr);
226
Adam Lesinski6f6ceb72014-11-14 14:48:12 -0800227 //
228 // Attribute specific handling. At this point we know both
229 // values are attributes. Since we can declare and define
230 // attributes all-over, we do special handling to see
231 // which definition sticks.
232 //
Adam Lesinski1ab598f2015-08-14 14:26:04 -0700233 if (existingAttr->typeMask == incomingAttr->typeMask) {
Adam Lesinski6f6ceb72014-11-14 14:48:12 -0800234 // The two attributes are both DECLs, but they are plain attributes
235 // with the same formats.
236 // Keep the strongest one.
Adam Lesinski1ab598f2015-08-14 14:26:04 -0700237 return existingAttr->isWeak() ? 1 : -1;
Adam Lesinski6f6ceb72014-11-14 14:48:12 -0800238 }
239
Adam Lesinski1ab598f2015-08-14 14:26:04 -0700240 if (existingAttr->isWeak() && existingAttr->typeMask == android::ResTable_map::TYPE_ANY) {
Adam Lesinski6f6ceb72014-11-14 14:48:12 -0800241 // Any incoming attribute is better than this.
242 return 1;
243 }
244
Adam Lesinski1ab598f2015-08-14 14:26:04 -0700245 if (incomingAttr->isWeak() && incomingAttr->typeMask == android::ResTable_map::TYPE_ANY) {
Adam Lesinski6f6ceb72014-11-14 14:48:12 -0800246 // The incoming attribute may be a USE instead of a DECL.
247 // Keep the existing attribute.
248 return -1;
249 }
250 return 0;
251}
252
253static constexpr const char16_t* kValidNameChars = u"._-";
Adam Lesinski330edcd2015-05-04 17:40:56 -0700254static constexpr const char16_t* kValidNameMangledChars = u"._-$";
255
Adam Lesinskie4bb9eb2016-02-12 22:18:51 -0800256bool ResourceTable::addResource(const ResourceNameRef& name,
257 const ConfigDescription& config,
258 const StringPiece& product,
259 std::unique_ptr<Value> value,
Adam Lesinskie78fd612015-10-22 12:48:43 -0700260 IDiagnostics* diag) {
Adam Lesinskie4bb9eb2016-02-12 22:18:51 -0800261 return addResourceImpl(name, {}, config, product, std::move(value), kValidNameChars,
Adam Lesinskifb48d292015-11-07 15:52:13 -0800262 resolveValueCollision, diag);
Adam Lesinski1ab598f2015-08-14 14:26:04 -0700263}
264
Adam Lesinskie4bb9eb2016-02-12 22:18:51 -0800265bool ResourceTable::addResource(const ResourceNameRef& name,
Chih-Hung Hsiehb3d46b42016-08-12 11:35:17 -0700266 const ResourceId& resId,
Adam Lesinskie4bb9eb2016-02-12 22:18:51 -0800267 const ConfigDescription& config,
268 const StringPiece& product,
269 std::unique_ptr<Value> value,
270 IDiagnostics* diag) {
271 return addResourceImpl(name, resId, config, product, std::move(value), kValidNameChars,
272 resolveValueCollision, diag);
273}
274
275bool ResourceTable::addFileReference(const ResourceNameRef& name,
276 const ConfigDescription& config,
277 const Source& source,
278 const StringPiece16& path,
Adam Lesinski1ab598f2015-08-14 14:26:04 -0700279 IDiagnostics* diag) {
Adam Lesinski355f2852016-02-13 20:26:45 -0800280 return addFileReferenceImpl(name, config, source, path, nullptr, kValidNameChars, diag);
Adam Lesinskifb48d292015-11-07 15:52:13 -0800281}
282
Adam Lesinski355f2852016-02-13 20:26:45 -0800283bool ResourceTable::addFileReferenceAllowMangled(const ResourceNameRef& name,
284 const ConfigDescription& config,
285 const Source& source,
286 const StringPiece16& path,
287 io::IFile* file,
288 IDiagnostics* diag) {
289 return addFileReferenceImpl(name, config, source, path, file, kValidNameMangledChars, diag);
290}
291
292bool ResourceTable::addFileReferenceImpl(const ResourceNameRef& name,
293 const ConfigDescription& config,
294 const Source& source,
295 const StringPiece16& path,
296 io::IFile* file,
297 const char16_t* validChars,
298 IDiagnostics* diag) {
Adam Lesinskie78fd612015-10-22 12:48:43 -0700299 std::unique_ptr<FileReference> fileRef = util::make_unique<FileReference>(
300 stringPool.makeRef(path));
301 fileRef->setSource(source);
Adam Lesinski355f2852016-02-13 20:26:45 -0800302 fileRef->file = file;
Adam Lesinskie4bb9eb2016-02-12 22:18:51 -0800303 return addResourceImpl(name, ResourceId{}, config, StringPiece{}, std::move(fileRef),
Adam Lesinski355f2852016-02-13 20:26:45 -0800304 kValidNameChars, resolveValueCollision, diag);
Adam Lesinski330edcd2015-05-04 17:40:56 -0700305}
306
307bool ResourceTable::addResourceAllowMangled(const ResourceNameRef& name,
308 const ConfigDescription& config,
Adam Lesinskie4bb9eb2016-02-12 22:18:51 -0800309 const StringPiece& product,
Adam Lesinski1ab598f2015-08-14 14:26:04 -0700310 std::unique_ptr<Value> value,
311 IDiagnostics* diag) {
Adam Lesinskie4bb9eb2016-02-12 22:18:51 -0800312 return addResourceImpl(name, ResourceId{}, config, product, std::move(value),
313 kValidNameMangledChars, resolveValueCollision, diag);
Adam Lesinski330edcd2015-05-04 17:40:56 -0700314}
315
Adam Lesinski9e10ac72015-10-16 14:37:48 -0700316bool ResourceTable::addResourceAllowMangled(const ResourceNameRef& name,
Chih-Hung Hsiehb3d46b42016-08-12 11:35:17 -0700317 const ResourceId& id,
Adam Lesinski9e10ac72015-10-16 14:37:48 -0700318 const ConfigDescription& config,
Adam Lesinskie4bb9eb2016-02-12 22:18:51 -0800319 const StringPiece& product,
Adam Lesinski9e10ac72015-10-16 14:37:48 -0700320 std::unique_ptr<Value> value,
321 IDiagnostics* diag) {
Adam Lesinskie4bb9eb2016-02-12 22:18:51 -0800322 return addResourceImpl(name, id, config, product, std::move(value), kValidNameMangledChars,
Adam Lesinskifb48d292015-11-07 15:52:13 -0800323 resolveValueCollision, diag);
Adam Lesinski9e10ac72015-10-16 14:37:48 -0700324}
325
Adam Lesinskifb48d292015-11-07 15:52:13 -0800326bool ResourceTable::addResourceImpl(const ResourceNameRef& name,
Chih-Hung Hsiehb3d46b42016-08-12 11:35:17 -0700327 const ResourceId& resId,
Adam Lesinskifb48d292015-11-07 15:52:13 -0800328 const ConfigDescription& config,
Adam Lesinskie4bb9eb2016-02-12 22:18:51 -0800329 const StringPiece& product,
Adam Lesinskifb48d292015-11-07 15:52:13 -0800330 std::unique_ptr<Value> value,
331 const char16_t* validChars,
332 std::function<int(Value*,Value*)> conflictResolver,
333 IDiagnostics* diag) {
Adam Lesinskie78fd612015-10-22 12:48:43 -0700334 assert(value && "value can't be nullptr");
335 assert(diag && "diagnostics can't be nullptr");
336
Adam Lesinski330edcd2015-05-04 17:40:56 -0700337 auto badCharIter = util::findNonAlphaNumericAndNotInSet(name.entry, validChars);
Adam Lesinski6f6ceb72014-11-14 14:48:12 -0800338 if (badCharIter != name.entry.end()) {
Adam Lesinskie78fd612015-10-22 12:48:43 -0700339 diag->error(DiagMessage(value->getSource())
Adam Lesinski1ab598f2015-08-14 14:26:04 -0700340 << "resource '"
341 << name
342 << "' has invalid entry name '"
343 << name.entry
344 << "'. Invalid character '"
345 << StringPiece16(badCharIter, 1)
346 << "'");
Adam Lesinski6f6ceb72014-11-14 14:48:12 -0800347 return false;
348 }
349
Adam Lesinski1ab598f2015-08-14 14:26:04 -0700350 ResourceTablePackage* package = findOrCreatePackage(name.package);
351 if (resId.isValid() && package->id && package->id.value() != resId.packageId()) {
Adam Lesinskie78fd612015-10-22 12:48:43 -0700352 diag->error(DiagMessage(value->getSource())
Adam Lesinski1ab598f2015-08-14 14:26:04 -0700353 << "trying to add resource '"
354 << name
355 << "' with ID "
356 << resId
357 << " but package '"
358 << package->name
359 << "' already has ID "
360 << std::hex << (int) package->id.value() << std::dec);
Adam Lesinski6f6ceb72014-11-14 14:48:12 -0800361 return false;
362 }
363
Adam Lesinski1ab598f2015-08-14 14:26:04 -0700364 ResourceTableType* type = package->findOrCreateType(name.type);
365 if (resId.isValid() && type->id && type->id.value() != resId.typeId()) {
Adam Lesinskie78fd612015-10-22 12:48:43 -0700366 diag->error(DiagMessage(value->getSource())
Adam Lesinski1ab598f2015-08-14 14:26:04 -0700367 << "trying to add resource '"
368 << name
369 << "' with ID "
370 << resId
371 << " but type '"
372 << type->type
373 << "' already has ID "
374 << std::hex << (int) type->id.value() << std::dec);
Adam Lesinski6f6ceb72014-11-14 14:48:12 -0800375 return false;
376 }
377
Adam Lesinski1ab598f2015-08-14 14:26:04 -0700378 ResourceEntry* entry = type->findOrCreateEntry(name.entry);
379 if (resId.isValid() && entry->id && entry->id.value() != resId.entryId()) {
Adam Lesinskie78fd612015-10-22 12:48:43 -0700380 diag->error(DiagMessage(value->getSource())
Adam Lesinski1ab598f2015-08-14 14:26:04 -0700381 << "trying to add resource '"
382 << name
383 << "' with ID "
384 << resId
385 << " but resource already has ID "
386 << ResourceId(package->id.value(), type->id.value(), entry->id.value()));
387 return false;
388 }
389
Adam Lesinskie4bb9eb2016-02-12 22:18:51 -0800390 ResourceConfigValue* configValue = entry->findOrCreateValue(config, product);
391 if (!configValue->value) {
392 // Resource does not exist, add it now.
393 configValue->value = std::move(value);
394
Adam Lesinski6f6ceb72014-11-14 14:48:12 -0800395 } else {
Adam Lesinskie4bb9eb2016-02-12 22:18:51 -0800396 int collisionResult = conflictResolver(configValue->value.get(), value.get());
Adam Lesinski6f6ceb72014-11-14 14:48:12 -0800397 if (collisionResult > 0) {
398 // Take the incoming value.
Adam Lesinskie4bb9eb2016-02-12 22:18:51 -0800399 configValue->value = std::move(value);
Adam Lesinski6f6ceb72014-11-14 14:48:12 -0800400 } else if (collisionResult == 0) {
Adam Lesinskie78fd612015-10-22 12:48:43 -0700401 diag->error(DiagMessage(value->getSource())
Adam Lesinski1ab598f2015-08-14 14:26:04 -0700402 << "duplicate value for resource '" << name << "' "
Adam Lesinskie78fd612015-10-22 12:48:43 -0700403 << "with config '" << config << "'");
Adam Lesinskie4bb9eb2016-02-12 22:18:51 -0800404 diag->error(DiagMessage(configValue->value->getSource())
Adam Lesinski1ab598f2015-08-14 14:26:04 -0700405 << "resource previously defined here");
Adam Lesinski6f6ceb72014-11-14 14:48:12 -0800406 return false;
407 }
408 }
409
410 if (resId.isValid()) {
Adam Lesinski1ab598f2015-08-14 14:26:04 -0700411 package->id = resId.packageId();
412 type->id = resId.typeId();
413 entry->id = resId.entryId();
Adam Lesinski6f6ceb72014-11-14 14:48:12 -0800414 }
415 return true;
416}
417
Chih-Hung Hsiehb3d46b42016-08-12 11:35:17 -0700418bool ResourceTable::setSymbolState(const ResourceNameRef& name, const ResourceId& resId,
Adam Lesinskie78fd612015-10-22 12:48:43 -0700419 const Symbol& symbol, IDiagnostics* diag) {
420 return setSymbolStateImpl(name, resId, symbol, kValidNameChars, diag);
Adam Lesinski330edcd2015-05-04 17:40:56 -0700421}
422
Adam Lesinskie78fd612015-10-22 12:48:43 -0700423bool ResourceTable::setSymbolStateAllowMangled(const ResourceNameRef& name,
Chih-Hung Hsiehb3d46b42016-08-12 11:35:17 -0700424 const ResourceId& resId,
Adam Lesinskie78fd612015-10-22 12:48:43 -0700425 const Symbol& symbol, IDiagnostics* diag) {
426 return setSymbolStateImpl(name, resId, symbol, kValidNameMangledChars, diag);
Adam Lesinski330edcd2015-05-04 17:40:56 -0700427}
428
Chih-Hung Hsiehb3d46b42016-08-12 11:35:17 -0700429bool ResourceTable::setSymbolStateImpl(const ResourceNameRef& name, const ResourceId& resId,
Adam Lesinskie78fd612015-10-22 12:48:43 -0700430 const Symbol& symbol, const char16_t* validChars,
431 IDiagnostics* diag) {
432 assert(diag && "diagnostics can't be nullptr");
433
Adam Lesinski330edcd2015-05-04 17:40:56 -0700434 auto badCharIter = util::findNonAlphaNumericAndNotInSet(name.entry, validChars);
Adam Lesinski6f6ceb72014-11-14 14:48:12 -0800435 if (badCharIter != name.entry.end()) {
Adam Lesinskie78fd612015-10-22 12:48:43 -0700436 diag->error(DiagMessage(symbol.source)
Adam Lesinski1ab598f2015-08-14 14:26:04 -0700437 << "resource '"
438 << name
439 << "' has invalid entry name '"
440 << name.entry
441 << "'. Invalid character '"
442 << StringPiece16(badCharIter, 1)
443 << "'");
Adam Lesinski6f6ceb72014-11-14 14:48:12 -0800444 return false;
445 }
446
Adam Lesinski1ab598f2015-08-14 14:26:04 -0700447 ResourceTablePackage* package = findOrCreatePackage(name.package);
448 if (resId.isValid() && package->id && package->id.value() != resId.packageId()) {
Adam Lesinskie78fd612015-10-22 12:48:43 -0700449 diag->error(DiagMessage(symbol.source)
Adam Lesinski1ab598f2015-08-14 14:26:04 -0700450 << "trying to add resource '"
451 << name
452 << "' with ID "
453 << resId
454 << " but package '"
455 << package->name
456 << "' already has ID "
457 << std::hex << (int) package->id.value() << std::dec);
Adam Lesinski6f6ceb72014-11-14 14:48:12 -0800458 return false;
459 }
460
Adam Lesinski1ab598f2015-08-14 14:26:04 -0700461 ResourceTableType* type = package->findOrCreateType(name.type);
462 if (resId.isValid() && type->id && type->id.value() != resId.typeId()) {
Adam Lesinskie78fd612015-10-22 12:48:43 -0700463 diag->error(DiagMessage(symbol.source)
Adam Lesinski1ab598f2015-08-14 14:26:04 -0700464 << "trying to add resource '"
465 << name
466 << "' with ID "
467 << resId
468 << " but type '"
469 << type->type
470 << "' already has ID "
471 << std::hex << (int) type->id.value() << std::dec);
472 return false;
473 }
474
475 ResourceEntry* entry = type->findOrCreateEntry(name.entry);
476 if (resId.isValid() && entry->id && entry->id.value() != resId.entryId()) {
Adam Lesinskie78fd612015-10-22 12:48:43 -0700477 diag->error(DiagMessage(symbol.source)
Adam Lesinski1ab598f2015-08-14 14:26:04 -0700478 << "trying to add resource '"
479 << name
480 << "' with ID "
481 << resId
482 << " but resource already has ID "
483 << ResourceId(package->id.value(), type->id.value(), entry->id.value()));
Adam Lesinski6f6ceb72014-11-14 14:48:12 -0800484 return false;
485 }
486
Adam Lesinski6f6ceb72014-11-14 14:48:12 -0800487 if (resId.isValid()) {
Adam Lesinski1ab598f2015-08-14 14:26:04 -0700488 package->id = resId.packageId();
489 type->id = resId.typeId();
490 entry->id = resId.entryId();
Adam Lesinski6f6ceb72014-11-14 14:48:12 -0800491 }
Adam Lesinskia6fe3452015-12-09 15:20:52 -0800492
493 // Only mark the type state as public, it doesn't care about being private.
494 if (symbol.state == SymbolState::kPublic) {
495 type->symbolStatus.state = SymbolState::kPublic;
496 }
497
498 if (symbol.state == SymbolState::kUndefined &&
499 entry->symbolStatus.state != SymbolState::kUndefined) {
500 // We can't undefine a symbol (remove its visibility). Ignore.
501 return true;
502 }
503
504 if (symbol.state == SymbolState::kPrivate &&
505 entry->symbolStatus.state == SymbolState::kPublic) {
506 // We can't downgrade public to private. Ignore.
507 return true;
508 }
509
510 entry->symbolStatus = std::move(symbol);
Adam Lesinski6f6ceb72014-11-14 14:48:12 -0800511 return true;
512}
513
Adam Lesinski1ab598f2015-08-14 14:26:04 -0700514Maybe<ResourceTable::SearchResult>
515ResourceTable::findResource(const ResourceNameRef& name) {
516 ResourceTablePackage* package = findPackage(name.package);
517 if (!package) {
Adam Lesinskica2fc352015-04-03 12:08:26 -0700518 return {};
Adam Lesinski6f6ceb72014-11-14 14:48:12 -0800519 }
520
Adam Lesinski1ab598f2015-08-14 14:26:04 -0700521 ResourceTableType* type = package->findType(name.type);
522 if (!type) {
Adam Lesinskica2fc352015-04-03 12:08:26 -0700523 return {};
Adam Lesinski6f6ceb72014-11-14 14:48:12 -0800524 }
525
Adam Lesinski1ab598f2015-08-14 14:26:04 -0700526 ResourceEntry* entry = type->findEntry(name.entry);
527 if (!entry) {
Adam Lesinskica2fc352015-04-03 12:08:26 -0700528 return {};
Adam Lesinski6f6ceb72014-11-14 14:48:12 -0800529 }
Adam Lesinski1ab598f2015-08-14 14:26:04 -0700530 return SearchResult{ package, type, entry };
Adam Lesinski6f6ceb72014-11-14 14:48:12 -0800531}
532
533} // namespace aapt