commit 42598054d2d278bddde812f160517162e95342c1
author Logan <tzuhsiang.chien@gmail.com> Wed Jan 26 22:41:13 2011 +0800
committer Logan <tzuhsiang.chien@gmail.com> Mon Jan 31 22:06:31 2011 +0800
tree dcb03b936c471a32219d7e8339388db0a53bbdd1
parent 39ebe2c22f8557752065465345bb3006d06e4497

Enhance the cache-writing policy.

lib/bcc/Script.cpp

diff --git a/lib/bcc/Script.cpp b/lib/bcc/Script.cpp
index cb86ef5..23fe9cf 100644
--- a/lib/bcc/Script.cpp
+++ b/lib/bcc/Script.cpp
@@ -23,6 +23,7 @@
 
 #include "CacheReader.h"
 #include "CacheWriter.h"
+#include "ContextManager.h"
 #include "FileHandle.h"
 #include "ScriptCompiled.h"
 #include "ScriptCached.h"
@@ -183,6 +184,7 @@
   // Read cache file
   ScriptCached *cached = reader.readCacheFile(&file, this);
   if (!cached) {
+    mIsContextSlotNotAvail = reader.isContextSlotNotAvail();
     return 1;
   }
 
@@ -250,8 +252,18 @@
   }
 
 #if USE_CACHE
-  // TODO(logan): Write the cache out
-  if (mCachePath && !getBooleanProp("debug.bcc.nocache")) {
+  // Note: If we re-compile the script because the cached context slot not
+  // available, then we don't have to write the cache.
+
+  // Note: If the address of the context is not in the context slot, then
+  // we don't have to cache it.
+
+  char *addr = getContext();
+
+  if (mCachePath &&
+      !mIsContextSlotNotAvail && getSlotIndexFromAddress(addr) >= 0 &&
+      !getBooleanProp("debug.bcc.nocache")) {
+
     FileHandle file;
 
     // Remove the file if it already exists before writing the new file.