commit 6315f76e3cc6ff2d012d1183a0b030d4ff0dc808
author zonr <zonr@google.com> Tue Oct 05 15:35:14 2010 +0800
committer Shih-wei Liao <sliao@google.com> Tue Oct 05 23:22:19 2010 -0700
tree a4fb1ab4dbe94218fcda5a020b596905ac5b394f
parent 91a3783ce1f4eb9ad6e9c1ecdbd27f3d6dc58634

More coding style fixing to improve the readability. No actual semantics
changed. This also makes cpplint happy.

slang_rs_export_element.cpp

diff --git a/slang_rs_export_element.cpp b/slang_rs_export_element.cpp
index a5375f8..1ecacce 100644
--- a/slang_rs_export_element.cpp
+++ b/slang_rs_export_element.cpp
@@ -1,6 +1,4 @@
-#include "slang_rs_context.hpp"
-#include "slang_rs_export_type.hpp"
-#include "slang_rs_export_element.hpp"
+#include "slang_rs_export_element.h"
 
 #include "clang/Basic/SourceLocation.h"
 #include "clang/Basic/IdentifierTable.h"
@@ -8,6 +6,9 @@
 #include "clang/AST/Decl.h"
 #include "clang/AST/Type.h"
 
+#include "slang_rs_context.h"
+#include "slang_rs_export_type.h"
+
 using namespace slang;
 
 bool RSExportElement::Initialized = false;
@@ -32,8 +33,7 @@
               Name.begin(),                             \
               Name.end(),                               \
               ElementInfoMap.getAllocator(),            \
-              EI                                        \
-              ));                                       \
+              EI));                                     \
     }
 #include "slang_rs_export_element_support.inc"
 
@@ -58,7 +58,7 @@
   if (!RSExportType::NormalizeType(T, TypeName))
     return NULL;
 
-  switch(T->getTypeClass()) {
+  switch (T->getTypeClass()) {
     case clang::Type::Builtin:
     case clang::Type::Pointer: {
       assert(EI->vsize == 1 && "Element not a primitive class (please check "
@@ -74,12 +74,10 @@
       ET = EPT;
       break;
     }
-
     case clang::Type::ConstantArray: {
-      //XXX
+      // XXX
       break;
     }
-
     case clang::Type::ExtVector: {
       assert(EI->vsize > 1 && "Element not a vector class (please check your "
                               "macro)");
@@ -98,14 +96,12 @@
       ET = EVT;
       break;
     }
-
     case clang::Type::Record: {
       // Must be RS object type
 
-      if ( TypeName.equals(llvm::StringRef("rs_matrix2x2")) ||
-           TypeName.equals(llvm::StringRef("rs_matrix3x3")) ||
-           TypeName.equals(llvm::StringRef("rs_matrix4x4")) ) {
-
+      if (TypeName.equals(llvm::StringRef("rs_matrix2x2")) ||
+          TypeName.equals(llvm::StringRef("rs_matrix3x3")) ||
+          TypeName.equals(llvm::StringRef("rs_matrix4x4"))) {
         const clang::RecordType *RT = static_cast<const clang::RecordType*> (T);
         const clang::RecordDecl *RD = RT->getDecl();
         RD = RD->getDefinition();
@@ -116,8 +112,7 @@
             RSExportConstantArrayType::Create(
                 Context,
                 static_cast<const clang::ConstantArrayType*> (FT),
-                TypeName
-                                              );
+                TypeName);
         ET = ECT;
       } else {
         RSExportPrimitiveType* EPT =
@@ -132,9 +127,8 @@
       }
       break;
     }
-
     default: {
-      // TODO: warning: type is not exportable
+      // TODO(zonr): warn that type is not exportable
       fprintf(stderr, "RSExportElement::Create : type '%s' is not exportable\n",
               T->getTypeClassName());
       break;
@@ -182,7 +176,7 @@
 }
 
 const RSExportElement::ElementInfo *
-RSExportElement::GetElementInfo(const llvm::StringRef& Name) {
+RSExportElement::GetElementInfo(const llvm::StringRef &Name) {
   if (!Initialized)
     Init();