commit 159a8323064d8550218bf31465e51cc5a5d14926
author Thierry Strudel <tstrudel@google.com> Wed Mar 23 11:22:34 2016 -0700
committer Thierry Strudel <tstrudel@google.com> Wed Mar 23 11:22:34 2016 -0700
tree d343667e9263ac0b8db6134ece9d114f29635cc5
parent 5b817549fcea6f58bbeaaffbf654ddd8751ebbdc

dumpsys: fix error condition

Bug: 27809529
Change-Id: Ia2bdac83a367e1dd550ea7a5b50eac14d84f66b2
Signed-off-by: Thierry Strudel <tstrudel@google.com>

cmds/dumpsys/dumpsys.cpp

diff --git a/cmds/dumpsys/dumpsys.cpp b/cmds/dumpsys/dumpsys.cpp
index db06e99..7e5bbc5 100644
--- a/cmds/dumpsys/dumpsys.cpp
+++ b/cmds/dumpsys/dumpsys.cpp
@@ -138,13 +138,12 @@
     }
 
     if ((skipServices && skippedServices.empty()) ||
-            (!skipServices && !showListOnly && services.empty()) ||
             (showListOnly && (!services.empty() || !skippedServices.empty()))) {
         usage();
         return -1;
     }
 
-    if (!skippedServices.empty() || showListOnly) {
+    if (services.empty() || showListOnly) {
         // gets all services
         services = sm->listServices();
         services.sort(sort_func);