clean-up EGL includes
Test: compile and run
Bug: cleanup
Change-Id: Icb6c70c80d455446d7163a20d51c41d9b6e0b578
diff --git a/libs/ui/GraphicBuffer.cpp b/libs/ui/GraphicBuffer.cpp
index 37ebfb3..c4d8f76 100644
--- a/libs/ui/GraphicBuffer.cpp
+++ b/libs/ui/GraphicBuffer.cpp
@@ -17,6 +17,9 @@
#define LOG_TAG "GraphicBuffer"
#include <ui/GraphicBuffer.h>
+
+#include <cutils/atomic.h>
+
#include <ui/GrallocMapper.h>
#include <ui/GraphicBufferAllocator.h>
#include <ui/GraphicBufferMapper.h>
diff --git a/opengl/libs/EGL/Loader.cpp b/opengl/libs/EGL/Loader.cpp
index b1ca13d..9aedc61 100644
--- a/opengl/libs/EGL/Loader.cpp
+++ b/opengl/libs/EGL/Loader.cpp
@@ -17,26 +17,21 @@
//#define LOG_NDEBUG 0
#define ATRACE_TAG ATRACE_TAG_GRAPHICS
-#include <array>
-#include <ctype.h>
+#include "Loader.h"
+
#include <dirent.h>
#include <dlfcn.h>
-#include <errno.h>
-#include <limits.h>
-#include <stdio.h>
-#include <stdlib.h>
-#include <string.h>
#include <android/dlext.h>
#include <cutils/properties.h>
#include <log/log.h>
+
+#include <utils/String8.h>
#include <utils/Trace.h>
+
#include <ui/GraphicsEnv.h>
-#include <EGL/egl.h>
-
#include "egldefs.h"
-#include "Loader.h"
// ----------------------------------------------------------------------------
namespace android {
@@ -437,10 +432,10 @@
return android_dlopen_ext(path, mode, info);
}
-static const std::array<const char*, 2> HAL_SUBNAME_KEY_PROPERTIES = {{
+static const char* HAL_SUBNAME_KEY_PROPERTIES[2] = {
"ro.hardware.egl",
"ro.board.platform",
-}};
+};
static void* load_updated_driver(const char* kind, android_namespace_t* ns) {
ATRACE_CALL();
@@ -454,10 +449,10 @@
if (property_get(key, prop, nullptr) > 0) {
String8 name;
name.appendFormat("lib%s_%s.so", kind, prop);
- so = do_android_dlopen_ext(name.string(), RTLD_LOCAL | RTLD_NOW,
- &dlextinfo);
- if (so)
+ so = do_android_dlopen_ext(name.string(), RTLD_LOCAL | RTLD_NOW, &dlextinfo);
+ if (so) {
return so;
+ }
}
}
return nullptr;
diff --git a/opengl/libs/EGL/Loader.h b/opengl/libs/EGL/Loader.h
index b0743a5..2dd4206 100644
--- a/opengl/libs/EGL/Loader.h
+++ b/opengl/libs/EGL/Loader.h
@@ -17,13 +17,10 @@
#ifndef ANDROID_EGL_LOADER_H
#define ANDROID_EGL_LOADER_H
-#include <ctype.h>
-#include <string.h>
-#include <errno.h>
+#include <stdint.h>
#include <utils/Errors.h>
#include <utils/Singleton.h>
-#include <utils/String8.h>
#include <EGL/egl.h>
@@ -33,12 +30,10 @@
struct egl_connection_t;
-class Loader : public Singleton<Loader>
-{
+class Loader : public Singleton<Loader> {
friend class Singleton<Loader>;
- typedef __eglMustCastToProperFunctionPointerType (*getProcAddressType)(
- const char*);
+ typedef __eglMustCastToProperFunctionPointerType (* getProcAddressType)(const char*);
enum {
EGL = 0x01,
diff --git a/opengl/libs/EGL/egl.cpp b/opengl/libs/EGL/egl.cpp
index ee83ada..34b0ba2 100644
--- a/opengl/libs/EGL/egl.cpp
+++ b/opengl/libs/EGL/egl.cpp
@@ -14,30 +14,26 @@
** limitations under the License.
*/
-#include <ctype.h>
#include <stdlib.h>
-#include <string.h>
#include <hardware/gralloc.h>
-#include <system/window.h>
#include <EGL/egl.h>
-#include <EGL/eglext.h>
#include <cutils/atomic.h>
#include <cutils/properties.h>
+
#include <log/log.h>
+
#include <utils/CallStack.h>
-#include <utils/String8.h>
#include "../egl_impl.h"
-#include "egl_tls.h"
#include "egldefs.h"
-#include "Loader.h"
-
+#include "egl_tls.h"
#include "egl_display.h"
#include "egl_object.h"
+#include "Loader.h"
typedef __eglMustCastToProperFunctionPointerType EGLFuncPointer;
diff --git a/opengl/libs/EGL/eglApi.cpp b/opengl/libs/EGL/eglApi.cpp
index c434d0e..3359c64 100644
--- a/opengl/libs/EGL/eglApi.cpp
+++ b/opengl/libs/EGL/eglApi.cpp
@@ -22,7 +22,6 @@
#include <string.h>
#include <hardware/gralloc1.h>
-#include <system/window.h>
#include <EGL/egl.h>
#include <EGL/eglext.h>
@@ -30,9 +29,7 @@
#include <android/hardware_buffer.h>
#include <private/android/AHardwareBufferHelpers.h>
-#include <cutils/atomic.h>
#include <cutils/compiler.h>
-#include <cutils/memory.h>
#include <cutils/properties.h>
#include <log/log.h>
@@ -44,18 +41,17 @@
#include <utils/KeyedVector.h>
#include <utils/String8.h>
#include <utils/Trace.h>
+#include <utils/Thread.h>
#include "binder/Binder.h"
#include "binder/Parcel.h"
#include "binder/IServiceManager.h"
#include "../egl_impl.h"
-#include "../hooks.h"
#include "egl_display.h"
#include "egl_object.h"
#include "egl_tls.h"
-#include "egldefs.h"
using namespace android;
@@ -84,11 +80,10 @@
* NOTE: Both strings MUST have a single space as the last character.
*/
-// CLion mistakenly warns about the extern keyword below.
-#pragma clang diagnostic push
-#pragma clang diagnostic ignored "-Wextern-initializer"
+extern char const * const gBuiltinExtensionString;
+extern char const * const gExtensionString;
-extern char const * const gBuiltinExtensionString =
+char const * const gBuiltinExtensionString =
"EGL_KHR_get_all_proc_addresses "
"EGL_ANDROID_presentation_time "
"EGL_KHR_swap_buffers_with_damage "
@@ -97,7 +92,8 @@
"EGL_ANDROID_front_buffer_auto_refresh "
"EGL_ANDROID_get_frame_timestamps "
;
-extern char const * const gExtensionString =
+
+char const * const gExtensionString =
"EGL_KHR_image " // mandatory
"EGL_KHR_image_base " // mandatory
"EGL_KHR_image_pixmap "
@@ -237,8 +233,6 @@
(__eglMustCastToProperFunctionPointerType)&eglGetFrameTimestampSupportedANDROID },
};
-#pragma clang diagnostic pop
-
/*
* These extensions entry-points should not be exposed to applications.
* They're used internally by the Android EGL layer.
diff --git a/opengl/libs/EGL/egl_cache.cpp b/opengl/libs/EGL/egl_cache.cpp
index 1fe322d..e46716c 100644
--- a/opengl/libs/EGL/egl_cache.cpp
+++ b/opengl/libs/EGL/egl_cache.cpp
@@ -14,18 +14,17 @@
** limitations under the License.
*/
+#include "egl_cache.h"
+
#include "../egl_impl.h"
-#include "egl_cache.h"
#include "egl_display.h"
-#include "egldefs.h"
-#include <fcntl.h>
#include <inttypes.h>
#include <sys/mman.h>
#include <sys/stat.h>
-#include <sys/types.h>
-#include <unistd.h>
+
+#include <utils/Thread.h>
// Cache size limits.
static const size_t maxKeySize = 12 * 1024;
@@ -87,7 +86,7 @@
bool atStart = !strncmp(BC_EXT_STR " ", exts, bcExtLen+1);
bool atEnd = (bcExtLen+1) < extsLen &&
!strcmp(" " BC_EXT_STR, exts + extsLen - (bcExtLen+1));
- bool inMiddle = strstr(exts, " " BC_EXT_STR " ");
+ bool inMiddle = strstr(exts, " " BC_EXT_STR " ") != nullptr;
if (equal || atStart || atEnd || inMiddle) {
PFNEGLSETBLOBCACHEFUNCSANDROIDPROC eglSetBlobCacheFuncsANDROID;
eglSetBlobCacheFuncsANDROID =
diff --git a/opengl/libs/EGL/egl_cache.h b/opengl/libs/EGL/egl_cache.h
index 8760009..e7f1712 100644
--- a/opengl/libs/EGL/egl_cache.h
+++ b/opengl/libs/EGL/egl_cache.h
@@ -21,6 +21,7 @@
#include <EGL/eglext.h>
#include <utils/BlobCache.h>
+#include <utils/Mutex.h>
#include <utils/String8.h>
#include <utils/StrongPointer.h>
diff --git a/opengl/libs/EGL/egl_display.cpp b/opengl/libs/EGL/egl_display.cpp
index d7df40c..c804fa7 100644
--- a/opengl/libs/EGL/egl_display.cpp
+++ b/opengl/libs/EGL/egl_display.cpp
@@ -17,16 +17,16 @@
#define __STDC_LIMIT_MACROS 1
#define ATRACE_TAG ATRACE_TAG_GRAPHICS
-#include <string.h>
+#include "egl_display.h"
#include "../egl_impl.h"
#include "egl_cache.h"
-#include "egl_display.h"
#include "egl_object.h"
#include "egl_tls.h"
#include "Loader.h"
#include <cutils/properties.h>
+
#include <utils/Trace.h>
// ----------------------------------------------------------------------------
diff --git a/opengl/libs/EGL/egl_display.h b/opengl/libs/EGL/egl_display.h
index e17558c..f5e7294 100644
--- a/opengl/libs/EGL/egl_display.h
+++ b/opengl/libs/EGL/egl_display.h
@@ -18,16 +18,16 @@
#define ANDROID_EGL_DISPLAY_H
-#include <ctype.h>
#include <stdint.h>
-#include <stdlib.h>
+#include <stddef.h>
#include <EGL/egl.h>
#include <EGL/eglext.h>
#include <cutils/compiler.h>
#include <utils/SortedVector.h>
-#include <utils/threads.h>
+#include <utils/Condition.h>
+#include <utils/Mutex.h>
#include <utils/String8.h>
#include "egldefs.h"
diff --git a/opengl/libs/EGL/egl_object.cpp b/opengl/libs/EGL/egl_object.cpp
index 7fc5609..b553d71 100644
--- a/opengl/libs/EGL/egl_object.cpp
+++ b/opengl/libs/EGL/egl_object.cpp
@@ -14,19 +14,10 @@
** limitations under the License.
*/
-#include <string>
+#include "egl_object.h"
+
#include <sstream>
-#include <ctype.h>
-#include <stdint.h>
-#include <stdlib.h>
-
-#include <EGL/egl.h>
-#include <EGL/eglext.h>
-
-#include <utils/threads.h>
-
-#include "egl_object.h"
// ----------------------------------------------------------------------------
namespace android {
diff --git a/opengl/libs/EGL/egl_object.h b/opengl/libs/EGL/egl_object.h
index 8ceba1d..f4012ab 100644
--- a/opengl/libs/EGL/egl_object.h
+++ b/opengl/libs/EGL/egl_object.h
@@ -17,15 +17,13 @@
#ifndef ANDROID_EGL_OBJECT_H
#define ANDROID_EGL_OBJECT_H
-#include <atomic>
-#include <ctype.h>
#include <stdint.h>
-#include <stdlib.h>
+#include <stddef.h>
#include <EGL/egl.h>
#include <EGL/eglext.h>
-#include <utils/threads.h>
+#include <utils/StrongPointer.h>
#include <utils/String8.h>
#include <utils/Vector.h>
@@ -62,8 +60,8 @@
template <typename N, typename T>
class LocalRef {
egl_object_t* ref;
- LocalRef();
- explicit LocalRef(const LocalRef* rhs);
+ LocalRef() = delete;
+ LocalRef(const LocalRef* rhs) = delete;
public:
~LocalRef();
explicit LocalRef(egl_object_t* rhs);
diff --git a/opengl/libs/EGL/egl_tls.cpp b/opengl/libs/EGL/egl_tls.cpp
index 6de5f27..ca8684e 100644
--- a/opengl/libs/EGL/egl_tls.cpp
+++ b/opengl/libs/EGL/egl_tls.cpp
@@ -14,16 +14,14 @@
** limitations under the License.
*/
-#include <pthread.h>
+#include "egl_tls.h"
+
#include <stdlib.h>
#include <cutils/properties.h>
#include <log/log.h>
#include <utils/CallStack.h>
-#include <EGL/egl.h>
-
-#include "egl_tls.h"
namespace android {
@@ -31,7 +29,7 @@
pthread_once_t egl_tls_t::sOnceKey = PTHREAD_ONCE_INIT;
egl_tls_t::egl_tls_t()
- : error(EGL_SUCCESS), ctx(0), logCallWithNoContext(EGL_TRUE) {
+ : error(EGL_SUCCESS), ctx(0), logCallWithNoContext(true) {
}
const char *egl_tls_t::egl_strerror(EGLint err) {
@@ -85,11 +83,12 @@
bool egl_tls_t::logNoContextCall() {
egl_tls_t* tls = getTLS();
- if (tls->logCallWithNoContext == true) {
+ if (tls->logCallWithNoContext) {
tls->logCallWithNoContext = false;
return true;
}
return false;
+
}
egl_tls_t* egl_tls_t::getTLS() {
diff --git a/opengl/libs/EGL/egl_tls.h b/opengl/libs/EGL/egl_tls.h
index 00eae0b..9feae68 100644
--- a/opengl/libs/EGL/egl_tls.h
+++ b/opengl/libs/EGL/egl_tls.h
@@ -17,11 +17,9 @@
#ifndef ANDROID_EGL_TLS_H
#define ANDROID_EGL_TLS_H
-#include <pthread.h>
-
#include <EGL/egl.h>
-#include "egldefs.h"
+#include <pthread.h>
// ----------------------------------------------------------------------------
namespace android {
@@ -36,7 +34,7 @@
EGLint error;
EGLContext ctx;
- EGLBoolean logCallWithNoContext;
+ bool logCallWithNoContext;
egl_tls_t();
static void validateTLSKey();
diff --git a/opengl/libs/egl_impl.h b/opengl/libs/egl_impl.h
index c0990ec..a8855ef 100644
--- a/opengl/libs/egl_impl.h
+++ b/opengl/libs/egl_impl.h
@@ -17,8 +17,6 @@
#ifndef ANDROID_EGL_IMPL_H
#define ANDROID_EGL_IMPL_H
-#include <ctype.h>
-
#include <EGL/egl.h>
#include <EGL/eglext.h>
#include <EGL/eglplatform.h>
@@ -30,8 +28,7 @@
// ----------------------------------------------------------------------------
EGLAPI const GLubyte * egl_get_string_for_current_context(GLenum name);
-EGLAPI const GLubyte * egl_get_string_for_current_context(GLenum name,
- GLuint index);
+EGLAPI const GLubyte * egl_get_string_for_current_context(GLenum name, GLuint index);
EGLAPI GLint egl_get_num_extensions_for_current_context();
// ----------------------------------------------------------------------------