commit 38d2500594652eabe7ee989d40b7190a26c577cc
author Robert Carr <racarr@google.com> Fri Jun 11 14:30:09 2021 -0700
committer Robert Carr <racarr@google.com> Tue Jun 15 11:53:29 2021 -0700
tree 6819769370bc9866374ef81f18b12f91cc026fa8
parent 13a864c4702e4303b6ccb26ae0cbe573bf62e2da

Layer: Don't need atomic for transaction flags

Following queued transaction changes we don't need an atomic here
since setPosition etc all execute on the main thread.

Test: Existing tests pass. simpleperf
Bug: 186200583
Change-Id: I965d3883d30ce1eb3c452742535281f3e2719424

services/surfaceflinger/BufferStateLayer.cpp

diff --git a/services/surfaceflinger/BufferStateLayer.cpp b/services/surfaceflinger/BufferStateLayer.cpp
index d68a0e0..6213a8a 100644
--- a/services/surfaceflinger/BufferStateLayer.cpp
+++ b/services/surfaceflinger/BufferStateLayer.cpp
@@ -33,6 +33,7 @@
 #include <gui/BufferQueue.h>
 #include <private/gui/SyncFeatures.h>
 #include <renderengine/Image.h>
+#include "TunnelModeEnabledReporter.h"
 
 #include "EffectLayer.h"
 #include "FrameTracer/FrameTracer.h"

services/surfaceflinger/Layer.cpp

diff --git a/services/surfaceflinger/Layer.cpp b/services/surfaceflinger/Layer.cpp
index 2bf5602..00defb3 100644
--- a/services/surfaceflinger/Layer.cpp
+++ b/services/surfaceflinger/Layer.cpp
@@ -847,11 +847,13 @@
 }
 
 uint32_t Layer::getTransactionFlags(uint32_t flags) {
-    return mTransactionFlags.fetch_and(~flags) & flags;
+    auto ret = mTransactionFlags & flags;
+    mTransactionFlags &= ~flags;
+    return ret;
 }
 
 uint32_t Layer::setTransactionFlags(uint32_t flags) {
-    return mTransactionFlags.fetch_or(flags);
+    return mTransactionFlags |= flags;
 }
 
 bool Layer::setPosition(float x, float y) {

services/surfaceflinger/Layer.h

diff --git a/services/surfaceflinger/Layer.h b/services/surfaceflinger/Layer.h
index 5873103..5669049 100644
--- a/services/surfaceflinger/Layer.h
+++ b/services/surfaceflinger/Layer.h
@@ -960,7 +960,7 @@
 
     // these are protected by an external lock (mStateLock)
     State mCurrentState;
-    std::atomic<uint32_t> mTransactionFlags{0};
+    uint32_t mTransactionFlags{0};
 
     // Timestamp history for UIAutomation. Thread safe.
     FrameTracker mFrameTracker;