commit 3bb979136595c6132d6c3b2a2aacac5bf352c4ef
author Valerie Hau <vhau@google.com> Thu Apr 09 10:40:10 2020 -0700
committer Valerie Hau <vhau@google.com> Thu Apr 09 10:40:10 2020 -0700
tree 7e4cdea928e421605a19facde709d77286129fa7
parent 14f49cd4d3566751258de3b050c2aea181fea9fc

Check for no error in getting planeLayout in lock

Bug: 153375197
Test: build, boot, libui_test
Change-Id: I47715b31d759367f22ca14598e43b078094d9d75

libs/ui/Gralloc4.cpp

diff --git a/libs/ui/Gralloc4.cpp b/libs/ui/Gralloc4.cpp
index 6fd4b80..c703290 100644
--- a/libs/ui/Gralloc4.cpp
+++ b/libs/ui/Gralloc4.cpp
@@ -202,7 +202,7 @@
     std::vector<ui::PlaneLayout> planeLayouts;
     status_t err = getPlaneLayouts(bufferHandle, &planeLayouts);
 
-    if (err != NO_ERROR && !planeLayouts.empty()) {
+    if (err == NO_ERROR && !planeLayouts.empty()) {
         if (outBytesPerPixel) {
             int32_t bitsPerPixel = planeLayouts.front().sampleIncrementInBits;
             for (const auto& planeLayout : planeLayouts) {