commit 9d089afd1de9bf4807840616a886a688dc1075ab
author Steven Moreland <smoreland@google.com> Tue Sep 18 08:58:09 2018 -0700
committer Steven Moreland <smoreland@google.com> Tue Sep 18 09:00:00 2018 -0700
tree 0d82cec8f661fe2f707ce95d42c2d399a25dac7f
parent 4549f39cdbe7b301693d9789fe189f1709d55107

libbinder_ndk: BAD_TYPE on bad checkInterface

As is convention. Previously PERMISSION_DENIED which isn't as clear and
also isn't consistent.

Bug: 111445392
Test: ./ndk/runtests.sh (note, this passing just indicates that this
    path isn't exercised. Multi-process tests are still in progress).

Change-Id: Ic66a61e87b7066224fff5ed7423fcfb0d50ffa93

libs/binder/ndk/ibinder.cpp

diff --git a/libs/binder/ndk/ibinder.cpp b/libs/binder/ndk/ibinder.cpp
index b1b4194..f16cde6 100644
--- a/libs/binder/ndk/ibinder.cpp
+++ b/libs/binder/ndk/ibinder.cpp
@@ -122,7 +122,7 @@
                               binder_flags_t flags) {
     if (isUserCommand(code)) {
         if (!data.checkInterface(this)) {
-            return STATUS_PERMISSION_DENIED;
+            return STATUS_BAD_TYPE;
         }
 
         const AParcel in = AParcel::readOnly(this, &data);