commit aaf621675d102848eb8c2cbe36edd6969dc6b016
author Chih-Hung Hsieh <chh@google.com> Thu Dec 20 15:45:04 2018 -0800
committer Chih-hung Hsieh <chh@google.com> Fri Jan 04 17:24:09 2019 +0000
tree 63aeb6717d091d09fe4ba16ff071d9f97d6117bf
parent 8f3776a7ace3d5c7bd4832367c495f63825a51b1

Fix/suppress libs/gui google-explicit-constructor warnings

* Add explicit to conversion constructors/operators

Bug: 28341362
Test: make with WITH_TIDY=1 DEFAULT_GLOBAL_TIDY_CHECKS=-*,google-explicit-constructor
Change-Id: I76384db26fac6da2de3dbb9092c26c4979324948

libs/gui/tests/Malicious.cpp

diff --git a/libs/gui/tests/Malicious.cpp b/libs/gui/tests/Malicious.cpp
index bb6b8a5..acd4297 100644
--- a/libs/gui/tests/Malicious.cpp
+++ b/libs/gui/tests/Malicious.cpp
@@ -27,7 +27,7 @@
 
 class ProxyBQP : public BnGraphicBufferProducer {
 public:
-    ProxyBQP(const sp<IGraphicBufferProducer>& producer) : mProducer(producer) {}
+    explicit ProxyBQP(const sp<IGraphicBufferProducer>& producer) : mProducer(producer) {}
 
     // Pass through calls to mProducer
     status_t requestBuffer(int slot, sp<GraphicBuffer>* buf) override {
@@ -102,7 +102,7 @@
 
 class MaliciousBQP : public ProxyBQP {
 public:
-    MaliciousBQP(const sp<IGraphicBufferProducer>& producer) : ProxyBQP(producer) {}
+    explicit MaliciousBQP(const sp<IGraphicBufferProducer>& producer) : ProxyBQP(producer) {}
 
     void beMalicious(int32_t value) { mMaliciousValue = value; }