commit e07105869c79c6ea2844310a45373eeb7b5c4cfa
author John Reck <jreck@google.com> Thu Sep 26 13:46:12 2019 -0700
committer John Reck <jreck@google.com> Thu Sep 26 14:18:10 2019 -0700
tree 07a9c495ba3eb9a9d3f73d6c68df177d050faad1
parent db313f6b27743d37098159c0b4d50b91f84bda55

Remove logspam

This log fires constantly on a device that appears to have touch
that's working perfectly fine. So it seems to be an ALOGV and
not actually an error that needs to be logged.

Also turn off ALOGV's and fix an unused variable error

Test: adb logcat

Change-Id: I7c66b76c6c47b22c0317ff98556873bd4d351d95

services/inputflinger/dispatcher/InputDispatcher.cpp

diff --git a/services/inputflinger/dispatcher/InputDispatcher.cpp b/services/inputflinger/dispatcher/InputDispatcher.cpp
index e161e8c..8dcf1e0 100644
--- a/services/inputflinger/dispatcher/InputDispatcher.cpp
+++ b/services/inputflinger/dispatcher/InputDispatcher.cpp
@@ -17,7 +17,7 @@
 #define LOG_TAG "InputDispatcher"
 #define ATRACE_TAG ATRACE_TAG_INPUT
 
-#define LOG_NDEBUG 0
+#define LOG_NDEBUG 1
 
 // Log detailed debug messages about each inbound event notification to the dispatcher.
 #define DEBUG_INBOUND_EVENT_DETAILS 0
@@ -3219,7 +3219,7 @@
                     !(info->layoutParamsFlags & InputWindowInfo::FLAG_NOT_TOUCHABLE) ||
                     !(info->layoutParamsFlags & InputWindowInfo::FLAG_NOT_FOCUSABLE);
             if (canReceiveInput && !noInputChannel) {
-                ALOGE("Window handle %s has no registered input channel",
+                ALOGV("Window handle %s has no registered input channel",
                       handle->getName().c_str());
             }
             continue;
@@ -3954,7 +3954,7 @@
         return BAD_VALUE;
     }
 
-    const bool removed = removeByValue(mConnectionsByFd, connection);
+    [[maybe_unused]] const bool removed = removeByValue(mConnectionsByFd, connection);
     ALOG_ASSERT(removed);
     mInputChannelsByToken.erase(inputChannel->getToken());