blob: 1882771202c1ca01340e9a828a31555089aea652 [file] [log] [blame]
Jeff Sharkey6c2c0562016-12-07 12:12:00 -07001/*
2 * Copyright (C) 2016 The Android Open Source Project
3 *
4 * Licensed under the Apache License, Version 2.0 (the "License");
5 * you may not use this file except in compliance with the License.
6 * You may obtain a copy of the License at
7 *
8 * http://www.apache.org/licenses/LICENSE-2.0
9 *
10 * Unless required by applicable law or agreed to in writing, software
11 * distributed under the License is distributed on an "AS IS" BASIS,
12 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13 * See the License for the specific language governing permissions and
14 * limitations under the License.
15 */
Mark Salyzyna5e161b2016-09-29 08:08:05 -070016#define LOG_TAG "installed"
Jeff Sharkey6c2c0562016-12-07 12:12:00 -070017
Alan Stokesa25d90c2017-10-16 10:56:00 +010018#include <array>
Jeff Sharkey90aff262016-12-12 14:28:24 -070019#include <fcntl.h>
Jeff Sharkey6c2c0562016-12-07 12:12:00 -070020#include <stdlib.h>
21#include <string.h>
Jeff Sharkey90aff262016-12-12 14:28:24 -070022#include <sys/capability.h>
23#include <sys/file.h>
Jeff Sharkey6c2c0562016-12-07 12:12:00 -070024#include <sys/stat.h>
Jeff Sharkey90aff262016-12-12 14:28:24 -070025#include <sys/time.h>
26#include <sys/types.h>
27#include <sys/resource.h>
28#include <sys/wait.h>
Jeff Sharkey6c2c0562016-12-07 12:12:00 -070029#include <unistd.h>
30
Andreas Gampe023b2242018-02-28 16:03:25 -080031#include <iomanip>
32
Alan Stokesa25d90c2017-10-16 10:56:00 +010033#include <android-base/file.h>
Jeff Sharkey6c2c0562016-12-07 12:12:00 -070034#include <android-base/logging.h>
Andreas Gampe6a9cf722017-07-24 16:49:10 -070035#include <android-base/properties.h>
Jeff Sharkey6c2c0562016-12-07 12:12:00 -070036#include <android-base/stringprintf.h>
Jeff Sharkey90aff262016-12-12 14:28:24 -070037#include <android-base/strings.h>
38#include <android-base/unique_fd.h>
Calin Juravle80a21252017-01-17 14:43:25 -080039#include <cutils/fs.h>
Jeff Sharkey90aff262016-12-12 14:28:24 -070040#include <cutils/properties.h>
41#include <cutils/sched_policy.h>
Andreas Gampefa2dadd2018-02-28 19:52:47 -080042#include <dex2oat_return_codes.h>
Mark Salyzyn7823e122016-09-29 08:08:05 -070043#include <log/log.h> // TODO: Move everything to base/logging.
Alan Stokesa25d90c2017-10-16 10:56:00 +010044#include <openssl/sha.h>
Jeff Sharkey90aff262016-12-12 14:28:24 -070045#include <private/android_filesystem_config.h>
Calin Juravlecb556e32017-04-04 20:22:50 -070046#include <selinux/android.h>
Jeff Sharkey90aff262016-12-12 14:28:24 -070047#include <system/thread_defs.h>
Jeff Sharkey6c2c0562016-12-07 12:12:00 -070048
49#include "dexopt.h"
Andreas Gampefa2dadd2018-02-28 19:52:47 -080050#include "dexopt_return_codes.h"
Jeff Sharkeyc1149c92017-09-21 14:51:09 -060051#include "globals.h"
Jeff Sharkey90aff262016-12-12 14:28:24 -070052#include "installd_deps.h"
53#include "otapreopt_utils.h"
Jeff Sharkey6c2c0562016-12-07 12:12:00 -070054#include "utils.h"
55
Jeff Sharkey90aff262016-12-12 14:28:24 -070056using android::base::EndsWith;
Alan Stokesa25d90c2017-10-16 10:56:00 +010057using android::base::ReadFully;
58using android::base::StringPrintf;
59using android::base::WriteFully;
Calin Juravle1a0af3b2017-03-09 14:33:33 -080060using android::base::unique_fd;
Jeff Sharkey6c2c0562016-12-07 12:12:00 -070061
62namespace android {
63namespace installd {
64
Andreas Gampe2a2d7ba2017-11-02 19:39:29 -070065// Should minidebug info be included in compiled artifacts? Even if this value is
66// "true," usage might still be conditional to other constraints, e.g., system
67// property overrides.
68static constexpr bool kEnableMinidebugInfo = true;
69
70static constexpr const char* kMinidebugInfoSystemProperty = "dalvik.vm.dex2oat-minidebuginfo";
71static constexpr bool kMinidebugInfoSystemPropertyDefault = false;
72static constexpr const char* kMinidebugDex2oatFlag = "--generate-mini-debug-info";
Mathieu Chartierb41ffcc2018-01-09 00:02:17 -080073static constexpr const char* kDisableCompactDexFlag = "--compact-dex-level=none";
Andreas Gampe2a2d7ba2017-11-02 19:39:29 -070074
Andreas Gampefa2dadd2018-02-28 19:52:47 -080075
Calin Juravle114f0812017-03-08 19:05:07 -080076// Deleter using free() for use with std::unique_ptr<>. See also UniqueCPtr<> below.
77struct FreeDelete {
78 // NOTE: Deleting a const object is valid but free() takes a non-const pointer.
79 void operator()(const void* ptr) const {
80 free(const_cast<void*>(ptr));
81 }
82};
83
84// Alias for std::unique_ptr<> that uses the C function free() to delete objects.
85template <typename T>
86using UniqueCPtr = std::unique_ptr<T, FreeDelete>;
87
Calin Juravle1a0af3b2017-03-09 14:33:33 -080088static unique_fd invalid_unique_fd() {
89 return unique_fd(-1);
90}
91
Andreas Gampe6a9cf722017-07-24 16:49:10 -070092static bool is_debug_runtime() {
93 return android::base::GetProperty("persist.sys.dalvik.vm.lib.2", "") == "libartd.so";
94}
95
David Sehra3b5ab62017-10-25 14:27:29 -070096static bool is_debuggable_build() {
97 return android::base::GetBoolProperty("ro.debuggable", false);
98}
99
Jeff Sharkey90aff262016-12-12 14:28:24 -0700100static bool clear_profile(const std::string& profile) {
Calin Juravle1a0af3b2017-03-09 14:33:33 -0800101 unique_fd ufd(open(profile.c_str(), O_WRONLY | O_NOFOLLOW | O_CLOEXEC));
Jeff Sharkey90aff262016-12-12 14:28:24 -0700102 if (ufd.get() < 0) {
103 if (errno != ENOENT) {
104 PLOG(WARNING) << "Could not open profile " << profile;
105 return false;
106 } else {
107 // Nothing to clear. That's ok.
108 return true;
109 }
110 }
111
112 if (flock(ufd.get(), LOCK_EX | LOCK_NB) != 0) {
113 if (errno != EWOULDBLOCK) {
114 PLOG(WARNING) << "Error locking profile " << profile;
115 }
116 // This implies that the app owning this profile is running
117 // (and has acquired the lock).
118 //
119 // If we can't acquire the lock bail out since clearing is useless anyway
120 // (the app will write again to the profile).
121 //
122 // Note:
123 // This does not impact the this is not an issue for the profiling correctness.
124 // In case this is needed because of an app upgrade, profiles will still be
125 // eventually cleared by the app itself due to checksum mismatch.
126 // If this is needed because profman advised, then keeping the data around
127 // until the next run is again not an issue.
128 //
129 // If the app attempts to acquire a lock while we've held one here,
130 // it will simply skip the current write cycle.
131 return false;
132 }
133
134 bool truncated = ftruncate(ufd.get(), 0) == 0;
135 if (!truncated) {
136 PLOG(WARNING) << "Could not truncate " << profile;
137 }
138 if (flock(ufd.get(), LOCK_UN) != 0) {
139 PLOG(WARNING) << "Error unlocking profile " << profile;
140 }
141 return truncated;
142}
143
Calin Juravle114f0812017-03-08 19:05:07 -0800144// Clear the reference profile for the given location.
Calin Juravle824a64d2018-01-18 20:23:17 -0800145// The location is the profile name for primary apks or the dex path for secondary dex files.
146static bool clear_reference_profile(const std::string& package_name, const std::string& location,
147 bool is_secondary_dex) {
148 return clear_profile(create_reference_profile_path(package_name, location, is_secondary_dex));
Jeff Sharkey90aff262016-12-12 14:28:24 -0700149}
150
Calin Juravle114f0812017-03-08 19:05:07 -0800151// Clear the reference profile for the given location.
Calin Juravle824a64d2018-01-18 20:23:17 -0800152// The location is the profile name for primary apks or the dex path for secondary dex files.
153static bool clear_current_profile(const std::string& package_name, const std::string& location,
154 userid_t user, bool is_secondary_dex) {
155 return clear_profile(create_current_profile_path(user, package_name, location,
156 is_secondary_dex));
Jeff Sharkey90aff262016-12-12 14:28:24 -0700157}
158
Calin Juravle114f0812017-03-08 19:05:07 -0800159// Clear the reference profile for the primary apk of the given package.
Calin Juravle824a64d2018-01-18 20:23:17 -0800160// The location is the profile name for primary apks or the dex path for secondary dex files.
161bool clear_primary_reference_profile(const std::string& package_name,
162 const std::string& location) {
163 return clear_reference_profile(package_name, location, /*is_secondary_dex*/false);
Calin Juravle114f0812017-03-08 19:05:07 -0800164}
165
166// Clear all current profile for the primary apk of the given package.
Calin Juravle824a64d2018-01-18 20:23:17 -0800167// The location is the profile name for primary apks or the dex path for secondary dex files.
168bool clear_primary_current_profiles(const std::string& package_name, const std::string& location) {
Jeff Sharkey90aff262016-12-12 14:28:24 -0700169 bool success = true;
Calin Juravle114f0812017-03-08 19:05:07 -0800170 // For secondary dex files, we don't really need the user but we use it for sanity checks.
Jeff Sharkey90aff262016-12-12 14:28:24 -0700171 std::vector<userid_t> users = get_known_users(/*volume_uuid*/ nullptr);
172 for (auto user : users) {
Calin Juravle824a64d2018-01-18 20:23:17 -0800173 success &= clear_current_profile(package_name, location, user, /*is_secondary_dex*/false);
Jeff Sharkey90aff262016-12-12 14:28:24 -0700174 }
175 return success;
176}
177
Calin Juravle114f0812017-03-08 19:05:07 -0800178// Clear the current profile for the primary apk of the given package and user.
Calin Juravle824a64d2018-01-18 20:23:17 -0800179bool clear_primary_current_profile(const std::string& package_name, const std::string& location,
180 userid_t user) {
181 return clear_current_profile(package_name, location, user, /*is_secondary_dex*/false);
Calin Juravle114f0812017-03-08 19:05:07 -0800182}
183
Jeff Sharkey90aff262016-12-12 14:28:24 -0700184static int split_count(const char *str)
185{
186 char *ctx;
187 int count = 0;
188 char buf[kPropertyValueMax];
189
Jeff Sharkeyc1149c92017-09-21 14:51:09 -0600190 strlcpy(buf, str, sizeof(buf));
Jeff Sharkey90aff262016-12-12 14:28:24 -0700191 char *pBuf = buf;
192
193 while(strtok_r(pBuf, " ", &ctx) != NULL) {
194 count++;
195 pBuf = NULL;
196 }
197
198 return count;
199}
200
201static int split(char *buf, const char **argv)
202{
203 char *ctx;
204 int count = 0;
205 char *tok;
206 char *pBuf = buf;
207
208 while((tok = strtok_r(pBuf, " ", &ctx)) != NULL) {
209 argv[count++] = tok;
210 pBuf = NULL;
211 }
212
213 return count;
214}
215
Jeff Hao10b8a6e2017-04-05 17:11:39 -0700216static const char* get_location_from_path(const char* path) {
217 static constexpr char kLocationSeparator = '/';
218 const char *location = strrchr(path, kLocationSeparator);
219 if (location == NULL) {
220 return path;
221 } else {
222 // Skip the separator character.
223 return location + 1;
224 }
225}
226
Andreas Gampefa2dadd2018-02-28 19:52:47 -0800227[[ noreturn ]]
Jeff Sharkey90aff262016-12-12 14:28:24 -0700228static void run_dex2oat(int zip_fd, int oat_fd, int input_vdex_fd, int output_vdex_fd, int image_fd,
229 const char* input_file_name, const char* output_file_name, int swap_fd,
Nicolas Geoffraybe6ecd62017-05-03 13:21:37 +0100230 const char* instruction_set, const char* compiler_filter,
Andreas Gampea73a0cb2017-11-02 18:14:42 -0700231 bool debuggable, bool post_bootcomplete, bool background_job_compile, int profile_fd,
Calin Juravle62c5a372018-02-01 17:03:23 +0000232 const char* class_loader_context, int target_sdk_version, bool enable_hidden_api_checks,
Calin Juravle2efc4022018-02-13 18:31:32 -0800233 int dex_metadata_fd, const char* compilation_reason) {
Jeff Sharkey90aff262016-12-12 14:28:24 -0700234 static const unsigned int MAX_INSTRUCTION_SET_LEN = 7;
235
236 if (strlen(instruction_set) >= MAX_INSTRUCTION_SET_LEN) {
Andreas Gampefa2dadd2018-02-28 19:52:47 -0800237 LOG(ERROR) << "Instruction set '" << instruction_set << "' longer than max length of "
238 << MAX_INSTRUCTION_SET_LEN;
239 exit(DexoptReturnCodes::kInstructionSetLength);
Jeff Sharkey90aff262016-12-12 14:28:24 -0700240 }
241
Jeff Hao10b8a6e2017-04-05 17:11:39 -0700242 // Get the relative path to the input file.
243 const char* relative_input_file_name = get_location_from_path(input_file_name);
244
Jeff Sharkey90aff262016-12-12 14:28:24 -0700245 char dex2oat_Xms_flag[kPropertyValueMax];
246 bool have_dex2oat_Xms_flag = get_property("dalvik.vm.dex2oat-Xms", dex2oat_Xms_flag, NULL) > 0;
247
248 char dex2oat_Xmx_flag[kPropertyValueMax];
249 bool have_dex2oat_Xmx_flag = get_property("dalvik.vm.dex2oat-Xmx", dex2oat_Xmx_flag, NULL) > 0;
250
251 char dex2oat_threads_buf[kPropertyValueMax];
252 bool have_dex2oat_threads_flag = get_property(post_bootcomplete
253 ? "dalvik.vm.dex2oat-threads"
254 : "dalvik.vm.boot-dex2oat-threads",
255 dex2oat_threads_buf,
256 NULL) > 0;
257 char dex2oat_threads_arg[kPropertyValueMax + 2];
258 if (have_dex2oat_threads_flag) {
259 sprintf(dex2oat_threads_arg, "-j%s", dex2oat_threads_buf);
260 }
261
262 char dex2oat_isa_features_key[kPropertyKeyMax];
263 sprintf(dex2oat_isa_features_key, "dalvik.vm.isa.%s.features", instruction_set);
264 char dex2oat_isa_features[kPropertyValueMax];
265 bool have_dex2oat_isa_features = get_property(dex2oat_isa_features_key,
266 dex2oat_isa_features, NULL) > 0;
267
268 char dex2oat_isa_variant_key[kPropertyKeyMax];
269 sprintf(dex2oat_isa_variant_key, "dalvik.vm.isa.%s.variant", instruction_set);
270 char dex2oat_isa_variant[kPropertyValueMax];
271 bool have_dex2oat_isa_variant = get_property(dex2oat_isa_variant_key,
272 dex2oat_isa_variant, NULL) > 0;
273
274 const char *dex2oat_norelocation = "-Xnorelocate";
275 bool have_dex2oat_relocation_skip_flag = false;
276
277 char dex2oat_flags[kPropertyValueMax];
278 int dex2oat_flags_count = get_property("dalvik.vm.dex2oat-flags",
279 dex2oat_flags, NULL) <= 0 ? 0 : split_count(dex2oat_flags);
280 ALOGV("dalvik.vm.dex2oat-flags=%s\n", dex2oat_flags);
281
Nicolas Geoffraybe6ecd62017-05-03 13:21:37 +0100282 // If we are booting without the real /data, don't spend time compiling.
Jeff Sharkey90aff262016-12-12 14:28:24 -0700283 char vold_decrypt[kPropertyValueMax];
284 bool have_vold_decrypt = get_property("vold.decrypt", vold_decrypt, "") > 0;
285 bool skip_compilation = (have_vold_decrypt &&
286 (strcmp(vold_decrypt, "trigger_restart_min_framework") == 0 ||
287 (strcmp(vold_decrypt, "1") == 0)));
288
289 bool generate_debug_info = property_get_bool("debug.generate-debug-info", false);
290
291 char app_image_format[kPropertyValueMax];
292 char image_format_arg[strlen("--image-format=") + kPropertyValueMax];
293 bool have_app_image_format =
294 image_fd >= 0 && get_property("dalvik.vm.appimageformat", app_image_format, NULL) > 0;
295 if (have_app_image_format) {
296 sprintf(image_format_arg, "--image-format=%s", app_image_format);
297 }
298
299 char dex2oat_large_app_threshold[kPropertyValueMax];
300 bool have_dex2oat_large_app_threshold =
301 get_property("dalvik.vm.dex2oat-very-large", dex2oat_large_app_threshold, NULL) > 0;
302 char dex2oat_large_app_threshold_arg[strlen("--very-large-app-threshold=") + kPropertyValueMax];
303 if (have_dex2oat_large_app_threshold) {
304 sprintf(dex2oat_large_app_threshold_arg,
305 "--very-large-app-threshold=%s",
306 dex2oat_large_app_threshold);
307 }
308
Andreas Gampe6a9cf722017-07-24 16:49:10 -0700309 // If the runtime was requested to use libartd.so, we'll run dex2oatd, otherwise dex2oat.
David Sehra3b5ab62017-10-25 14:27:29 -0700310 const char* dex2oat_bin = "/system/bin/dex2oat";
311 static const char* kDex2oatDebugPath = "/system/bin/dex2oatd";
Andreas Gampea73a0cb2017-11-02 18:14:42 -0700312 if (is_debug_runtime() || (background_job_compile && is_debuggable_build())) {
David Sehra3b5ab62017-10-25 14:27:29 -0700313 DCHECK(access(kDex2oatDebugPath, X_OK) == 0);
314 dex2oat_bin = kDex2oatDebugPath;
315 }
Jeff Sharkey90aff262016-12-12 14:28:24 -0700316
Andreas Gampe2a2d7ba2017-11-02 19:39:29 -0700317 bool generate_minidebug_info = kEnableMinidebugInfo &&
318 android::base::GetBoolProperty(kMinidebugInfoSystemProperty,
319 kMinidebugInfoSystemPropertyDefault);
320
Jeff Sharkey90aff262016-12-12 14:28:24 -0700321 static const char* RUNTIME_ARG = "--runtime-arg";
322
323 static const int MAX_INT_LEN = 12; // '-'+10dig+'\0' -OR- 0x+8dig
324
George Burgess IV36cebe772017-01-25 11:52:01 -0800325 // clang FORTIFY doesn't let us use strlen in constant array bounds, so we
326 // use arraysize instead.
327 char zip_fd_arg[arraysize("--zip-fd=") + MAX_INT_LEN];
328 char zip_location_arg[arraysize("--zip-location=") + PKG_PATH_MAX];
329 char input_vdex_fd_arg[arraysize("--input-vdex-fd=") + MAX_INT_LEN];
330 char output_vdex_fd_arg[arraysize("--output-vdex-fd=") + MAX_INT_LEN];
331 char oat_fd_arg[arraysize("--oat-fd=") + MAX_INT_LEN];
332 char oat_location_arg[arraysize("--oat-location=") + PKG_PATH_MAX];
333 char instruction_set_arg[arraysize("--instruction-set=") + MAX_INSTRUCTION_SET_LEN];
334 char instruction_set_variant_arg[arraysize("--instruction-set-variant=") + kPropertyValueMax];
335 char instruction_set_features_arg[arraysize("--instruction-set-features=") + kPropertyValueMax];
336 char dex2oat_Xms_arg[arraysize("-Xms") + kPropertyValueMax];
337 char dex2oat_Xmx_arg[arraysize("-Xmx") + kPropertyValueMax];
338 char dex2oat_compiler_filter_arg[arraysize("--compiler-filter=") + kPropertyValueMax];
Jeff Sharkey90aff262016-12-12 14:28:24 -0700339 bool have_dex2oat_swap_fd = false;
George Burgess IV36cebe772017-01-25 11:52:01 -0800340 char dex2oat_swap_fd[arraysize("--swap-fd=") + MAX_INT_LEN];
Jeff Sharkey90aff262016-12-12 14:28:24 -0700341 bool have_dex2oat_image_fd = false;
George Burgess IV36cebe772017-01-25 11:52:01 -0800342 char dex2oat_image_fd[arraysize("--app-image-fd=") + MAX_INT_LEN];
Calin Juravle52c45822017-07-13 22:50:21 -0700343 size_t class_loader_context_size = arraysize("--class-loader-context=") + PKG_PATH_MAX;
David Brazdil570d3982018-01-16 20:15:43 +0000344 char target_sdk_version_arg[arraysize("-Xtarget-sdk-version:") + MAX_INT_LEN];
Calin Juravle52c45822017-07-13 22:50:21 -0700345 char class_loader_context_arg[class_loader_context_size];
346 if (class_loader_context != nullptr) {
347 snprintf(class_loader_context_arg, class_loader_context_size, "--class-loader-context=%s",
348 class_loader_context);
349 }
Jeff Sharkey90aff262016-12-12 14:28:24 -0700350
351 sprintf(zip_fd_arg, "--zip-fd=%d", zip_fd);
Jeff Hao10b8a6e2017-04-05 17:11:39 -0700352 sprintf(zip_location_arg, "--zip-location=%s", relative_input_file_name);
Jeff Sharkey90aff262016-12-12 14:28:24 -0700353 sprintf(input_vdex_fd_arg, "--input-vdex-fd=%d", input_vdex_fd);
354 sprintf(output_vdex_fd_arg, "--output-vdex-fd=%d", output_vdex_fd);
355 sprintf(oat_fd_arg, "--oat-fd=%d", oat_fd);
356 sprintf(oat_location_arg, "--oat-location=%s", output_file_name);
357 sprintf(instruction_set_arg, "--instruction-set=%s", instruction_set);
358 sprintf(instruction_set_variant_arg, "--instruction-set-variant=%s", dex2oat_isa_variant);
359 sprintf(instruction_set_features_arg, "--instruction-set-features=%s", dex2oat_isa_features);
360 if (swap_fd >= 0) {
361 have_dex2oat_swap_fd = true;
362 sprintf(dex2oat_swap_fd, "--swap-fd=%d", swap_fd);
363 }
364 if (image_fd >= 0) {
365 have_dex2oat_image_fd = true;
366 sprintf(dex2oat_image_fd, "--app-image-fd=%d", image_fd);
367 }
368
369 if (have_dex2oat_Xms_flag) {
370 sprintf(dex2oat_Xms_arg, "-Xms%s", dex2oat_Xms_flag);
371 }
372 if (have_dex2oat_Xmx_flag) {
373 sprintf(dex2oat_Xmx_arg, "-Xmx%s", dex2oat_Xmx_flag);
374 }
David Brazdil570d3982018-01-16 20:15:43 +0000375 sprintf(target_sdk_version_arg, "-Xtarget-sdk-version:%d", target_sdk_version);
Jeff Sharkey90aff262016-12-12 14:28:24 -0700376
377 // Compute compiler filter.
378
Nicolas Geoffraybe6ecd62017-05-03 13:21:37 +0100379 bool have_dex2oat_compiler_filter_flag = false;
Jeff Sharkey90aff262016-12-12 14:28:24 -0700380 if (skip_compilation) {
Jeff Sharkeyc1149c92017-09-21 14:51:09 -0600381 strlcpy(dex2oat_compiler_filter_arg, "--compiler-filter=extract",
382 sizeof(dex2oat_compiler_filter_arg));
Jeff Sharkey90aff262016-12-12 14:28:24 -0700383 have_dex2oat_compiler_filter_flag = true;
384 have_dex2oat_relocation_skip_flag = true;
Nicolas Geoffraybe6ecd62017-05-03 13:21:37 +0100385 } else if (compiler_filter != nullptr) {
386 if (strlen(compiler_filter) + strlen("--compiler-filter=") <
Jeff Sharkey90aff262016-12-12 14:28:24 -0700387 arraysize(dex2oat_compiler_filter_arg)) {
Nicolas Geoffraybe6ecd62017-05-03 13:21:37 +0100388 sprintf(dex2oat_compiler_filter_arg, "--compiler-filter=%s", compiler_filter);
389 have_dex2oat_compiler_filter_flag = true;
390 } else {
391 ALOGW("Compiler filter name '%s' is too large (max characters is %zu)",
392 compiler_filter,
393 kPropertyValueMax);
394 }
395 }
396
397 if (!have_dex2oat_compiler_filter_flag) {
Jeff Sharkey90aff262016-12-12 14:28:24 -0700398 char dex2oat_compiler_filter_flag[kPropertyValueMax];
399 have_dex2oat_compiler_filter_flag = get_property("dalvik.vm.dex2oat-filter",
400 dex2oat_compiler_filter_flag, NULL) > 0;
401 if (have_dex2oat_compiler_filter_flag) {
402 sprintf(dex2oat_compiler_filter_arg,
403 "--compiler-filter=%s",
404 dex2oat_compiler_filter_flag);
405 }
406 }
407
408 // Check whether all apps should be compiled debuggable.
409 if (!debuggable) {
410 char prop_buf[kPropertyValueMax];
411 debuggable =
412 (get_property("dalvik.vm.always_debuggable", prop_buf, "0") > 0) &&
413 (prop_buf[0] == '1');
414 }
415 char profile_arg[strlen("--profile-file-fd=") + MAX_INT_LEN];
416 if (profile_fd != -1) {
417 sprintf(profile_arg, "--profile-file-fd=%d", profile_fd);
418 }
419
Jeff Hao10b8a6e2017-04-05 17:11:39 -0700420 // Get the directory of the apk to pass as a base classpath directory.
421 char base_dir[arraysize("--classpath-dir=") + PKG_PATH_MAX];
422 std::string apk_dir(input_file_name);
423 unsigned long dir_index = apk_dir.rfind('/');
424 bool has_base_dir = dir_index != std::string::npos;
425 if (has_base_dir) {
426 apk_dir = apk_dir.substr(0, dir_index);
427 sprintf(base_dir, "--classpath-dir=%s", apk_dir.c_str());
428 }
Jeff Sharkey90aff262016-12-12 14:28:24 -0700429
Calin Juravle62c5a372018-02-01 17:03:23 +0000430 std::string dex_metadata_fd_arg = "--dm-fd=" + std::to_string(dex_metadata_fd);
Jeff Hao10b8a6e2017-04-05 17:11:39 -0700431
Calin Juravle2efc4022018-02-13 18:31:32 -0800432 std::string compilation_reason_arg = compilation_reason == nullptr
433 ? ""
434 : std::string("--compilation-reason=") + compilation_reason;
435
Andreas Gampe6a9cf722017-07-24 16:49:10 -0700436 ALOGV("Running %s in=%s out=%s\n", dex2oat_bin, relative_input_file_name, output_file_name);
Jeff Sharkey90aff262016-12-12 14:28:24 -0700437
Mathieu Chartierb41ffcc2018-01-09 00:02:17 -0800438 // Disable cdex if update input vdex is true since this combination of options is not
439 // supported.
Mathieu Chartier1fb463e2018-01-09 15:16:10 -0800440 // Disable cdex for non-background compiles since we don't want to regress app install until
441 // there are enough benefits to justify the tradeoff.
442 const bool disable_cdex = !background_job_compile || (input_vdex_fd == output_vdex_fd);
Mathieu Chartierb41ffcc2018-01-09 00:02:17 -0800443
Jeff Sharkey90aff262016-12-12 14:28:24 -0700444 const char* argv[9 // program name, mandatory arguments and the final NULL
445 + (have_dex2oat_isa_variant ? 1 : 0)
446 + (have_dex2oat_isa_features ? 1 : 0)
447 + (have_dex2oat_Xms_flag ? 2 : 0)
448 + (have_dex2oat_Xmx_flag ? 2 : 0)
449 + (have_dex2oat_compiler_filter_flag ? 1 : 0)
450 + (have_dex2oat_threads_flag ? 1 : 0)
451 + (have_dex2oat_swap_fd ? 1 : 0)
452 + (have_dex2oat_image_fd ? 1 : 0)
453 + (have_dex2oat_relocation_skip_flag ? 2 : 0)
454 + (generate_debug_info ? 1 : 0)
455 + (debuggable ? 1 : 0)
456 + (have_app_image_format ? 1 : 0)
457 + dex2oat_flags_count
458 + (profile_fd == -1 ? 0 : 1)
Calin Juravle52c45822017-07-13 22:50:21 -0700459 + (class_loader_context != nullptr ? 1 : 0)
Jeff Hao10b8a6e2017-04-05 17:11:39 -0700460 + (has_base_dir ? 1 : 0)
Andreas Gampe2a2d7ba2017-11-02 19:39:29 -0700461 + (have_dex2oat_large_app_threshold ? 1 : 0)
Mathieu Chartierb41ffcc2018-01-09 00:02:17 -0800462 + (disable_cdex ? 1 : 0)
David Brazdil570d3982018-01-16 20:15:43 +0000463 + (generate_minidebug_info ? 1 : 0)
David Brazdil7fcbb812018-01-17 17:05:40 +0000464 + (target_sdk_version != 0 ? 2 : 0)
Calin Juravle62c5a372018-02-01 17:03:23 +0000465 + (enable_hidden_api_checks ? 2 : 0)
Calin Juravle2efc4022018-02-13 18:31:32 -0800466 + (dex_metadata_fd > -1 ? 1 : 0)
467 + (compilation_reason != nullptr ? 1 : 0)];
Jeff Sharkey90aff262016-12-12 14:28:24 -0700468 int i = 0;
Andreas Gampe6a9cf722017-07-24 16:49:10 -0700469 argv[i++] = dex2oat_bin;
Jeff Sharkey90aff262016-12-12 14:28:24 -0700470 argv[i++] = zip_fd_arg;
471 argv[i++] = zip_location_arg;
472 argv[i++] = input_vdex_fd_arg;
473 argv[i++] = output_vdex_fd_arg;
474 argv[i++] = oat_fd_arg;
475 argv[i++] = oat_location_arg;
476 argv[i++] = instruction_set_arg;
477 if (have_dex2oat_isa_variant) {
478 argv[i++] = instruction_set_variant_arg;
479 }
480 if (have_dex2oat_isa_features) {
481 argv[i++] = instruction_set_features_arg;
482 }
483 if (have_dex2oat_Xms_flag) {
484 argv[i++] = RUNTIME_ARG;
485 argv[i++] = dex2oat_Xms_arg;
486 }
487 if (have_dex2oat_Xmx_flag) {
488 argv[i++] = RUNTIME_ARG;
489 argv[i++] = dex2oat_Xmx_arg;
490 }
491 if (have_dex2oat_compiler_filter_flag) {
492 argv[i++] = dex2oat_compiler_filter_arg;
493 }
494 if (have_dex2oat_threads_flag) {
495 argv[i++] = dex2oat_threads_arg;
496 }
497 if (have_dex2oat_swap_fd) {
498 argv[i++] = dex2oat_swap_fd;
499 }
500 if (have_dex2oat_image_fd) {
501 argv[i++] = dex2oat_image_fd;
502 }
503 if (generate_debug_info) {
504 argv[i++] = "--generate-debug-info";
505 }
506 if (debuggable) {
507 argv[i++] = "--debuggable";
508 }
509 if (have_app_image_format) {
510 argv[i++] = image_format_arg;
511 }
512 if (have_dex2oat_large_app_threshold) {
513 argv[i++] = dex2oat_large_app_threshold_arg;
514 }
515 if (dex2oat_flags_count) {
516 i += split(dex2oat_flags, argv + i);
517 }
518 if (have_dex2oat_relocation_skip_flag) {
519 argv[i++] = RUNTIME_ARG;
520 argv[i++] = dex2oat_norelocation;
521 }
522 if (profile_fd != -1) {
523 argv[i++] = profile_arg;
524 }
Jeff Hao10b8a6e2017-04-05 17:11:39 -0700525 if (has_base_dir) {
526 argv[i++] = base_dir;
527 }
Calin Juravle52c45822017-07-13 22:50:21 -0700528 if (class_loader_context != nullptr) {
529 argv[i++] = class_loader_context_arg;
530 }
Andreas Gampe2a2d7ba2017-11-02 19:39:29 -0700531 if (generate_minidebug_info) {
532 argv[i++] = kMinidebugDex2oatFlag;
533 }
Mathieu Chartierb41ffcc2018-01-09 00:02:17 -0800534 if (disable_cdex) {
535 argv[i++] = kDisableCompactDexFlag;
536 }
David Brazdil570d3982018-01-16 20:15:43 +0000537 if (target_sdk_version != 0) {
538 argv[i++] = RUNTIME_ARG;
539 argv[i++] = target_sdk_version_arg;
540 }
David Brazdil52249162018-02-12 18:04:59 -0800541 if (enable_hidden_api_checks) {
David Brazdil7fcbb812018-01-17 17:05:40 +0000542 argv[i++] = RUNTIME_ARG;
David Brazdil52249162018-02-12 18:04:59 -0800543 argv[i++] = "-Xhidden-api-checks";
David Brazdil7fcbb812018-01-17 17:05:40 +0000544 }
Calin Juravle52c45822017-07-13 22:50:21 -0700545
Calin Juravle62c5a372018-02-01 17:03:23 +0000546 if (dex_metadata_fd > -1) {
547 argv[i++] = dex_metadata_fd_arg.c_str();
548 }
Calin Juravle2efc4022018-02-13 18:31:32 -0800549
550 if(compilation_reason != nullptr) {
551 argv[i++] = compilation_reason_arg.c_str();
552 }
Jeff Sharkey90aff262016-12-12 14:28:24 -0700553 // Do not add after dex2oat_flags, they should override others for debugging.
554 argv[i] = NULL;
555
Andreas Gampe6a9cf722017-07-24 16:49:10 -0700556 execv(dex2oat_bin, (char * const *)argv);
Andreas Gampefa2dadd2018-02-28 19:52:47 -0800557 PLOG(ERROR) << "execv(" << dex2oat_bin << ") failed";
558 exit(DexoptReturnCodes::kDex2oatExec);
Jeff Sharkey90aff262016-12-12 14:28:24 -0700559}
560
561/*
562 * Whether dexopt should use a swap file when compiling an APK.
563 *
564 * If kAlwaysProvideSwapFile, do this on all devices (dex2oat will make a more informed decision
565 * itself, anyways).
566 *
567 * Otherwise, read "dalvik.vm.dex2oat-swap". If the property exists, return whether it is "true".
568 *
569 * Otherwise, return true if this is a low-mem device.
570 *
571 * Otherwise, return default value.
572 */
573static bool kAlwaysProvideSwapFile = false;
574static bool kDefaultProvideSwapFile = true;
575
576static bool ShouldUseSwapFileForDexopt() {
577 if (kAlwaysProvideSwapFile) {
578 return true;
579 }
580
581 // Check the "override" property. If it exists, return value == "true".
582 char dex2oat_prop_buf[kPropertyValueMax];
583 if (get_property("dalvik.vm.dex2oat-swap", dex2oat_prop_buf, "") > 0) {
584 if (strcmp(dex2oat_prop_buf, "true") == 0) {
585 return true;
586 } else {
587 return false;
588 }
589 }
590
591 // Shortcut for default value. This is an implementation optimization for the process sketched
592 // above. If the default value is true, we can avoid to check whether this is a low-mem device,
593 // as low-mem is never returning false. The compiler will optimize this away if it can.
594 if (kDefaultProvideSwapFile) {
595 return true;
596 }
597
598 bool is_low_mem = property_get_bool("ro.config.low_ram", false);
599 if (is_low_mem) {
600 return true;
601 }
602
603 // Default value must be false here.
604 return kDefaultProvideSwapFile;
605}
606
Richard Uhler76cc0272016-12-08 10:46:35 +0000607static void SetDex2OatScheduling(bool set_to_bg) {
Jeff Sharkey90aff262016-12-12 14:28:24 -0700608 if (set_to_bg) {
609 if (set_sched_policy(0, SP_BACKGROUND) < 0) {
Andreas Gampefa2dadd2018-02-28 19:52:47 -0800610 PLOG(ERROR) << "set_sched_policy failed";
611 exit(DexoptReturnCodes::kSetSchedPolicy);
Jeff Sharkey90aff262016-12-12 14:28:24 -0700612 }
613 if (setpriority(PRIO_PROCESS, 0, ANDROID_PRIORITY_BACKGROUND) < 0) {
Andreas Gampefa2dadd2018-02-28 19:52:47 -0800614 PLOG(ERROR) << "setpriority failed";
615 exit(DexoptReturnCodes::kSetPriority);
Jeff Sharkey90aff262016-12-12 14:28:24 -0700616 }
617 }
618}
619
Calin Juravle29591732017-11-20 17:46:19 -0800620static unique_fd create_profile(uid_t uid, const std::string& profile, int32_t flags) {
621 unique_fd fd(TEMP_FAILURE_RETRY(open(profile.c_str(), flags, 0600)));
Calin Juravle1a0af3b2017-03-09 14:33:33 -0800622 if (fd.get() < 0) {
Calin Juravle29591732017-11-20 17:46:19 -0800623 if (errno != EEXIST) {
Calin Juravle114f0812017-03-08 19:05:07 -0800624 PLOG(ERROR) << "Failed to create profile " << profile;
Calin Juravle29591732017-11-20 17:46:19 -0800625 return invalid_unique_fd();
Calin Juravle114f0812017-03-08 19:05:07 -0800626 }
Jeff Sharkey90aff262016-12-12 14:28:24 -0700627 }
Calin Juravle114f0812017-03-08 19:05:07 -0800628 // Profiles should belong to the app; make sure of that by giving ownership to
629 // the app uid. If we cannot do that, there's no point in returning the fd
630 // since dex2oat/profman will fail with SElinux denials.
631 if (fchown(fd.get(), uid, uid) < 0) {
632 PLOG(ERROR) << "Could not chwon profile " << profile;
Calin Juravle29591732017-11-20 17:46:19 -0800633 return invalid_unique_fd();
Calin Juravle114f0812017-03-08 19:05:07 -0800634 }
Calin Juravle29591732017-11-20 17:46:19 -0800635 return fd;
Calin Juravle114f0812017-03-08 19:05:07 -0800636}
637
Calin Juravle29591732017-11-20 17:46:19 -0800638static unique_fd open_profile(uid_t uid, const std::string& profile, int32_t flags) {
Calin Juravle114f0812017-03-08 19:05:07 -0800639 // Do not follow symlinks when opening a profile:
640 // - primary profiles should not contain symlinks in their paths
641 // - secondary dex paths should have been already resolved and validated
642 flags |= O_NOFOLLOW;
643
Calin Juravle29591732017-11-20 17:46:19 -0800644 // Check if we need to create the profile
645 // Reference profiles and snapshots are created on the fly; so they might not exist beforehand.
646 unique_fd fd;
647 if ((flags & O_CREAT) != 0) {
648 fd = create_profile(uid, profile, flags);
649 } else {
650 fd.reset(TEMP_FAILURE_RETRY(open(profile.c_str(), flags)));
651 }
652
Calin Juravle114f0812017-03-08 19:05:07 -0800653 if (fd.get() < 0) {
654 if (errno != ENOENT) {
655 // Profiles might be missing for various reasons. For example, in a
656 // multi-user environment, the profile directory for one user can be created
657 // after we start a merge. In this case the current profile for that user
658 // will not be found.
659 // Also, the secondary dex profiles might be deleted by the app at any time,
660 // so we can't we need to prepare if they are missing.
661 PLOG(ERROR) << "Failed to open profile " << profile;
662 }
663 return invalid_unique_fd();
664 }
665
Jeff Sharkey90aff262016-12-12 14:28:24 -0700666 return fd;
667}
668
Calin Juravle824a64d2018-01-18 20:23:17 -0800669static unique_fd open_current_profile(uid_t uid, userid_t user, const std::string& package_name,
670 const std::string& location, bool is_secondary_dex) {
671 std::string profile = create_current_profile_path(user, package_name, location,
672 is_secondary_dex);
Calin Juravle29591732017-11-20 17:46:19 -0800673 return open_profile(uid, profile, O_RDONLY);
Calin Juravle114f0812017-03-08 19:05:07 -0800674}
675
Calin Juravle824a64d2018-01-18 20:23:17 -0800676static unique_fd open_reference_profile(uid_t uid, const std::string& package_name,
677 const std::string& location, bool read_write, bool is_secondary_dex) {
678 std::string profile = create_reference_profile_path(package_name, location, is_secondary_dex);
Calin Juravle29591732017-11-20 17:46:19 -0800679 return open_profile(uid, profile, read_write ? (O_CREAT | O_RDWR) : O_RDONLY);
680}
681
682static unique_fd open_spnashot_profile(uid_t uid, const std::string& package_name,
Calin Juravle824a64d2018-01-18 20:23:17 -0800683 const std::string& location) {
684 std::string profile = create_snapshot_profile_path(package_name, location);
Calin Juravle29591732017-11-20 17:46:19 -0800685 return open_profile(uid, profile, O_CREAT | O_RDWR | O_TRUNC);
Calin Juravle114f0812017-03-08 19:05:07 -0800686}
687
Calin Juravle824a64d2018-01-18 20:23:17 -0800688static void open_profile_files(uid_t uid, const std::string& package_name,
689 const std::string& location, bool is_secondary_dex,
Calin Juravle1a0af3b2017-03-09 14:33:33 -0800690 /*out*/ std::vector<unique_fd>* profiles_fd, /*out*/ unique_fd* reference_profile_fd) {
Jeff Sharkey90aff262016-12-12 14:28:24 -0700691 // Open the reference profile in read-write mode as profman might need to save the merge.
Calin Juravle824a64d2018-01-18 20:23:17 -0800692 *reference_profile_fd = open_reference_profile(uid, package_name, location,
693 /*read_write*/ true, is_secondary_dex);
Jeff Sharkey90aff262016-12-12 14:28:24 -0700694
Calin Juravle114f0812017-03-08 19:05:07 -0800695 // For secondary dex files, we don't really need the user but we use it for sanity checks.
696 // Note: the user owning the dex file should be the current user.
697 std::vector<userid_t> users;
698 if (is_secondary_dex){
699 users.push_back(multiuser_get_user_id(uid));
700 } else {
701 users = get_known_users(/*volume_uuid*/ nullptr);
702 }
Jeff Sharkey90aff262016-12-12 14:28:24 -0700703 for (auto user : users) {
Calin Juravle824a64d2018-01-18 20:23:17 -0800704 unique_fd profile_fd = open_current_profile(uid, user, package_name, location,
705 is_secondary_dex);
Jeff Sharkey90aff262016-12-12 14:28:24 -0700706 // Add to the lists only if both fds are valid.
Calin Juravle1a0af3b2017-03-09 14:33:33 -0800707 if (profile_fd.get() >= 0) {
708 profiles_fd->push_back(std::move(profile_fd));
Jeff Sharkey90aff262016-12-12 14:28:24 -0700709 }
710 }
711}
712
713static void drop_capabilities(uid_t uid) {
714 if (setgid(uid) != 0) {
Andreas Gampefa2dadd2018-02-28 19:52:47 -0800715 PLOG(ERROR) << "setgid(" << uid << ") failed in installd during dexopt";
716 exit(DexoptReturnCodes::kSetGid);
Jeff Sharkey90aff262016-12-12 14:28:24 -0700717 }
718 if (setuid(uid) != 0) {
Andreas Gampefa2dadd2018-02-28 19:52:47 -0800719 PLOG(ERROR) << "setuid(" << uid << ") failed in installd during dexopt";
720 exit(DexoptReturnCodes::kSetUid);
Jeff Sharkey90aff262016-12-12 14:28:24 -0700721 }
722 // drop capabilities
723 struct __user_cap_header_struct capheader;
724 struct __user_cap_data_struct capdata[2];
725 memset(&capheader, 0, sizeof(capheader));
726 memset(&capdata, 0, sizeof(capdata));
727 capheader.version = _LINUX_CAPABILITY_VERSION_3;
728 if (capset(&capheader, &capdata[0]) < 0) {
Andreas Gampefa2dadd2018-02-28 19:52:47 -0800729 PLOG(ERROR) << "capset failed";
730 exit(DexoptReturnCodes::kCapSet);
Jeff Sharkey90aff262016-12-12 14:28:24 -0700731 }
732}
733
734static constexpr int PROFMAN_BIN_RETURN_CODE_COMPILE = 0;
735static constexpr int PROFMAN_BIN_RETURN_CODE_SKIP_COMPILATION = 1;
736static constexpr int PROFMAN_BIN_RETURN_CODE_BAD_PROFILES = 2;
737static constexpr int PROFMAN_BIN_RETURN_CODE_ERROR_IO = 3;
738static constexpr int PROFMAN_BIN_RETURN_CODE_ERROR_LOCKING = 4;
739
Andreas Gampefa2dadd2018-02-28 19:52:47 -0800740[[ noreturn ]]
Calin Juravlef63d4792018-01-30 17:43:34 +0000741static void run_profman(const std::vector<unique_fd>& profile_fds,
742 const unique_fd& reference_profile_fd,
743 const std::vector<unique_fd>* apk_fds,
744 bool copy_and_update) {
Andreas Gampe6a9cf722017-07-24 16:49:10 -0700745 const char* profman_bin = is_debug_runtime() ? "/system/bin/profmand" : "/system/bin/profman";
Jeff Sharkey90aff262016-12-12 14:28:24 -0700746
Calin Juravlef63d4792018-01-30 17:43:34 +0000747 if (copy_and_update) {
748 CHECK_EQ(1u, profile_fds.size());
749 CHECK(apk_fds != nullptr);
750 CHECK_EQ(1u, apk_fds->size());
751 }
752 std::vector<std::string> profile_args(profile_fds.size());
753 for (size_t k = 0; k < profile_fds.size(); k++) {
754 profile_args[k] = "--profile-file-fd=" + std::to_string(profile_fds[k].get());
Jeff Sharkey90aff262016-12-12 14:28:24 -0700755 }
Calin Juravle0d0a4922018-01-23 19:54:11 -0800756 std::string reference_profile_arg = "--reference-profile-file-fd="
757 + std::to_string(reference_profile_fd.get());
758
759 std::vector<std::string> apk_args;
760 if (apk_fds != nullptr) {
761 for (size_t k = 0; k < apk_fds->size(); k++) {
762 apk_args.push_back("--apk-fd=" + std::to_string((*apk_fds)[k].get()));
763 }
764 }
Jeff Sharkey90aff262016-12-12 14:28:24 -0700765
766 // program name, reference profile fd, the final NULL and the profile fds
Calin Juravlef63d4792018-01-30 17:43:34 +0000767 const char* argv[3 + profile_args.size() + apk_args.size() + (copy_and_update ? 1 : 0)];
Jeff Sharkey90aff262016-12-12 14:28:24 -0700768 int i = 0;
Andreas Gampe6a9cf722017-07-24 16:49:10 -0700769 argv[i++] = profman_bin;
Calin Juravle0d0a4922018-01-23 19:54:11 -0800770 argv[i++] = reference_profile_arg.c_str();
Jeff Sharkey90aff262016-12-12 14:28:24 -0700771 for (size_t k = 0; k < profile_args.size(); k++) {
772 argv[i++] = profile_args[k].c_str();
773 }
Calin Juravle0d0a4922018-01-23 19:54:11 -0800774 for (size_t k = 0; k < apk_args.size(); k++) {
775 argv[i++] = apk_args[k].c_str();
776 }
Calin Juravlef63d4792018-01-30 17:43:34 +0000777 if (copy_and_update) {
778 argv[i++] = "--copy-and-update-profile-key";
779 }
Jeff Sharkey90aff262016-12-12 14:28:24 -0700780 // Do not add after dex2oat_flags, they should override others for debugging.
781 argv[i] = NULL;
782
Andreas Gampe6a9cf722017-07-24 16:49:10 -0700783 execv(profman_bin, (char * const *)argv);
Andreas Gampefa2dadd2018-02-28 19:52:47 -0800784 PLOG(ERROR) << "execv(" << profman_bin << ") failed";
785 exit(DexoptReturnCodes::kProfmanExec); /* only get here on exec failure */
Jeff Sharkey90aff262016-12-12 14:28:24 -0700786}
787
Andreas Gampefa2dadd2018-02-28 19:52:47 -0800788[[ noreturn ]]
Calin Juravlef63d4792018-01-30 17:43:34 +0000789static void run_profman_merge(const std::vector<unique_fd>& profiles_fd,
790 const unique_fd& reference_profile_fd,
791 const std::vector<unique_fd>* apk_fds = nullptr) {
792 run_profman(profiles_fd, reference_profile_fd, apk_fds, /*copy_and_update*/false);
793}
794
Andreas Gampefa2dadd2018-02-28 19:52:47 -0800795[[ noreturn ]]
Calin Juravlef63d4792018-01-30 17:43:34 +0000796static void run_profman_copy_and_update(unique_fd&& profile_fd,
797 unique_fd&& reference_profile_fd,
798 unique_fd&& apk_fd) {
799 std::vector<unique_fd> profiles_fd;
800 profiles_fd.push_back(std::move(profile_fd));
801 std::vector<unique_fd> apk_fds;
802 apk_fds.push_back(std::move(apk_fd));
803
804 run_profman(profiles_fd, reference_profile_fd, &apk_fds, /*copy_and_update*/true);
805}
806
Jeff Sharkey90aff262016-12-12 14:28:24 -0700807// Decides if profile guided compilation is needed or not based on existing profiles.
Calin Juravle114f0812017-03-08 19:05:07 -0800808// The location is the package name for primary apks or the dex path for secondary dex files.
809// Returns true if there is enough information in the current profiles that makes it
810// worth to recompile the given location.
Jeff Sharkey90aff262016-12-12 14:28:24 -0700811// If the return value is true all the current profiles would have been merged into
812// the reference profiles accessible with open_reference_profile().
Calin Juravle824a64d2018-01-18 20:23:17 -0800813static bool analyze_profiles(uid_t uid, const std::string& package_name,
814 const std::string& location, bool is_secondary_dex) {
Calin Juravle1a0af3b2017-03-09 14:33:33 -0800815 std::vector<unique_fd> profiles_fd;
816 unique_fd reference_profile_fd;
Calin Juravle824a64d2018-01-18 20:23:17 -0800817 open_profile_files(uid, package_name, location, is_secondary_dex,
818 &profiles_fd, &reference_profile_fd);
Calin Juravle1a0af3b2017-03-09 14:33:33 -0800819 if (profiles_fd.empty() || (reference_profile_fd.get() < 0)) {
Jeff Sharkey90aff262016-12-12 14:28:24 -0700820 // Skip profile guided compilation because no profiles were found.
821 // Or if the reference profile info couldn't be opened.
Jeff Sharkey90aff262016-12-12 14:28:24 -0700822 return false;
823 }
824
Jeff Sharkey90aff262016-12-12 14:28:24 -0700825 pid_t pid = fork();
826 if (pid == 0) {
827 /* child -- drop privileges before continuing */
828 drop_capabilities(uid);
829 run_profman_merge(profiles_fd, reference_profile_fd);
Jeff Sharkey90aff262016-12-12 14:28:24 -0700830 }
831 /* parent */
832 int return_code = wait_child(pid);
833 bool need_to_compile = false;
834 bool should_clear_current_profiles = false;
835 bool should_clear_reference_profile = false;
836 if (!WIFEXITED(return_code)) {
Calin Juravle114f0812017-03-08 19:05:07 -0800837 LOG(WARNING) << "profman failed for location " << location << ": " << return_code;
Jeff Sharkey90aff262016-12-12 14:28:24 -0700838 } else {
839 return_code = WEXITSTATUS(return_code);
840 switch (return_code) {
841 case PROFMAN_BIN_RETURN_CODE_COMPILE:
842 need_to_compile = true;
843 should_clear_current_profiles = true;
844 should_clear_reference_profile = false;
845 break;
846 case PROFMAN_BIN_RETURN_CODE_SKIP_COMPILATION:
847 need_to_compile = false;
848 should_clear_current_profiles = false;
849 should_clear_reference_profile = false;
850 break;
851 case PROFMAN_BIN_RETURN_CODE_BAD_PROFILES:
Calin Juravle114f0812017-03-08 19:05:07 -0800852 LOG(WARNING) << "Bad profiles for location " << location;
Jeff Sharkey90aff262016-12-12 14:28:24 -0700853 need_to_compile = false;
854 should_clear_current_profiles = true;
855 should_clear_reference_profile = true;
856 break;
857 case PROFMAN_BIN_RETURN_CODE_ERROR_IO: // fall-through
858 case PROFMAN_BIN_RETURN_CODE_ERROR_LOCKING:
859 // Temporary IO problem (e.g. locking). Ignore but log a warning.
Calin Juravle114f0812017-03-08 19:05:07 -0800860 LOG(WARNING) << "IO error while reading profiles for location " << location;
Jeff Sharkey90aff262016-12-12 14:28:24 -0700861 need_to_compile = false;
862 should_clear_current_profiles = false;
863 should_clear_reference_profile = false;
864 break;
865 default:
866 // Unknown return code or error. Unlink profiles.
Calin Juravle114f0812017-03-08 19:05:07 -0800867 LOG(WARNING) << "Unknown error code while processing profiles for location "
868 << location << ": " << return_code;
Jeff Sharkey90aff262016-12-12 14:28:24 -0700869 need_to_compile = false;
870 should_clear_current_profiles = true;
871 should_clear_reference_profile = true;
872 break;
873 }
874 }
Calin Juravle1a0af3b2017-03-09 14:33:33 -0800875
Jeff Sharkey90aff262016-12-12 14:28:24 -0700876 if (should_clear_current_profiles) {
Calin Juravle114f0812017-03-08 19:05:07 -0800877 if (is_secondary_dex) {
878 // For secondary dex files, the owning user is the current user.
Calin Juravle824a64d2018-01-18 20:23:17 -0800879 clear_current_profile(package_name, location, multiuser_get_user_id(uid),
880 is_secondary_dex);
Calin Juravle114f0812017-03-08 19:05:07 -0800881 } else {
Calin Juravle824a64d2018-01-18 20:23:17 -0800882 clear_primary_current_profiles(package_name, location);
Calin Juravle114f0812017-03-08 19:05:07 -0800883 }
Jeff Sharkey90aff262016-12-12 14:28:24 -0700884 }
885 if (should_clear_reference_profile) {
Calin Juravle824a64d2018-01-18 20:23:17 -0800886 clear_reference_profile(package_name, location, is_secondary_dex);
Jeff Sharkey90aff262016-12-12 14:28:24 -0700887 }
888 return need_to_compile;
889}
890
Calin Juravle114f0812017-03-08 19:05:07 -0800891// Decides if profile guided compilation is needed or not based on existing profiles.
892// The analysis is done for the primary apks of the given package.
893// Returns true if there is enough information in the current profiles that makes it
894// worth to recompile the package.
895// If the return value is true all the current profiles would have been merged into
896// the reference profiles accessible with open_reference_profile().
Calin Juravle824a64d2018-01-18 20:23:17 -0800897bool analyze_primary_profiles(uid_t uid, const std::string& package_name,
898 const std::string& profile_name) {
899 return analyze_profiles(uid, package_name, profile_name, /*is_secondary_dex*/false);
Calin Juravle114f0812017-03-08 19:05:07 -0800900}
901
Andreas Gampefa2dadd2018-02-28 19:52:47 -0800902[[ noreturn ]]
Calin Juravle1a0af3b2017-03-09 14:33:33 -0800903static void run_profman_dump(const std::vector<unique_fd>& profile_fds,
904 const unique_fd& reference_profile_fd,
Jeff Sharkey90aff262016-12-12 14:28:24 -0700905 const std::vector<std::string>& dex_locations,
Calin Juravle1a0af3b2017-03-09 14:33:33 -0800906 const std::vector<unique_fd>& apk_fds,
907 const unique_fd& output_fd) {
Jeff Sharkey90aff262016-12-12 14:28:24 -0700908 std::vector<std::string> profman_args;
909 static const char* PROFMAN_BIN = "/system/bin/profman";
910 profman_args.push_back(PROFMAN_BIN);
911 profman_args.push_back("--dump-only");
Calin Juravle1a0af3b2017-03-09 14:33:33 -0800912 profman_args.push_back(StringPrintf("--dump-output-to-fd=%d", output_fd.get()));
Jeff Sharkey90aff262016-12-12 14:28:24 -0700913 if (reference_profile_fd != -1) {
914 profman_args.push_back(StringPrintf("--reference-profile-file-fd=%d",
Calin Juravle1a0af3b2017-03-09 14:33:33 -0800915 reference_profile_fd.get()));
Jeff Sharkey90aff262016-12-12 14:28:24 -0700916 }
Calin Juravle1a0af3b2017-03-09 14:33:33 -0800917 for (size_t i = 0; i < profile_fds.size(); i++) {
918 profman_args.push_back(StringPrintf("--profile-file-fd=%d", profile_fds[i].get()));
Jeff Sharkey90aff262016-12-12 14:28:24 -0700919 }
920 for (const std::string& dex_location : dex_locations) {
921 profman_args.push_back(StringPrintf("--dex-location=%s", dex_location.c_str()));
922 }
Calin Juravle1a0af3b2017-03-09 14:33:33 -0800923 for (size_t i = 0; i < apk_fds.size(); i++) {
924 profman_args.push_back(StringPrintf("--apk-fd=%d", apk_fds[i].get()));
Jeff Sharkey90aff262016-12-12 14:28:24 -0700925 }
926 const char **argv = new const char*[profman_args.size() + 1];
927 size_t i = 0;
928 for (const std::string& profman_arg : profman_args) {
929 argv[i++] = profman_arg.c_str();
930 }
931 argv[i] = NULL;
932
933 execv(PROFMAN_BIN, (char * const *)argv);
Andreas Gampefa2dadd2018-02-28 19:52:47 -0800934 PLOG(ERROR) << "execv(" << PROFMAN_BIN << ") failed";
935 exit(DexoptReturnCodes::kProfmanExec); /* only get here on exec failure */
Jeff Sharkey90aff262016-12-12 14:28:24 -0700936}
937
Calin Juravle408cd4a2018-01-20 23:34:18 -0800938bool dump_profiles(int32_t uid, const std::string& pkgname, const std::string& profile_name,
939 const std::string& code_path) {
Calin Juravle1a0af3b2017-03-09 14:33:33 -0800940 std::vector<unique_fd> profile_fds;
941 unique_fd reference_profile_fd;
Calin Juravle408cd4a2018-01-20 23:34:18 -0800942 std::string out_file_name = StringPrintf("/data/misc/profman/%s-%s.txt",
943 pkgname.c_str(), profile_name.c_str());
Jeff Sharkey90aff262016-12-12 14:28:24 -0700944
Calin Juravle408cd4a2018-01-20 23:34:18 -0800945 open_profile_files(uid, pkgname, profile_name, /*is_secondary_dex*/false,
Calin Juravle114f0812017-03-08 19:05:07 -0800946 &profile_fds, &reference_profile_fd);
Jeff Sharkey90aff262016-12-12 14:28:24 -0700947
Calin Juravle1a0af3b2017-03-09 14:33:33 -0800948 const bool has_reference_profile = (reference_profile_fd.get() != -1);
Jeff Sharkey90aff262016-12-12 14:28:24 -0700949 const bool has_profiles = !profile_fds.empty();
950
951 if (!has_reference_profile && !has_profiles) {
Calin Juravle76268c52017-03-09 13:19:42 -0800952 LOG(ERROR) << "profman dump: no profiles to dump for " << pkgname;
Jeff Sharkey90aff262016-12-12 14:28:24 -0700953 return false;
954 }
955
Calin Juravle114f0812017-03-08 19:05:07 -0800956 unique_fd output_fd(open(out_file_name.c_str(),
957 O_WRONLY | O_CREAT | O_TRUNC | O_NOFOLLOW, 0644));
Jeff Sharkey90aff262016-12-12 14:28:24 -0700958 if (fchmod(output_fd, S_IRUSR|S_IWUSR|S_IRGRP|S_IROTH) < 0) {
Calin Juravle408cd4a2018-01-20 23:34:18 -0800959 LOG(ERROR) << "installd cannot chmod file for dump_profile" << out_file_name;
Jeff Sharkey90aff262016-12-12 14:28:24 -0700960 return false;
961 }
Calin Juravle408cd4a2018-01-20 23:34:18 -0800962
Jeff Sharkey90aff262016-12-12 14:28:24 -0700963 std::vector<std::string> dex_locations;
Calin Juravle1a0af3b2017-03-09 14:33:33 -0800964 std::vector<unique_fd> apk_fds;
Calin Juravle408cd4a2018-01-20 23:34:18 -0800965 unique_fd apk_fd(open(code_path.c_str(), O_RDONLY | O_NOFOLLOW));
966 if (apk_fd == -1) {
967 PLOG(ERROR) << "installd cannot open " << code_path.c_str();
968 return false;
Jeff Sharkey90aff262016-12-12 14:28:24 -0700969 }
Calin Juravle408cd4a2018-01-20 23:34:18 -0800970 dex_locations.push_back(get_location_from_path(code_path.c_str()));
971 apk_fds.push_back(std::move(apk_fd));
972
Jeff Sharkey90aff262016-12-12 14:28:24 -0700973
974 pid_t pid = fork();
975 if (pid == 0) {
976 /* child -- drop privileges before continuing */
977 drop_capabilities(uid);
978 run_profman_dump(profile_fds, reference_profile_fd, dex_locations,
979 apk_fds, output_fd);
Jeff Sharkey90aff262016-12-12 14:28:24 -0700980 }
981 /* parent */
Jeff Sharkey90aff262016-12-12 14:28:24 -0700982 int return_code = wait_child(pid);
983 if (!WIFEXITED(return_code)) {
984 LOG(WARNING) << "profman failed for package " << pkgname << ": "
985 << return_code;
986 return false;
987 }
988 return true;
989}
990
Mathieu Chartierf966f2a2017-05-10 12:48:37 -0700991bool copy_system_profile(const std::string& system_profile,
Calin Juravle824a64d2018-01-18 20:23:17 -0800992 uid_t packageUid, const std::string& package_name, const std::string& profile_name) {
Mathieu Chartierf966f2a2017-05-10 12:48:37 -0700993 unique_fd in_fd(open(system_profile.c_str(), O_RDONLY | O_NOFOLLOW | O_CLOEXEC));
994 unique_fd out_fd(open_reference_profile(packageUid,
Calin Juravle824a64d2018-01-18 20:23:17 -0800995 package_name,
996 profile_name,
Mathieu Chartierf966f2a2017-05-10 12:48:37 -0700997 /*read_write*/ true,
998 /*secondary*/ false));
999 if (in_fd.get() < 0) {
1000 PLOG(WARNING) << "Could not open profile " << system_profile;
1001 return false;
1002 }
1003 if (out_fd.get() < 0) {
Calin Juravle824a64d2018-01-18 20:23:17 -08001004 PLOG(WARNING) << "Could not open profile " << package_name;
Mathieu Chartierf966f2a2017-05-10 12:48:37 -07001005 return false;
1006 }
1007
Mathieu Chartier78f71fe2017-06-14 13:02:26 -07001008 // As a security measure we want to write the profile information with the reduced capabilities
1009 // of the package user id. So we fork and drop capabilities in the child.
Mathieu Chartierf966f2a2017-05-10 12:48:37 -07001010 pid_t pid = fork();
1011 if (pid == 0) {
1012 /* child -- drop privileges before continuing */
1013 drop_capabilities(packageUid);
1014
1015 if (flock(out_fd.get(), LOCK_EX | LOCK_NB) != 0) {
1016 if (errno != EWOULDBLOCK) {
Calin Juravle824a64d2018-01-18 20:23:17 -08001017 PLOG(WARNING) << "Error locking profile " << package_name;
Mathieu Chartierf966f2a2017-05-10 12:48:37 -07001018 }
1019 // This implies that the app owning this profile is running
1020 // (and has acquired the lock).
1021 //
1022 // The app never acquires the lock for the reference profiles of primary apks.
1023 // Only dex2oat from installd will do that. Since installd is single threaded
1024 // we should not see this case. Nevertheless be prepared for it.
Calin Juravle824a64d2018-01-18 20:23:17 -08001025 PLOG(WARNING) << "Failed to flock " << package_name;
Mathieu Chartierf966f2a2017-05-10 12:48:37 -07001026 return false;
1027 }
1028
1029 bool truncated = ftruncate(out_fd.get(), 0) == 0;
1030 if (!truncated) {
Calin Juravle824a64d2018-01-18 20:23:17 -08001031 PLOG(WARNING) << "Could not truncate " << package_name;
Mathieu Chartierf966f2a2017-05-10 12:48:37 -07001032 }
1033
1034 // Copy over data.
1035 static constexpr size_t kBufferSize = 4 * 1024;
1036 char buffer[kBufferSize];
1037 while (true) {
1038 ssize_t bytes = read(in_fd.get(), buffer, kBufferSize);
1039 if (bytes == 0) {
1040 break;
1041 }
1042 write(out_fd.get(), buffer, bytes);
1043 }
1044 if (flock(out_fd.get(), LOCK_UN) != 0) {
Calin Juravle824a64d2018-01-18 20:23:17 -08001045 PLOG(WARNING) << "Error unlocking profile " << package_name;
Mathieu Chartierf966f2a2017-05-10 12:48:37 -07001046 }
Mathieu Chartier78f71fe2017-06-14 13:02:26 -07001047 // Use _exit since we don't want to run the global destructors in the child.
1048 // b/62597429
1049 _exit(0);
Mathieu Chartierf966f2a2017-05-10 12:48:37 -07001050 }
1051 /* parent */
1052 int return_code = wait_child(pid);
1053 return return_code == 0;
1054}
1055
Jeff Sharkey90aff262016-12-12 14:28:24 -07001056static std::string replace_file_extension(const std::string& oat_path, const std::string& new_ext) {
1057 // A standard dalvik-cache entry. Replace ".dex" with `new_ext`.
1058 if (EndsWith(oat_path, ".dex")) {
1059 std::string new_path = oat_path;
1060 new_path.replace(new_path.length() - strlen(".dex"), strlen(".dex"), new_ext);
Elliott Hughes969e4f82017-12-20 12:34:09 -08001061 CHECK(EndsWith(new_path, new_ext));
Jeff Sharkey90aff262016-12-12 14:28:24 -07001062 return new_path;
1063 }
1064
1065 // An odex entry. Not that this may not be an extension, e.g., in the OTA
1066 // case (where the base name will have an extension for the B artifact).
1067 size_t odex_pos = oat_path.rfind(".odex");
1068 if (odex_pos != std::string::npos) {
1069 std::string new_path = oat_path;
1070 new_path.replace(odex_pos, strlen(".odex"), new_ext);
1071 CHECK_NE(new_path.find(new_ext), std::string::npos);
1072 return new_path;
1073 }
1074
1075 // Don't know how to handle this.
1076 return "";
1077}
1078
1079// Translate the given oat path to an art (app image) path. An empty string
1080// denotes an error.
1081static std::string create_image_filename(const std::string& oat_path) {
1082 return replace_file_extension(oat_path, ".art");
1083}
1084
1085// Translate the given oat path to a vdex path. An empty string denotes an error.
1086static std::string create_vdex_filename(const std::string& oat_path) {
1087 return replace_file_extension(oat_path, ".vdex");
1088}
1089
Jeff Sharkey90aff262016-12-12 14:28:24 -07001090static int open_output_file(const char* file_name, bool recreate, int permissions) {
1091 int flags = O_RDWR | O_CREAT;
1092 if (recreate) {
1093 if (unlink(file_name) < 0) {
1094 if (errno != ENOENT) {
1095 PLOG(ERROR) << "open_output_file: Couldn't unlink " << file_name;
1096 }
1097 }
1098 flags |= O_EXCL;
1099 }
1100 return open(file_name, flags, permissions);
1101}
1102
Calin Juravle2289c0a2017-02-15 12:44:14 -08001103static bool set_permissions_and_ownership(
1104 int fd, bool is_public, int uid, const char* path, bool is_secondary_dex) {
1105 // Primary apks are owned by the system. Secondary dex files are owned by the app.
1106 int owning_uid = is_secondary_dex ? uid : AID_SYSTEM;
Jeff Sharkey90aff262016-12-12 14:28:24 -07001107 if (fchmod(fd,
1108 S_IRUSR|S_IWUSR|S_IRGRP |
1109 (is_public ? S_IROTH : 0)) < 0) {
1110 ALOGE("installd cannot chmod '%s' during dexopt\n", path);
1111 return false;
Calin Juravle2289c0a2017-02-15 12:44:14 -08001112 } else if (fchown(fd, owning_uid, uid) < 0) {
Jeff Sharkey90aff262016-12-12 14:28:24 -07001113 ALOGE("installd cannot chown '%s' during dexopt\n", path);
1114 return false;
1115 }
1116 return true;
1117}
1118
1119static bool IsOutputDalvikCache(const char* oat_dir) {
1120 // InstallerConnection.java (which invokes installd) transforms Java null arguments
1121 // into '!'. Play it safe by handling it both.
1122 // TODO: ensure we never get null.
1123 // TODO: pass a flag instead of inferring if the output is dalvik cache.
1124 return oat_dir == nullptr || oat_dir[0] == '!';
1125}
1126
Calin Juravled23dee72017-07-06 16:29:11 -07001127// Best-effort check whether we can fit the the path into our buffers.
1128// Note: the cache path will require an additional 5 bytes for ".swap", but we'll try to run
1129// without a swap file, if necessary. Reference profiles file also add an extra ".prof"
1130// extension to the cache path (5 bytes).
1131// TODO(calin): move away from char* buffers and PKG_PATH_MAX.
1132static bool validate_dex_path_size(const std::string& dex_path) {
1133 if (dex_path.size() >= (PKG_PATH_MAX - 8)) {
1134 LOG(ERROR) << "dex_path too long: " << dex_path;
1135 return false;
1136 }
1137 return true;
1138}
1139
Jeff Sharkey90aff262016-12-12 14:28:24 -07001140static bool create_oat_out_path(const char* apk_path, const char* instruction_set,
Calin Juravle80a21252017-01-17 14:43:25 -08001141 const char* oat_dir, bool is_secondary_dex, /*out*/ char* out_oat_path) {
Calin Juravled23dee72017-07-06 16:29:11 -07001142 if (!validate_dex_path_size(apk_path)) {
Jeff Sharkey90aff262016-12-12 14:28:24 -07001143 return false;
1144 }
1145
1146 if (!IsOutputDalvikCache(oat_dir)) {
Calin Juravle80a21252017-01-17 14:43:25 -08001147 // Oat dirs for secondary dex files are already validated.
1148 if (!is_secondary_dex && validate_apk_path(oat_dir)) {
Jeff Sharkey90aff262016-12-12 14:28:24 -07001149 ALOGE("cannot validate apk path with oat_dir '%s'\n", oat_dir);
1150 return false;
1151 }
1152 if (!calculate_oat_file_path(out_oat_path, oat_dir, apk_path, instruction_set)) {
1153 return false;
1154 }
1155 } else {
1156 if (!create_cache_path(out_oat_path, apk_path, instruction_set)) {
1157 return false;
1158 }
1159 }
1160 return true;
1161}
1162
1163// Helper for fd management. This is similar to a unique_fd in that it closes the file descriptor
1164// on destruction. It will also run the given cleanup (unless told not to) after closing.
1165//
1166// Usage example:
1167//
Calin Juravle7a570e82017-01-14 16:23:30 -08001168// Dex2oatFileWrapper file(open(...),
Jeff Sharkey90aff262016-12-12 14:28:24 -07001169// [name]() {
1170// unlink(name.c_str());
1171// });
1172// // Note: care needs to be taken about name, as it needs to have a lifetime longer than the
1173// wrapper if captured as a reference.
1174//
1175// if (file.get() == -1) {
1176// // Error opening...
1177// }
1178//
1179// ...
1180// if (error) {
1181// // At this point, when the Dex2oatFileWrapper is destructed, the cleanup function will run
1182// // and delete the file (after the fd is closed).
1183// return -1;
1184// }
1185//
1186// (Success case)
1187// file.SetCleanup(false);
1188// // At this point, when the Dex2oatFileWrapper is destructed, the cleanup function will not run
1189// // (leaving the file around; after the fd is closed).
1190//
Jeff Sharkey90aff262016-12-12 14:28:24 -07001191class Dex2oatFileWrapper {
1192 public:
Calin Juravle7a570e82017-01-14 16:23:30 -08001193 Dex2oatFileWrapper() : value_(-1), cleanup_(), do_cleanup_(true), auto_close_(true) {
Jeff Sharkey90aff262016-12-12 14:28:24 -07001194 }
1195
Calin Juravle7a570e82017-01-14 16:23:30 -08001196 Dex2oatFileWrapper(int value, std::function<void ()> cleanup)
1197 : value_(value), cleanup_(cleanup), do_cleanup_(true), auto_close_(true) {}
1198
1199 Dex2oatFileWrapper(Dex2oatFileWrapper&& other) {
1200 value_ = other.value_;
1201 cleanup_ = other.cleanup_;
1202 do_cleanup_ = other.do_cleanup_;
1203 auto_close_ = other.auto_close_;
1204 other.release();
1205 }
1206
1207 Dex2oatFileWrapper& operator=(Dex2oatFileWrapper&& other) {
1208 value_ = other.value_;
1209 cleanup_ = other.cleanup_;
1210 do_cleanup_ = other.do_cleanup_;
1211 auto_close_ = other.auto_close_;
1212 other.release();
1213 return *this;
1214 }
Jeff Sharkey90aff262016-12-12 14:28:24 -07001215
1216 ~Dex2oatFileWrapper() {
1217 reset(-1);
1218 }
1219
1220 int get() {
1221 return value_;
1222 }
1223
1224 void SetCleanup(bool cleanup) {
1225 do_cleanup_ = cleanup;
1226 }
1227
1228 void reset(int new_value) {
Calin Juravle7a570e82017-01-14 16:23:30 -08001229 if (auto_close_ && value_ >= 0) {
Jeff Sharkey90aff262016-12-12 14:28:24 -07001230 close(value_);
1231 }
1232 if (do_cleanup_ && cleanup_ != nullptr) {
1233 cleanup_();
1234 }
1235
1236 value_ = new_value;
1237 }
1238
Calin Juravle7a570e82017-01-14 16:23:30 -08001239 void reset(int new_value, std::function<void ()> new_cleanup) {
1240 if (auto_close_ && value_ >= 0) {
Jeff Sharkey90aff262016-12-12 14:28:24 -07001241 close(value_);
1242 }
1243 if (do_cleanup_ && cleanup_ != nullptr) {
1244 cleanup_();
1245 }
1246
1247 value_ = new_value;
1248 cleanup_ = new_cleanup;
1249 }
1250
Calin Juravle7a570e82017-01-14 16:23:30 -08001251 void DisableAutoClose() {
1252 auto_close_ = false;
1253 }
1254
Jeff Sharkey90aff262016-12-12 14:28:24 -07001255 private:
Calin Juravle7a570e82017-01-14 16:23:30 -08001256 void release() {
1257 value_ = -1;
1258 do_cleanup_ = false;
1259 cleanup_ = nullptr;
1260 }
Jeff Sharkey90aff262016-12-12 14:28:24 -07001261 int value_;
Calin Juravle7a570e82017-01-14 16:23:30 -08001262 std::function<void ()> cleanup_;
Jeff Sharkey90aff262016-12-12 14:28:24 -07001263 bool do_cleanup_;
Calin Juravle7a570e82017-01-14 16:23:30 -08001264 bool auto_close_;
Jeff Sharkey90aff262016-12-12 14:28:24 -07001265};
1266
Calin Juravle7a570e82017-01-14 16:23:30 -08001267// (re)Creates the app image if needed.
1268Dex2oatFileWrapper maybe_open_app_image(const char* out_oat_path, bool profile_guided,
Calin Juravle2289c0a2017-02-15 12:44:14 -08001269 bool is_public, int uid, bool is_secondary_dex) {
Nicolas Geoffrayaa17ab42017-08-15 14:51:05 +01001270
1271 // We don't create an image for secondary dex files.
1272 if (is_secondary_dex) {
Calin Juravle7a570e82017-01-14 16:23:30 -08001273 return Dex2oatFileWrapper();
1274 }
Jeff Sharkey90aff262016-12-12 14:28:24 -07001275
Calin Juravle7a570e82017-01-14 16:23:30 -08001276 const std::string image_path = create_image_filename(out_oat_path);
1277 if (image_path.empty()) {
1278 // Happens when the out_oat_path has an unknown extension.
1279 return Dex2oatFileWrapper();
1280 }
Nicolas Geoffrayaa17ab42017-08-15 14:51:05 +01001281
1282 // Use app images only if it is enabled (by a set image format) and we are compiling
1283 // profile-guided (so the app image doesn't conservatively contain all classes).
1284 if (!profile_guided) {
1285 // In case there is a stale image, remove it now. Ignore any error.
1286 unlink(image_path.c_str());
1287 return Dex2oatFileWrapper();
1288 }
Calin Juravle7a570e82017-01-14 16:23:30 -08001289 char app_image_format[kPropertyValueMax];
1290 bool have_app_image_format =
1291 get_property("dalvik.vm.appimageformat", app_image_format, NULL) > 0;
1292 if (!have_app_image_format) {
1293 return Dex2oatFileWrapper();
1294 }
1295 // Recreate is true since we do not want to modify a mapped image. If the app is
1296 // already running and we modify the image file, it can cause crashes (b/27493510).
1297 Dex2oatFileWrapper wrapper_fd(
1298 open_output_file(image_path.c_str(), true /*recreate*/, 0600 /*permissions*/),
1299 [image_path]() { unlink(image_path.c_str()); });
1300 if (wrapper_fd.get() < 0) {
1301 // Could not create application image file. Go on since we can compile without it.
1302 LOG(ERROR) << "installd could not create '" << image_path
1303 << "' for image file during dexopt";
1304 // If we have a valid image file path but no image fd, explicitly erase the image file.
1305 if (unlink(image_path.c_str()) < 0) {
1306 if (errno != ENOENT) {
1307 PLOG(ERROR) << "Couldn't unlink image file " << image_path;
1308 }
1309 }
1310 } else if (!set_permissions_and_ownership(
Calin Juravle2289c0a2017-02-15 12:44:14 -08001311 wrapper_fd.get(), is_public, uid, image_path.c_str(), is_secondary_dex)) {
Calin Juravle7a570e82017-01-14 16:23:30 -08001312 ALOGE("installd cannot set owner '%s' for image during dexopt\n", image_path.c_str());
1313 wrapper_fd.reset(-1);
1314 }
Jeff Sharkey90aff262016-12-12 14:28:24 -07001315
Calin Juravle7a570e82017-01-14 16:23:30 -08001316 return wrapper_fd;
1317}
1318
1319// Creates the dexopt swap file if necessary and return its fd.
1320// Returns -1 if there's no need for a swap or in case of errors.
Calin Juravle1a0af3b2017-03-09 14:33:33 -08001321unique_fd maybe_open_dexopt_swap_file(const char* out_oat_path) {
Calin Juravle7a570e82017-01-14 16:23:30 -08001322 if (!ShouldUseSwapFileForDexopt()) {
Calin Juravle1a0af3b2017-03-09 14:33:33 -08001323 return invalid_unique_fd();
Calin Juravle7a570e82017-01-14 16:23:30 -08001324 }
Jeff Sharkeyc1149c92017-09-21 14:51:09 -06001325 auto swap_file_name = std::string(out_oat_path) + ".swap";
Calin Juravle1a0af3b2017-03-09 14:33:33 -08001326 unique_fd swap_fd(open_output_file(
Jeff Sharkeyc1149c92017-09-21 14:51:09 -06001327 swap_file_name.c_str(), /*recreate*/true, /*permissions*/0600));
Calin Juravle7a570e82017-01-14 16:23:30 -08001328 if (swap_fd.get() < 0) {
1329 // Could not create swap file. Optimistically go on and hope that we can compile
1330 // without it.
Jeff Sharkeyc1149c92017-09-21 14:51:09 -06001331 ALOGE("installd could not create '%s' for swap during dexopt\n", swap_file_name.c_str());
Calin Juravle7a570e82017-01-14 16:23:30 -08001332 } else {
1333 // Immediately unlink. We don't really want to hit flash.
Jeff Sharkeyc1149c92017-09-21 14:51:09 -06001334 if (unlink(swap_file_name.c_str()) < 0) {
Calin Juravle7a570e82017-01-14 16:23:30 -08001335 PLOG(ERROR) << "Couldn't unlink swap file " << swap_file_name;
1336 }
1337 }
1338 return swap_fd;
1339}
1340
1341// Opens the reference profiles if needed.
1342// Note that the reference profile might not exist so it's OK if the fd will be -1.
Calin Juravle114f0812017-03-08 19:05:07 -08001343Dex2oatFileWrapper maybe_open_reference_profile(const std::string& pkgname,
Calin Juravlec4f6a0b2018-02-01 01:27:24 +00001344 const std::string& dex_path, const char* profile_name, bool profile_guided,
Calin Juravle824a64d2018-01-18 20:23:17 -08001345 bool is_public, int uid, bool is_secondary_dex) {
Calin Juravle5bd1c722018-02-01 17:23:54 +00001346 // If we are not profile guided compilation, or we are compiling system server
1347 // do not bother to open the profiles; we won't be using them.
1348 if (!profile_guided || (pkgname[0] == '*')) {
1349 return Dex2oatFileWrapper();
1350 }
1351
1352 // If this is a secondary dex path which is public do not open the profile.
1353 // We cannot compile public secondary dex paths with profiles. That's because
1354 // it will expose how the dex files are used by their owner.
1355 //
1356 // Note that the PackageManager is responsible to set the is_public flag for
1357 // primary apks and we do not check it here. In some cases, e.g. when
1358 // compiling with a public profile from the .dm file the PackageManager will
1359 // set is_public toghether with the profile guided compilation.
1360 if (is_secondary_dex && is_public) {
Calin Juravle7a570e82017-01-14 16:23:30 -08001361 return Dex2oatFileWrapper();
Jeff Sharkey90aff262016-12-12 14:28:24 -07001362 }
Calin Juravle114f0812017-03-08 19:05:07 -08001363
1364 // Open reference profile in read only mode as dex2oat does not get write permissions.
Calin Juravlec4f6a0b2018-02-01 01:27:24 +00001365 std::string location;
1366 if (is_secondary_dex) {
1367 location = dex_path;
1368 } else {
1369 if (profile_name == nullptr) {
1370 // This path is taken for system server re-compilation lunched from ZygoteInit.
1371 return Dex2oatFileWrapper();
1372 } else {
1373 location = profile_name;
1374 }
1375 }
Calin Juravle824a64d2018-01-18 20:23:17 -08001376 unique_fd ufd = open_reference_profile(uid, pkgname, location, /*read_write*/false,
1377 is_secondary_dex);
1378 const auto& cleanup = [pkgname, location, is_secondary_dex]() {
1379 clear_reference_profile(pkgname, location, is_secondary_dex);
Calin Juravle114f0812017-03-08 19:05:07 -08001380 };
1381 return Dex2oatFileWrapper(ufd.release(), cleanup);
Calin Juravle7a570e82017-01-14 16:23:30 -08001382}
Jeff Sharkey90aff262016-12-12 14:28:24 -07001383
Calin Juravle7a570e82017-01-14 16:23:30 -08001384// Opens the vdex files and assigns the input fd to in_vdex_wrapper_fd and the output fd to
1385// out_vdex_wrapper_fd. Returns true for success or false in case of errors.
Shubham Ajmerab6bcd222017-10-19 10:08:03 -07001386bool open_vdex_files_for_dex2oat(const char* apk_path, const char* out_oat_path, int dexopt_needed,
Nicolas Geoffray3c95f2d2017-04-24 13:34:59 +00001387 const char* instruction_set, bool is_public, int uid, bool is_secondary_dex,
Nicolas Geoffrayb03814f2017-06-05 12:38:10 +00001388 bool profile_guided, Dex2oatFileWrapper* in_vdex_wrapper_fd,
Calin Juravle7a570e82017-01-14 16:23:30 -08001389 Dex2oatFileWrapper* out_vdex_wrapper_fd) {
1390 CHECK(in_vdex_wrapper_fd != nullptr);
1391 CHECK(out_vdex_wrapper_fd != nullptr);
Jeff Sharkey90aff262016-12-12 14:28:24 -07001392 // Open the existing VDEX. We do this before creating the new output VDEX, which will
1393 // unlink the old one.
Richard Uhler76cc0272016-12-08 10:46:35 +00001394 char in_odex_path[PKG_PATH_MAX];
1395 int dexopt_action = abs(dexopt_needed);
1396 bool is_odex_location = dexopt_needed < 0;
Jeff Sharkey90aff262016-12-12 14:28:24 -07001397 std::string in_vdex_path_str;
Nicolas Geoffrayb03814f2017-06-05 12:38:10 +00001398
1399 // Infer the name of the output VDEX.
1400 const std::string out_vdex_path_str = create_vdex_filename(out_oat_path);
1401 if (out_vdex_path_str.empty()) {
1402 return false;
1403 }
1404
1405 bool update_vdex_in_place = false;
Nicolas Geoffray3c95f2d2017-04-24 13:34:59 +00001406 if (dexopt_action != DEX2OAT_FROM_SCRATCH) {
Jeff Sharkey90aff262016-12-12 14:28:24 -07001407 // Open the possibly existing vdex. If none exist, we pass -1 to dex2oat for input-vdex-fd.
1408 const char* path = nullptr;
1409 if (is_odex_location) {
1410 if (calculate_odex_file_path(in_odex_path, apk_path, instruction_set)) {
1411 path = in_odex_path;
1412 } else {
1413 ALOGE("installd cannot compute input vdex location for '%s'\n", apk_path);
Calin Juravle7a570e82017-01-14 16:23:30 -08001414 return false;
Jeff Sharkey90aff262016-12-12 14:28:24 -07001415 }
1416 } else {
1417 path = out_oat_path;
1418 }
1419 in_vdex_path_str = create_vdex_filename(path);
1420 if (in_vdex_path_str.empty()) {
1421 ALOGE("installd cannot compute input vdex location for '%s'\n", path);
Calin Juravle7a570e82017-01-14 16:23:30 -08001422 return false;
Jeff Sharkey90aff262016-12-12 14:28:24 -07001423 }
Nicolas Geoffrayb03814f2017-06-05 12:38:10 +00001424 // We can update in place when all these conditions are met:
1425 // 1) The vdex location to write to is the same as the vdex location to read (vdex files
1426 // on /system typically cannot be updated in place).
1427 // 2) We dex2oat due to boot image change, because we then know the existing vdex file
1428 // cannot be currently used by a running process.
1429 // 3) We are not doing a profile guided compilation, because dexlayout requires two
1430 // different vdex files to operate.
1431 update_vdex_in_place =
1432 (in_vdex_path_str == out_vdex_path_str) &&
1433 (dexopt_action == DEX2OAT_FOR_BOOT_IMAGE) &&
1434 !profile_guided;
1435 if (update_vdex_in_place) {
1436 // Open the file read-write to be able to update it.
1437 in_vdex_wrapper_fd->reset(open(in_vdex_path_str.c_str(), O_RDWR, 0));
1438 if (in_vdex_wrapper_fd->get() == -1) {
1439 // If we failed to open the file, we cannot update it in place.
1440 update_vdex_in_place = false;
1441 }
1442 } else {
1443 in_vdex_wrapper_fd->reset(open(in_vdex_path_str.c_str(), O_RDONLY, 0));
1444 }
Jeff Sharkey90aff262016-12-12 14:28:24 -07001445 }
1446
Nicolas Geoffrayb03814f2017-06-05 12:38:10 +00001447 // If we are updating the vdex in place, we do not need to recreate a vdex,
1448 // and can use the same existing one.
1449 if (update_vdex_in_place) {
1450 // We unlink the file in case the invocation of dex2oat fails, to ensure we don't
1451 // have bogus stale vdex files.
1452 out_vdex_wrapper_fd->reset(
1453 in_vdex_wrapper_fd->get(),
1454 [out_vdex_path_str]() { unlink(out_vdex_path_str.c_str()); });
1455 // Disable auto close for the in wrapper fd (it will be done when destructing the out
1456 // wrapper).
1457 in_vdex_wrapper_fd->DisableAutoClose();
1458 } else {
1459 out_vdex_wrapper_fd->reset(
1460 open_output_file(out_vdex_path_str.c_str(), /*recreate*/true, /*permissions*/0644),
1461 [out_vdex_path_str]() { unlink(out_vdex_path_str.c_str()); });
1462 if (out_vdex_wrapper_fd->get() < 0) {
1463 ALOGE("installd cannot open vdex'%s' during dexopt\n", out_vdex_path_str.c_str());
1464 return false;
1465 }
Jeff Sharkey90aff262016-12-12 14:28:24 -07001466 }
Calin Juravle7a570e82017-01-14 16:23:30 -08001467 if (!set_permissions_and_ownership(out_vdex_wrapper_fd->get(), is_public, uid,
Calin Juravle2289c0a2017-02-15 12:44:14 -08001468 out_vdex_path_str.c_str(), is_secondary_dex)) {
Calin Juravle7a570e82017-01-14 16:23:30 -08001469 ALOGE("installd cannot set owner '%s' for vdex during dexopt\n", out_vdex_path_str.c_str());
1470 return false;
1471 }
1472
1473 // If we got here we successfully opened the vdex files.
1474 return true;
1475}
1476
1477// Opens the output oat file for the given apk.
1478// If successful it stores the output path into out_oat_path and returns true.
1479Dex2oatFileWrapper open_oat_out_file(const char* apk_path, const char* oat_dir,
Calin Juravle80a21252017-01-17 14:43:25 -08001480 bool is_public, int uid, const char* instruction_set, bool is_secondary_dex,
1481 char* out_oat_path) {
1482 if (!create_oat_out_path(apk_path, instruction_set, oat_dir, is_secondary_dex, out_oat_path)) {
Calin Juravle7a570e82017-01-14 16:23:30 -08001483 return Dex2oatFileWrapper();
1484 }
1485 const std::string out_oat_path_str(out_oat_path);
1486 Dex2oatFileWrapper wrapper_fd(
1487 open_output_file(out_oat_path, /*recreate*/true, /*permissions*/0644),
1488 [out_oat_path_str]() { unlink(out_oat_path_str.c_str()); });
1489 if (wrapper_fd.get() < 0) {
Calin Juravle80a21252017-01-17 14:43:25 -08001490 PLOG(ERROR) << "installd cannot open output during dexopt" << out_oat_path;
Calin Juravle2289c0a2017-02-15 12:44:14 -08001491 } else if (!set_permissions_and_ownership(
1492 wrapper_fd.get(), is_public, uid, out_oat_path, is_secondary_dex)) {
Calin Juravle7a570e82017-01-14 16:23:30 -08001493 ALOGE("installd cannot set owner '%s' for output during dexopt\n", out_oat_path);
1494 wrapper_fd.reset(-1);
1495 }
1496 return wrapper_fd;
1497}
1498
Shubham Ajmerab6bcd222017-10-19 10:08:03 -07001499// Creates RDONLY fds for oat and vdex files, if exist.
1500// Returns false if it fails to create oat out path for the given apk path.
1501// Note that the method returns true even if the files could not be opened.
1502bool maybe_open_oat_and_vdex_file(const std::string& apk_path,
1503 const std::string& oat_dir,
1504 const std::string& instruction_set,
1505 bool is_secondary_dex,
1506 unique_fd* oat_file_fd,
1507 unique_fd* vdex_file_fd) {
1508 char oat_path[PKG_PATH_MAX];
1509 if (!create_oat_out_path(apk_path.c_str(),
1510 instruction_set.c_str(),
1511 oat_dir.c_str(),
1512 is_secondary_dex,
1513 oat_path)) {
Calin Juravle7d765462017-09-04 15:57:10 -07001514 LOG(ERROR) << "Could not create oat out path for "
1515 << apk_path << " with oat dir " << oat_dir;
Shubham Ajmerab6bcd222017-10-19 10:08:03 -07001516 return false;
1517 }
1518 oat_file_fd->reset(open(oat_path, O_RDONLY));
1519 if (oat_file_fd->get() < 0) {
1520 PLOG(INFO) << "installd cannot open oat file during dexopt" << oat_path;
1521 }
1522
1523 std::string vdex_filename = create_vdex_filename(oat_path);
1524 vdex_file_fd->reset(open(vdex_filename.c_str(), O_RDONLY));
1525 if (vdex_file_fd->get() < 0) {
1526 PLOG(INFO) << "installd cannot open vdex file during dexopt" << vdex_filename;
1527 }
1528
1529 return true;
1530}
1531
Calin Juravle7a570e82017-01-14 16:23:30 -08001532// Updates the access times of out_oat_path based on those from apk_path.
1533void update_out_oat_access_times(const char* apk_path, const char* out_oat_path) {
1534 struct stat input_stat;
1535 memset(&input_stat, 0, sizeof(input_stat));
1536 if (stat(apk_path, &input_stat) != 0) {
1537 PLOG(ERROR) << "Could not stat " << apk_path << " during dexopt";
1538 return;
1539 }
1540
1541 struct utimbuf ut;
1542 ut.actime = input_stat.st_atime;
1543 ut.modtime = input_stat.st_mtime;
1544 if (utime(out_oat_path, &ut) != 0) {
1545 PLOG(WARNING) << "Could not update access times for " << apk_path << " during dexopt";
1546 }
1547}
1548
Calin Juravle80a21252017-01-17 14:43:25 -08001549// Runs (execv) dexoptanalyzer on the given arguments.
Calin Juravle114f0812017-03-08 19:05:07 -08001550// The analyzer will check if the dex_file needs to be (re)compiled to match the compiler_filter.
1551// If this is for a profile guided compilation, profile_was_updated will tell whether or not
1552// the profile has changed.
Shubham Ajmerab6bcd222017-10-19 10:08:03 -07001553static void exec_dexoptanalyzer(const std::string& dex_file, int vdex_fd, int oat_fd,
1554 int zip_fd, const std::string& instruction_set, const std::string& compiler_filter,
1555 bool profile_was_updated, bool downgrade,
Calin Juravle58cab072017-09-12 01:02:26 -07001556 const char* class_loader_context) {
Shubham Ajmerab6bcd222017-10-19 10:08:03 -07001557 CHECK_GE(zip_fd, 0);
Andreas Gampe6a9cf722017-07-24 16:49:10 -07001558 const char* dexoptanalyzer_bin =
1559 is_debug_runtime()
1560 ? "/system/bin/dexoptanalyzerd"
1561 : "/system/bin/dexoptanalyzer";
Calin Juravle80a21252017-01-17 14:43:25 -08001562 static const unsigned int MAX_INSTRUCTION_SET_LEN = 7;
1563
Calin Juravled23dee72017-07-06 16:29:11 -07001564 if (instruction_set.size() >= MAX_INSTRUCTION_SET_LEN) {
1565 LOG(ERROR) << "Instruction set " << instruction_set
1566 << " longer than max length of " << MAX_INSTRUCTION_SET_LEN;
Calin Juravle80a21252017-01-17 14:43:25 -08001567 return;
1568 }
1569
Calin Juravled23dee72017-07-06 16:29:11 -07001570 std::string dex_file_arg = "--dex-file=" + dex_file;
Shubham Ajmerab6bcd222017-10-19 10:08:03 -07001571 std::string oat_fd_arg = "--oat-fd=" + std::to_string(oat_fd);
1572 std::string vdex_fd_arg = "--vdex-fd=" + std::to_string(vdex_fd);
1573 std::string zip_fd_arg = "--zip-fd=" + std::to_string(zip_fd);
Calin Juravled23dee72017-07-06 16:29:11 -07001574 std::string isa_arg = "--isa=" + instruction_set;
1575 std::string compiler_filter_arg = "--compiler-filter=" + compiler_filter;
Calin Juravle114f0812017-03-08 19:05:07 -08001576 const char* assume_profile_changed = "--assume-profile-changed";
Shubham Ajmera54ef8622017-06-22 11:10:27 -07001577 const char* downgrade_flag = "--downgrade";
Calin Juravle58cab072017-09-12 01:02:26 -07001578 std::string class_loader_context_arg = "--class-loader-context=";
1579 if (class_loader_context != nullptr) {
1580 class_loader_context_arg += class_loader_context;
1581 }
Calin Juravle80a21252017-01-17 14:43:25 -08001582
Calin Juravle80a21252017-01-17 14:43:25 -08001583 // program name, dex file, isa, filter, the final NULL
Shubham Ajmerab6bcd222017-10-19 10:08:03 -07001584 const int argc = 6 +
Shubham Ajmera54ef8622017-06-22 11:10:27 -07001585 (profile_was_updated ? 1 : 0) +
Shubham Ajmerab6bcd222017-10-19 10:08:03 -07001586 (vdex_fd >= 0 ? 1 : 0) +
1587 (oat_fd >= 0 ? 1 : 0) +
Calin Juravle58cab072017-09-12 01:02:26 -07001588 (downgrade ? 1 : 0) +
1589 (class_loader_context != nullptr ? 1 : 0);
Shubham Ajmera54ef8622017-06-22 11:10:27 -07001590 const char* argv[argc];
Calin Juravle80a21252017-01-17 14:43:25 -08001591 int i = 0;
Andreas Gampe6a9cf722017-07-24 16:49:10 -07001592 argv[i++] = dexoptanalyzer_bin;
Calin Juravled23dee72017-07-06 16:29:11 -07001593 argv[i++] = dex_file_arg.c_str();
1594 argv[i++] = isa_arg.c_str();
1595 argv[i++] = compiler_filter_arg.c_str();
Shubham Ajmerab6bcd222017-10-19 10:08:03 -07001596 if (oat_fd >= 0) {
1597 argv[i++] = oat_fd_arg.c_str();
1598 }
1599 if (vdex_fd >= 0) {
1600 argv[i++] = vdex_fd_arg.c_str();
1601 }
1602 argv[i++] = zip_fd_arg.c_str();
Calin Juravle114f0812017-03-08 19:05:07 -08001603 if (profile_was_updated) {
1604 argv[i++] = assume_profile_changed;
1605 }
Shubham Ajmera54ef8622017-06-22 11:10:27 -07001606 if (downgrade) {
1607 argv[i++] = downgrade_flag;
1608 }
Calin Juravle58cab072017-09-12 01:02:26 -07001609 if (class_loader_context != nullptr) {
Calin Juravle91501072017-10-26 15:44:53 -07001610 argv[i++] = class_loader_context_arg.c_str();
Calin Juravle58cab072017-09-12 01:02:26 -07001611 }
Calin Juravle80a21252017-01-17 14:43:25 -08001612 argv[i] = NULL;
1613
Andreas Gampe6a9cf722017-07-24 16:49:10 -07001614 execv(dexoptanalyzer_bin, (char * const *)argv);
1615 ALOGE("execv(%s) failed: %s\n", dexoptanalyzer_bin, strerror(errno));
Calin Juravle80a21252017-01-17 14:43:25 -08001616}
1617
1618// Prepares the oat dir for the secondary dex files.
Calin Juravle114f0812017-03-08 19:05:07 -08001619static bool prepare_secondary_dex_oat_dir(const std::string& dex_path, int uid,
Calin Juravle7d765462017-09-04 15:57:10 -07001620 const char* instruction_set) {
Calin Juravle114f0812017-03-08 19:05:07 -08001621 unsigned long dirIndex = dex_path.rfind('/');
Calin Juravle80a21252017-01-17 14:43:25 -08001622 if (dirIndex == std::string::npos) {
Calin Juravlec9eab382017-01-25 01:17:17 -08001623 LOG(ERROR ) << "Unexpected dir structure for secondary dex " << dex_path;
Calin Juravle80a21252017-01-17 14:43:25 -08001624 return false;
1625 }
Calin Juravle114f0812017-03-08 19:05:07 -08001626 std::string dex_dir = dex_path.substr(0, dirIndex);
Calin Juravle80a21252017-01-17 14:43:25 -08001627
Calin Juravle80a21252017-01-17 14:43:25 -08001628 // Create oat file output directory.
Calin Juravleebc8a792017-04-04 20:21:05 -07001629 mode_t oat_dir_mode = S_IRWXU | S_IRWXG | S_IXOTH;
1630 if (prepare_app_cache_dir(dex_dir, "oat", oat_dir_mode, uid, uid) != 0) {
Calin Juravlec9eab382017-01-25 01:17:17 -08001631 LOG(ERROR) << "Could not prepare oat dir for secondary dex: " << dex_path;
Calin Juravle80a21252017-01-17 14:43:25 -08001632 return false;
1633 }
1634
1635 char oat_dir[PKG_PATH_MAX];
Calin Juravle114f0812017-03-08 19:05:07 -08001636 snprintf(oat_dir, PKG_PATH_MAX, "%s/oat", dex_dir.c_str());
Calin Juravle80a21252017-01-17 14:43:25 -08001637
Calin Juravle7d765462017-09-04 15:57:10 -07001638 if (prepare_app_cache_dir(oat_dir, instruction_set, oat_dir_mode, uid, uid) != 0) {
Calin Juravlec9eab382017-01-25 01:17:17 -08001639 LOG(ERROR) << "Could not prepare oat/isa dir for secondary dex: " << dex_path;
Calin Juravle80a21252017-01-17 14:43:25 -08001640 return false;
1641 }
1642
1643 return true;
1644}
1645
Calin Juravle7d765462017-09-04 15:57:10 -07001646// Return codes for identifying the reason why dexoptanalyzer was not invoked when processing
1647// secondary dex files. This return codes are returned by the child process created for
1648// analyzing secondary dex files in process_secondary_dex_dexopt.
Calin Juravle80a21252017-01-17 14:43:25 -08001649
Andreas Gampe194fe422018-02-28 20:16:19 -08001650enum DexoptAnalyzerSkipCodes {
1651 // The dexoptanalyzer was not invoked because of validation or IO errors.
Andreas Gampe3008bbe2018-02-28 20:24:48 -08001652 // Specific errors are encoded in the name.
1653 kSecondaryDexDexoptAnalyzerSkippedValidatePath = 200,
1654 kSecondaryDexDexoptAnalyzerSkippedOpenZip = 201,
1655 kSecondaryDexDexoptAnalyzerSkippedPrepareDir = 202,
1656 kSecondaryDexDexoptAnalyzerSkippedOpenOutput = 203,
1657 kSecondaryDexDexoptAnalyzerSkippedFailExec = 204,
Andreas Gampe194fe422018-02-28 20:16:19 -08001658 // The dexoptanalyzer was not invoked because the dex file does not exist anymore.
Andreas Gampe3008bbe2018-02-28 20:24:48 -08001659 kSecondaryDexDexoptAnalyzerSkippedNoFile = 205,
Andreas Gampe194fe422018-02-28 20:16:19 -08001660};
Calin Juravle7d765462017-09-04 15:57:10 -07001661
1662// Verifies the result of analyzing secondary dex files from process_secondary_dex_dexopt.
Calin Juravle80a21252017-01-17 14:43:25 -08001663// If the result is valid returns true and sets dexopt_needed_out to a valid value.
1664// Returns false for errors or unexpected result values.
Calin Juravle7d765462017-09-04 15:57:10 -07001665// The result is expected to be either one of SECONDARY_DEX_* codes or a valid exit code
1666// of dexoptanalyzer.
1667static bool process_secondary_dexoptanalyzer_result(const std::string& dex_path, int result,
Andreas Gampe194fe422018-02-28 20:16:19 -08001668 int* dexopt_needed_out, std::string* error_msg) {
Calin Juravle80a21252017-01-17 14:43:25 -08001669 // The result values are defined in dexoptanalyzer.
1670 switch (result) {
Calin Juravle7d765462017-09-04 15:57:10 -07001671 case 0: // dexoptanalyzer: no_dexopt_needed
Calin Juravle80a21252017-01-17 14:43:25 -08001672 *dexopt_needed_out = NO_DEXOPT_NEEDED; return true;
Calin Juravle7d765462017-09-04 15:57:10 -07001673 case 1: // dexoptanalyzer: dex2oat_from_scratch
Calin Juravle80a21252017-01-17 14:43:25 -08001674 *dexopt_needed_out = DEX2OAT_FROM_SCRATCH; return true;
Calin Juravle7d765462017-09-04 15:57:10 -07001675 case 5: // dexoptanalyzer: dex2oat_for_bootimage_odex
Calin Juravle80a21252017-01-17 14:43:25 -08001676 *dexopt_needed_out = -DEX2OAT_FOR_BOOT_IMAGE; return true;
Calin Juravle7d765462017-09-04 15:57:10 -07001677 case 6: // dexoptanalyzer: dex2oat_for_filter_odex
Calin Juravle80a21252017-01-17 14:43:25 -08001678 *dexopt_needed_out = -DEX2OAT_FOR_FILTER; return true;
Calin Juravle7d765462017-09-04 15:57:10 -07001679 case 7: // dexoptanalyzer: dex2oat_for_relocation_odex
Calin Juravle80a21252017-01-17 14:43:25 -08001680 *dexopt_needed_out = -DEX2OAT_FOR_RELOCATION; return true;
Calin Juravle7d765462017-09-04 15:57:10 -07001681 case 2: // dexoptanalyzer: dex2oat_for_bootimage_oat
1682 case 3: // dexoptanalyzer: dex2oat_for_filter_oat
1683 case 4: // dexoptanalyzer: dex2oat_for_relocation_oat
Andreas Gampe194fe422018-02-28 20:16:19 -08001684 *error_msg = StringPrintf("Dexoptanalyzer return the status of an oat file."
1685 " Expected odex file status for secondary dex %s"
1686 " : dexoptanalyzer result=%d",
1687 dex_path.c_str(),
1688 result);
Calin Juravle80a21252017-01-17 14:43:25 -08001689 return false;
Andreas Gampe194fe422018-02-28 20:16:19 -08001690 }
1691
1692 // Use a second switch for enum switch-case analysis.
1693 switch (static_cast<DexoptAnalyzerSkipCodes>(result)) {
Andreas Gampe3008bbe2018-02-28 20:24:48 -08001694 case kSecondaryDexDexoptAnalyzerSkippedNoFile:
Calin Juravle7d765462017-09-04 15:57:10 -07001695 // If the file does not exist there's no need for dexopt.
1696 *dexopt_needed_out = NO_DEXOPT_NEEDED;
1697 return true;
Andreas Gampe3008bbe2018-02-28 20:24:48 -08001698
1699 case kSecondaryDexDexoptAnalyzerSkippedValidatePath:
1700 *error_msg = "Dexoptanalyzer path validation failed";
1701 return false;
1702 case kSecondaryDexDexoptAnalyzerSkippedOpenZip:
1703 *error_msg = "Dexoptanalyzer open zip failed";
1704 return false;
1705 case kSecondaryDexDexoptAnalyzerSkippedPrepareDir:
1706 *error_msg = "Dexoptanalyzer dir preparation failed";
1707 return false;
1708 case kSecondaryDexDexoptAnalyzerSkippedOpenOutput:
1709 *error_msg = "Dexoptanalyzer open output failed";
1710 return false;
1711 case kSecondaryDexDexoptAnalyzerSkippedFailExec:
1712 *error_msg = "Dexoptanalyzer failed to execute";
Calin Juravle80a21252017-01-17 14:43:25 -08001713 return false;
1714 }
Andreas Gampe194fe422018-02-28 20:16:19 -08001715
1716 *error_msg = StringPrintf("Unexpected result from analyzing secondary dex %s result=%d",
1717 dex_path.c_str(),
1718 result);
1719 return false;
Calin Juravle80a21252017-01-17 14:43:25 -08001720}
1721
Calin Juravle7d765462017-09-04 15:57:10 -07001722enum SecondaryDexAccess {
1723 kSecondaryDexAccessReadOk = 0,
1724 kSecondaryDexAccessDoesNotExist = 1,
1725 kSecondaryDexAccessPermissionError = 2,
1726 kSecondaryDexAccessIOError = 3
1727};
1728
1729static SecondaryDexAccess check_secondary_dex_access(const std::string& dex_path) {
1730 // Check if the path exists and can be read. If not, there's nothing to do.
1731 if (access(dex_path.c_str(), R_OK) == 0) {
1732 return kSecondaryDexAccessReadOk;
1733 } else {
1734 if (errno == ENOENT) {
1735 LOG(INFO) << "Secondary dex does not exist: " << dex_path;
1736 return kSecondaryDexAccessDoesNotExist;
1737 } else {
1738 PLOG(ERROR) << "Could not access secondary dex " << dex_path;
1739 return errno == EACCES
1740 ? kSecondaryDexAccessPermissionError
1741 : kSecondaryDexAccessIOError;
1742 }
1743 }
1744}
1745
1746static bool is_file_public(const std::string& filename) {
1747 struct stat file_stat;
1748 if (stat(filename.c_str(), &file_stat) == 0) {
1749 return (file_stat.st_mode & S_IROTH) != 0;
1750 }
1751 return false;
1752}
1753
1754// Create the oat file structure for the secondary dex 'dex_path' and assign
1755// the individual path component to the 'out_' parameters.
1756static bool create_secondary_dex_oat_layout(const std::string& dex_path, const std::string& isa,
Andreas Gampe194fe422018-02-28 20:16:19 -08001757 char* out_oat_dir, char* out_oat_isa_dir, char* out_oat_path, std::string* error_msg) {
Calin Juravle7d765462017-09-04 15:57:10 -07001758 size_t dirIndex = dex_path.rfind('/');
1759 if (dirIndex == std::string::npos) {
Andreas Gampe194fe422018-02-28 20:16:19 -08001760 *error_msg = std::string("Unexpected dir structure for dex file ").append(dex_path);
Calin Juravle7d765462017-09-04 15:57:10 -07001761 return false;
1762 }
1763 // TODO(calin): we have similar computations in at lest 3 other places
1764 // (InstalldNativeService, otapropt and dexopt). Unify them and get rid of snprintf by
1765 // using string append.
1766 std::string apk_dir = dex_path.substr(0, dirIndex);
1767 snprintf(out_oat_dir, PKG_PATH_MAX, "%s/oat", apk_dir.c_str());
1768 snprintf(out_oat_isa_dir, PKG_PATH_MAX, "%s/%s", out_oat_dir, isa.c_str());
1769
1770 if (!create_oat_out_path(dex_path.c_str(), isa.c_str(), out_oat_dir,
1771 /*is_secondary_dex*/true, out_oat_path)) {
Andreas Gampe194fe422018-02-28 20:16:19 -08001772 *error_msg = std::string("Could not create oat path for secondary dex ").append(dex_path);
Calin Juravle7d765462017-09-04 15:57:10 -07001773 return false;
1774 }
1775 return true;
1776}
1777
1778// Validate that the dexopt_flags contain a valid storage flag and convert that to an installd
1779// recognized storage flags (FLAG_STORAGE_CE or FLAG_STORAGE_DE).
Andreas Gampe194fe422018-02-28 20:16:19 -08001780static bool validate_dexopt_storage_flags(int dexopt_flags,
1781 int* out_storage_flag,
1782 std::string* error_msg) {
Calin Juravle7d765462017-09-04 15:57:10 -07001783 if ((dexopt_flags & DEXOPT_STORAGE_CE) != 0) {
1784 *out_storage_flag = FLAG_STORAGE_CE;
1785 if ((dexopt_flags & DEXOPT_STORAGE_DE) != 0) {
Andreas Gampe194fe422018-02-28 20:16:19 -08001786 *error_msg = "Ambiguous secondary dex storage flag. Both, CE and DE, flags are set";
Calin Juravle7d765462017-09-04 15:57:10 -07001787 return false;
1788 }
1789 } else if ((dexopt_flags & DEXOPT_STORAGE_DE) != 0) {
1790 *out_storage_flag = FLAG_STORAGE_DE;
1791 } else {
Andreas Gampe194fe422018-02-28 20:16:19 -08001792 *error_msg = "Secondary dex storage flag must be set";
Calin Juravle7d765462017-09-04 15:57:10 -07001793 return false;
1794 }
1795 return true;
1796}
1797
Calin Juravlec9eab382017-01-25 01:17:17 -08001798// Processes the dex_path as a secondary dex files and return true if the path dex file should
Calin Juravle80a21252017-01-17 14:43:25 -08001799// be compiled. Returns false for errors (logged) or true if the secondary dex path was process
1800// successfully.
Calin Juravleebc8a792017-04-04 20:21:05 -07001801// When returning true, the output parameters will be:
1802// - is_public_out: whether or not the oat file should not be made public
1803// - dexopt_needed_out: valid OatFileAsssitant::DexOptNeeded
1804// - oat_dir_out: the oat dir path where the oat file should be stored
Calin Juravle7d765462017-09-04 15:57:10 -07001805static bool process_secondary_dex_dexopt(const std::string& dex_path, const char* pkgname,
Calin Juravle80a21252017-01-17 14:43:25 -08001806 int dexopt_flags, const char* volume_uuid, int uid, const char* instruction_set,
Calin Juravleebc8a792017-04-04 20:21:05 -07001807 const char* compiler_filter, bool* is_public_out, int* dexopt_needed_out,
Andreas Gampe194fe422018-02-28 20:16:19 -08001808 std::string* oat_dir_out, bool downgrade, const char* class_loader_context,
1809 /* out */ std::string* error_msg) {
Calin Juravle7d765462017-09-04 15:57:10 -07001810 LOG(DEBUG) << "Processing secondary dex path " << dex_path;
Calin Juravle80a21252017-01-17 14:43:25 -08001811 int storage_flag;
Andreas Gampe194fe422018-02-28 20:16:19 -08001812 if (!validate_dexopt_storage_flags(dexopt_flags, &storage_flag, error_msg)) {
1813 LOG(ERROR) << *error_msg;
Calin Juravle80a21252017-01-17 14:43:25 -08001814 return false;
1815 }
Calin Juravle7d765462017-09-04 15:57:10 -07001816 // Compute the oat dir as it's not easy to extract it from the child computation.
1817 char oat_path[PKG_PATH_MAX];
1818 char oat_dir[PKG_PATH_MAX];
1819 char oat_isa_dir[PKG_PATH_MAX];
1820 if (!create_secondary_dex_oat_layout(
Andreas Gampe194fe422018-02-28 20:16:19 -08001821 dex_path, instruction_set, oat_dir, oat_isa_dir, oat_path, error_msg)) {
1822 LOG(ERROR) << "Could not create secondary odex layout: " << *error_msg;
Calin Juravled23dee72017-07-06 16:29:11 -07001823 return false;
1824 }
Calin Juravle7d765462017-09-04 15:57:10 -07001825 oat_dir_out->assign(oat_dir);
Shubham Ajmerab6bcd222017-10-19 10:08:03 -07001826
Calin Juravle80a21252017-01-17 14:43:25 -08001827 pid_t pid = fork();
1828 if (pid == 0) {
1829 // child -- drop privileges before continuing.
1830 drop_capabilities(uid);
Calin Juravle7d765462017-09-04 15:57:10 -07001831
1832 // Validate the path structure.
1833 if (!validate_secondary_dex_path(pkgname, dex_path, volume_uuid, uid, storage_flag)) {
1834 LOG(ERROR) << "Could not validate secondary dex path " << dex_path;
Andreas Gampe3008bbe2018-02-28 20:24:48 -08001835 _exit(kSecondaryDexDexoptAnalyzerSkippedValidatePath);
Calin Juravle7d765462017-09-04 15:57:10 -07001836 }
1837
1838 // Open the dex file.
1839 unique_fd zip_fd;
1840 zip_fd.reset(open(dex_path.c_str(), O_RDONLY));
1841 if (zip_fd.get() < 0) {
1842 if (errno == ENOENT) {
Andreas Gampe3008bbe2018-02-28 20:24:48 -08001843 _exit(kSecondaryDexDexoptAnalyzerSkippedNoFile);
Calin Juravle7d765462017-09-04 15:57:10 -07001844 } else {
Andreas Gampe3008bbe2018-02-28 20:24:48 -08001845 _exit(kSecondaryDexDexoptAnalyzerSkippedOpenZip);
Calin Juravle7d765462017-09-04 15:57:10 -07001846 }
1847 }
1848
1849 // Prepare the oat directories.
1850 if (!prepare_secondary_dex_oat_dir(dex_path, uid, instruction_set)) {
Andreas Gampe3008bbe2018-02-28 20:24:48 -08001851 _exit(kSecondaryDexDexoptAnalyzerSkippedPrepareDir);
Calin Juravle7d765462017-09-04 15:57:10 -07001852 }
1853
1854 // Open the vdex/oat files if any.
1855 unique_fd oat_file_fd;
1856 unique_fd vdex_file_fd;
1857 if (!maybe_open_oat_and_vdex_file(dex_path,
1858 *oat_dir_out,
1859 instruction_set,
1860 true /* is_secondary_dex */,
1861 &oat_file_fd,
1862 &vdex_file_fd)) {
Andreas Gampe3008bbe2018-02-28 20:24:48 -08001863 _exit(kSecondaryDexDexoptAnalyzerSkippedOpenOutput);
Calin Juravle7d765462017-09-04 15:57:10 -07001864 }
1865
1866 // Analyze profiles.
Calin Juravle824a64d2018-01-18 20:23:17 -08001867 bool profile_was_updated = analyze_profiles(uid, pkgname, dex_path,
1868 /*is_secondary_dex*/true);
Calin Juravle7d765462017-09-04 15:57:10 -07001869
1870 // Run dexoptanalyzer to get dexopt_needed code. This is not expected to return.
Shubham Ajmerab6bcd222017-10-19 10:08:03 -07001871 exec_dexoptanalyzer(dex_path,
1872 vdex_file_fd.get(),
1873 oat_file_fd.get(),
1874 zip_fd.get(),
1875 instruction_set,
Calin Juravle7d765462017-09-04 15:57:10 -07001876 compiler_filter, profile_was_updated,
1877 downgrade,
1878 class_loader_context);
1879 PLOG(ERROR) << "Failed to exec dexoptanalyzer";
Andreas Gampe3008bbe2018-02-28 20:24:48 -08001880 _exit(kSecondaryDexDexoptAnalyzerSkippedFailExec);
Calin Juravle80a21252017-01-17 14:43:25 -08001881 }
1882
1883 /* parent */
Calin Juravle80a21252017-01-17 14:43:25 -08001884 int result = wait_child(pid);
1885 if (!WIFEXITED(result)) {
Andreas Gampe194fe422018-02-28 20:16:19 -08001886 *error_msg = StringPrintf("dexoptanalyzer failed for path %s: 0x%04x",
1887 dex_path.c_str(),
1888 result);
1889 LOG(ERROR) << *error_msg;
Calin Juravle80a21252017-01-17 14:43:25 -08001890 return false;
1891 }
1892 result = WEXITSTATUS(result);
Calin Juravle7d765462017-09-04 15:57:10 -07001893 // Check that we successfully executed dexoptanalyzer.
Andreas Gampe194fe422018-02-28 20:16:19 -08001894 bool success = process_secondary_dexoptanalyzer_result(dex_path,
1895 result,
1896 dexopt_needed_out,
1897 error_msg);
1898 if (!success) {
1899 LOG(ERROR) << *error_msg;
1900 }
Calin Juravle7d765462017-09-04 15:57:10 -07001901
1902 LOG(DEBUG) << "Processed secondary dex file " << dex_path << " result=" << result;
1903
Calin Juravle80a21252017-01-17 14:43:25 -08001904 // Run dexopt only if needed or forced.
Calin Juravle7d765462017-09-04 15:57:10 -07001905 // Note that dexoptanalyzer is executed even if force compilation is enabled (because it
1906 // makes the code simpler; force compilation is only needed during tests).
1907 if (success &&
Andreas Gampe3008bbe2018-02-28 20:24:48 -08001908 (result != kSecondaryDexDexoptAnalyzerSkippedNoFile) &&
Calin Juravle7d765462017-09-04 15:57:10 -07001909 ((dexopt_flags & DEXOPT_FORCE) != 0)) {
Calin Juravle80a21252017-01-17 14:43:25 -08001910 *dexopt_needed_out = DEX2OAT_FROM_SCRATCH;
1911 }
1912
Calin Juravle7d765462017-09-04 15:57:10 -07001913 // Check if we should make the oat file public.
1914 // Note that if the dex file is not public the compiled code cannot be made public.
1915 // It is ok to check this flag outside in the parent process.
1916 *is_public_out = ((dexopt_flags & DEXOPT_PUBLIC) != 0) && is_file_public(dex_path);
1917
Calin Juravle80a21252017-01-17 14:43:25 -08001918 return success;
1919}
1920
Andreas Gampefa2dadd2018-02-28 19:52:47 -08001921static std::string format_dexopt_error(int status, const char* dex_path) {
1922 if (WIFEXITED(status)) {
1923 int int_code = WEXITSTATUS(status);
1924 const char* code_name = get_return_code_name(static_cast<DexoptReturnCodes>(int_code));
1925 if (code_name != nullptr) {
1926 return StringPrintf("Dex2oat invocation for %s failed: %s", dex_path, code_name);
1927 }
1928 }
1929 return StringPrintf("Dex2oat invocation for %s failed with 0x%04x", dex_path, status);
Andreas Gampe023b2242018-02-28 16:03:25 -08001930}
1931
Calin Juravlec9eab382017-01-25 01:17:17 -08001932int dexopt(const char* dex_path, uid_t uid, const char* pkgname, const char* instruction_set,
Calin Juravle80a21252017-01-17 14:43:25 -08001933 int dexopt_needed, const char* oat_dir, int dexopt_flags, const char* compiler_filter,
Calin Juravle52c45822017-07-13 22:50:21 -07001934 const char* volume_uuid, const char* class_loader_context, const char* se_info,
Calin Juravle62c5a372018-02-01 17:03:23 +00001935 bool downgrade, int target_sdk_version, const char* profile_name,
Andreas Gampe023b2242018-02-28 16:03:25 -08001936 const char* dex_metadata_path, const char* compilation_reason, std::string* error_msg) {
Calin Juravle7a570e82017-01-14 16:23:30 -08001937 CHECK(pkgname != nullptr);
1938 CHECK(pkgname[0] != 0);
Andreas Gampe023b2242018-02-28 16:03:25 -08001939 CHECK(error_msg != nullptr);
Andreas Gamped32eec22018-02-28 16:02:51 -08001940 CHECK_EQ(dexopt_flags & ~DEXOPT_MASK, 0)
1941 << "dexopt flags contains unknown fields: " << dexopt_flags;
Calin Juravle7a570e82017-01-14 16:23:30 -08001942
Calin Juravled23dee72017-07-06 16:29:11 -07001943 if (!validate_dex_path_size(dex_path)) {
Andreas Gampe023b2242018-02-28 16:03:25 -08001944 *error_msg = StringPrintf("Failed to validate %s", dex_path);
Calin Juravle52c45822017-07-13 22:50:21 -07001945 return -1;
1946 }
1947
1948 if (class_loader_context != nullptr && strlen(class_loader_context) > PKG_PATH_MAX) {
Andreas Gampe023b2242018-02-28 16:03:25 -08001949 *error_msg = StringPrintf("Class loader context exceeds the allowed size: %s",
1950 class_loader_context);
1951 LOG(ERROR) << *error_msg;
Calin Juravle52c45822017-07-13 22:50:21 -07001952 return -1;
Calin Juravled23dee72017-07-06 16:29:11 -07001953 }
1954
Calin Juravleebc8a792017-04-04 20:21:05 -07001955 bool is_public = (dexopt_flags & DEXOPT_PUBLIC) != 0;
Calin Juravle7a570e82017-01-14 16:23:30 -08001956 bool debuggable = (dexopt_flags & DEXOPT_DEBUGGABLE) != 0;
1957 bool boot_complete = (dexopt_flags & DEXOPT_BOOTCOMPLETE) != 0;
1958 bool profile_guided = (dexopt_flags & DEXOPT_PROFILE_GUIDED) != 0;
Calin Juravle80a21252017-01-17 14:43:25 -08001959 bool is_secondary_dex = (dexopt_flags & DEXOPT_SECONDARY_DEX) != 0;
Andreas Gampea73a0cb2017-11-02 18:14:42 -07001960 bool background_job_compile = (dexopt_flags & DEXOPT_IDLE_BACKGROUND_JOB) != 0;
David Brazdil52249162018-02-12 18:04:59 -08001961 bool enable_hidden_api_checks = (dexopt_flags & DEXOPT_ENABLE_HIDDEN_API_CHECKS) != 0;
Calin Juravle80a21252017-01-17 14:43:25 -08001962
1963 // Check if we're dealing with a secondary dex file and if we need to compile it.
1964 std::string oat_dir_str;
1965 if (is_secondary_dex) {
Calin Juravlec9eab382017-01-25 01:17:17 -08001966 if (process_secondary_dex_dexopt(dex_path, pkgname, dexopt_flags, volume_uuid, uid,
Calin Juravleebc8a792017-04-04 20:21:05 -07001967 instruction_set, compiler_filter, &is_public, &dexopt_needed, &oat_dir_str,
Andreas Gampe194fe422018-02-28 20:16:19 -08001968 downgrade, class_loader_context, error_msg)) {
Calin Juravle80a21252017-01-17 14:43:25 -08001969 oat_dir = oat_dir_str.c_str();
1970 if (dexopt_needed == NO_DEXOPT_NEEDED) {
1971 return 0; // Nothing to do, report success.
1972 }
1973 } else {
Andreas Gampe194fe422018-02-28 20:16:19 -08001974 if (error_msg->empty()) { // TODO: Make this a CHECK.
1975 *error_msg = "Failed processing secondary.";
1976 }
Calin Juravle80a21252017-01-17 14:43:25 -08001977 return -1; // We had an error, logged in the process method.
1978 }
1979 } else {
Calin Juravlec9eab382017-01-25 01:17:17 -08001980 // Currently these flags are only use for secondary dex files.
1981 // Verify that they are not set for primary apks.
Calin Juravle80a21252017-01-17 14:43:25 -08001982 CHECK((dexopt_flags & DEXOPT_STORAGE_CE) == 0);
1983 CHECK((dexopt_flags & DEXOPT_STORAGE_DE) == 0);
1984 }
Calin Juravle7a570e82017-01-14 16:23:30 -08001985
1986 // Open the input file.
Calin Juravle1a0af3b2017-03-09 14:33:33 -08001987 unique_fd input_fd(open(dex_path, O_RDONLY, 0));
Calin Juravle7a570e82017-01-14 16:23:30 -08001988 if (input_fd.get() < 0) {
Andreas Gampe023b2242018-02-28 16:03:25 -08001989 *error_msg = StringPrintf("installd cannot open '%s' for input during dexopt", dex_path);
1990 LOG(ERROR) << *error_msg;
Calin Juravle7a570e82017-01-14 16:23:30 -08001991 return -1;
1992 }
1993
1994 // Create the output OAT file.
1995 char out_oat_path[PKG_PATH_MAX];
Calin Juravlec9eab382017-01-25 01:17:17 -08001996 Dex2oatFileWrapper out_oat_fd = open_oat_out_file(dex_path, oat_dir, is_public, uid,
Calin Juravle80a21252017-01-17 14:43:25 -08001997 instruction_set, is_secondary_dex, out_oat_path);
Calin Juravle7a570e82017-01-14 16:23:30 -08001998 if (out_oat_fd.get() < 0) {
Andreas Gampe023b2242018-02-28 16:03:25 -08001999 *error_msg = "Could not open out oat file.";
Calin Juravle7a570e82017-01-14 16:23:30 -08002000 return -1;
2001 }
2002
2003 // Open vdex files.
2004 Dex2oatFileWrapper in_vdex_fd;
2005 Dex2oatFileWrapper out_vdex_fd;
Shubham Ajmerab6bcd222017-10-19 10:08:03 -07002006 if (!open_vdex_files_for_dex2oat(dex_path, out_oat_path, dexopt_needed, instruction_set,
2007 is_public, uid, is_secondary_dex, profile_guided, &in_vdex_fd, &out_vdex_fd)) {
Andreas Gampe023b2242018-02-28 16:03:25 -08002008 *error_msg = "Could not open vdex files.";
Jeff Sharkey90aff262016-12-12 14:28:24 -07002009 return -1;
2010 }
2011
Calin Juravlecb556e32017-04-04 20:22:50 -07002012 // Ensure that the oat dir and the compiler artifacts of secondary dex files have the correct
2013 // selinux context (we generate them on the fly during the dexopt invocation and they don't
2014 // fully inherit their parent context).
2015 // Note that for primary apk the oat files are created before, in a separate installd
2016 // call which also does the restorecon. TODO(calin): unify the paths.
2017 if (is_secondary_dex) {
2018 if (selinux_android_restorecon_pkgdir(oat_dir, se_info, uid,
2019 SELINUX_ANDROID_RESTORECON_RECURSE)) {
Andreas Gampe023b2242018-02-28 16:03:25 -08002020 *error_msg = std::string("Failed to restorecon ").append(oat_dir);
2021 LOG(ERROR) << *error_msg;
Calin Juravlecb556e32017-04-04 20:22:50 -07002022 return -1;
2023 }
2024 }
2025
Jeff Sharkey90aff262016-12-12 14:28:24 -07002026 // Create a swap file if necessary.
Calin Juravle1a0af3b2017-03-09 14:33:33 -08002027 unique_fd swap_fd = maybe_open_dexopt_swap_file(out_oat_path);
Jeff Sharkey90aff262016-12-12 14:28:24 -07002028
Calin Juravle7a570e82017-01-14 16:23:30 -08002029 // Create the app image file if needed.
2030 Dex2oatFileWrapper image_fd =
Calin Juravle2289c0a2017-02-15 12:44:14 -08002031 maybe_open_app_image(out_oat_path, profile_guided, is_public, uid, is_secondary_dex);
Jeff Sharkey90aff262016-12-12 14:28:24 -07002032
Calin Juravle7a570e82017-01-14 16:23:30 -08002033 // Open the reference profile if needed.
Calin Juravle114f0812017-03-08 19:05:07 -08002034 Dex2oatFileWrapper reference_profile_fd = maybe_open_reference_profile(
Calin Juravle824a64d2018-01-18 20:23:17 -08002035 pkgname, dex_path, profile_name, profile_guided, is_public, uid, is_secondary_dex);
Calin Juravle7a570e82017-01-14 16:23:30 -08002036
Calin Juravle62c5a372018-02-01 17:03:23 +00002037 unique_fd dex_metadata_fd;
2038 if (dex_metadata_path != nullptr) {
2039 dex_metadata_fd.reset(TEMP_FAILURE_RETRY(open(dex_metadata_path, O_RDONLY | O_NOFOLLOW)));
2040 if (dex_metadata_fd.get() < 0) {
2041 PLOG(ERROR) << "Failed to open dex metadata file " << dex_metadata_path;
2042 }
2043 }
2044
Andreas Gampe023b2242018-02-28 16:03:25 -08002045 LOG(VERBOSE) << "DexInv: --- BEGIN '" << dex_path << "' ---";
Jeff Sharkey90aff262016-12-12 14:28:24 -07002046
2047 pid_t pid = fork();
2048 if (pid == 0) {
2049 /* child -- drop privileges before continuing */
2050 drop_capabilities(uid);
2051
Richard Uhler76cc0272016-12-08 10:46:35 +00002052 SetDex2OatScheduling(boot_complete);
Jeff Sharkey90aff262016-12-12 14:28:24 -07002053 if (flock(out_oat_fd.get(), LOCK_EX | LOCK_NB) != 0) {
Andreas Gampe023b2242018-02-28 16:03:25 -08002054 PLOG(ERROR) << "flock(" << out_oat_path << ") failed";
Andreas Gampefa2dadd2018-02-28 19:52:47 -08002055 _exit(DexoptReturnCodes::kFlock);
Jeff Sharkey90aff262016-12-12 14:28:24 -07002056 }
2057
Richard Uhler76cc0272016-12-08 10:46:35 +00002058 run_dex2oat(input_fd.get(),
2059 out_oat_fd.get(),
2060 in_vdex_fd.get(),
Calin Juravle7a570e82017-01-14 16:23:30 -08002061 out_vdex_fd.get(),
Richard Uhler76cc0272016-12-08 10:46:35 +00002062 image_fd.get(),
Jeff Hao10b8a6e2017-04-05 17:11:39 -07002063 dex_path,
Richard Uhler76cc0272016-12-08 10:46:35 +00002064 out_oat_path,
2065 swap_fd.get(),
2066 instruction_set,
2067 compiler_filter,
Richard Uhler76cc0272016-12-08 10:46:35 +00002068 debuggable,
2069 boot_complete,
Andreas Gampea73a0cb2017-11-02 18:14:42 -07002070 background_job_compile,
Richard Uhler76cc0272016-12-08 10:46:35 +00002071 reference_profile_fd.get(),
David Brazdil570d3982018-01-16 20:15:43 +00002072 class_loader_context,
David Brazdil7fcbb812018-01-17 17:05:40 +00002073 target_sdk_version,
Calin Juravle62c5a372018-02-01 17:03:23 +00002074 enable_hidden_api_checks,
Calin Juravle2efc4022018-02-13 18:31:32 -08002075 dex_metadata_fd.get(),
2076 compilation_reason);
Jeff Sharkey90aff262016-12-12 14:28:24 -07002077 } else {
2078 int res = wait_child(pid);
2079 if (res == 0) {
Andreas Gampe023b2242018-02-28 16:03:25 -08002080 LOG(VERBOSE) << "DexInv: --- END '" << dex_path << "' (success) ---";
Jeff Sharkey90aff262016-12-12 14:28:24 -07002081 } else {
Andreas Gampe023b2242018-02-28 16:03:25 -08002082 LOG(VERBOSE) << "DexInv: --- END '" << dex_path << "' --- status=0x"
2083 << std::hex << std::setw(4) << res << ", process failed";
2084 *error_msg = format_dexopt_error(res, dex_path);
Andreas Gampe013f02e2017-03-20 18:36:54 -07002085 return res;
Jeff Sharkey90aff262016-12-12 14:28:24 -07002086 }
2087 }
2088
Calin Juravlec9eab382017-01-25 01:17:17 -08002089 update_out_oat_access_times(dex_path, out_oat_path);
Jeff Sharkey90aff262016-12-12 14:28:24 -07002090
2091 // We've been successful, don't delete output.
2092 out_oat_fd.SetCleanup(false);
Calin Juravle7a570e82017-01-14 16:23:30 -08002093 out_vdex_fd.SetCleanup(false);
Jeff Sharkey90aff262016-12-12 14:28:24 -07002094 image_fd.SetCleanup(false);
2095 reference_profile_fd.SetCleanup(false);
2096
2097 return 0;
2098}
2099
Calin Juravlec9eab382017-01-25 01:17:17 -08002100// Try to remove the given directory. Log an error if the directory exists
2101// and is empty but could not be removed.
2102static bool rmdir_if_empty(const char* dir) {
2103 if (rmdir(dir) == 0) {
2104 return true;
2105 }
2106 if (errno == ENOENT || errno == ENOTEMPTY) {
2107 return true;
2108 }
2109 PLOG(ERROR) << "Failed to remove dir: " << dir;
2110 return false;
2111}
2112
2113// Try to unlink the given file. Log an error if the file exists and could not
2114// be unlinked.
2115static bool unlink_if_exists(const std::string& file) {
2116 if (unlink(file.c_str()) == 0) {
2117 return true;
2118 }
2119 if (errno == ENOENT) {
2120 return true;
2121
2122 }
2123 PLOG(ERROR) << "Could not unlink: " << file;
2124 return false;
2125}
2126
Calin Juravle7d765462017-09-04 15:57:10 -07002127enum ReconcileSecondaryDexResult {
2128 kReconcileSecondaryDexExists = 0,
2129 kReconcileSecondaryDexCleanedUp = 1,
2130 kReconcileSecondaryDexValidationError = 2,
2131 kReconcileSecondaryDexCleanUpError = 3,
2132 kReconcileSecondaryDexAccessIOError = 4,
2133};
Calin Juravlec9eab382017-01-25 01:17:17 -08002134
2135// Reconcile the secondary dex 'dex_path' and its generated oat files.
2136// Return true if all the parameters are valid and the secondary dex file was
2137// processed successfully (i.e. the dex_path either exists, or if not, its corresponding
2138// oat/vdex/art files where deleted successfully). In this case, out_secondary_dex_exists
2139// will be true if the secondary dex file still exists. If the secondary dex file does not exist,
2140// the method cleans up any previously generated compiler artifacts (oat, vdex, art).
2141// Return false if there were errors during processing. In this case
2142// out_secondary_dex_exists will be set to false.
2143bool reconcile_secondary_dex_file(const std::string& dex_path,
2144 const std::string& pkgname, int uid, const std::vector<std::string>& isas,
2145 const std::unique_ptr<std::string>& volume_uuid, int storage_flag,
2146 /*out*/bool* out_secondary_dex_exists) {
Calin Juravle7d765462017-09-04 15:57:10 -07002147 *out_secondary_dex_exists = false; // start by assuming the file does not exist.
Calin Juravlec9eab382017-01-25 01:17:17 -08002148 if (isas.size() == 0) {
2149 LOG(ERROR) << "reconcile_secondary_dex_file called with empty isas vector";
2150 return false;
2151 }
2152
Calin Juravle7d765462017-09-04 15:57:10 -07002153 if (storage_flag != FLAG_STORAGE_CE && storage_flag != FLAG_STORAGE_DE) {
2154 LOG(ERROR) << "reconcile_secondary_dex_file called with invalid storage_flag: "
2155 << storage_flag;
Calin Juravlec9eab382017-01-25 01:17:17 -08002156 return false;
2157 }
2158
Shubham Ajmerae6d7ad52017-08-25 13:07:44 -07002159 // As a security measure we want to unlink art artifacts with the reduced capabilities
2160 // of the package user id. So we fork and drop capabilities in the child.
2161 pid_t pid = fork();
2162 if (pid == 0) {
Calin Juravle7d765462017-09-04 15:57:10 -07002163 /* child -- drop privileges before continuing */
2164 drop_capabilities(uid);
2165
2166 const char* volume_uuid_cstr = volume_uuid == nullptr ? nullptr : volume_uuid->c_str();
2167 if (!validate_secondary_dex_path(pkgname.c_str(), dex_path.c_str(), volume_uuid_cstr,
2168 uid, storage_flag)) {
2169 LOG(ERROR) << "Could not validate secondary dex path " << dex_path;
2170 _exit(kReconcileSecondaryDexValidationError);
2171 }
2172
2173 SecondaryDexAccess access_check = check_secondary_dex_access(dex_path);
2174 switch (access_check) {
2175 case kSecondaryDexAccessDoesNotExist:
2176 // File does not exist. Proceed with cleaning.
2177 break;
2178 case kSecondaryDexAccessReadOk: _exit(kReconcileSecondaryDexExists);
2179 case kSecondaryDexAccessIOError: _exit(kReconcileSecondaryDexAccessIOError);
2180 case kSecondaryDexAccessPermissionError: _exit(kReconcileSecondaryDexValidationError);
2181 default:
2182 LOG(ERROR) << "Unexpected result from check_secondary_dex_access: " << access_check;
2183 _exit(kReconcileSecondaryDexValidationError);
2184 }
2185
2186 // The secondary dex does not exist anymore or it's. Clear any generated files.
Shubham Ajmerae6d7ad52017-08-25 13:07:44 -07002187 char oat_path[PKG_PATH_MAX];
2188 char oat_dir[PKG_PATH_MAX];
2189 char oat_isa_dir[PKG_PATH_MAX];
2190 bool result = true;
Shubham Ajmerae6d7ad52017-08-25 13:07:44 -07002191 for (size_t i = 0; i < isas.size(); i++) {
Andreas Gampe194fe422018-02-28 20:16:19 -08002192 std::string error_msg;
Calin Juravle7d765462017-09-04 15:57:10 -07002193 if (!create_secondary_dex_oat_layout(
Andreas Gampe194fe422018-02-28 20:16:19 -08002194 dex_path,isas[i], oat_dir, oat_isa_dir, oat_path, &error_msg)) {
2195 LOG(ERROR) << error_msg;
Calin Juravle7d765462017-09-04 15:57:10 -07002196 _exit(kReconcileSecondaryDexValidationError);
Shubham Ajmerae6d7ad52017-08-25 13:07:44 -07002197 }
Calin Juravle51314092017-05-18 15:33:05 -07002198
Shubham Ajmerae6d7ad52017-08-25 13:07:44 -07002199 // Delete oat/vdex/art files.
2200 result = unlink_if_exists(oat_path) && result;
2201 result = unlink_if_exists(create_vdex_filename(oat_path)) && result;
2202 result = unlink_if_exists(create_image_filename(oat_path)) && result;
Calin Juravlec9eab382017-01-25 01:17:17 -08002203
Shubham Ajmerae6d7ad52017-08-25 13:07:44 -07002204 // Delete profiles.
2205 std::string current_profile = create_current_profile_path(
Calin Juravle824a64d2018-01-18 20:23:17 -08002206 multiuser_get_user_id(uid), pkgname, dex_path, /*is_secondary*/true);
Shubham Ajmerae6d7ad52017-08-25 13:07:44 -07002207 std::string reference_profile = create_reference_profile_path(
Calin Juravle824a64d2018-01-18 20:23:17 -08002208 pkgname, dex_path, /*is_secondary*/true);
Shubham Ajmerae6d7ad52017-08-25 13:07:44 -07002209 result = unlink_if_exists(current_profile) && result;
2210 result = unlink_if_exists(reference_profile) && result;
Calin Juravle51314092017-05-18 15:33:05 -07002211
Shubham Ajmerae6d7ad52017-08-25 13:07:44 -07002212 // We upgraded once the location of current profile for secondary dex files.
2213 // Check for any previous left-overs and remove them as well.
2214 std::string old_current_profile = dex_path + ".prof";
2215 result = unlink_if_exists(old_current_profile);
Calin Juravle3760ad32017-07-27 16:31:55 -07002216
Shubham Ajmerae6d7ad52017-08-25 13:07:44 -07002217 // Try removing the directories as well, they might be empty.
2218 result = rmdir_if_empty(oat_isa_dir) && result;
2219 result = rmdir_if_empty(oat_dir) && result;
2220 }
Calin Juravle7d765462017-09-04 15:57:10 -07002221 if (!result) {
2222 PLOG(ERROR) << "Failed to clean secondary dex artifacts for location " << dex_path;
2223 }
2224 _exit(result ? kReconcileSecondaryDexCleanedUp : kReconcileSecondaryDexAccessIOError);
Calin Juravlec9eab382017-01-25 01:17:17 -08002225 }
2226
Shubham Ajmerae6d7ad52017-08-25 13:07:44 -07002227 int return_code = wait_child(pid);
Calin Juravle7d765462017-09-04 15:57:10 -07002228 if (!WIFEXITED(return_code)) {
2229 LOG(WARNING) << "reconcile dex failed for location " << dex_path << ": " << return_code;
2230 } else {
2231 return_code = WEXITSTATUS(return_code);
2232 }
2233
2234 LOG(DEBUG) << "Reconcile secondary dex path " << dex_path << " result=" << return_code;
2235
2236 switch (return_code) {
2237 case kReconcileSecondaryDexCleanedUp:
2238 case kReconcileSecondaryDexValidationError:
2239 // If we couldn't validate assume the dex file does not exist.
2240 // This will purge the entry from the PM records.
2241 *out_secondary_dex_exists = false;
2242 return true;
2243 case kReconcileSecondaryDexExists:
2244 *out_secondary_dex_exists = true;
2245 return true;
2246 case kReconcileSecondaryDexAccessIOError:
2247 // We had an access IO error.
2248 // Return false so that we can try again.
2249 // The value of out_secondary_dex_exists does not matter in this case and by convention
2250 // is set to false.
2251 *out_secondary_dex_exists = false;
2252 return false;
2253 default:
2254 LOG(ERROR) << "Unexpected code from reconcile_secondary_dex_file: " << return_code;
2255 *out_secondary_dex_exists = false;
2256 return false;
2257 }
Calin Juravlec9eab382017-01-25 01:17:17 -08002258}
2259
Alan Stokesa25d90c2017-10-16 10:56:00 +01002260// Compute and return the hash (SHA-256) of the secondary dex file at dex_path.
2261// Returns true if all parameters are valid and the hash successfully computed and stored in
2262// out_secondary_dex_hash.
2263// Also returns true with an empty hash if the file does not currently exist or is not accessible to
2264// the app.
2265// For any other errors (e.g. if any of the parameters are invalid) returns false.
2266bool hash_secondary_dex_file(const std::string& dex_path, const std::string& pkgname, int uid,
2267 const std::unique_ptr<std::string>& volume_uuid, int storage_flag,
2268 std::vector<uint8_t>* out_secondary_dex_hash) {
2269 out_secondary_dex_hash->clear();
2270
2271 const char* volume_uuid_cstr = volume_uuid == nullptr ? nullptr : volume_uuid->c_str();
2272
2273 if (storage_flag != FLAG_STORAGE_CE && storage_flag != FLAG_STORAGE_DE) {
2274 LOG(ERROR) << "hash_secondary_dex_file called with invalid storage_flag: "
2275 << storage_flag;
2276 return false;
2277 }
2278
2279 // Pipe to get the hash result back from our child process.
2280 unique_fd pipe_read, pipe_write;
2281 if (!Pipe(&pipe_read, &pipe_write)) {
2282 PLOG(ERROR) << "Failed to create pipe";
2283 return false;
2284 }
2285
2286 // Fork so that actual access to the files is done in the app's own UID, to ensure we only
2287 // access data the app itself can access.
2288 pid_t pid = fork();
2289 if (pid == 0) {
2290 // child -- drop privileges before continuing
2291 drop_capabilities(uid);
2292 pipe_read.reset();
2293
2294 if (!validate_secondary_dex_path(pkgname, dex_path, volume_uuid_cstr, uid, storage_flag)) {
2295 LOG(ERROR) << "Could not validate secondary dex path " << dex_path;
Andreas Gampefa2dadd2018-02-28 19:52:47 -08002296 _exit(DexoptReturnCodes::kHashValidatePath);
Alan Stokesa25d90c2017-10-16 10:56:00 +01002297 }
2298
2299 unique_fd fd(TEMP_FAILURE_RETRY(open(dex_path.c_str(), O_RDONLY | O_CLOEXEC | O_NOFOLLOW)));
2300 if (fd == -1) {
2301 if (errno == EACCES || errno == ENOENT) {
2302 // Not treated as an error.
2303 _exit(0);
2304 }
2305 PLOG(ERROR) << "Failed to open secondary dex " << dex_path;
Andreas Gampefa2dadd2018-02-28 19:52:47 -08002306 _exit(DexoptReturnCodes::kHashOpenPath);
Alan Stokesa25d90c2017-10-16 10:56:00 +01002307 }
2308
2309 SHA256_CTX ctx;
2310 SHA256_Init(&ctx);
2311
2312 std::vector<uint8_t> buffer(65536);
2313 while (true) {
2314 ssize_t bytes_read = TEMP_FAILURE_RETRY(read(fd, buffer.data(), buffer.size()));
2315 if (bytes_read == 0) {
2316 break;
2317 } else if (bytes_read == -1) {
2318 PLOG(ERROR) << "Failed to read secondary dex " << dex_path;
Andreas Gampefa2dadd2018-02-28 19:52:47 -08002319 _exit(DexoptReturnCodes::kHashReadDex);
Alan Stokesa25d90c2017-10-16 10:56:00 +01002320 }
2321
2322 SHA256_Update(&ctx, buffer.data(), bytes_read);
2323 }
2324
2325 std::array<uint8_t, SHA256_DIGEST_LENGTH> hash;
2326 SHA256_Final(hash.data(), &ctx);
2327 if (!WriteFully(pipe_write, hash.data(), hash.size())) {
Andreas Gampefa2dadd2018-02-28 19:52:47 -08002328 _exit(DexoptReturnCodes::kHashWrite);
Alan Stokesa25d90c2017-10-16 10:56:00 +01002329 }
2330
2331 _exit(0);
2332 }
2333
2334 // parent
2335 pipe_write.reset();
2336
2337 out_secondary_dex_hash->resize(SHA256_DIGEST_LENGTH);
2338 if (!ReadFully(pipe_read, out_secondary_dex_hash->data(), out_secondary_dex_hash->size())) {
2339 out_secondary_dex_hash->clear();
2340 }
2341 return wait_child(pid) == 0;
2342}
2343
Jeff Sharkey90aff262016-12-12 14:28:24 -07002344// Helper for move_ab, so that we can have common failure-case cleanup.
2345static bool unlink_and_rename(const char* from, const char* to) {
2346 // Check whether "from" exists, and if so whether it's regular. If it is, unlink. Otherwise,
2347 // return a failure.
2348 struct stat s;
2349 if (stat(to, &s) == 0) {
2350 if (!S_ISREG(s.st_mode)) {
2351 LOG(ERROR) << from << " is not a regular file to replace for A/B.";
2352 return false;
2353 }
2354 if (unlink(to) != 0) {
2355 LOG(ERROR) << "Could not unlink " << to << " to move A/B.";
2356 return false;
2357 }
2358 } else {
2359 // This may be a permission problem. We could investigate the error code, but we'll just
2360 // let the rename failure do the work for us.
2361 }
2362
2363 // Try to rename "to" to "from."
2364 if (rename(from, to) != 0) {
2365 PLOG(ERROR) << "Could not rename " << from << " to " << to;
2366 return false;
2367 }
2368 return true;
2369}
2370
2371// Move/rename a B artifact (from) to an A artifact (to).
2372static bool move_ab_path(const std::string& b_path, const std::string& a_path) {
2373 // Check whether B exists.
2374 {
2375 struct stat s;
2376 if (stat(b_path.c_str(), &s) != 0) {
2377 // Silently ignore for now. The service calling this isn't smart enough to understand
2378 // lack of artifacts at the moment.
2379 return false;
2380 }
2381 if (!S_ISREG(s.st_mode)) {
2382 LOG(ERROR) << "A/B artifact " << b_path << " is not a regular file.";
2383 // Try to unlink, but swallow errors.
2384 unlink(b_path.c_str());
2385 return false;
2386 }
2387 }
2388
2389 // Rename B to A.
2390 if (!unlink_and_rename(b_path.c_str(), a_path.c_str())) {
2391 // Delete the b_path so we don't try again (or fail earlier).
2392 if (unlink(b_path.c_str()) != 0) {
2393 PLOG(ERROR) << "Could not unlink " << b_path;
2394 }
2395
2396 return false;
2397 }
2398
2399 return true;
2400}
2401
2402bool move_ab(const char* apk_path, const char* instruction_set, const char* oat_dir) {
2403 // Get the current slot suffix. No suffix, no A/B.
2404 std::string slot_suffix;
2405 {
2406 char buf[kPropertyValueMax];
2407 if (get_property("ro.boot.slot_suffix", buf, nullptr) <= 0) {
2408 return false;
2409 }
2410 slot_suffix = buf;
2411
2412 if (!ValidateTargetSlotSuffix(slot_suffix)) {
2413 LOG(ERROR) << "Target slot suffix not legal: " << slot_suffix;
2414 return false;
2415 }
2416 }
2417
2418 // Validate other inputs.
2419 if (validate_apk_path(apk_path) != 0) {
2420 LOG(ERROR) << "Invalid apk_path: " << apk_path;
2421 return false;
2422 }
2423 if (validate_apk_path(oat_dir) != 0) {
2424 LOG(ERROR) << "Invalid oat_dir: " << oat_dir;
2425 return false;
2426 }
2427
2428 char a_path[PKG_PATH_MAX];
2429 if (!calculate_oat_file_path(a_path, oat_dir, apk_path, instruction_set)) {
2430 return false;
2431 }
2432 const std::string a_vdex_path = create_vdex_filename(a_path);
2433 const std::string a_image_path = create_image_filename(a_path);
2434
2435 // B path = A path + slot suffix.
2436 const std::string b_path = StringPrintf("%s.%s", a_path, slot_suffix.c_str());
2437 const std::string b_vdex_path = StringPrintf("%s.%s", a_vdex_path.c_str(), slot_suffix.c_str());
2438 const std::string b_image_path = StringPrintf("%s.%s",
2439 a_image_path.c_str(),
2440 slot_suffix.c_str());
2441
2442 bool success = true;
2443 if (move_ab_path(b_path, a_path)) {
2444 if (move_ab_path(b_vdex_path, a_vdex_path)) {
2445 // Note: we can live without an app image. As such, ignore failure to move the image file.
2446 // If we decide to require the app image, or the app image being moved correctly,
2447 // then change accordingly.
2448 constexpr bool kIgnoreAppImageFailure = true;
2449
2450 if (!a_image_path.empty()) {
2451 if (!move_ab_path(b_image_path, a_image_path)) {
2452 unlink(a_image_path.c_str());
2453 if (!kIgnoreAppImageFailure) {
2454 success = false;
2455 }
2456 }
2457 }
2458 } else {
2459 // Cleanup: delete B image, ignore errors.
2460 unlink(b_image_path.c_str());
2461 success = false;
2462 }
2463 } else {
2464 // Cleanup: delete B image, ignore errors.
2465 unlink(b_vdex_path.c_str());
2466 unlink(b_image_path.c_str());
2467 success = false;
2468 }
2469 return success;
2470}
2471
2472bool delete_odex(const char* apk_path, const char* instruction_set, const char* oat_dir) {
2473 // Delete the oat/odex file.
2474 char out_path[PKG_PATH_MAX];
Calin Juravle80a21252017-01-17 14:43:25 -08002475 if (!create_oat_out_path(apk_path, instruction_set, oat_dir,
Calin Juravle114f0812017-03-08 19:05:07 -08002476 /*is_secondary_dex*/false, out_path)) {
Jeff Sharkey90aff262016-12-12 14:28:24 -07002477 return false;
2478 }
2479
2480 // In case of a permission failure report the issue. Otherwise just print a warning.
2481 auto unlink_and_check = [](const char* path) -> bool {
2482 int result = unlink(path);
2483 if (result != 0) {
2484 if (errno == EACCES || errno == EPERM) {
2485 PLOG(ERROR) << "Could not unlink " << path;
2486 return false;
2487 }
2488 PLOG(WARNING) << "Could not unlink " << path;
2489 }
2490 return true;
2491 };
2492
2493 // Delete the oat/odex file.
2494 bool return_value_oat = unlink_and_check(out_path);
2495
2496 // Derive and delete the app image.
2497 bool return_value_art = unlink_and_check(create_image_filename(out_path).c_str());
2498
Nicolas Geoffray192fb962017-05-25 13:58:06 +01002499 // Derive and delete the vdex file.
2500 bool return_value_vdex = unlink_and_check(create_vdex_filename(out_path).c_str());
2501
Jeff Sharkey90aff262016-12-12 14:28:24 -07002502 // Report success.
Nicolas Geoffray192fb962017-05-25 13:58:06 +01002503 return return_value_oat && return_value_art && return_value_vdex;
Jeff Sharkey90aff262016-12-12 14:28:24 -07002504}
2505
Jeff Sharkeyc1149c92017-09-21 14:51:09 -06002506static bool is_absolute_path(const std::string& path) {
2507 if (path.find('/') != 0 || path.find("..") != std::string::npos) {
2508 LOG(ERROR) << "Invalid absolute path " << path;
2509 return false;
2510 } else {
2511 return true;
2512 }
2513}
2514
2515static bool is_valid_instruction_set(const std::string& instruction_set) {
2516 // TODO: add explicit whitelisting of instruction sets
2517 if (instruction_set.find('/') != std::string::npos) {
2518 LOG(ERROR) << "Invalid instruction set " << instruction_set;
2519 return false;
2520 } else {
2521 return true;
2522 }
2523}
2524
2525bool calculate_oat_file_path_default(char path[PKG_PATH_MAX], const char *oat_dir,
2526 const char *apk_path, const char *instruction_set) {
2527 std::string oat_dir_ = oat_dir;
2528 std::string apk_path_ = apk_path;
2529 std::string instruction_set_ = instruction_set;
2530
2531 if (!is_absolute_path(oat_dir_)) return false;
2532 if (!is_absolute_path(apk_path_)) return false;
2533 if (!is_valid_instruction_set(instruction_set_)) return false;
2534
2535 std::string::size_type end = apk_path_.rfind('.');
2536 std::string::size_type start = apk_path_.rfind('/', end);
2537 if (end == std::string::npos || start == std::string::npos) {
2538 LOG(ERROR) << "Invalid apk_path " << apk_path_;
2539 return false;
2540 }
2541
2542 std::string res_ = oat_dir_ + '/' + instruction_set + '/'
2543 + apk_path_.substr(start + 1, end - start - 1) + ".odex";
2544 const char* res = res_.c_str();
2545 if (strlen(res) >= PKG_PATH_MAX) {
2546 LOG(ERROR) << "Result too large";
2547 return false;
2548 } else {
2549 strlcpy(path, res, PKG_PATH_MAX);
2550 return true;
2551 }
2552}
2553
2554bool calculate_odex_file_path_default(char path[PKG_PATH_MAX], const char *apk_path,
2555 const char *instruction_set) {
2556 std::string apk_path_ = apk_path;
2557 std::string instruction_set_ = instruction_set;
2558
2559 if (!is_absolute_path(apk_path_)) return false;
2560 if (!is_valid_instruction_set(instruction_set_)) return false;
2561
2562 std::string::size_type end = apk_path_.rfind('.');
2563 std::string::size_type start = apk_path_.rfind('/', end);
2564 if (end == std::string::npos || start == std::string::npos) {
2565 LOG(ERROR) << "Invalid apk_path " << apk_path_;
2566 return false;
2567 }
2568
2569 std::string oat_dir = apk_path_.substr(0, start + 1) + "oat";
2570 return calculate_oat_file_path_default(path, oat_dir.c_str(), apk_path, instruction_set);
2571}
2572
2573bool create_cache_path_default(char path[PKG_PATH_MAX], const char *src,
2574 const char *instruction_set) {
2575 std::string src_ = src;
2576 std::string instruction_set_ = instruction_set;
2577
2578 if (!is_absolute_path(src_)) return false;
2579 if (!is_valid_instruction_set(instruction_set_)) return false;
2580
2581 for (auto it = src_.begin() + 1; it < src_.end(); ++it) {
2582 if (*it == '/') {
2583 *it = '@';
2584 }
2585 }
2586
2587 std::string res_ = android_data_dir + DALVIK_CACHE + '/' + instruction_set_ + src_
2588 + DALVIK_CACHE_POSTFIX;
2589 const char* res = res_.c_str();
2590 if (strlen(res) >= PKG_PATH_MAX) {
2591 LOG(ERROR) << "Result too large";
2592 return false;
2593 } else {
2594 strlcpy(path, res, PKG_PATH_MAX);
2595 return true;
2596 }
2597}
2598
Calin Juravle0d0a4922018-01-23 19:54:11 -08002599bool open_classpath_files(const std::string& classpath, std::vector<unique_fd>* apk_fds) {
2600 std::vector<std::string> classpaths_elems = base::Split(classpath, ":");
2601 for (const std::string& elem : classpaths_elems) {
2602 unique_fd fd(TEMP_FAILURE_RETRY(open(elem.c_str(), O_RDONLY)));
2603 if (fd < 0) {
2604 PLOG(ERROR) << "Could not open classpath elem " << elem;
2605 return false;
2606 } else {
2607 apk_fds->push_back(std::move(fd));
2608 }
2609 }
2610 return true;
2611}
2612
2613static bool create_app_profile_snapshot(int32_t app_id,
2614 const std::string& package_name,
2615 const std::string& profile_name,
2616 const std::string& classpath) {
Calin Juravle29591732017-11-20 17:46:19 -08002617 int app_shared_gid = multiuser_get_shared_gid(/*user_id*/ 0, app_id);
2618
Calin Juravle824a64d2018-01-18 20:23:17 -08002619 unique_fd snapshot_fd = open_spnashot_profile(AID_SYSTEM, package_name, profile_name);
Calin Juravle29591732017-11-20 17:46:19 -08002620 if (snapshot_fd < 0) {
2621 return false;
2622 }
2623
2624 std::vector<unique_fd> profiles_fd;
2625 unique_fd reference_profile_fd;
Calin Juravle824a64d2018-01-18 20:23:17 -08002626 open_profile_files(app_shared_gid, package_name, profile_name, /*is_secondary_dex*/ false,
2627 &profiles_fd, &reference_profile_fd);
Calin Juravle29591732017-11-20 17:46:19 -08002628 if (profiles_fd.empty() || (reference_profile_fd.get() < 0)) {
2629 return false;
2630 }
2631
2632 profiles_fd.push_back(std::move(reference_profile_fd));
2633
Calin Juravle0d0a4922018-01-23 19:54:11 -08002634 // Open the class paths elements. These will be used to filter out profile data that does
2635 // not belong to the classpath during merge.
2636 std::vector<unique_fd> apk_fds;
2637 if (!open_classpath_files(classpath, &apk_fds)) {
2638 return false;
2639 }
2640
Calin Juravle29591732017-11-20 17:46:19 -08002641 pid_t pid = fork();
2642 if (pid == 0) {
2643 /* child -- drop privileges before continuing */
2644 drop_capabilities(app_shared_gid);
Calin Juravle0d0a4922018-01-23 19:54:11 -08002645 run_profman_merge(profiles_fd, snapshot_fd, &apk_fds);
Calin Juravle29591732017-11-20 17:46:19 -08002646 }
2647
2648 /* parent */
2649 int return_code = wait_child(pid);
2650 if (!WIFEXITED(return_code)) {
Calin Juravle824a64d2018-01-18 20:23:17 -08002651 LOG(WARNING) << "profman failed for " << package_name << ":" << profile_name;
Calin Juravle29591732017-11-20 17:46:19 -08002652 return false;
2653 }
2654
2655 return true;
2656}
2657
Calin Juravle0d0a4922018-01-23 19:54:11 -08002658static bool create_boot_image_profile_snapshot(const std::string& package_name,
2659 const std::string& profile_name,
2660 const std::string& classpath) {
2661 // The reference profile directory for the android package might not be prepared. Do it now.
2662 const std::string ref_profile_dir =
2663 create_primary_reference_profile_package_dir_path(package_name);
2664 if (fs_prepare_dir(ref_profile_dir.c_str(), 0770, AID_SYSTEM, AID_SYSTEM) != 0) {
2665 PLOG(ERROR) << "Failed to prepare " << ref_profile_dir;
2666 return false;
2667 }
2668
2669 // Open and create the snapshot profile.
2670 unique_fd snapshot_fd = open_spnashot_profile(AID_SYSTEM, package_name, profile_name);
2671
2672 // Collect all non empty profiles.
2673 // The collection will traverse all applications profiles and find the non empty files.
2674 // This has the potential of inspecting a large number of files and directories (depending
2675 // on the number of applications and users). So there is a slight increase in the chance
2676 // to get get occasionally I/O errors (e.g. for opening the file). When that happens do not
2677 // fail the snapshot and aggregate whatever profile we could open.
2678 //
2679 // The profile snapshot is a best effort based on available data it's ok if some data
2680 // from some apps is missing. It will be counter productive for the snapshot to fail
2681 // because we could not open or read some of the files.
2682 std::vector<std::string> profiles;
2683 if (!collect_profiles(&profiles)) {
2684 LOG(WARNING) << "There were errors while collecting the profiles for the boot image.";
2685 }
2686
2687 // If we have no profiles return early.
2688 if (profiles.empty()) {
2689 return true;
2690 }
2691
2692 // Open the classpath elements. These will be used to filter out profile data that does
2693 // not belong to the classpath during merge.
2694 std::vector<unique_fd> apk_fds;
2695 if (!open_classpath_files(classpath, &apk_fds)) {
2696 return false;
2697 }
2698
2699 // If we could not open any files from the classpath return an error.
2700 if (apk_fds.empty()) {
2701 LOG(ERROR) << "Could not open any of the classpath elements.";
2702 return false;
2703 }
2704
2705 // Aggregate the profiles in batches of kAggregationBatchSize.
2706 // We do this to avoid opening a huge a amount of files.
2707 static constexpr size_t kAggregationBatchSize = 10;
2708
2709 std::vector<unique_fd> profiles_fd;
2710 for (size_t i = 0; i < profiles.size(); ) {
2711 for (size_t k = 0; k < kAggregationBatchSize && i < profiles.size(); k++, i++) {
2712 unique_fd fd = open_profile(AID_SYSTEM, profiles[i], O_RDONLY);
2713 if (fd.get() >= 0) {
2714 profiles_fd.push_back(std::move(fd));
2715 }
2716 }
2717 pid_t pid = fork();
2718 if (pid == 0) {
2719 /* child -- drop privileges before continuing */
2720 drop_capabilities(AID_SYSTEM);
2721
2722 run_profman_merge(profiles_fd, snapshot_fd, &apk_fds);
Calin Juravle0d0a4922018-01-23 19:54:11 -08002723 }
2724
2725 /* parent */
2726 int return_code = wait_child(pid);
2727 if (!WIFEXITED(return_code)) {
2728 PLOG(WARNING) << "profman failed for " << package_name << ":" << profile_name;
2729 return false;
2730 }
2731 return true;
2732 }
2733 return true;
2734}
2735
2736bool create_profile_snapshot(int32_t app_id, const std::string& package_name,
2737 const std::string& profile_name, const std::string& classpath) {
2738 if (app_id == -1) {
2739 return create_boot_image_profile_snapshot(package_name, profile_name, classpath);
2740 } else {
2741 return create_app_profile_snapshot(app_id, package_name, profile_name, classpath);
2742 }
2743}
2744
Calin Juravlec3b049e2018-01-18 22:32:58 -08002745bool prepare_app_profile(const std::string& package_name,
2746 userid_t user_id,
2747 appid_t app_id,
2748 const std::string& profile_name,
Calin Juravlef63d4792018-01-30 17:43:34 +00002749 const std::string& code_path,
Calin Juravlec3b049e2018-01-18 22:32:58 -08002750 const std::unique_ptr<std::string>& dex_metadata) {
2751 // Prepare the current profile.
2752 std::string cur_profile = create_current_profile_path(user_id, package_name, profile_name,
2753 /*is_secondary_dex*/ false);
2754 uid_t uid = multiuser_get_uid(user_id, app_id);
2755 if (fs_prepare_file_strict(cur_profile.c_str(), 0600, uid, uid) != 0) {
2756 PLOG(ERROR) << "Failed to prepare " << cur_profile;
2757 return false;
2758 }
2759
2760 // Check if we need to install the profile from the dex metadata.
2761 if (dex_metadata == nullptr) {
2762 return true;
2763 }
2764
2765 // We have a dex metdata. Merge the profile into the reference profile.
2766 unique_fd ref_profile_fd = open_reference_profile(uid, package_name, profile_name,
2767 /*read_write*/ true, /*is_secondary_dex*/ false);
2768 unique_fd dex_metadata_fd(TEMP_FAILURE_RETRY(
2769 open(dex_metadata->c_str(), O_RDONLY | O_NOFOLLOW)));
Calin Juravlef63d4792018-01-30 17:43:34 +00002770 unique_fd apk_fd(TEMP_FAILURE_RETRY(open(code_path.c_str(), O_RDONLY | O_NOFOLLOW)));
2771 if (apk_fd < 0) {
2772 PLOG(ERROR) << "Could not open code path " << code_path;
2773 return false;
2774 }
Calin Juravlec3b049e2018-01-18 22:32:58 -08002775
2776 pid_t pid = fork();
2777 if (pid == 0) {
2778 /* child -- drop privileges before continuing */
2779 gid_t app_shared_gid = multiuser_get_shared_gid(user_id, app_id);
2780 drop_capabilities(app_shared_gid);
2781
Calin Juravlef63d4792018-01-30 17:43:34 +00002782 // The copy and update takes ownership over the fds.
2783 run_profman_copy_and_update(std::move(dex_metadata_fd),
2784 std::move(ref_profile_fd),
2785 std::move(apk_fd));
Calin Juravlec3b049e2018-01-18 22:32:58 -08002786 }
2787
2788 /* parent */
2789 int return_code = wait_child(pid);
2790 if (!WIFEXITED(return_code)) {
2791 PLOG(WARNING) << "profman failed for " << package_name << ":" << profile_name;
2792 return false;
2793 }
2794 return true;
2795}
2796
Jeff Sharkey6c2c0562016-12-07 12:12:00 -07002797} // namespace installd
2798} // namespace android