Calin Juravle | 7d76546 | 2017-09-04 15:57:10 -0700 | [diff] [blame] | 1 | /* |
| 2 | * Copyright (C) 2017 The Android Open Source Project |
| 3 | * |
| 4 | * Licensed under the Apache License, Version 2.0 (the "License"); |
| 5 | * you may not use this file except in compliance with the License. |
| 6 | * You may obtain a copy of the License at |
| 7 | * |
| 8 | * http://www.apache.org/licenses/LICENSE-2.0 |
| 9 | * |
| 10 | * Unless required by applicable law or agreed to in writing, software |
| 11 | * distributed under the License is distributed on an "AS IS" BASIS, |
| 12 | * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
| 13 | * See the License for the specific language governing permissions and |
| 14 | * limitations under the License. |
| 15 | */ |
| 16 | |
Calin Juravle | 0d0a492 | 2018-01-23 19:54:11 -0800 | [diff] [blame] | 17 | #include <cstdlib> |
Calin Juravle | 2959173 | 2017-11-20 17:46:19 -0800 | [diff] [blame] | 18 | #include <fcntl.h> |
Calin Juravle | 7d76546 | 2017-09-04 15:57:10 -0700 | [diff] [blame] | 19 | #include <stdlib.h> |
| 20 | #include <string.h> |
Calin Juravle | 2959173 | 2017-11-20 17:46:19 -0800 | [diff] [blame] | 21 | #include <sys/types.h> |
| 22 | #include <sys/stat.h> |
Calin Juravle | 7d76546 | 2017-09-04 15:57:10 -0700 | [diff] [blame] | 23 | |
Calin Juravle | 2959173 | 2017-11-20 17:46:19 -0800 | [diff] [blame] | 24 | #include <android-base/file.h> |
Calin Juravle | 7d76546 | 2017-09-04 15:57:10 -0700 | [diff] [blame] | 25 | #include <android-base/logging.h> |
| 26 | #include <android-base/stringprintf.h> |
Calin Juravle | 2959173 | 2017-11-20 17:46:19 -0800 | [diff] [blame] | 27 | #include <android-base/unique_fd.h> |
| 28 | |
Calin Juravle | 7d76546 | 2017-09-04 15:57:10 -0700 | [diff] [blame] | 29 | #include <cutils/properties.h> |
Calin Juravle | 2959173 | 2017-11-20 17:46:19 -0800 | [diff] [blame] | 30 | |
Calin Juravle | 7d76546 | 2017-09-04 15:57:10 -0700 | [diff] [blame] | 31 | #include <gtest/gtest.h> |
| 32 | |
Calin Juravle | 2959173 | 2017-11-20 17:46:19 -0800 | [diff] [blame] | 33 | #include <selinux/android.h> |
| 34 | #include <selinux/avc.h> |
| 35 | |
Calin Juravle | 7d76546 | 2017-09-04 15:57:10 -0700 | [diff] [blame] | 36 | #include "dexopt.h" |
| 37 | #include "InstalldNativeService.h" |
| 38 | #include "globals.h" |
| 39 | #include "tests/test_utils.h" |
| 40 | #include "utils.h" |
| 41 | |
Calin Juravle | 2959173 | 2017-11-20 17:46:19 -0800 | [diff] [blame] | 42 | using android::base::ReadFully; |
| 43 | using android::base::unique_fd; |
| 44 | |
Calin Juravle | 7d76546 | 2017-09-04 15:57:10 -0700 | [diff] [blame] | 45 | namespace android { |
| 46 | namespace installd { |
| 47 | |
| 48 | // TODO(calin): try to dedup this code. |
| 49 | #if defined(__arm__) |
| 50 | static const std::string kRuntimeIsa = "arm"; |
| 51 | #elif defined(__aarch64__) |
| 52 | static const std::string kRuntimeIsa = "arm64"; |
| 53 | #elif defined(__mips__) && !defined(__LP64__) |
| 54 | static const std::string kRuntimeIsa = "mips"; |
| 55 | #elif defined(__mips__) && defined(__LP64__) |
| 56 | static const std::string kRuntimeIsa = "mips64"; |
| 57 | #elif defined(__i386__) |
| 58 | static const std::string kRuntimeIsa = "x86"; |
| 59 | #elif defined(__x86_64__) |
| 60 | static const std::string kRuntimeIsa = "x86_64"; |
| 61 | #else |
| 62 | static const std::string kRuntimeIsa = "none"; |
| 63 | #endif |
| 64 | |
| 65 | int get_property(const char *key, char *value, const char *default_value) { |
| 66 | return property_get(key, value, default_value); |
| 67 | } |
| 68 | |
| 69 | bool calculate_oat_file_path(char path[PKG_PATH_MAX], const char *oat_dir, const char *apk_path, |
| 70 | const char *instruction_set) { |
| 71 | return calculate_oat_file_path_default(path, oat_dir, apk_path, instruction_set); |
| 72 | } |
| 73 | |
| 74 | bool calculate_odex_file_path(char path[PKG_PATH_MAX], const char *apk_path, |
| 75 | const char *instruction_set) { |
| 76 | return calculate_odex_file_path_default(path, apk_path, instruction_set); |
| 77 | } |
| 78 | |
| 79 | bool create_cache_path(char path[PKG_PATH_MAX], const char *src, const char *instruction_set) { |
| 80 | return create_cache_path_default(path, src, instruction_set); |
| 81 | } |
| 82 | |
| 83 | static void run_cmd(const std::string& cmd) { |
| 84 | system(cmd.c_str()); |
| 85 | } |
| 86 | |
| 87 | static void mkdir(const std::string& path, uid_t owner, gid_t group, mode_t mode) { |
| 88 | ::mkdir(path.c_str(), mode); |
| 89 | ::chown(path.c_str(), owner, group); |
| 90 | ::chmod(path.c_str(), mode); |
| 91 | } |
| 92 | |
Calin Juravle | 2959173 | 2017-11-20 17:46:19 -0800 | [diff] [blame] | 93 | static int log_callback(int type, const char *fmt, ...) { // NOLINT |
| 94 | va_list ap; |
| 95 | int priority; |
| 96 | |
| 97 | switch (type) { |
| 98 | case SELINUX_WARNING: |
| 99 | priority = ANDROID_LOG_WARN; |
| 100 | break; |
| 101 | case SELINUX_INFO: |
| 102 | priority = ANDROID_LOG_INFO; |
| 103 | break; |
| 104 | default: |
| 105 | priority = ANDROID_LOG_ERROR; |
| 106 | break; |
| 107 | } |
| 108 | va_start(ap, fmt); |
| 109 | LOG_PRI_VA(priority, "SELinux", fmt, ap); |
| 110 | va_end(ap); |
| 111 | return 0; |
| 112 | } |
| 113 | |
| 114 | static bool init_selinux() { |
| 115 | int selinux_enabled = (is_selinux_enabled() > 0); |
| 116 | |
| 117 | union selinux_callback cb; |
| 118 | cb.func_log = log_callback; |
| 119 | selinux_set_callback(SELINUX_CB_LOG, cb); |
| 120 | |
| 121 | if (selinux_enabled && selinux_status_open(true) < 0) { |
| 122 | LOG(ERROR) << "Could not open selinux status; exiting"; |
| 123 | return false; |
| 124 | } |
| 125 | |
| 126 | return true; |
| 127 | } |
| 128 | |
Calin Juravle | 7d76546 | 2017-09-04 15:57:10 -0700 | [diff] [blame] | 129 | // Base64 encoding of a simple dex files with 2 methods. |
| 130 | static const char kDexFile[] = |
| 131 | "UEsDBBQAAAAIAOiOYUs9y6BLCgEAABQCAAALABwAY2xhc3Nlcy5kZXhVVAkAA/Ns+lkOHv1ZdXgL" |
| 132 | "AAEEI+UCAASIEwAAS0mt4DIwNmX4qpn7j/2wA7v7N+ZvoQpCJRlVx5SWa4YaiDAxMBQwMDBUhJkI" |
| 133 | "MUBBDyMDAzsDRJwFxAdioBDDHAYEYAbiFUAM1M5wAIhFGCGKDIDYAogdgNgDiH2BOAiI0xghekDm" |
| 134 | "sQIxGxQzM6ACRijNhCbOhCZfyohdPYyuh8szgtVkMkLsLhAAqeCDi+ejibPZZOZlltgxsDnqZSWW" |
| 135 | "JTKwOUFoZh9HayDhZM0g5AMS0M9JzEvX90/KSk0usWZgDAMaws5nAyXBzmpoYGlgAjsAyJoBMp0b" |
| 136 | "zQ8gGhbOTEhhzYwU3qxIYc2GFN6MClC/AhUyKUDMAYU9M1Qc5F8GKBscVgIQM0FxCwBQSwECHgMU" |
| 137 | "AAAACADojmFLPcugSwoBAAAUAgAACwAYAAAAAAAAAAAAoIEAAAAAY2xhc3Nlcy5kZXhVVAUAA/Ns" |
| 138 | "+ll1eAsAAQQj5QIABIgTAABQSwUGAAAAAAEAAQBRAAAATwEAAAAA"; |
| 139 | |
| 140 | |
| 141 | class DexoptTest : public testing::Test { |
| 142 | protected: |
| 143 | static constexpr bool kDebug = false; |
| 144 | static constexpr uid_t kSystemUid = 1000; |
| 145 | static constexpr uid_t kSystemGid = 1000; |
| 146 | static constexpr int32_t kOSdkVersion = 25; |
| 147 | static constexpr int32_t kAppDataFlags = FLAG_STORAGE_CE | FLAG_STORAGE_DE; |
Calin Juravle | 7d76546 | 2017-09-04 15:57:10 -0700 | [diff] [blame] | 148 | static constexpr int32_t kTestUserId = 0; |
Calin Juravle | d2affb8 | 2017-11-28 17:41:43 -0800 | [diff] [blame] | 149 | static constexpr uid_t kTestAppId = 19999; |
| 150 | |
| 151 | const gid_t kTestAppUid = multiuser_get_uid(kTestUserId, kTestAppId); |
| 152 | const uid_t kTestAppGid = multiuser_get_shared_gid(kTestUserId, kTestAppId); |
Calin Juravle | 7d76546 | 2017-09-04 15:57:10 -0700 | [diff] [blame] | 153 | |
| 154 | InstalldNativeService* service_; |
| 155 | std::unique_ptr<std::string> volume_uuid_; |
| 156 | std::string package_name_; |
Calin Juravle | 0d0a492 | 2018-01-23 19:54:11 -0800 | [diff] [blame] | 157 | std::string apk_path_; |
Calin Juravle | 7d76546 | 2017-09-04 15:57:10 -0700 | [diff] [blame] | 158 | std::string app_apk_dir_; |
| 159 | std::string app_private_dir_ce_; |
| 160 | std::string app_private_dir_de_; |
| 161 | std::string se_info_; |
Calin Juravle | c4f6a0b | 2018-02-01 01:27:24 +0000 | [diff] [blame] | 162 | std::string app_oat_dir_; |
Calin Juravle | 7d76546 | 2017-09-04 15:57:10 -0700 | [diff] [blame] | 163 | |
| 164 | int64_t ce_data_inode_; |
| 165 | |
| 166 | std::string secondary_dex_ce_; |
| 167 | std::string secondary_dex_ce_link_; |
| 168 | std::string secondary_dex_de_; |
| 169 | |
| 170 | virtual void SetUp() { |
| 171 | setenv("ANDROID_LOG_TAGS", "*:v", 1); |
| 172 | android::base::InitLogging(nullptr); |
Calin Juravle | 2959173 | 2017-11-20 17:46:19 -0800 | [diff] [blame] | 173 | // Initialize the globals holding the file system main paths (/data/, /system/ etc..). |
| 174 | // This is needed in order to compute the application and profile paths. |
| 175 | ASSERT_TRUE(init_globals_from_data_and_root()); |
| 176 | // Initialize selinux log callbacks. |
| 177 | // This ensures that selinux is up and running and re-directs the selinux messages |
| 178 | // to logcat (in order to make it easier to investigate test results). |
| 179 | ASSERT_TRUE(init_selinux()); |
Calin Juravle | 7d76546 | 2017-09-04 15:57:10 -0700 | [diff] [blame] | 180 | service_ = new InstalldNativeService(); |
| 181 | |
| 182 | volume_uuid_ = nullptr; |
| 183 | package_name_ = "com.installd.test.dexopt"; |
| 184 | se_info_ = "default"; |
Calin Juravle | 7d76546 | 2017-09-04 15:57:10 -0700 | [diff] [blame] | 185 | app_apk_dir_ = android_app_dir + package_name_; |
| 186 | |
| 187 | create_mock_app(); |
| 188 | } |
| 189 | |
| 190 | virtual void TearDown() { |
| 191 | if (!kDebug) { |
| 192 | service_->destroyAppData( |
| 193 | volume_uuid_, package_name_, kTestUserId, kAppDataFlags, ce_data_inode_); |
| 194 | run_cmd("rm -rf " + app_apk_dir_); |
| 195 | run_cmd("rm -rf " + app_private_dir_ce_); |
| 196 | run_cmd("rm -rf " + app_private_dir_de_); |
| 197 | } |
| 198 | delete service_; |
| 199 | } |
| 200 | |
| 201 | void create_mock_app() { |
| 202 | // Create the oat dir. |
Calin Juravle | c4f6a0b | 2018-02-01 01:27:24 +0000 | [diff] [blame] | 203 | app_oat_dir_ = app_apk_dir_ + "/oat"; |
Calin Juravle | 7d76546 | 2017-09-04 15:57:10 -0700 | [diff] [blame] | 204 | mkdir(app_apk_dir_, kSystemUid, kSystemGid, 0755); |
Calin Juravle | c4f6a0b | 2018-02-01 01:27:24 +0000 | [diff] [blame] | 205 | service_->createOatDir(app_oat_dir_, kRuntimeIsa); |
Calin Juravle | 7d76546 | 2017-09-04 15:57:10 -0700 | [diff] [blame] | 206 | |
| 207 | // Copy the primary apk. |
Calin Juravle | 0d0a492 | 2018-01-23 19:54:11 -0800 | [diff] [blame] | 208 | apk_path_ = app_apk_dir_ + "/base.jar"; |
| 209 | ASSERT_TRUE(WriteBase64ToFile(kDexFile, apk_path_, kSystemUid, kSystemGid, 0644)); |
Calin Juravle | 7d76546 | 2017-09-04 15:57:10 -0700 | [diff] [blame] | 210 | |
| 211 | // Create the app user data. |
| 212 | ASSERT_TRUE(service_->createAppData( |
| 213 | volume_uuid_, |
| 214 | package_name_, |
| 215 | kTestUserId, |
| 216 | kAppDataFlags, |
| 217 | kTestAppUid, |
| 218 | se_info_, |
| 219 | kOSdkVersion, |
| 220 | &ce_data_inode_).isOk()); |
| 221 | |
| 222 | // Create a secondary dex file on CE storage |
| 223 | const char* volume_uuid_cstr = volume_uuid_ == nullptr ? nullptr : volume_uuid_->c_str(); |
| 224 | app_private_dir_ce_ = create_data_user_ce_package_path( |
| 225 | volume_uuid_cstr, kTestUserId, package_name_.c_str()); |
| 226 | secondary_dex_ce_ = app_private_dir_ce_ + "/secondary_ce.jar"; |
| 227 | ASSERT_TRUE(WriteBase64ToFile(kDexFile, secondary_dex_ce_, kTestAppUid, kTestAppGid, 0600)); |
| 228 | std::string app_private_dir_ce_link = create_data_user_ce_package_path_as_user_link( |
| 229 | volume_uuid_cstr, kTestUserId, package_name_.c_str()); |
| 230 | secondary_dex_ce_link_ = app_private_dir_ce_link + "/secondary_ce.jar"; |
| 231 | |
| 232 | // Create a secondary dex file on DE storage. |
| 233 | app_private_dir_de_ = create_data_user_de_package_path( |
| 234 | volume_uuid_cstr, kTestUserId, package_name_.c_str()); |
| 235 | secondary_dex_de_ = app_private_dir_de_ + "/secondary_de.jar"; |
| 236 | ASSERT_TRUE(WriteBase64ToFile(kDexFile, secondary_dex_de_, kTestAppUid, kTestAppGid, 0600)); |
| 237 | |
| 238 | // Fix app data uid. |
| 239 | ASSERT_TRUE(service_->fixupAppData(volume_uuid_, kTestUserId).isOk()); |
| 240 | } |
| 241 | |
| 242 | |
Calin Juravle | 2959173 | 2017-11-20 17:46:19 -0800 | [diff] [blame] | 243 | std::string GetSecondaryDexArtifact(const std::string& path, const std::string& type) { |
Calin Juravle | 7d76546 | 2017-09-04 15:57:10 -0700 | [diff] [blame] | 244 | std::string::size_type end = path.rfind('.'); |
| 245 | std::string::size_type start = path.rfind('/', end); |
| 246 | return path.substr(0, start) + "/oat/" + kRuntimeIsa + "/" + |
| 247 | path.substr(start + 1, end - start) + type; |
| 248 | } |
| 249 | |
Calin Juravle | 2959173 | 2017-11-20 17:46:19 -0800 | [diff] [blame] | 250 | void CompileSecondaryDex(const std::string& path, int32_t dex_storage_flag, |
Calin Juravle | 7d76546 | 2017-09-04 15:57:10 -0700 | [diff] [blame] | 251 | bool should_binder_call_succeed, bool should_dex_be_compiled = true, |
Calin Juravle | d2affb8 | 2017-11-28 17:41:43 -0800 | [diff] [blame] | 252 | int32_t uid = -1) { |
| 253 | if (uid == -1) { |
| 254 | uid = kTestAppUid; |
| 255 | } |
Calin Juravle | 7d76546 | 2017-09-04 15:57:10 -0700 | [diff] [blame] | 256 | std::unique_ptr<std::string> package_name_ptr(new std::string(package_name_)); |
| 257 | int32_t dexopt_needed = 0; // does not matter; |
| 258 | std::unique_ptr<std::string> out_path = nullptr; // does not matter |
| 259 | int32_t dex_flags = DEXOPT_SECONDARY_DEX | dex_storage_flag; |
| 260 | std::string compiler_filter = "speed-profile"; |
| 261 | std::unique_ptr<std::string> class_loader_context_ptr(new std::string("&")); |
| 262 | std::unique_ptr<std::string> se_info_ptr(new std::string(se_info_)); |
| 263 | bool downgrade = false; |
David Brazdil | 570d398 | 2018-01-16 20:15:43 +0000 | [diff] [blame] | 264 | int32_t target_sdk_version = 0; // default |
Calin Juravle | c4f6a0b | 2018-02-01 01:27:24 +0000 | [diff] [blame] | 265 | std::unique_ptr<std::string> profile_name_ptr = nullptr; |
Calin Juravle | 62c5a37 | 2018-02-01 17:03:23 +0000 | [diff] [blame] | 266 | std::unique_ptr<std::string> dm_path_ptr = nullptr; |
Calin Juravle | 2efc402 | 2018-02-13 18:31:32 -0800 | [diff] [blame] | 267 | std::unique_ptr<std::string> compilation_reason_ptr = nullptr; |
Calin Juravle | 7d76546 | 2017-09-04 15:57:10 -0700 | [diff] [blame] | 268 | |
| 269 | binder::Status result = service_->dexopt(path, |
| 270 | uid, |
| 271 | package_name_ptr, |
| 272 | kRuntimeIsa, |
| 273 | dexopt_needed, |
| 274 | out_path, |
| 275 | dex_flags, |
| 276 | compiler_filter, |
| 277 | volume_uuid_, |
| 278 | class_loader_context_ptr, |
| 279 | se_info_ptr, |
David Brazdil | 570d398 | 2018-01-16 20:15:43 +0000 | [diff] [blame] | 280 | downgrade, |
Calin Juravle | 408cd4a | 2018-01-20 23:34:18 -0800 | [diff] [blame] | 281 | target_sdk_version, |
Calin Juravle | 62c5a37 | 2018-02-01 17:03:23 +0000 | [diff] [blame] | 282 | profile_name_ptr, |
Calin Juravle | 2efc402 | 2018-02-13 18:31:32 -0800 | [diff] [blame] | 283 | dm_path_ptr, |
| 284 | compilation_reason_ptr); |
Andreas Gampe | f6a93b1 | 2018-02-27 09:51:15 -0800 | [diff] [blame] | 285 | ASSERT_EQ(should_binder_call_succeed, result.isOk()) << result.toString8().c_str(); |
Calin Juravle | 7d76546 | 2017-09-04 15:57:10 -0700 | [diff] [blame] | 286 | int expected_access = should_dex_be_compiled ? 0 : -1; |
Calin Juravle | 2959173 | 2017-11-20 17:46:19 -0800 | [diff] [blame] | 287 | std::string odex = GetSecondaryDexArtifact(path, "odex"); |
| 288 | std::string vdex = GetSecondaryDexArtifact(path, "vdex"); |
| 289 | std::string art = GetSecondaryDexArtifact(path, "art"); |
Calin Juravle | 7d76546 | 2017-09-04 15:57:10 -0700 | [diff] [blame] | 290 | ASSERT_EQ(expected_access, access(odex.c_str(), R_OK)); |
| 291 | ASSERT_EQ(expected_access, access(vdex.c_str(), R_OK)); |
| 292 | ASSERT_EQ(-1, access(art.c_str(), R_OK)); // empty profiles do not generate an image. |
| 293 | } |
| 294 | |
| 295 | void reconcile_secondary_dex(const std::string& path, int32_t storage_flag, |
| 296 | bool should_binder_call_succeed, bool should_dex_exist, bool should_dex_be_deleted, |
Calin Juravle | d2affb8 | 2017-11-28 17:41:43 -0800 | [diff] [blame] | 297 | int32_t uid = -1, std::string* package_override = nullptr) { |
| 298 | if (uid == -1) { |
| 299 | uid = kTestAppUid; |
| 300 | } |
Calin Juravle | 7d76546 | 2017-09-04 15:57:10 -0700 | [diff] [blame] | 301 | std::vector<std::string> isas; |
| 302 | isas.push_back(kRuntimeIsa); |
| 303 | bool out_secondary_dex_exists = false; |
| 304 | binder::Status result = service_->reconcileSecondaryDexFile( |
| 305 | path, |
| 306 | package_override == nullptr ? package_name_ : *package_override, |
| 307 | uid, |
| 308 | isas, |
| 309 | volume_uuid_, |
| 310 | storage_flag, |
| 311 | &out_secondary_dex_exists); |
| 312 | |
Andreas Gampe | f6a93b1 | 2018-02-27 09:51:15 -0800 | [diff] [blame] | 313 | ASSERT_EQ(should_binder_call_succeed, result.isOk()) << result.toString8().c_str(); |
Calin Juravle | 7d76546 | 2017-09-04 15:57:10 -0700 | [diff] [blame] | 314 | ASSERT_EQ(should_dex_exist, out_secondary_dex_exists); |
| 315 | |
| 316 | int expected_access = should_dex_be_deleted ? -1 : 0; |
Calin Juravle | 2959173 | 2017-11-20 17:46:19 -0800 | [diff] [blame] | 317 | std::string odex = GetSecondaryDexArtifact(path, "odex"); |
| 318 | std::string vdex = GetSecondaryDexArtifact(path, "vdex"); |
| 319 | std::string art = GetSecondaryDexArtifact(path, "art"); |
Calin Juravle | 7d76546 | 2017-09-04 15:57:10 -0700 | [diff] [blame] | 320 | ASSERT_EQ(expected_access, access(odex.c_str(), F_OK)); |
| 321 | ASSERT_EQ(expected_access, access(vdex.c_str(), F_OK)); |
| 322 | ASSERT_EQ(-1, access(art.c_str(), R_OK)); // empty profiles do not generate an image. |
| 323 | } |
Calin Juravle | 2959173 | 2017-11-20 17:46:19 -0800 | [diff] [blame] | 324 | |
| 325 | void CheckFileAccess(const std::string& file, uid_t uid, gid_t gid, mode_t mode) { |
| 326 | struct stat st; |
| 327 | ASSERT_EQ(0, stat(file.c_str(), &st)); |
| 328 | ASSERT_EQ(uid, st.st_uid); |
| 329 | ASSERT_EQ(gid, st.st_gid); |
| 330 | ASSERT_EQ(mode, st.st_mode); |
| 331 | } |
Calin Juravle | c4f6a0b | 2018-02-01 01:27:24 +0000 | [diff] [blame] | 332 | |
| 333 | void CompilePrimaryDexOk(std::string compiler_filter, |
| 334 | int32_t dex_flags, |
| 335 | const char* oat_dir, |
| 336 | int32_t uid, |
| 337 | int32_t dexopt_needed, |
Calin Juravle | 62c5a37 | 2018-02-01 17:03:23 +0000 | [diff] [blame] | 338 | const char* dm_path = nullptr, |
Calin Juravle | c4f6a0b | 2018-02-01 01:27:24 +0000 | [diff] [blame] | 339 | bool downgrade = false) { |
| 340 | return CompilePrimaryDex( |
Calin Juravle | 62c5a37 | 2018-02-01 17:03:23 +0000 | [diff] [blame] | 341 | compiler_filter, dex_flags, oat_dir, uid, dexopt_needed, dm_path, downgrade, true); |
Calin Juravle | c4f6a0b | 2018-02-01 01:27:24 +0000 | [diff] [blame] | 342 | } |
| 343 | |
| 344 | void CompilePrimaryDexFail(std::string compiler_filter, |
| 345 | int32_t dex_flags, |
| 346 | const char* oat_dir, |
| 347 | int32_t uid, |
| 348 | int32_t dexopt_needed, |
Calin Juravle | 62c5a37 | 2018-02-01 17:03:23 +0000 | [diff] [blame] | 349 | const char* dm_path = nullptr, |
Calin Juravle | c4f6a0b | 2018-02-01 01:27:24 +0000 | [diff] [blame] | 350 | bool downgrade = false) { |
| 351 | return CompilePrimaryDex( |
Calin Juravle | 62c5a37 | 2018-02-01 17:03:23 +0000 | [diff] [blame] | 352 | compiler_filter, dex_flags, oat_dir, uid, dexopt_needed, dm_path, downgrade, false); |
Calin Juravle | c4f6a0b | 2018-02-01 01:27:24 +0000 | [diff] [blame] | 353 | } |
| 354 | |
| 355 | void CompilePrimaryDex(std::string compiler_filter, |
| 356 | int32_t dex_flags, |
| 357 | const char* oat_dir, |
| 358 | int32_t uid, |
| 359 | int32_t dexopt_needed, |
Calin Juravle | 62c5a37 | 2018-02-01 17:03:23 +0000 | [diff] [blame] | 360 | const char* dm_path, |
Calin Juravle | c4f6a0b | 2018-02-01 01:27:24 +0000 | [diff] [blame] | 361 | bool downgrade, |
| 362 | bool should_binder_call_succeed) { |
| 363 | std::unique_ptr<std::string> package_name_ptr(new std::string(package_name_)); |
| 364 | std::unique_ptr<std::string> out_path( |
| 365 | oat_dir == nullptr ? nullptr : new std::string(oat_dir)); |
| 366 | std::unique_ptr<std::string> class_loader_context_ptr(new std::string("&")); |
| 367 | std::unique_ptr<std::string> se_info_ptr(new std::string(se_info_)); |
| 368 | int32_t target_sdk_version = 0; // default |
| 369 | std::unique_ptr<std::string> profile_name_ptr(new std::string("primary.prof")); |
Calin Juravle | 62c5a37 | 2018-02-01 17:03:23 +0000 | [diff] [blame] | 370 | std::unique_ptr<std::string> dm_path_ptr = nullptr; |
| 371 | if (dm_path != nullptr) { |
| 372 | dm_path_ptr.reset(new std::string(dm_path)); |
| 373 | } |
Calin Juravle | 2efc402 | 2018-02-13 18:31:32 -0800 | [diff] [blame] | 374 | std::unique_ptr<std::string> compilation_reason_ptr(new std::string("test-reason")); |
Calin Juravle | c4f6a0b | 2018-02-01 01:27:24 +0000 | [diff] [blame] | 375 | |
| 376 | bool prof_result; |
| 377 | binder::Status prof_binder_result = service_->prepareAppProfile( |
| 378 | package_name_, kTestUserId, kTestAppId, *profile_name_ptr, /*code path*/ "base.apk", |
| 379 | /*dex_metadata*/ nullptr, &prof_result); |
| 380 | |
Andreas Gampe | f6a93b1 | 2018-02-27 09:51:15 -0800 | [diff] [blame] | 381 | ASSERT_TRUE(prof_binder_result.isOk()) << prof_binder_result.toString8().c_str(); |
Calin Juravle | c4f6a0b | 2018-02-01 01:27:24 +0000 | [diff] [blame] | 382 | ASSERT_TRUE(prof_result); |
| 383 | |
| 384 | binder::Status result = service_->dexopt(apk_path_, |
| 385 | uid, |
| 386 | package_name_ptr, |
| 387 | kRuntimeIsa, |
| 388 | dexopt_needed, |
| 389 | out_path, |
| 390 | dex_flags, |
| 391 | compiler_filter, |
| 392 | volume_uuid_, |
| 393 | class_loader_context_ptr, |
| 394 | se_info_ptr, |
| 395 | downgrade, |
| 396 | target_sdk_version, |
Calin Juravle | 62c5a37 | 2018-02-01 17:03:23 +0000 | [diff] [blame] | 397 | profile_name_ptr, |
Calin Juravle | 2efc402 | 2018-02-13 18:31:32 -0800 | [diff] [blame] | 398 | dm_path_ptr, |
| 399 | compilation_reason_ptr); |
Andreas Gampe | f6a93b1 | 2018-02-27 09:51:15 -0800 | [diff] [blame] | 400 | ASSERT_EQ(should_binder_call_succeed, result.isOk()) << result.toString8().c_str(); |
Calin Juravle | c4f6a0b | 2018-02-01 01:27:24 +0000 | [diff] [blame] | 401 | |
| 402 | if (!should_binder_call_succeed) { |
| 403 | return; |
| 404 | } |
| 405 | // Check the access to the compiler output. |
| 406 | // - speed-profile artifacts are not world-wide readable. |
| 407 | // - files are owned by the system uid. |
| 408 | std::string odex = GetPrimaryDexArtifact(oat_dir, apk_path_, "odex"); |
| 409 | std::string vdex = GetPrimaryDexArtifact(oat_dir, apk_path_, "vdex"); |
| 410 | std::string art = GetPrimaryDexArtifact(oat_dir, apk_path_, "art"); |
| 411 | |
Calin Juravle | 5bd1c72 | 2018-02-01 17:23:54 +0000 | [diff] [blame] | 412 | bool is_public = (dex_flags & DEXOPT_PUBLIC) != 0; |
| 413 | mode_t mode = S_IFREG | (is_public ? 0644 : 0640); |
Calin Juravle | c4f6a0b | 2018-02-01 01:27:24 +0000 | [diff] [blame] | 414 | CheckFileAccess(odex, kSystemUid, uid, mode); |
| 415 | CheckFileAccess(vdex, kSystemUid, uid, mode); |
Calin Juravle | c4f6a0b | 2018-02-01 01:27:24 +0000 | [diff] [blame] | 416 | |
Calin Juravle | 5bd1c72 | 2018-02-01 17:23:54 +0000 | [diff] [blame] | 417 | if (compiler_filter == "speed-profile") { |
| 418 | CheckFileAccess(art, kSystemUid, uid, mode); |
| 419 | } |
Calin Juravle | c4f6a0b | 2018-02-01 01:27:24 +0000 | [diff] [blame] | 420 | } |
| 421 | |
| 422 | std::string GetPrimaryDexArtifact(const char* oat_dir, |
| 423 | const std::string& dex_path, |
| 424 | const std::string& type) { |
| 425 | if (oat_dir == nullptr) { |
| 426 | std::string path = dex_path; |
| 427 | for (auto it = path.begin() + 1; it < path.end(); ++it) { |
| 428 | if (*it == '/') { |
| 429 | *it = '@'; |
| 430 | } |
| 431 | } |
| 432 | return android_data_dir + DALVIK_CACHE + '/' + kRuntimeIsa + "/" + path |
| 433 | + "@classes.dex"; |
| 434 | } else { |
| 435 | std::string::size_type name_end = dex_path.rfind('.'); |
| 436 | std::string::size_type name_start = dex_path.rfind('/'); |
| 437 | return std::string(oat_dir) + "/" + kRuntimeIsa + "/" + |
| 438 | dex_path.substr(name_start + 1, name_end - name_start) + type; |
| 439 | } |
| 440 | } |
Calin Juravle | 7d76546 | 2017-09-04 15:57:10 -0700 | [diff] [blame] | 441 | }; |
| 442 | |
| 443 | |
| 444 | TEST_F(DexoptTest, DexoptSecondaryCe) { |
| 445 | LOG(INFO) << "DexoptSecondaryCe"; |
Calin Juravle | 2959173 | 2017-11-20 17:46:19 -0800 | [diff] [blame] | 446 | CompileSecondaryDex(secondary_dex_ce_, DEXOPT_STORAGE_CE, |
Calin Juravle | 7d76546 | 2017-09-04 15:57:10 -0700 | [diff] [blame] | 447 | /*binder_ok*/ true, /*compile_ok*/ true); |
| 448 | } |
| 449 | |
| 450 | TEST_F(DexoptTest, DexoptSecondaryCeLink) { |
| 451 | LOG(INFO) << "DexoptSecondaryCeLink"; |
Calin Juravle | 2959173 | 2017-11-20 17:46:19 -0800 | [diff] [blame] | 452 | CompileSecondaryDex(secondary_dex_ce_link_, DEXOPT_STORAGE_CE, |
Calin Juravle | 7d76546 | 2017-09-04 15:57:10 -0700 | [diff] [blame] | 453 | /*binder_ok*/ true, /*compile_ok*/ true); |
| 454 | } |
| 455 | |
| 456 | TEST_F(DexoptTest, DexoptSecondaryDe) { |
| 457 | LOG(INFO) << "DexoptSecondaryDe"; |
Calin Juravle | 2959173 | 2017-11-20 17:46:19 -0800 | [diff] [blame] | 458 | CompileSecondaryDex(secondary_dex_de_, DEXOPT_STORAGE_DE, |
Calin Juravle | 7d76546 | 2017-09-04 15:57:10 -0700 | [diff] [blame] | 459 | /*binder_ok*/ true, /*compile_ok*/ true); |
| 460 | } |
| 461 | |
| 462 | TEST_F(DexoptTest, DexoptSecondaryDoesNotExist) { |
| 463 | LOG(INFO) << "DexoptSecondaryDoesNotExist"; |
| 464 | // If the file validates but does not exist we do not treat it as an error. |
Calin Juravle | 2959173 | 2017-11-20 17:46:19 -0800 | [diff] [blame] | 465 | CompileSecondaryDex(secondary_dex_ce_ + "not.there", DEXOPT_STORAGE_CE, |
Calin Juravle | 7d76546 | 2017-09-04 15:57:10 -0700 | [diff] [blame] | 466 | /*binder_ok*/ true, /*compile_ok*/ false); |
| 467 | } |
| 468 | |
| 469 | TEST_F(DexoptTest, DexoptSecondaryStorageValidationError) { |
| 470 | LOG(INFO) << "DexoptSecondaryStorageValidationError"; |
Calin Juravle | 2959173 | 2017-11-20 17:46:19 -0800 | [diff] [blame] | 471 | CompileSecondaryDex(secondary_dex_ce_, DEXOPT_STORAGE_DE, |
Calin Juravle | 7d76546 | 2017-09-04 15:57:10 -0700 | [diff] [blame] | 472 | /*binder_ok*/ false, /*compile_ok*/ false); |
| 473 | } |
| 474 | |
| 475 | TEST_F(DexoptTest, DexoptSecondaryAppOwnershipValidationError) { |
| 476 | LOG(INFO) << "DexoptSecondaryAppOwnershipValidationError"; |
Calin Juravle | 2959173 | 2017-11-20 17:46:19 -0800 | [diff] [blame] | 477 | CompileSecondaryDex("/data/data/random.app/secondary.jar", DEXOPT_STORAGE_CE, |
Calin Juravle | 7d76546 | 2017-09-04 15:57:10 -0700 | [diff] [blame] | 478 | /*binder_ok*/ false, /*compile_ok*/ false); |
| 479 | } |
| 480 | |
| 481 | TEST_F(DexoptTest, DexoptSecondaryAcessViaDifferentUidError) { |
| 482 | LOG(INFO) << "DexoptSecondaryAcessViaDifferentUidError"; |
Calin Juravle | 2959173 | 2017-11-20 17:46:19 -0800 | [diff] [blame] | 483 | CompileSecondaryDex(secondary_dex_ce_, DEXOPT_STORAGE_CE, |
Calin Juravle | 7d76546 | 2017-09-04 15:57:10 -0700 | [diff] [blame] | 484 | /*binder_ok*/ false, /*compile_ok*/ false, kSystemUid); |
| 485 | } |
| 486 | |
Calin Juravle | c4f6a0b | 2018-02-01 01:27:24 +0000 | [diff] [blame] | 487 | TEST_F(DexoptTest, DexoptPrimaryPublic) { |
| 488 | LOG(INFO) << "DexoptPrimaryPublic"; |
| 489 | CompilePrimaryDexOk("verify", |
| 490 | DEXOPT_BOOTCOMPLETE | DEXOPT_PUBLIC, |
| 491 | app_oat_dir_.c_str(), |
| 492 | kTestAppGid, |
| 493 | DEX2OAT_FROM_SCRATCH); |
| 494 | } |
| 495 | |
Calin Juravle | 5bd1c72 | 2018-02-01 17:23:54 +0000 | [diff] [blame] | 496 | TEST_F(DexoptTest, DexoptPrimaryFailedInvalidFilter) { |
| 497 | LOG(INFO) << "DexoptPrimaryFailedInvalidFilter"; |
| 498 | CompilePrimaryDexFail("awesome-filter", |
| 499 | DEXOPT_IDLE_BACKGROUND_JOB | DEXOPT_PUBLIC, |
| 500 | app_oat_dir_.c_str(), |
| 501 | kTestAppGid, |
| 502 | DEX2OAT_FROM_SCRATCH); |
| 503 | } |
| 504 | |
Calin Juravle | c4f6a0b | 2018-02-01 01:27:24 +0000 | [diff] [blame] | 505 | TEST_F(DexoptTest, DexoptPrimaryProfileNonPublic) { |
| 506 | LOG(INFO) << "DexoptPrimaryProfileNonPublic"; |
| 507 | CompilePrimaryDexOk("speed-profile", |
Calin Juravle | 5bd1c72 | 2018-02-01 17:23:54 +0000 | [diff] [blame] | 508 | DEXOPT_BOOTCOMPLETE | DEXOPT_PROFILE_GUIDED, |
Calin Juravle | c4f6a0b | 2018-02-01 01:27:24 +0000 | [diff] [blame] | 509 | app_oat_dir_.c_str(), |
| 510 | kTestAppGid, |
| 511 | DEX2OAT_FROM_SCRATCH); |
| 512 | } |
| 513 | |
| 514 | TEST_F(DexoptTest, DexoptPrimaryProfilePublic) { |
| 515 | LOG(INFO) << "DexoptPrimaryProfilePublic"; |
Calin Juravle | 5bd1c72 | 2018-02-01 17:23:54 +0000 | [diff] [blame] | 516 | CompilePrimaryDexOk("speed-profile", |
| 517 | DEXOPT_BOOTCOMPLETE | DEXOPT_PROFILE_GUIDED | DEXOPT_PUBLIC, |
Calin Juravle | c4f6a0b | 2018-02-01 01:27:24 +0000 | [diff] [blame] | 518 | app_oat_dir_.c_str(), |
| 519 | kTestAppGid, |
| 520 | DEX2OAT_FROM_SCRATCH); |
| 521 | } |
| 522 | |
| 523 | TEST_F(DexoptTest, DexoptPrimaryBackgroundOk) { |
| 524 | LOG(INFO) << "DexoptPrimaryBackgroundOk"; |
| 525 | CompilePrimaryDexOk("speed-profile", |
Calin Juravle | 5bd1c72 | 2018-02-01 17:23:54 +0000 | [diff] [blame] | 526 | DEXOPT_IDLE_BACKGROUND_JOB | DEXOPT_PROFILE_GUIDED, |
Calin Juravle | c4f6a0b | 2018-02-01 01:27:24 +0000 | [diff] [blame] | 527 | app_oat_dir_.c_str(), |
| 528 | kTestAppGid, |
| 529 | DEX2OAT_FROM_SCRATCH); |
| 530 | } |
| 531 | |
Calin Juravle | c4f6a0b | 2018-02-01 01:27:24 +0000 | [diff] [blame] | 532 | class PrimaryDexReCompilationTest : public DexoptTest { |
| 533 | public: |
| 534 | virtual void SetUp() { |
| 535 | DexoptTest::SetUp(); |
| 536 | CompilePrimaryDexOk("verify", |
| 537 | DEXOPT_BOOTCOMPLETE | DEXOPT_PUBLIC, |
| 538 | app_oat_dir_.c_str(), |
| 539 | kTestAppGid, |
| 540 | DEX2OAT_FROM_SCRATCH); |
| 541 | std::string odex = GetSecondaryDexArtifact(apk_path_, "odex"); |
| 542 | std::string vdex = GetSecondaryDexArtifact(apk_path_, "vdex"); |
| 543 | |
| 544 | first_compilation_odex_fd_.reset(open(odex.c_str(), O_RDONLY)); |
| 545 | first_compilation_vdex_fd_.reset(open(vdex.c_str(), O_RDONLY)); |
| 546 | } |
| 547 | |
| 548 | virtual void TearDown() { |
| 549 | first_compilation_odex_fd_.reset(-1); |
| 550 | first_compilation_vdex_fd_.reset(-1); |
| 551 | DexoptTest::TearDown(); |
| 552 | } |
| 553 | |
| 554 | protected: |
| 555 | unique_fd first_compilation_odex_fd_; |
| 556 | unique_fd first_compilation_vdex_fd_; |
| 557 | }; |
| 558 | |
| 559 | TEST_F(PrimaryDexReCompilationTest, DexoptPrimaryUpdateInPlaceVdex) { |
| 560 | LOG(INFO) << "DexoptPrimaryUpdateInPlaceVdex"; |
| 561 | |
| 562 | CompilePrimaryDexOk("verify", |
| 563 | DEXOPT_IDLE_BACKGROUND_JOB | DEXOPT_PUBLIC, |
| 564 | app_oat_dir_.c_str(), |
| 565 | kTestAppGid, |
| 566 | DEX2OAT_FOR_BOOT_IMAGE); |
| 567 | } |
Calin Juravle | 7d76546 | 2017-09-04 15:57:10 -0700 | [diff] [blame] | 568 | |
| 569 | class ReconcileTest : public DexoptTest { |
| 570 | virtual void SetUp() { |
| 571 | DexoptTest::SetUp(); |
Calin Juravle | 2959173 | 2017-11-20 17:46:19 -0800 | [diff] [blame] | 572 | CompileSecondaryDex(secondary_dex_ce_, DEXOPT_STORAGE_CE, |
Calin Juravle | 7d76546 | 2017-09-04 15:57:10 -0700 | [diff] [blame] | 573 | /*binder_ok*/ true, /*compile_ok*/ true); |
Calin Juravle | 2959173 | 2017-11-20 17:46:19 -0800 | [diff] [blame] | 574 | CompileSecondaryDex(secondary_dex_de_, DEXOPT_STORAGE_DE, |
Calin Juravle | 7d76546 | 2017-09-04 15:57:10 -0700 | [diff] [blame] | 575 | /*binder_ok*/ true, /*compile_ok*/ true); |
| 576 | } |
| 577 | }; |
| 578 | |
| 579 | TEST_F(ReconcileTest, ReconcileSecondaryCeExists) { |
| 580 | LOG(INFO) << "ReconcileSecondaryCeExists"; |
| 581 | reconcile_secondary_dex(secondary_dex_ce_, FLAG_STORAGE_CE, |
| 582 | /*binder_ok*/ true, /*dex_ok */ true, /*odex_deleted*/ false); |
| 583 | } |
| 584 | |
| 585 | TEST_F(ReconcileTest, ReconcileSecondaryCeLinkExists) { |
| 586 | LOG(INFO) << "ReconcileSecondaryCeLinkExists"; |
| 587 | reconcile_secondary_dex(secondary_dex_ce_link_, FLAG_STORAGE_CE, |
| 588 | /*binder_ok*/ true, /*dex_ok */ true, /*odex_deleted*/ false); |
| 589 | } |
| 590 | |
| 591 | TEST_F(ReconcileTest, ReconcileSecondaryDeExists) { |
| 592 | LOG(INFO) << "ReconcileSecondaryDeExists"; |
| 593 | reconcile_secondary_dex(secondary_dex_de_, FLAG_STORAGE_DE, |
| 594 | /*binder_ok*/ true, /*dex_ok */ true, /*odex_deleted*/ false); |
| 595 | } |
| 596 | |
| 597 | TEST_F(ReconcileTest, ReconcileSecondaryDeDoesNotExist) { |
| 598 | LOG(INFO) << "ReconcileSecondaryDeDoesNotExist"; |
| 599 | run_cmd("rm -rf " + secondary_dex_de_); |
| 600 | reconcile_secondary_dex(secondary_dex_de_, FLAG_STORAGE_DE, |
| 601 | /*binder_ok*/ true, /*dex_ok */ false, /*odex_deleted*/ true); |
| 602 | } |
| 603 | |
| 604 | TEST_F(ReconcileTest, ReconcileSecondaryStorageValidationError) { |
| 605 | // Validation errors will not clean the odex/vdex/art files but will mark |
| 606 | // the file as non existent so that the PM knows it should purge it from its |
| 607 | // records. |
| 608 | LOG(INFO) << "ReconcileSecondaryStorageValidationError"; |
| 609 | reconcile_secondary_dex(secondary_dex_ce_, FLAG_STORAGE_DE, |
| 610 | /*binder_ok*/ true, /*dex_ok */ false, /*odex_deleted*/ false); |
| 611 | } |
| 612 | |
| 613 | TEST_F(ReconcileTest, ReconcileSecondaryAppOwnershipValidationError) { |
| 614 | LOG(INFO) << "ReconcileSecondaryAppOwnershipValidationError"; |
| 615 | // Attempt to reconcile the dex files of the test app from a different app. |
| 616 | std::string another_app = "another.app"; |
| 617 | reconcile_secondary_dex(secondary_dex_ce_, FLAG_STORAGE_CE, |
| 618 | /*binder_ok*/ true, /*dex_ok */ false, /*odex_deleted*/ false, kSystemUid, &another_app); |
| 619 | } |
| 620 | |
| 621 | TEST_F(ReconcileTest, ReconcileSecondaryAcessViaDifferentUidError) { |
| 622 | LOG(INFO) << "ReconcileSecondaryAcessViaDifferentUidError"; |
| 623 | reconcile_secondary_dex(secondary_dex_ce_, FLAG_STORAGE_CE, |
| 624 | /*binder_ok*/ true, /*dex_ok */ false, /*odex_deleted*/ false, kSystemUid); |
| 625 | } |
| 626 | |
Calin Juravle | 2959173 | 2017-11-20 17:46:19 -0800 | [diff] [blame] | 627 | class ProfileTest : public DexoptTest { |
| 628 | protected: |
| 629 | std::string cur_profile_; |
| 630 | std::string ref_profile_; |
| 631 | std::string snap_profile_; |
| 632 | |
Calin Juravle | 824a64d | 2018-01-18 20:23:17 -0800 | [diff] [blame] | 633 | static constexpr const char* kPrimaryProfile = "primary.prof"; |
| 634 | |
Calin Juravle | 2959173 | 2017-11-20 17:46:19 -0800 | [diff] [blame] | 635 | virtual void SetUp() { |
| 636 | DexoptTest::SetUp(); |
| 637 | cur_profile_ = create_current_profile_path( |
Calin Juravle | 824a64d | 2018-01-18 20:23:17 -0800 | [diff] [blame] | 638 | kTestUserId, package_name_, kPrimaryProfile, /*is_secondary_dex*/ false); |
| 639 | ref_profile_ = create_reference_profile_path(package_name_, kPrimaryProfile, |
| 640 | /*is_secondary_dex*/ false); |
| 641 | snap_profile_ = create_snapshot_profile_path(package_name_, kPrimaryProfile); |
Calin Juravle | 2959173 | 2017-11-20 17:46:19 -0800 | [diff] [blame] | 642 | } |
| 643 | |
Calin Juravle | 824a64d | 2018-01-18 20:23:17 -0800 | [diff] [blame] | 644 | void SetupProfile(const std::string& path, uid_t uid, gid_t gid, mode_t mode, |
| 645 | int32_t num_dex) { |
| 646 | run_cmd("profman --generate-test-profile-seed=" + std::to_string(num_dex) + |
| 647 | " --generate-test-profile-num-dex=" + std::to_string(num_dex) + |
| 648 | " --generate-test-profile=" + path); |
Calin Juravle | 2959173 | 2017-11-20 17:46:19 -0800 | [diff] [blame] | 649 | ::chmod(path.c_str(), mode); |
| 650 | ::chown(path.c_str(), uid, gid); |
| 651 | } |
| 652 | |
| 653 | void SetupProfiles(bool setup_ref) { |
| 654 | SetupProfile(cur_profile_, kTestAppUid, kTestAppGid, 0600, 1); |
| 655 | if (setup_ref) { |
Calin Juravle | 824a64d | 2018-01-18 20:23:17 -0800 | [diff] [blame] | 656 | SetupProfile(ref_profile_, kTestAppUid, kTestAppGid, 0600, 2); |
Calin Juravle | 2959173 | 2017-11-20 17:46:19 -0800 | [diff] [blame] | 657 | } |
| 658 | } |
| 659 | |
Calin Juravle | c3596c3 | 2017-12-05 12:29:15 -0800 | [diff] [blame] | 660 | void createProfileSnapshot(int32_t appid, const std::string& package_name, |
| 661 | bool expected_result) { |
Calin Juravle | 2959173 | 2017-11-20 17:46:19 -0800 | [diff] [blame] | 662 | bool result; |
Calin Juravle | c3596c3 | 2017-12-05 12:29:15 -0800 | [diff] [blame] | 663 | binder::Status binder_result = service_->createProfileSnapshot( |
Calin Juravle | 0d0a492 | 2018-01-23 19:54:11 -0800 | [diff] [blame] | 664 | appid, package_name, kPrimaryProfile, apk_path_, &result); |
Andreas Gampe | f6a93b1 | 2018-02-27 09:51:15 -0800 | [diff] [blame] | 665 | ASSERT_TRUE(binder_result.isOk()) << binder_result.toString8().c_str(); |
Calin Juravle | 2959173 | 2017-11-20 17:46:19 -0800 | [diff] [blame] | 666 | ASSERT_EQ(expected_result, result); |
| 667 | |
| 668 | if (!expected_result) { |
| 669 | // Do not check the files if we expect to fail. |
| 670 | return; |
| 671 | } |
| 672 | |
| 673 | // Check that the snapshot was created witht he expected acess flags. |
| 674 | CheckFileAccess(snap_profile_, kSystemUid, kSystemGid, 0600 | S_IFREG); |
| 675 | |
| 676 | // The snapshot should be equivalent to the merge of profiles. |
| 677 | std::string expected_profile_content = snap_profile_ + ".expected"; |
| 678 | run_cmd("rm -f " + expected_profile_content); |
| 679 | run_cmd("touch " + expected_profile_content); |
| 680 | run_cmd("profman --profile-file=" + cur_profile_ + |
| 681 | " --profile-file=" + ref_profile_ + |
Calin Juravle | 40b5f46 | 2018-02-07 04:11:52 -0800 | [diff] [blame] | 682 | " --reference-profile-file=" + expected_profile_content + |
| 683 | " --apk=" + apk_path_); |
Calin Juravle | 2959173 | 2017-11-20 17:46:19 -0800 | [diff] [blame] | 684 | |
| 685 | ASSERT_TRUE(AreFilesEqual(expected_profile_content, snap_profile_)); |
| 686 | |
| 687 | pid_t pid = fork(); |
| 688 | if (pid == 0) { |
| 689 | /* child */ |
| 690 | TransitionToSystemServer(); |
| 691 | |
| 692 | // System server should be able to open the the spanshot. |
| 693 | unique_fd fd(open(snap_profile_.c_str(), O_RDONLY)); |
| 694 | ASSERT_TRUE(fd > -1) << "Failed to open profile as kSystemUid: " << strerror(errno); |
| 695 | _exit(0); |
| 696 | } |
| 697 | /* parent */ |
| 698 | ASSERT_TRUE(WIFEXITED(wait_child(pid))); |
| 699 | } |
| 700 | |
Calin Juravle | 408cd4a | 2018-01-20 23:34:18 -0800 | [diff] [blame] | 701 | void mergePackageProfiles(const std::string& package_name, |
| 702 | const std::string& code_path, |
| 703 | bool expected_result) { |
Calin Juravle | 824a64d | 2018-01-18 20:23:17 -0800 | [diff] [blame] | 704 | bool result; |
| 705 | binder::Status binder_result = service_->mergeProfiles( |
Calin Juravle | 408cd4a | 2018-01-20 23:34:18 -0800 | [diff] [blame] | 706 | kTestAppUid, package_name, code_path, &result); |
Andreas Gampe | f6a93b1 | 2018-02-27 09:51:15 -0800 | [diff] [blame] | 707 | ASSERT_TRUE(binder_result.isOk()) << binder_result.toString8().c_str(); |
Calin Juravle | 824a64d | 2018-01-18 20:23:17 -0800 | [diff] [blame] | 708 | ASSERT_EQ(expected_result, result); |
| 709 | |
| 710 | if (!expected_result) { |
| 711 | // Do not check the files if we expect to fail. |
| 712 | return; |
| 713 | } |
| 714 | |
| 715 | // Check that the snapshot was created witht he expected acess flags. |
| 716 | CheckFileAccess(ref_profile_, kTestAppUid, kTestAppUid, 0600 | S_IFREG); |
| 717 | |
| 718 | // The snapshot should be equivalent to the merge of profiles. |
| 719 | std::string ref_profile_content = ref_profile_ + ".expected"; |
| 720 | run_cmd("rm -f " + ref_profile_content); |
| 721 | run_cmd("touch " + ref_profile_content); |
| 722 | run_cmd("profman --profile-file=" + cur_profile_ + |
| 723 | " --profile-file=" + ref_profile_ + |
| 724 | " --reference-profile-file=" + ref_profile_content); |
| 725 | |
| 726 | ASSERT_TRUE(AreFilesEqual(ref_profile_content, ref_profile_)); |
| 727 | } |
| 728 | |
Calin Juravle | c3b049e | 2018-01-18 22:32:58 -0800 | [diff] [blame] | 729 | // TODO(calin): add dex metadata tests once the ART change is merged. |
| 730 | void preparePackageProfile(const std::string& package_name, const std::string& profile_name, |
| 731 | bool expected_result) { |
| 732 | bool result; |
| 733 | binder::Status binder_result = service_->prepareAppProfile( |
| 734 | package_name, kTestUserId, kTestAppId, profile_name, /*code path*/ "base.apk", |
| 735 | /*dex_metadata*/ nullptr, &result); |
Andreas Gampe | f6a93b1 | 2018-02-27 09:51:15 -0800 | [diff] [blame] | 736 | ASSERT_TRUE(binder_result.isOk()) << binder_result.toString8().c_str(); |
Calin Juravle | c3b049e | 2018-01-18 22:32:58 -0800 | [diff] [blame] | 737 | ASSERT_EQ(expected_result, result); |
| 738 | |
| 739 | if (!expected_result) { |
| 740 | // Do not check the files if we expect to fail. |
| 741 | return; |
| 742 | } |
| 743 | |
| 744 | std::string code_path_cur_prof = create_current_profile_path( |
| 745 | kTestUserId, package_name, profile_name, /*is_secondary_dex*/ false); |
| 746 | std::string code_path_ref_profile = create_reference_profile_path(package_name, |
| 747 | profile_name, /*is_secondary_dex*/ false); |
| 748 | |
| 749 | // Check that we created the current profile. |
| 750 | CheckFileAccess(code_path_cur_prof, kTestAppUid, kTestAppUid, 0600 | S_IFREG); |
| 751 | |
| 752 | // Without dex metadata we don't generate a reference profile. |
| 753 | ASSERT_EQ(-1, access(code_path_ref_profile.c_str(), R_OK)); |
| 754 | } |
| 755 | |
Calin Juravle | 0d0a492 | 2018-01-23 19:54:11 -0800 | [diff] [blame] | 756 | protected: |
Calin Juravle | 2959173 | 2017-11-20 17:46:19 -0800 | [diff] [blame] | 757 | void TransitionToSystemServer() { |
| 758 | ASSERT_TRUE(DropCapabilities(kSystemUid, kSystemGid)); |
| 759 | int32_t res = selinux_android_setcontext( |
| 760 | kSystemUid, true, se_info_.c_str(), "system_server"); |
| 761 | ASSERT_EQ(0, res) << "Failed to setcon " << strerror(errno); |
| 762 | } |
| 763 | |
| 764 | bool AreFilesEqual(const std::string& file1, const std::string& file2) { |
| 765 | std::vector<uint8_t> content1; |
| 766 | std::vector<uint8_t> content2; |
| 767 | |
| 768 | if (!ReadAll(file1, &content1)) return false; |
| 769 | if (!ReadAll(file2, &content2)) return false; |
| 770 | return content1 == content2; |
| 771 | } |
| 772 | |
| 773 | bool ReadAll(const std::string& file, std::vector<uint8_t>* content) { |
| 774 | unique_fd fd(open(file.c_str(), O_RDONLY)); |
| 775 | if (fd < 0) { |
| 776 | PLOG(ERROR) << "Failed to open " << file; |
| 777 | return false; |
| 778 | } |
| 779 | struct stat st; |
| 780 | if (fstat(fd, &st) != 0) { |
| 781 | PLOG(ERROR) << "Failed to stat " << file; |
| 782 | return false; |
| 783 | } |
| 784 | content->resize(st.st_size); |
| 785 | bool result = ReadFully(fd, content->data(), content->size()); |
| 786 | if (!result) { |
| 787 | PLOG(ERROR) << "Failed to read " << file; |
| 788 | } |
| 789 | return result; |
| 790 | } |
| 791 | }; |
| 792 | |
| 793 | TEST_F(ProfileTest, ProfileSnapshotOk) { |
| 794 | LOG(INFO) << "ProfileSnapshotOk"; |
| 795 | |
| 796 | SetupProfiles(/*setup_ref*/ true); |
Calin Juravle | c3596c3 | 2017-12-05 12:29:15 -0800 | [diff] [blame] | 797 | createProfileSnapshot(kTestAppId, package_name_, /*expected_result*/ true); |
Calin Juravle | 2959173 | 2017-11-20 17:46:19 -0800 | [diff] [blame] | 798 | } |
| 799 | |
| 800 | // The reference profile is created on the fly. We need to be able to |
| 801 | // snapshot without one. |
| 802 | TEST_F(ProfileTest, ProfileSnapshotOkNoReference) { |
| 803 | LOG(INFO) << "ProfileSnapshotOkNoReference"; |
| 804 | |
| 805 | SetupProfiles(/*setup_ref*/ false); |
Calin Juravle | c3596c3 | 2017-12-05 12:29:15 -0800 | [diff] [blame] | 806 | createProfileSnapshot(kTestAppId, package_name_, /*expected_result*/ true); |
Calin Juravle | 2959173 | 2017-11-20 17:46:19 -0800 | [diff] [blame] | 807 | } |
| 808 | |
| 809 | TEST_F(ProfileTest, ProfileSnapshotFailWrongPackage) { |
| 810 | LOG(INFO) << "ProfileSnapshotFailWrongPackage"; |
| 811 | |
| 812 | SetupProfiles(/*setup_ref*/ true); |
Calin Juravle | c3596c3 | 2017-12-05 12:29:15 -0800 | [diff] [blame] | 813 | createProfileSnapshot(kTestAppId, "not.there", /*expected_result*/ false); |
Calin Juravle | 2959173 | 2017-11-20 17:46:19 -0800 | [diff] [blame] | 814 | } |
| 815 | |
| 816 | TEST_F(ProfileTest, ProfileSnapshotDestroySnapshot) { |
| 817 | LOG(INFO) << "ProfileSnapshotDestroySnapshot"; |
| 818 | |
| 819 | SetupProfiles(/*setup_ref*/ true); |
Calin Juravle | c3596c3 | 2017-12-05 12:29:15 -0800 | [diff] [blame] | 820 | createProfileSnapshot(kTestAppId, package_name_, /*expected_result*/ true); |
Calin Juravle | 2959173 | 2017-11-20 17:46:19 -0800 | [diff] [blame] | 821 | |
Calin Juravle | 824a64d | 2018-01-18 20:23:17 -0800 | [diff] [blame] | 822 | binder::Status binder_result = service_->destroyProfileSnapshot(package_name_, kPrimaryProfile); |
Andreas Gampe | f6a93b1 | 2018-02-27 09:51:15 -0800 | [diff] [blame] | 823 | ASSERT_TRUE(binder_result.isOk()) << binder_result.toString8().c_str(); |
Calin Juravle | 2959173 | 2017-11-20 17:46:19 -0800 | [diff] [blame] | 824 | struct stat st; |
| 825 | ASSERT_EQ(-1, stat(snap_profile_.c_str(), &st)); |
| 826 | ASSERT_EQ(ENOENT, errno); |
| 827 | } |
| 828 | |
Calin Juravle | 824a64d | 2018-01-18 20:23:17 -0800 | [diff] [blame] | 829 | TEST_F(ProfileTest, ProfileMergeOk) { |
| 830 | LOG(INFO) << "ProfileMergeOk"; |
| 831 | |
| 832 | SetupProfiles(/*setup_ref*/ true); |
Calin Juravle | 408cd4a | 2018-01-20 23:34:18 -0800 | [diff] [blame] | 833 | mergePackageProfiles(package_name_, "primary.prof", /*expected_result*/ true); |
Calin Juravle | 824a64d | 2018-01-18 20:23:17 -0800 | [diff] [blame] | 834 | } |
| 835 | |
| 836 | // The reference profile is created on the fly. We need to be able to |
| 837 | // merge without one. |
| 838 | TEST_F(ProfileTest, ProfileMergeOkNoReference) { |
| 839 | LOG(INFO) << "ProfileMergeOkNoReference"; |
| 840 | |
| 841 | SetupProfiles(/*setup_ref*/ false); |
Calin Juravle | 408cd4a | 2018-01-20 23:34:18 -0800 | [diff] [blame] | 842 | mergePackageProfiles(package_name_, "primary.prof", /*expected_result*/ true); |
Calin Juravle | 824a64d | 2018-01-18 20:23:17 -0800 | [diff] [blame] | 843 | } |
| 844 | |
| 845 | TEST_F(ProfileTest, ProfileMergeFailWrongPackage) { |
| 846 | LOG(INFO) << "ProfileMergeFailWrongPackage"; |
| 847 | |
| 848 | SetupProfiles(/*setup_ref*/ true); |
Calin Juravle | 408cd4a | 2018-01-20 23:34:18 -0800 | [diff] [blame] | 849 | mergePackageProfiles("not.there", "primary.prof", /*expected_result*/ false); |
Calin Juravle | 824a64d | 2018-01-18 20:23:17 -0800 | [diff] [blame] | 850 | } |
| 851 | |
Calin Juravle | d2affb8 | 2017-11-28 17:41:43 -0800 | [diff] [blame] | 852 | TEST_F(ProfileTest, ProfileDirOk) { |
| 853 | LOG(INFO) << "ProfileDirOk"; |
| 854 | |
| 855 | std::string cur_profile_dir = create_primary_current_profile_package_dir_path( |
| 856 | kTestUserId, package_name_); |
| 857 | std::string cur_profile_file = create_current_profile_path(kTestUserId, package_name_, |
Calin Juravle | 824a64d | 2018-01-18 20:23:17 -0800 | [diff] [blame] | 858 | kPrimaryProfile, /*is_secondary_dex*/false); |
Calin Juravle | d2affb8 | 2017-11-28 17:41:43 -0800 | [diff] [blame] | 859 | std::string ref_profile_dir = create_primary_reference_profile_package_dir_path(package_name_); |
| 860 | |
| 861 | CheckFileAccess(cur_profile_dir, kTestAppUid, kTestAppUid, 0700 | S_IFDIR); |
Calin Juravle | 6f06eb6 | 2017-11-28 18:44:53 -0800 | [diff] [blame] | 862 | CheckFileAccess(ref_profile_dir, kSystemUid, kTestAppGid, 0770 | S_IFDIR); |
| 863 | } |
| 864 | |
| 865 | // Verify that the profile directories are fixed up during an upgrade. |
| 866 | // (The reference profile directory is prepared lazily). |
| 867 | TEST_F(ProfileTest, ProfileDirOkAfterFixup) { |
| 868 | LOG(INFO) << "ProfileDirOkAfterFixup"; |
| 869 | |
| 870 | std::string cur_profile_dir = create_primary_current_profile_package_dir_path( |
| 871 | kTestUserId, package_name_); |
| 872 | std::string cur_profile_file = create_current_profile_path(kTestUserId, package_name_, |
Calin Juravle | 824a64d | 2018-01-18 20:23:17 -0800 | [diff] [blame] | 873 | kPrimaryProfile, /*is_secondary_dex*/false); |
Calin Juravle | 6f06eb6 | 2017-11-28 18:44:53 -0800 | [diff] [blame] | 874 | std::string ref_profile_dir = create_primary_reference_profile_package_dir_path(package_name_); |
| 875 | |
| 876 | // Simulate a pre-P setup by changing the owner to kTestAppGid and permissions to 0700. |
| 877 | ASSERT_EQ(0, chown(ref_profile_dir.c_str(), kTestAppGid, kTestAppGid)); |
| 878 | ASSERT_EQ(0, chmod(ref_profile_dir.c_str(), 0700)); |
| 879 | |
| 880 | // Run createAppData again which will offer to fix-up the profile directories. |
| 881 | ASSERT_TRUE(service_->createAppData( |
| 882 | volume_uuid_, |
| 883 | package_name_, |
| 884 | kTestUserId, |
| 885 | kAppDataFlags, |
| 886 | kTestAppUid, |
| 887 | se_info_, |
| 888 | kOSdkVersion, |
| 889 | &ce_data_inode_).isOk()); |
| 890 | |
| 891 | // Check the file access. |
| 892 | CheckFileAccess(cur_profile_dir, kTestAppUid, kTestAppUid, 0700 | S_IFDIR); |
Calin Juravle | 6f06eb6 | 2017-11-28 18:44:53 -0800 | [diff] [blame] | 893 | CheckFileAccess(ref_profile_dir, kSystemUid, kTestAppGid, 0770 | S_IFDIR); |
Calin Juravle | d2affb8 | 2017-11-28 17:41:43 -0800 | [diff] [blame] | 894 | } |
| 895 | |
Calin Juravle | c3b049e | 2018-01-18 22:32:58 -0800 | [diff] [blame] | 896 | TEST_F(ProfileTest, ProfilePrepareOk) { |
| 897 | LOG(INFO) << "ProfilePrepareOk"; |
| 898 | preparePackageProfile(package_name_, "split.prof", /*expected_result*/ true); |
| 899 | } |
| 900 | |
| 901 | TEST_F(ProfileTest, ProfilePrepareFailInvalidPackage) { |
| 902 | LOG(INFO) << "ProfilePrepareFailInvalidPackage"; |
| 903 | preparePackageProfile("not.there.package", "split.prof", /*expected_result*/ false); |
| 904 | } |
| 905 | |
| 906 | TEST_F(ProfileTest, ProfilePrepareFailProfileChangedUid) { |
| 907 | LOG(INFO) << "ProfilePrepareFailProfileChangedUid"; |
| 908 | SetupProfiles(/*setup_ref*/ false); |
| 909 | // Change the uid on the profile to trigger a failure. |
| 910 | ::chown(cur_profile_.c_str(), kTestAppUid + 1, kTestAppGid + 1); |
| 911 | preparePackageProfile(package_name_, "primary.prof", /*expected_result*/ false); |
| 912 | } |
| 913 | |
Calin Juravle | 0d0a492 | 2018-01-23 19:54:11 -0800 | [diff] [blame] | 914 | |
| 915 | class BootProfileTest : public ProfileTest { |
| 916 | public: |
| 917 | virtual void setup() { |
| 918 | ProfileTest::SetUp(); |
| 919 | intial_android_profiles_dir = android_profiles_dir; |
| 920 | } |
| 921 | |
| 922 | virtual void TearDown() { |
| 923 | android_profiles_dir = intial_android_profiles_dir; |
| 924 | ProfileTest::TearDown(); |
| 925 | } |
| 926 | |
| 927 | void UpdateAndroidProfilesDir(const std::string& profile_dir) { |
| 928 | android_profiles_dir = profile_dir; |
| 929 | // We need to create the reference profile directory in the new profile dir. |
| 930 | run_cmd("mkdir -p " + profile_dir + "/ref"); |
| 931 | } |
| 932 | |
| 933 | void createBootImageProfileSnapshot(const std::string& classpath, bool expected_result) { |
| 934 | bool result; |
| 935 | binder::Status binder_result = service_->createProfileSnapshot( |
| 936 | -1, "android", "android.prof", classpath, &result); |
| 937 | ASSERT_TRUE(binder_result.isOk()); |
| 938 | ASSERT_EQ(expected_result, result); |
| 939 | |
| 940 | if (!expected_result) { |
| 941 | // Do not check the files if we expect to fail. |
| 942 | return; |
| 943 | } |
| 944 | |
| 945 | // Check that the snapshot was created with he expected access flags. |
| 946 | const std::string boot_profile = create_snapshot_profile_path("android", "android.prof"); |
| 947 | CheckFileAccess(boot_profile, kSystemUid, kSystemGid, 0600 | S_IFREG); |
| 948 | |
| 949 | pid_t pid = fork(); |
| 950 | if (pid == 0) { |
| 951 | /* child */ |
| 952 | TransitionToSystemServer(); |
| 953 | |
| 954 | // System server should be able to open the snapshot. |
| 955 | unique_fd fd(open(boot_profile.c_str(), O_RDONLY)); |
| 956 | ASSERT_TRUE(fd > -1) << "Failed to open profile as kSystemUid: " << strerror(errno); |
| 957 | _exit(0); |
| 958 | } |
| 959 | /* parent */ |
| 960 | ASSERT_TRUE(WIFEXITED(wait_child(pid))); |
| 961 | } |
| 962 | protected: |
| 963 | std::string intial_android_profiles_dir; |
| 964 | }; |
| 965 | |
| 966 | TEST_F(BootProfileTest, BootProfileSnapshotOk) { |
| 967 | LOG(INFO) << "BootProfileSnapshotOk"; |
| 968 | char* boot_classpath = getenv("BOOTCLASSPATH"); |
| 969 | ASSERT_TRUE(boot_classpath != nullptr); |
| 970 | createBootImageProfileSnapshot(boot_classpath, /*expected_result*/ true); |
| 971 | } |
| 972 | |
| 973 | TEST_F(BootProfileTest, BootProfileSnapshotFailEmptyClasspath) { |
| 974 | LOG(INFO) << "BootProfileSnapshotFailEmptyClasspath"; |
| 975 | |
| 976 | createBootImageProfileSnapshot(/*boot_classpath*/ "", /*expected_result*/ false); |
| 977 | } |
| 978 | |
| 979 | TEST_F(BootProfileTest, BootProfileSnapshotOkNoProfiles) { |
| 980 | LOG(INFO) << "BootProfileSnapshotOkNoProfiles"; |
| 981 | char* boot_classpath = getenv("BOOTCLASSPATH"); |
| 982 | ASSERT_TRUE(boot_classpath != nullptr); |
| 983 | |
| 984 | // The app_apk_dir has no profiles. So we shouldn't be able to merge anything. |
| 985 | // Still, this is not a failure case. |
| 986 | UpdateAndroidProfilesDir(app_apk_dir_); |
| 987 | createBootImageProfileSnapshot(boot_classpath, /*expected_result*/ true); |
| 988 | } |
| 989 | |
| 990 | // Verify that profile collection. |
| 991 | TEST_F(BootProfileTest, CollectProfiles) { |
| 992 | LOG(INFO) << "CollectProfiles"; |
| 993 | |
| 994 | // Create some profile directories mimicking the real profile structure. |
| 995 | run_cmd("mkdir -p " + app_private_dir_de_ + "/profiles/ref"); |
| 996 | run_cmd("mkdir -p " + app_private_dir_de_ + "/profiles/cur/0/"); |
| 997 | run_cmd("mkdir -p " + app_private_dir_de_ + "/profiles/cur/1/"); |
| 998 | // Create an empty profile. |
| 999 | run_cmd("touch " + app_private_dir_de_ + "/profiles/cur/1/primary.prof"); |
| 1000 | // Create a random file. |
| 1001 | run_cmd("touch " + app_private_dir_de_ + "/profiles/cur/0/non.profile.file"); |
| 1002 | |
| 1003 | // Create some non-empty profiles. |
| 1004 | std::string current_prof = app_private_dir_de_ + "/profiles/cur/0/primary.prof"; |
| 1005 | run_cmd("echo 1 > " + current_prof); |
| 1006 | std::string ref_prof = app_private_dir_de_ + "/profiles/ref/primary.prof"; |
| 1007 | run_cmd("echo 1 > " + ref_prof); |
| 1008 | |
| 1009 | UpdateAndroidProfilesDir(app_private_dir_de_ + "/profiles"); |
| 1010 | |
| 1011 | std::vector<std::string> profiles; |
| 1012 | collect_profiles(&profiles); |
| 1013 | |
| 1014 | // Only two profiles should be in the output. |
| 1015 | ASSERT_EQ(2u, profiles.size()); |
| 1016 | ASSERT_TRUE(std::find(profiles.begin(), profiles.end(), current_prof) != profiles.end()); |
| 1017 | ASSERT_TRUE(std::find(profiles.begin(), profiles.end(), ref_prof) != profiles.end()); |
| 1018 | } |
| 1019 | |
Calin Juravle | 7d76546 | 2017-09-04 15:57:10 -0700 | [diff] [blame] | 1020 | } // namespace installd |
| 1021 | } // namespace android |