Marissa Wall | 61c5862 | 2018-07-18 10:12:20 -0700 | [diff] [blame] | 1 | /* |
| 2 | * Copyright (C) 2017 The Android Open Source Project |
| 3 | * |
| 4 | * Licensed under the Apache License, Version 2.0 (the "License"); |
| 5 | * you may not use this file except in compliance with the License. |
| 6 | * You may obtain a copy of the License at |
| 7 | * |
| 8 | * http://www.apache.org/licenses/LICENSE-2.0 |
| 9 | * |
| 10 | * Unless required by applicable law or agreed to in writing, software |
| 11 | * distributed under the License is distributed on an "AS IS" BASIS, |
| 12 | * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
| 13 | * See the License for the specific language governing permissions and |
| 14 | * limitations under the License. |
| 15 | */ |
| 16 | |
Ady Abraham | b0dbdaa | 2020-01-06 16:19:42 -0800 | [diff] [blame] | 17 | // TODO(b/129481165): remove the #pragma below and fix conversion issues |
| 18 | #pragma clang diagnostic push |
| 19 | #pragma clang diagnostic ignored "-Wconversion" |
Marin Shalamanov | bed7fd3 | 2020-12-21 20:02:20 +0100 | [diff] [blame] | 20 | #pragma clang diagnostic ignored "-Wextra" |
Ady Abraham | b0dbdaa | 2020-01-06 16:19:42 -0800 | [diff] [blame] | 21 | |
Marissa Wall | 61c5862 | 2018-07-18 10:12:20 -0700 | [diff] [blame] | 22 | //#define LOG_NDEBUG 0 |
| 23 | #undef LOG_TAG |
| 24 | #define LOG_TAG "BufferStateLayer" |
| 25 | #define ATRACE_TAG ATRACE_TAG_GRAPHICS |
| 26 | |
Lloyd Pique | 9755fb7 | 2019-03-26 14:44:40 -0700 | [diff] [blame] | 27 | #include "BufferStateLayer.h" |
| 28 | |
Lloyd Pique | 37c2c9b | 2018-12-04 17:25:10 -0800 | [diff] [blame] | 29 | #include <limits> |
Marissa Wall | 61c5862 | 2018-07-18 10:12:20 -0700 | [diff] [blame] | 30 | |
Adithya Srinivasan | b9a7dab | 2021-01-14 23:49:46 +0000 | [diff] [blame] | 31 | #include <FrameTimeline/FrameTimeline.h> |
Lloyd Pique | 9755fb7 | 2019-03-26 14:44:40 -0700 | [diff] [blame] | 32 | #include <compositionengine/LayerFECompositionState.h> |
Marissa Wall | 947d34e | 2019-03-29 14:03:53 -0700 | [diff] [blame] | 33 | #include <gui/BufferQueue.h> |
Marissa Wall | 61c5862 | 2018-07-18 10:12:20 -0700 | [diff] [blame] | 34 | #include <private/gui/SyncFeatures.h> |
Peiyong Lin | cbc184f | 2018-08-22 13:24:10 -0700 | [diff] [blame] | 35 | #include <renderengine/Image.h> |
Marissa Wall | 61c5862 | 2018-07-18 10:12:20 -0700 | [diff] [blame] | 36 | |
Vishnu Nair | fa247b1 | 2020-02-11 08:58:26 -0800 | [diff] [blame] | 37 | #include "EffectLayer.h" |
Adithya Srinivasan | b238cd5 | 2021-02-04 17:54:05 +0000 | [diff] [blame] | 38 | #include "FrameTracer/FrameTracer.h" |
Lloyd Pique | 37c2c9b | 2018-12-04 17:25:10 -0800 | [diff] [blame] | 39 | #include "TimeStats/TimeStats.h" |
Valerie Hau | 0bc0915 | 2018-12-20 07:42:47 -0800 | [diff] [blame] | 40 | |
Marissa Wall | 61c5862 | 2018-07-18 10:12:20 -0700 | [diff] [blame] | 41 | namespace android { |
| 42 | |
Adithya Srinivasan | b9a7dab | 2021-01-14 23:49:46 +0000 | [diff] [blame] | 43 | using PresentState = frametimeline::SurfaceFrame::PresentState; |
Lloyd Pique | 42ab75e | 2018-09-12 20:46:03 -0700 | [diff] [blame] | 44 | // clang-format off |
| 45 | const std::array<float, 16> BufferStateLayer::IDENTITY_MATRIX{ |
| 46 | 1, 0, 0, 0, |
| 47 | 0, 1, 0, 0, |
| 48 | 0, 0, 1, 0, |
| 49 | 0, 0, 0, 1 |
| 50 | }; |
| 51 | // clang-format on |
Marissa Wall | 61c5862 | 2018-07-18 10:12:20 -0700 | [diff] [blame] | 52 | |
Marissa Wall | 947d34e | 2019-03-29 14:03:53 -0700 | [diff] [blame] | 53 | BufferStateLayer::BufferStateLayer(const LayerCreationArgs& args) |
| 54 | : BufferLayer(args), mHwcSlotGenerator(new HwcSlotGenerator()) { |
Marissa Wall | 3ff826c | 2019-02-07 11:58:25 -0800 | [diff] [blame] | 55 | mCurrentState.dataspace = ui::Dataspace::V0_SRGB; |
Vishnu Nair | 6035634 | 2018-11-13 13:00:45 -0800 | [diff] [blame] | 56 | } |
Marissa Wall | 61c5862 | 2018-07-18 10:12:20 -0700 | [diff] [blame] | 57 | |
Alec Mouri | 4545a8a | 2019-08-08 20:05:32 -0700 | [diff] [blame] | 58 | BufferStateLayer::~BufferStateLayer() { |
chaviw | b4c6e58 | 2019-08-16 14:35:07 -0700 | [diff] [blame] | 59 | // The original layer and the clone layer share the same texture and buffer. Therefore, only |
| 60 | // one of the layers, in this case the original layer, needs to handle the deletion. The |
| 61 | // original layer and the clone should be removed at the same time so there shouldn't be any |
| 62 | // issue with the clone layer trying to use the texture. |
| 63 | if (mBufferInfo.mBuffer != nullptr && !isClone()) { |
chaviw | d62d306 | 2019-09-04 14:48:02 -0700 | [diff] [blame] | 64 | // Ensure that mBuffer is uncached from RenderEngine here, as |
Alec Mouri | 4545a8a | 2019-08-08 20:05:32 -0700 | [diff] [blame] | 65 | // RenderEngine may have been using the buffer as an external texture |
| 66 | // after the client uncached the buffer. |
| 67 | auto& engine(mFlinger->getRenderEngine()); |
chaviw | d62d306 | 2019-09-04 14:48:02 -0700 | [diff] [blame] | 68 | engine.unbindExternalTextureBuffer(mBufferInfo.mBuffer->getId()); |
Alec Mouri | 4545a8a | 2019-08-08 20:05:32 -0700 | [diff] [blame] | 69 | } |
| 70 | } |
| 71 | |
Robert Carr | 8d95853 | 2020-11-10 14:09:16 -0800 | [diff] [blame] | 72 | status_t BufferStateLayer::addReleaseFence(const sp<CallbackHandle>& ch, |
| 73 | const sp<Fence>& fence) { |
| 74 | if (ch == nullptr) { |
| 75 | return OK; |
| 76 | } |
| 77 | if (!ch->previousReleaseFence.get()) { |
| 78 | ch->previousReleaseFence = fence; |
| 79 | return OK; |
| 80 | } |
| 81 | |
| 82 | // Below logic is lifted from ConsumerBase.cpp: |
| 83 | // Check status of fences first because merging is expensive. |
| 84 | // Merging an invalid fence with any other fence results in an |
| 85 | // invalid fence. |
| 86 | auto currentStatus = ch->previousReleaseFence->getStatus(); |
| 87 | if (currentStatus == Fence::Status::Invalid) { |
| 88 | ALOGE("Existing fence has invalid state, layer: %s", mName.c_str()); |
| 89 | return BAD_VALUE; |
| 90 | } |
| 91 | |
| 92 | auto incomingStatus = fence->getStatus(); |
| 93 | if (incomingStatus == Fence::Status::Invalid) { |
| 94 | ALOGE("New fence has invalid state, layer: %s", mName.c_str()); |
| 95 | ch->previousReleaseFence = fence; |
| 96 | return BAD_VALUE; |
| 97 | } |
| 98 | |
| 99 | // If both fences are signaled or both are unsignaled, we need to merge |
| 100 | // them to get an accurate timestamp. |
| 101 | if (currentStatus == incomingStatus) { |
| 102 | char fenceName[32] = {}; |
| 103 | snprintf(fenceName, 32, "%.28s", mName.c_str()); |
| 104 | sp<Fence> mergedFence = Fence::merge( |
| 105 | fenceName, ch->previousReleaseFence, fence); |
| 106 | if (!mergedFence.get()) { |
| 107 | ALOGE("failed to merge release fences, layer: %s", mName.c_str()); |
| 108 | // synchronization is broken, the best we can do is hope fences |
| 109 | // signal in order so the new fence will act like a union |
| 110 | ch->previousReleaseFence = fence; |
| 111 | return BAD_VALUE; |
| 112 | } |
| 113 | ch->previousReleaseFence = mergedFence; |
| 114 | } else if (incomingStatus == Fence::Status::Unsignaled) { |
| 115 | // If one fence has signaled and the other hasn't, the unsignaled |
| 116 | // fence will approximately correspond with the correct timestamp. |
| 117 | // There's a small race if both fences signal at about the same time |
| 118 | // and their statuses are retrieved with unfortunate timing. However, |
| 119 | // by this point, they will have both signaled and only the timestamp |
| 120 | // will be slightly off; any dependencies after this point will |
| 121 | // already have been met. |
| 122 | ch->previousReleaseFence = fence; |
| 123 | } |
| 124 | // else if (currentStatus == Fence::Status::Unsignaled) is a no-op. |
| 125 | |
| 126 | return OK; |
| 127 | } |
| 128 | |
Marissa Wall | 61c5862 | 2018-07-18 10:12:20 -0700 | [diff] [blame] | 129 | // ----------------------------------------------------------------------- |
| 130 | // Interface implementation for Layer |
| 131 | // ----------------------------------------------------------------------- |
Marissa Wall | fda30bb | 2018-10-12 11:34:28 -0700 | [diff] [blame] | 132 | void BufferStateLayer::onLayerDisplayed(const sp<Fence>& releaseFence) { |
Robert Carr | 8d95853 | 2020-11-10 14:09:16 -0800 | [diff] [blame] | 133 | if (!releaseFence->isValid()) { |
| 134 | return; |
| 135 | } |
Marissa Wall | 5a68a77 | 2018-12-22 17:43:42 -0800 | [diff] [blame] | 136 | // The previous release fence notifies the client that SurfaceFlinger is done with the previous |
| 137 | // buffer that was presented on this layer. The first transaction that came in this frame that |
| 138 | // replaced the previous buffer on this layer needs this release fence, because the fence will |
| 139 | // let the client know when that previous buffer is removed from the screen. |
| 140 | // |
| 141 | // Every other transaction on this layer does not need a release fence because no other |
| 142 | // Transactions that were set on this layer this frame are going to have their preceeding buffer |
| 143 | // removed from the display this frame. |
| 144 | // |
| 145 | // For example, if we have 3 transactions this frame. The first transaction doesn't contain a |
| 146 | // buffer so it doesn't need a previous release fence because the layer still needs the previous |
| 147 | // buffer. The second transaction contains a buffer so it needs a previous release fence because |
| 148 | // the previous buffer will be released this frame. The third transaction also contains a |
| 149 | // buffer. It replaces the buffer in the second transaction. The buffer in the second |
| 150 | // transaction will now no longer be presented so it is released immediately and the third |
| 151 | // transaction doesn't need a previous release fence. |
Robert Carr | 8d95853 | 2020-11-10 14:09:16 -0800 | [diff] [blame] | 152 | sp<CallbackHandle> ch; |
Marissa Wall | 5a68a77 | 2018-12-22 17:43:42 -0800 | [diff] [blame] | 153 | for (auto& handle : mDrawingState.callbackHandles) { |
| 154 | if (handle->releasePreviousBuffer) { |
Robert Carr | 8d95853 | 2020-11-10 14:09:16 -0800 | [diff] [blame] | 155 | ch = handle; |
Marissa Wall | 5a68a77 | 2018-12-22 17:43:42 -0800 | [diff] [blame] | 156 | break; |
| 157 | } |
| 158 | } |
Robert Carr | 8d95853 | 2020-11-10 14:09:16 -0800 | [diff] [blame] | 159 | auto status = addReleaseFence(ch, releaseFence); |
| 160 | if (status != OK) { |
| 161 | ALOGE("Failed to add release fence for layer %s", getName().c_str()); |
| 162 | } |
Mikael Pessa | 2e1608f | 2019-07-19 11:25:35 -0700 | [diff] [blame] | 163 | |
Valerie Hau | bf78464 | 2020-01-29 07:25:23 -0800 | [diff] [blame] | 164 | mPreviousReleaseFence = releaseFence; |
| 165 | |
Mikael Pessa | 2e1608f | 2019-07-19 11:25:35 -0700 | [diff] [blame] | 166 | // Prevent tracing the same release multiple times. |
| 167 | if (mPreviousFrameNumber != mPreviousReleasedFrameNumber) { |
Mikael Pessa | 2e1608f | 2019-07-19 11:25:35 -0700 | [diff] [blame] | 168 | mPreviousReleasedFrameNumber = mPreviousFrameNumber; |
| 169 | } |
Marissa Wall | 61c5862 | 2018-07-18 10:12:20 -0700 | [diff] [blame] | 170 | } |
| 171 | |
Jorim Jaggi | 9c03b50 | 2020-11-24 23:51:31 +0100 | [diff] [blame] | 172 | void BufferStateLayer::onSurfaceFrameCreated( |
| 173 | const std::shared_ptr<frametimeline::SurfaceFrame>& surfaceFrame) { |
Adithya Srinivasan | d17c7da | 2021-03-05 20:43:32 +0000 | [diff] [blame] | 174 | while (mPendingJankClassifications.size() >= kPendingClassificationMaxSurfaceFrames) { |
| 175 | // Too many SurfaceFrames pending classification. The front of the deque is probably not |
| 176 | // tracked by FrameTimeline and will never be presented. This will only result in a memory |
| 177 | // leak. |
| 178 | ALOGW("Removing the front of pending jank deque from layer - %s to prevent memory leak", |
| 179 | mName.c_str()); |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame^] | 180 | std::string miniDump = mPendingJankClassifications.front()->miniDump(); |
| 181 | ALOGD("Head SurfaceFrame mini dump\n%s", miniDump.c_str()); |
Adithya Srinivasan | d17c7da | 2021-03-05 20:43:32 +0000 | [diff] [blame] | 182 | mPendingJankClassifications.pop_front(); |
| 183 | } |
Jorim Jaggi | 9c03b50 | 2020-11-24 23:51:31 +0100 | [diff] [blame] | 184 | mPendingJankClassifications.emplace_back(surfaceFrame); |
| 185 | } |
| 186 | |
Valerie Hau | bf78464 | 2020-01-29 07:25:23 -0800 | [diff] [blame] | 187 | void BufferStateLayer::releasePendingBuffer(nsecs_t dequeueReadyTime) { |
Valerie Hau | 32cdc1f | 2019-10-21 14:45:54 -0700 | [diff] [blame] | 188 | for (const auto& handle : mDrawingState.callbackHandles) { |
| 189 | handle->transformHint = mTransformHint; |
Valerie Hau | 871d635 | 2020-01-29 08:44:02 -0800 | [diff] [blame] | 190 | handle->dequeueReadyTime = dequeueReadyTime; |
Valerie Hau | 32cdc1f | 2019-10-21 14:45:54 -0700 | [diff] [blame] | 191 | } |
| 192 | |
Jorim Jaggi | 9c03b50 | 2020-11-24 23:51:31 +0100 | [diff] [blame] | 193 | std::vector<JankData> jankData; |
| 194 | jankData.reserve(mPendingJankClassifications.size()); |
| 195 | while (!mPendingJankClassifications.empty() |
| 196 | && mPendingJankClassifications.front()->getJankType()) { |
| 197 | std::shared_ptr<frametimeline::SurfaceFrame> surfaceFrame = |
| 198 | mPendingJankClassifications.front(); |
| 199 | mPendingJankClassifications.pop_front(); |
| 200 | jankData.emplace_back( |
| 201 | JankData(surfaceFrame->getToken(), surfaceFrame->getJankType().value())); |
| 202 | } |
| 203 | |
Robert Carr | 9a803c3 | 2021-01-14 16:57:58 -0800 | [diff] [blame] | 204 | mFlinger->getTransactionCallbackInvoker().finalizePendingCallbackHandles( |
Jorim Jaggi | 9c03b50 | 2020-11-24 23:51:31 +0100 | [diff] [blame] | 205 | mDrawingState.callbackHandles, jankData); |
Marissa Wall | 5a68a77 | 2018-12-22 17:43:42 -0800 | [diff] [blame] | 206 | |
| 207 | mDrawingState.callbackHandles = {}; |
Valerie Hau | bf78464 | 2020-01-29 07:25:23 -0800 | [diff] [blame] | 208 | |
| 209 | const sp<Fence>& releaseFence(mPreviousReleaseFence); |
| 210 | std::shared_ptr<FenceTime> releaseFenceTime = std::make_shared<FenceTime>(releaseFence); |
| 211 | { |
| 212 | Mutex::Autolock lock(mFrameEventHistoryMutex); |
| 213 | if (mPreviousFrameNumber != 0) { |
| 214 | mFrameEventHistory.addRelease(mPreviousFrameNumber, dequeueReadyTime, |
| 215 | std::move(releaseFenceTime)); |
| 216 | } |
| 217 | } |
Marissa Wall | 61c5862 | 2018-07-18 10:12:20 -0700 | [diff] [blame] | 218 | } |
| 219 | |
Valerie Hau | 871d635 | 2020-01-29 08:44:02 -0800 | [diff] [blame] | 220 | void BufferStateLayer::finalizeFrameEventHistory(const std::shared_ptr<FenceTime>& glDoneFence, |
| 221 | const CompositorTiming& compositorTiming) { |
| 222 | for (const auto& handle : mDrawingState.callbackHandles) { |
| 223 | handle->gpuCompositionDoneFence = glDoneFence; |
| 224 | handle->compositorTiming = compositorTiming; |
| 225 | } |
| 226 | } |
| 227 | |
Marissa Wall | e2ffb42 | 2018-10-12 11:33:52 -0700 | [diff] [blame] | 228 | bool BufferStateLayer::willPresentCurrentTransaction() const { |
| 229 | // Returns true if the most recent Transaction applied to CurrentState will be presented. |
Robert Carr | 321e83c | 2019-08-19 15:49:30 -0700 | [diff] [blame] | 230 | return (getSidebandStreamChanged() || getAutoRefresh() || |
Valerie Hau | aa19456 | 2019-02-05 16:21:38 -0800 | [diff] [blame] | 231 | (mCurrentState.modified && |
chaviw | 8ba8b07 | 2021-01-25 14:55:46 -0800 | [diff] [blame] | 232 | (mCurrentState.buffer != nullptr || mCurrentState.bgColorLayer != nullptr))); |
Marissa Wall | 61c5862 | 2018-07-18 10:12:20 -0700 | [diff] [blame] | 233 | } |
| 234 | |
Valerie Hau | 3282b3c | 2020-02-03 15:37:27 -0800 | [diff] [blame] | 235 | /* TODO: vhau uncomment once deferred transaction migration complete in |
| 236 | * WindowManager |
Lloyd Pique | 0449b0f | 2018-12-20 16:23:45 -0800 | [diff] [blame] | 237 | void BufferStateLayer::pushPendingState() { |
| 238 | if (!mCurrentState.modified) { |
Marissa Wall | 61c5862 | 2018-07-18 10:12:20 -0700 | [diff] [blame] | 239 | return; |
| 240 | } |
Lloyd Pique | 0449b0f | 2018-12-20 16:23:45 -0800 | [diff] [blame] | 241 | mPendingStates.push_back(mCurrentState); |
Dominik Laskowski | 87a07e4 | 2019-10-10 20:38:02 -0700 | [diff] [blame] | 242 | ATRACE_INT(mTransactionName.c_str(), mPendingStates.size()); |
Marissa Wall | 61c5862 | 2018-07-18 10:12:20 -0700 | [diff] [blame] | 243 | } |
Valerie Hau | 3282b3c | 2020-02-03 15:37:27 -0800 | [diff] [blame] | 244 | */ |
Marissa Wall | 61c5862 | 2018-07-18 10:12:20 -0700 | [diff] [blame] | 245 | |
| 246 | bool BufferStateLayer::applyPendingStates(Layer::State* stateToCommit) { |
Valerie Hau | 3282b3c | 2020-02-03 15:37:27 -0800 | [diff] [blame] | 247 | mCurrentStateModified = mCurrentState.modified; |
| 248 | bool stateUpdateAvailable = Layer::applyPendingStates(stateToCommit); |
| 249 | mCurrentStateModified = stateUpdateAvailable && mCurrentStateModified; |
Lloyd Pique | 0449b0f | 2018-12-20 16:23:45 -0800 | [diff] [blame] | 250 | mCurrentState.modified = false; |
Marissa Wall | 61c5862 | 2018-07-18 10:12:20 -0700 | [diff] [blame] | 251 | return stateUpdateAvailable; |
| 252 | } |
| 253 | |
Marissa Wall | 861616d | 2018-10-22 12:52:23 -0700 | [diff] [blame] | 254 | // Crop that applies to the window |
| 255 | Rect BufferStateLayer::getCrop(const Layer::State& /*s*/) const { |
| 256 | return Rect::INVALID_RECT; |
Marissa Wall | 61c5862 | 2018-07-18 10:12:20 -0700 | [diff] [blame] | 257 | } |
| 258 | |
| 259 | bool BufferStateLayer::setTransform(uint32_t transform) { |
Lloyd Pique | 0449b0f | 2018-12-20 16:23:45 -0800 | [diff] [blame] | 260 | if (mCurrentState.transform == transform) return false; |
Lloyd Pique | 0449b0f | 2018-12-20 16:23:45 -0800 | [diff] [blame] | 261 | mCurrentState.transform = transform; |
| 262 | mCurrentState.modified = true; |
Marissa Wall | 61c5862 | 2018-07-18 10:12:20 -0700 | [diff] [blame] | 263 | setTransactionFlags(eTransactionNeeded); |
| 264 | return true; |
| 265 | } |
| 266 | |
| 267 | bool BufferStateLayer::setTransformToDisplayInverse(bool transformToDisplayInverse) { |
Lloyd Pique | 0449b0f | 2018-12-20 16:23:45 -0800 | [diff] [blame] | 268 | if (mCurrentState.transformToDisplayInverse == transformToDisplayInverse) return false; |
| 269 | mCurrentState.sequence++; |
| 270 | mCurrentState.transformToDisplayInverse = transformToDisplayInverse; |
| 271 | mCurrentState.modified = true; |
Marissa Wall | 61c5862 | 2018-07-18 10:12:20 -0700 | [diff] [blame] | 272 | setTransactionFlags(eTransactionNeeded); |
| 273 | return true; |
| 274 | } |
| 275 | |
| 276 | bool BufferStateLayer::setCrop(const Rect& crop) { |
Marissa Wall | 290ad08 | 2019-03-06 13:23:47 -0800 | [diff] [blame] | 277 | Rect c = crop; |
| 278 | if (c.left < 0) { |
| 279 | c.left = 0; |
| 280 | } |
| 281 | if (c.top < 0) { |
| 282 | c.top = 0; |
| 283 | } |
| 284 | // If the width and/or height are < 0, make it [0, 0, -1, -1] so the equality comparision below |
| 285 | // treats all invalid rectangles the same. |
| 286 | if (!c.isValid()) { |
| 287 | c.makeInvalid(); |
| 288 | } |
| 289 | |
| 290 | if (mCurrentState.crop == c) return false; |
Marissa Wall | 290ad08 | 2019-03-06 13:23:47 -0800 | [diff] [blame] | 291 | mCurrentState.crop = c; |
Lloyd Pique | 0449b0f | 2018-12-20 16:23:45 -0800 | [diff] [blame] | 292 | mCurrentState.modified = true; |
Marissa Wall | 61c5862 | 2018-07-18 10:12:20 -0700 | [diff] [blame] | 293 | setTransactionFlags(eTransactionNeeded); |
| 294 | return true; |
| 295 | } |
| 296 | |
Marissa Wall | 861616d | 2018-10-22 12:52:23 -0700 | [diff] [blame] | 297 | bool BufferStateLayer::setFrame(const Rect& frame) { |
| 298 | int x = frame.left; |
| 299 | int y = frame.top; |
| 300 | int w = frame.getWidth(); |
| 301 | int h = frame.getHeight(); |
| 302 | |
Marissa Wall | 0f3242d | 2018-12-20 15:10:22 -0800 | [diff] [blame] | 303 | if (x < 0) { |
| 304 | x = 0; |
| 305 | w = frame.right; |
| 306 | } |
| 307 | |
| 308 | if (y < 0) { |
| 309 | y = 0; |
| 310 | h = frame.bottom; |
| 311 | } |
| 312 | |
Lloyd Pique | 0449b0f | 2018-12-20 16:23:45 -0800 | [diff] [blame] | 313 | if (mCurrentState.active.transform.tx() == x && mCurrentState.active.transform.ty() == y && |
| 314 | mCurrentState.active.w == w && mCurrentState.active.h == h) { |
Marissa Wall | 861616d | 2018-10-22 12:52:23 -0700 | [diff] [blame] | 315 | return false; |
| 316 | } |
| 317 | |
| 318 | if (!frame.isValid()) { |
| 319 | x = y = w = h = 0; |
| 320 | } |
Lloyd Pique | 0449b0f | 2018-12-20 16:23:45 -0800 | [diff] [blame] | 321 | mCurrentState.active.transform.set(x, y); |
| 322 | mCurrentState.active.w = w; |
| 323 | mCurrentState.active.h = h; |
Marissa Wall | 861616d | 2018-10-22 12:52:23 -0700 | [diff] [blame] | 324 | |
Lloyd Pique | 0449b0f | 2018-12-20 16:23:45 -0800 | [diff] [blame] | 325 | mCurrentState.sequence++; |
| 326 | mCurrentState.modified = true; |
Marissa Wall | 861616d | 2018-10-22 12:52:23 -0700 | [diff] [blame] | 327 | setTransactionFlags(eTransactionNeeded); |
| 328 | return true; |
| 329 | } |
| 330 | |
Valerie Hau | 871d635 | 2020-01-29 08:44:02 -0800 | [diff] [blame] | 331 | bool BufferStateLayer::addFrameEvent(const sp<Fence>& acquireFence, nsecs_t postedTime, |
| 332 | nsecs_t desiredPresentTime) { |
Valerie Hau | bf78464 | 2020-01-29 07:25:23 -0800 | [diff] [blame] | 333 | Mutex::Autolock lock(mFrameEventHistoryMutex); |
| 334 | mAcquireTimeline.updateSignalTimes(); |
| 335 | std::shared_ptr<FenceTime> acquireFenceTime = |
| 336 | std::make_shared<FenceTime>((acquireFence ? acquireFence : Fence::NO_FENCE)); |
| 337 | NewFrameEventsEntry newTimestamps = {mCurrentState.frameNumber, postedTime, desiredPresentTime, |
| 338 | acquireFenceTime}; |
Valerie Hau | 871d635 | 2020-01-29 08:44:02 -0800 | [diff] [blame] | 339 | mFrameEventHistory.setProducerWantsEvents(); |
Valerie Hau | bf78464 | 2020-01-29 07:25:23 -0800 | [diff] [blame] | 340 | mFrameEventHistory.addQueue(newTimestamps); |
| 341 | return true; |
| 342 | } |
| 343 | |
| 344 | bool BufferStateLayer::setBuffer(const sp<GraphicBuffer>& buffer, const sp<Fence>& acquireFence, |
Ady Abraham | f0c5649 | 2020-12-17 18:04:15 -0800 | [diff] [blame] | 345 | nsecs_t postTime, nsecs_t desiredPresentTime, bool isAutoTimestamp, |
Vishnu Nair | adf632b | 2021-01-07 14:05:08 -0800 | [diff] [blame] | 346 | const client_cache_t& clientCacheId, uint64_t frameNumber, |
Adithya Srinivasan | b238cd5 | 2021-02-04 17:54:05 +0000 | [diff] [blame] | 347 | std::optional<nsecs_t> dequeueTime, |
Adithya Srinivasan | b9a7dab | 2021-01-14 23:49:46 +0000 | [diff] [blame] | 348 | const FrameTimelineInfo& info) { |
Robert Carr | 0c1966e | 2020-10-19 12:12:08 -0700 | [diff] [blame] | 349 | ATRACE_CALL(); |
| 350 | |
Lloyd Pique | 0449b0f | 2018-12-20 16:23:45 -0800 | [diff] [blame] | 351 | if (mCurrentState.buffer) { |
Marissa Wall | fda30bb | 2018-10-12 11:34:28 -0700 | [diff] [blame] | 352 | mReleasePreviousBuffer = true; |
Robert Carr | 7121caf | 2020-12-15 13:07:32 -0800 | [diff] [blame] | 353 | if (mCurrentState.buffer != mDrawingState.buffer) { |
| 354 | // If mCurrentState has a buffer, and we are about to update again |
| 355 | // before swapping to drawing state, then the first buffer will be |
| 356 | // dropped and we should decrement the pending buffer count. |
| 357 | decrementPendingBufferCount(); |
Adithya Srinivasan | b9a7dab | 2021-01-14 23:49:46 +0000 | [diff] [blame] | 358 | if (mCurrentState.bufferSurfaceFrameTX != nullptr) { |
| 359 | addSurfaceFrameDroppedForBuffer(mCurrentState.bufferSurfaceFrameTX); |
| 360 | mCurrentState.bufferSurfaceFrameTX.reset(); |
| 361 | } |
Robert Carr | 7121caf | 2020-12-15 13:07:32 -0800 | [diff] [blame] | 362 | } |
Marissa Wall | fda30bb | 2018-10-12 11:34:28 -0700 | [diff] [blame] | 363 | } |
| 364 | |
Vishnu Nair | 6b7c5c9 | 2020-09-29 17:27:05 -0700 | [diff] [blame] | 365 | mCurrentState.frameNumber = frameNumber; |
Valerie Hau | 2f54d64 | 2020-01-22 09:37:03 -0800 | [diff] [blame] | 366 | |
Lloyd Pique | 0449b0f | 2018-12-20 16:23:45 -0800 | [diff] [blame] | 367 | mCurrentState.buffer = buffer; |
Marissa Wall | 947d34e | 2019-03-29 14:03:53 -0700 | [diff] [blame] | 368 | mCurrentState.clientCacheId = clientCacheId; |
Lloyd Pique | 0449b0f | 2018-12-20 16:23:45 -0800 | [diff] [blame] | 369 | mCurrentState.modified = true; |
Marissa Wall | 61c5862 | 2018-07-18 10:12:20 -0700 | [diff] [blame] | 370 | setTransactionFlags(eTransactionNeeded); |
Ady Abraham | 09bd392 | 2019-04-08 10:44:56 -0700 | [diff] [blame] | 371 | |
Yiwei Zhang | 1a88c40 | 2019-11-18 10:43:58 -0800 | [diff] [blame] | 372 | const int32_t layerId = getSequence(); |
Valerie Hau | 134651a | 2020-01-28 16:21:22 -0800 | [diff] [blame] | 373 | mFlinger->mTimeStats->setPostTime(layerId, mCurrentState.frameNumber, getName().c_str(), |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 374 | mOwnerUid, postTime); |
chaviw | fa67b55 | 2019-08-12 16:51:55 -0700 | [diff] [blame] | 375 | mCurrentState.desiredPresentTime = desiredPresentTime; |
Ady Abraham | f0c5649 | 2020-12-17 18:04:15 -0800 | [diff] [blame] | 376 | mCurrentState.isAutoTimestamp = isAutoTimestamp; |
Ady Abraham | 09bd392 | 2019-04-08 10:44:56 -0700 | [diff] [blame] | 377 | |
Ady Abraham | f0c5649 | 2020-12-17 18:04:15 -0800 | [diff] [blame] | 378 | mFlinger->mScheduler->recordLayerHistory(this, isAutoTimestamp ? 0 : desiredPresentTime, |
Ady Abraham | 5def733 | 2020-05-29 16:13:47 -0700 | [diff] [blame] | 379 | LayerHistory::LayerUpdateType::Buffer); |
Ady Abraham | 09bd392 | 2019-04-08 10:44:56 -0700 | [diff] [blame] | 380 | |
Ady Abraham | f0c5649 | 2020-12-17 18:04:15 -0800 | [diff] [blame] | 381 | addFrameEvent(acquireFence, postTime, isAutoTimestamp ? 0 : desiredPresentTime); |
Adithya Srinivasan | b9a7dab | 2021-01-14 23:49:46 +0000 | [diff] [blame] | 382 | |
Adithya Srinivasan | 891004e | 2021-02-12 20:20:47 +0000 | [diff] [blame] | 383 | setFrameTimelineVsyncForBufferTransaction(info, postTime); |
Adithya Srinivasan | b9a7dab | 2021-01-14 23:49:46 +0000 | [diff] [blame] | 384 | |
Adithya Srinivasan | b238cd5 | 2021-02-04 17:54:05 +0000 | [diff] [blame] | 385 | if (dequeueTime && *dequeueTime != 0) { |
| 386 | const uint64_t bufferId = buffer->getId(); |
| 387 | mFlinger->mFrameTracer->traceNewLayer(layerId, getName().c_str()); |
| 388 | mFlinger->mFrameTracer->traceTimestamp(layerId, bufferId, frameNumber, *dequeueTime, |
| 389 | FrameTracer::FrameEvent::DEQUEUE); |
| 390 | mFlinger->mFrameTracer->traceTimestamp(layerId, bufferId, frameNumber, postTime, |
| 391 | FrameTracer::FrameEvent::QUEUE); |
| 392 | } |
Marissa Wall | 61c5862 | 2018-07-18 10:12:20 -0700 | [diff] [blame] | 393 | return true; |
| 394 | } |
| 395 | |
| 396 | bool BufferStateLayer::setAcquireFence(const sp<Fence>& fence) { |
Marissa Wall | fda30bb | 2018-10-12 11:34:28 -0700 | [diff] [blame] | 397 | // The acquire fences of BufferStateLayers have already signaled before they are set |
| 398 | mCallbackHandleAcquireTime = fence->getSignalTime(); |
| 399 | |
Lloyd Pique | 0449b0f | 2018-12-20 16:23:45 -0800 | [diff] [blame] | 400 | mCurrentState.acquireFence = fence; |
| 401 | mCurrentState.modified = true; |
Marissa Wall | 61c5862 | 2018-07-18 10:12:20 -0700 | [diff] [blame] | 402 | setTransactionFlags(eTransactionNeeded); |
| 403 | return true; |
| 404 | } |
| 405 | |
| 406 | bool BufferStateLayer::setDataspace(ui::Dataspace dataspace) { |
Lloyd Pique | 0449b0f | 2018-12-20 16:23:45 -0800 | [diff] [blame] | 407 | if (mCurrentState.dataspace == dataspace) return false; |
Lloyd Pique | 0449b0f | 2018-12-20 16:23:45 -0800 | [diff] [blame] | 408 | mCurrentState.dataspace = dataspace; |
| 409 | mCurrentState.modified = true; |
Marissa Wall | 61c5862 | 2018-07-18 10:12:20 -0700 | [diff] [blame] | 410 | setTransactionFlags(eTransactionNeeded); |
| 411 | return true; |
| 412 | } |
| 413 | |
| 414 | bool BufferStateLayer::setHdrMetadata(const HdrMetadata& hdrMetadata) { |
Lloyd Pique | 0449b0f | 2018-12-20 16:23:45 -0800 | [diff] [blame] | 415 | if (mCurrentState.hdrMetadata == hdrMetadata) return false; |
Lloyd Pique | 0449b0f | 2018-12-20 16:23:45 -0800 | [diff] [blame] | 416 | mCurrentState.hdrMetadata = hdrMetadata; |
| 417 | mCurrentState.modified = true; |
Marissa Wall | 61c5862 | 2018-07-18 10:12:20 -0700 | [diff] [blame] | 418 | setTransactionFlags(eTransactionNeeded); |
| 419 | return true; |
| 420 | } |
| 421 | |
| 422 | bool BufferStateLayer::setSurfaceDamageRegion(const Region& surfaceDamage) { |
Lloyd Pique | 0449b0f | 2018-12-20 16:23:45 -0800 | [diff] [blame] | 423 | mCurrentState.surfaceDamageRegion = surfaceDamage; |
| 424 | mCurrentState.modified = true; |
Marissa Wall | 61c5862 | 2018-07-18 10:12:20 -0700 | [diff] [blame] | 425 | setTransactionFlags(eTransactionNeeded); |
| 426 | return true; |
| 427 | } |
| 428 | |
| 429 | bool BufferStateLayer::setApi(int32_t api) { |
Lloyd Pique | 0449b0f | 2018-12-20 16:23:45 -0800 | [diff] [blame] | 430 | if (mCurrentState.api == api) return false; |
Lloyd Pique | 0449b0f | 2018-12-20 16:23:45 -0800 | [diff] [blame] | 431 | mCurrentState.api = api; |
| 432 | mCurrentState.modified = true; |
Marissa Wall | 61c5862 | 2018-07-18 10:12:20 -0700 | [diff] [blame] | 433 | setTransactionFlags(eTransactionNeeded); |
| 434 | return true; |
| 435 | } |
| 436 | |
| 437 | bool BufferStateLayer::setSidebandStream(const sp<NativeHandle>& sidebandStream) { |
Lloyd Pique | 0449b0f | 2018-12-20 16:23:45 -0800 | [diff] [blame] | 438 | if (mCurrentState.sidebandStream == sidebandStream) return false; |
Lloyd Pique | 0449b0f | 2018-12-20 16:23:45 -0800 | [diff] [blame] | 439 | mCurrentState.sidebandStream = sidebandStream; |
| 440 | mCurrentState.modified = true; |
Marissa Wall | 61c5862 | 2018-07-18 10:12:20 -0700 | [diff] [blame] | 441 | setTransactionFlags(eTransactionNeeded); |
| 442 | |
| 443 | if (!mSidebandStreamChanged.exchange(true)) { |
| 444 | // mSidebandStreamChanged was false |
| 445 | mFlinger->signalLayerUpdate(); |
| 446 | } |
| 447 | return true; |
| 448 | } |
| 449 | |
Marissa Wall | e2ffb42 | 2018-10-12 11:33:52 -0700 | [diff] [blame] | 450 | bool BufferStateLayer::setTransactionCompletedListeners( |
| 451 | const std::vector<sp<CallbackHandle>>& handles) { |
Marissa Wall | fda30bb | 2018-10-12 11:34:28 -0700 | [diff] [blame] | 452 | // If there is no handle, we will not send a callback so reset mReleasePreviousBuffer and return |
Marissa Wall | e2ffb42 | 2018-10-12 11:33:52 -0700 | [diff] [blame] | 453 | if (handles.empty()) { |
Marissa Wall | fda30bb | 2018-10-12 11:34:28 -0700 | [diff] [blame] | 454 | mReleasePreviousBuffer = false; |
Marissa Wall | e2ffb42 | 2018-10-12 11:33:52 -0700 | [diff] [blame] | 455 | return false; |
| 456 | } |
| 457 | |
| 458 | const bool willPresent = willPresentCurrentTransaction(); |
| 459 | |
| 460 | for (const auto& handle : handles) { |
Marissa Wall | fda30bb | 2018-10-12 11:34:28 -0700 | [diff] [blame] | 461 | // If this transaction set a buffer on this layer, release its previous buffer |
| 462 | handle->releasePreviousBuffer = mReleasePreviousBuffer; |
| 463 | |
Marissa Wall | e2ffb42 | 2018-10-12 11:33:52 -0700 | [diff] [blame] | 464 | // If this layer will be presented in this frame |
| 465 | if (willPresent) { |
Marissa Wall | fda30bb | 2018-10-12 11:34:28 -0700 | [diff] [blame] | 466 | // If this transaction set an acquire fence on this layer, set its acquire time |
| 467 | handle->acquireTime = mCallbackHandleAcquireTime; |
Vishnu Nair | 935590e | 2021-02-10 13:05:52 -0800 | [diff] [blame] | 468 | handle->frameNumber = mCurrentState.frameNumber; |
Marissa Wall | fda30bb | 2018-10-12 11:34:28 -0700 | [diff] [blame] | 469 | |
Marissa Wall | e2ffb42 | 2018-10-12 11:33:52 -0700 | [diff] [blame] | 470 | // Notify the transaction completed thread that there is a pending latched callback |
| 471 | // handle |
Robert Carr | 9a803c3 | 2021-01-14 16:57:58 -0800 | [diff] [blame] | 472 | mFlinger->getTransactionCallbackInvoker().registerPendingCallbackHandle(handle); |
Marissa Wall | e2ffb42 | 2018-10-12 11:33:52 -0700 | [diff] [blame] | 473 | |
| 474 | // Store so latched time and release fence can be set |
Lloyd Pique | 0449b0f | 2018-12-20 16:23:45 -0800 | [diff] [blame] | 475 | mCurrentState.callbackHandles.push_back(handle); |
Marissa Wall | e2ffb42 | 2018-10-12 11:33:52 -0700 | [diff] [blame] | 476 | |
| 477 | } else { // If this layer will NOT need to be relatched and presented this frame |
| 478 | // Notify the transaction completed thread this handle is done |
Robert Carr | 9a803c3 | 2021-01-14 16:57:58 -0800 | [diff] [blame] | 479 | mFlinger->getTransactionCallbackInvoker().registerUnpresentedCallbackHandle(handle); |
Marissa Wall | e2ffb42 | 2018-10-12 11:33:52 -0700 | [diff] [blame] | 480 | } |
| 481 | } |
| 482 | |
Marissa Wall | fda30bb | 2018-10-12 11:34:28 -0700 | [diff] [blame] | 483 | mReleasePreviousBuffer = false; |
| 484 | mCallbackHandleAcquireTime = -1; |
| 485 | |
Marissa Wall | e2ffb42 | 2018-10-12 11:33:52 -0700 | [diff] [blame] | 486 | return willPresent; |
| 487 | } |
| 488 | |
Marissa Wall | 61c5862 | 2018-07-18 10:12:20 -0700 | [diff] [blame] | 489 | bool BufferStateLayer::setTransparentRegionHint(const Region& transparent) { |
Lloyd Pique | 0449b0f | 2018-12-20 16:23:45 -0800 | [diff] [blame] | 490 | mCurrentState.transparentRegionHint = transparent; |
| 491 | mCurrentState.modified = true; |
Marissa Wall | 61c5862 | 2018-07-18 10:12:20 -0700 | [diff] [blame] | 492 | setTransactionFlags(eTransactionNeeded); |
| 493 | return true; |
| 494 | } |
| 495 | |
Marissa Wall | 861616d | 2018-10-22 12:52:23 -0700 | [diff] [blame] | 496 | Rect BufferStateLayer::getBufferSize(const State& s) const { |
| 497 | // for buffer state layers we use the display frame size as the buffer size. |
| 498 | if (getActiveWidth(s) < UINT32_MAX && getActiveHeight(s) < UINT32_MAX) { |
| 499 | return Rect(getActiveWidth(s), getActiveHeight(s)); |
Marissa Wall | 61c5862 | 2018-07-18 10:12:20 -0700 | [diff] [blame] | 500 | } |
| 501 | |
chaviw | 7e72caf | 2020-12-02 16:50:43 -0800 | [diff] [blame] | 502 | if (mBufferInfo.mBuffer == nullptr) { |
| 503 | return Rect::INVALID_RECT; |
| 504 | } |
| 505 | |
Marissa Wall | 861616d | 2018-10-22 12:52:23 -0700 | [diff] [blame] | 506 | // if the display frame is not defined, use the parent bounds as the buffer size. |
| 507 | const auto& p = mDrawingParent.promote(); |
| 508 | if (p != nullptr) { |
Vishnu Nair | 4351ad5 | 2019-02-11 14:13:02 -0800 | [diff] [blame] | 509 | Rect parentBounds = Rect(p->getBounds(Region())); |
Marissa Wall | 861616d | 2018-10-22 12:52:23 -0700 | [diff] [blame] | 510 | if (!parentBounds.isEmpty()) { |
| 511 | return parentBounds; |
| 512 | } |
| 513 | } |
| 514 | |
Marissa Wall | 861616d | 2018-10-22 12:52:23 -0700 | [diff] [blame] | 515 | return Rect::INVALID_RECT; |
Marissa Wall | 61c5862 | 2018-07-18 10:12:20 -0700 | [diff] [blame] | 516 | } |
Vishnu Nair | 4351ad5 | 2019-02-11 14:13:02 -0800 | [diff] [blame] | 517 | |
| 518 | FloatRect BufferStateLayer::computeSourceBounds(const FloatRect& parentBounds) const { |
| 519 | const State& s(getDrawingState()); |
| 520 | // for buffer state layers we use the display frame size as the buffer size. |
| 521 | if (getActiveWidth(s) < UINT32_MAX && getActiveHeight(s) < UINT32_MAX) { |
| 522 | return FloatRect(0, 0, getActiveWidth(s), getActiveHeight(s)); |
| 523 | } |
| 524 | |
| 525 | // if the display frame is not defined, use the parent bounds as the buffer size. |
| 526 | return parentBounds; |
| 527 | } |
| 528 | |
Marissa Wall | 61c5862 | 2018-07-18 10:12:20 -0700 | [diff] [blame] | 529 | // ----------------------------------------------------------------------- |
| 530 | |
| 531 | // ----------------------------------------------------------------------- |
| 532 | // Interface implementation for BufferLayer |
| 533 | // ----------------------------------------------------------------------- |
| 534 | bool BufferStateLayer::fenceHasSignaled() const { |
Alec Mouri | 91f6df3 | 2020-01-30 08:48:58 -0800 | [diff] [blame] | 535 | const bool fenceSignaled = |
| 536 | getDrawingState().acquireFence->getStatus() == Fence::Status::Signaled; |
| 537 | if (!fenceSignaled) { |
| 538 | mFlinger->mTimeStats->incrementLatchSkipped(getSequence(), |
| 539 | TimeStats::LatchSkipReason::LateAcquire); |
| 540 | } |
| 541 | |
| 542 | return fenceSignaled; |
Marissa Wall | 61c5862 | 2018-07-18 10:12:20 -0700 | [diff] [blame] | 543 | } |
| 544 | |
Dominik Laskowski | a8955dd | 2019-07-10 10:19:09 -0700 | [diff] [blame] | 545 | bool BufferStateLayer::framePresentTimeIsCurrent(nsecs_t expectedPresentTime) const { |
Ady Abraham | cd1580c | 2019-04-29 15:40:03 -0700 | [diff] [blame] | 546 | if (!hasFrameUpdate() || isRemovedFromCurrentState()) { |
| 547 | return true; |
| 548 | } |
| 549 | |
Ady Abraham | f0c5649 | 2020-12-17 18:04:15 -0800 | [diff] [blame] | 550 | return mCurrentState.isAutoTimestamp || mCurrentState.desiredPresentTime <= expectedPresentTime; |
Ady Abraham | cd1580c | 2019-04-29 15:40:03 -0700 | [diff] [blame] | 551 | } |
| 552 | |
Valerie Hau | 871d635 | 2020-01-29 08:44:02 -0800 | [diff] [blame] | 553 | bool BufferStateLayer::onPreComposition(nsecs_t refreshStartTime) { |
| 554 | for (const auto& handle : mDrawingState.callbackHandles) { |
| 555 | handle->refreshStartTime = refreshStartTime; |
| 556 | } |
| 557 | return BufferLayer::onPreComposition(refreshStartTime); |
| 558 | } |
| 559 | |
Dominik Laskowski | a8955dd | 2019-07-10 10:19:09 -0700 | [diff] [blame] | 560 | uint64_t BufferStateLayer::getFrameNumber(nsecs_t /*expectedPresentTime*/) const { |
Valerie Hau | 134651a | 2020-01-28 16:21:22 -0800 | [diff] [blame] | 561 | return mDrawingState.frameNumber; |
Marissa Wall | 61c5862 | 2018-07-18 10:12:20 -0700 | [diff] [blame] | 562 | } |
| 563 | |
Robert Carr | fe1209c | 2020-02-11 12:25:35 -0800 | [diff] [blame] | 564 | /** |
| 565 | * This is the frameNumber used for deferred transaction signalling. We need to use this because |
| 566 | * of cases where we defer a transaction for a surface to itself. In the BLAST world this |
| 567 | * may not make a huge amount of sense (Why not just merge the Buffer transaction with the |
| 568 | * deferred transaction?) but this is an important legacy use case, for example moving |
| 569 | * a window at the same time it draws makes use of this kind of technique. So anyway |
| 570 | * imagine we have something like this: |
| 571 | * |
| 572 | * Transaction { // containing |
| 573 | * Buffer -> frameNumber = 2 |
| 574 | * DeferTransactionUntil -> frameNumber = 2 |
| 575 | * Random other stuff |
| 576 | * } |
| 577 | * Now imagine getHeadFrameNumber returned mDrawingState.mFrameNumber (or mCurrentFrameNumber). |
| 578 | * Prior to doTransaction SurfaceFlinger will call notifyAvailableFrames, but because we |
| 579 | * haven't swapped mCurrentState to mDrawingState yet we will think the sync point |
| 580 | * is not ready. So we will return false from applyPendingState and not swap |
| 581 | * current state to drawing state. But because we don't swap current state |
| 582 | * to drawing state the number will never update and we will be stuck. This way |
| 583 | * we can see we need to return the frame number for the buffer we are about |
| 584 | * to apply. |
| 585 | */ |
| 586 | uint64_t BufferStateLayer::getHeadFrameNumber(nsecs_t /* expectedPresentTime */) const { |
| 587 | return mCurrentState.frameNumber; |
| 588 | } |
| 589 | |
Vishnu Nair | cf26a0a | 2020-11-13 12:56:20 -0800 | [diff] [blame] | 590 | void BufferStateLayer::setAutoRefresh(bool autoRefresh) { |
| 591 | if (!mAutoRefresh.exchange(autoRefresh)) { |
| 592 | mFlinger->signalLayerUpdate(); |
| 593 | } |
Marissa Wall | 61c5862 | 2018-07-18 10:12:20 -0700 | [diff] [blame] | 594 | } |
| 595 | |
Vishnu Nair | 6194e2e | 2019-02-06 12:58:39 -0800 | [diff] [blame] | 596 | bool BufferStateLayer::latchSidebandStream(bool& recomputeVisibleRegions) { |
Marissa Wall | 61c5862 | 2018-07-18 10:12:20 -0700 | [diff] [blame] | 597 | if (mSidebandStreamChanged.exchange(false)) { |
| 598 | const State& s(getDrawingState()); |
| 599 | // mSidebandStreamChanged was true |
Lloyd Pique | 0b785d8 | 2018-12-04 17:25:27 -0800 | [diff] [blame] | 600 | mSidebandStream = s.sidebandStream; |
Lloyd Pique | de19665 | 2020-01-22 17:29:58 -0800 | [diff] [blame] | 601 | editCompositionState()->sidebandStream = mSidebandStream; |
Lloyd Pique | 0b785d8 | 2018-12-04 17:25:27 -0800 | [diff] [blame] | 602 | if (mSidebandStream != nullptr) { |
Marissa Wall | 61c5862 | 2018-07-18 10:12:20 -0700 | [diff] [blame] | 603 | setTransactionFlags(eTransactionNeeded); |
| 604 | mFlinger->setTransactionFlags(eTraversalNeeded); |
| 605 | } |
| 606 | recomputeVisibleRegions = true; |
| 607 | |
Vishnu Nair | 6194e2e | 2019-02-06 12:58:39 -0800 | [diff] [blame] | 608 | return true; |
Marissa Wall | 61c5862 | 2018-07-18 10:12:20 -0700 | [diff] [blame] | 609 | } |
Vishnu Nair | 6194e2e | 2019-02-06 12:58:39 -0800 | [diff] [blame] | 610 | return false; |
Marissa Wall | 61c5862 | 2018-07-18 10:12:20 -0700 | [diff] [blame] | 611 | } |
| 612 | |
Lloyd Pique | 0449b0f | 2018-12-20 16:23:45 -0800 | [diff] [blame] | 613 | bool BufferStateLayer::hasFrameUpdate() const { |
Valerie Hau | aa19456 | 2019-02-05 16:21:38 -0800 | [diff] [blame] | 614 | const State& c(getCurrentState()); |
| 615 | return mCurrentStateModified && (c.buffer != nullptr || c.bgColorLayer != nullptr); |
Marissa Wall | 61c5862 | 2018-07-18 10:12:20 -0700 | [diff] [blame] | 616 | } |
| 617 | |
Ady Abraham | 43752eb | 2021-03-04 16:24:25 -0800 | [diff] [blame] | 618 | std::optional<nsecs_t> BufferStateLayer::nextPredictedPresentTime(int64_t vsyncId) const { |
| 619 | const auto prediction = |
| 620 | mFlinger->mFrameTimeline->getTokenManager()->getPredictionsForToken(vsyncId); |
| 621 | if (!prediction.has_value()) { |
Ady Abraham | 63a3e59 | 2021-01-06 10:47:15 -0800 | [diff] [blame] | 622 | return std::nullopt; |
Ady Abraham | ce4adf1 | 2020-12-15 18:45:12 -0800 | [diff] [blame] | 623 | } |
| 624 | |
Ady Abraham | 43752eb | 2021-03-04 16:24:25 -0800 | [diff] [blame] | 625 | return prediction->presentTime; |
Ady Abraham | ce4adf1 | 2020-12-15 18:45:12 -0800 | [diff] [blame] | 626 | } |
| 627 | |
Dominik Laskowski | a8955dd | 2019-07-10 10:19:09 -0700 | [diff] [blame] | 628 | status_t BufferStateLayer::updateTexImage(bool& /*recomputeVisibleRegions*/, nsecs_t latchTime, |
| 629 | nsecs_t /*expectedPresentTime*/) { |
Marissa Wall | 61c5862 | 2018-07-18 10:12:20 -0700 | [diff] [blame] | 630 | const State& s(getDrawingState()); |
| 631 | |
| 632 | if (!s.buffer) { |
Valerie Hau | aa19456 | 2019-02-05 16:21:38 -0800 | [diff] [blame] | 633 | if (s.bgColorLayer) { |
| 634 | for (auto& handle : mDrawingState.callbackHandles) { |
| 635 | handle->latchTime = latchTime; |
| 636 | } |
| 637 | } |
Marissa Wall | 61c5862 | 2018-07-18 10:12:20 -0700 | [diff] [blame] | 638 | return NO_ERROR; |
| 639 | } |
| 640 | |
Marissa Wall | 5a68a77 | 2018-12-22 17:43:42 -0800 | [diff] [blame] | 641 | for (auto& handle : mDrawingState.callbackHandles) { |
Vishnu Nair | 935590e | 2021-02-10 13:05:52 -0800 | [diff] [blame] | 642 | if (handle->frameNumber == mDrawingState.frameNumber) { |
| 643 | handle->latchTime = latchTime; |
| 644 | } |
Marissa Wall | 5a68a77 | 2018-12-22 17:43:42 -0800 | [diff] [blame] | 645 | } |
Marissa Wall | e2ffb42 | 2018-10-12 11:33:52 -0700 | [diff] [blame] | 646 | |
Vishnu Nair | ea0de00 | 2020-11-17 17:42:37 -0800 | [diff] [blame] | 647 | const int32_t layerId = getSequence(); |
Adithya Srinivasan | b238cd5 | 2021-02-04 17:54:05 +0000 | [diff] [blame] | 648 | const uint64_t bufferId = mDrawingState.buffer->getId(); |
| 649 | const uint64_t frameNumber = mDrawingState.frameNumber; |
| 650 | const auto acquireFence = std::make_shared<FenceTime>(mDrawingState.acquireFence); |
| 651 | mFlinger->mTimeStats->setAcquireFence(layerId, frameNumber, acquireFence); |
| 652 | mFlinger->mTimeStats->setLatchTime(layerId, frameNumber, latchTime); |
| 653 | |
| 654 | mFlinger->mFrameTracer->traceFence(layerId, bufferId, frameNumber, acquireFence, |
| 655 | FrameTracer::FrameEvent::ACQUIRE_FENCE); |
| 656 | mFlinger->mFrameTracer->traceTimestamp(layerId, bufferId, frameNumber, latchTime, |
| 657 | FrameTracer::FrameEvent::LATCH); |
Marissa Wall | 61c5862 | 2018-07-18 10:12:20 -0700 | [diff] [blame] | 658 | |
Adithya Srinivasan | b9a7dab | 2021-01-14 23:49:46 +0000 | [diff] [blame] | 659 | auto& bufferSurfaceFrame = mDrawingState.bufferSurfaceFrameTX; |
| 660 | if (bufferSurfaceFrame != nullptr && |
| 661 | bufferSurfaceFrame->getPresentState() != PresentState::Presented) { |
| 662 | // Update only if the bufferSurfaceFrame wasn't already presented. A Presented |
| 663 | // bufferSurfaceFrame could be seen here if a pending state was applied successfully and we |
| 664 | // are processing the next state. |
| 665 | addSurfaceFramePresentedForBuffer(bufferSurfaceFrame, |
| 666 | mDrawingState.acquireFence->getSignalTime(), latchTime); |
| 667 | bufferSurfaceFrame.reset(); |
| 668 | } |
| 669 | |
Marissa Wall | 16c112d | 2019-03-20 13:21:13 -0700 | [diff] [blame] | 670 | mCurrentStateModified = false; |
| 671 | |
Marissa Wall | 61c5862 | 2018-07-18 10:12:20 -0700 | [diff] [blame] | 672 | return NO_ERROR; |
| 673 | } |
| 674 | |
| 675 | status_t BufferStateLayer::updateActiveBuffer() { |
| 676 | const State& s(getDrawingState()); |
| 677 | |
| 678 | if (s.buffer == nullptr) { |
| 679 | return BAD_VALUE; |
| 680 | } |
chaviw | df3c5e8 | 2021-01-07 13:00:37 -0800 | [diff] [blame] | 681 | |
| 682 | if (s.buffer != mBufferInfo.mBuffer) { |
| 683 | decrementPendingBufferCount(); |
| 684 | } |
Marissa Wall | 61c5862 | 2018-07-18 10:12:20 -0700 | [diff] [blame] | 685 | |
Mikael Pessa | 2e1608f | 2019-07-19 11:25:35 -0700 | [diff] [blame] | 686 | mPreviousBufferId = getCurrentBufferId(); |
chaviw | d62d306 | 2019-09-04 14:48:02 -0700 | [diff] [blame] | 687 | mBufferInfo.mBuffer = s.buffer; |
| 688 | mBufferInfo.mFence = s.acquireFence; |
Marissa Wall | 61c5862 | 2018-07-18 10:12:20 -0700 | [diff] [blame] | 689 | |
| 690 | return NO_ERROR; |
| 691 | } |
| 692 | |
Valerie Hau | bf78464 | 2020-01-29 07:25:23 -0800 | [diff] [blame] | 693 | status_t BufferStateLayer::updateFrameNumber(nsecs_t latchTime) { |
Marissa Wall | 61c5862 | 2018-07-18 10:12:20 -0700 | [diff] [blame] | 694 | // TODO(marissaw): support frame history events |
Mikael Pessa | 2e1608f | 2019-07-19 11:25:35 -0700 | [diff] [blame] | 695 | mPreviousFrameNumber = mCurrentFrameNumber; |
Valerie Hau | 134651a | 2020-01-28 16:21:22 -0800 | [diff] [blame] | 696 | mCurrentFrameNumber = mDrawingState.frameNumber; |
Valerie Hau | bf78464 | 2020-01-29 07:25:23 -0800 | [diff] [blame] | 697 | { |
| 698 | Mutex::Autolock lock(mFrameEventHistoryMutex); |
| 699 | mFrameEventHistory.addLatch(mCurrentFrameNumber, latchTime); |
| 700 | } |
Marissa Wall | 61c5862 | 2018-07-18 10:12:20 -0700 | [diff] [blame] | 701 | return NO_ERROR; |
| 702 | } |
| 703 | |
Marissa Wall | 947d34e | 2019-03-29 14:03:53 -0700 | [diff] [blame] | 704 | void BufferStateLayer::HwcSlotGenerator::bufferErased(const client_cache_t& clientCacheId) { |
| 705 | std::lock_guard lock(mMutex); |
| 706 | if (!clientCacheId.isValid()) { |
| 707 | ALOGE("invalid process, failed to erase buffer"); |
| 708 | return; |
| 709 | } |
| 710 | eraseBufferLocked(clientCacheId); |
| 711 | } |
| 712 | |
| 713 | uint32_t BufferStateLayer::HwcSlotGenerator::getHwcCacheSlot(const client_cache_t& clientCacheId) { |
| 714 | std::lock_guard<std::mutex> lock(mMutex); |
| 715 | auto itr = mCachedBuffers.find(clientCacheId); |
| 716 | if (itr == mCachedBuffers.end()) { |
| 717 | return addCachedBuffer(clientCacheId); |
| 718 | } |
| 719 | auto& [hwcCacheSlot, counter] = itr->second; |
| 720 | counter = mCounter++; |
| 721 | return hwcCacheSlot; |
| 722 | } |
| 723 | |
| 724 | uint32_t BufferStateLayer::HwcSlotGenerator::addCachedBuffer(const client_cache_t& clientCacheId) |
| 725 | REQUIRES(mMutex) { |
| 726 | if (!clientCacheId.isValid()) { |
| 727 | ALOGE("invalid process, returning invalid slot"); |
| 728 | return BufferQueue::INVALID_BUFFER_SLOT; |
| 729 | } |
| 730 | |
| 731 | ClientCache::getInstance().registerErasedRecipient(clientCacheId, wp<ErasedRecipient>(this)); |
| 732 | |
| 733 | uint32_t hwcCacheSlot = getFreeHwcCacheSlot(); |
| 734 | mCachedBuffers[clientCacheId] = {hwcCacheSlot, mCounter++}; |
| 735 | return hwcCacheSlot; |
| 736 | } |
| 737 | |
| 738 | uint32_t BufferStateLayer::HwcSlotGenerator::getFreeHwcCacheSlot() REQUIRES(mMutex) { |
| 739 | if (mFreeHwcCacheSlots.empty()) { |
| 740 | evictLeastRecentlyUsed(); |
| 741 | } |
| 742 | |
| 743 | uint32_t hwcCacheSlot = mFreeHwcCacheSlots.top(); |
| 744 | mFreeHwcCacheSlots.pop(); |
| 745 | return hwcCacheSlot; |
| 746 | } |
| 747 | |
| 748 | void BufferStateLayer::HwcSlotGenerator::evictLeastRecentlyUsed() REQUIRES(mMutex) { |
| 749 | uint64_t minCounter = UINT_MAX; |
| 750 | client_cache_t minClientCacheId = {}; |
| 751 | for (const auto& [clientCacheId, slotCounter] : mCachedBuffers) { |
| 752 | const auto& [hwcCacheSlot, counter] = slotCounter; |
| 753 | if (counter < minCounter) { |
| 754 | minCounter = counter; |
| 755 | minClientCacheId = clientCacheId; |
| 756 | } |
| 757 | } |
| 758 | eraseBufferLocked(minClientCacheId); |
| 759 | |
| 760 | ClientCache::getInstance().unregisterErasedRecipient(minClientCacheId, this); |
| 761 | } |
| 762 | |
| 763 | void BufferStateLayer::HwcSlotGenerator::eraseBufferLocked(const client_cache_t& clientCacheId) |
| 764 | REQUIRES(mMutex) { |
| 765 | auto itr = mCachedBuffers.find(clientCacheId); |
| 766 | if (itr == mCachedBuffers.end()) { |
| 767 | return; |
| 768 | } |
| 769 | auto& [hwcCacheSlot, counter] = itr->second; |
| 770 | |
| 771 | // TODO send to hwc cache and resources |
| 772 | |
| 773 | mFreeHwcCacheSlots.push(hwcCacheSlot); |
| 774 | mCachedBuffers.erase(clientCacheId); |
| 775 | } |
chaviw | 4244e03 | 2019-09-04 11:27:49 -0700 | [diff] [blame] | 776 | |
| 777 | void BufferStateLayer::gatherBufferInfo() { |
chaviw | debadb8 | 2020-03-26 14:57:24 -0700 | [diff] [blame] | 778 | BufferLayer::gatherBufferInfo(); |
chaviw | 4244e03 | 2019-09-04 11:27:49 -0700 | [diff] [blame] | 779 | |
chaviw | debadb8 | 2020-03-26 14:57:24 -0700 | [diff] [blame] | 780 | const State& s(getDrawingState()); |
chaviw | 4244e03 | 2019-09-04 11:27:49 -0700 | [diff] [blame] | 781 | mBufferInfo.mDesiredPresentTime = s.desiredPresentTime; |
| 782 | mBufferInfo.mFenceTime = std::make_shared<FenceTime>(s.acquireFence); |
| 783 | mBufferInfo.mFence = s.acquireFence; |
chaviw | 4244e03 | 2019-09-04 11:27:49 -0700 | [diff] [blame] | 784 | mBufferInfo.mTransform = s.transform; |
| 785 | mBufferInfo.mDataspace = translateDataspace(s.dataspace); |
| 786 | mBufferInfo.mCrop = computeCrop(s); |
| 787 | mBufferInfo.mScaleMode = NATIVE_WINDOW_SCALING_MODE_SCALE_TO_WINDOW; |
| 788 | mBufferInfo.mSurfaceDamage = s.surfaceDamageRegion; |
| 789 | mBufferInfo.mHdrMetadata = s.hdrMetadata; |
| 790 | mBufferInfo.mApi = s.api; |
chaviw | 4244e03 | 2019-09-04 11:27:49 -0700 | [diff] [blame] | 791 | mBufferInfo.mTransformToDisplayInverse = s.transformToDisplayInverse; |
chaviw | f83ce18 | 2019-09-12 14:43:08 -0700 | [diff] [blame] | 792 | mBufferInfo.mBufferSlot = mHwcSlotGenerator->getHwcCacheSlot(s.clientCacheId); |
chaviw | 4244e03 | 2019-09-04 11:27:49 -0700 | [diff] [blame] | 793 | } |
| 794 | |
Robert Carr | 916b036 | 2020-10-06 13:53:03 -0700 | [diff] [blame] | 795 | uint32_t BufferStateLayer::getEffectiveScalingMode() const { |
| 796 | return NATIVE_WINDOW_SCALING_MODE_SCALE_TO_WINDOW; |
| 797 | } |
| 798 | |
chaviw | 4244e03 | 2019-09-04 11:27:49 -0700 | [diff] [blame] | 799 | Rect BufferStateLayer::computeCrop(const State& s) { |
| 800 | if (s.crop.isEmpty() && s.buffer) { |
| 801 | return s.buffer->getBounds(); |
| 802 | } else if (s.buffer) { |
| 803 | Rect crop = s.crop; |
| 804 | crop.left = std::max(crop.left, 0); |
| 805 | crop.top = std::max(crop.top, 0); |
| 806 | uint32_t bufferWidth = s.buffer->getWidth(); |
| 807 | uint32_t bufferHeight = s.buffer->getHeight(); |
| 808 | if (bufferHeight <= std::numeric_limits<int32_t>::max() && |
| 809 | bufferWidth <= std::numeric_limits<int32_t>::max()) { |
| 810 | crop.right = std::min(crop.right, static_cast<int32_t>(bufferWidth)); |
| 811 | crop.bottom = std::min(crop.bottom, static_cast<int32_t>(bufferHeight)); |
| 812 | } |
| 813 | if (!crop.isValid()) { |
| 814 | // Crop rect is out of bounds, return whole buffer |
| 815 | return s.buffer->getBounds(); |
| 816 | } |
| 817 | return crop; |
| 818 | } |
| 819 | return s.crop; |
| 820 | } |
| 821 | |
chaviw | b4c6e58 | 2019-08-16 14:35:07 -0700 | [diff] [blame] | 822 | sp<Layer> BufferStateLayer::createClone() { |
Dominik Laskowski | 87a07e4 | 2019-10-10 20:38:02 -0700 | [diff] [blame] | 823 | LayerCreationArgs args(mFlinger.get(), nullptr, mName + " (Mirror)", 0, 0, 0, LayerMetadata()); |
chaviw | b4c6e58 | 2019-08-16 14:35:07 -0700 | [diff] [blame] | 824 | args.textureName = mTextureName; |
Lloyd Pique | 1c3a5eb | 2019-10-03 13:07:08 -0700 | [diff] [blame] | 825 | sp<BufferStateLayer> layer = mFlinger->getFactory().createBufferStateLayer(args); |
chaviw | b4c6e58 | 2019-08-16 14:35:07 -0700 | [diff] [blame] | 826 | layer->mHwcSlotGenerator = mHwcSlotGenerator; |
| 827 | layer->setInitialValuesForClone(this); |
| 828 | return layer; |
| 829 | } |
Valerie Hau | 92bf548 | 2020-02-10 09:49:08 -0800 | [diff] [blame] | 830 | |
| 831 | Layer::RoundedCornerState BufferStateLayer::getRoundedCornerState() const { |
| 832 | const auto& p = mDrawingParent.promote(); |
| 833 | if (p != nullptr) { |
| 834 | RoundedCornerState parentState = p->getRoundedCornerState(); |
| 835 | if (parentState.radius > 0) { |
| 836 | ui::Transform t = getActiveTransform(getDrawingState()); |
| 837 | t = t.inverse(); |
| 838 | parentState.cropRect = t.transform(parentState.cropRect); |
| 839 | // The rounded corners shader only accepts 1 corner radius for performance reasons, |
| 840 | // but a transform matrix can define horizontal and vertical scales. |
| 841 | // Let's take the average between both of them and pass into the shader, practically we |
| 842 | // never do this type of transformation on windows anyway. |
| 843 | parentState.radius *= (t[0][0] + t[1][1]) / 2.0f; |
| 844 | return parentState; |
| 845 | } |
| 846 | } |
| 847 | const float radius = getDrawingState().cornerRadius; |
| 848 | const State& s(getDrawingState()); |
| 849 | if (radius <= 0 || (getActiveWidth(s) == UINT32_MAX && getActiveHeight(s) == UINT32_MAX)) |
| 850 | return RoundedCornerState(); |
| 851 | return RoundedCornerState(FloatRect(static_cast<float>(s.active.transform.tx()), |
| 852 | static_cast<float>(s.active.transform.ty()), |
| 853 | static_cast<float>(s.active.transform.tx() + s.active.w), |
| 854 | static_cast<float>(s.active.transform.ty() + s.active.h)), |
| 855 | radius); |
| 856 | } |
Vishnu Nair | e7f79c5 | 2020-10-29 14:45:03 -0700 | [diff] [blame] | 857 | |
| 858 | bool BufferStateLayer::bufferNeedsFiltering() const { |
| 859 | const State& s(getDrawingState()); |
| 860 | if (!s.buffer) { |
| 861 | return false; |
| 862 | } |
| 863 | |
| 864 | uint32_t bufferWidth = s.buffer->width; |
| 865 | uint32_t bufferHeight = s.buffer->height; |
| 866 | |
| 867 | // Undo any transformations on the buffer and return the result. |
| 868 | if (s.transform & ui::Transform::ROT_90) { |
| 869 | std::swap(bufferWidth, bufferHeight); |
| 870 | } |
| 871 | |
| 872 | if (s.transformToDisplayInverse) { |
| 873 | uint32_t invTransform = DisplayDevice::getPrimaryDisplayRotationFlags(); |
| 874 | if (invTransform & ui::Transform::ROT_90) { |
| 875 | std::swap(bufferWidth, bufferHeight); |
| 876 | } |
| 877 | } |
| 878 | |
| 879 | const Rect layerSize{getBounds()}; |
| 880 | return layerSize.width() != bufferWidth || layerSize.height() != bufferHeight; |
| 881 | } |
Robert Carr | 7121caf | 2020-12-15 13:07:32 -0800 | [diff] [blame] | 882 | |
Robert Carr | 7121caf | 2020-12-15 13:07:32 -0800 | [diff] [blame] | 883 | void BufferStateLayer::decrementPendingBufferCount() { |
Vishnu Nair | 8eda69e | 2021-02-26 10:42:10 -0800 | [diff] [blame] | 884 | int32_t pendingBuffers = --mPendingBufferTransactions; |
| 885 | tracePendingBufferCount(pendingBuffers); |
Robert Carr | 7121caf | 2020-12-15 13:07:32 -0800 | [diff] [blame] | 886 | } |
| 887 | |
Vishnu Nair | 8eda69e | 2021-02-26 10:42:10 -0800 | [diff] [blame] | 888 | void BufferStateLayer::tracePendingBufferCount(int32_t pendingBuffers) { |
| 889 | ATRACE_INT(mBlastTransactionName.c_str(), pendingBuffers); |
Robert Carr | 7121caf | 2020-12-15 13:07:32 -0800 | [diff] [blame] | 890 | } |
| 891 | |
| 892 | uint32_t BufferStateLayer::doTransaction(uint32_t flags) { |
| 893 | if (mDrawingState.buffer != nullptr && mDrawingState.buffer != mBufferInfo.mBuffer) { |
| 894 | // If we are about to update mDrawingState.buffer but it has not yet latched |
| 895 | // then we will drop a buffer and should decrement the pending buffer count. |
| 896 | // This logic may not work perfectly in the face of a BufferStateLayer being the |
| 897 | // deferred side of a deferred transaction, but we don't expect this use case. |
| 898 | decrementPendingBufferCount(); |
| 899 | } |
| 900 | return Layer::doTransaction(flags); |
| 901 | } |
| 902 | |
Marissa Wall | 61c5862 | 2018-07-18 10:12:20 -0700 | [diff] [blame] | 903 | } // namespace android |
Ady Abraham | b0dbdaa | 2020-01-06 16:19:42 -0800 | [diff] [blame] | 904 | |
| 905 | // TODO(b/129481165): remove the #pragma below and fix conversion issues |
Marin Shalamanov | bed7fd3 | 2020-12-21 20:02:20 +0100 | [diff] [blame] | 906 | #pragma clang diagnostic pop // ignored "-Wconversion -Wextra" |