commit | 0627cbec1cc5fefee437346fca467f57eefdeb21 | [log] [tgz] |
---|---|---|
author | Conrad Chen <conradchen@google.com> | Mon Jun 26 14:09:12 2017 -0700 |
committer | Conrad Chen <conradchen@google.com> | Mon Jul 10 14:39:50 2017 -0700 |
tree | e1d92fbb642b49a10136668cdea6be0330a580f7 | |
parent | f495192f570a0cfcc5e7d399846a2da818f44e5f [diff] |
MediaSession: Fix possible memory leak in MediaController.Callback MediaControllerCompat.Callback might be implemented by developers as an anonymous class or a inner class of the activity class, and thus holds a reference to the activity, which may causes activty leaks under the following two situations: 1. The Stub classes will be parcelled as a Binder, which may sustain after the activity creating it is destroyed. Makes Stub classes static to prevent activity leaks via Stub classes. 2. Messages sent to a handler would hold a reference to the handler. In MediaControllerCompat.Callback, the non-static inner class MessageHandler will hold a reference to the outer Callback class object. If some messages are not processed yet when the activity is destroyed, the activity may leak. Removes all messages in the handler when the callback is unregistered to solve this issue. Test: ./gradlew support-media-compat:connectedCheck Bug: 37141048 Change-Id: I6d4ed767a0eb067578777585ce06508a5b9727e6
We are not currently accepting new modules, features, or behavior changes.
NOTE: You will need to use Linux or Mac OS. Building under Windows is not currently supported.
Follow the “Downloading the Source” guide to install and set up repo
tool, but instead of running the listed repo
commands to initialize the repository, run the folowing:
repo init -u https://android.googlesource.com/platform/manifest -b ub-supportlib-master
Now your repository is set to pull only what you need for building and running support library. Download the code (and grab a coffee while we pull down 7GB):
repo sync -j8 -c
You will use this command to sync your checkout in the future - it’s similar to git fetch
Open path/to/checkout/frameworks/support/
in Android Studio. Now you're ready edit, run, and test!
If you get “Unregistered VCS root detected” click “Add root” to enable git integration for Android Studio.
If you see any warnings (red underlines) run Build > Clean Project
.
You can do most of your work from Android Studio, however you can also build the full support library from command line:
cd path/to/checkout/frameworks/support/ ./gradlew createArchive
Run FooBarTest
Run android.support.foobar
Support library has a set of Android applications that exercise support library code. These applications can be useful when you want to debug a real running application, or reproduce a problem interactively, before writing test code.
These applications are named support-*-demos (e.g. support-4v-demos or support-leanback-demos. You can run them by clicking Run > Run ...
and choosing the desired application.
cd path/to/checkout/frameworks/support/ repo start my_branch_name . (make needed modifications) git commit -a repo upload --current-branch .
If you see the following prompt, choose always
:
Run hook scripts from https://android.googlesource.com/platform/manifest (yes/always/NO)?