Gitiles
Code Review Sign In
gerrit-public.fairphone.software / platform / frameworks / support / 0730cdb7a158e81e3ff5212bbcf964f4b8e7b03b
commit0730cdb7a158e81e3ff5212bbcf964f4b8e7b03b[log] [tgz]
authorIan Lake <ilake@google.com>Fri Apr 21 13:15:01 2017 -0700
committerYigit Boyar <yboyar@google.com>Fri Jul 07 17:24:00 2017 -0700
tree1cf49c851849e4e8f36b78f1c2625ec24f76cc2b
parent0584aa1690129f0c41e42306a3e0bc7fc59c205c [diff]
Change Nav testapp's top level based on screen size

Update the Navigation testapp to adapt the top level
navigation pattern based on the available screen size:
- On very small screens (such as is common on phones
with multi-window or phones in landscape), use a
navigation drawer to keep navigation out of the way
but accessible
- When there is enough height (such as normal devices in
portrait), use bottom navigation
- On larger tablets in landscape and Chromebooks, use a
persistent navigation drawer that is always visible to
better use the available space

Test: testapp runs, works on multi-window on phones through Pixel C

BUG: 37573313
Change-Id: Ib78090be4ecc0cd7c7c9eb5010f098b51a8d6c57
10 files changed
tree: 1cf49c851849e4e8f36b78f1c2625ec24f76cc2b
  1. .idea/
  2. annotations/
  3. api/
  4. app-toolkit/
  5. buildSrc/
  6. compat/
  7. core-ui/
  8. core-utils/
  9. customtabs/
  10. design/
  11. development/
  12. dynamic-animation/
  13. emoji/
  14. exifinterface/
  15. fragment/
  16. frameworks/
  17. gradle/
  18. graphics/
  19. lifecycle/
  20. media-compat/
  21. navigation/
  22. percent/
  23. recommendation/
  24. room/
  25. samples/
  26. samples-flatfoot/
  27. scripts/
  28. testutils/
  29. transition/
  30. tv-provider/
  31. v13/
  32. v14/
  33. v17/
  34. v4/
  35. v7/
  36. wear/
  37. .gitignore
  38. Android.mk
  39. build.gradle
  40. CleanSpec.mk
  41. droiddoc.mk
  42. gradle.properties
  43. gradlew
  44. LICENSE.txt
  45. makeFlatfootRepo.sh
  46. pathmap.mk
  47. PREUPLOAD.cfg
  48. README.md
  49. settings.gradle
README.md

AOSP Support Library Contribution Guide

Accepted Types of Contributions

  • Bug fixes (needs a corresponding bug report in b.android.com)
  • Each bug fix is expected to come with tests
  • Fixing spelling errors
  • Updating documentation
  • Adding new tests to the area that is not currently covered by tests

We are not currently accepting new modules, features, or behavior changes.

Checking Out the Code

NOTE: You will need to use Linux or Mac OS. Building under Windows is not currently supported.

Follow the “Downloading the Source” guide to install and set up repo tool, but instead of running the listed repo commands to initialize the repository, run the folowing:

repo init -u https://android.googlesource.com/platform/manifest -b ub-supportlib-master

Now your repository is set to pull only what you need for building and running support library. Download the code (and grab a coffee while we pull down 7GB):

repo sync -j8 -c

You will use this command to sync your checkout in the future - it’s similar to git fetch

Using Android Studio

Open path/to/checkout/frameworks/support/ in Android Studio. Now you're ready edit, run, and test!

If you get “Unregistered VCS root detected” click “Add root” to enable git integration for Android Studio.

If you see any warnings (red underlines) run Build > Clean Project.

Optional - Full Build

You can do most of your work from Android Studio, however you can also build the full support library from command line:

cd path/to/checkout/frameworks/support/
./gradlew createArchive

Running Tests

Single Test Class or Method

  1. Open the desired test file in Android Studio.
  2. Right-click on a test class or @Test method name and select Run FooBarTest

Full Test Package

  1. In the project side panel open the desired module.
  2. Find the directory with the tests
  3. Right-click on the directory and select Run android.support.foobar

Running Sample Apps

Support library has a set of Android applications that exercise support library code. These applications can be useful when you want to debug a real running application, or reproduce a problem interactively, before writing test code.

These applications are named support-*-demos (e.g. support-4v-demos or support-leanback-demos. You can run them by clicking Run > Run ... and choosing the desired application.

Making a change

cd path/to/checkout/frameworks/support/
repo start my_branch_name .
(make needed modifications)
git commit -a
repo upload --current-branch .

If you see the following prompt, choose always:

Run hook scripts from https://android.googlesource.com/platform/manifest (yes/always/NO)?

Getting reviewed

  • After you run repo upload, open r.android.com
  • Sign in into your account (or create one if you do not have one yet)
  • Add an appropriate reviewer (use git log to find who did most modifications on the file you are fixing)