Gitiles
Code Review Sign In
gerrit-public.fairphone.software / platform / frameworks / support / 17347a161ae0b69ceef26992d5ec3d136d9ae47d
commit17347a161ae0b69ceef26992d5ec3d136d9ae47d[log] [tgz]
authorChris Craik <ccraik@google.com>Fri Feb 09 16:07:30 2018 -0800
committerChris Craik <ccraik@google.com>Tue Feb 20 09:44:39 2018 -0800
tree789c128d7538ffaede1f30d80efccef756539f89
parent815db23e554cd136ff992d1ae857024856af0b20 [diff]
Add initial support for 27.1 in app-toolkit, switch Paging to use it

Bug: 72443497
Test: tests in paging:runtime, paging:common, room:integration-tests:*
Test: ./gradlew createFlatfootDocsArchive -PofflineDocs=true --stacktrace --debug
Test: ./gradlew runBuildServerCompilationTasks

In supportlib 27.1.0:
    ListAdapter moved to v7-recyclerview
    ListAdapterHelper moved to v7-recyclerview as AsyncListDiffer
    ListAdapterConfig moved to v7-recyclerview as AsyncDifferConfig
    DiffCallback moved to v7-recyclerview as DiffUtil.ItemCallback

This CL updates paging to account for those moves. Because of this,
previous versions of paging cannot be used with 27.1, and future
versions cannot be used with v7-recyclerview < 27.1.

Switched setList->submitList throughout to match new naming.
AsyncPagedListDiffer can't easily implement a @NonNull
getCurrentList() like AsyncListDiffer does, so leaving the rest of
its API as is.

Only paging and tests that depend upon it use 27.1 for now, other
projects must opt in.

Preemptively sorted out kotlintestapp's dependencies to make it
compatible with 27.1, even though it doesn't use it yet.

Change-Id: Ia43203a51b82cdda68b4bf503a1166ab254a1aa3
20 files changed
tree: 789c128d7538ffaede1f30d80efccef756539f89
  1. .idea/
  2. annotations/
  3. api/
  4. app-toolkit/
  5. buildSrc/
  6. car/
  7. compat/
  8. content/
  9. core-ui/
  10. core-utils/
  11. customtabs/
  12. design/
  13. development/
  14. dynamic-animation/
  15. emoji/
  16. exifinterface/
  17. fragment/
  18. frameworks/
  19. gradle/
  20. graphics/
  21. jetifier/
  22. leanback/
  23. lifecycle/
  24. media-compat/
  25. paging/
  26. percent/
  27. persistence/
  28. preference-leanback/
  29. recommendation/
  30. recyclerview-selection/
  31. room/
  32. samples/
  33. scripts/
  34. testutils/
  35. transition/
  36. tv-provider/
  37. v13/
  38. v14/
  39. v4/
  40. v7/
  41. viewpager2/
  42. wear/
  43. webkit/
  44. webkit-codegen/
  45. .gitignore
  46. Android.mk
  47. build.gradle
  48. CleanSpec.mk
  49. gradle.properties
  50. gradlew
  51. LICENSE.txt
  52. makeFlatfootRepo.sh
  53. OWNERS
  54. pathmap.mk
  55. PREUPLOAD.cfg
  56. README.md
  57. settings.gradle
README.md

AOSP Support Library Contribution Guide

Accepted Types of Contributions

  • Bug fixes (needs a corresponding bug report in b.android.com)
  • Each bug fix is expected to come with tests
  • Fixing spelling errors
  • Updating documentation
  • Adding new tests to the area that is not currently covered by tests

We are not currently accepting new modules, features, or behavior changes.

Checking Out the Code

NOTE: You will need to use Linux or Mac OS. Building under Windows is not currently supported.

Follow the “Downloading the Source” guide to install and set up repo tool, but instead of running the listed repo commands to initialize the repository, run the folowing:

repo init -u https://android.googlesource.com/platform/manifest -b ub-supportlib-master

Now your repository is set to pull only what you need for building and running support library. Download the code (and grab a coffee while we pull down 7GB):

repo sync -j8 -c

You will use this command to sync your checkout in the future - it’s similar to git fetch

Using Android Studio

Open path/to/checkout/frameworks/support/ in Android Studio. Now you're ready edit, run, and test!

If you get “Unregistered VCS root detected” click “Add root” to enable git integration for Android Studio.

If you see any warnings (red underlines) run Build > Clean Project.

Optional - Full Build

You can do most of your work from Android Studio, however you can also build the full support library from command line:

cd path/to/checkout/frameworks/support/
./gradlew createArchive

Running Tests

Single Test Class or Method

  1. Open the desired test file in Android Studio.
  2. Right-click on a test class or @Test method name and select Run FooBarTest

Full Test Package

  1. In the project side panel open the desired module.
  2. Find the directory with the tests
  3. Right-click on the directory and select Run android.support.foobar

Running Sample Apps

Support library has a set of Android applications that exercise support library code. These applications can be useful when you want to debug a real running application, or reproduce a problem interactively, before writing test code.

These applications are named support-*-demos (e.g. support-4v-demos or support-leanback-demos. You can run them by clicking Run > Run ... and choosing the desired application.

Making a change

cd path/to/checkout/frameworks/support/
repo start my_branch_name .
(make needed modifications)
git commit -a
repo upload --current-branch .

If you see the following prompt, choose always:

Run hook scripts from https://android.googlesource.com/platform/manifest (yes/always/NO)?

Getting reviewed

  • After you run repo upload, open r.android.com
  • Sign in into your account (or create one if you do not have one yet)
  • Add an appropriate reviewer (use git log to find who did most modifications on the file you are fixing)