Paging refactor to unify list/data source types, and simplify mutability

Bug: 64809611
Test: new tests passing

- Unified list type for contiguous data sources - null padding is created at initialization, and
  consumed as items are loaded. Infinite unpadded, and counted padded lists use same list type
  entirely.

- New list and DataSource type for tiled data sources, which can access data at any location.

- Split data source based on keyed vs tiled  based implementations. This massively simplified the
  few existing data sources, and allowed us to specialize further, making the trivial test (and
  limit-offset) code much simpler (and avoiding code that was extremely prone to off by one errors)

- Added PagedListAdapter, which provides convenience wrapper for the AdapterHelper, saving users a
  few extra lines of code.

- Uncountable positioning - rework also has relative data source position stored at initialization
  so that countable items can use position, without being required to count their dataset. This
  supports cases with simple position IDs, but where you: 1) don't want nulls in the data, 2) don't
  care about count/scrollbars, 3) can't easily compute the total number.

- PagedList requires data to initialize - Removes need for weird warmup API, avoids showing a list
  of nulls to user in countable case, and unifies initialization codepaths.

- PagedList has a snapshot() method that enables DiffUtil to run safely on a background thread on
  immutable data, and snapshot-aware diffing that allows a new list to load content while it's being
  used in diffing on a background thread.

Not done:

- Parameterized initialization (both init from key, storing key, passing key when creating LiveData<PagedList>)

Change-Id: I7cb945afe37e68aad44cde45277afd7a27416e52
71 files changed
tree: b0a5d02bafe401f8f51633e9675b3f88442b51c1
  1. .idea/
  2. annotations/
  3. api/
  4. app-toolkit/
  5. buildSrc/
  6. compat/
  7. content/
  8. core-ui/
  9. core-utils/
  10. customtabs/
  11. design/
  12. development/
  13. dynamic-animation/
  14. emoji/
  15. exifinterface/
  16. fragment/
  17. frameworks/
  18. gradle/
  19. graphics/
  20. lifecycle/
  21. media-compat/
  22. media-compat-test-client/
  23. media-compat-test-lib/
  24. media-compat-test-service/
  25. paging/
  26. percent/
  27. recommendation/
  28. room/
  29. samples/
  30. scripts/
  31. testutils/
  32. transition/
  33. tv-provider/
  34. v13/
  35. v14/
  36. v17/
  37. v4/
  38. v7/
  39. wear/
  40. .gitignore
  41. Android.mk
  42. build.gradle
  43. CleanSpec.mk
  44. gradle.properties
  45. gradlew
  46. LICENSE.txt
  47. makeFlatfootRepo.sh
  48. pathmap.mk
  49. PREUPLOAD.cfg
  50. README.md
  51. settings.gradle
README.md

AOSP Support Library Contribution Guide

Accepted Types of Contributions

  • Bug fixes (needs a corresponding bug report in b.android.com)
  • Each bug fix is expected to come with tests
  • Fixing spelling errors
  • Updating documentation
  • Adding new tests to the area that is not currently covered by tests

We are not currently accepting new modules, features, or behavior changes.

Checking Out the Code

NOTE: You will need to use Linux or Mac OS. Building under Windows is not currently supported.

Follow the “Downloading the Source” guide to install and set up repo tool, but instead of running the listed repo commands to initialize the repository, run the folowing:

repo init -u https://android.googlesource.com/platform/manifest -b ub-supportlib-master

Now your repository is set to pull only what you need for building and running support library. Download the code (and grab a coffee while we pull down 7GB):

repo sync -j8 -c

You will use this command to sync your checkout in the future - it’s similar to git fetch

Using Android Studio

Open path/to/checkout/frameworks/support/ in Android Studio. Now you're ready edit, run, and test!

If you get “Unregistered VCS root detected” click “Add root” to enable git integration for Android Studio.

If you see any warnings (red underlines) run Build > Clean Project.

Optional - Full Build

You can do most of your work from Android Studio, however you can also build the full support library from command line:

cd path/to/checkout/frameworks/support/
./gradlew createArchive

Running Tests

Single Test Class or Method

  1. Open the desired test file in Android Studio.
  2. Right-click on a test class or @Test method name and select Run FooBarTest

Full Test Package

  1. In the project side panel open the desired module.
  2. Find the directory with the tests
  3. Right-click on the directory and select Run android.support.foobar

Running Sample Apps

Support library has a set of Android applications that exercise support library code. These applications can be useful when you want to debug a real running application, or reproduce a problem interactively, before writing test code.

These applications are named support-*-demos (e.g. support-4v-demos or support-leanback-demos. You can run them by clicking Run > Run ... and choosing the desired application.

Making a change

cd path/to/checkout/frameworks/support/
repo start my_branch_name .
(make needed modifications)
git commit -a
repo upload --current-branch .

If you see the following prompt, choose always:

Run hook scripts from https://android.googlesource.com/platform/manifest (yes/always/NO)?

Getting reviewed

  • After you run repo upload, open r.android.com
  • Sign in into your account (or create one if you do not have one yet)
  • Add an appropriate reviewer (use git log to find who did most modifications on the file you are fixing)