Gitiles
Code Review Sign In
gerrit-public.fairphone.software / platform / frameworks / support / 2259e4dc433701d006db35df4c5e9f8d51e7d29b
commit2259e4dc433701d006db35df4c5e9f8d51e7d29b[log] [tgz]
authorYigit Boyar <yboyar@google.com>Fri Nov 25 18:26:10 2016 -0800
committerYigit Boyar <yboyar@google.com>Thu Jul 06 16:20:09 2017 -0700
treecc5c9055a911d8225eea508a748cb3a2a45cd400
parent8bad027c789d3fb3da8e68fa0154f2a24ccc2865 [diff]
Type Adapters

This CL introduces type adapter logic that can convert a java
type into / from a database column (ColumnTypeAdapter).

There are also type adapters which can be used to create intermediate
representations if the type cannot directly be converted into a
database column (e.g. a Boolean is first converted into int then
into database).

So far we only have primitive types + string. More will be added later.

An additional type adapter to convert int list to string is also
provided to cover more cases (might be removed).

The code generation structure may change in the future as we write
real code that reads / writes an entitiy but based on the prototype,
this setup seems promising.

Also, there is no way to define custom adapters yet, it will also come
later.

TypeAdapterStore is not optimized at all since the structure is not
set and equals checks on TypeMirror objects does not seem to work.
Once we have the final structure, may optimize.

Bug: 32342709
Test: BasicColumnTypeAdaptersTest.kt, TypeAdapterStoreTest.kt

Change-Id: I52fde5a92dbe0ebe7290e001ba9e497c6d8e3981
25 files changed
tree: cc5c9055a911d8225eea508a748cb3a2a45cd400
  1. .idea/
  2. annotations/
  3. api/
  4. buildSrc/
  5. compat/
  6. core-ui/
  7. core-utils/
  8. customtabs/
  9. design/
  10. development/
  11. dynamic-animation/
  12. emoji/
  13. exifinterface/
  14. flatfoot-common/
  15. fragment/
  16. frameworks/
  17. gradle/
  18. graphics/
  19. lifecycle/
  20. media-compat/
  21. percent/
  22. recommendation/
  23. room/
  24. samples/
  25. scripts/
  26. testutils/
  27. transition/
  28. tv-provider/
  29. v13/
  30. v14/
  31. v17/
  32. v4/
  33. v7/
  34. wear/
  35. .gitignore
  36. Android.mk
  37. build.gradle
  38. CleanSpec.mk
  39. droiddoc.mk
  40. gradle.properties
  41. gradlew
  42. LICENSE.txt
  43. pathmap.mk
  44. PREUPLOAD.cfg
  45. README.md
  46. settings.gradle
README.md

AOSP Support Library Contribution Guide

Accepted Types of Contributions

  • Bug fixes (needs a corresponding bug report in b.android.com)
  • Each bug fix is expected to come with tests
  • Fixing spelling errors
  • Updating documentation
  • Adding new tests to the area that is not currently covered by tests

We are not currently accepting new modules, features, or behavior changes.

Checking Out the Code

NOTE: You will need to use Linux or Mac OS. Building under Windows is not currently supported.

Follow the “Downloading the Source” guide to install and set up repo tool, but instead of running the listed repo commands to initialize the repository, run the folowing:

repo init -u https://android.googlesource.com/platform/manifest -b ub-supportlib-master

Now your repository is set to pull only what you need for building and running support library. Download the code (and grab a coffee while we pull down 7GB):

repo sync -j8 -c

You will use this command to sync your checkout in the future - it’s similar to git fetch

Using Android Studio

Open path/to/checkout/frameworks/support/ in Android Studio. Now you're ready edit, run, and test!

If you get “Unregistered VCS root detected” click “Add root” to enable git integration for Android Studio.

If you see any warnings (red underlines) run Build > Clean Project.

Optional - Full Build

You can do most of your work from Android Studio, however you can also build the full support library from command line:

cd path/to/checkout/frameworks/support/
./gradlew createArchive

Running Tests

Single Test Class or Method

  1. Open the desired test file in Android Studio.
  2. Right-click on a test class or @Test method name and select Run FooBarTest

Full Test Package

  1. In the project side panel open the desired module.
  2. Find the directory with the tests
  3. Right-click on the directory and select Run android.support.foobar

Running Sample Apps

Support library has a set of Android applications that exercise support library code. These applications can be useful when you want to debug a real running application, or reproduce a problem interactively, before writing test code.

These applications are named support-*-demos (e.g. support-4v-demos or support-leanback-demos. You can run them by clicking Run > Run ... and choosing the desired application.

Making a change

cd path/to/checkout/frameworks/support/
repo start my_branch_name .
(make needed modifications)
git commit -a
repo upload --current-branch .

If you see the following prompt, choose always:

Run hook scripts from https://android.googlesource.com/platform/manifest (yes/always/NO)?

Getting reviewed

  • After you run repo upload, open r.android.com
  • Sign in into your account (or create one if you do not have one yet)
  • Add an appropriate reviewer (use git log to find who did most modifications on the file you are fixing)