Further browse spacing fixes to match redlines.
When not expanded, padding is greater for the selected row.
b/15328938
Change-Id: I97f2a40b542372a7f15ff6cfc30d7a23e74eb8a5
diff --git a/v17/leanback/res/values/dimens.xml b/v17/leanback/res/values/dimens.xml
index b3ec3ee..747aebb 100644
--- a/v17/leanback/res/values/dimens.xml
+++ b/v17/leanback/res/values/dimens.xml
@@ -52,7 +52,10 @@
<dimen name="lb_browse_row_hovercard_title_font_size">18sp</dimen>
<dimen name="lb_browse_row_hovercard_description_font_size">14sp</dimen>
<dimen name="lb_browse_item_horizontal_margin">8dp</dimen>
- <dimen name="lb_browse_item_vertical_margin">10dp</dimen>
+ <dimen name="lb_browse_item_vertical_margin">8dp</dimen>
+ <dimen name="lb_browse_selected_row_top_padding">20dp</dimen>
+ <dimen name="lb_browse_expanded_selected_row_top_padding">16dp</dimen>
+ <dimen name="lb_browse_expanded_row_no_hovercard_bottom_padding">28dp</dimen>
<item name="lb_focus_zoom_factor_small" type="fraction">106%</item>
<item name="lb_focus_zoom_factor_medium" type="fraction">110%</item>
diff --git a/v17/leanback/src/android/support/v17/leanback/widget/ListRowPresenter.java b/v17/leanback/src/android/support/v17/leanback/widget/ListRowPresenter.java
index 8546755..d200529 100644
--- a/v17/leanback/src/android/support/v17/leanback/widget/ListRowPresenter.java
+++ b/v17/leanback/src/android/support/v17/leanback/widget/ListRowPresenter.java
@@ -23,6 +23,7 @@
import android.support.v17.leanback.widget.Presenter.ViewHolder;
import android.support.v7.widget.RecyclerView;
import android.util.AttributeSet;
+import android.util.Log;
import android.view.View;
import android.view.ViewGroup;
import android.view.ViewGroup.LayoutParams;
@@ -95,6 +96,10 @@
private boolean mShadowEnabled = true;
private int mBrowseRowsFadingEdgeLength = -1;
+ private static int sSelectedRowTopPadding;
+ private static int sExpandedSelectedRowTopPadding;
+ private static int sExpandedRowNoHovercardBottomPadding;
+
/**
* Constructs a ListRowPresenter with defaults.
* Uses {@link FocusHighlight#ZOOM_FACTOR_MEDIUM} for focus zooming.
@@ -278,8 +283,51 @@
}
}
+ private static void initStatics(Context context) {
+ if (sSelectedRowTopPadding == 0) {
+ sSelectedRowTopPadding = context.getResources().getDimensionPixelSize(
+ R.dimen.lb_browse_selected_row_top_padding);
+ sExpandedSelectedRowTopPadding = context.getResources().getDimensionPixelSize(
+ R.dimen.lb_browse_expanded_selected_row_top_padding);
+ sExpandedRowNoHovercardBottomPadding = context.getResources().getDimensionPixelSize(
+ R.dimen.lb_browse_expanded_row_no_hovercard_bottom_padding);
+ }
+ }
+
+ private int getSpaceUnderBaseline(ListRowPresenter.ViewHolder vh) {
+ RowHeaderPresenter.ViewHolder headerViewHolder = vh.getHeaderViewHolder();
+ if (headerViewHolder != null) {
+ if (getHeaderPresenter() != null) {
+ return getHeaderPresenter().getSpaceUnderBaseline(headerViewHolder);
+ }
+ return headerViewHolder.view.getPaddingBottom();
+ }
+ return 0;
+ }
+
+ private void setVerticalPadding(ListRowPresenter.ViewHolder vh) {
+ int paddingTop, paddingBottom;
+ if (vh.isExpanded()) {
+ int headerSpaceUnderBaseline = getSpaceUnderBaseline(vh);
+ if (DEBUG) Log.v(TAG, "headerSpaceUnderBaseline " + headerSpaceUnderBaseline);
+ paddingTop = (vh.isSelected() ? sExpandedSelectedRowTopPadding : vh.mPaddingTop) -
+ headerSpaceUnderBaseline;
+ paddingBottom = mHoverCardPresenterSelector == null ?
+ sExpandedRowNoHovercardBottomPadding : vh.mPaddingBottom;
+ } else if (vh.isSelected()) {
+ paddingTop = sSelectedRowTopPadding;
+ paddingBottom = sSelectedRowTopPadding - vh.mPaddingTop;
+ } else {
+ paddingTop = vh.mPaddingTop;
+ paddingBottom = 0;
+ }
+ vh.getGridView().setPadding(vh.mPaddingLeft, paddingTop, vh.mPaddingRight,
+ paddingBottom);
+ }
+
@Override
protected RowPresenter.ViewHolder createRowViewHolder(ViewGroup parent) {
+ initStatics(parent.getContext());
ListRowView rowView = new ListRowView(parent.getContext());
setupFadingEffect(rowView);
if (mRowHeight != 0) {
@@ -291,7 +339,9 @@
@Override
protected void onRowViewSelected(RowPresenter.ViewHolder holder, boolean selected) {
super.onRowViewSelected(holder, selected);
- updateFooterViewSwitcher((ViewHolder) holder);
+ ViewHolder vh = (ViewHolder) holder;
+ setVerticalPadding(vh);
+ updateFooterViewSwitcher(vh);
}
/*
@@ -335,13 +385,7 @@
int newHeight = expanded ? getExpandedRowHeight() : getRowHeight();
vh.getGridView().setRowHeight(newHeight);
}
- if (expanded) {
- vh.getGridView().setPadding(vh.mPaddingLeft, vh.mPaddingTop,
- vh.mPaddingRight, vh.mPaddingBottom);
- } else {
- vh.getGridView().setPadding(vh.mPaddingLeft, vh.mPaddingTop,
- vh.mPaddingRight, 0);
- }
+ setVerticalPadding(vh);
vh.getGridView().setFadingLeftEdge(!expanded);
updateFooterViewSwitcher(vh);
}
diff --git a/v17/leanback/src/android/support/v17/leanback/widget/RowHeaderPresenter.java b/v17/leanback/src/android/support/v17/leanback/widget/RowHeaderPresenter.java
index 64f46ad..2479420 100644
--- a/v17/leanback/src/android/support/v17/leanback/widget/RowHeaderPresenter.java
+++ b/v17/leanback/src/android/support/v17/leanback/widget/RowHeaderPresenter.java
@@ -13,10 +13,12 @@
*/
package android.support.v17.leanback.widget;
+import android.graphics.Paint;
import android.support.v17.leanback.R;
import android.view.LayoutInflater;
import android.view.View;
import android.view.ViewGroup;
+import android.widget.TextView;
/**
* RowHeaderPresenter provides a default implementation for header using TextView.
@@ -26,6 +28,7 @@
public class RowHeaderPresenter extends Presenter {
private final int mLayoutResourceId;
+ private final Paint mFontMeasurePaint = new Paint(Paint.ANTI_ALIAS_FLAG);
public RowHeaderPresenter() {
this(R.layout.lb_row_header);
@@ -90,4 +93,26 @@
holder.view.setAlpha(holder.mUnselectAlpha + holder.mSelectLevel *
(1f - holder.mUnselectAlpha));
}
-}
\ No newline at end of file
+
+ /**
+ * Returns the space (distance in pixels) below the baseline of the
+ * text view, if one exists; otherwise, returns 0.
+ */
+ public int getSpaceUnderBaseline(ViewHolder holder) {
+ int space = holder.view.getPaddingBottom();
+ if (holder.view instanceof TextView) {
+ space += (int) getFontDescent((TextView) holder.view, mFontMeasurePaint);
+ }
+ return space;
+ }
+
+ protected static float getFontDescent(TextView textView, Paint fontMeasurePaint) {
+ if (fontMeasurePaint.getTextSize() != textView.getTextSize()) {
+ fontMeasurePaint.setTextSize(textView.getTextSize());
+ }
+ if (fontMeasurePaint.getTypeface() != textView.getTypeface()) {
+ fontMeasurePaint.setTypeface(textView.getTypeface());
+ }
+ return fontMeasurePaint.descent();
+ }
+}