Gitiles
Code Review Sign In
gerrit-public.fairphone.software / platform / frameworks / support / 9cf4f3d3aa83bc64db574955805c67ac9ea84008
commit9cf4f3d3aa83bc64db574955805c67ac9ea84008[log] [tgz]
authorSumir Kataria <sumir@google.com>Tue Feb 06 09:57:51 2018 -0800
committerSumir Kataria <sumir@google.com>Tue Feb 06 10:33:00 2018 -0800
tree2acebe0ebdb33f4f627fdcf1ae6693b75d33cb05
parentb6430f2f232996be5971e9a57819aa2377daf920 [diff]
Provide only one LiveData listener for work items.

There was a lot of confusion about the separate getStatus
and getOutput methods in WorkManager.  I've combined them
both into getStatus, which returns a new type, WorkStatus.
The old WorkStatus has been renamed to State (along with
all references to it, as well as the DB column name).  To
summarize the class changes:

- WorkStatus: new class, contains id, state, and output
- State: formerly known as WorkStatus (yes, I know, I'm
  sorry)
- WorkSpec.IdStateAndOutput: a POJO mapping to the DB
  columns; I'm not exposing this to the developers since
  it contains business logic they shouldn't be privy to

Because there is a DB schema change, you will have to
wipe out any existing DBs (clear data on the app); I
have not provided an upgrade step here.

Also updated WorkContinuation.getStatuses to return this
new data structure.

Test: Updated and ran tests.
Change-Id: If97110b0e946cb4a00f50a3b870951907add492e
26 files changed
tree: 2acebe0ebdb33f4f627fdcf1ae6693b75d33cb05
  1. .idea/
  2. annotations/
  3. api/
  4. app-toolkit/
  5. background/
  6. buildSrc/
  7. car/
  8. compat/
  9. content/
  10. core-ui/
  11. core-utils/
  12. customtabs/
  13. design/
  14. development/
  15. dynamic-animation/
  16. emoji/
  17. exifinterface/
  18. fragment/
  19. frameworks/
  20. gradle/
  21. graphics/
  22. jetifier/
  23. leanback/
  24. lifecycle/
  25. media-compat/
  26. paging/
  27. percent/
  28. persistence/
  29. preference-leanback/
  30. recommendation/
  31. recyclerview-selection/
  32. room/
  33. samples/
  34. scripts/
  35. testutils/
  36. transition/
  37. tv-provider/
  38. v13/
  39. v14/
  40. v4/
  41. v7/
  42. viewpager2/
  43. wear/
  44. webkit/
  45. webkit-codegen/
  46. .gitignore
  47. Android.mk
  48. build.gradle
  49. CleanSpec.mk
  50. gradle.properties
  51. gradlew
  52. LICENSE.txt
  53. makeFlatfootRepo.sh
  54. OWNERS
  55. pathmap.mk
  56. PREUPLOAD.cfg
  57. README.md
  58. settings.gradle
README.md

AOSP Support Library Contribution Guide

Accepted Types of Contributions

  • Bug fixes (needs a corresponding bug report in b.android.com)
  • Each bug fix is expected to come with tests
  • Fixing spelling errors
  • Updating documentation
  • Adding new tests to the area that is not currently covered by tests

We are not currently accepting new modules, features, or behavior changes.

Checking Out the Code

NOTE: You will need to use Linux or Mac OS. Building under Windows is not currently supported.

Follow the “Downloading the Source” guide to install and set up repo tool, but instead of running the listed repo commands to initialize the repository, run the folowing:

repo init -u https://android.googlesource.com/platform/manifest -b ub-supportlib-master

Now your repository is set to pull only what you need for building and running support library. Download the code (and grab a coffee while we pull down 7GB):

repo sync -j8 -c

You will use this command to sync your checkout in the future - it’s similar to git fetch

Using Android Studio

Open path/to/checkout/frameworks/support/ in Android Studio. Now you're ready edit, run, and test!

If you get “Unregistered VCS root detected” click “Add root” to enable git integration for Android Studio.

If you see any warnings (red underlines) run Build > Clean Project.

Optional - Full Build

You can do most of your work from Android Studio, however you can also build the full support library from command line:

cd path/to/checkout/frameworks/support/
./gradlew createArchive

Running Tests

Single Test Class or Method

  1. Open the desired test file in Android Studio.
  2. Right-click on a test class or @Test method name and select Run FooBarTest

Full Test Package

  1. In the project side panel open the desired module.
  2. Find the directory with the tests
  3. Right-click on the directory and select Run android.support.foobar

Running Sample Apps

Support library has a set of Android applications that exercise support library code. These applications can be useful when you want to debug a real running application, or reproduce a problem interactively, before writing test code.

These applications are named support-*-demos (e.g. support-4v-demos or support-leanback-demos. You can run them by clicking Run > Run ... and choosing the desired application.

Making a change

cd path/to/checkout/frameworks/support/
repo start my_branch_name .
(make needed modifications)
git commit -a
repo upload --current-branch .

If you see the following prompt, choose always:

Run hook scripts from https://android.googlesource.com/platform/manifest (yes/always/NO)?

Getting reviewed

  • After you run repo upload, open r.android.com
  • Sign in into your account (or create one if you do not have one yet)
  • Add an appropriate reviewer (use git log to find who did most modifications on the file you are fixing)