Gitiles
Code Review Sign In
gerrit-public.fairphone.software / platform / frameworks / support / 9f29f4a040c61cdbc2bbb5adb9c90fd5691cac57
commit9f29f4a040c61cdbc2bbb5adb9c90fd5691cac57[log] [tgz]
authorFilip Pavlis <pavlis@google.com>Mon Oct 02 19:43:43 2017 +0100
committerFilip Pavlis <pavlis@google.com>Tue Nov 21 18:22:23 2017 +0000
tree4ac03a0c02844d8b77478974044eb1e9d7e33e46
parent817db34fbff2871e9bef052f4cab460534a52352 [diff]
Adds POM rewriting capabilities.

Also changes the transformation to work over a set of files instead of a
single one.

Since we need to get all the POM files before we even start transforming
any libraries (to know that there is a library that is using older
version of support library that is not supported). The transformation
process firstly scans POM files and then does transformations on the
rest of the files. After that it finally also modifies the POM files.

I still have a few TODOs but didn't want to have the CL even bigger.
- Fix reference to any dependency we have rewritten in all the
discovered POM files
- Hook the gradle plugin to work over a set of libraries

UPDATE: Pom files can define values using properties. So I have extended
the tool to support that. I have also added better version checking
(support for intervals) and all PomRewriteRules versions are now validated
before the process is started

Bug: b/64833662
Test: Added in PomDocumentTest
Change-Id: I4e270de6c4590259300772102781b81c6d9237d4
22 files changed
tree: 4ac03a0c02844d8b77478974044eb1e9d7e33e46
  1. .idea/
  2. annotations/
  3. api/
  4. app-toolkit/
  5. buildSrc/
  6. car/
  7. compat/
  8. content/
  9. core-ui/
  10. core-utils/
  11. customtabs/
  12. design/
  13. development/
  14. dynamic-animation/
  15. emoji/
  16. exifinterface/
  17. fragment/
  18. frameworks/
  19. gradle/
  20. graphics/
  21. jetifier/
  22. leanback/
  23. lifecycle/
  24. media-compat/
  25. paging/
  26. percent/
  27. persistence/
  28. preference-leanback/
  29. recommendation/
  30. recyclerview-selection/
  31. room/
  32. samples/
  33. scripts/
  34. testutils/
  35. transition/
  36. tv-provider/
  37. v13/
  38. v14/
  39. v4/
  40. v7/
  41. wear/
  42. webkit/
  43. .gitignore
  44. Android.mk
  45. build.gradle
  46. CleanSpec.mk
  47. gradle.properties
  48. gradlew
  49. LICENSE.txt
  50. makeFlatfootRepo.sh
  51. OWNERS
  52. pathmap.mk
  53. PREUPLOAD.cfg
  54. README.md
  55. settings.gradle
README.md

AOSP Support Library Contribution Guide

Accepted Types of Contributions

  • Bug fixes (needs a corresponding bug report in b.android.com)
  • Each bug fix is expected to come with tests
  • Fixing spelling errors
  • Updating documentation
  • Adding new tests to the area that is not currently covered by tests

We are not currently accepting new modules, features, or behavior changes.

Checking Out the Code

NOTE: You will need to use Linux or Mac OS. Building under Windows is not currently supported.

Follow the “Downloading the Source” guide to install and set up repo tool, but instead of running the listed repo commands to initialize the repository, run the folowing:

repo init -u https://android.googlesource.com/platform/manifest -b ub-supportlib-master

Now your repository is set to pull only what you need for building and running support library. Download the code (and grab a coffee while we pull down 7GB):

repo sync -j8 -c

You will use this command to sync your checkout in the future - it’s similar to git fetch

Using Android Studio

Open path/to/checkout/frameworks/support/ in Android Studio. Now you're ready edit, run, and test!

If you get “Unregistered VCS root detected” click “Add root” to enable git integration for Android Studio.

If you see any warnings (red underlines) run Build > Clean Project.

Optional - Full Build

You can do most of your work from Android Studio, however you can also build the full support library from command line:

cd path/to/checkout/frameworks/support/
./gradlew createArchive

Running Tests

Single Test Class or Method

  1. Open the desired test file in Android Studio.
  2. Right-click on a test class or @Test method name and select Run FooBarTest

Full Test Package

  1. In the project side panel open the desired module.
  2. Find the directory with the tests
  3. Right-click on the directory and select Run android.support.foobar

Running Sample Apps

Support library has a set of Android applications that exercise support library code. These applications can be useful when you want to debug a real running application, or reproduce a problem interactively, before writing test code.

These applications are named support-*-demos (e.g. support-4v-demos or support-leanback-demos. You can run them by clicking Run > Run ... and choosing the desired application.

Making a change

cd path/to/checkout/frameworks/support/
repo start my_branch_name .
(make needed modifications)
git commit -a
repo upload --current-branch .

If you see the following prompt, choose always:

Run hook scripts from https://android.googlesource.com/platform/manifest (yes/always/NO)?

Getting reviewed

  • After you run repo upload, open r.android.com
  • Sign in into your account (or create one if you do not have one yet)
  • Add an appropriate reviewer (use git log to find who did most modifications on the file you are fixing)