Gitiles
Code Review Sign In
gerrit-public.fairphone.software / platform / frameworks / support / aa26b9a4657d36611a0d216df318e46b4f3e1e51
commitaa26b9a4657d36611a0d216df318e46b4f3e1e51[log] [tgz]
authorSean Kelley <smskelley@google.com>Mon May 08 14:18:12 2017 -0700
committerSean Kelley <smskelley@google.com>Mon May 08 14:48:47 2017 -0700
tree0cca6a9ef0f8a321ee0e1923244cc0d1e097da50
parent54a8a460d85d2d0709d9b8f62c31915e6f03adc5 [diff]
Adjust layout width to fix broken test

To ensure the espresso tests work on non-watch devices, the layout
height and width were constrained to 213dp. This works okay for e.g. a
phone in portrait mode, however it doesn't work for large devices in
landscape. This is because the action drawer has margins which are
specified as a percentage of the entire screen. As a result, the action
drawer list elements were off screen and thus "isCompletelyDisplayed"
was always false.

To resolve this, layout height remains constrained at 213dp, but layout
width is now match_parent even for large devices. While debugging, I
found it useful to make the drawers have distinct colors (red and blue)
so that it's easy to tell when the drawer is open. I have left these
changes since it should help with future debugging.

Test: Espresso tests on a Ryu, Angler, Swordfish, Tetra
Bug: 38041618
Change-Id: I910ec418949a91e37407917e0e3ee2e59eb4cf1e
4 files changed
tree: 0cca6a9ef0f8a321ee0e1923244cc0d1e097da50
  1. .idea/
  2. annotations/
  3. api/
  4. buildSrc/
  5. compat/
  6. core-ui/
  7. core-utils/
  8. customtabs/
  9. design/
  10. development/
  11. dynamic-animation/
  12. emoji/
  13. exifinterface/
  14. fragment/
  15. frameworks/
  16. gradle/
  17. graphics/
  18. media-compat/
  19. percent/
  20. recommendation/
  21. samples/
  22. scripts/
  23. testutils/
  24. transition/
  25. tv-provider/
  26. v13/
  27. v14/
  28. v17/
  29. v4/
  30. v7/
  31. wear/
  32. .gitignore
  33. Android.mk
  34. build.gradle
  35. CleanSpec.mk
  36. droiddoc.mk
  37. gradle.properties
  38. gradlew
  39. pathmap.mk
  40. PREUPLOAD.cfg
  41. README.md
  42. settings.gradle
README.md

AOSP Support Library Contribution Guide

Accepted Types of Contributions

  • Bug fixes (needs a corresponding bug report in b.android.com)
  • Each bug fix is expected to come with tests
  • Fixing spelling errors
  • Updating documentation
  • Adding new tests to the area that is not currently covered by tests

We are not currently accepting new modules, features, or behavior changes.

Checking Out the Code

NOTE: You will need to use Linux or Mac OS. Building under Windows is not currently supported.

Follow the “Downloading the Source” guide to install and set up repo tool, but instead of running the listed repo commands to initialize the repository, run the folowing:

repo init -u https://android.googlesource.com/platform/manifest -b ub-supportlib-master

Now your repository is set to pull only what you need for building and running support library. Download the code (and grab a coffee while we pull down 7GB):

repo sync -j8 -c

You will use this command to sync your checkout in the future - it’s similar to git fetch

Using Android Studio

Open path/to/checkout/frameworks/support/ in Android Studio. Now you're ready edit, run, and test!

If you get “Unregistered VCS root detected” click “Add root” to enable git integration for Android Studio.

If you see any warnings (red underlines) run Build > Clean Project.

Optional - Full Build

You can do most of your work from Android Studio, however you can also build the full support library from command line:

cd path/to/checkout/frameworks/support/
./gradlew createArchive

Running Tests

Single Test Class or Method

  1. Open the desired test file in Android Studio.
  2. Right-click on a test class or @Test method name and select Run FooBarTest

Full Test Package

  1. In the project side panel open the desired module.
  2. Find the directory with the tests
  3. Right-click on the directory and select Run android.support.foobar

Running Sample Apps

Support library has a set of Android applications that exercise support library code. These applications can be useful when you want to debug a real running application, or reproduce a problem interactively, before writing test code.

These applications are named support-*-demos (e.g. support-4v-demos or support-leanback-demos. You can run them by clicking Run > Run ... and choosing the desired application.

Making a change

cd path/to/checkout/frameworks/support/
repo start my_branch_name .
(make needed modifications)
git commit -a
repo upload --current-branch .

If you see the following prompt, choose always:

Run hook scripts from https://android.googlesource.com/platform/manifest (yes/always/NO)?

Getting reviewed

  • After you run repo upload, open r.android.com
  • Sign in into your account (or create one if you do not have one yet)
  • Add an appropriate reviewer (use git log to find who did most modifications on the file you are fixing)