commit 064de8b1ef8940b45135c567568a4c52b1f94d1f
author Apoorv Raghuvanshi <apoorvr@codeaurora.org> Mon Dec 15 23:06:53 2014 +0530
committer Gerrit - the friendly Code Review server <code-review@localhost> Mon Jan 05 08:55:44 2015 -0800
tree e9154c44b2218b2f0731e253889d9133a1115e39
parent e1785b18f5f13ea9a98e604dbb3f9f811a25c183

mm-audio: aenc-aac: fix integer overflow for encoded buffer timestamp calculation

Encoded buffer timestamp is 64 bit wide and is derived by multiplying
two 32 bit values, while calculating timestamp, these values are
multiplied with result stored in intermediate storage of 32 bit used
by compiler internally, this was associated with overflow if the result
is larger than max supported by 32 bit storage.
Changing m_frame_count to 64 bit will fix possible overflow for frame
count as well as force compiler to use intermediate variable of
required size.

Change-Id: I5ab709094d1c6b984d27f98327d3d8afa179fc92
CRs-Fixed: 767185

mm-audio/aenc-aac/qdsp6/inc/omx_aac_aenc.h

diff --git a/mm-audio/aenc-aac/qdsp6/inc/omx_aac_aenc.h b/mm-audio/aenc-aac/qdsp6/inc/omx_aac_aenc.h
index 2e2abbf..a87717b 100644
--- a/mm-audio/aenc-aac/qdsp6/inc/omx_aac_aenc.h
+++ b/mm-audio/aenc-aac/qdsp6/inc/omx_aac_aenc.h
@@ -457,7 +457,7 @@
     unsigned int                   m_flags;      //encapsulate the waiting states.
     OMX_U64                        nTimestamp;
     OMX_U64                        ts;
-    uint32_t                       m_frame_count;
+    OMX_U64                        m_frame_count;
     unsigned int                   frameduration;
     unsigned int                   pcm_input; //tunnel or non-tunnel
     unsigned int                   m_inp_act_buf_count;    // Num of Input Buffers