commit 1b793e288fc2d1df5321d00c7c002459700c45e6
author Padmanabhan Komanduru <pkomandu@codeaurora.org> Tue May 05 21:02:34 2020 +0530
committer Padmanabhan Komanduru <pkomandu@codeaurora.org> Thu May 14 01:58:48 2020 +0530
tree f23663e58800d3b70c4a5214ca1f78e2393ea055
parent 18db95d35cf9ff07c76b854f355adefee6683116

composer: fix the signature to getDebugProperty/getSupportedDsiBitClks

Change-Id: Ie3a2b5cc7bc06073681dbf7701caad09f2e9a522
CRs-Fixed: 2686393

composer/hwc_session.h

diff --git a/composer/hwc_session.h b/composer/hwc_session.h
index 680e54a..d9ca4ac 100644
--- a/composer/hwc_session.h
+++ b/composer/hwc_session.h
@@ -362,13 +362,16 @@
     virtual int IsHDRSupported(uint32_t disp_id, bool *supported);
     virtual int IsWCGSupported(uint32_t disp_id, bool *supported);
     virtual int SetLayerAsMask(uint32_t disp_id, uint64_t layer_id);
-    virtual int GetDebugProperty(const std::string prop_name, std::string value);
+    virtual int GetDebugProperty(const std::string prop_name, std::string value) {return -EINVAL;}
+    virtual int GetDebugProperty(const std::string prop_name, std::string *value);
     virtual int GetActiveBuiltinDisplayAttributes(DisplayConfig::Attributes *attr);
     virtual int SetPanelLuminanceAttributes(uint32_t disp_id, float min_lum, float max_lum);
     virtual int IsBuiltInDisplay(uint32_t disp_id, bool *is_builtin);
     virtual int IsAsyncVDSCreationSupported(bool *supported);
     virtual int CreateVirtualDisplay(uint32_t width, uint32_t height, int format);
-    virtual int GetSupportedDSIBitClks(uint32_t disp_id, std::vector<uint64_t> bit_clks);
+    virtual int GetSupportedDSIBitClks(uint32_t disp_id,
+                                       std::vector<uint64_t> bit_clks) {return -EINVAL;}
+    virtual int GetSupportedDSIBitClks(uint32_t disp_id, std::vector<uint64_t> *bit_clks);
     virtual int GetDSIClk(uint32_t disp_id, uint64_t *bit_clk);
     virtual int SetDSIClk(uint32_t disp_id, uint64_t bit_clk);
     virtual int SetCWBOutputBuffer(uint32_t disp_id, const DisplayConfig::Rect rect,

composer/hwc_session_services.cpp

diff --git a/composer/hwc_session_services.cpp b/composer/hwc_session_services.cpp
index af457eb..911b4b0 100644
--- a/composer/hwc_session_services.cpp
+++ b/composer/hwc_session_services.cpp
@@ -802,14 +802,14 @@
 }
 
 int HWCSession::DisplayConfigImpl::GetDebugProperty(const std::string prop_name,
-                                                    std::string value) {
+                                                    std::string *value) {
   std::string vendor_prop_name = DISP_PROP_PREFIX;
   int error = -EINVAL;
   char val[64] = {};
 
   vendor_prop_name += prop_name.c_str();
   if (HWCDebugHandler::Get()->GetProperty(vendor_prop_name.c_str(), val) == kErrorNone) {
-    value = val;
+    *value = val;
     error = 0;
   }
 
@@ -889,13 +889,13 @@
 }
 
 int HWCSession::DisplayConfigImpl::GetSupportedDSIBitClks(uint32_t disp_id,
-                                                           std::vector<uint64_t> bit_clks) {
+                                                          std::vector<uint64_t> *bit_clks) {
   SCOPE_LOCK(hwc_session_->locker_[disp_id]);
   if (!hwc_session_->hwc_display_[disp_id]) {
     return -EINVAL;
   }
 
-  hwc_session_->hwc_display_[disp_id]->GetSupportedDSIClock(&bit_clks);
+  hwc_session_->hwc_display_[disp_id]->GetSupportedDSIClock(bit_clks);
   return 0;
 }