commit ce3692bb487abdf23e99917d70f34c7d947b165c
author Pullakavi Srinivas <spullaka@codeaurora.org> Thu Feb 13 01:14:09 2020 +0530
committer Gerrit - the friendly Code Review server <code-review@localhost> Mon Apr 20 03:39:06 2020 -0700
tree 255a99904ff3a0a666cae431fa7d1dd3f945a0c1
parent 52f60f22bc6dbb8c7f37ef1ed79f6cccdb64ed50

sdm: Enable options for variable args.

CRs-Fixed: 2617483
Change-Id: I3f576c2f301d48a0d13a6e53efff1b823a648ffb

libdebug/debug_handler.h

diff --git a/libdebug/debug_handler.h b/libdebug/debug_handler.h
index 81795e4..6e6f7ee 100644
--- a/libdebug/debug_handler.h
+++ b/libdebug/debug_handler.h
@@ -1,5 +1,5 @@
 /*
-* Copyright (c) 2018, The Linux Foundation. All rights reserved.
+* Copyright (c) 2018, 2020 The Linux Foundation. All rights reserved.
 *
 * Redistribution and use in source and binary forms, with or without
 * modification, are permitted provided that the following conditions are
@@ -62,11 +62,12 @@
 
 class DebugHandler {
  public:
-  virtual void Error(const char *format, ...) = 0;
-  virtual void Warning(const char *format, ...) = 0;
-  virtual void Info(const char *format, ...) = 0;
-  virtual void Debug(const char *format, ...) = 0;
-  virtual void Verbose(const char *format, ...) = 0;
+  // __format__(printf hints the compiler to validate format specifiers vs arguments provided.
+  virtual void Error(const char *format, ...) __attribute__ ((__format__(printf, 2, 3))) = 0;
+  virtual void Warning(const char *format, ...) __attribute__ ((__format__(printf, 2, 3))) = 0;
+  virtual void Info(const char *format, ...) __attribute__ ((__format__(printf, 2, 3))) = 0;
+  virtual void Debug(const char *format, ...) __attribute__ ((__format__(printf, 2, 3))) = 0;
+  virtual void Verbose(const char *format, ...) __attribute__ ((__format__(printf, 2, 3))) = 0;
   virtual void BeginTrace(const char *class_name, const char *function_name,
                           const char *custom_string) = 0;
   virtual void EndTrace() = 0;