power: Spring cleanup
* Cleanup SoC specific files:
- Fix code spacing and indentation
- Remove dead code
- Remove useless comments
- Remove useless logs
- Make code uniform between the files so it's easier to diff
- Use declared enums when possible for power hints
Change-Id: Ie1378c94c53b33299927c5eb1bfc19f1a42b8743
diff --git a/power-8992.c b/power-8992.c
index 0f02cd6..274adb1 100644
--- a/power-8992.c
+++ b/power-8992.c
@@ -27,6 +27,7 @@
* OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN
* IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/
+
#define LOG_NIDEBUG 0
#include <errno.h>
@@ -88,13 +89,14 @@
};
#ifdef INTERACTION_BOOST
-int get_number_of_profiles() {
+int get_number_of_profiles()
+{
return 5;
}
#endif
-static void set_power_profile(int profile) {
-
+static void set_power_profile(int profile)
+{
if (profile == current_power_profile)
return;
@@ -124,36 +126,34 @@
perform_hint_action(DEFAULT_PROFILE_HINT_ID, profile_bias_performance,
ARRAY_SIZE(profile_bias_performance));
ALOGD("%s: Set bias perf mode", __func__);
-
}
current_power_profile = profile;
}
-static int process_video_encode_hint(void *metadata)
+static void process_video_encode_hint(void *metadata)
{
char governor[80];
struct video_encode_metadata_t video_encode_metadata;
if (get_scaling_governor(governor, sizeof(governor)) == -1) {
ALOGE("Can't obtain scaling governor.");
-
- return HINT_NONE;
+ return;
}
- /* Initialize encode metadata struct fields */
+ if (!metadata) {
+ return;
+ }
+
+ /* Initialize encode metadata struct fields. */
memset(&video_encode_metadata, 0, sizeof(struct video_encode_metadata_t));
video_encode_metadata.state = -1;
video_encode_metadata.hint_id = DEFAULT_VIDEO_ENCODE_HINT_ID;
- if (metadata) {
- if (parse_video_encode_metadata((char *)metadata, &video_encode_metadata) ==
- -1) {
- ALOGE("Error occurred while parsing metadata.");
- return HINT_NONE;
- }
- } else {
- return HINT_NONE;
+ if (parse_video_encode_metadata((char *)metadata,
+ &video_encode_metadata) == -1) {
+ ALOGE("Error occurred while parsing metadata.");
+ return;
}
if (video_encode_metadata.state == 1) {
@@ -164,19 +164,17 @@
* above_hispeed_delay - 40ms
* sched_small_tsk - 50
*/
- int resource_values[] = {0x2C07, 0x2F5A, 0x2704, 0x4032};
-
+ int resource_values[] = {
+ 0x2C07, 0x2F5A, 0x2704, 0x4032
+ };
perform_hint_action(video_encode_metadata.hint_id,
resource_values, ARRAY_SIZE(resource_values));
- return HINT_HANDLED;
}
} else if (video_encode_metadata.state == 0) {
if (is_interactive_governor(governor)) {
undo_hint_action(video_encode_metadata.hint_id);
- return HINT_HANDLED;
}
}
- return HINT_NONE;
}
static int resources_interaction_fling_boost[] = {
@@ -216,7 +214,6 @@
switch (hint) {
case POWER_HINT_INTERACTION:
- {
duration = 500; // 500ms by default
if (data) {
int input_duration = *((int*)data);
@@ -243,17 +240,14 @@
resources_interaction_boost);
}
return HINT_HANDLED;
- }
case POWER_HINT_LAUNCH:
- {
duration = 2000;
-
interaction(duration, ARRAY_SIZE(resources_launch),
resources_launch);
return HINT_HANDLED;
- }
case POWER_HINT_VIDEO_ENCODE:
- return process_video_encode_hint(data);
+ process_video_encode_hint(data);
+ return HINT_HANDLED;
default:
break;
}
@@ -266,7 +260,6 @@
if (get_scaling_governor(governor, sizeof(governor)) == -1) {
ALOGE("Can't obtain scaling governor.");
-
return HINT_NONE;
}
@@ -275,17 +268,17 @@
if (is_interactive_governor(governor)) {
// sched upmigrate = 99, sched downmigrate = 95
// keep the big cores around, but make them very hard to use
- int resource_values[] = { 0x4E63, 0x4F5F };
+ int resource_values[] = {
+ 0x4E63, 0x4F5F
+ };
perform_hint_action(DISPLAY_STATE_HINT_ID,
resource_values, ARRAY_SIZE(resource_values));
- return HINT_HANDLED;
}
} else {
/* Display on */
if (is_interactive_governor(governor)) {
undo_hint_action(DISPLAY_STATE_HINT_ID);
- return HINT_HANDLED;
}
}
- return HINT_NONE;
+ return HINT_HANDLED;
}