commit d6f61ebd80b698f20610ca466de1c9a03795d7b0
author Sunil Dutt <usdutt@codeaurora.org> Tue Mar 02 01:13:34 2021 -0800
committer Gerrit - the friendly Code Review server <code-review@localhost> Thu Apr 01 21:46:31 2021 -0700
tree 03187c54edb8ba256ff2eeaeed80ef92ceecf39a
parent 717f58316141d70b369cd6c974ff1a6e7c395f42

Type cast to correct data type for comparision in NANTLV_ReadTlv

pOutTlv->length is of type u16 while the inBufferSize is int.
The comparision between these different types is incorrect.
Hence, Type cast to correct data type for comparision in
NANTLV_ReadTlv.

Change-Id: I72f96622f1264777e6f66ed8962b99369498c873
CRs-fixed: 2884038

qcwcn/wifi_hal/nan.cpp

diff --git a/qcwcn/wifi_hal/nan.cpp b/qcwcn/wifi_hal/nan.cpp
index 2428e1d..e2d493e 100644
--- a/qcwcn/wifi_hal/nan.cpp
+++ b/qcwcn/wifi_hal/nan.cpp
@@ -1425,7 +1425,7 @@
     pOutTlv->length |= *pInTlv++ << 8;
     readLen += 2;
 
-    if(pOutTlv->length > inBufferSize - NAN_TLV_HEADER_SIZE) {
+    if(pOutTlv->length > (u16)(inBufferSize - NAN_TLV_HEADER_SIZE)) {
         ALOGE("Insufficient length to process TLV header, inBufferSize = %d",
               inBufferSize);
         return readLen;