commit fa49a7f7fa01f352f4d5c196939a1e92a6cd692e
author Ajay Nambi <anambi@codeaurora.org> Wed Aug 05 14:53:50 2015 +0530
committer Sanket Padawe <sanketpadawe@google.com> Thu Nov 12 13:12:08 2015 -0800
tree 3958b93785aaf4e7504edf3e27a57e457043f7a5
parent 51ca1cd89b0f6fc1a955ef94d1ecd75a49d312b7

Fix for rild crash becasue of buffer overflow

There is a buffer overflow which causing rild crash. For
appendPrintBuf, "sprintf" is replaced with "snprintf" for
the safe copy operation.

Bug:23289936
Change-Id: I25430a5c6f2a8b19a3271235323499b6ee802746

libril/ril.cpp

diff --git a/libril/ril.cpp b/libril/ril.cpp
index 30b4220..9b05829 100644
--- a/libril/ril.cpp
+++ b/libril/ril.cpp
@@ -109,7 +109,7 @@
 
     #define clearPrintBuf           printBuf[0] = 0
     #define removeLastChar          printBuf[strlen(printBuf)-1] = 0
-    #define appendPrintBuf(x...)    sprintf(printBuf, x)
+    #define appendPrintBuf(x...)    snprintf(printBuf, PRINTBUF_SIZE, x)
 #else
     #define startRequest
     #define closeRequest