Port JDK-7014860
- API change of SocketImpl.shutdownInput() and available()
- available() returns 0 after calling shutdownInput
- The change happens after 7 but before 8u60
Bug: 64065632
Test: cts-tradefed run cts-dev --module CtsLibcoreTestCases
Test: cts-tradefed run cts-dev --module CtsLibcoreOjTestCases
Change-Id: I53c14726e4c46b07bfd026bc010e3fc3c854dbcc
diff --git a/ojluni/src/main/java/java/net/AbstractPlainSocketImpl.java b/ojluni/src/main/java/java/net/AbstractPlainSocketImpl.java
index 16cf18c..5ad02d1 100644
--- a/ojluni/src/main/java/java/net/AbstractPlainSocketImpl.java
+++ b/ojluni/src/main/java/java/net/AbstractPlainSocketImpl.java
@@ -478,10 +478,10 @@
}
/*
- * If connection has been reset then return 0 to indicate
- * there are no buffered bytes.
+ * If connection has been reset or shut down for input, then return 0
+ * to indicate there are no buffered bytes.
*/
- if (isConnectionReset()) {
+ if (isConnectionReset() || shut_rd) {
return 0;
}
diff --git a/ojluni/src/main/java/java/net/SocketImpl.java b/ojluni/src/main/java/java/net/SocketImpl.java
index 688ba60..c0db070 100644
--- a/ojluni/src/main/java/java/net/SocketImpl.java
+++ b/ojluni/src/main/java/java/net/SocketImpl.java
@@ -182,8 +182,9 @@
* Any data sent to this socket is acknowledged and then
* silently discarded.
*
- * If you read from a socket input stream after invoking
- * shutdownInput() on the socket, the stream will return EOF.
+ * If you read from a socket input stream after invoking this method on the
+ * socket, the stream's {@code available} method will return 0, and its
+ * {@code read} methods will return {@code -1} (end of stream).
*
* @exception IOException if an I/O error occurs when shutting down this
* socket.
diff --git a/ojluni/src/test/java/net/Socket/ShutdownInput.java b/ojluni/src/test/java/net/Socket/ShutdownInput.java
new file mode 100644
index 0000000..eaec46a
--- /dev/null
+++ b/ojluni/src/test/java/net/Socket/ShutdownInput.java
@@ -0,0 +1,94 @@
+/*
+ * Copyright (c) 2011, Oracle and/or its affiliates. All rights reserved.
+ * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
+ *
+ * This code is free software; you can redistribute it and/or modify it
+ * under the terms of the GNU General Public License version 2 only, as
+ * published by the Free Software Foundation.
+ *
+ * This code is distributed in the hope that it will be useful, but WITHOUT
+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+ * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
+ * version 2 for more details (a copy is included in the LICENSE file that
+ * accompanied this code).
+ *
+ * You should have received a copy of the GNU General Public License version
+ * 2 along with this work; if not, write to the Free Software Foundation,
+ * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
+ *
+ * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
+ * or visit www.oracle.com if you need additional information or have any
+ * questions.
+ */
+
+/*
+ * @test
+ * @bug 7014860
+ * @summary Socket.getInputStream().available() not clear for
+ * case that connection is shutdown for reading
+ */
+
+package test.java.net.Socket;
+import org.testng.annotations.Test;
+import java.io.InputStream;
+import java.io.OutputStream;
+import java.net.InetAddress;
+import java.net.InetSocketAddress;
+import java.net.ServerSocket;
+import java.net.Socket;
+import java.nio.channels.ServerSocketChannel;
+import java.nio.channels.SocketChannel;
+
+public class ShutdownInput {
+ static boolean failed = false;
+
+ // Android-changed: Removed args & added @Test
+ @Test
+ public static void main() throws Exception {
+ InetAddress iaddr = InetAddress.getLocalHost();
+
+ try ( ServerSocket ss = new ServerSocket(0);
+ Socket s1 = new Socket(iaddr, ss.getLocalPort());
+ Socket s2 = ss.accept() ) {
+
+ test(s1, s2, "Testing NET");
+ }
+
+ // check the NIO socket adapter
+ try (ServerSocketChannel sc = ServerSocketChannel.open().bind(null);
+ SocketChannel s1 = SocketChannel.open(
+ new InetSocketAddress(iaddr, sc.socket().getLocalPort()));
+ SocketChannel s2 = sc.accept() ) {
+
+ test(s1.socket(), s2.socket(), "Testing NIO");
+ }
+
+ if (failed) {
+ throw new RuntimeException("Failed: check output");
+ }
+ }
+
+ public static void test(Socket s1, Socket s2, String mesg) throws Exception {
+ OutputStream os = s1.getOutputStream();
+ os.write("This is a message".getBytes("US-ASCII"));
+
+ InputStream in = s2.getInputStream();
+ s2.shutdownInput();
+
+ if (in.available() != 0) {
+ failed = true;
+ System.out.println(mesg + ":" + s2 + " in.available() should be 0, " +
+ "but returns "+ in.available());
+ }
+
+ byte[] ba = new byte[2];
+ if (in.read() != -1 ||
+ in.read(ba) != -1 ||
+ in.read(ba, 0, ba.length) != -1) {
+
+ failed = true;
+ System.out.append(mesg + ":" + s2 + " in.read() should be -1");
+ }
+ }
+}
+