commit 6ff0bc557127f5ee1300549ab5b2867ff19a1944
author Mathieu Chartier <mathieuc@google.com> Wed Nov 26 00:03:03 2014 +0000
committer Gerrit Code Review <noreply-gerritcodereview@google.com> Wed Nov 26 00:03:03 2014 +0000
tree 17e5ba5e02be0e0255a4c410cee6bbd2b0376b11
parent f75e5d4e5894ac2aa3b1441b69c02198ea7e5688
parent 3d38e8203d344acc9acd63c377b6a53683e1df67

Merge "Move dexCacheStrings from ArtMethod to ArtClass"

libart/src/main/java/java/lang/Class.java

diff --git a/libart/src/main/java/java/lang/Class.java b/libart/src/main/java/java/lang/Class.java
index a833f6c..d766385 100644
--- a/libart/src/main/java/java/lang/Class.java
+++ b/libart/src/main/java/java/lang/Class.java
@@ -138,6 +138,9 @@
      */
     private transient DexCache dexCache;
 
+    /** Short-cut to dexCache.strings */
+    private transient String[] dexCacheStrings;
+
     /** static, private, and <init> methods. */
     private transient ArtMethod[] directMethods;
 
@@ -453,7 +456,6 @@
      * @hide
      */
     public String getDexCacheString(Dex dex, int dexStringIndex) {
-        String[] dexCacheStrings = dexCache.strings;
         String s = dexCacheStrings[dexStringIndex];
         if (s == null) {
             s = dex.strings().get(dexStringIndex).intern();

libart/src/main/java/java/lang/reflect/ArtMethod.java

diff --git a/libart/src/main/java/java/lang/reflect/ArtMethod.java b/libart/src/main/java/java/lang/reflect/ArtMethod.java
index 07cc30c..95e03c6 100644
--- a/libart/src/main/java/java/lang/reflect/ArtMethod.java
+++ b/libart/src/main/java/java/lang/reflect/ArtMethod.java
@@ -53,9 +53,6 @@
     /** Short-cut to declaringClass.dexCache.resolvedTypes */
     /* package */ Class<?>[] dexCacheResolvedTypes;
 
-    /** Short-cut to declaringClass.dexCache.strings */
-    private String[] dexCacheStrings;
-
     /** Bits encoding access (e.g. public, private) as well as other runtime specific flags */
     private int accessFlags;
 
@@ -180,12 +177,7 @@
      * Method we can avoid one indirection.
      */
     private String getDexCacheString(Dex dex, int dexStringIndex) {
-        String s = (String) dexCacheStrings[dexStringIndex];
-        if (s == null) {
-            s = dex.strings().get(dexStringIndex).intern();
-            dexCacheStrings[dexStringIndex] = s;
-        }
-        return s;
+        return declaringClass.getDexCacheString(dex, dexStringIndex);
     }
 
     /**