commit 37a969d4b3ffb71b5e5939ef3556115c2b2e4cc1
author roldenburg <roldenburg@google.com> Thu Feb 22 14:46:44 2018 -0800
committer Copybara-Service <copybara-piper@google.com> Thu Feb 22 15:36:26 2018 -0800
tree d32b931223afa4e67512fcb8dd3bcb35fa5c0320
parent 4c29a7995936f72d7b229358863ab2df03e2f170

Fix bug in isVoicemailNumber method not returning early

Bug: 72997695
Test: existing tests, LoggerUtilsTest, placed call to voicemail and verified
PiperOrigin-RevId: 186677560
Change-Id: I63d0a463f890c8cc1a301daa37388f58aed33aae

java/com/android/incallui/call/DialerCall.java

diff --git a/java/com/android/incallui/call/DialerCall.java b/java/com/android/incallui/call/DialerCall.java
index 90a0140..50bc691 100644
--- a/java/com/android/incallui/call/DialerCall.java
+++ b/java/com/android/incallui/call/DialerCall.java
@@ -501,10 +501,12 @@
   private void updateIsVoiceMailNumber() {
     if (getHandle() != null && PhoneAccount.SCHEME_VOICEMAIL.equals(getHandle().getScheme())) {
       isVoicemailNumber = true;
+      return;
     }
 
     if (!PermissionsUtil.hasPermission(context, permission.READ_PHONE_STATE)) {
       isVoicemailNumber = false;
+      return;
     }
 
     isVoicemailNumber = TelecomUtil.isVoicemailNumber(context, getAccountHandle(), getNumber());