commit dde01c59422e1316fc51e53337e1a21dd2ffa480
author twyen <twyen@google.com> Fri Sep 22 10:07:31 2017 -0700
committer Eric Erfanian <erfanian@google.com> Fri Sep 22 12:20:06 2017 -0700
tree 41b20c72629f8c02f015b77e63a7e30b64158381
parent f8c23e67f17c5b7142bf4ab846f1b73e228c9f3d

Log non-contact lightbringer actions

video call upgrade and calling from call log is logged

Bug: 66222115
Test: DialerCallTest, GoogleCallLogAdapterTest
PiperOrigin-RevId: 169703001
Change-Id: Ib4dc3507dec09f49d41cec09d32cc9800477ee8b

java/com/android/incallui/call/DialerCall.java

diff --git a/java/com/android/incallui/call/DialerCall.java b/java/com/android/incallui/call/DialerCall.java
index ee9a926..a9bad5b 100644
--- a/java/com/android/incallui/call/DialerCall.java
+++ b/java/com/android/incallui/call/DialerCall.java
@@ -26,6 +26,7 @@
 import android.support.annotation.IntDef;
 import android.support.annotation.NonNull;
 import android.support.annotation.Nullable;
+import android.support.annotation.VisibleForTesting;
 import android.telecom.Call;
 import android.telecom.Call.Details;
 import android.telecom.CallAudioState;
@@ -57,6 +58,7 @@
 import com.android.dialer.enrichedcall.Session;
 import com.android.dialer.lightbringer.LightbringerComponent;
 import com.android.dialer.logging.ContactLookupResult;
+import com.android.dialer.logging.ContactLookupResult.Type;
 import com.android.dialer.logging.DialerImpression;
 import com.android.dialer.logging.Logger;
 import com.android.dialer.theme.R;
@@ -320,6 +322,18 @@
     updateEnrichedCallSession();
   }
 
+  /** Test only constructor to avoid initializing dependencies. */
+  @VisibleForTesting
+  DialerCall(Context context) {
+    mContext = context;
+    mTelecomCall = null;
+    mLatencyReport = null;
+    mId = null;
+    mHiddenId = 0;
+    mDialerCallDelegate = null;
+    mVideoTechManager = null;
+  }
+
   private static int translateState(int state) {
     switch (state) {
       case Call.STATE_NEW:
@@ -1250,6 +1264,15 @@
   @Override
   public void onImpressionLoggingNeeded(DialerImpression.Type impressionType) {
     Logger.get(mContext).logCallImpression(impressionType, getUniqueCallId(), getTimeAddedMs());
+    if (impressionType == DialerImpression.Type.LIGHTBRINGER_UPGRADE_REQUESTED) {
+      if (getLogState().contactLookupResult == Type.NOT_FOUND) {
+        Logger.get(mContext)
+            .logCallImpression(
+                DialerImpression.Type.LIGHTBRINGER_NON_CONTACT_UPGRADE_REQUESTED,
+                getUniqueCallId(),
+                getTimeAddedMs());
+      }
+    }
   }
 
   private void updateEnrichedCallSession() {