| commit | 484087c181cedb5a6418c8c10f81a36eaa49420f | [log] [tgz] |
|---|---|---|
| author | Jin Dong <jin.x.dong@sony.com> | Fri Dec 22 17:49:23 2017 +0800 |
| committer | Shunta Sato <shunta.sato@sony.com> | Mon Jan 29 16:32:45 2018 +0900 |
| tree | 808e54534f85022d2be7d7936c6b7337cd9cf7a6 | |
| parent | 5a56c3191318a2a193acc28abdc19589157f4d31 [diff] |
Fix memory leak of DataSaverPreference When DataSaverPreference is shown repeatedly, memory leak happens since DataSaverBackend.Listener is not removed on onDetached(). TEST: Repeat enter and exit "Data usage" for several times and check if the count of activity is not increasing. Bug: 72581115 Change-Id: Ic4a72de049bb87f1e522fe46dd0fb4bb58ed65a5
diff --git a/src/com/android/settings/datausage/DataSaverPreference.java b/src/com/android/settings/datausage/DataSaverPreference.java index 13ef9d7..f1f648a 100644 --- a/src/com/android/settings/datausage/DataSaverPreference.java +++ b/src/com/android/settings/datausage/DataSaverPreference.java
@@ -37,7 +37,7 @@ @Override public void onDetached() { super.onDetached(); - mDataSaverBackend.addListener(this); + mDataSaverBackend.remListener(this); } @Override