commit db237a6adeda20341d327e38201ad8b7b0055114
author Yi-Ling Chuang <emilychuang@google.com> Fri Apr 19 13:52:25 2019 +0800
committer Yi-Ling Chuang <emilychuang@google.com> Fri Apr 19 14:02:35 2019 +0800
tree cdebb114295b408eb3f579e1b48e7cd978b743d8
parent 9588c9003f41ff252c84609fa46c79fdc9fe040c

Fix the break of repo hook color check.

Add the missing color for notification importance button

Fixes: 130850328
Test: manual
Change-Id: I6c070fad42d5fb0e6d5e3aa00d66b32708dde605

color-check-baseline.xml

diff --git a/color-check-baseline.xml b/color-check-baseline.xml
index 02b00e2..e0a0206 100644
--- a/color-check-baseline.xml
+++ b/color-check-baseline.xml
@@ -3357,4 +3357,20 @@
             column="5"/>
     </issue>
 
+    <issue
+        id="HardCodedColor"
+        severity="Error"
+        message="Avoid using hardcoded color"
+        category="Correctness"
+        priority="4"
+        summary="Using hardcoded color"
+        explanation="Hardcoded color values are bad because theme changes cannot be uniformly applied.Instead use the theme specific colors such as `?android:attr/textColorPrimary` in attributes.&#xA;This ensures that a theme change from a light to a dark theme can be uniformlyapplied across the app."
+        errorLine1="    android:color=&quot;@color/notification_importance_button_unselected&quot;"
+        errorLine2="    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
+        <location
+            file="res/drawable/button_border_unselected.xml"
+            line="21"
+            column="10"/>
+    </issue>
+
 </issues>