commit 5349ce14695dc98615108eb26f96806921b0abba
author Vikram Aggarwal <viki@google.com> Mon Sep 24 14:12:40 2012 -0700
committer Vikram Aggarwal <viki@google.com> Mon Sep 24 15:11:55 2012 -0700
tree 20373dddb41a11eb9167cf185613d0d775eb210c
parent b2b98ba97983f225eec19dc9bc5333e6ef80ee15

JavaScript calls: Do not internationalize numbers

Numbers were getting internationalized because the system's printf
with the %d format tries to use the localized, unicode representation
of the number (setHeight=١٩٦px). Bad idea for all languages where the
numbers are written differently.

Bug: 7176003 Android MR1- Gmail App issues with Arabic
Change-Id: I95799b05d64c78127227cee8d351facbce4bcefa

src/com/android/mail/ui/ConversationViewFragment.java

diff --git a/src/com/android/mail/ui/ConversationViewFragment.java b/src/com/android/mail/ui/ConversationViewFragment.java
index 7180f7c..6eac59d 100644
--- a/src/com/android/mail/ui/ConversationViewFragment.java
+++ b/src/com/android/mail/ui/ConversationViewFragment.java
@@ -618,7 +618,7 @@
         final int h = mWebView.screenPxToWebPx(newSpacerHeightPx);
         LogUtils.i(LAYOUT_TAG, "setting HTML spacer h=%dwebPx (%dscreenPx)", h,
                 newSpacerHeightPx);
-        mWebView.loadUrl(String.format("javascript:setMessageHeaderSpacerHeight('%s', %d);",
+        mWebView.loadUrl(String.format("javascript:setMessageHeaderSpacerHeight('%s', %s);",
                 mTemplates.getMessageDomId(item.message), h));
     }
 
@@ -630,7 +630,7 @@
         final int h = mWebView.screenPxToWebPx(newSpacerHeightPx);
         LogUtils.i(LAYOUT_TAG, "setting HTML spacer expanded=%s h=%dwebPx (%dscreenPx)",
                 item.isExpanded(), h, newSpacerHeightPx);
-        mWebView.loadUrl(String.format("javascript:setMessageBodyVisible('%s', %s, %d);",
+        mWebView.loadUrl(String.format("javascript:setMessageBodyVisible('%s', %s, %s);",
                 mTemplates.getMessageDomId(item.message), item.isExpanded(), h));
 
         mViewState.setExpansionState(item.message,