commit | 5b62a95abaefd7cc1d58b71a90edc6e5f26691ec | [log] [tgz] |
---|---|---|
author | Vikram Aggarwal <viki@google.com> | Thu May 09 10:30:56 2013 -0700 |
committer | Vikram Aggarwal <viki@google.com> | Thu May 09 11:32:36 2013 -0700 |
tree | e58fcc7d9fc14735ac0f8db8ad913c34423e771b | |
parent | 943fa0cac110f5b918a975c44531ee6f858794db [diff] |
Smaller stars Bug: 8870312 Improved Star UX in Conversation List Change-Id: I93d94a4a7fc8d1b4e0f60f5eff8f1fc824760a7f
diff --git a/res/drawable-hdpi/ic_star_off.png b/res/drawable-hdpi/ic_star_off.png index 4476f91..cf1cd90 100644 --- a/res/drawable-hdpi/ic_star_off.png +++ b/res/drawable-hdpi/ic_star_off.png Binary files differ
diff --git a/res/drawable-hdpi/ic_star_on.png b/res/drawable-hdpi/ic_star_on.png index b4e7ceb..b694bbb 100644 --- a/res/drawable-hdpi/ic_star_on.png +++ b/res/drawable-hdpi/ic_star_on.png Binary files differ
diff --git a/res/drawable-mdpi/ic_star_off.png b/res/drawable-mdpi/ic_star_off.png index 3d959ef..522b5ab 100644 --- a/res/drawable-mdpi/ic_star_off.png +++ b/res/drawable-mdpi/ic_star_off.png Binary files differ
diff --git a/res/drawable-mdpi/ic_star_on.png b/res/drawable-mdpi/ic_star_on.png index 9f4318f..50dd679 100644 --- a/res/drawable-mdpi/ic_star_on.png +++ b/res/drawable-mdpi/ic_star_on.png Binary files differ
diff --git a/res/drawable-xhdpi/ic_star_off.png b/res/drawable-xhdpi/ic_star_off.png index 72c50b7..a611a1f 100644 --- a/res/drawable-xhdpi/ic_star_off.png +++ b/res/drawable-xhdpi/ic_star_off.png Binary files differ
diff --git a/res/drawable-xhdpi/ic_star_on.png b/res/drawable-xhdpi/ic_star_on.png index 31551a2..f77acd7 100644 --- a/res/drawable-xhdpi/ic_star_on.png +++ b/res/drawable-xhdpi/ic_star_on.png Binary files differ
diff --git a/res/layout/conversation_item_view_normal.xml b/res/layout/conversation_item_view_normal.xml index 350afd7..25eabe4 100644 --- a/res/layout/conversation_item_view_normal.xml +++ b/res/layout/conversation_item_view_normal.xml
@@ -145,7 +145,7 @@ android:layout_width="wrap_content" android:layout_height="wrap_content" android:layout_alignParentRight="true" - android:layout_marginTop="-6dp" + android:layout_marginTop="-1dp" android:src="@drawable/ic_star_off" /> <!-- we assume the star asset is less than 48dp wide -->
diff --git a/res/layout/conversation_item_view_normal_spacious.xml b/res/layout/conversation_item_view_normal_spacious.xml index b8bb2af..7bc05d3 100644 --- a/res/layout/conversation_item_view_normal_spacious.xml +++ b/res/layout/conversation_item_view_normal_spacious.xml
@@ -145,7 +145,7 @@ android:layout_width="wrap_content" android:layout_height="wrap_content" android:layout_alignParentRight="true" - android:layout_marginTop="-6dp" + android:layout_marginTop="-1dp" android:src="@drawable/ic_star_off" /> <!-- we assume the star asset is less than 48dp wide -->
diff --git a/res/layout/conversation_item_view_wide.xml b/res/layout/conversation_item_view_wide.xml index 949e964..3acda63 100644 --- a/res/layout/conversation_item_view_wide.xml +++ b/res/layout/conversation_item_view_wide.xml
@@ -140,7 +140,7 @@ android:id="@+id/star" android:layout_width="wrap_content" android:layout_height="wrap_content" - android:layout_marginTop="-12dp" + android:layout_marginTop="-1dp" android:layout_marginLeft="32dp" android:src="@drawable/ic_star_off" />
diff --git a/res/values/dimen.xml b/res/values/dimen.xml index 11d12a4..3c826ea 100644 --- a/res/values/dimen.xml +++ b/res/values/dimen.xml
@@ -31,7 +31,8 @@ <dimen name="compose_scrollview_width">700dp</dimen> <dimen name="color_block_width">32dip</dimen> <dimen name="color_block_height">6dip</dimen> - <dimen name="star_touch_slop">4dip</dimen> + <!-- The star is pretty small and does not have padding anymore, so the slop needs to be bigger--> + <dimen name="star_touch_slop">16dip</dimen> <dimen name="sender_image_touch_slop">8dip</dimen> <dimen name="move_slop">4dip</dimen> <dimen name="standard_scaled_dimen">100sp</dimen>