Gitiles
Code Review Sign In
gerrit-public.fairphone.software / platform / packages / modules / DnsResolver / 084871190e82da9564d229091cc1cd5c7175f4d3
commit084871190e82da9564d229091cc1cd5c7175f4d3[log] [tgz]
authorBernie Innocenti <codewiz@google.com>Fri Oct 11 21:14:13 2019 +0900
committerBernie Innocenti <codewiz@google.com>Thu Oct 17 10:06:24 2019 +0000
treef6157ae38bb36ca445fa9a8a48d5b40a9c8fc11e
parentbf0b3bcc2a2fa0e47c2d9126492a1ba3c2e2fae2 [diff]
Explicitly allocate ResState on the call stack

Previously known as __res_state, res_state, res or even statp, the
ResState struct holds the context of a query in progress.

After a long series of preparatory patches, the thread-local storage
nonsense that's been plaguing this fine codebase for decades is finally
gone. Sayonara! ResState is now explicitly allocated on the stack at the
beginning of each query and passed down as a regular function argument.

To keep this patch reviewable, I threw in two compatibility typedefs for
the legacy names. We'll get rid of them in a separate mechanical patch.

Next steps:
 - Give ResState a regular constructor and, crucially, a real destructor
 - Move the definition to ResState.h, like it's a real class
 - Populate the nameservers immediately on construction
 - Switch to safe C++ data structures

Change-Id: I5c0b85da3ad9a55fa41dca6c87e57fe8f50c6abc
14 files changed
tree: f6157ae38bb36ca445fa9a8a48d5b40a9c8fc11e
  1. aidl/
  2. apex/
  3. binder/
  4. include/
  5. tests/
  6. .clang-format ⇨ ../../../build/soong/scripts/system-clang-format
  7. .editorconfig
  8. Android.bp
  9. Dns64Configuration.cpp
  10. Dns64Configuration.h
  11. DnsProxyListener.cpp
  12. DnsProxyListener.h
  13. DnsResolver.cpp
  14. DnsResolver.h
  15. dnsresolver_binder_test.cpp
  16. DnsResolverService.cpp
  17. DnsResolverService.h
  18. DnsTlsDispatcher.cpp
  19. DnsTlsDispatcher.h
  20. DnsTlsQueryMap.cpp
  21. DnsTlsQueryMap.h
  22. DnsTlsServer.cpp
  23. DnsTlsServer.h
  24. DnsTlsSessionCache.cpp
  25. DnsTlsSessionCache.h
  26. DnsTlsSocket.cpp
  27. DnsTlsSocket.h
  28. DnsTlsSocketFactory.h
  29. DnsTlsTransport.cpp
  30. DnsTlsTransport.h
  31. getaddrinfo.cpp
  32. getaddrinfo.h
  33. gethnamaddr.cpp
  34. gethnamaddr.h
  35. hostent.h
  36. IDnsTlsSocket.h
  37. IDnsTlsSocketFactory.h
  38. IDnsTlsSocketObserver.h
  39. libnetd_resolv.map.txt
  40. LockedQueue.h
  41. NOTICE
  42. OWNERS
  43. PREUPLOAD.cfg
  44. PrivateDnsConfiguration.cpp
  45. PrivateDnsConfiguration.h
  46. README-DoT.md
  47. README.md
  48. res_cache.cpp
  49. res_comp.cpp
  50. res_debug.cpp
  51. res_debug.h
  52. res_init.cpp
  53. res_init.h
  54. res_mkquery.cpp
  55. res_query.cpp
  56. res_send.cpp
  57. res_send.h
  58. res_stats.cpp
  59. resolv_cache.h
  60. resolv_cache_unit_test.cpp
  61. resolv_integration_test.cpp
  62. resolv_private.h
  63. resolv_tls_unit_test.cpp
  64. resolv_unit_test.cpp
  65. ResolverController.cpp
  66. ResolverController.h
  67. ResolverEventReporter.cpp
  68. ResolverEventReporter.h
  69. ResolverStats.h
  70. sethostent.cpp
  71. stats.proto
  72. TEST_MAPPING
README.md

Logging

This code uses LOG(X) for logging. Log levels are VERBOSE,DEBUG,INFO,WARNING and ERROR. The default setting is WARNING and logs relate to WARNING and ERROR will be shown. If you want to enable the DEBUG level logs, using following command. adb shell service call dnsresolver 10 i32 1 VERBOSE 0 DEBUG 1 INFO 2 WARNING 3 ERROR 4 Verbose resolver logs could contain PII -- do NOT enable in production builds.