Gitiles
Code Review Sign In
gerrit-public.fairphone.software / platform / packages / modules / DnsResolver / d35d292452618cff69bb890275a91dbfda91dc34
commitd35d292452618cff69bb890275a91dbfda91dc34[log] [tgz]
authorBernie Innocenti <codewiz@google.com>Tue Oct 08 23:34:53 2019 +0900
committerBernie Innocenti <codewiz@google.com>Wed Oct 09 00:22:18 2019 +0900
treea2c979f10655d2937496600e2d1cccf8c9682258
parent3479d3b0dad4d626ebb33ee569f0e286d472599a [diff]
Remove separate IPv4-only nsaddr_list from res_state

The res_state struct held two separate lists of nameserver addresses,
presumably for binary compatibility with userspace poking directly at
libc internal data structures.

This change removes the IPv4 only statp->nsaddr_list and keeps the
deeply-nested statp->_u._ext.ext->nsaddrs, which is a sockaddr_union.

While cleaning up res_init, I had a wtf moment when I noticed that
HAS_INET6_STRUCTS is never defined. So, we don't actually support v6
nameservers??? The truth is: we don't really use res_setservers()
other than at initialization time, when it's a no-op, and
res_getservers() was actually dead code. So they can both rest in peace.

Test: m, flashall, atest
Change-Id: Iba0d5aa73f531b5ed925eb4178e5d5883c12a23d
6 files changed
tree: a2c979f10655d2937496600e2d1cccf8c9682258
  1. aidl/
  2. apex/
  3. binder/
  4. include/
  5. tests/
  6. .clang-format ⇨ ../../../build/soong/scripts/system-clang-format
  7. .editorconfig
  8. Android.bp
  9. Dns64Configuration.cpp
  10. Dns64Configuration.h
  11. DnsProxyListener.cpp
  12. DnsProxyListener.h
  13. DnsResolver.cpp
  14. DnsResolver.h
  15. dnsresolver_binder_test.cpp
  16. DnsResolverService.cpp
  17. DnsResolverService.h
  18. DnsTlsDispatcher.cpp
  19. DnsTlsDispatcher.h
  20. DnsTlsQueryMap.cpp
  21. DnsTlsQueryMap.h
  22. DnsTlsServer.cpp
  23. DnsTlsServer.h
  24. DnsTlsSessionCache.cpp
  25. DnsTlsSessionCache.h
  26. DnsTlsSocket.cpp
  27. DnsTlsSocket.h
  28. DnsTlsSocketFactory.h
  29. DnsTlsTransport.cpp
  30. DnsTlsTransport.h
  31. getaddrinfo.cpp
  32. getaddrinfo.h
  33. gethnamaddr.cpp
  34. gethnamaddr.h
  35. hostent.h
  36. IDnsTlsSocket.h
  37. IDnsTlsSocketFactory.h
  38. IDnsTlsSocketObserver.h
  39. libnetd_resolv.map.txt
  40. LockedQueue.h
  41. NOTICE
  42. OWNERS
  43. PREUPLOAD.cfg
  44. PrivateDnsConfiguration.cpp
  45. PrivateDnsConfiguration.h
  46. README-DoT.md
  47. README.md
  48. res_cache.cpp
  49. res_comp.cpp
  50. res_debug.cpp
  51. res_debug.h
  52. res_init.cpp
  53. res_init.h
  54. res_mkquery.cpp
  55. res_query.cpp
  56. res_send.cpp
  57. res_send.h
  58. res_state.cpp
  59. res_state_ext.h
  60. res_stats.cpp
  61. resolv_cache.h
  62. resolv_cache_unit_test.cpp
  63. resolv_integration_test.cpp
  64. resolv_private.h
  65. resolv_static.h
  66. resolv_tls_unit_test.cpp
  67. resolv_unit_test.cpp
  68. ResolverController.cpp
  69. ResolverController.h
  70. ResolverEventReporter.cpp
  71. ResolverEventReporter.h
  72. ResolverStats.h
  73. sethostent.cpp
  74. stats.proto
  75. TEST_MAPPING
README.md

Logging

This code uses LOG(X) for logging. Log levels are VERBOSE,DEBUG,INFO,WARNING and ERROR. The default setting is WARNING and logs relate to WARNING and ERROR will be shown. If you want to enable the DEBUG level logs, using following command. adb shell service call dnsresolver 10 i32 1 VERBOSE 0 DEBUG 1 INFO 2 WARNING 3 ERROR 4 Verbose resolver logs could contain PII -- do NOT enable in production builds.