Decouple PrivateDnsConfiguration from resolv_cache.h
This change is to simplify writting tests for PrivateDnsConfiguration.
Also add a network ID check before starting any resolver configuration.
Bug: 79727473
Test: cd packages/modules/DnsResolver && atest
Change-Id: Icf0040c67aafe5318a61fc3d2b7158d8f0384367
diff --git a/PrivateDnsConfiguration.cpp b/PrivateDnsConfiguration.cpp
index d806fa0..3a18f1e 100644
--- a/PrivateDnsConfiguration.cpp
+++ b/PrivateDnsConfiguration.cpp
@@ -28,7 +28,6 @@
#include "ResolverEventReporter.h"
#include "netd_resolv/resolv.h"
#include "netdutils/BackoffSequence.h"
-#include "resolv_cache.h"
#include "util.h"
using android::base::StringPrintf;
@@ -90,7 +89,6 @@
} else {
mPrivateDnsModes[netId] = PrivateDnsMode::OFF;
mPrivateDnsTransports.erase(netId);
- resolv_stats_set_servers_for_dot(netId, {});
mPrivateDnsValidateThreads.erase(netId);
// TODO: As mPrivateDnsValidateThreads is reset, validation threads which haven't yet
// finished are considered outdated. Consider signaling the outdated validation threads to
@@ -128,7 +126,7 @@
}
}
- return resolv_stats_set_servers_for_dot(netId, servers);
+ return 0;
}
PrivateDnsStatus PrivateDnsConfiguration::getStatus(unsigned netId) {