blob: 5d41a8af3ffdcdc634688504cbe8a09a43604a48 [file] [log] [blame]
Ken Chenb9fa2062018-11-13 21:51:13 +08001/*
2 * Copyright (C) 2016 The Android Open Source Project
3 *
4 * Licensed under the Apache License, Version 2.0 (the "License");
5 * you may not use this file except in compliance with the License.
6 * You may obtain a copy of the License at
7 *
8 * http://www.apache.org/licenses/LICENSE-2.0
9 *
Lorenzo Colitti0a8b4aa2019-06-26 22:31:03 +090010 * Unless required by applicable law or agreed to in writing, software
Ken Chenb9fa2062018-11-13 21:51:13 +080011 * distributed under the License is distributed on an "AS IS" BASIS,
12 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13 * See the License for the specific language governing permissions and
14 * limitations under the License.
15 *
16 */
17
Bernie Innocenti3952ccc2019-03-03 19:39:53 +090018#define LOG_TAG "resolv_integration_test"
Ken Chenb9fa2062018-11-13 21:51:13 +080019
Hungming Chen5bf09772019-04-25 11:16:13 +080020#include <android-base/logging.h>
Bernie Innocenti41b82c42019-06-05 22:38:25 +090021#include <android-base/parseint.h>
Mike Yu40e67072019-10-09 21:14:09 +080022#include <android-base/properties.h>
Mike Yu6ce587d2019-12-19 21:30:22 +080023#include <android-base/result.h>
Bernie Innocenti41b82c42019-06-05 22:38:25 +090024#include <android-base/stringprintf.h>
25#include <android-base/unique_fd.h>
26#include <android/multinetwork.h> // ResNsendFlags
Ken Chenb9fa2062018-11-13 21:51:13 +080027#include <arpa/inet.h>
Luke Huang94b10b92018-11-21 20:13:38 +080028#include <arpa/nameser.h>
Hungming Chene8f970c2019-04-10 17:34:06 +080029#include <binder/ProcessState.h>
Lorenzo Colittieb9aeec2019-06-26 19:53:55 +090030#include <bpf/BpfUtils.h>
Bernie Innocenti41b82c42019-06-05 22:38:25 +090031#include <cutils/sockets.h>
32#include <gmock/gmock-matchers.h>
33#include <gtest/gtest.h>
Ken Chenb9fa2062018-11-13 21:51:13 +080034#include <netdb.h>
Luke Huang9d2d25b2019-06-14 00:34:05 +080035#include <netdutils/InternetAddresses.h>
Luke Huang579ddc72019-06-14 00:59:39 +080036#include <netdutils/NetworkConstants.h> // SHA256_SIZE
Luke Huang9d2d25b2019-06-14 00:34:05 +080037#include <netdutils/ResponseCode.h>
Hungming Chen63779052019-10-30 15:06:13 +080038#include <netdutils/Slice.h>
Luke Huang9d2d25b2019-06-14 00:34:05 +080039#include <netdutils/SocketOption.h>
Mike Yu40e67072019-10-09 21:14:09 +080040#include <netdutils/Stopwatch.h>
Luke Huang94b10b92018-11-21 20:13:38 +080041#include <netinet/in.h>
42#include <poll.h> /* poll */
Bernie Innocenti41b82c42019-06-05 22:38:25 +090043#include <private/android_filesystem_config.h>
Luke Huang94b10b92018-11-21 20:13:38 +080044#include <resolv.h>
Ken Chenb9fa2062018-11-13 21:51:13 +080045#include <stdarg.h>
Ken Chenb9fa2062018-11-13 21:51:13 +080046#include <stdlib.h>
Luke Huang94b10b92018-11-21 20:13:38 +080047#include <sys/socket.h>
48#include <sys/un.h>
Ken Chenb9fa2062018-11-13 21:51:13 +080049#include <unistd.h>
50
51#include <algorithm>
52#include <chrono>
53#include <iterator>
54#include <numeric>
55#include <thread>
Luke Huang81568fb2020-07-13 00:55:12 +080056#include <unordered_set>
Ken Chenb9fa2062018-11-13 21:51:13 +080057
Luke Huang829511c2020-05-26 17:31:15 +080058#include <DnsProxydProtocol.h> // NETID_USE_LOCAL_NAMESERVERS
Luke Huangf8215372019-11-22 11:53:41 +080059#include <aidl/android/net/IDnsResolver.h>
60#include <android/binder_manager.h>
61#include <android/binder_process.h>
Luke Huang5729afc2020-07-30 23:12:17 +080062#include <util.h> // getApiLevel
Bernie Innocenti41b82c42019-06-05 22:38:25 +090063#include "NetdClient.h"
Bernie Innocenti41b82c42019-06-05 22:38:25 +090064#include "ResolverStats.h"
Luke Huangf8215372019-11-22 11:53:41 +080065#include "netid_client.h" // NETID_UNSET
66#include "params.h" // MAXNS
Mike Yu532405f2020-06-17 17:46:44 +080067#include "stats.h" // RCODE_TIMEOUT
Hungming Chene8f970c2019-04-10 17:34:06 +080068#include "tests/dns_metrics_listener/dns_metrics_listener.h"
chenbruceb43ec752019-07-24 20:19:41 +080069#include "tests/dns_responder/dns_responder.h"
Luke Huangf8215372019-11-22 11:53:41 +080070#include "tests/dns_responder/dns_responder_client_ndk.h"
Hungming Chenc6556622019-10-02 16:01:07 +080071#include "tests/dns_responder/dns_tls_certificate.h"
chenbruceb43ec752019-07-24 20:19:41 +080072#include "tests/dns_responder/dns_tls_frontend.h"
Luke Huangfde82482019-06-04 01:04:53 +080073#include "tests/resolv_test_utils.h"
Mike Yu6ce587d2019-12-19 21:30:22 +080074#include "tests/tun_forwarder.h"
Ken Chenb9fa2062018-11-13 21:51:13 +080075
Luke Huang0d592bc2019-05-25 18:24:03 +080076// Valid VPN netId range is 100 ~ 65535
77constexpr int TEST_VPN_NETID = 65502;
Luke Huang94b10b92018-11-21 20:13:38 +080078constexpr int MAXPACKET = (8 * 1024);
Ken Chenb9fa2062018-11-13 21:51:13 +080079
Mike Yu10832aa2020-08-25 19:13:11 +080080const std::string kSortNameserversFlag("persist.device_config.netd_native.sort_nameservers");
Mike Yue93d9ae2020-08-25 19:09:51 +080081const std::string kDotConnectTimeoutMsFlag(
82 "persist.device_config.netd_native.dot_connect_timeout_ms");
83const std::string kDotAsyncHandshakeFlag("persist.device_config.netd_native.dot_async_handshake");
Mike Yubb499092020-08-28 19:18:42 +080084const std::string kDotMaxretriesFlag("persist.device_config.netd_native.dot_maxtries");
Mike Yu10832aa2020-08-25 19:13:11 +080085
Ken Chenb9fa2062018-11-13 21:51:13 +080086// Semi-public Bionic hook used by the NDK (frameworks/base/native/android/net.c)
87// Tested here for convenience.
88extern "C" int android_getaddrinfofornet(const char* hostname, const char* servname,
89 const addrinfo* hints, unsigned netid, unsigned mark,
90 struct addrinfo** result);
91
Mike Yu153b5b82020-03-04 19:53:54 +080092using namespace std::chrono_literals;
93
Luke Huang70070852019-11-25 18:25:50 +080094using aidl::android::net::IDnsResolver;
Luke Huangf8215372019-11-22 11:53:41 +080095using aidl::android::net::INetd;
Mike Yu8ac63402019-12-02 15:28:38 +080096using aidl::android::net::ResolverParamsParcel;
Mike Yu532405f2020-06-17 17:46:44 +080097using aidl::android::net::metrics::INetdEventListener;
Mike Yu6ce587d2019-12-19 21:30:22 +080098using android::base::Error;
Luke Huang9807e6b2019-05-20 16:17:12 +080099using android::base::ParseInt;
Mike Yu6ce587d2019-12-19 21:30:22 +0800100using android::base::Result;
Ken Chenb9fa2062018-11-13 21:51:13 +0800101using android::base::StringPrintf;
Luke Huang9807e6b2019-05-20 16:17:12 +0800102using android::base::unique_fd;
Ken Chenb9fa2062018-11-13 21:51:13 +0800103using android::net::ResolverStats;
Mike Yu6ce587d2019-12-19 21:30:22 +0800104using android::net::TunForwarder;
Hungming Chene8f970c2019-04-10 17:34:06 +0800105using android::net::metrics::DnsMetricsListener;
Ken Chenb9fa2062018-11-13 21:51:13 +0800106using android::netdutils::enableSockopt;
Hungming Chen63779052019-10-30 15:06:13 +0800107using android::netdutils::makeSlice;
Luke Huang9807e6b2019-05-20 16:17:12 +0800108using android::netdutils::ResponseCode;
Luke Huang9d2d25b2019-06-14 00:34:05 +0800109using android::netdutils::ScopedAddrinfo;
Mike Yu40e67072019-10-09 21:14:09 +0800110using android::netdutils::Stopwatch;
Hungming Chen63779052019-10-30 15:06:13 +0800111using android::netdutils::toHex;
Ken Chenb9fa2062018-11-13 21:51:13 +0800112
113// TODO: move into libnetdutils?
114namespace {
Luke Huangfde82482019-06-04 01:04:53 +0800115
Ken Chenb9fa2062018-11-13 21:51:13 +0800116ScopedAddrinfo safe_getaddrinfo(const char* node, const char* service,
117 const struct addrinfo* hints) {
118 addrinfo* result = nullptr;
119 if (getaddrinfo(node, service, hints, &result) != 0) {
120 result = nullptr; // Should already be the case, but...
121 }
122 return ScopedAddrinfo(result);
123}
Luke Huangfde82482019-06-04 01:04:53 +0800124
Mike Yu40e67072019-10-09 21:14:09 +0800125std::pair<ScopedAddrinfo, int> safe_getaddrinfo_time_taken(const char* node, const char* service,
126 const addrinfo& hints) {
127 Stopwatch s;
128 ScopedAddrinfo result = safe_getaddrinfo(node, service, &hints);
129 return {std::move(result), s.timeTakenUs() / 1000};
130}
131
Mike Yue2162e52020-03-04 18:43:46 +0800132struct NameserverStats {
133 NameserverStats() = delete;
134 NameserverStats(const std::string server) : server(server) {}
135 NameserverStats& setSuccesses(int val) {
136 successes = val;
137 return *this;
138 }
139 NameserverStats& setErrors(int val) {
140 errors = val;
141 return *this;
142 }
143 NameserverStats& setTimeouts(int val) {
144 timeouts = val;
145 return *this;
146 }
147 NameserverStats& setInternalErrors(int val) {
148 internal_errors = val;
149 return *this;
150 }
151
152 const std::string server;
153 int successes = 0;
154 int errors = 0;
155 int timeouts = 0;
156 int internal_errors = 0;
157};
158
Mike Yu61d17262020-02-15 18:56:22 +0800159class ScopedSystemProperties {
160 public:
161 ScopedSystemProperties(const std::string& key, const std::string& value) : mStoredKey(key) {
162 mStoredValue = android::base::GetProperty(key, "");
163 android::base::SetProperty(key, value);
164 }
165 ~ScopedSystemProperties() { android::base::SetProperty(mStoredKey, mStoredValue); }
166
167 private:
168 std::string mStoredKey;
169 std::string mStoredValue;
170};
171
Luke Huang5729afc2020-07-30 23:12:17 +0800172const bool isAtLeastR = (getApiLevel() >= 30);
173
Ken Chenb9fa2062018-11-13 21:51:13 +0800174} // namespace
175
Bernie Innocentia5c7b7b2019-01-17 21:28:24 +0900176class ResolverTest : public ::testing::Test {
Hungming Chene8f970c2019-04-10 17:34:06 +0800177 public:
Hungming Chen473c4de2020-03-12 11:13:35 +0800178 static void SetUpTestSuite() {
Hungming Chen5bf09772019-04-25 11:16:13 +0800179 // Get binder service.
180 // Note that |mDnsClient| is not used for getting binder service in this static function.
181 // The reason is that wants to keep |mDnsClient| as a non-static data member. |mDnsClient|
182 // which sets up device network configuration could be independent from every test.
Luke Huangf8215372019-11-22 11:53:41 +0800183 // TODO: Perhaps add a static function in resolv_test_binder_utils.{cpp,h} to get binder
184 // service.
185
186 AIBinder* binder = AServiceManager_getService("dnsresolver");
187 ndk::SpAIBinder resolvBinder = ndk::SpAIBinder(binder);
188 auto resolvService = aidl::android::net::IDnsResolver::fromBinder(resolvBinder);
Hungming Chen5bf09772019-04-25 11:16:13 +0800189 ASSERT_NE(nullptr, resolvService.get());
190
191 // Subscribe the death recipient to the service IDnsResolver for detecting Netd death.
Luke Huang70070852019-11-25 18:25:50 +0800192 // GTEST assertion macros are not invoked for generating a test failure in the death
193 // recipient because the macros can't indicate failed test if Netd died between tests.
194 // Moreover, continuing testing may have no meaningful after Netd death. Therefore, the
195 // death recipient aborts process by GTEST_LOG_(FATAL) once Netd died.
Luke Huangf8215372019-11-22 11:53:41 +0800196 sResolvDeathRecipient = AIBinder_DeathRecipient_new([](void*) {
197 constexpr char errorMessage[] = "Netd died";
198 LOG(ERROR) << errorMessage;
199 GTEST_LOG_(FATAL) << errorMessage;
200 });
201 ASSERT_EQ(STATUS_OK, AIBinder_linkToDeath(binder, sResolvDeathRecipient, nullptr));
Hungming Chen5bf09772019-04-25 11:16:13 +0800202
203 // Subscribe the DNS listener for verifying DNS metrics event contents.
Luke Huangf8215372019-11-22 11:53:41 +0800204 sDnsMetricsListener = ndk::SharedRefBase::make<DnsMetricsListener>(
205 TEST_NETID /*monitor specific network*/);
Hungming Chen5bf09772019-04-25 11:16:13 +0800206 ASSERT_TRUE(resolvService->registerEventListener(sDnsMetricsListener).isOk());
207
208 // Start the binder thread pool for listening DNS metrics events and receiving death
209 // recipient.
Luke Huangf8215372019-11-22 11:53:41 +0800210 ABinderProcess_startThreadPool();
Hungming Chene8f970c2019-04-10 17:34:06 +0800211 }
Hungming Chen473c4de2020-03-12 11:13:35 +0800212 static void TearDownTestSuite() { AIBinder_DeathRecipient_delete(sResolvDeathRecipient); }
Hungming Chene8f970c2019-04-10 17:34:06 +0800213
Ken Chenb9fa2062018-11-13 21:51:13 +0800214 protected:
Lorenzo Colitti61f796b2020-05-21 00:57:49 +0900215 void SetUp() {
216 mDnsClient.SetUp();
217 sDnsMetricsListener->reset();
218 }
219
Mike Yu960243d2020-01-17 19:02:15 +0800220 void TearDown() {
221 // Ensure the dump works at the end of each test.
222 DumpResolverService();
223
224 mDnsClient.TearDown();
225 }
nuccachena26cc2a2018-07-17 18:07:23 +0800226
Luke Huangf40df9c2020-04-21 08:51:48 +0800227 void resetNetwork() {
228 mDnsClient.TearDown();
229 mDnsClient.SetupOemNetwork();
230 }
231
Xiao Ma09b71022018-12-11 17:56:32 +0900232 void StartDns(test::DNSResponder& dns, const std::vector<DnsRecord>& records) {
233 for (const auto& r : records) {
234 dns.addMapping(r.host_name, r.type, r.addr);
235 }
236
237 ASSERT_TRUE(dns.startServer());
238 dns.clearQueries();
239 }
Bernie Innocentia5c7b7b2019-01-17 21:28:24 +0900240
Mike Yu960243d2020-01-17 19:02:15 +0800241 void DumpResolverService() {
242 unique_fd fd(open("/dev/null", O_WRONLY));
243 EXPECT_EQ(mDnsClient.resolvService()->dump(fd, nullptr, 0), 0);
244
245 const char* querylogCmd[] = {"querylog"}; // Keep it sync with DnsQueryLog::DUMP_KEYWORD.
246 EXPECT_EQ(mDnsClient.resolvService()->dump(fd, querylogCmd, std::size(querylogCmd)), 0);
247 }
248
Hungming Chene8f970c2019-04-10 17:34:06 +0800249 bool WaitForNat64Prefix(ExpectNat64PrefixStatus status,
250 std::chrono::milliseconds timeout = std::chrono::milliseconds(1000)) {
Hungming Chen5bf09772019-04-25 11:16:13 +0800251 return sDnsMetricsListener->waitForNat64Prefix(status, timeout);
Hungming Chene8f970c2019-04-10 17:34:06 +0800252 }
253
Mike Yu724f77d2019-08-16 11:14:50 +0800254 bool WaitForPrivateDnsValidation(std::string serverAddr, bool validated) {
255 return sDnsMetricsListener->waitForPrivateDnsValidation(serverAddr, validated);
256 }
257
Mike Yu153b5b82020-03-04 19:53:54 +0800258 bool hasUncaughtPrivateDnsValidation(const std::string& serverAddr) {
259 return sDnsMetricsListener->findValidationRecord(serverAddr);
260 }
261
Mike Yu532405f2020-06-17 17:46:44 +0800262 void ExpectDnsEvent(int32_t eventType, int32_t returnCode, const std::string& hostname,
263 const std::vector<std::string>& ipAddresses) {
264 const DnsMetricsListener::DnsEvent expect = {
265 TEST_NETID, eventType, returnCode,
266 hostname, ipAddresses, static_cast<int32_t>(ipAddresses.size())};
Mike Yub8faac42020-06-20 11:11:44 +0800267 do {
268 // Blocking call until timeout.
269 const auto dnsEvent = sDnsMetricsListener->popDnsEvent();
270 ASSERT_TRUE(dnsEvent.has_value()) << "Expected DnsEvent " << expect;
271 if (dnsEvent.value() == expect) break;
272 LOG(INFO) << "Skip unexpected DnsEvent: " << dnsEvent.value();
273 } while (true);
Mike Yu532405f2020-06-17 17:46:44 +0800274 }
275
Mike Yu61d17262020-02-15 18:56:22 +0800276 enum class StatsCmp { LE, EQ };
277
278 bool expectStatsNotGreaterThan(const std::vector<NameserverStats>& nameserversStats) {
279 return expectStatsFromGetResolverInfo(nameserversStats, StatsCmp::LE);
280 }
281
282 bool expectStatsEqualTo(const std::vector<NameserverStats>& nameserversStats) {
283 return expectStatsFromGetResolverInfo(nameserversStats, StatsCmp::EQ);
284 }
285
286 bool expectStatsFromGetResolverInfo(const std::vector<NameserverStats>& nameserversStats,
287 const StatsCmp cmp) {
Mike Yue2162e52020-03-04 18:43:46 +0800288 std::vector<std::string> res_servers;
289 std::vector<std::string> res_domains;
290 std::vector<std::string> res_tls_servers;
291 res_params res_params;
292 std::vector<ResolverStats> res_stats;
293 int wait_for_pending_req_timeout_count;
294
295 if (!DnsResponderClient::GetResolverInfo(mDnsClient.resolvService(), TEST_NETID,
296 &res_servers, &res_domains, &res_tls_servers,
297 &res_params, &res_stats,
298 &wait_for_pending_req_timeout_count)) {
299 ADD_FAILURE() << "GetResolverInfo failed";
300 return false;
301 }
302
303 if (res_servers.size() != res_stats.size()) {
304 ADD_FAILURE() << fmt::format("res_servers.size() != res_stats.size(): {} != {}",
305 res_servers.size(), res_stats.size());
306 return false;
307 }
308 if (res_servers.size() != nameserversStats.size()) {
309 ADD_FAILURE() << fmt::format("res_servers.size() != nameserversStats.size(): {} != {}",
310 res_servers.size(), nameserversStats.size());
311 return false;
312 }
313
314 for (const auto& stats : nameserversStats) {
315 SCOPED_TRACE(stats.server);
316 const auto it = std::find(res_servers.begin(), res_servers.end(), stats.server);
317 if (it == res_servers.end()) {
318 ADD_FAILURE() << fmt::format("nameserver {} not found in the list {{{}}}",
319 stats.server, fmt::join(res_servers, ", "));
320 return false;
321 }
322 const int index = std::distance(res_servers.begin(), it);
323
324 // The check excludes rtt_avg, last_sample_time, and usable since they will be obsolete
325 // after |res_stats| is retrieved from NetConfig.dnsStats rather than NetConfig.nsstats.
Mike Yu61d17262020-02-15 18:56:22 +0800326 switch (cmp) {
327 case StatsCmp::EQ:
328 EXPECT_EQ(res_stats[index].successes, stats.successes);
329 EXPECT_EQ(res_stats[index].errors, stats.errors);
330 EXPECT_EQ(res_stats[index].timeouts, stats.timeouts);
331 EXPECT_EQ(res_stats[index].internal_errors, stats.internal_errors);
332 break;
333 case StatsCmp::LE:
334 EXPECT_LE(res_stats[index].successes, stats.successes);
335 EXPECT_LE(res_stats[index].errors, stats.errors);
336 EXPECT_LE(res_stats[index].timeouts, stats.timeouts);
337 EXPECT_LE(res_stats[index].internal_errors, stats.internal_errors);
338 break;
339 default:
340 ADD_FAILURE() << "Unknown comparator " << static_cast<int>(cmp);
341 return false;
342 }
Mike Yue2162e52020-03-04 18:43:46 +0800343 }
344
345 return true;
346 }
347
Mike Yu153b5b82020-03-04 19:53:54 +0800348 // Since there's no way to terminate private DNS validation threads at any time. Tests that
349 // focus on the results of private DNS validation can interfere with each other if they use the
350 // same IP address for test servers. getUniqueIPv4Address() is a workaround to reduce the
351 // possibility of tests being flaky. A feasible solution is to forbid the validation threads,
352 // which are considered as outdated (e.g. switch the resolver to private DNS OFF mode), updating
353 // the result to the PrivateDnsConfiguration instance.
354 static std::string getUniqueIPv4Address() {
355 static int counter = 0;
356 return fmt::format("127.0.100.{}", (++counter & 0xff));
357 }
358
Bernie Innocentia5c7b7b2019-01-17 21:28:24 +0900359 DnsResponderClient mDnsClient;
Xiao Ma09b71022018-12-11 17:56:32 +0900360
Hungming Chen5bf09772019-04-25 11:16:13 +0800361 // Use a shared static DNS listener for all tests to avoid registering lots of listeners
362 // which may be released late until process terminated. Currently, registered DNS listener
363 // is removed by binder death notification which is fired when the process hosting an
364 // IBinder has gone away. If every test in ResolverTest registers its DNS listener, Netd
365 // may temporarily hold lots of dead listeners until the unit test process terminates.
366 // TODO: Perhaps add an unregistering listener binder call or fork a listener process which
367 // could be terminated earlier.
Luke Huangf8215372019-11-22 11:53:41 +0800368 static std::shared_ptr<DnsMetricsListener>
Hungming Chen473c4de2020-03-12 11:13:35 +0800369 sDnsMetricsListener; // Initialized in SetUpTestSuite.
Hungming Chen5bf09772019-04-25 11:16:13 +0800370
371 // Use a shared static death recipient to monitor the service death. The static death
372 // recipient could monitor the death not only during the test but also between tests.
Hungming Chen473c4de2020-03-12 11:13:35 +0800373 static AIBinder_DeathRecipient* sResolvDeathRecipient; // Initialized in SetUpTestSuite.
Ken Chenb9fa2062018-11-13 21:51:13 +0800374};
375
Hungming Chen5bf09772019-04-25 11:16:13 +0800376// Initialize static member of class.
Luke Huangf8215372019-11-22 11:53:41 +0800377std::shared_ptr<DnsMetricsListener> ResolverTest::sDnsMetricsListener;
378AIBinder_DeathRecipient* ResolverTest::sResolvDeathRecipient;
Hungming Chen5bf09772019-04-25 11:16:13 +0800379
Ken Chenb9fa2062018-11-13 21:51:13 +0800380TEST_F(ResolverTest, GetHostByName) {
Xiao Ma09b71022018-12-11 17:56:32 +0900381 constexpr char nonexistent_host_name[] = "nonexistent.example.com.";
382
383 test::DNSResponder dns;
384 StartDns(dns, {{kHelloExampleCom, ns_type::ns_t_a, "1.2.3.3"}});
385 ASSERT_TRUE(mDnsClient.SetResolversForNetwork());
Ken Chenb9fa2062018-11-13 21:51:13 +0800386
387 const hostent* result;
Ken Chenb9fa2062018-11-13 21:51:13 +0800388 result = gethostbyname("nonexistent");
389 EXPECT_EQ(1U, GetNumQueriesForType(dns, ns_type::ns_t_a, nonexistent_host_name));
390 ASSERT_TRUE(result == nullptr);
391 ASSERT_EQ(HOST_NOT_FOUND, h_errno);
392
393 dns.clearQueries();
394 result = gethostbyname("hello");
Xiao Ma09b71022018-12-11 17:56:32 +0900395 EXPECT_EQ(1U, GetNumQueriesForType(dns, ns_type::ns_t_a, kHelloExampleCom));
Ken Chenb9fa2062018-11-13 21:51:13 +0800396 ASSERT_FALSE(result == nullptr);
397 ASSERT_EQ(4, result->h_length);
398 ASSERT_FALSE(result->h_addr_list[0] == nullptr);
399 EXPECT_EQ("1.2.3.3", ToString(result));
400 EXPECT_TRUE(result->h_addr_list[1] == nullptr);
Ken Chenb9fa2062018-11-13 21:51:13 +0800401}
402
lifr4e4a2e02019-01-29 16:53:51 +0800403TEST_F(ResolverTest, GetHostByName_cnames) {
404 constexpr char host_name[] = "host.example.com.";
405 size_t cnamecount = 0;
406 test::DNSResponder dns;
407
408 const std::vector<DnsRecord> records = {
409 {kHelloExampleCom, ns_type::ns_t_cname, "a.example.com."},
410 {"a.example.com.", ns_type::ns_t_cname, "b.example.com."},
411 {"b.example.com.", ns_type::ns_t_cname, "c.example.com."},
412 {"c.example.com.", ns_type::ns_t_cname, "d.example.com."},
413 {"d.example.com.", ns_type::ns_t_cname, "e.example.com."},
414 {"e.example.com.", ns_type::ns_t_cname, host_name},
415 {host_name, ns_type::ns_t_a, "1.2.3.3"},
416 {host_name, ns_type::ns_t_aaaa, "2001:db8::42"},
417 };
418 StartDns(dns, records);
419 ASSERT_TRUE(mDnsClient.SetResolversForNetwork());
420
421 // using gethostbyname2() to resolve ipv4 hello.example.com. to 1.2.3.3
422 // Ensure the v4 address and cnames are correct
423 const hostent* result;
424 result = gethostbyname2("hello", AF_INET);
425 ASSERT_FALSE(result == nullptr);
426
427 for (int i = 0; result != nullptr && result->h_aliases[i] != nullptr; i++) {
428 std::string domain_name = records[i].host_name.substr(0, records[i].host_name.size() - 1);
429 EXPECT_EQ(result->h_aliases[i], domain_name);
430 cnamecount++;
431 }
432 // The size of "Non-cname type" record in DNS records is 2
433 ASSERT_EQ(cnamecount, records.size() - 2);
434 ASSERT_EQ(4, result->h_length);
435 ASSERT_FALSE(result->h_addr_list[0] == nullptr);
436 EXPECT_EQ("1.2.3.3", ToString(result));
437 EXPECT_TRUE(result->h_addr_list[1] == nullptr);
438 EXPECT_EQ(1U, dns.queries().size()) << dns.dumpQueries();
439
440 // using gethostbyname2() to resolve ipv6 hello.example.com. to 2001:db8::42
441 // Ensure the v6 address and cnames are correct
442 cnamecount = 0;
443 dns.clearQueries();
444 result = gethostbyname2("hello", AF_INET6);
445 for (unsigned i = 0; result != nullptr && result->h_aliases[i] != nullptr; i++) {
446 std::string domain_name = records[i].host_name.substr(0, records[i].host_name.size() - 1);
447 EXPECT_EQ(result->h_aliases[i], domain_name);
448 cnamecount++;
449 }
450 // The size of "Non-cname type" DNS record in records is 2
451 ASSERT_EQ(cnamecount, records.size() - 2);
452 ASSERT_FALSE(result == nullptr);
453 ASSERT_EQ(16, result->h_length);
454 ASSERT_FALSE(result->h_addr_list[0] == nullptr);
455 EXPECT_EQ("2001:db8::42", ToString(result));
456 EXPECT_TRUE(result->h_addr_list[1] == nullptr);
457}
458
459TEST_F(ResolverTest, GetHostByName_cnamesInfiniteLoop) {
460 test::DNSResponder dns;
461 const std::vector<DnsRecord> records = {
462 {kHelloExampleCom, ns_type::ns_t_cname, "a.example.com."},
463 {"a.example.com.", ns_type::ns_t_cname, kHelloExampleCom},
464 };
465 StartDns(dns, records);
466 ASSERT_TRUE(mDnsClient.SetResolversForNetwork());
467
468 const hostent* result;
469 result = gethostbyname2("hello", AF_INET);
470 ASSERT_TRUE(result == nullptr);
471
472 dns.clearQueries();
473 result = gethostbyname2("hello", AF_INET6);
474 ASSERT_TRUE(result == nullptr);
475}
476
Ken Chenb9fa2062018-11-13 21:51:13 +0800477TEST_F(ResolverTest, GetHostByName_localhost) {
Ken Chenb9fa2062018-11-13 21:51:13 +0800478 constexpr char name_camelcase[] = "LocalHost";
Ken Chenb9fa2062018-11-13 21:51:13 +0800479 constexpr char name_ip6_dot[] = "ip6-localhost.";
480 constexpr char name_ip6_fqdn[] = "ip6-localhost.example.com.";
481
markchien96b09e22020-07-29 14:24:34 +0800482 // Add a no-op nameserver which shouldn't receive any queries
Xiao Ma09b71022018-12-11 17:56:32 +0900483 test::DNSResponder dns;
484 StartDns(dns, {});
485 ASSERT_TRUE(mDnsClient.SetResolversForNetwork());
Ken Chenb9fa2062018-11-13 21:51:13 +0800486
487 // Expect no DNS queries; localhost is resolved via /etc/hosts
Xiao Ma09b71022018-12-11 17:56:32 +0900488 const hostent* result = gethostbyname(kLocalHost);
Ken Chenb9fa2062018-11-13 21:51:13 +0800489 EXPECT_TRUE(dns.queries().empty()) << dns.dumpQueries();
490 ASSERT_FALSE(result == nullptr);
491 ASSERT_EQ(4, result->h_length);
492 ASSERT_FALSE(result->h_addr_list[0] == nullptr);
Xiao Ma09b71022018-12-11 17:56:32 +0900493 EXPECT_EQ(kLocalHostAddr, ToString(result));
Ken Chenb9fa2062018-11-13 21:51:13 +0800494 EXPECT_TRUE(result->h_addr_list[1] == nullptr);
495
496 // Ensure the hosts file resolver ignores case of hostnames
497 result = gethostbyname(name_camelcase);
498 EXPECT_TRUE(dns.queries().empty()) << dns.dumpQueries();
499 ASSERT_FALSE(result == nullptr);
500 ASSERT_EQ(4, result->h_length);
501 ASSERT_FALSE(result->h_addr_list[0] == nullptr);
Xiao Ma09b71022018-12-11 17:56:32 +0900502 EXPECT_EQ(kLocalHostAddr, ToString(result));
Ken Chenb9fa2062018-11-13 21:51:13 +0800503 EXPECT_TRUE(result->h_addr_list[1] == nullptr);
504
505 // The hosts file also contains ip6-localhost, but gethostbyname() won't
chenbruce018fdb22019-06-12 18:08:04 +0800506 // return it. This would be easy to
Ken Chenb9fa2062018-11-13 21:51:13 +0800507 // change, but there's no point in changing the legacy behavior; new code
508 // should be calling getaddrinfo() anyway.
509 // So we check the legacy behavior, which results in amusing A-record
510 // lookups for ip6-localhost, with and without search domains appended.
511 dns.clearQueries();
Xiao Ma09b71022018-12-11 17:56:32 +0900512 result = gethostbyname(kIp6LocalHost);
Sehee Parkbbca0202018-11-16 10:53:16 +0900513 EXPECT_EQ(2U, dns.queries().size()) << dns.dumpQueries();
514 EXPECT_EQ(1U, GetNumQueriesForType(dns, ns_type::ns_t_a, name_ip6_dot)) << dns.dumpQueries();
515 EXPECT_EQ(1U, GetNumQueriesForType(dns, ns_type::ns_t_a, name_ip6_fqdn)) << dns.dumpQueries();
Ken Chenb9fa2062018-11-13 21:51:13 +0800516 ASSERT_TRUE(result == nullptr);
517
518 // Finally, use gethostbyname2() to resolve ip6-localhost to ::1 from
519 // the hosts file.
520 dns.clearQueries();
Xiao Ma09b71022018-12-11 17:56:32 +0900521 result = gethostbyname2(kIp6LocalHost, AF_INET6);
Ken Chenb9fa2062018-11-13 21:51:13 +0800522 EXPECT_TRUE(dns.queries().empty()) << dns.dumpQueries();
523 ASSERT_FALSE(result == nullptr);
524 ASSERT_EQ(16, result->h_length);
525 ASSERT_FALSE(result->h_addr_list[0] == nullptr);
Xiao Ma09b71022018-12-11 17:56:32 +0900526 EXPECT_EQ(kIp6LocalHostAddr, ToString(result));
Ken Chenb9fa2062018-11-13 21:51:13 +0800527 EXPECT_TRUE(result->h_addr_list[1] == nullptr);
Ken Chenb9fa2062018-11-13 21:51:13 +0800528}
529
530TEST_F(ResolverTest, GetHostByName_numeric) {
markchien96b09e22020-07-29 14:24:34 +0800531 // Add a no-op nameserver which shouldn't receive any queries
Xiao Ma09b71022018-12-11 17:56:32 +0900532 test::DNSResponder dns;
533 StartDns(dns, {});
534 ASSERT_TRUE(mDnsClient.SetResolversForNetwork());
Ken Chenb9fa2062018-11-13 21:51:13 +0800535
536 // Numeric v4 address: expect no DNS queries
537 constexpr char numeric_v4[] = "192.168.0.1";
Ken Chenb9fa2062018-11-13 21:51:13 +0800538 const hostent* result = gethostbyname(numeric_v4);
Sehee Parkbbca0202018-11-16 10:53:16 +0900539 EXPECT_EQ(0U, dns.queries().size());
Ken Chenb9fa2062018-11-13 21:51:13 +0800540 ASSERT_FALSE(result == nullptr);
541 ASSERT_EQ(4, result->h_length); // v4
542 ASSERT_FALSE(result->h_addr_list[0] == nullptr);
543 EXPECT_EQ(numeric_v4, ToString(result));
544 EXPECT_TRUE(result->h_addr_list[1] == nullptr);
545
546 // gethostbyname() recognizes a v6 address, and fails with no DNS queries
547 constexpr char numeric_v6[] = "2001:db8::42";
548 dns.clearQueries();
549 result = gethostbyname(numeric_v6);
Sehee Parkbbca0202018-11-16 10:53:16 +0900550 EXPECT_EQ(0U, dns.queries().size());
Ken Chenb9fa2062018-11-13 21:51:13 +0800551 EXPECT_TRUE(result == nullptr);
552
553 // Numeric v6 address with gethostbyname2(): succeeds with no DNS queries
554 dns.clearQueries();
555 result = gethostbyname2(numeric_v6, AF_INET6);
Sehee Parkbbca0202018-11-16 10:53:16 +0900556 EXPECT_EQ(0U, dns.queries().size());
Ken Chenb9fa2062018-11-13 21:51:13 +0800557 ASSERT_FALSE(result == nullptr);
558 ASSERT_EQ(16, result->h_length); // v6
559 ASSERT_FALSE(result->h_addr_list[0] == nullptr);
560 EXPECT_EQ(numeric_v6, ToString(result));
561 EXPECT_TRUE(result->h_addr_list[1] == nullptr);
562
563 // Numeric v6 address with scope work with getaddrinfo(),
564 // but gethostbyname2() does not understand them; it issues two dns
565 // queries, then fails. This hardly ever happens, there's no point
566 // in fixing this. This test simply verifies the current (bogus)
567 // behavior to avoid further regressions (like crashes, or leaks).
568 constexpr char numeric_v6_scope[] = "fe80::1%lo";
569 dns.clearQueries();
570 result = gethostbyname2(numeric_v6_scope, AF_INET6);
Sehee Parkbbca0202018-11-16 10:53:16 +0900571 EXPECT_EQ(2U, dns.queries().size()); // OUCH!
Ken Chenb9fa2062018-11-13 21:51:13 +0800572 ASSERT_TRUE(result == nullptr);
Ken Chenb9fa2062018-11-13 21:51:13 +0800573}
574
575TEST_F(ResolverTest, BinderSerialization) {
Ken Chenb9fa2062018-11-13 21:51:13 +0800576 std::vector<int> params_offsets = {
Luke Huang5bd827c2019-03-14 16:10:04 +0800577 IDnsResolver::RESOLVER_PARAMS_SAMPLE_VALIDITY,
578 IDnsResolver::RESOLVER_PARAMS_SUCCESS_THRESHOLD,
579 IDnsResolver::RESOLVER_PARAMS_MIN_SAMPLES,
580 IDnsResolver::RESOLVER_PARAMS_MAX_SAMPLES,
581 IDnsResolver::RESOLVER_PARAMS_BASE_TIMEOUT_MSEC,
582 IDnsResolver::RESOLVER_PARAMS_RETRY_COUNT,
Ken Chenb9fa2062018-11-13 21:51:13 +0800583 };
Bernie Innocentib102dd22018-12-04 14:57:48 +0900584 const int size = static_cast<int>(params_offsets.size());
Luke Huang5bd827c2019-03-14 16:10:04 +0800585 EXPECT_EQ(size, IDnsResolver::RESOLVER_PARAMS_COUNT);
Ken Chenb9fa2062018-11-13 21:51:13 +0800586 std::sort(params_offsets.begin(), params_offsets.end());
Bernie Innocentib102dd22018-12-04 14:57:48 +0900587 for (int i = 0; i < size; ++i) {
Ken Chenb9fa2062018-11-13 21:51:13 +0800588 EXPECT_EQ(params_offsets[i], i);
589 }
590}
591
592TEST_F(ResolverTest, GetHostByName_Binder) {
Luke Huangf8215372019-11-22 11:53:41 +0800593 std::vector<std::string> domains = {"example.com"};
Ken Chenb9fa2062018-11-13 21:51:13 +0800594 std::vector<std::unique_ptr<test::DNSResponder>> dns;
595 std::vector<std::string> servers;
Bernie Innocentia5c7b7b2019-01-17 21:28:24 +0900596 std::vector<DnsResponderClient::Mapping> mappings;
597 ASSERT_NO_FATAL_FAILURE(mDnsClient.SetupMappings(1, domains, &mappings));
598 ASSERT_NO_FATAL_FAILURE(mDnsClient.SetupDNSServers(4, mappings, &dns, &servers));
Ken Chenb9fa2062018-11-13 21:51:13 +0800599 ASSERT_EQ(1U, mappings.size());
Bernie Innocentia5c7b7b2019-01-17 21:28:24 +0900600 const DnsResponderClient::Mapping& mapping = mappings[0];
Ken Chenb9fa2062018-11-13 21:51:13 +0800601
Xiao Ma09b71022018-12-11 17:56:32 +0900602 ASSERT_TRUE(mDnsClient.SetResolversForNetwork(servers, domains, kDefaultParams));
Ken Chenb9fa2062018-11-13 21:51:13 +0800603
604 const hostent* result = gethostbyname(mapping.host.c_str());
Bernie Innocentib102dd22018-12-04 14:57:48 +0900605 const size_t total_queries =
Luke Huangfde82482019-06-04 01:04:53 +0800606 std::accumulate(dns.begin(), dns.end(), 0, [&mapping](size_t total, auto& d) {
Ken Chenb9fa2062018-11-13 21:51:13 +0800607 return total + GetNumQueriesForType(*d, ns_type::ns_t_a, mapping.entry.c_str());
608 });
609
610 EXPECT_LE(1U, total_queries);
611 ASSERT_FALSE(result == nullptr);
612 ASSERT_EQ(4, result->h_length);
613 ASSERT_FALSE(result->h_addr_list[0] == nullptr);
614 EXPECT_EQ(mapping.ip4, ToString(result));
615 EXPECT_TRUE(result->h_addr_list[1] == nullptr);
616
617 std::vector<std::string> res_servers;
618 std::vector<std::string> res_domains;
Mike Yu0a1c53d2018-11-26 13:26:21 +0900619 std::vector<std::string> res_tls_servers;
Bernie Innocenti758005f2019-02-19 18:08:36 +0900620 res_params res_params;
Ken Chenb9fa2062018-11-13 21:51:13 +0800621 std::vector<ResolverStats> res_stats;
Ken Chen92bed612018-12-22 21:46:55 +0800622 int wait_for_pending_req_timeout_count;
Luke Huangf8215372019-11-22 11:53:41 +0800623 ASSERT_TRUE(DnsResponderClient::GetResolverInfo(
624 mDnsClient.resolvService(), TEST_NETID, &res_servers, &res_domains, &res_tls_servers,
625 &res_params, &res_stats, &wait_for_pending_req_timeout_count));
Ken Chenb9fa2062018-11-13 21:51:13 +0800626 EXPECT_EQ(servers.size(), res_servers.size());
627 EXPECT_EQ(domains.size(), res_domains.size());
Mike Yu0a1c53d2018-11-26 13:26:21 +0900628 EXPECT_EQ(0U, res_tls_servers.size());
Luke Huang5bd827c2019-03-14 16:10:04 +0800629 ASSERT_EQ(static_cast<size_t>(IDnsResolver::RESOLVER_PARAMS_COUNT), kDefaultParams.size());
630 EXPECT_EQ(kDefaultParams[IDnsResolver::RESOLVER_PARAMS_SAMPLE_VALIDITY],
631 res_params.sample_validity);
632 EXPECT_EQ(kDefaultParams[IDnsResolver::RESOLVER_PARAMS_SUCCESS_THRESHOLD],
Bernie Innocentia5c7b7b2019-01-17 21:28:24 +0900633 res_params.success_threshold);
Luke Huang5bd827c2019-03-14 16:10:04 +0800634 EXPECT_EQ(kDefaultParams[IDnsResolver::RESOLVER_PARAMS_MIN_SAMPLES], res_params.min_samples);
635 EXPECT_EQ(kDefaultParams[IDnsResolver::RESOLVER_PARAMS_MAX_SAMPLES], res_params.max_samples);
636 EXPECT_EQ(kDefaultParams[IDnsResolver::RESOLVER_PARAMS_BASE_TIMEOUT_MSEC],
Ken Chenb9fa2062018-11-13 21:51:13 +0800637 res_params.base_timeout_msec);
638 EXPECT_EQ(servers.size(), res_stats.size());
639
Bernie Innocenti0c067e42019-04-01 15:33:16 +0900640 EXPECT_THAT(res_servers, testing::UnorderedElementsAreArray(servers));
641 EXPECT_THAT(res_domains, testing::UnorderedElementsAreArray(domains));
Ken Chenb9fa2062018-11-13 21:51:13 +0800642}
643
644TEST_F(ResolverTest, GetAddrInfo) {
Xiao Ma09b71022018-12-11 17:56:32 +0900645 constexpr char listen_addr[] = "127.0.0.4";
646 constexpr char listen_addr2[] = "127.0.0.5";
647 constexpr char host_name[] = "howdy.example.com.";
Ken Chenb9fa2062018-11-13 21:51:13 +0800648
Xiao Ma09b71022018-12-11 17:56:32 +0900649 const std::vector<DnsRecord> records = {
650 {host_name, ns_type::ns_t_a, "1.2.3.4"},
651 {host_name, ns_type::ns_t_aaaa, "::1.2.3.4"},
652 };
653 test::DNSResponder dns(listen_addr);
654 test::DNSResponder dns2(listen_addr2);
655 StartDns(dns, records);
656 StartDns(dns2, records);
Ken Chenb9fa2062018-11-13 21:51:13 +0800657
Xiao Ma09b71022018-12-11 17:56:32 +0900658 ASSERT_TRUE(mDnsClient.SetResolversForNetwork({listen_addr}));
Ken Chenb9fa2062018-11-13 21:51:13 +0800659 dns.clearQueries();
660 dns2.clearQueries();
661
662 ScopedAddrinfo result = safe_getaddrinfo("howdy", nullptr, nullptr);
663 EXPECT_TRUE(result != nullptr);
664 size_t found = GetNumQueries(dns, host_name);
665 EXPECT_LE(1U, found);
666 // Could be A or AAAA
667 std::string result_str = ToString(result);
668 EXPECT_TRUE(result_str == "1.2.3.4" || result_str == "::1.2.3.4")
Luke Huangf8215372019-11-22 11:53:41 +0800669 << ", result_str='" << result_str << "'";
Ken Chenb9fa2062018-11-13 21:51:13 +0800670
671 // Verify that the name is cached.
672 size_t old_found = found;
673 result = safe_getaddrinfo("howdy", nullptr, nullptr);
674 EXPECT_TRUE(result != nullptr);
675 found = GetNumQueries(dns, host_name);
676 EXPECT_LE(1U, found);
677 EXPECT_EQ(old_found, found);
678 result_str = ToString(result);
Luke Huangf8215372019-11-22 11:53:41 +0800679 EXPECT_TRUE(result_str == "1.2.3.4" || result_str == "::1.2.3.4") << result_str;
Ken Chenb9fa2062018-11-13 21:51:13 +0800680
681 // Change the DNS resolver, ensure that queries are still cached.
Xiao Ma09b71022018-12-11 17:56:32 +0900682 ASSERT_TRUE(mDnsClient.SetResolversForNetwork({listen_addr2}));
Ken Chenb9fa2062018-11-13 21:51:13 +0800683 dns.clearQueries();
684 dns2.clearQueries();
685
686 result = safe_getaddrinfo("howdy", nullptr, nullptr);
687 EXPECT_TRUE(result != nullptr);
688 found = GetNumQueries(dns, host_name);
689 size_t found2 = GetNumQueries(dns2, host_name);
690 EXPECT_EQ(0U, found);
691 EXPECT_LE(0U, found2);
692
693 // Could be A or AAAA
694 result_str = ToString(result);
695 EXPECT_TRUE(result_str == "1.2.3.4" || result_str == "::1.2.3.4")
Luke Huangf8215372019-11-22 11:53:41 +0800696 << ", result_str='" << result_str << "'";
Ken Chenb9fa2062018-11-13 21:51:13 +0800697}
698
699TEST_F(ResolverTest, GetAddrInfoV4) {
Xiao Ma09b71022018-12-11 17:56:32 +0900700 test::DNSResponder dns;
701 StartDns(dns, {{kHelloExampleCom, ns_type::ns_t_a, "1.2.3.5"}});
702 ASSERT_TRUE(mDnsClient.SetResolversForNetwork());
Ken Chenb9fa2062018-11-13 21:51:13 +0800703
Xiao Ma09b71022018-12-11 17:56:32 +0900704 const addrinfo hints = {.ai_family = AF_INET};
705 ScopedAddrinfo result = safe_getaddrinfo("hello", nullptr, &hints);
Ken Chenb9fa2062018-11-13 21:51:13 +0800706 EXPECT_TRUE(result != nullptr);
Xiao Ma09b71022018-12-11 17:56:32 +0900707 EXPECT_EQ(1U, GetNumQueries(dns, kHelloExampleCom));
Ken Chenb9fa2062018-11-13 21:51:13 +0800708 EXPECT_EQ("1.2.3.5", ToString(result));
709}
710
711TEST_F(ResolverTest, GetAddrInfo_localhost) {
markchien96b09e22020-07-29 14:24:34 +0800712 // Add a no-op nameserver which shouldn't receive any queries
Xiao Ma09b71022018-12-11 17:56:32 +0900713 test::DNSResponder dns;
714 StartDns(dns, {});
715 ASSERT_TRUE(mDnsClient.SetResolversForNetwork());
Ken Chenb9fa2062018-11-13 21:51:13 +0800716
Xiao Ma09b71022018-12-11 17:56:32 +0900717 ScopedAddrinfo result = safe_getaddrinfo(kLocalHost, nullptr, nullptr);
Ken Chenb9fa2062018-11-13 21:51:13 +0800718 EXPECT_TRUE(result != nullptr);
719 // Expect no DNS queries; localhost is resolved via /etc/hosts
720 EXPECT_TRUE(dns.queries().empty()) << dns.dumpQueries();
Xiao Ma09b71022018-12-11 17:56:32 +0900721 EXPECT_EQ(kLocalHostAddr, ToString(result));
Ken Chenb9fa2062018-11-13 21:51:13 +0800722
Xiao Ma09b71022018-12-11 17:56:32 +0900723 result = safe_getaddrinfo(kIp6LocalHost, nullptr, nullptr);
Ken Chenb9fa2062018-11-13 21:51:13 +0800724 EXPECT_TRUE(result != nullptr);
725 // Expect no DNS queries; ip6-localhost is resolved via /etc/hosts
726 EXPECT_TRUE(dns.queries().empty()) << dns.dumpQueries();
Xiao Ma09b71022018-12-11 17:56:32 +0900727 EXPECT_EQ(kIp6LocalHostAddr, ToString(result));
Ken Chenb9fa2062018-11-13 21:51:13 +0800728}
729
Luke Huangd8ac4752019-06-18 17:05:47 +0800730TEST_F(ResolverTest, GetAddrInfo_InvalidSocketType) {
731 test::DNSResponder dns;
732 StartDns(dns, {{kHelloExampleCom, ns_type::ns_t_a, "1.2.3.5"}});
733 ASSERT_TRUE(mDnsClient.SetResolversForNetwork());
734
735 // TODO: Test other invalid socket types.
736 const addrinfo hints = {
737 .ai_family = AF_UNSPEC,
Luke Huangd8ac4752019-06-18 17:05:47 +0800738 .ai_socktype = SOCK_PACKET,
739 };
740 addrinfo* result = nullptr;
741 // This is a valid hint, but the query won't be sent because the socket type is
742 // not supported.
743 EXPECT_EQ(EAI_NODATA, getaddrinfo("hello", nullptr, &hints, &result));
744 ScopedAddrinfo result_cleanup(result);
745 EXPECT_EQ(nullptr, result);
746}
747
Ken Chen92bed612018-12-22 21:46:55 +0800748// Verify if the resolver correctly handle multiple queries simultaneously
749// step 1: set dns server#1 into deferred responding mode.
750// step 2: thread#1 query "hello.example.com." --> resolver send query to server#1.
751// step 3: thread#2 query "hello.example.com." --> resolver hold the request and wait for
752// response of previous pending query sent by thread#1.
753// step 4: thread#3 query "konbanha.example.com." --> resolver send query to server#3. Server
754// respond to resolver immediately.
755// step 5: check if server#1 get 1 query by thread#1, server#2 get 0 query, server#3 get 1 query.
756// step 6: resume dns server#1 to respond dns query in step#2.
757// step 7: thread#1 and #2 should get returned from DNS query after step#6. Also, check the
758// number of queries in server#2 is 0 to ensure thread#2 does not wake up unexpectedly
759// before signaled by thread#1.
760TEST_F(ResolverTest, GetAddrInfoV4_deferred_resp) {
761 const char* listen_addr1 = "127.0.0.9";
762 const char* listen_addr2 = "127.0.0.10";
763 const char* listen_addr3 = "127.0.0.11";
764 const char* listen_srv = "53";
765 const char* host_name_deferred = "hello.example.com.";
766 const char* host_name_normal = "konbanha.example.com.";
Mike Yufc125e42019-05-15 20:41:28 +0800767 test::DNSResponder dns1(listen_addr1, listen_srv, ns_rcode::ns_r_servfail);
768 test::DNSResponder dns2(listen_addr2, listen_srv, ns_rcode::ns_r_servfail);
769 test::DNSResponder dns3(listen_addr3, listen_srv, ns_rcode::ns_r_servfail);
Ken Chen92bed612018-12-22 21:46:55 +0800770 dns1.addMapping(host_name_deferred, ns_type::ns_t_a, "1.2.3.4");
771 dns2.addMapping(host_name_deferred, ns_type::ns_t_a, "1.2.3.4");
772 dns3.addMapping(host_name_normal, ns_type::ns_t_a, "1.2.3.5");
773 ASSERT_TRUE(dns1.startServer());
774 ASSERT_TRUE(dns2.startServer());
775 ASSERT_TRUE(dns3.startServer());
776 const std::vector<std::string> servers_for_t1 = {listen_addr1};
777 const std::vector<std::string> servers_for_t2 = {listen_addr2};
778 const std::vector<std::string> servers_for_t3 = {listen_addr3};
779 addrinfo hints = {.ai_family = AF_INET};
780 const std::vector<int> params = {300, 25, 8, 8, 5000};
781 bool t3_task_done = false;
782
783 dns1.setDeferredResp(true);
784 std::thread t1([&, this]() {
785 ASSERT_TRUE(
786 mDnsClient.SetResolversForNetwork(servers_for_t1, kDefaultSearchDomains, params));
787 ScopedAddrinfo result = safe_getaddrinfo(host_name_deferred, nullptr, &hints);
788 // t3's dns query should got returned first
789 EXPECT_TRUE(t3_task_done);
790 EXPECT_EQ(1U, GetNumQueries(dns1, host_name_deferred));
791 EXPECT_TRUE(result != nullptr);
792 EXPECT_EQ("1.2.3.4", ToString(result));
793 });
794
795 // ensuring t1 and t2 handler functions are processed in order
796 usleep(100 * 1000);
797 std::thread t2([&, this]() {
798 ASSERT_TRUE(
799 mDnsClient.SetResolversForNetwork(servers_for_t2, kDefaultSearchDomains, params));
800 ScopedAddrinfo result = safe_getaddrinfo(host_name_deferred, nullptr, &hints);
801 EXPECT_TRUE(t3_task_done);
802 EXPECT_EQ(0U, GetNumQueries(dns2, host_name_deferred));
803 EXPECT_TRUE(result != nullptr);
804 EXPECT_EQ("1.2.3.4", ToString(result));
805
806 std::vector<std::string> res_servers;
807 std::vector<std::string> res_domains;
808 std::vector<std::string> res_tls_servers;
Bernie Innocenti758005f2019-02-19 18:08:36 +0900809 res_params res_params;
Ken Chen92bed612018-12-22 21:46:55 +0800810 std::vector<ResolverStats> res_stats;
811 int wait_for_pending_req_timeout_count;
Luke Huangf8215372019-11-22 11:53:41 +0800812 ASSERT_TRUE(DnsResponderClient::GetResolverInfo(
813 mDnsClient.resolvService(), TEST_NETID, &res_servers, &res_domains,
814 &res_tls_servers, &res_params, &res_stats, &wait_for_pending_req_timeout_count));
Ken Chen92bed612018-12-22 21:46:55 +0800815 EXPECT_EQ(0, wait_for_pending_req_timeout_count);
816 });
817
818 // ensuring t2 and t3 handler functions are processed in order
819 usleep(100 * 1000);
820 std::thread t3([&, this]() {
821 ASSERT_TRUE(
822 mDnsClient.SetResolversForNetwork(servers_for_t3, kDefaultSearchDomains, params));
823 ScopedAddrinfo result = safe_getaddrinfo(host_name_normal, nullptr, &hints);
824 EXPECT_EQ(1U, GetNumQueries(dns1, host_name_deferred));
825 EXPECT_EQ(0U, GetNumQueries(dns2, host_name_deferred));
826 EXPECT_EQ(1U, GetNumQueries(dns3, host_name_normal));
827 EXPECT_TRUE(result != nullptr);
828 EXPECT_EQ("1.2.3.5", ToString(result));
829
830 t3_task_done = true;
831 dns1.setDeferredResp(false);
832 });
833 t3.join();
834 t1.join();
835 t2.join();
836}
837
lifr4e4a2e02019-01-29 16:53:51 +0800838TEST_F(ResolverTest, GetAddrInfo_cnames) {
839 constexpr char host_name[] = "host.example.com.";
840 test::DNSResponder dns;
841 const std::vector<DnsRecord> records = {
842 {kHelloExampleCom, ns_type::ns_t_cname, "a.example.com."},
843 {"a.example.com.", ns_type::ns_t_cname, "b.example.com."},
844 {"b.example.com.", ns_type::ns_t_cname, "c.example.com."},
845 {"c.example.com.", ns_type::ns_t_cname, "d.example.com."},
846 {"d.example.com.", ns_type::ns_t_cname, "e.example.com."},
847 {"e.example.com.", ns_type::ns_t_cname, host_name},
848 {host_name, ns_type::ns_t_a, "1.2.3.3"},
849 {host_name, ns_type::ns_t_aaaa, "2001:db8::42"},
850 };
851 StartDns(dns, records);
852 ASSERT_TRUE(mDnsClient.SetResolversForNetwork());
853
854 addrinfo hints = {.ai_family = AF_INET};
855 ScopedAddrinfo result = safe_getaddrinfo("hello", nullptr, &hints);
856 EXPECT_TRUE(result != nullptr);
857 EXPECT_EQ("1.2.3.3", ToString(result));
858
859 dns.clearQueries();
860 hints = {.ai_family = AF_INET6};
861 result = safe_getaddrinfo("hello", nullptr, &hints);
862 EXPECT_TRUE(result != nullptr);
863 EXPECT_EQ("2001:db8::42", ToString(result));
864}
865
866TEST_F(ResolverTest, GetAddrInfo_cnamesNoIpAddress) {
867 test::DNSResponder dns;
868 const std::vector<DnsRecord> records = {
869 {kHelloExampleCom, ns_type::ns_t_cname, "a.example.com."},
870 };
871 StartDns(dns, records);
872 ASSERT_TRUE(mDnsClient.SetResolversForNetwork());
873
874 addrinfo hints = {.ai_family = AF_INET};
875 ScopedAddrinfo result = safe_getaddrinfo("hello", nullptr, &hints);
876 EXPECT_TRUE(result == nullptr);
877
878 dns.clearQueries();
879 hints = {.ai_family = AF_INET6};
880 result = safe_getaddrinfo("hello", nullptr, &hints);
881 EXPECT_TRUE(result == nullptr);
882}
883
884TEST_F(ResolverTest, GetAddrInfo_cnamesIllegalRdata) {
885 test::DNSResponder dns;
886 const std::vector<DnsRecord> records = {
887 {kHelloExampleCom, ns_type::ns_t_cname, ".!#?"},
888 };
889 StartDns(dns, records);
890 ASSERT_TRUE(mDnsClient.SetResolversForNetwork());
891
892 addrinfo hints = {.ai_family = AF_INET};
893 ScopedAddrinfo result = safe_getaddrinfo("hello", nullptr, &hints);
894 EXPECT_TRUE(result == nullptr);
895
896 dns.clearQueries();
897 hints = {.ai_family = AF_INET6};
898 result = safe_getaddrinfo("hello", nullptr, &hints);
899 EXPECT_TRUE(result == nullptr);
900}
901
Pabba Prakash66707822020-01-08 15:34:58 +0530902TEST_F(ResolverTest, GetAddrInfoForCaseInSensitiveDomains) {
903 test::DNSResponder dns;
904 const char* host_name = "howdy.example.com.";
905 const char* host_name2 = "HOWDY.example.com.";
906 const std::vector<DnsRecord> records = {
907 {host_name, ns_type::ns_t_a, "1.2.3.4"},
908 {host_name, ns_type::ns_t_aaaa, "::1.2.3.4"},
909 {host_name2, ns_type::ns_t_a, "1.2.3.5"},
910 {host_name2, ns_type::ns_t_aaaa, "::1.2.3.5"},
911 };
912 StartDns(dns, records);
913 ASSERT_TRUE(mDnsClient.SetResolversForNetwork());
914
915 ScopedAddrinfo hostname_result = safe_getaddrinfo("howdy", nullptr, nullptr);
916 EXPECT_TRUE(hostname_result != nullptr);
917 const size_t hostname1_count_after_first_query = GetNumQueries(dns, host_name);
918 EXPECT_LE(1U, hostname1_count_after_first_query);
919 // Could be A or AAAA
920 std::string hostname_result_str = ToString(hostname_result);
921 EXPECT_TRUE(hostname_result_str == "1.2.3.4" || hostname_result_str == "::1.2.3.4");
922
923 // Verify that the name is cached.
924 ScopedAddrinfo hostname2_result = safe_getaddrinfo("HOWDY", nullptr, nullptr);
925 EXPECT_TRUE(hostname2_result != nullptr);
926 const size_t hostname1_count_after_second_query = GetNumQueries(dns, host_name);
927 EXPECT_LE(1U, hostname1_count_after_second_query);
928
929 // verify that there is no change in num of queries for howdy.example.com
930 EXPECT_EQ(hostname1_count_after_first_query, hostname1_count_after_second_query);
931
932 // Number of queries for HOWDY.example.com would be >= 1 if domain names
933 // are considered case-sensitive, else number of queries should be 0.
934 const size_t hostname2_count = GetNumQueries(dns, host_name2);
935 EXPECT_EQ(0U,hostname2_count);
936 std::string hostname2_result_str = ToString(hostname2_result);
937 EXPECT_TRUE(hostname2_result_str == "1.2.3.4" || hostname2_result_str == "::1.2.3.4");
938
939 // verify that the result is still the same address even though
940 // mixed-case string is not in the DNS
941 ScopedAddrinfo result = safe_getaddrinfo("HowDY", nullptr, nullptr);
942 EXPECT_TRUE(result != nullptr);
943 std::string result_str = ToString(result);
944 EXPECT_TRUE(result_str == "1.2.3.4" || result_str == "::1.2.3.4");
945}
946
Ken Chenb9fa2062018-11-13 21:51:13 +0800947TEST_F(ResolverTest, MultidomainResolution) {
Xiao Ma09b71022018-12-11 17:56:32 +0900948 constexpr char host_name[] = "nihao.example2.com.";
Luke Huangf8215372019-11-22 11:53:41 +0800949 std::vector<std::string> searchDomains = {"example1.com", "example2.com", "example3.com"};
Ken Chenb9fa2062018-11-13 21:51:13 +0800950
Xiao Ma09b71022018-12-11 17:56:32 +0900951 test::DNSResponder dns("127.0.0.6");
952 StartDns(dns, {{host_name, ns_type::ns_t_a, "1.2.3.3"}});
953 ASSERT_TRUE(mDnsClient.SetResolversForNetwork({"127.0.0.6"}, searchDomains));
954
Ken Chenb9fa2062018-11-13 21:51:13 +0800955 const hostent* result = gethostbyname("nihao");
Xiao Ma09b71022018-12-11 17:56:32 +0900956
Ken Chenb9fa2062018-11-13 21:51:13 +0800957 EXPECT_EQ(1U, GetNumQueriesForType(dns, ns_type::ns_t_a, host_name));
958 ASSERT_FALSE(result == nullptr);
959 ASSERT_EQ(4, result->h_length);
960 ASSERT_FALSE(result->h_addr_list[0] == nullptr);
961 EXPECT_EQ("1.2.3.3", ToString(result));
962 EXPECT_TRUE(result->h_addr_list[1] == nullptr);
Ken Chenb9fa2062018-11-13 21:51:13 +0800963}
964
965TEST_F(ResolverTest, GetAddrInfoV6_numeric) {
Ken Chenb9fa2062018-11-13 21:51:13 +0800966 constexpr char host_name[] = "ohayou.example.com.";
967 constexpr char numeric_addr[] = "fe80::1%lo";
968
Xiao Ma09b71022018-12-11 17:56:32 +0900969 test::DNSResponder dns;
Ken Chenb9fa2062018-11-13 21:51:13 +0800970 dns.setResponseProbability(0.0);
Xiao Ma09b71022018-12-11 17:56:32 +0900971 StartDns(dns, {{host_name, ns_type::ns_t_aaaa, "2001:db8::5"}});
972 ASSERT_TRUE(mDnsClient.SetResolversForNetwork());
Ken Chenb9fa2062018-11-13 21:51:13 +0800973
974 addrinfo hints = {.ai_family = AF_INET6};
975 ScopedAddrinfo result = safe_getaddrinfo(numeric_addr, nullptr, &hints);
976 EXPECT_TRUE(result != nullptr);
977 EXPECT_EQ(numeric_addr, ToString(result));
978 EXPECT_TRUE(dns.queries().empty()); // Ensure no DNS queries were sent out
979
980 // Now try a non-numeric hostname query with the AI_NUMERICHOST flag set.
981 // We should fail without sending out a DNS query.
982 hints.ai_flags |= AI_NUMERICHOST;
983 result = safe_getaddrinfo(host_name, nullptr, &hints);
984 EXPECT_TRUE(result == nullptr);
985 EXPECT_TRUE(dns.queries().empty()); // Ensure no DNS queries were sent out
986}
987
988TEST_F(ResolverTest, GetAddrInfoV6_failing) {
Xiao Ma09b71022018-12-11 17:56:32 +0900989 constexpr char listen_addr0[] = "127.0.0.7";
990 constexpr char listen_addr1[] = "127.0.0.8";
Ken Chenb9fa2062018-11-13 21:51:13 +0800991 const char* host_name = "ohayou.example.com.";
Xiao Ma09b71022018-12-11 17:56:32 +0900992
993 test::DNSResponder dns0(listen_addr0);
994 test::DNSResponder dns1(listen_addr1);
Ken Chenb9fa2062018-11-13 21:51:13 +0800995 dns0.setResponseProbability(0.0);
Xiao Ma09b71022018-12-11 17:56:32 +0900996 StartDns(dns0, {{host_name, ns_type::ns_t_aaaa, "2001:db8::5"}});
997 StartDns(dns1, {{host_name, ns_type::ns_t_aaaa, "2001:db8::6"}});
998
Luke Huangf8215372019-11-22 11:53:41 +0800999 std::vector<std::string> servers = {listen_addr0, listen_addr1};
Ken Chenb9fa2062018-11-13 21:51:13 +08001000 // <sample validity in s> <success threshold in percent> <min samples> <max samples>
1001 int sample_count = 8;
Luke Huangf8215372019-11-22 11:53:41 +08001002 const std::vector<int> params = {300, 25, sample_count, sample_count};
Xiao Ma09b71022018-12-11 17:56:32 +09001003 ASSERT_TRUE(mDnsClient.SetResolversForNetwork(servers, kDefaultSearchDomains, params));
Ken Chenb9fa2062018-11-13 21:51:13 +08001004
1005 // Repeatedly perform resolutions for non-existing domains until MAXNSSAMPLES resolutions have
1006 // reached the dns0, which is set to fail. No more requests should then arrive at that server
1007 // for the next sample_lifetime seconds.
1008 // TODO: This approach is implementation-dependent, change once metrics reporting is available.
Xiao Ma09b71022018-12-11 17:56:32 +09001009 const addrinfo hints = {.ai_family = AF_INET6};
Bernie Innocentib102dd22018-12-04 14:57:48 +09001010 for (int i = 0; i < sample_count; ++i) {
Ken Chenb9fa2062018-11-13 21:51:13 +08001011 std::string domain = StringPrintf("nonexistent%d", i);
1012 ScopedAddrinfo result = safe_getaddrinfo(domain.c_str(), nullptr, &hints);
1013 }
1014 // Due to 100% errors for all possible samples, the server should be ignored from now on and
1015 // only the second one used for all following queries, until NSSAMPLE_VALIDITY is reached.
1016 dns0.clearQueries();
1017 dns1.clearQueries();
1018 ScopedAddrinfo result = safe_getaddrinfo("ohayou", nullptr, &hints);
1019 EXPECT_TRUE(result != nullptr);
1020 EXPECT_EQ(0U, GetNumQueries(dns0, host_name));
1021 EXPECT_EQ(1U, GetNumQueries(dns1, host_name));
1022}
1023
1024TEST_F(ResolverTest, GetAddrInfoV6_nonresponsive) {
Xiao Ma09b71022018-12-11 17:56:32 +09001025 constexpr char listen_addr0[] = "127.0.0.7";
1026 constexpr char listen_addr1[] = "127.0.0.8";
1027 constexpr char listen_srv[] = "53";
1028 constexpr char host_name1[] = "ohayou.example.com.";
1029 constexpr char host_name2[] = "ciao.example.com.";
Luke Huang483cf332019-06-03 17:24:51 +08001030 const std::vector<std::string> defaultSearchDomain = {"example.com"};
1031 // The minimal timeout is 1000ms, so we can't decrease timeout
1032 // So reduce retry count.
1033 const std::vector<int> reduceRetryParams = {
1034 300, // sample validity in seconds
1035 25, // success threshod in percent
1036 8, 8, // {MIN,MAX}_SAMPLES
1037 1000, // BASE_TIMEOUT_MSEC
1038 1, // retry count
1039 };
Xiao Ma09b71022018-12-11 17:56:32 +09001040 const std::vector<DnsRecord> records0 = {
1041 {host_name1, ns_type::ns_t_aaaa, "2001:db8::5"},
1042 {host_name2, ns_type::ns_t_aaaa, "2001:db8::5"},
1043 };
1044 const std::vector<DnsRecord> records1 = {
1045 {host_name1, ns_type::ns_t_aaaa, "2001:db8::6"},
1046 {host_name2, ns_type::ns_t_aaaa, "2001:db8::6"},
1047 };
Ken Chenb9fa2062018-11-13 21:51:13 +08001048
1049 // dns0 does not respond with 100% probability, while
1050 // dns1 responds normally, at least initially.
Mike Yufc125e42019-05-15 20:41:28 +08001051 test::DNSResponder dns0(listen_addr0, listen_srv, static_cast<ns_rcode>(-1));
1052 test::DNSResponder dns1(listen_addr1, listen_srv, static_cast<ns_rcode>(-1));
Ken Chenb9fa2062018-11-13 21:51:13 +08001053 dns0.setResponseProbability(0.0);
Xiao Ma09b71022018-12-11 17:56:32 +09001054 StartDns(dns0, records0);
1055 StartDns(dns1, records1);
Luke Huang483cf332019-06-03 17:24:51 +08001056 ASSERT_TRUE(mDnsClient.SetResolversForNetwork({listen_addr0, listen_addr1}, defaultSearchDomain,
1057 reduceRetryParams));
Ken Chenb9fa2062018-11-13 21:51:13 +08001058
Luke Huang483cf332019-06-03 17:24:51 +08001059 // Specify ai_socktype to make getaddrinfo will only query 1 time
1060 const addrinfo hints = {.ai_family = AF_INET6, .ai_socktype = SOCK_STREAM};
Ken Chenb9fa2062018-11-13 21:51:13 +08001061
1062 // dns0 will ignore the request, and we'll fallback to dns1 after the first
1063 // retry.
1064 ScopedAddrinfo result = safe_getaddrinfo(host_name1, nullptr, &hints);
1065 EXPECT_TRUE(result != nullptr);
1066 EXPECT_EQ(1U, GetNumQueries(dns0, host_name1));
1067 EXPECT_EQ(1U, GetNumQueries(dns1, host_name1));
Mike Yu532405f2020-06-17 17:46:44 +08001068 ExpectDnsEvent(INetdEventListener::EVENT_GETADDRINFO, 0, host_name1, {"2001:db8::6"});
Ken Chenb9fa2062018-11-13 21:51:13 +08001069
1070 // Now make dns1 also ignore 100% requests... The resolve should alternate
Luke Huang483cf332019-06-03 17:24:51 +08001071 // queries between the nameservers and fail
Ken Chenb9fa2062018-11-13 21:51:13 +08001072 dns1.setResponseProbability(0.0);
1073 addrinfo* result2 = nullptr;
1074 EXPECT_EQ(EAI_NODATA, getaddrinfo(host_name2, nullptr, &hints, &result2));
1075 EXPECT_EQ(nullptr, result2);
Luke Huang483cf332019-06-03 17:24:51 +08001076 EXPECT_EQ(1U, GetNumQueries(dns0, host_name2));
1077 EXPECT_EQ(1U, GetNumQueries(dns1, host_name2));
Mike Yu532405f2020-06-17 17:46:44 +08001078 ExpectDnsEvent(INetdEventListener::EVENT_GETADDRINFO, RCODE_TIMEOUT, host_name2, {});
Ken Chenb9fa2062018-11-13 21:51:13 +08001079}
1080
1081TEST_F(ResolverTest, GetAddrInfoV6_concurrent) {
Xiao Ma09b71022018-12-11 17:56:32 +09001082 constexpr char listen_addr0[] = "127.0.0.9";
1083 constexpr char listen_addr1[] = "127.0.0.10";
1084 constexpr char listen_addr2[] = "127.0.0.11";
1085 constexpr char host_name[] = "konbanha.example.com.";
1086
1087 test::DNSResponder dns0(listen_addr0);
1088 test::DNSResponder dns1(listen_addr1);
1089 test::DNSResponder dns2(listen_addr2);
1090 StartDns(dns0, {{host_name, ns_type::ns_t_aaaa, "2001:db8::5"}});
1091 StartDns(dns1, {{host_name, ns_type::ns_t_aaaa, "2001:db8::6"}});
1092 StartDns(dns2, {{host_name, ns_type::ns_t_aaaa, "2001:db8::7"}});
1093
Luke Huangf8215372019-11-22 11:53:41 +08001094 const std::vector<std::string> servers = {listen_addr0, listen_addr1, listen_addr2};
Ken Chenb9fa2062018-11-13 21:51:13 +08001095 std::vector<std::thread> threads(10);
1096 for (std::thread& thread : threads) {
Luke Huangf8215372019-11-22 11:53:41 +08001097 thread = std::thread([this, &servers]() {
1098 unsigned delay = arc4random_uniform(1 * 1000 * 1000); // <= 1s
Ken Chenb9fa2062018-11-13 21:51:13 +08001099 usleep(delay);
1100 std::vector<std::string> serverSubset;
1101 for (const auto& server : servers) {
1102 if (arc4random_uniform(2)) {
1103 serverSubset.push_back(server);
1104 }
1105 }
1106 if (serverSubset.empty()) serverSubset = servers;
Xiao Ma09b71022018-12-11 17:56:32 +09001107 ASSERT_TRUE(mDnsClient.SetResolversForNetwork(serverSubset));
1108 const addrinfo hints = {.ai_family = AF_INET6};
Ken Chenb9fa2062018-11-13 21:51:13 +08001109 addrinfo* result = nullptr;
1110 int rv = getaddrinfo("konbanha", nullptr, &hints, &result);
1111 EXPECT_EQ(0, rv) << "error [" << rv << "] " << gai_strerror(rv);
1112 if (result) {
1113 freeaddrinfo(result);
1114 result = nullptr;
1115 }
1116 });
1117 }
1118 for (std::thread& thread : threads) {
1119 thread.join();
1120 }
Ken Chen92bed612018-12-22 21:46:55 +08001121
1122 std::vector<std::string> res_servers;
1123 std::vector<std::string> res_domains;
1124 std::vector<std::string> res_tls_servers;
Bernie Innocenti758005f2019-02-19 18:08:36 +09001125 res_params res_params;
Ken Chen92bed612018-12-22 21:46:55 +08001126 std::vector<ResolverStats> res_stats;
1127 int wait_for_pending_req_timeout_count;
Luke Huangf8215372019-11-22 11:53:41 +08001128 ASSERT_TRUE(DnsResponderClient::GetResolverInfo(
1129 mDnsClient.resolvService(), TEST_NETID, &res_servers, &res_domains, &res_tls_servers,
1130 &res_params, &res_stats, &wait_for_pending_req_timeout_count));
Ken Chen92bed612018-12-22 21:46:55 +08001131 EXPECT_EQ(0, wait_for_pending_req_timeout_count);
Ken Chenb9fa2062018-11-13 21:51:13 +08001132}
1133
Mike Yu8ac63402019-12-02 15:28:38 +08001134TEST_F(ResolverTest, SkipBadServersDueToInternalError) {
1135 constexpr char listen_addr1[] = "fe80::1";
1136 constexpr char listen_addr2[] = "255.255.255.255";
1137 constexpr char listen_addr3[] = "127.0.0.3";
Mike Yu61d17262020-02-15 18:56:22 +08001138 int counter = 0; // To generate unique hostnames.
Mike Yu8ac63402019-12-02 15:28:38 +08001139 test::DNSResponder dns(listen_addr3);
1140 ASSERT_TRUE(dns.startServer());
1141
Mike Yu61d17262020-02-15 18:56:22 +08001142 ResolverParamsParcel setupParams = DnsResponderClient::GetDefaultResolverParamsParcel();
1143 setupParams.servers = {listen_addr1, listen_addr2, listen_addr3};
1144 setupParams.minSamples = 2; // Recognize bad servers in two attempts when sorting not enabled.
Mike Yu8ac63402019-12-02 15:28:38 +08001145
Mike Yu61d17262020-02-15 18:56:22 +08001146 ResolverParamsParcel cleanupParams = DnsResponderClient::GetDefaultResolverParamsParcel();
1147 cleanupParams.servers.clear();
1148 cleanupParams.tlsServers.clear();
Mike Yu8ac63402019-12-02 15:28:38 +08001149
Mike Yu61d17262020-02-15 18:56:22 +08001150 for (const auto& sortNameserversFlag : {"" /* unset */, "0" /* off */, "1" /* on */}) {
1151 SCOPED_TRACE(fmt::format("sortNameversFlag_{}", sortNameserversFlag));
1152 ScopedSystemProperties scopedSystemProperties(kSortNameserversFlag, sortNameserversFlag);
1153
Mike Yu10832aa2020-08-25 19:13:11 +08001154 // Re-setup test network to make experiment flag take effect.
1155 resetNetwork();
1156
Mike Yu61d17262020-02-15 18:56:22 +08001157 ASSERT_TRUE(mDnsClient.SetResolversFromParcel(setupParams));
1158
1159 // Start sending synchronized querying.
1160 for (int i = 0; i < 100; i++) {
1161 std::string hostName = StringPrintf("hello%d.com.", counter++);
1162 dns.addMapping(hostName, ns_type::ns_t_a, "1.2.3.4");
1163 const addrinfo hints = {.ai_family = AF_INET, .ai_socktype = SOCK_DGRAM};
1164 EXPECT_TRUE(safe_getaddrinfo(hostName.c_str(), nullptr, &hints) != nullptr);
1165 }
1166
1167 const std::vector<NameserverStats> targetStats = {
1168 NameserverStats(listen_addr1).setInternalErrors(5),
1169 NameserverStats(listen_addr2).setInternalErrors(5),
1170 NameserverStats(listen_addr3).setSuccesses(setupParams.maxSamples),
1171 };
1172 EXPECT_TRUE(expectStatsNotGreaterThan(targetStats));
1173
1174 // Also verify the number of queries received in the server because res_stats.successes has
1175 // a maximum.
1176 EXPECT_EQ(dns.queries().size(), 100U);
1177
1178 // Reset the state.
1179 ASSERT_TRUE(mDnsClient.SetResolversFromParcel(cleanupParams));
1180 dns.clearQueries();
Mike Yu8ac63402019-12-02 15:28:38 +08001181 }
Mike Yu8ac63402019-12-02 15:28:38 +08001182}
1183
1184TEST_F(ResolverTest, SkipBadServersDueToTimeout) {
1185 constexpr char listen_addr1[] = "127.0.0.3";
1186 constexpr char listen_addr2[] = "127.0.0.4";
Mike Yu61d17262020-02-15 18:56:22 +08001187 int counter = 0; // To generate unique hostnames.
1188
1189 ResolverParamsParcel setupParams = DnsResponderClient::GetDefaultResolverParamsParcel();
1190 setupParams.servers = {listen_addr1, listen_addr2};
1191 setupParams.minSamples = 2; // Recognize bad servers in two attempts when sorting not enabled.
1192
1193 ResolverParamsParcel cleanupParams = DnsResponderClient::GetDefaultResolverParamsParcel();
1194 cleanupParams.servers.clear();
1195 cleanupParams.tlsServers.clear();
Mike Yu8ac63402019-12-02 15:28:38 +08001196
1197 // Set dns1 non-responsive and dns2 workable.
1198 test::DNSResponder dns1(listen_addr1, test::kDefaultListenService, static_cast<ns_rcode>(-1));
1199 test::DNSResponder dns2(listen_addr2);
1200 dns1.setResponseProbability(0.0);
1201 ASSERT_TRUE(dns1.startServer());
1202 ASSERT_TRUE(dns2.startServer());
1203
Mike Yu61d17262020-02-15 18:56:22 +08001204 for (const auto& sortNameserversFlag : {"" /* unset */, "0" /* off */, "1" /* on */}) {
1205 SCOPED_TRACE(fmt::format("sortNameversFlag_{}", sortNameserversFlag));
1206 ScopedSystemProperties scopedSystemProperties(kSortNameserversFlag, sortNameserversFlag);
Mike Yu8ac63402019-12-02 15:28:38 +08001207
Mike Yu10832aa2020-08-25 19:13:11 +08001208 // Re-setup test network to make experiment flag take effect.
1209 resetNetwork();
1210
Mike Yu61d17262020-02-15 18:56:22 +08001211 ASSERT_TRUE(mDnsClient.SetResolversFromParcel(setupParams));
Mike Yu8ac63402019-12-02 15:28:38 +08001212
Mike Yu61d17262020-02-15 18:56:22 +08001213 // Start sending synchronized querying.
1214 for (int i = 0; i < 100; i++) {
1215 std::string hostName = StringPrintf("hello%d.com.", counter++);
1216 dns1.addMapping(hostName, ns_type::ns_t_a, "1.2.3.4");
1217 dns2.addMapping(hostName, ns_type::ns_t_a, "1.2.3.5");
1218 const addrinfo hints = {.ai_family = AF_INET, .ai_socktype = SOCK_DGRAM};
1219 EXPECT_TRUE(safe_getaddrinfo(hostName.c_str(), nullptr, &hints) != nullptr);
1220 }
1221
1222 const std::vector<NameserverStats> targetStats = {
1223 NameserverStats(listen_addr1).setTimeouts(5),
1224 NameserverStats(listen_addr2).setSuccesses(setupParams.maxSamples),
1225 };
1226 EXPECT_TRUE(expectStatsNotGreaterThan(targetStats));
1227
1228 // Also verify the number of queries received in the server because res_stats.successes has
1229 // an upper bound.
1230 EXPECT_GT(dns1.queries().size(), 0U);
1231 EXPECT_LT(dns1.queries().size(), 5U);
1232 EXPECT_EQ(dns2.queries().size(), 100U);
1233
1234 // Reset the state.
1235 ASSERT_TRUE(mDnsClient.SetResolversFromParcel(cleanupParams));
1236 dns1.clearQueries();
1237 dns2.clearQueries();
Mike Yu8ac63402019-12-02 15:28:38 +08001238 }
Mike Yu8ac63402019-12-02 15:28:38 +08001239}
1240
chenbrucefd837fa2019-10-29 18:35:36 +08001241TEST_F(ResolverTest, GetAddrInfoFromCustTable_InvalidInput) {
1242 constexpr char hostnameNoip[] = "noip.example.com.";
1243 constexpr char hostnameInvalidip[] = "invalidip.example.com.";
1244 const std::vector<aidl::android::net::ResolverHostsParcel> invalidCustHosts = {
1245 {"", hostnameNoip},
1246 {"wrong IP", hostnameInvalidip},
1247 };
1248 test::DNSResponder dns;
1249 StartDns(dns, {});
1250 auto resolverParams = DnsResponderClient::GetDefaultResolverParamsParcel();
Ken Chena6ac2a62020-04-07 17:25:56 +08001251 resolverParams.resolverOptions.hosts = invalidCustHosts;
chenbrucefd837fa2019-10-29 18:35:36 +08001252 ASSERT_TRUE(mDnsClient.resolvService()->setResolverConfiguration(resolverParams).isOk());
1253 for (const auto& hostname : {hostnameNoip, hostnameInvalidip}) {
1254 // The query won't get data from customized table because of invalid customized table
1255 // and DNSResponder also has no records. hostnameNoip has never registered and
1256 // hostnameInvalidip has registered but wrong IP.
1257 const addrinfo hints = {.ai_family = AF_UNSPEC};
1258 ScopedAddrinfo result = safe_getaddrinfo(hostname, nullptr, &hints);
1259 ASSERT_TRUE(result == nullptr);
1260 EXPECT_EQ(4U, GetNumQueries(dns, hostname));
1261 }
1262}
1263
1264TEST_F(ResolverTest, GetAddrInfoFromCustTable) {
1265 constexpr char hostnameV4[] = "v4only.example.com.";
1266 constexpr char hostnameV6[] = "v6only.example.com.";
1267 constexpr char hostnameV4V6[] = "v4v6.example.com.";
1268 constexpr char custAddrV4[] = "1.2.3.4";
1269 constexpr char custAddrV6[] = "::1.2.3.4";
1270 constexpr char dnsSvAddrV4[] = "1.2.3.5";
1271 constexpr char dnsSvAddrV6[] = "::1.2.3.5";
1272 const std::vector<aidl::android::net::ResolverHostsParcel> custHostV4 = {
1273 {custAddrV4, hostnameV4},
1274 };
1275 const std::vector<aidl::android::net::ResolverHostsParcel> custHostV6 = {
1276 {custAddrV6, hostnameV6},
1277 };
1278 const std::vector<aidl::android::net::ResolverHostsParcel> custHostV4V6 = {
1279 {custAddrV4, hostnameV4V6},
1280 {custAddrV6, hostnameV4V6},
1281 };
1282 const std::vector<DnsRecord> dnsSvHostV4 = {
1283 {hostnameV4, ns_type::ns_t_a, dnsSvAddrV4},
1284 };
1285 const std::vector<DnsRecord> dnsSvHostV6 = {
1286 {hostnameV6, ns_type::ns_t_aaaa, dnsSvAddrV6},
1287 };
1288 const std::vector<DnsRecord> dnsSvHostV4V6 = {
1289 {hostnameV4V6, ns_type::ns_t_a, dnsSvAddrV4},
1290 {hostnameV4V6, ns_type::ns_t_aaaa, dnsSvAddrV6},
1291 };
1292 struct TestConfig {
1293 const std::string name;
1294 const std::vector<aidl::android::net::ResolverHostsParcel> customizedHosts;
1295 const std::vector<DnsRecord> dnsserverHosts;
1296 const std::vector<std::string> queryResult;
1297 std::string asParameters() const {
1298 return StringPrintf("name: %s, customizedHosts: %s, dnsserverHosts: %s", name.c_str(),
1299 customizedHosts.empty() ? "No" : "Yes",
1300 dnsserverHosts.empty() ? "No" : "Yes");
1301 }
1302 } testConfigs[]{
1303 // clang-format off
1304 {hostnameV4, {}, {}, {}},
1305 {hostnameV4, {}, dnsSvHostV4, {dnsSvAddrV4}},
1306 {hostnameV4, custHostV4, {}, {custAddrV4}},
1307 {hostnameV4, custHostV4, dnsSvHostV4, {custAddrV4}},
1308 {hostnameV6, {}, {}, {}},
1309 {hostnameV6, {}, dnsSvHostV6, {dnsSvAddrV6}},
1310 {hostnameV6, custHostV6, {}, {custAddrV6}},
1311 {hostnameV6, custHostV6, dnsSvHostV6, {custAddrV6}},
1312 {hostnameV4V6, {}, {}, {}},
1313 {hostnameV4V6, {}, dnsSvHostV4V6, {dnsSvAddrV4, dnsSvAddrV6}},
1314 {hostnameV4V6, custHostV4V6, {}, {custAddrV4, custAddrV6}},
1315 {hostnameV4V6, custHostV4V6, dnsSvHostV4V6, {custAddrV4, custAddrV6}},
1316 // clang-format on
1317 };
1318
1319 for (const auto& config : testConfigs) {
1320 SCOPED_TRACE(config.asParameters());
1321
1322 test::DNSResponder dns;
1323 StartDns(dns, config.dnsserverHosts);
1324
1325 auto resolverParams = DnsResponderClient::GetDefaultResolverParamsParcel();
Ken Chena6ac2a62020-04-07 17:25:56 +08001326 resolverParams.resolverOptions.hosts = config.customizedHosts;
chenbrucefd837fa2019-10-29 18:35:36 +08001327 ASSERT_TRUE(mDnsClient.resolvService()->setResolverConfiguration(resolverParams).isOk());
1328 const addrinfo hints = {.ai_family = AF_UNSPEC, .ai_socktype = SOCK_STREAM};
1329 ScopedAddrinfo result = safe_getaddrinfo(config.name.c_str(), nullptr, &hints);
1330 if (config.customizedHosts.empty() && config.dnsserverHosts.empty()) {
1331 ASSERT_TRUE(result == nullptr);
1332 EXPECT_EQ(2U, GetNumQueries(dns, config.name.c_str()));
1333 } else {
1334 ASSERT_TRUE(result != nullptr);
1335 EXPECT_THAT(ToStrings(result), testing::UnorderedElementsAreArray(config.queryResult));
1336 EXPECT_EQ(config.customizedHosts.empty() ? 2U : 0U,
1337 GetNumQueries(dns, config.name.c_str()));
1338 }
1339
1340 EXPECT_TRUE(mDnsClient.resolvService()->flushNetworkCache(TEST_NETID).isOk());
1341 }
1342}
1343
1344TEST_F(ResolverTest, GetAddrInfoFromCustTable_Modify) {
1345 constexpr char hostnameV4V6[] = "v4v6.example.com.";
1346 constexpr char custAddrV4[] = "1.2.3.4";
1347 constexpr char custAddrV6[] = "::1.2.3.4";
1348 constexpr char dnsSvAddrV4[] = "1.2.3.5";
1349 constexpr char dnsSvAddrV6[] = "::1.2.3.5";
1350 const std::vector<DnsRecord> dnsSvHostV4V6 = {
1351 {hostnameV4V6, ns_type::ns_t_a, dnsSvAddrV4},
1352 {hostnameV4V6, ns_type::ns_t_aaaa, dnsSvAddrV6},
1353 };
1354 const std::vector<aidl::android::net::ResolverHostsParcel> custHostV4V6 = {
1355 {custAddrV4, hostnameV4V6},
1356 {custAddrV6, hostnameV4V6},
1357 };
1358 test::DNSResponder dns;
1359 StartDns(dns, dnsSvHostV4V6);
1360 auto resolverParams = DnsResponderClient::GetDefaultResolverParamsParcel();
1361
Ken Chena6ac2a62020-04-07 17:25:56 +08001362 resolverParams.resolverOptions.hosts = custHostV4V6;
chenbrucefd837fa2019-10-29 18:35:36 +08001363 ASSERT_TRUE(mDnsClient.resolvService()->setResolverConfiguration(resolverParams).isOk());
1364 const addrinfo hints = {.ai_family = AF_UNSPEC, .ai_socktype = SOCK_STREAM};
1365 ScopedAddrinfo result = safe_getaddrinfo(hostnameV4V6, nullptr, &hints);
1366 ASSERT_TRUE(result != nullptr);
1367 EXPECT_THAT(ToStrings(result), testing::UnorderedElementsAreArray({custAddrV4, custAddrV6}));
1368 EXPECT_EQ(0U, GetNumQueries(dns, hostnameV4V6));
1369
Ken Chena6ac2a62020-04-07 17:25:56 +08001370 resolverParams.resolverOptions.hosts = {};
chenbrucefd837fa2019-10-29 18:35:36 +08001371 ASSERT_TRUE(mDnsClient.resolvService()->setResolverConfiguration(resolverParams).isOk());
1372 result = safe_getaddrinfo(hostnameV4V6, nullptr, &hints);
1373 ASSERT_TRUE(result != nullptr);
1374 EXPECT_THAT(ToStrings(result), testing::UnorderedElementsAreArray({dnsSvAddrV4, dnsSvAddrV6}));
1375 EXPECT_EQ(2U, GetNumQueries(dns, hostnameV4V6));
1376}
1377
Ken Chenb9fa2062018-11-13 21:51:13 +08001378TEST_F(ResolverTest, EmptySetup) {
Ken Chenb9fa2062018-11-13 21:51:13 +08001379 std::vector<std::string> servers;
1380 std::vector<std::string> domains;
Xiao Ma09b71022018-12-11 17:56:32 +09001381 ASSERT_TRUE(mDnsClient.SetResolversForNetwork(servers, domains));
Ken Chenb9fa2062018-11-13 21:51:13 +08001382 std::vector<std::string> res_servers;
1383 std::vector<std::string> res_domains;
Mike Yu0a1c53d2018-11-26 13:26:21 +09001384 std::vector<std::string> res_tls_servers;
Bernie Innocenti758005f2019-02-19 18:08:36 +09001385 res_params res_params;
Ken Chenb9fa2062018-11-13 21:51:13 +08001386 std::vector<ResolverStats> res_stats;
Ken Chen92bed612018-12-22 21:46:55 +08001387 int wait_for_pending_req_timeout_count;
Luke Huangf8215372019-11-22 11:53:41 +08001388 ASSERT_TRUE(DnsResponderClient::GetResolverInfo(
1389 mDnsClient.resolvService(), TEST_NETID, &res_servers, &res_domains, &res_tls_servers,
1390 &res_params, &res_stats, &wait_for_pending_req_timeout_count));
Ken Chenb9fa2062018-11-13 21:51:13 +08001391 EXPECT_EQ(0U, res_servers.size());
1392 EXPECT_EQ(0U, res_domains.size());
Mike Yu0a1c53d2018-11-26 13:26:21 +09001393 EXPECT_EQ(0U, res_tls_servers.size());
Luke Huang5bd827c2019-03-14 16:10:04 +08001394 ASSERT_EQ(static_cast<size_t>(IDnsResolver::RESOLVER_PARAMS_COUNT), kDefaultParams.size());
1395 EXPECT_EQ(kDefaultParams[IDnsResolver::RESOLVER_PARAMS_SAMPLE_VALIDITY],
1396 res_params.sample_validity);
1397 EXPECT_EQ(kDefaultParams[IDnsResolver::RESOLVER_PARAMS_SUCCESS_THRESHOLD],
Bernie Innocentia5c7b7b2019-01-17 21:28:24 +09001398 res_params.success_threshold);
Luke Huang5bd827c2019-03-14 16:10:04 +08001399 EXPECT_EQ(kDefaultParams[IDnsResolver::RESOLVER_PARAMS_MIN_SAMPLES], res_params.min_samples);
1400 EXPECT_EQ(kDefaultParams[IDnsResolver::RESOLVER_PARAMS_MAX_SAMPLES], res_params.max_samples);
1401 EXPECT_EQ(kDefaultParams[IDnsResolver::RESOLVER_PARAMS_BASE_TIMEOUT_MSEC],
Ken Chenb9fa2062018-11-13 21:51:13 +08001402 res_params.base_timeout_msec);
Luke Huang5bd827c2019-03-14 16:10:04 +08001403 EXPECT_EQ(kDefaultParams[IDnsResolver::RESOLVER_PARAMS_RETRY_COUNT], res_params.retry_count);
Ken Chenb9fa2062018-11-13 21:51:13 +08001404}
1405
1406TEST_F(ResolverTest, SearchPathChange) {
Xiao Ma09b71022018-12-11 17:56:32 +09001407 constexpr char listen_addr[] = "127.0.0.13";
1408 constexpr char host_name1[] = "test13.domain1.org.";
1409 constexpr char host_name2[] = "test13.domain2.org.";
Luke Huangf8215372019-11-22 11:53:41 +08001410 std::vector<std::string> servers = {listen_addr};
1411 std::vector<std::string> domains = {"domain1.org"};
Xiao Ma09b71022018-12-11 17:56:32 +09001412
1413 const std::vector<DnsRecord> records = {
1414 {host_name1, ns_type::ns_t_aaaa, "2001:db8::13"},
1415 {host_name2, ns_type::ns_t_aaaa, "2001:db8::1:13"},
1416 };
1417 test::DNSResponder dns(listen_addr);
1418 StartDns(dns, records);
1419 ASSERT_TRUE(mDnsClient.SetResolversForNetwork(servers, domains));
Ken Chenb9fa2062018-11-13 21:51:13 +08001420
1421 const addrinfo hints = {.ai_family = AF_INET6};
1422 ScopedAddrinfo result = safe_getaddrinfo("test13", nullptr, &hints);
1423 EXPECT_TRUE(result != nullptr);
1424 EXPECT_EQ(1U, dns.queries().size());
1425 EXPECT_EQ(1U, GetNumQueries(dns, host_name1));
1426 EXPECT_EQ("2001:db8::13", ToString(result));
1427
1428 // Test that changing the domain search path on its own works.
Luke Huangf8215372019-11-22 11:53:41 +08001429 domains = {"domain2.org"};
Xiao Ma09b71022018-12-11 17:56:32 +09001430 ASSERT_TRUE(mDnsClient.SetResolversForNetwork(servers, domains));
Ken Chenb9fa2062018-11-13 21:51:13 +08001431 dns.clearQueries();
1432
1433 result = safe_getaddrinfo("test13", nullptr, &hints);
1434 EXPECT_TRUE(result != nullptr);
1435 EXPECT_EQ(1U, dns.queries().size());
1436 EXPECT_EQ(1U, GetNumQueries(dns, host_name2));
1437 EXPECT_EQ("2001:db8::1:13", ToString(result));
1438}
1439
Luke Huang2dac4382019-06-24 13:28:44 +08001440namespace {
1441
Luke Huangf8215372019-11-22 11:53:41 +08001442std::vector<std::string> getResolverDomains(aidl::android::net::IDnsResolver* dnsResolverService,
Luke Huang2dac4382019-06-24 13:28:44 +08001443 unsigned netId) {
1444 std::vector<std::string> res_servers;
1445 std::vector<std::string> res_domains;
1446 std::vector<std::string> res_tls_servers;
1447 res_params res_params;
1448 std::vector<ResolverStats> res_stats;
1449 int wait_for_pending_req_timeout_count;
Luke Huangf8215372019-11-22 11:53:41 +08001450 DnsResponderClient::GetResolverInfo(dnsResolverService, netId, &res_servers, &res_domains,
1451 &res_tls_servers, &res_params, &res_stats,
1452 &wait_for_pending_req_timeout_count);
Luke Huang2dac4382019-06-24 13:28:44 +08001453 return res_domains;
1454}
1455
1456} // namespace
1457
1458TEST_F(ResolverTest, SearchPathPrune) {
1459 constexpr size_t DUPLICATED_DOMAIN_NUM = 3;
1460 constexpr char listen_addr[] = "127.0.0.13";
1461 constexpr char domian_name1[] = "domain13.org.";
1462 constexpr char domian_name2[] = "domain14.org.";
1463 constexpr char host_name1[] = "test13.domain13.org.";
1464 constexpr char host_name2[] = "test14.domain14.org.";
1465 std::vector<std::string> servers = {listen_addr};
1466
1467 std::vector<std::string> testDomains1;
1468 std::vector<std::string> testDomains2;
1469 // Domain length should be <= 255
1470 // Max number of domains in search path is 6
1471 for (size_t i = 0; i < MAXDNSRCH + 1; i++) {
1472 // Fill up with invalid domain
1473 testDomains1.push_back(std::string(300, i + '0'));
1474 // Fill up with valid but duplicated domain
1475 testDomains2.push_back(StringPrintf("domain%zu.org", i % DUPLICATED_DOMAIN_NUM));
1476 }
1477
1478 // Add valid domain used for query.
1479 testDomains1.push_back(domian_name1);
1480
1481 // Add valid domain twice used for query.
1482 testDomains2.push_back(domian_name2);
1483 testDomains2.push_back(domian_name2);
1484
1485 const std::vector<DnsRecord> records = {
1486 {host_name1, ns_type::ns_t_aaaa, "2001:db8::13"},
1487 {host_name2, ns_type::ns_t_aaaa, "2001:db8::1:13"},
1488 };
1489 test::DNSResponder dns(listen_addr);
1490 StartDns(dns, records);
1491 ASSERT_TRUE(mDnsClient.SetResolversForNetwork(servers, testDomains1));
1492
1493 const addrinfo hints = {.ai_family = AF_INET6};
1494 ScopedAddrinfo result = safe_getaddrinfo("test13", nullptr, &hints);
1495
1496 EXPECT_TRUE(result != nullptr);
1497
1498 EXPECT_EQ(1U, dns.queries().size());
1499 EXPECT_EQ(1U, GetNumQueries(dns, host_name1));
1500 EXPECT_EQ("2001:db8::13", ToString(result));
1501
1502 const auto& res_domains1 = getResolverDomains(mDnsClient.resolvService(), TEST_NETID);
1503 // Expect 1 valid domain, invalid domains are removed.
1504 ASSERT_EQ(1U, res_domains1.size());
1505 EXPECT_EQ(domian_name1, res_domains1[0]);
1506
1507 dns.clearQueries();
1508
1509 ASSERT_TRUE(mDnsClient.SetResolversForNetwork(servers, testDomains2));
1510
1511 result = safe_getaddrinfo("test14", nullptr, &hints);
1512 EXPECT_TRUE(result != nullptr);
1513
1514 // (3 domains * 2 retries) + 1 success query = 7
1515 EXPECT_EQ(7U, dns.queries().size());
1516 EXPECT_EQ(1U, GetNumQueries(dns, host_name2));
1517 EXPECT_EQ("2001:db8::1:13", ToString(result));
1518
1519 const auto& res_domains2 = getResolverDomains(mDnsClient.resolvService(), TEST_NETID);
1520 // Expect 4 valid domain, duplicate domains are removed.
1521 EXPECT_EQ(DUPLICATED_DOMAIN_NUM + 1U, res_domains2.size());
1522 EXPECT_THAT(
1523 std::vector<std::string>({"domain0.org", "domain1.org", "domain2.org", domian_name2}),
1524 testing::ElementsAreArray(res_domains2));
1525}
1526
Mike Yu0a1c53d2018-11-26 13:26:21 +09001527// If we move this function to dns_responder_client, it will complicate the dependency need of
1528// dns_tls_frontend.h.
1529static void setupTlsServers(const std::vector<std::string>& servers,
waynema0e73c2e2019-07-31 15:04:08 +08001530 std::vector<std::unique_ptr<test::DnsTlsFrontend>>* tls) {
Xiao Ma09b71022018-12-11 17:56:32 +09001531 constexpr char listen_udp[] = "53";
1532 constexpr char listen_tls[] = "853";
Mike Yu0a1c53d2018-11-26 13:26:21 +09001533
1534 for (const auto& server : servers) {
1535 auto t = std::make_unique<test::DnsTlsFrontend>(server, listen_tls, server, listen_udp);
1536 t = std::make_unique<test::DnsTlsFrontend>(server, listen_tls, server, listen_udp);
1537 t->startServer();
Mike Yu0a1c53d2018-11-26 13:26:21 +09001538 tls->push_back(std::move(t));
1539 }
1540}
1541
Mike Yu0a1c53d2018-11-26 13:26:21 +09001542TEST_F(ResolverTest, MaxServerPrune_Binder) {
Mike Yu0a1c53d2018-11-26 13:26:21 +09001543 std::vector<std::string> domains;
1544 std::vector<std::unique_ptr<test::DNSResponder>> dns;
1545 std::vector<std::unique_ptr<test::DnsTlsFrontend>> tls;
1546 std::vector<std::string> servers;
Bernie Innocentia5c7b7b2019-01-17 21:28:24 +09001547 std::vector<DnsResponderClient::Mapping> mappings;
Mike Yu0a1c53d2018-11-26 13:26:21 +09001548
1549 for (unsigned i = 0; i < MAXDNSRCH + 1; i++) {
1550 domains.push_back(StringPrintf("example%u.com", i));
1551 }
Bernie Innocentia5c7b7b2019-01-17 21:28:24 +09001552 ASSERT_NO_FATAL_FAILURE(mDnsClient.SetupMappings(1, domains, &mappings));
1553 ASSERT_NO_FATAL_FAILURE(mDnsClient.SetupDNSServers(MAXNS + 1, mappings, &dns, &servers));
waynema0e73c2e2019-07-31 15:04:08 +08001554 ASSERT_NO_FATAL_FAILURE(setupTlsServers(servers, &tls));
Mike Yu0a1c53d2018-11-26 13:26:21 +09001555
waynema0e73c2e2019-07-31 15:04:08 +08001556 ASSERT_TRUE(mDnsClient.SetResolversWithTls(servers, domains, kDefaultParams,
1557 kDefaultPrivateDnsHostName));
Mike Yu0a1c53d2018-11-26 13:26:21 +09001558
Mike Yu383855b2019-01-15 17:53:27 +08001559 // If the private DNS validation hasn't completed yet before backend DNS servers stop,
1560 // TLS servers will get stuck in handleOneRequest(), which causes this test stuck in
1561 // ~DnsTlsFrontend() because the TLS server loop threads can't be terminated.
1562 // So, wait for private DNS validation done before stopping backend DNS servers.
1563 for (int i = 0; i < MAXNS; i++) {
chenbruceaff85842019-05-31 15:46:42 +08001564 LOG(INFO) << "Waiting for private DNS validation on " << tls[i]->listen_address() << ".";
Mike Yu724f77d2019-08-16 11:14:50 +08001565 EXPECT_TRUE(WaitForPrivateDnsValidation(tls[i]->listen_address(), true));
chenbruceaff85842019-05-31 15:46:42 +08001566 LOG(INFO) << "private DNS validation on " << tls[i]->listen_address() << " done.";
Mike Yu383855b2019-01-15 17:53:27 +08001567 }
1568
Mike Yu0a1c53d2018-11-26 13:26:21 +09001569 std::vector<std::string> res_servers;
1570 std::vector<std::string> res_domains;
1571 std::vector<std::string> res_tls_servers;
Bernie Innocenti758005f2019-02-19 18:08:36 +09001572 res_params res_params;
Mike Yu0a1c53d2018-11-26 13:26:21 +09001573 std::vector<ResolverStats> res_stats;
Ken Chen92bed612018-12-22 21:46:55 +08001574 int wait_for_pending_req_timeout_count;
Luke Huangf8215372019-11-22 11:53:41 +08001575 ASSERT_TRUE(DnsResponderClient::GetResolverInfo(
1576 mDnsClient.resolvService(), TEST_NETID, &res_servers, &res_domains, &res_tls_servers,
1577 &res_params, &res_stats, &wait_for_pending_req_timeout_count));
Mike Yu0a1c53d2018-11-26 13:26:21 +09001578
1579 // Check the size of the stats and its contents.
1580 EXPECT_EQ(static_cast<size_t>(MAXNS), res_servers.size());
1581 EXPECT_EQ(static_cast<size_t>(MAXNS), res_tls_servers.size());
1582 EXPECT_EQ(static_cast<size_t>(MAXDNSRCH), res_domains.size());
1583 EXPECT_TRUE(std::equal(servers.begin(), servers.begin() + MAXNS, res_servers.begin()));
1584 EXPECT_TRUE(std::equal(servers.begin(), servers.begin() + MAXNS, res_tls_servers.begin()));
1585 EXPECT_TRUE(std::equal(domains.begin(), domains.begin() + MAXDNSRCH, res_domains.begin()));
Mike Yu0a1c53d2018-11-26 13:26:21 +09001586}
1587
1588TEST_F(ResolverTest, ResolverStats) {
Xiao Ma09b71022018-12-11 17:56:32 +09001589 constexpr char listen_addr1[] = "127.0.0.4";
1590 constexpr char listen_addr2[] = "127.0.0.5";
1591 constexpr char listen_addr3[] = "127.0.0.6";
Mike Yu0a1c53d2018-11-26 13:26:21 +09001592
1593 // Set server 1 timeout.
Mike Yufc125e42019-05-15 20:41:28 +08001594 test::DNSResponder dns1(listen_addr1, "53", static_cast<ns_rcode>(-1));
Mike Yu0a1c53d2018-11-26 13:26:21 +09001595 dns1.setResponseProbability(0.0);
1596 ASSERT_TRUE(dns1.startServer());
1597
1598 // Set server 2 responding server failure.
Xiao Ma09b71022018-12-11 17:56:32 +09001599 test::DNSResponder dns2(listen_addr2);
Mike Yu0a1c53d2018-11-26 13:26:21 +09001600 dns2.setResponseProbability(0.0);
1601 ASSERT_TRUE(dns2.startServer());
1602
1603 // Set server 3 workable.
Xiao Ma09b71022018-12-11 17:56:32 +09001604 test::DNSResponder dns3(listen_addr3);
1605 dns3.addMapping(kHelloExampleCom, ns_type::ns_t_a, "1.2.3.4");
Mike Yu0a1c53d2018-11-26 13:26:21 +09001606 ASSERT_TRUE(dns3.startServer());
1607
1608 std::vector<std::string> servers = {listen_addr1, listen_addr2, listen_addr3};
Xiao Ma09b71022018-12-11 17:56:32 +09001609 ASSERT_TRUE(mDnsClient.SetResolversForNetwork(servers));
Mike Yu0a1c53d2018-11-26 13:26:21 +09001610
1611 dns3.clearQueries();
Xiao Ma09b71022018-12-11 17:56:32 +09001612 const addrinfo hints = {.ai_family = AF_INET, .ai_socktype = SOCK_DGRAM};
Mike Yu0a1c53d2018-11-26 13:26:21 +09001613 ScopedAddrinfo result = safe_getaddrinfo("hello", nullptr, &hints);
Xiao Ma09b71022018-12-11 17:56:32 +09001614 size_t found = GetNumQueries(dns3, kHelloExampleCom);
Mike Yu0a1c53d2018-11-26 13:26:21 +09001615 EXPECT_LE(1U, found);
1616 std::string result_str = ToString(result);
1617 EXPECT_TRUE(result_str == "1.2.3.4") << ", result_str='" << result_str << "'";
1618
Mike Yue2162e52020-03-04 18:43:46 +08001619 const std::vector<NameserverStats> expectedCleartextDnsStats = {
1620 NameserverStats(listen_addr1).setTimeouts(1),
1621 NameserverStats(listen_addr2).setErrors(1),
1622 NameserverStats(listen_addr3).setSuccesses(1),
1623 };
Mike Yu61d17262020-02-15 18:56:22 +08001624 EXPECT_TRUE(expectStatsEqualTo(expectedCleartextDnsStats));
Mike Yu0a1c53d2018-11-26 13:26:21 +09001625}
1626
Mike Yu15791832020-02-11 13:38:48 +08001627TEST_F(ResolverTest, AlwaysUseLatestSetupParamsInLookups) {
1628 constexpr char listen_addr1[] = "127.0.0.3";
1629 constexpr char listen_addr2[] = "255.255.255.255";
1630 constexpr char listen_addr3[] = "127.0.0.4";
1631 constexpr char hostname[] = "hello";
1632 constexpr char fqdn_with_search_domain[] = "hello.domain2.com.";
1633
1634 test::DNSResponder dns1(listen_addr1, test::kDefaultListenService, static_cast<ns_rcode>(-1));
1635 dns1.setResponseProbability(0.0);
1636 ASSERT_TRUE(dns1.startServer());
1637
1638 test::DNSResponder dns3(listen_addr3);
1639 StartDns(dns3, {{fqdn_with_search_domain, ns_type::ns_t_a, "1.2.3.4"}});
1640
1641 ResolverParamsParcel parcel = DnsResponderClient::GetDefaultResolverParamsParcel();
1642 parcel.tlsServers.clear();
1643 parcel.servers = {listen_addr1, listen_addr2};
1644 parcel.domains = {"domain1.com", "domain2.com"};
1645 ASSERT_TRUE(mDnsClient.SetResolversFromParcel(parcel));
1646
1647 // Expect the things happening in t1:
1648 // 1. The lookup starts using the first domain for query. It sends queries to the populated
1649 // nameserver list {listen_addr1, listen_addr2} for the hostname "hello.domain1.com".
1650 // 2. A different list of nameservers is updated to the resolver. Revision ID is incremented.
1651 // 3. The query for the hostname times out. The lookup fails to add the timeout record to the
1652 // the stats because of the unmatched revision ID.
1653 // 4. The lookup starts using the second domain for query. It sends queries to the populated
1654 // nameserver list {listen_addr3, listen_addr1, listen_addr2} for another hostname
1655 // "hello.domain2.com".
1656 // 5. The lookup gets the answer and updates a success record to the stats.
1657 std::thread t1([&hostname]() {
1658 const addrinfo hints = {.ai_family = AF_INET, .ai_socktype = SOCK_DGRAM};
1659 ScopedAddrinfo result = safe_getaddrinfo(hostname, nullptr, &hints);
1660 EXPECT_NE(result.get(), nullptr);
1661 EXPECT_EQ(ToString(result), "1.2.3.4");
1662 });
1663
1664 // Wait for t1 to start the step 1.
1665 while (dns1.queries().size() == 0) {
1666 usleep(1000);
1667 }
1668
1669 // Update the resolver with three nameservers. This will increment the revision ID.
1670 parcel.servers = {listen_addr3, listen_addr1, listen_addr2};
1671 ASSERT_TRUE(mDnsClient.SetResolversFromParcel(parcel));
1672
1673 t1.join();
1674 EXPECT_EQ(0U, GetNumQueriesForType(dns3, ns_type::ns_t_aaaa, fqdn_with_search_domain));
1675 EXPECT_EQ(1U, GetNumQueriesForType(dns3, ns_type::ns_t_a, fqdn_with_search_domain));
1676
Mike Yue2162e52020-03-04 18:43:46 +08001677 const std::vector<NameserverStats> expectedCleartextDnsStats = {
1678 NameserverStats(listen_addr1),
1679 NameserverStats(listen_addr2),
1680 NameserverStats(listen_addr3).setSuccesses(1),
1681 };
Mike Yu61d17262020-02-15 18:56:22 +08001682 EXPECT_TRUE(expectStatsEqualTo(expectedCleartextDnsStats));
Mike Yu15791832020-02-11 13:38:48 +08001683}
1684
Ken Chenb9fa2062018-11-13 21:51:13 +08001685// Test what happens if the specified TLS server is nonexistent.
1686TEST_F(ResolverTest, GetHostByName_TlsMissing) {
Xiao Ma09b71022018-12-11 17:56:32 +09001687 constexpr char listen_addr[] = "127.0.0.3";
1688 constexpr char host_name[] = "tlsmissing.example.com.";
1689
1690 test::DNSResponder dns;
1691 StartDns(dns, {{host_name, ns_type::ns_t_a, "1.2.3.3"}});
Luke Huangf8215372019-11-22 11:53:41 +08001692 std::vector<std::string> servers = {listen_addr};
Ken Chenb9fa2062018-11-13 21:51:13 +08001693
1694 // There's nothing listening on this address, so validation will either fail or
1695 /// hang. Either way, queries will continue to flow to the DNSResponder.
waynema0e73c2e2019-07-31 15:04:08 +08001696 ASSERT_TRUE(mDnsClient.SetResolversWithTls(servers, kDefaultSearchDomains, kDefaultParams, ""));
Ken Chenb9fa2062018-11-13 21:51:13 +08001697
1698 const hostent* result;
1699
1700 result = gethostbyname("tlsmissing");
1701 ASSERT_FALSE(result == nullptr);
1702 EXPECT_EQ("1.2.3.3", ToString(result));
1703
1704 // Clear TLS bit.
Xiao Ma09b71022018-12-11 17:56:32 +09001705 ASSERT_TRUE(mDnsClient.SetResolversForNetwork());
Ken Chenb9fa2062018-11-13 21:51:13 +08001706}
1707
1708// Test what happens if the specified TLS server replies with garbage.
1709TEST_F(ResolverTest, GetHostByName_TlsBroken) {
Xiao Ma09b71022018-12-11 17:56:32 +09001710 constexpr char listen_addr[] = "127.0.0.3";
1711 constexpr char host_name1[] = "tlsbroken1.example.com.";
1712 constexpr char host_name2[] = "tlsbroken2.example.com.";
1713 const std::vector<DnsRecord> records = {
1714 {host_name1, ns_type::ns_t_a, "1.2.3.1"},
1715 {host_name2, ns_type::ns_t_a, "1.2.3.2"},
1716 };
1717
1718 test::DNSResponder dns;
1719 StartDns(dns, records);
Luke Huangf8215372019-11-22 11:53:41 +08001720 std::vector<std::string> servers = {listen_addr};
Ken Chenb9fa2062018-11-13 21:51:13 +08001721
1722 // Bind the specified private DNS socket but don't respond to any client sockets yet.
1723 int s = socket(AF_INET, SOCK_STREAM | SOCK_CLOEXEC, IPPROTO_TCP);
1724 ASSERT_TRUE(s >= 0);
1725 struct sockaddr_in tlsServer = {
Luke Huangf8215372019-11-22 11:53:41 +08001726 .sin_family = AF_INET,
1727 .sin_port = htons(853),
Ken Chenb9fa2062018-11-13 21:51:13 +08001728 };
1729 ASSERT_TRUE(inet_pton(AF_INET, listen_addr, &tlsServer.sin_addr));
1730 ASSERT_TRUE(enableSockopt(s, SOL_SOCKET, SO_REUSEPORT).ok());
1731 ASSERT_TRUE(enableSockopt(s, SOL_SOCKET, SO_REUSEADDR).ok());
1732 ASSERT_FALSE(bind(s, reinterpret_cast<struct sockaddr*>(&tlsServer), sizeof(tlsServer)));
1733 ASSERT_FALSE(listen(s, 1));
1734
1735 // Trigger TLS validation.
waynema0e73c2e2019-07-31 15:04:08 +08001736 ASSERT_TRUE(mDnsClient.SetResolversWithTls(servers, kDefaultSearchDomains, kDefaultParams, ""));
Ken Chenb9fa2062018-11-13 21:51:13 +08001737
1738 struct sockaddr_storage cliaddr;
1739 socklen_t sin_size = sizeof(cliaddr);
Luke Huangf8215372019-11-22 11:53:41 +08001740 int new_fd = accept4(s, reinterpret_cast<struct sockaddr*>(&cliaddr), &sin_size, SOCK_CLOEXEC);
Ken Chenb9fa2062018-11-13 21:51:13 +08001741 ASSERT_TRUE(new_fd > 0);
1742
1743 // We've received the new file descriptor but not written to it or closed, so the
1744 // validation is still pending. Queries should still flow correctly because the
1745 // server is not used until validation succeeds.
1746 const hostent* result;
1747 result = gethostbyname("tlsbroken1");
1748 ASSERT_FALSE(result == nullptr);
1749 EXPECT_EQ("1.2.3.1", ToString(result));
1750
1751 // Now we cause the validation to fail.
1752 std::string garbage = "definitely not a valid TLS ServerHello";
1753 write(new_fd, garbage.data(), garbage.size());
1754 close(new_fd);
1755
1756 // Validation failure shouldn't interfere with lookups, because lookups won't be sent
1757 // to the TLS server unless validation succeeds.
1758 result = gethostbyname("tlsbroken2");
1759 ASSERT_FALSE(result == nullptr);
1760 EXPECT_EQ("1.2.3.2", ToString(result));
1761
1762 // Clear TLS bit.
Xiao Ma09b71022018-12-11 17:56:32 +09001763 ASSERT_TRUE(mDnsClient.SetResolversForNetwork());
Ken Chenb9fa2062018-11-13 21:51:13 +08001764 close(s);
1765}
1766
1767TEST_F(ResolverTest, GetHostByName_Tls) {
Xiao Ma09b71022018-12-11 17:56:32 +09001768 constexpr char listen_addr[] = "127.0.0.3";
1769 constexpr char listen_udp[] = "53";
1770 constexpr char listen_tls[] = "853";
1771 constexpr char host_name1[] = "tls1.example.com.";
1772 constexpr char host_name2[] = "tls2.example.com.";
1773 constexpr char host_name3[] = "tls3.example.com.";
1774 const std::vector<DnsRecord> records = {
1775 {host_name1, ns_type::ns_t_a, "1.2.3.1"},
1776 {host_name2, ns_type::ns_t_a, "1.2.3.2"},
1777 {host_name3, ns_type::ns_t_a, "1.2.3.3"},
1778 };
1779
1780 test::DNSResponder dns;
1781 StartDns(dns, records);
Luke Huangf8215372019-11-22 11:53:41 +08001782 std::vector<std::string> servers = {listen_addr};
Ken Chenb9fa2062018-11-13 21:51:13 +08001783
1784 test::DnsTlsFrontend tls(listen_addr, listen_tls, listen_addr, listen_udp);
1785 ASSERT_TRUE(tls.startServer());
waynema0e73c2e2019-07-31 15:04:08 +08001786 ASSERT_TRUE(mDnsClient.SetResolversWithTls(servers, kDefaultSearchDomains, kDefaultParams, ""));
Mike Yu724f77d2019-08-16 11:14:50 +08001787 EXPECT_TRUE(WaitForPrivateDnsValidation(tls.listen_address(), true));
Ken Chenb9fa2062018-11-13 21:51:13 +08001788
Mike Yu724f77d2019-08-16 11:14:50 +08001789 const hostent* result = gethostbyname("tls1");
Ken Chenb9fa2062018-11-13 21:51:13 +08001790 ASSERT_FALSE(result == nullptr);
1791 EXPECT_EQ("1.2.3.1", ToString(result));
1792
1793 // Wait for query to get counted.
Bernie Innocenti0ad80e92020-01-23 22:20:44 +09001794 EXPECT_TRUE(tls.waitForQueries(2));
Ken Chenb9fa2062018-11-13 21:51:13 +08001795
1796 // Stop the TLS server. Since we're in opportunistic mode, queries will
1797 // fall back to the locally-assigned (clear text) nameservers.
1798 tls.stopServer();
1799
1800 dns.clearQueries();
1801 result = gethostbyname("tls2");
1802 EXPECT_FALSE(result == nullptr);
1803 EXPECT_EQ("1.2.3.2", ToString(result));
1804 const auto queries = dns.queries();
1805 EXPECT_EQ(1U, queries.size());
waynema29253052019-08-20 11:26:08 +08001806 EXPECT_EQ("tls2.example.com.", queries[0].name);
1807 EXPECT_EQ(ns_t_a, queries[0].type);
Ken Chenb9fa2062018-11-13 21:51:13 +08001808
1809 // Reset the resolvers without enabling TLS. Queries should still be routed
1810 // to the UDP endpoint.
Xiao Ma09b71022018-12-11 17:56:32 +09001811 ASSERT_TRUE(mDnsClient.SetResolversForNetwork());
Ken Chenb9fa2062018-11-13 21:51:13 +08001812
1813 result = gethostbyname("tls3");
1814 ASSERT_FALSE(result == nullptr);
1815 EXPECT_EQ("1.2.3.3", ToString(result));
Ken Chenb9fa2062018-11-13 21:51:13 +08001816}
1817
Ken Chenb9fa2062018-11-13 21:51:13 +08001818TEST_F(ResolverTest, GetHostByName_TlsFailover) {
Xiao Ma09b71022018-12-11 17:56:32 +09001819 constexpr char listen_addr1[] = "127.0.0.3";
1820 constexpr char listen_addr2[] = "127.0.0.4";
1821 constexpr char listen_udp[] = "53";
1822 constexpr char listen_tls[] = "853";
1823 constexpr char host_name1[] = "tlsfailover1.example.com.";
1824 constexpr char host_name2[] = "tlsfailover2.example.com.";
1825 const std::vector<DnsRecord> records1 = {
1826 {host_name1, ns_type::ns_t_a, "1.2.3.1"},
1827 {host_name2, ns_type::ns_t_a, "1.2.3.2"},
1828 };
1829 const std::vector<DnsRecord> records2 = {
1830 {host_name1, ns_type::ns_t_a, "1.2.3.3"},
1831 {host_name2, ns_type::ns_t_a, "1.2.3.4"},
1832 };
1833
1834 test::DNSResponder dns1(listen_addr1);
1835 test::DNSResponder dns2(listen_addr2);
1836 StartDns(dns1, records1);
1837 StartDns(dns2, records2);
1838
Luke Huangf8215372019-11-22 11:53:41 +08001839 std::vector<std::string> servers = {listen_addr1, listen_addr2};
Ken Chenb9fa2062018-11-13 21:51:13 +08001840
1841 test::DnsTlsFrontend tls1(listen_addr1, listen_tls, listen_addr1, listen_udp);
1842 test::DnsTlsFrontend tls2(listen_addr2, listen_tls, listen_addr2, listen_udp);
1843 ASSERT_TRUE(tls1.startServer());
1844 ASSERT_TRUE(tls2.startServer());
waynema0e73c2e2019-07-31 15:04:08 +08001845 ASSERT_TRUE(mDnsClient.SetResolversWithTls(servers, kDefaultSearchDomains, kDefaultParams,
1846 kDefaultPrivateDnsHostName));
Mike Yu724f77d2019-08-16 11:14:50 +08001847 EXPECT_TRUE(WaitForPrivateDnsValidation(tls1.listen_address(), true));
1848 EXPECT_TRUE(WaitForPrivateDnsValidation(tls2.listen_address(), true));
Ken Chenb9fa2062018-11-13 21:51:13 +08001849
Mike Yu724f77d2019-08-16 11:14:50 +08001850 const hostent* result = gethostbyname("tlsfailover1");
Ken Chenb9fa2062018-11-13 21:51:13 +08001851 ASSERT_FALSE(result == nullptr);
1852 EXPECT_EQ("1.2.3.1", ToString(result));
1853
1854 // Wait for query to get counted.
Bernie Innocenti0ad80e92020-01-23 22:20:44 +09001855 EXPECT_TRUE(tls1.waitForQueries(2));
Ken Chenb9fa2062018-11-13 21:51:13 +08001856 // No new queries should have reached tls2.
Luke Huang0a0870d2020-02-12 20:41:10 +08001857 EXPECT_TRUE(tls2.waitForQueries(1));
Ken Chenb9fa2062018-11-13 21:51:13 +08001858
1859 // Stop tls1. Subsequent queries should attempt to reach tls1, fail, and retry to tls2.
1860 tls1.stopServer();
1861
1862 result = gethostbyname("tlsfailover2");
1863 EXPECT_EQ("1.2.3.4", ToString(result));
1864
1865 // Wait for query to get counted.
Bernie Innocenti0ad80e92020-01-23 22:20:44 +09001866 EXPECT_TRUE(tls2.waitForQueries(2));
Ken Chenb9fa2062018-11-13 21:51:13 +08001867
1868 // No additional queries should have reached the insecure servers.
1869 EXPECT_EQ(2U, dns1.queries().size());
1870 EXPECT_EQ(2U, dns2.queries().size());
1871
1872 // Clear TLS bit.
Xiao Ma09b71022018-12-11 17:56:32 +09001873 ASSERT_TRUE(mDnsClient.SetResolversForNetwork(servers));
Ken Chenb9fa2062018-11-13 21:51:13 +08001874}
1875
1876TEST_F(ResolverTest, GetHostByName_BadTlsName) {
Xiao Ma09b71022018-12-11 17:56:32 +09001877 constexpr char listen_addr[] = "127.0.0.3";
1878 constexpr char listen_udp[] = "53";
1879 constexpr char listen_tls[] = "853";
1880 constexpr char host_name[] = "badtlsname.example.com.";
1881
1882 test::DNSResponder dns;
1883 StartDns(dns, {{host_name, ns_type::ns_t_a, "1.2.3.1"}});
Luke Huangf8215372019-11-22 11:53:41 +08001884 std::vector<std::string> servers = {listen_addr};
Ken Chenb9fa2062018-11-13 21:51:13 +08001885
1886 test::DnsTlsFrontend tls(listen_addr, listen_tls, listen_addr, listen_udp);
1887 ASSERT_TRUE(tls.startServer());
Xiao Ma09b71022018-12-11 17:56:32 +09001888 ASSERT_TRUE(mDnsClient.SetResolversWithTls(servers, kDefaultSearchDomains, kDefaultParams,
waynema0e73c2e2019-07-31 15:04:08 +08001889 kDefaultIncorrectPrivateDnsHostName));
Ken Chenb9fa2062018-11-13 21:51:13 +08001890
waynema0e73c2e2019-07-31 15:04:08 +08001891 // The TLS handshake would fail because the name of TLS server doesn't
1892 // match with TLS server's certificate.
Mike Yu724f77d2019-08-16 11:14:50 +08001893 EXPECT_TRUE(WaitForPrivateDnsValidation(tls.listen_address(), false));
Ken Chenb9fa2062018-11-13 21:51:13 +08001894
1895 // The query should fail hard, because a name was specified.
1896 EXPECT_EQ(nullptr, gethostbyname("badtlsname"));
1897
1898 // Clear TLS bit.
Xiao Ma09b71022018-12-11 17:56:32 +09001899 ASSERT_TRUE(mDnsClient.SetResolversForNetwork());
Ken Chenb9fa2062018-11-13 21:51:13 +08001900}
1901
1902TEST_F(ResolverTest, GetAddrInfo_Tls) {
Xiao Ma09b71022018-12-11 17:56:32 +09001903 constexpr char listen_addr[] = "127.0.0.3";
1904 constexpr char listen_udp[] = "53";
1905 constexpr char listen_tls[] = "853";
1906 constexpr char host_name[] = "addrinfotls.example.com.";
1907 const std::vector<DnsRecord> records = {
1908 {host_name, ns_type::ns_t_a, "1.2.3.4"},
1909 {host_name, ns_type::ns_t_aaaa, "::1.2.3.4"},
1910 };
1911
1912 test::DNSResponder dns;
1913 StartDns(dns, records);
Luke Huangf8215372019-11-22 11:53:41 +08001914 std::vector<std::string> servers = {listen_addr};
Ken Chenb9fa2062018-11-13 21:51:13 +08001915
1916 test::DnsTlsFrontend tls(listen_addr, listen_tls, listen_addr, listen_udp);
1917 ASSERT_TRUE(tls.startServer());
waynema0e73c2e2019-07-31 15:04:08 +08001918 ASSERT_TRUE(mDnsClient.SetResolversWithTls(servers, kDefaultSearchDomains, kDefaultParams,
1919 kDefaultPrivateDnsHostName));
Mike Yu724f77d2019-08-16 11:14:50 +08001920 EXPECT_TRUE(WaitForPrivateDnsValidation(tls.listen_address(), true));
Ken Chenb9fa2062018-11-13 21:51:13 +08001921
1922 dns.clearQueries();
1923 ScopedAddrinfo result = safe_getaddrinfo("addrinfotls", nullptr, nullptr);
1924 EXPECT_TRUE(result != nullptr);
1925 size_t found = GetNumQueries(dns, host_name);
1926 EXPECT_LE(1U, found);
1927 // Could be A or AAAA
1928 std::string result_str = ToString(result);
1929 EXPECT_TRUE(result_str == "1.2.3.4" || result_str == "::1.2.3.4")
Luke Huangf8215372019-11-22 11:53:41 +08001930 << ", result_str='" << result_str << "'";
Ken Chenb9fa2062018-11-13 21:51:13 +08001931 // Wait for both A and AAAA queries to get counted.
Bernie Innocenti0ad80e92020-01-23 22:20:44 +09001932 EXPECT_TRUE(tls.waitForQueries(3));
Ken Chenb9fa2062018-11-13 21:51:13 +08001933
1934 // Clear TLS bit.
Xiao Ma09b71022018-12-11 17:56:32 +09001935 ASSERT_TRUE(mDnsClient.SetResolversForNetwork());
Ken Chenb9fa2062018-11-13 21:51:13 +08001936}
1937
1938TEST_F(ResolverTest, TlsBypass) {
1939 const char OFF[] = "off";
1940 const char OPPORTUNISTIC[] = "opportunistic";
1941 const char STRICT[] = "strict";
1942
1943 const char GETHOSTBYNAME[] = "gethostbyname";
1944 const char GETADDRINFO[] = "getaddrinfo";
1945 const char GETADDRINFOFORNET[] = "getaddrinfofornet";
1946
1947 const unsigned BYPASS_NETID = NETID_USE_LOCAL_NAMESERVERS | TEST_NETID;
1948
Ken Chenb9fa2062018-11-13 21:51:13 +08001949 const char ADDR4[] = "192.0.2.1";
1950 const char ADDR6[] = "2001:db8::1";
1951
1952 const char cleartext_addr[] = "127.0.0.53";
1953 const char cleartext_port[] = "53";
1954 const char tls_port[] = "853";
Luke Huangf8215372019-11-22 11:53:41 +08001955 const std::vector<std::string> servers = {cleartext_addr};
Ken Chenb9fa2062018-11-13 21:51:13 +08001956
Xiao Ma09b71022018-12-11 17:56:32 +09001957 test::DNSResponder dns(cleartext_addr);
Ken Chenb9fa2062018-11-13 21:51:13 +08001958 ASSERT_TRUE(dns.startServer());
1959
1960 test::DnsTlsFrontend tls(cleartext_addr, tls_port, cleartext_addr, cleartext_port);
Mike Yudd4ac2d2019-05-31 16:52:11 +08001961 ASSERT_TRUE(tls.startServer());
Ken Chenb9fa2062018-11-13 21:51:13 +08001962
Luke Huangf8215372019-11-22 11:53:41 +08001963 // clang-format off
Ken Chenb9fa2062018-11-13 21:51:13 +08001964 struct TestConfig {
1965 const std::string mode;
1966 const bool withWorkingTLS;
1967 const std::string method;
1968
1969 std::string asHostName() const {
Luke Huangf8215372019-11-22 11:53:41 +08001970 return StringPrintf("%s.%s.%s.", mode.c_str(), withWorkingTLS ? "tlsOn" : "tlsOff",
Ken Chenb9fa2062018-11-13 21:51:13 +08001971 method.c_str());
1972 }
1973 } testConfigs[]{
Ken Chenb9fa2062018-11-13 21:51:13 +08001974 {OFF, true, GETHOSTBYNAME},
1975 {OPPORTUNISTIC, true, GETHOSTBYNAME},
1976 {STRICT, true, GETHOSTBYNAME},
Ken Chenb9fa2062018-11-13 21:51:13 +08001977 {OFF, true, GETADDRINFO},
1978 {OPPORTUNISTIC, true, GETADDRINFO},
1979 {STRICT, true, GETADDRINFO},
Ken Chenb9fa2062018-11-13 21:51:13 +08001980 {OFF, true, GETADDRINFOFORNET},
1981 {OPPORTUNISTIC, true, GETADDRINFOFORNET},
1982 {STRICT, true, GETADDRINFOFORNET},
Mike Yudd4ac2d2019-05-31 16:52:11 +08001983 {OFF, false, GETHOSTBYNAME},
1984 {OPPORTUNISTIC, false, GETHOSTBYNAME},
1985 {STRICT, false, GETHOSTBYNAME},
1986 {OFF, false, GETADDRINFO},
1987 {OPPORTUNISTIC, false, GETADDRINFO},
1988 {STRICT, false, GETADDRINFO},
1989 {OFF, false, GETADDRINFOFORNET},
1990 {OPPORTUNISTIC, false, GETADDRINFOFORNET},
1991 {STRICT, false, GETADDRINFOFORNET},
Ken Chenb9fa2062018-11-13 21:51:13 +08001992 };
Luke Huangf8215372019-11-22 11:53:41 +08001993 // clang-format on
Ken Chenb9fa2062018-11-13 21:51:13 +08001994
1995 for (const auto& config : testConfigs) {
1996 const std::string testHostName = config.asHostName();
1997 SCOPED_TRACE(testHostName);
1998
1999 // Don't tempt test bugs due to caching.
2000 const char* host_name = testHostName.c_str();
2001 dns.addMapping(host_name, ns_type::ns_t_a, ADDR4);
2002 dns.addMapping(host_name, ns_type::ns_t_aaaa, ADDR6);
2003
Mike Yudd4ac2d2019-05-31 16:52:11 +08002004 if (config.withWorkingTLS) {
2005 if (!tls.running()) {
2006 ASSERT_TRUE(tls.startServer());
2007 }
2008 } else {
2009 if (tls.running()) {
2010 ASSERT_TRUE(tls.stopServer());
2011 }
2012 }
Ken Chenb9fa2062018-11-13 21:51:13 +08002013
2014 if (config.mode == OFF) {
Xiao Ma09b71022018-12-11 17:56:32 +09002015 ASSERT_TRUE(mDnsClient.SetResolversForNetwork(servers, kDefaultSearchDomains,
2016 kDefaultParams));
Bernie Innocenti0ad80e92020-01-23 22:20:44 +09002017 } else /* OPPORTUNISTIC or STRICT */ {
2018 const char* tls_hostname = (config.mode == STRICT) ? kDefaultPrivateDnsHostName : "";
Xiao Ma09b71022018-12-11 17:56:32 +09002019 ASSERT_TRUE(mDnsClient.SetResolversWithTls(servers, kDefaultSearchDomains,
Bernie Innocenti0ad80e92020-01-23 22:20:44 +09002020 kDefaultParams, tls_hostname));
Mike Yu724f77d2019-08-16 11:14:50 +08002021
2022 // Wait for the validation event. If the server is running, the validation should
Bernie Innocenti0ad80e92020-01-23 22:20:44 +09002023 // succeed; otherwise, the validation should fail.
Mike Yu724f77d2019-08-16 11:14:50 +08002024 EXPECT_TRUE(WaitForPrivateDnsValidation(tls.listen_address(), config.withWorkingTLS));
Bernie Innocenti0ad80e92020-01-23 22:20:44 +09002025 if (config.withWorkingTLS) {
2026 EXPECT_TRUE(tls.waitForQueries(1));
2027 tls.clearQueries();
2028 }
Ken Chenb9fa2062018-11-13 21:51:13 +08002029 }
Ken Chenb9fa2062018-11-13 21:51:13 +08002030
2031 const hostent* h_result = nullptr;
2032 ScopedAddrinfo ai_result;
2033
2034 if (config.method == GETHOSTBYNAME) {
2035 ASSERT_EQ(0, setNetworkForResolv(BYPASS_NETID));
2036 h_result = gethostbyname(host_name);
2037
2038 EXPECT_EQ(1U, GetNumQueriesForType(dns, ns_type::ns_t_a, host_name));
2039 ASSERT_FALSE(h_result == nullptr);
2040 ASSERT_EQ(4, h_result->h_length);
2041 ASSERT_FALSE(h_result->h_addr_list[0] == nullptr);
2042 EXPECT_EQ(ADDR4, ToString(h_result));
2043 EXPECT_TRUE(h_result->h_addr_list[1] == nullptr);
2044 } else if (config.method == GETADDRINFO) {
2045 ASSERT_EQ(0, setNetworkForResolv(BYPASS_NETID));
2046 ai_result = safe_getaddrinfo(host_name, nullptr, nullptr);
2047 EXPECT_TRUE(ai_result != nullptr);
2048
2049 EXPECT_LE(1U, GetNumQueries(dns, host_name));
2050 // Could be A or AAAA
2051 const std::string result_str = ToString(ai_result);
2052 EXPECT_TRUE(result_str == ADDR4 || result_str == ADDR6)
Luke Huangf8215372019-11-22 11:53:41 +08002053 << ", result_str='" << result_str << "'";
Ken Chenb9fa2062018-11-13 21:51:13 +08002054 } else if (config.method == GETADDRINFOFORNET) {
2055 addrinfo* raw_ai_result = nullptr;
2056 EXPECT_EQ(0, android_getaddrinfofornet(host_name, /*servname=*/nullptr,
2057 /*hints=*/nullptr, BYPASS_NETID, MARK_UNSET,
2058 &raw_ai_result));
2059 ai_result.reset(raw_ai_result);
2060
2061 EXPECT_LE(1U, GetNumQueries(dns, host_name));
2062 // Could be A or AAAA
2063 const std::string result_str = ToString(ai_result);
2064 EXPECT_TRUE(result_str == ADDR4 || result_str == ADDR6)
Luke Huangf8215372019-11-22 11:53:41 +08002065 << ", result_str='" << result_str << "'";
Ken Chenb9fa2062018-11-13 21:51:13 +08002066 }
2067
Mike Yudd4ac2d2019-05-31 16:52:11 +08002068 EXPECT_EQ(0, tls.queries());
Ken Chenb9fa2062018-11-13 21:51:13 +08002069
2070 // Clear per-process resolv netid.
2071 ASSERT_EQ(0, setNetworkForResolv(NETID_UNSET));
Ken Chenb9fa2062018-11-13 21:51:13 +08002072 dns.clearQueries();
2073 }
Ken Chenb9fa2062018-11-13 21:51:13 +08002074}
2075
2076TEST_F(ResolverTest, StrictMode_NoTlsServers) {
Xiao Ma09b71022018-12-11 17:56:32 +09002077 constexpr char cleartext_addr[] = "127.0.0.53";
Luke Huangf8215372019-11-22 11:53:41 +08002078 const std::vector<std::string> servers = {cleartext_addr};
Xiao Ma09b71022018-12-11 17:56:32 +09002079 constexpr char host_name[] = "strictmode.notlsips.example.com.";
2080 const std::vector<DnsRecord> records = {
2081 {host_name, ns_type::ns_t_a, "1.2.3.4"},
2082 {host_name, ns_type::ns_t_aaaa, "::1.2.3.4"},
2083 };
Ken Chenb9fa2062018-11-13 21:51:13 +08002084
Xiao Ma09b71022018-12-11 17:56:32 +09002085 test::DNSResponder dns(cleartext_addr);
2086 StartDns(dns, records);
Ken Chenb9fa2062018-11-13 21:51:13 +08002087
waynema0e73c2e2019-07-31 15:04:08 +08002088 ASSERT_TRUE(mDnsClient.SetResolversWithTls(servers, kDefaultSearchDomains, kDefaultParams,
2089 kDefaultIncorrectPrivateDnsHostName));
Ken Chenb9fa2062018-11-13 21:51:13 +08002090
2091 addrinfo* ai_result = nullptr;
2092 EXPECT_NE(0, getaddrinfo(host_name, nullptr, nullptr, &ai_result));
2093 EXPECT_EQ(0U, GetNumQueries(dns, host_name));
2094}
Luke Huang94b10b92018-11-21 20:13:38 +08002095
2096namespace {
2097
Luke Huang70931aa2019-01-31 11:57:41 +08002098int getAsyncResponse(int fd, int* rcode, uint8_t* buf, int bufLen) {
Luke Huang94b10b92018-11-21 20:13:38 +08002099 struct pollfd wait_fd[1];
2100 wait_fd[0].fd = fd;
2101 wait_fd[0].events = POLLIN;
2102 short revents;
2103 int ret;
2104
2105 ret = poll(wait_fd, 1, -1);
2106 revents = wait_fd[0].revents;
2107 if (revents & POLLIN) {
Mike Yub3505422020-10-15 16:10:41 +08002108 return resNetworkResult(fd, rcode, buf, bufLen);
Luke Huang94b10b92018-11-21 20:13:38 +08002109 }
2110 return -1;
2111}
2112
Luke Huang70931aa2019-01-31 11:57:41 +08002113std::string toString(uint8_t* buf, int bufLen, int ipType) {
Luke Huang94b10b92018-11-21 20:13:38 +08002114 ns_msg handle;
2115 int ancount, n = 0;
2116 ns_rr rr;
2117
Luke Huangf8215372019-11-22 11:53:41 +08002118 if (ns_initparse((const uint8_t*)buf, bufLen, &handle) >= 0) {
Luke Huang94b10b92018-11-21 20:13:38 +08002119 ancount = ns_msg_count(handle, ns_s_an);
2120 if (ns_parserr(&handle, ns_s_an, n, &rr) == 0) {
Luke Huang70931aa2019-01-31 11:57:41 +08002121 const uint8_t* rdata = ns_rr_rdata(rr);
Luke Huang94b10b92018-11-21 20:13:38 +08002122 char buffer[INET6_ADDRSTRLEN];
Luke Huangf8215372019-11-22 11:53:41 +08002123 if (inet_ntop(ipType, (const char*)rdata, buffer, sizeof(buffer))) {
Luke Huang94b10b92018-11-21 20:13:38 +08002124 return buffer;
2125 }
2126 }
2127 }
2128 return "";
2129}
2130
2131int dns_open_proxy() {
2132 int s = socket(AF_UNIX, SOCK_STREAM | SOCK_CLOEXEC, 0);
2133 if (s == -1) {
2134 return -1;
2135 }
2136 const int one = 1;
2137 setsockopt(s, SOL_SOCKET, SO_REUSEADDR, &one, sizeof(one));
2138
2139 static const struct sockaddr_un proxy_addr = {
2140 .sun_family = AF_UNIX,
2141 .sun_path = "/dev/socket/dnsproxyd",
2142 };
2143
Luke Huangf8215372019-11-22 11:53:41 +08002144 if (TEMP_FAILURE_RETRY(connect(s, (const struct sockaddr*)&proxy_addr, sizeof(proxy_addr))) !=
Luke Huang94b10b92018-11-21 20:13:38 +08002145 0) {
2146 close(s);
2147 return -1;
2148 }
2149
2150 return s;
2151}
2152
Luke Huangba7bef92018-12-26 16:53:03 +08002153void expectAnswersValid(int fd, int ipType, const std::string& expectedAnswer) {
2154 int rcode = -1;
2155 uint8_t buf[MAXPACKET] = {};
2156
2157 int res = getAsyncResponse(fd, &rcode, buf, MAXPACKET);
2158 EXPECT_GT(res, 0);
2159 EXPECT_EQ(expectedAnswer, toString(buf, res, ipType));
2160}
2161
2162void expectAnswersNotValid(int fd, int expectedErrno) {
2163 int rcode = -1;
2164 uint8_t buf[MAXPACKET] = {};
2165
2166 int res = getAsyncResponse(fd, &rcode, buf, MAXPACKET);
2167 EXPECT_EQ(expectedErrno, res);
2168}
2169
Luke Huang94b10b92018-11-21 20:13:38 +08002170} // namespace
2171
2172TEST_F(ResolverTest, Async_NormalQueryV4V6) {
Xiao Ma09b71022018-12-11 17:56:32 +09002173 constexpr char listen_addr[] = "127.0.0.4";
2174 constexpr char host_name[] = "howdy.example.com.";
2175 const std::vector<DnsRecord> records = {
2176 {host_name, ns_type::ns_t_a, "1.2.3.4"},
2177 {host_name, ns_type::ns_t_aaaa, "::1.2.3.4"},
2178 };
2179
2180 test::DNSResponder dns(listen_addr);
2181 StartDns(dns, records);
Luke Huang94b10b92018-11-21 20:13:38 +08002182 std::vector<std::string> servers = {listen_addr};
Xiao Ma09b71022018-12-11 17:56:32 +09002183 ASSERT_TRUE(mDnsClient.SetResolversForNetwork(servers));
Luke Huang94b10b92018-11-21 20:13:38 +08002184
Luke Huangba7bef92018-12-26 16:53:03 +08002185 int fd1 = resNetworkQuery(TEST_NETID, "howdy.example.com", ns_c_in, ns_t_a, 0);
2186 int fd2 = resNetworkQuery(TEST_NETID, "howdy.example.com", ns_c_in, ns_t_aaaa, 0);
Luke Huang94b10b92018-11-21 20:13:38 +08002187 EXPECT_TRUE(fd1 != -1);
2188 EXPECT_TRUE(fd2 != -1);
2189
Luke Huang70931aa2019-01-31 11:57:41 +08002190 uint8_t buf[MAXPACKET] = {};
Luke Huang94b10b92018-11-21 20:13:38 +08002191 int rcode;
2192 int res = getAsyncResponse(fd2, &rcode, buf, MAXPACKET);
2193 EXPECT_GT(res, 0);
2194 EXPECT_EQ("::1.2.3.4", toString(buf, res, AF_INET6));
2195
2196 res = getAsyncResponse(fd1, &rcode, buf, MAXPACKET);
2197 EXPECT_GT(res, 0);
2198 EXPECT_EQ("1.2.3.4", toString(buf, res, AF_INET));
2199
2200 EXPECT_EQ(2U, GetNumQueries(dns, host_name));
2201
2202 // Re-query verify cache works
Luke Huangba7bef92018-12-26 16:53:03 +08002203 fd1 = resNetworkQuery(TEST_NETID, "howdy.example.com", ns_c_in, ns_t_a, 0);
2204 fd2 = resNetworkQuery(TEST_NETID, "howdy.example.com", ns_c_in, ns_t_aaaa, 0);
Luke Huang94b10b92018-11-21 20:13:38 +08002205
2206 EXPECT_TRUE(fd1 != -1);
2207 EXPECT_TRUE(fd2 != -1);
2208
2209 res = getAsyncResponse(fd2, &rcode, buf, MAXPACKET);
2210 EXPECT_GT(res, 0);
2211 EXPECT_EQ("::1.2.3.4", toString(buf, res, AF_INET6));
2212
2213 res = getAsyncResponse(fd1, &rcode, buf, MAXPACKET);
2214 EXPECT_GT(res, 0);
2215 EXPECT_EQ("1.2.3.4", toString(buf, res, AF_INET));
2216
2217 EXPECT_EQ(2U, GetNumQueries(dns, host_name));
2218}
2219
2220TEST_F(ResolverTest, Async_BadQuery) {
Xiao Ma09b71022018-12-11 17:56:32 +09002221 constexpr char listen_addr[] = "127.0.0.4";
2222 constexpr char host_name[] = "howdy.example.com.";
2223 const std::vector<DnsRecord> records = {
2224 {host_name, ns_type::ns_t_a, "1.2.3.4"},
2225 {host_name, ns_type::ns_t_aaaa, "::1.2.3.4"},
2226 };
2227
2228 test::DNSResponder dns(listen_addr);
2229 StartDns(dns, records);
Luke Huang94b10b92018-11-21 20:13:38 +08002230 std::vector<std::string> servers = {listen_addr};
Xiao Ma09b71022018-12-11 17:56:32 +09002231 ASSERT_TRUE(mDnsClient.SetResolversForNetwork(servers));
Luke Huang94b10b92018-11-21 20:13:38 +08002232
2233 static struct {
2234 int fd;
2235 const char* dname;
2236 const int queryType;
2237 const int expectRcode;
2238 } kTestData[] = {
Luke Huangba7bef92018-12-26 16:53:03 +08002239 {-1, "", ns_t_aaaa, 0},
2240 {-1, "as65ass46", ns_t_aaaa, 0},
2241 {-1, "454564564564", ns_t_aaaa, 0},
2242 {-1, "h645235", ns_t_a, 0},
2243 {-1, "www.google.com", ns_t_a, 0},
Luke Huang94b10b92018-11-21 20:13:38 +08002244 };
2245
2246 for (auto& td : kTestData) {
2247 SCOPED_TRACE(td.dname);
Luke Huangba7bef92018-12-26 16:53:03 +08002248 td.fd = resNetworkQuery(TEST_NETID, td.dname, ns_c_in, td.queryType, 0);
Luke Huang94b10b92018-11-21 20:13:38 +08002249 EXPECT_TRUE(td.fd != -1);
2250 }
2251
2252 // dns_responder return empty resp(packet only contains query part) with no error currently
2253 for (const auto& td : kTestData) {
Luke Huang70931aa2019-01-31 11:57:41 +08002254 uint8_t buf[MAXPACKET] = {};
Luke Huang94b10b92018-11-21 20:13:38 +08002255 int rcode;
2256 SCOPED_TRACE(td.dname);
2257 int res = getAsyncResponse(td.fd, &rcode, buf, MAXPACKET);
2258 EXPECT_GT(res, 0);
2259 EXPECT_EQ(rcode, td.expectRcode);
2260 }
2261}
2262
2263TEST_F(ResolverTest, Async_EmptyAnswer) {
Xiao Ma09b71022018-12-11 17:56:32 +09002264 constexpr char listen_addr[] = "127.0.0.4";
2265 constexpr char host_name[] = "howdy.example.com.";
2266 const std::vector<DnsRecord> records = {
2267 {host_name, ns_type::ns_t_a, "1.2.3.4"},
2268 {host_name, ns_type::ns_t_aaaa, "::1.2.3.4"},
2269 };
2270
2271 test::DNSResponder dns(listen_addr);
2272 StartDns(dns, records);
Luke Huang94b10b92018-11-21 20:13:38 +08002273 std::vector<std::string> servers = {listen_addr};
Xiao Ma09b71022018-12-11 17:56:32 +09002274 ASSERT_TRUE(mDnsClient.SetResolversForNetwork(servers));
Luke Huang94b10b92018-11-21 20:13:38 +08002275
Luke Huang9c264bb2018-12-18 16:44:41 +08002276 // TODO: Disable retry to make this test explicit.
2277 auto& cv = dns.getCv();
2278 auto& cvMutex = dns.getCvMutex();
2279 int fd1;
2280 // Wait on the condition variable to ensure that the DNS server has handled our first query.
2281 {
2282 std::unique_lock lk(cvMutex);
Luke Huangba7bef92018-12-26 16:53:03 +08002283 fd1 = resNetworkQuery(TEST_NETID, "howdy.example.com", ns_c_in, ns_t_aaaa, 0);
Luke Huang9c264bb2018-12-18 16:44:41 +08002284 EXPECT_TRUE(fd1 != -1);
2285 EXPECT_EQ(std::cv_status::no_timeout, cv.wait_for(lk, std::chrono::seconds(1)));
2286 }
Luke Huang94b10b92018-11-21 20:13:38 +08002287
Luke Huang94b10b92018-11-21 20:13:38 +08002288 dns.setResponseProbability(0.0);
Luke Huang94b10b92018-11-21 20:13:38 +08002289
Luke Huangba7bef92018-12-26 16:53:03 +08002290 int fd2 = resNetworkQuery(TEST_NETID, "howdy.example.com", ns_c_in, ns_t_a, 0);
Luke Huang94b10b92018-11-21 20:13:38 +08002291 EXPECT_TRUE(fd2 != -1);
2292
Luke Huangba7bef92018-12-26 16:53:03 +08002293 int fd3 = resNetworkQuery(TEST_NETID, "howdy.example.com", ns_c_in, ns_t_a, 0);
Luke Huang94b10b92018-11-21 20:13:38 +08002294 EXPECT_TRUE(fd3 != -1);
2295
Luke Huang9c264bb2018-12-18 16:44:41 +08002296 uint8_t buf[MAXPACKET] = {};
Luke Huang94b10b92018-11-21 20:13:38 +08002297 int rcode;
2298
Luke Huang9c264bb2018-12-18 16:44:41 +08002299 // expect no response
2300 int res = getAsyncResponse(fd3, &rcode, buf, MAXPACKET);
2301 EXPECT_EQ(-ETIMEDOUT, res);
Luke Huang94b10b92018-11-21 20:13:38 +08002302
Luke Huang9c264bb2018-12-18 16:44:41 +08002303 // expect no response
Luke Huang94b10b92018-11-21 20:13:38 +08002304 memset(buf, 0, MAXPACKET);
Luke Huang9c264bb2018-12-18 16:44:41 +08002305 res = getAsyncResponse(fd2, &rcode, buf, MAXPACKET);
2306 EXPECT_EQ(-ETIMEDOUT, res);
Luke Huang94b10b92018-11-21 20:13:38 +08002307
Luke Huang94b10b92018-11-21 20:13:38 +08002308 dns.setResponseProbability(1.0);
Luke Huang94b10b92018-11-21 20:13:38 +08002309
Luke Huangba7bef92018-12-26 16:53:03 +08002310 int fd4 = resNetworkQuery(TEST_NETID, "howdy.example.com", ns_c_in, ns_t_a, 0);
Luke Huang94b10b92018-11-21 20:13:38 +08002311 EXPECT_TRUE(fd4 != -1);
2312
2313 memset(buf, 0, MAXPACKET);
2314 res = getAsyncResponse(fd4, &rcode, buf, MAXPACKET);
2315 EXPECT_GT(res, 0);
2316 EXPECT_EQ("1.2.3.4", toString(buf, res, AF_INET));
2317
2318 memset(buf, 0, MAXPACKET);
2319 res = getAsyncResponse(fd1, &rcode, buf, MAXPACKET);
2320 EXPECT_GT(res, 0);
2321 EXPECT_EQ("::1.2.3.4", toString(buf, res, AF_INET6));
Mike Yu532405f2020-06-17 17:46:44 +08002322
2323 // Trailing dot is removed. Is it intended?
2324 ExpectDnsEvent(INetdEventListener::EVENT_RES_NSEND, 0, "howdy.example.com", {"::1.2.3.4"});
2325 ExpectDnsEvent(INetdEventListener::EVENT_RES_NSEND, RCODE_TIMEOUT, "howdy.example.com", {});
2326 ExpectDnsEvent(INetdEventListener::EVENT_RES_NSEND, RCODE_TIMEOUT, "howdy.example.com", {});
2327 ExpectDnsEvent(INetdEventListener::EVENT_RES_NSEND, 0, "howdy.example.com", {"1.2.3.4"});
Luke Huang94b10b92018-11-21 20:13:38 +08002328}
2329
2330TEST_F(ResolverTest, Async_MalformedQuery) {
Xiao Ma09b71022018-12-11 17:56:32 +09002331 constexpr char listen_addr[] = "127.0.0.4";
2332 constexpr char host_name[] = "howdy.example.com.";
2333 const std::vector<DnsRecord> records = {
2334 {host_name, ns_type::ns_t_a, "1.2.3.4"},
2335 {host_name, ns_type::ns_t_aaaa, "::1.2.3.4"},
2336 };
2337
2338 test::DNSResponder dns(listen_addr);
2339 StartDns(dns, records);
Luke Huang94b10b92018-11-21 20:13:38 +08002340 std::vector<std::string> servers = {listen_addr};
Xiao Ma09b71022018-12-11 17:56:32 +09002341 ASSERT_TRUE(mDnsClient.SetResolversForNetwork(servers));
Luke Huang94b10b92018-11-21 20:13:38 +08002342
2343 int fd = dns_open_proxy();
2344 EXPECT_TRUE(fd > 0);
2345
2346 const std::string badMsg = "16-52512#";
Xiao Ma09b71022018-12-11 17:56:32 +09002347 static const struct {
Luke Huang94b10b92018-11-21 20:13:38 +08002348 const std::string cmd;
2349 const int expectErr;
2350 } kTestData[] = {
Luke Huangba7bef92018-12-26 16:53:03 +08002351 // Too few arguments
Luke Huang94b10b92018-11-21 20:13:38 +08002352 {"resnsend " + badMsg + '\0', -EINVAL},
2353 // Bad netId
Luke Huangba7bef92018-12-26 16:53:03 +08002354 {"resnsend badnetId 0 " + badMsg + '\0', -EINVAL},
Luke Huang94b10b92018-11-21 20:13:38 +08002355 // Bad raw data
Luke Huangba7bef92018-12-26 16:53:03 +08002356 {"resnsend " + std::to_string(TEST_NETID) + " 0 " + badMsg + '\0', -EILSEQ},
Luke Huang94b10b92018-11-21 20:13:38 +08002357 };
2358
2359 for (unsigned int i = 0; i < std::size(kTestData); i++) {
2360 auto& td = kTestData[i];
2361 SCOPED_TRACE(td.cmd);
2362 ssize_t rc = TEMP_FAILURE_RETRY(write(fd, td.cmd.c_str(), td.cmd.size()));
2363 EXPECT_EQ(rc, static_cast<ssize_t>(td.cmd.size()));
2364
2365 int32_t tmp;
2366 rc = TEMP_FAILURE_RETRY(read(fd, &tmp, sizeof(tmp)));
2367 EXPECT_TRUE(rc > 0);
2368 EXPECT_EQ(static_cast<int>(ntohl(tmp)), td.expectErr);
2369 }
2370 // Normal query with answer buffer
2371 // This is raw data of query "howdy.example.com" type 1 class 1
2372 std::string query = "81sBAAABAAAAAAAABWhvd2R5B2V4YW1wbGUDY29tAAABAAE=";
Luke Huangba7bef92018-12-26 16:53:03 +08002373 std::string cmd = "resnsend " + std::to_string(TEST_NETID) + " 0 " + query + '\0';
Luke Huang94b10b92018-11-21 20:13:38 +08002374 ssize_t rc = TEMP_FAILURE_RETRY(write(fd, cmd.c_str(), cmd.size()));
2375 EXPECT_EQ(rc, static_cast<ssize_t>(cmd.size()));
2376
Luke Huang70931aa2019-01-31 11:57:41 +08002377 uint8_t smallBuf[1] = {};
Luke Huang94b10b92018-11-21 20:13:38 +08002378 int rcode;
2379 rc = getAsyncResponse(fd, &rcode, smallBuf, 1);
Luke Huangba7bef92018-12-26 16:53:03 +08002380 EXPECT_EQ(-EMSGSIZE, rc);
Luke Huang94b10b92018-11-21 20:13:38 +08002381
2382 // Do the normal test with large buffer again
2383 fd = dns_open_proxy();
2384 EXPECT_TRUE(fd > 0);
2385 rc = TEMP_FAILURE_RETRY(write(fd, cmd.c_str(), cmd.size()));
2386 EXPECT_EQ(rc, static_cast<ssize_t>(cmd.size()));
Luke Huang70931aa2019-01-31 11:57:41 +08002387 uint8_t buf[MAXPACKET] = {};
Luke Huang94b10b92018-11-21 20:13:38 +08002388 rc = getAsyncResponse(fd, &rcode, buf, MAXPACKET);
2389 EXPECT_EQ("1.2.3.4", toString(buf, rc, AF_INET));
Mike Yu4f3747b2018-12-02 17:54:29 +09002390}
2391
Luke Huangba7bef92018-12-26 16:53:03 +08002392TEST_F(ResolverTest, Async_CacheFlags) {
Xiao Ma09b71022018-12-11 17:56:32 +09002393 constexpr char listen_addr[] = "127.0.0.4";
Luke Huang4eabbe32020-05-28 03:17:32 +08002394 constexpr char host_name1[] = "howdy.example.com.";
2395 constexpr char host_name2[] = "howdy.example2.com.";
2396 constexpr char host_name3[] = "howdy.example3.com.";
Xiao Ma09b71022018-12-11 17:56:32 +09002397 const std::vector<DnsRecord> records = {
Luke Huang4eabbe32020-05-28 03:17:32 +08002398 {host_name1, ns_type::ns_t_a, "1.2.3.4"}, {host_name1, ns_type::ns_t_aaaa, "::1.2.3.4"},
2399 {host_name2, ns_type::ns_t_a, "1.2.3.5"}, {host_name2, ns_type::ns_t_aaaa, "::1.2.3.5"},
2400 {host_name3, ns_type::ns_t_a, "1.2.3.6"}, {host_name3, ns_type::ns_t_aaaa, "::1.2.3.6"},
Xiao Ma09b71022018-12-11 17:56:32 +09002401 };
2402
2403 test::DNSResponder dns(listen_addr);
2404 StartDns(dns, records);
Luke Huangba7bef92018-12-26 16:53:03 +08002405 std::vector<std::string> servers = {listen_addr};
Xiao Ma09b71022018-12-11 17:56:32 +09002406 ASSERT_TRUE(mDnsClient.SetResolversForNetwork(servers));
Luke Huangba7bef92018-12-26 16:53:03 +08002407
2408 // ANDROID_RESOLV_NO_CACHE_STORE
2409 int fd1 = resNetworkQuery(TEST_NETID, "howdy.example.com", ns_c_in, ns_t_a,
2410 ANDROID_RESOLV_NO_CACHE_STORE);
2411 EXPECT_TRUE(fd1 != -1);
2412 int fd2 = resNetworkQuery(TEST_NETID, "howdy.example.com", ns_c_in, ns_t_a,
2413 ANDROID_RESOLV_NO_CACHE_STORE);
2414 EXPECT_TRUE(fd2 != -1);
2415 int fd3 = resNetworkQuery(TEST_NETID, "howdy.example.com", ns_c_in, ns_t_a,
2416 ANDROID_RESOLV_NO_CACHE_STORE);
2417 EXPECT_TRUE(fd3 != -1);
2418
2419 expectAnswersValid(fd3, AF_INET, "1.2.3.4");
2420 expectAnswersValid(fd2, AF_INET, "1.2.3.4");
2421 expectAnswersValid(fd1, AF_INET, "1.2.3.4");
2422
2423 // No cache exists, expect 3 queries
Luke Huang4eabbe32020-05-28 03:17:32 +08002424 EXPECT_EQ(3U, GetNumQueries(dns, host_name1));
Luke Huangba7bef92018-12-26 16:53:03 +08002425
Luke Huang4eabbe32020-05-28 03:17:32 +08002426 // Raise a query with no flags to ensure no cache exists. Also make an cache entry for the
2427 // query.
Luke Huangba7bef92018-12-26 16:53:03 +08002428 fd1 = resNetworkQuery(TEST_NETID, "howdy.example.com", ns_c_in, ns_t_a, 0);
2429
2430 EXPECT_TRUE(fd1 != -1);
2431
2432 expectAnswersValid(fd1, AF_INET, "1.2.3.4");
2433
Luke Huang4eabbe32020-05-28 03:17:32 +08002434 // Expect 4 queries because there should be no cache before this query.
2435 EXPECT_EQ(4U, GetNumQueries(dns, host_name1));
2436
2437 // Now we have the cache entry, re-query with ANDROID_RESOLV_NO_CACHE_STORE to ensure
2438 // that ANDROID_RESOLV_NO_CACHE_STORE implied ANDROID_RESOLV_NO_CACHE_LOOKUP.
2439 fd1 = resNetworkQuery(TEST_NETID, "howdy.example.com", ns_c_in, ns_t_a,
2440 ANDROID_RESOLV_NO_CACHE_STORE);
2441 EXPECT_TRUE(fd1 != -1);
2442 expectAnswersValid(fd1, AF_INET, "1.2.3.4");
2443 // Expect 5 queries because we shouldn't do cache lookup for the query which has
2444 // ANDROID_RESOLV_NO_CACHE_STORE.
2445 EXPECT_EQ(5U, GetNumQueries(dns, host_name1));
Luke Huangba7bef92018-12-26 16:53:03 +08002446
2447 // ANDROID_RESOLV_NO_CACHE_LOOKUP
2448 fd1 = resNetworkQuery(TEST_NETID, "howdy.example.com", ns_c_in, ns_t_a,
2449 ANDROID_RESOLV_NO_CACHE_LOOKUP);
2450 fd2 = resNetworkQuery(TEST_NETID, "howdy.example.com", ns_c_in, ns_t_a,
2451 ANDROID_RESOLV_NO_CACHE_LOOKUP);
2452
2453 EXPECT_TRUE(fd1 != -1);
2454 EXPECT_TRUE(fd2 != -1);
2455
2456 expectAnswersValid(fd2, AF_INET, "1.2.3.4");
2457 expectAnswersValid(fd1, AF_INET, "1.2.3.4");
2458
Luke Huang4eabbe32020-05-28 03:17:32 +08002459 // Cache was skipped, expect 2 more queries.
2460 EXPECT_EQ(7U, GetNumQueries(dns, host_name1));
Luke Huangba7bef92018-12-26 16:53:03 +08002461
2462 // Re-query verify cache works
Luke Huang4eabbe32020-05-28 03:17:32 +08002463 fd1 = resNetworkQuery(TEST_NETID, "howdy.example.com", ns_c_in, ns_t_a, 0);
Luke Huangba7bef92018-12-26 16:53:03 +08002464 EXPECT_TRUE(fd1 != -1);
2465 expectAnswersValid(fd1, AF_INET, "1.2.3.4");
2466
Luke Huang4eabbe32020-05-28 03:17:32 +08002467 // Cache hits, expect still 7 queries
2468 EXPECT_EQ(7U, GetNumQueries(dns, host_name1));
Luke Huanga1d74182019-03-19 17:30:36 +08002469
2470 // Start to verify if ANDROID_RESOLV_NO_CACHE_LOOKUP does write response into cache
2471 dns.clearQueries();
2472
Luke Huang4eabbe32020-05-28 03:17:32 +08002473 fd1 = resNetworkQuery(TEST_NETID, "howdy.example2.com", ns_c_in, ns_t_aaaa,
Luke Huanga1d74182019-03-19 17:30:36 +08002474 ANDROID_RESOLV_NO_CACHE_LOOKUP);
Luke Huang4eabbe32020-05-28 03:17:32 +08002475 fd2 = resNetworkQuery(TEST_NETID, "howdy.example2.com", ns_c_in, ns_t_aaaa,
Luke Huanga1d74182019-03-19 17:30:36 +08002476 ANDROID_RESOLV_NO_CACHE_LOOKUP);
2477
2478 EXPECT_TRUE(fd1 != -1);
2479 EXPECT_TRUE(fd2 != -1);
2480
Luke Huang4eabbe32020-05-28 03:17:32 +08002481 expectAnswersValid(fd2, AF_INET6, "::1.2.3.5");
2482 expectAnswersValid(fd1, AF_INET6, "::1.2.3.5");
Luke Huanga1d74182019-03-19 17:30:36 +08002483
2484 // Skip cache, expect 2 queries
Luke Huang4eabbe32020-05-28 03:17:32 +08002485 EXPECT_EQ(2U, GetNumQueries(dns, host_name2));
Luke Huanga1d74182019-03-19 17:30:36 +08002486
2487 // Re-query without flags
Luke Huang4eabbe32020-05-28 03:17:32 +08002488 fd1 = resNetworkQuery(TEST_NETID, "howdy.example2.com", ns_c_in, ns_t_aaaa, 0);
2489 fd2 = resNetworkQuery(TEST_NETID, "howdy.example2.com", ns_c_in, ns_t_aaaa, 0);
Luke Huanga1d74182019-03-19 17:30:36 +08002490
2491 EXPECT_TRUE(fd1 != -1);
2492 EXPECT_TRUE(fd2 != -1);
2493
Luke Huang4eabbe32020-05-28 03:17:32 +08002494 expectAnswersValid(fd2, AF_INET6, "::1.2.3.5");
2495 expectAnswersValid(fd1, AF_INET6, "::1.2.3.5");
Luke Huanga1d74182019-03-19 17:30:36 +08002496
2497 // Cache hits, expect still 2 queries
Luke Huang4eabbe32020-05-28 03:17:32 +08002498 EXPECT_EQ(2U, GetNumQueries(dns, host_name2));
Luke Huang40f5f492019-05-09 19:37:35 +08002499
2500 // Test both ANDROID_RESOLV_NO_CACHE_STORE and ANDROID_RESOLV_NO_CACHE_LOOKUP are set
2501 dns.clearQueries();
2502
Luke Huang4eabbe32020-05-28 03:17:32 +08002503 // Make sure that the cache of "howdy.example3.com" exists.
2504 fd1 = resNetworkQuery(TEST_NETID, "howdy.example3.com", ns_c_in, ns_t_aaaa, 0);
Luke Huang40f5f492019-05-09 19:37:35 +08002505 EXPECT_TRUE(fd1 != -1);
Luke Huang4eabbe32020-05-28 03:17:32 +08002506 expectAnswersValid(fd1, AF_INET6, "::1.2.3.6");
2507 EXPECT_EQ(1U, GetNumQueries(dns, host_name3));
Luke Huang40f5f492019-05-09 19:37:35 +08002508
2509 // Re-query with testFlags
2510 const int testFlag = ANDROID_RESOLV_NO_CACHE_STORE | ANDROID_RESOLV_NO_CACHE_LOOKUP;
Luke Huang4eabbe32020-05-28 03:17:32 +08002511 fd1 = resNetworkQuery(TEST_NETID, "howdy.example3.com", ns_c_in, ns_t_aaaa, testFlag);
Luke Huang40f5f492019-05-09 19:37:35 +08002512 EXPECT_TRUE(fd1 != -1);
Luke Huang4eabbe32020-05-28 03:17:32 +08002513 expectAnswersValid(fd1, AF_INET6, "::1.2.3.6");
Luke Huang40f5f492019-05-09 19:37:35 +08002514 // Expect cache lookup is skipped.
Luke Huang4eabbe32020-05-28 03:17:32 +08002515 EXPECT_EQ(2U, GetNumQueries(dns, host_name3));
Luke Huang40f5f492019-05-09 19:37:35 +08002516
2517 // Do another query with testFlags
Luke Huang4eabbe32020-05-28 03:17:32 +08002518 fd1 = resNetworkQuery(TEST_NETID, "howdy.example3.com", ns_c_in, ns_t_a, testFlag);
Luke Huang40f5f492019-05-09 19:37:35 +08002519 EXPECT_TRUE(fd1 != -1);
Luke Huang4eabbe32020-05-28 03:17:32 +08002520 expectAnswersValid(fd1, AF_INET, "1.2.3.6");
Luke Huang40f5f492019-05-09 19:37:35 +08002521 // Expect cache lookup is skipped.
Luke Huang4eabbe32020-05-28 03:17:32 +08002522 EXPECT_EQ(3U, GetNumQueries(dns, host_name3));
Luke Huang40f5f492019-05-09 19:37:35 +08002523
2524 // Re-query with no flags
Luke Huang4eabbe32020-05-28 03:17:32 +08002525 fd1 = resNetworkQuery(TEST_NETID, "howdy.example3.com", ns_c_in, ns_t_a, 0);
Luke Huang40f5f492019-05-09 19:37:35 +08002526 EXPECT_TRUE(fd1 != -1);
Luke Huang4eabbe32020-05-28 03:17:32 +08002527 expectAnswersValid(fd1, AF_INET, "1.2.3.6");
Luke Huang40f5f492019-05-09 19:37:35 +08002528 // Expect no cache hit because cache storing is also skipped in previous query.
Luke Huang4eabbe32020-05-28 03:17:32 +08002529 EXPECT_EQ(4U, GetNumQueries(dns, host_name3));
Luke Huangba7bef92018-12-26 16:53:03 +08002530}
2531
Luke Huang08b13d22020-02-05 14:46:21 +08002532TEST_F(ResolverTest, Async_NoCacheStoreFlagDoesNotRefreshStaleCacheEntry) {
2533 constexpr char listen_addr[] = "127.0.0.4";
2534 constexpr char host_name[] = "howdy.example.com.";
2535 const std::vector<DnsRecord> records = {
2536 {host_name, ns_type::ns_t_a, "1.2.3.4"},
2537 };
2538
2539 test::DNSResponder dns(listen_addr);
2540 StartDns(dns, records);
2541 std::vector<std::string> servers = {listen_addr};
2542 ASSERT_TRUE(mDnsClient.SetResolversForNetwork(servers));
2543
2544 const unsigned SHORT_TTL_SEC = 1;
2545 dns.setTtl(SHORT_TTL_SEC);
2546
2547 // Refer to b/148842821 for the purpose of below test steps.
2548 // Basically, this test is used to ensure stale cache case is handled
2549 // correctly with ANDROID_RESOLV_NO_CACHE_STORE.
2550 int fd = resNetworkQuery(TEST_NETID, "howdy.example.com", ns_c_in, ns_t_a, 0);
2551 EXPECT_TRUE(fd != -1);
2552 expectAnswersValid(fd, AF_INET, "1.2.3.4");
2553
2554 EXPECT_EQ(1U, GetNumQueries(dns, host_name));
2555 dns.clearQueries();
2556
2557 // Wait until cache expired
2558 sleep(SHORT_TTL_SEC + 0.5);
2559
2560 // Now request the same hostname again.
2561 // We should see a new DNS query because the entry in cache has become stale.
2562 // Due to ANDROID_RESOLV_NO_CACHE_STORE, this query must *not* refresh that stale entry.
2563 fd = resNetworkQuery(TEST_NETID, "howdy.example.com", ns_c_in, ns_t_a,
2564 ANDROID_RESOLV_NO_CACHE_STORE);
2565 EXPECT_TRUE(fd != -1);
2566 expectAnswersValid(fd, AF_INET, "1.2.3.4");
2567 EXPECT_EQ(1U, GetNumQueries(dns, host_name));
2568 dns.clearQueries();
2569
2570 // If the cache is still stale, we expect to see one more DNS query
2571 // (this time the cache will be refreshed, but we're not checking for it).
2572 fd = resNetworkQuery(TEST_NETID, "howdy.example.com", ns_c_in, ns_t_a, 0);
2573 EXPECT_TRUE(fd != -1);
2574 expectAnswersValid(fd, AF_INET, "1.2.3.4");
2575 EXPECT_EQ(1U, GetNumQueries(dns, host_name));
2576}
2577
Luke Huangba7bef92018-12-26 16:53:03 +08002578TEST_F(ResolverTest, Async_NoRetryFlag) {
Luke Huang70931aa2019-01-31 11:57:41 +08002579 constexpr char listen_addr0[] = "127.0.0.4";
2580 constexpr char listen_addr1[] = "127.0.0.6";
Xiao Ma09b71022018-12-11 17:56:32 +09002581 constexpr char host_name[] = "howdy.example.com.";
2582 const std::vector<DnsRecord> records = {
2583 {host_name, ns_type::ns_t_a, "1.2.3.4"},
2584 {host_name, ns_type::ns_t_aaaa, "::1.2.3.4"},
2585 };
2586
Luke Huang70931aa2019-01-31 11:57:41 +08002587 test::DNSResponder dns0(listen_addr0);
2588 test::DNSResponder dns1(listen_addr1);
2589 StartDns(dns0, records);
2590 StartDns(dns1, records);
2591 ASSERT_TRUE(mDnsClient.SetResolversForNetwork({listen_addr0, listen_addr1}));
Luke Huangba7bef92018-12-26 16:53:03 +08002592
Luke Huang70931aa2019-01-31 11:57:41 +08002593 dns0.clearQueries();
2594 dns1.clearQueries();
2595
2596 dns0.setResponseProbability(0.0);
2597 dns1.setResponseProbability(0.0);
Luke Huangba7bef92018-12-26 16:53:03 +08002598
2599 int fd1 = resNetworkQuery(TEST_NETID, "howdy.example.com", ns_c_in, ns_t_a,
2600 ANDROID_RESOLV_NO_RETRY);
2601 EXPECT_TRUE(fd1 != -1);
2602
2603 int fd2 = resNetworkQuery(TEST_NETID, "howdy.example.com", ns_c_in, ns_t_aaaa,
2604 ANDROID_RESOLV_NO_RETRY);
2605 EXPECT_TRUE(fd2 != -1);
2606
2607 // expect no response
2608 expectAnswersNotValid(fd1, -ETIMEDOUT);
2609 expectAnswersNotValid(fd2, -ETIMEDOUT);
Mike Yu532405f2020-06-17 17:46:44 +08002610 ExpectDnsEvent(INetdEventListener::EVENT_RES_NSEND, RCODE_TIMEOUT, "howdy.example.com", {});
2611 ExpectDnsEvent(INetdEventListener::EVENT_RES_NSEND, RCODE_TIMEOUT, "howdy.example.com", {});
Luke Huangba7bef92018-12-26 16:53:03 +08002612
Luke Huang70931aa2019-01-31 11:57:41 +08002613 // No retry case, expect total 2 queries. The server is selected randomly.
2614 EXPECT_EQ(2U, GetNumQueries(dns0, host_name) + GetNumQueries(dns1, host_name));
Luke Huangba7bef92018-12-26 16:53:03 +08002615
Luke Huang70931aa2019-01-31 11:57:41 +08002616 dns0.clearQueries();
2617 dns1.clearQueries();
Luke Huangba7bef92018-12-26 16:53:03 +08002618
2619 fd1 = resNetworkQuery(TEST_NETID, "howdy.example.com", ns_c_in, ns_t_a, 0);
2620 EXPECT_TRUE(fd1 != -1);
2621
2622 fd2 = resNetworkQuery(TEST_NETID, "howdy.example.com", ns_c_in, ns_t_aaaa, 0);
2623 EXPECT_TRUE(fd2 != -1);
2624
2625 // expect no response
2626 expectAnswersNotValid(fd1, -ETIMEDOUT);
2627 expectAnswersNotValid(fd2, -ETIMEDOUT);
Mike Yu532405f2020-06-17 17:46:44 +08002628 ExpectDnsEvent(INetdEventListener::EVENT_RES_NSEND, RCODE_TIMEOUT, "howdy.example.com", {});
2629 ExpectDnsEvent(INetdEventListener::EVENT_RES_NSEND, RCODE_TIMEOUT, "howdy.example.com", {});
Luke Huangba7bef92018-12-26 16:53:03 +08002630
2631 // Retry case, expect 4 queries
Luke Huang70931aa2019-01-31 11:57:41 +08002632 EXPECT_EQ(4U, GetNumQueries(dns0, host_name));
2633 EXPECT_EQ(4U, GetNumQueries(dns1, host_name));
2634}
2635
2636TEST_F(ResolverTest, Async_VerifyQueryID) {
2637 constexpr char listen_addr[] = "127.0.0.4";
2638 constexpr char host_name[] = "howdy.example.com.";
2639 const std::vector<DnsRecord> records = {
2640 {host_name, ns_type::ns_t_a, "1.2.3.4"},
2641 {host_name, ns_type::ns_t_aaaa, "::1.2.3.4"},
2642 };
2643
2644 test::DNSResponder dns(listen_addr);
2645 StartDns(dns, records);
2646 std::vector<std::string> servers = {listen_addr};
2647 ASSERT_TRUE(mDnsClient.SetResolversForNetwork(servers));
2648
2649 const uint8_t queryBuf1[] = {
2650 /* Header */
2651 0x55, 0x66, /* Transaction ID */
2652 0x01, 0x00, /* Flags */
2653 0x00, 0x01, /* Questions */
2654 0x00, 0x00, /* Answer RRs */
2655 0x00, 0x00, /* Authority RRs */
2656 0x00, 0x00, /* Additional RRs */
2657 /* Queries */
2658 0x05, 0x68, 0x6f, 0x77, 0x64, 0x79, 0x07, 0x65, 0x78, 0x61, 0x6d, 0x70, 0x6c, 0x65,
2659 0x03, 0x63, 0x6f, 0x6d, 0x00, /* Name */
2660 0x00, 0x01, /* Type */
2661 0x00, 0x01 /* Class */
2662 };
2663
2664 int fd = resNetworkSend(TEST_NETID, queryBuf1, sizeof(queryBuf1), 0);
2665 EXPECT_TRUE(fd != -1);
2666
2667 uint8_t buf[MAXPACKET] = {};
2668 int rcode;
2669
2670 int res = getAsyncResponse(fd, &rcode, buf, MAXPACKET);
2671 EXPECT_GT(res, 0);
2672 EXPECT_EQ("1.2.3.4", toString(buf, res, AF_INET));
2673
2674 auto hp = reinterpret_cast<HEADER*>(buf);
2675 EXPECT_EQ(21862U, htons(hp->id));
2676
2677 EXPECT_EQ(1U, GetNumQueries(dns, host_name));
2678
2679 const uint8_t queryBuf2[] = {
2680 /* Header */
2681 0x00, 0x53, /* Transaction ID */
2682 0x01, 0x00, /* Flags */
2683 0x00, 0x01, /* Questions */
2684 0x00, 0x00, /* Answer RRs */
2685 0x00, 0x00, /* Authority RRs */
2686 0x00, 0x00, /* Additional RRs */
2687 /* Queries */
2688 0x05, 0x68, 0x6f, 0x77, 0x64, 0x79, 0x07, 0x65, 0x78, 0x61, 0x6d, 0x70, 0x6c, 0x65,
2689 0x03, 0x63, 0x6f, 0x6d, 0x00, /* Name */
2690 0x00, 0x01, /* Type */
2691 0x00, 0x01 /* Class */
2692 };
2693
2694 // Re-query verify cache works and query id is correct
2695 fd = resNetworkSend(TEST_NETID, queryBuf2, sizeof(queryBuf2), 0);
2696
2697 EXPECT_TRUE(fd != -1);
2698
2699 res = getAsyncResponse(fd, &rcode, buf, MAXPACKET);
2700 EXPECT_GT(res, 0);
2701 EXPECT_EQ("1.2.3.4", toString(buf, res, AF_INET));
2702
2703 EXPECT_EQ(0x0053U, htons(hp->id));
2704
2705 EXPECT_EQ(1U, GetNumQueries(dns, host_name));
Luke Huangba7bef92018-12-26 16:53:03 +08002706}
2707
Mike Yu4f3747b2018-12-02 17:54:29 +09002708// This test checks that the resolver should not generate the request containing OPT RR when using
Ken Chen0a015532019-01-02 14:59:38 +08002709// cleartext DNS. If we query the DNS server not supporting EDNS0 and it reponds with
2710// FORMERR_ON_EDNS, we will fallback to no EDNS0 and try again. If the server does no response, we
2711// won't retry so that we get no answer.
Mike Yu4f3747b2018-12-02 17:54:29 +09002712TEST_F(ResolverTest, BrokenEdns) {
2713 typedef test::DNSResponder::Edns Edns;
2714 enum ExpectResult { EXPECT_FAILURE, EXPECT_SUCCESS };
2715
Mike Yu3977d482020-02-26 17:18:57 +08002716 // Perform cleartext query in off mode.
Mike Yu4f3747b2018-12-02 17:54:29 +09002717 const char OFF[] = "off";
Mike Yu3977d482020-02-26 17:18:57 +08002718
2719 // Perform cleartext query when there's no private DNS server validated in opportunistic mode.
Mike Yu4f3747b2018-12-02 17:54:29 +09002720 const char OPPORTUNISTIC_UDP[] = "opportunistic_udp";
Mike Yu3977d482020-02-26 17:18:57 +08002721
2722 // Perform cleartext query when there is a private DNS server validated in opportunistic mode.
2723 const char OPPORTUNISTIC_FALLBACK_UDP[] = "opportunistic_fallback_udp";
2724
2725 // Perform cyphertext query in opportunistic mode.
Mike Yu4f3747b2018-12-02 17:54:29 +09002726 const char OPPORTUNISTIC_TLS[] = "opportunistic_tls";
Mike Yu3977d482020-02-26 17:18:57 +08002727
2728 // Perform cyphertext query in strict mode.
Mike Yu4f3747b2018-12-02 17:54:29 +09002729 const char STRICT[] = "strict";
Mike Yu3977d482020-02-26 17:18:57 +08002730
Mike Yu4f3747b2018-12-02 17:54:29 +09002731 const char GETHOSTBYNAME[] = "gethostbyname";
2732 const char GETADDRINFO[] = "getaddrinfo";
Mike Yu4f3747b2018-12-02 17:54:29 +09002733 const char ADDR4[] = "192.0.2.1";
2734 const char CLEARTEXT_ADDR[] = "127.0.0.53";
2735 const char CLEARTEXT_PORT[] = "53";
2736 const char TLS_PORT[] = "853";
Luke Huangf8215372019-11-22 11:53:41 +08002737 const std::vector<std::string> servers = {CLEARTEXT_ADDR};
Mike Yu3977d482020-02-26 17:18:57 +08002738 ResolverParamsParcel paramsForCleanup = DnsResponderClient::GetDefaultResolverParamsParcel();
2739 paramsForCleanup.servers.clear();
2740 paramsForCleanup.tlsServers.clear();
Mike Yu4f3747b2018-12-02 17:54:29 +09002741
Mike Yufc125e42019-05-15 20:41:28 +08002742 test::DNSResponder dns(CLEARTEXT_ADDR, CLEARTEXT_PORT, ns_rcode::ns_r_servfail);
Mike Yu4f3747b2018-12-02 17:54:29 +09002743 ASSERT_TRUE(dns.startServer());
2744
2745 test::DnsTlsFrontend tls(CLEARTEXT_ADDR, TLS_PORT, CLEARTEXT_ADDR, CLEARTEXT_PORT);
2746
Luke Huangf8215372019-11-22 11:53:41 +08002747 // clang-format off
Mike Yu4f3747b2018-12-02 17:54:29 +09002748 static const struct TestConfig {
2749 std::string mode;
2750 std::string method;
2751 Edns edns;
2752 ExpectResult expectResult;
2753
2754 std::string asHostName() const {
2755 const char* ednsString;
2756 switch (edns) {
2757 case Edns::ON:
2758 ednsString = "ednsOn";
2759 break;
Ken Chen0a015532019-01-02 14:59:38 +08002760 case Edns::FORMERR_ON_EDNS:
Mike Yu4f3747b2018-12-02 17:54:29 +09002761 ednsString = "ednsFormerr";
2762 break;
2763 case Edns::DROP:
2764 ednsString = "ednsDrop";
2765 break;
2766 default:
2767 ednsString = "";
2768 break;
2769 }
2770 return StringPrintf("%s.%s.%s.", mode.c_str(), method.c_str(), ednsString);
2771 }
2772 } testConfigs[] = {
Mike Yu3977d482020-02-26 17:18:57 +08002773 // In OPPORTUNISTIC_TLS, if the DNS server doesn't support EDNS0 but TLS, the lookup
2774 // fails. Could such server exist? if so, we might need to fix it to fallback to
2775 // cleartext query. If the server still make no response for the queries with EDNS0, we
2776 // might also need to fix it to retry without EDNS0.
Mike Yu4f3747b2018-12-02 17:54:29 +09002777 // Another thing is that {OPPORTUNISTIC_TLS, Edns::DROP} and {STRICT, Edns::DROP} are
2778 // commented out since TLS timeout is not configurable.
2779 // TODO: Uncomment them after TLS timeout is configurable.
Mike Yu3977d482020-02-26 17:18:57 +08002780 {OFF, GETHOSTBYNAME, Edns::ON, EXPECT_SUCCESS},
2781 {OPPORTUNISTIC_UDP, GETHOSTBYNAME, Edns::ON, EXPECT_SUCCESS},
2782 {OPPORTUNISTIC_FALLBACK_UDP, GETHOSTBYNAME, Edns::ON, EXPECT_SUCCESS},
2783 {OPPORTUNISTIC_TLS, GETHOSTBYNAME, Edns::ON, EXPECT_SUCCESS},
2784 {STRICT, GETHOSTBYNAME, Edns::ON, EXPECT_SUCCESS},
2785 {OFF, GETHOSTBYNAME, Edns::FORMERR_ON_EDNS, EXPECT_SUCCESS},
2786 {OPPORTUNISTIC_UDP, GETHOSTBYNAME, Edns::FORMERR_ON_EDNS, EXPECT_SUCCESS},
2787 {OPPORTUNISTIC_FALLBACK_UDP, GETHOSTBYNAME, Edns::FORMERR_ON_EDNS, EXPECT_SUCCESS},
2788 {OPPORTUNISTIC_TLS, GETHOSTBYNAME, Edns::FORMERR_ON_EDNS, EXPECT_FAILURE},
2789 {STRICT, GETHOSTBYNAME, Edns::FORMERR_ON_EDNS, EXPECT_FAILURE},
2790 {OFF, GETHOSTBYNAME, Edns::DROP, EXPECT_SUCCESS},
2791 {OPPORTUNISTIC_UDP, GETHOSTBYNAME, Edns::DROP, EXPECT_SUCCESS},
2792
2793 // The failure is due to no retry on timeout. Maybe fix it?
2794 {OPPORTUNISTIC_FALLBACK_UDP, GETHOSTBYNAME, Edns::DROP, EXPECT_FAILURE},
2795
2796 //{OPPORTUNISTIC_TLS, GETHOSTBYNAME, Edns::DROP, EXPECT_FAILURE},
2797 //{STRICT, GETHOSTBYNAME, Edns::DROP, EXPECT_FAILURE},
2798 {OFF, GETADDRINFO, Edns::ON, EXPECT_SUCCESS},
2799 {OPPORTUNISTIC_UDP, GETADDRINFO, Edns::ON, EXPECT_SUCCESS},
2800 {OPPORTUNISTIC_FALLBACK_UDP, GETADDRINFO, Edns::ON, EXPECT_SUCCESS},
2801 {OPPORTUNISTIC_TLS, GETADDRINFO, Edns::ON, EXPECT_SUCCESS},
2802 {STRICT, GETADDRINFO, Edns::ON, EXPECT_SUCCESS},
2803 {OFF, GETADDRINFO, Edns::FORMERR_ON_EDNS, EXPECT_SUCCESS},
2804 {OPPORTUNISTIC_UDP, GETADDRINFO, Edns::FORMERR_ON_EDNS, EXPECT_SUCCESS},
2805 {OPPORTUNISTIC_FALLBACK_UDP, GETADDRINFO, Edns::FORMERR_ON_EDNS, EXPECT_SUCCESS},
2806 {OPPORTUNISTIC_TLS, GETADDRINFO, Edns::FORMERR_ON_EDNS, EXPECT_FAILURE},
2807 {STRICT, GETADDRINFO, Edns::FORMERR_ON_EDNS, EXPECT_FAILURE},
2808 {OFF, GETADDRINFO, Edns::DROP, EXPECT_SUCCESS},
2809 {OPPORTUNISTIC_UDP, GETADDRINFO, Edns::DROP, EXPECT_SUCCESS},
2810
2811 // The failure is due to no retry on timeout. Maybe fix it?
2812 {OPPORTUNISTIC_FALLBACK_UDP, GETADDRINFO, Edns::DROP, EXPECT_FAILURE},
2813
Mike Yu4f3747b2018-12-02 17:54:29 +09002814 //{OPPORTUNISTIC_TLS, GETADDRINFO, Edns::DROP, EXPECT_FAILURE},
2815 //{STRICT, GETADDRINFO, Edns::DROP, EXPECT_FAILURE},
2816 };
Luke Huangf8215372019-11-22 11:53:41 +08002817 // clang-format on
Mike Yu4f3747b2018-12-02 17:54:29 +09002818
2819 for (const auto& config : testConfigs) {
2820 const std::string testHostName = config.asHostName();
2821 SCOPED_TRACE(testHostName);
2822
2823 const char* host_name = testHostName.c_str();
2824 dns.addMapping(host_name, ns_type::ns_t_a, ADDR4);
2825 dns.setEdns(config.edns);
2826
2827 if (config.mode == OFF) {
Mike Yu0f20cdd2019-06-11 11:52:37 +08002828 if (tls.running()) {
2829 ASSERT_TRUE(tls.stopServer());
2830 }
Xiao Ma09b71022018-12-11 17:56:32 +09002831 ASSERT_TRUE(mDnsClient.SetResolversForNetwork(servers));
Mike Yu4f3747b2018-12-02 17:54:29 +09002832 } else if (config.mode == OPPORTUNISTIC_UDP) {
Mike Yu0f20cdd2019-06-11 11:52:37 +08002833 if (tls.running()) {
2834 ASSERT_TRUE(tls.stopServer());
2835 }
Xiao Ma09b71022018-12-11 17:56:32 +09002836 ASSERT_TRUE(mDnsClient.SetResolversWithTls(servers, kDefaultSearchDomains,
waynema0e73c2e2019-07-31 15:04:08 +08002837 kDefaultParams, ""));
Mike Yu724f77d2019-08-16 11:14:50 +08002838 EXPECT_TRUE(WaitForPrivateDnsValidation(tls.listen_address(), false));
Mike Yu3977d482020-02-26 17:18:57 +08002839 } else if (config.mode == OPPORTUNISTIC_TLS || config.mode == OPPORTUNISTIC_FALLBACK_UDP) {
Mike Yu0f20cdd2019-06-11 11:52:37 +08002840 if (!tls.running()) {
2841 ASSERT_TRUE(tls.startServer());
2842 }
Xiao Ma09b71022018-12-11 17:56:32 +09002843 ASSERT_TRUE(mDnsClient.SetResolversWithTls(servers, kDefaultSearchDomains,
waynema0e73c2e2019-07-31 15:04:08 +08002844 kDefaultParams, ""));
Mike Yu724f77d2019-08-16 11:14:50 +08002845 EXPECT_TRUE(WaitForPrivateDnsValidation(tls.listen_address(), true));
Mike Yu3977d482020-02-26 17:18:57 +08002846
2847 if (config.mode == OPPORTUNISTIC_FALLBACK_UDP) {
2848 // Force the resolver to fallback to cleartext queries.
2849 ASSERT_TRUE(tls.stopServer());
2850 }
Mike Yu4f3747b2018-12-02 17:54:29 +09002851 } else if (config.mode == STRICT) {
Mike Yu0f20cdd2019-06-11 11:52:37 +08002852 if (!tls.running()) {
2853 ASSERT_TRUE(tls.startServer());
2854 }
Xiao Ma09b71022018-12-11 17:56:32 +09002855 ASSERT_TRUE(mDnsClient.SetResolversWithTls(servers, kDefaultSearchDomains,
waynema0e73c2e2019-07-31 15:04:08 +08002856 kDefaultParams, kDefaultPrivateDnsHostName));
Mike Yu724f77d2019-08-16 11:14:50 +08002857 EXPECT_TRUE(WaitForPrivateDnsValidation(tls.listen_address(), true));
Mike Yu4f3747b2018-12-02 17:54:29 +09002858 }
2859
2860 if (config.method == GETHOSTBYNAME) {
2861 const hostent* h_result = gethostbyname(host_name);
2862 if (config.expectResult == EXPECT_SUCCESS) {
2863 EXPECT_LE(1U, GetNumQueries(dns, host_name));
2864 ASSERT_TRUE(h_result != nullptr);
2865 ASSERT_EQ(4, h_result->h_length);
2866 ASSERT_FALSE(h_result->h_addr_list[0] == nullptr);
2867 EXPECT_EQ(ADDR4, ToString(h_result));
2868 EXPECT_TRUE(h_result->h_addr_list[1] == nullptr);
Mike Yu532405f2020-06-17 17:46:44 +08002869 ExpectDnsEvent(INetdEventListener::EVENT_GETHOSTBYNAME, 0, host_name, {ADDR4});
Mike Yu4f3747b2018-12-02 17:54:29 +09002870 } else {
2871 EXPECT_EQ(0U, GetNumQueriesForType(dns, ns_type::ns_t_a, host_name));
2872 ASSERT_TRUE(h_result == nullptr);
2873 ASSERT_EQ(HOST_NOT_FOUND, h_errno);
Mike Yu532405f2020-06-17 17:46:44 +08002874 int returnCode = (config.edns == Edns::DROP) ? RCODE_TIMEOUT : EAI_FAIL;
2875 ExpectDnsEvent(INetdEventListener::EVENT_GETHOSTBYNAME, returnCode, host_name, {});
Mike Yu4f3747b2018-12-02 17:54:29 +09002876 }
2877 } else if (config.method == GETADDRINFO) {
2878 ScopedAddrinfo ai_result;
2879 addrinfo hints = {.ai_family = AF_INET, .ai_socktype = SOCK_DGRAM};
2880 ai_result = safe_getaddrinfo(host_name, nullptr, &hints);
2881 if (config.expectResult == EXPECT_SUCCESS) {
2882 EXPECT_TRUE(ai_result != nullptr);
2883 EXPECT_EQ(1U, GetNumQueries(dns, host_name));
2884 const std::string result_str = ToString(ai_result);
2885 EXPECT_EQ(ADDR4, result_str);
Mike Yu532405f2020-06-17 17:46:44 +08002886 ExpectDnsEvent(INetdEventListener::EVENT_GETADDRINFO, 0, host_name, {ADDR4});
Mike Yu4f3747b2018-12-02 17:54:29 +09002887 } else {
2888 EXPECT_TRUE(ai_result == nullptr);
2889 EXPECT_EQ(0U, GetNumQueries(dns, host_name));
Mike Yu532405f2020-06-17 17:46:44 +08002890 int returnCode = (config.edns == Edns::DROP) ? RCODE_TIMEOUT : EAI_FAIL;
2891 ExpectDnsEvent(INetdEventListener::EVENT_GETADDRINFO, returnCode, host_name, {});
Mike Yu4f3747b2018-12-02 17:54:29 +09002892 }
2893 } else {
2894 FAIL() << "Unsupported query method: " << config.method;
2895 }
2896
Mike Yudd4ac2d2019-05-31 16:52:11 +08002897 tls.clearQueries();
Mike Yu4f3747b2018-12-02 17:54:29 +09002898 dns.clearQueries();
Mike Yu3977d482020-02-26 17:18:57 +08002899
2900 // Clear the setup to force the resolver to validate private DNS servers in every test.
2901 ASSERT_TRUE(mDnsClient.SetResolversFromParcel(paramsForCleanup));
Mike Yu4f3747b2018-12-02 17:54:29 +09002902 }
Mike Yu4f3747b2018-12-02 17:54:29 +09002903}
nuccachena26cc2a2018-07-17 18:07:23 +08002904
Ken Chen0a015532019-01-02 14:59:38 +08002905// DNS-over-TLS validation success, but server does not respond to TLS query after a while.
2906// Resolver should have a reasonable number of retries instead of spinning forever. We don't have
2907// an efficient way to know if resolver is stuck in an infinite loop. However, test case will be
2908// failed due to timeout.
2909TEST_F(ResolverTest, UnstableTls) {
2910 const char CLEARTEXT_ADDR[] = "127.0.0.53";
2911 const char CLEARTEXT_PORT[] = "53";
2912 const char TLS_PORT[] = "853";
2913 const char* host_name1 = "nonexistent1.example.com.";
2914 const char* host_name2 = "nonexistent2.example.com.";
2915 const std::vector<std::string> servers = {CLEARTEXT_ADDR};
2916
Mike Yufc125e42019-05-15 20:41:28 +08002917 test::DNSResponder dns(CLEARTEXT_ADDR, CLEARTEXT_PORT, ns_rcode::ns_r_servfail);
Ken Chen0a015532019-01-02 14:59:38 +08002918 ASSERT_TRUE(dns.startServer());
2919 dns.setEdns(test::DNSResponder::Edns::FORMERR_ON_EDNS);
2920 test::DnsTlsFrontend tls(CLEARTEXT_ADDR, TLS_PORT, CLEARTEXT_ADDR, CLEARTEXT_PORT);
2921 ASSERT_TRUE(tls.startServer());
waynema0e73c2e2019-07-31 15:04:08 +08002922 ASSERT_TRUE(mDnsClient.SetResolversWithTls(servers, kDefaultSearchDomains, kDefaultParams, ""));
Mike Yu724f77d2019-08-16 11:14:50 +08002923 EXPECT_TRUE(WaitForPrivateDnsValidation(tls.listen_address(), true));
2924
Ken Chen0a015532019-01-02 14:59:38 +08002925 // Shutdown TLS server to get an error. It's similar to no response case but without waiting.
2926 tls.stopServer();
2927
2928 const hostent* h_result = gethostbyname(host_name1);
2929 EXPECT_EQ(1U, GetNumQueries(dns, host_name1));
2930 ASSERT_TRUE(h_result == nullptr);
2931 ASSERT_EQ(HOST_NOT_FOUND, h_errno);
2932
2933 addrinfo hints = {.ai_family = AF_INET, .ai_socktype = SOCK_DGRAM};
2934 ScopedAddrinfo ai_result = safe_getaddrinfo(host_name2, nullptr, &hints);
2935 EXPECT_TRUE(ai_result == nullptr);
2936 EXPECT_EQ(1U, GetNumQueries(dns, host_name2));
2937}
2938
2939// DNS-over-TLS validation success, but server does not respond to TLS query after a while.
2940// Moreover, server responds RCODE=FORMERR even on non-EDNS query.
2941TEST_F(ResolverTest, BogusDnsServer) {
2942 const char CLEARTEXT_ADDR[] = "127.0.0.53";
2943 const char CLEARTEXT_PORT[] = "53";
2944 const char TLS_PORT[] = "853";
2945 const char* host_name1 = "nonexistent1.example.com.";
2946 const char* host_name2 = "nonexistent2.example.com.";
2947 const std::vector<std::string> servers = {CLEARTEXT_ADDR};
2948
Mike Yufc125e42019-05-15 20:41:28 +08002949 test::DNSResponder dns(CLEARTEXT_ADDR, CLEARTEXT_PORT, ns_rcode::ns_r_servfail);
Ken Chen0a015532019-01-02 14:59:38 +08002950 ASSERT_TRUE(dns.startServer());
2951 test::DnsTlsFrontend tls(CLEARTEXT_ADDR, TLS_PORT, CLEARTEXT_ADDR, CLEARTEXT_PORT);
2952 ASSERT_TRUE(tls.startServer());
waynema0e73c2e2019-07-31 15:04:08 +08002953 ASSERT_TRUE(mDnsClient.SetResolversWithTls(servers, kDefaultSearchDomains, kDefaultParams, ""));
Mike Yu724f77d2019-08-16 11:14:50 +08002954 EXPECT_TRUE(WaitForPrivateDnsValidation(tls.listen_address(), true));
2955
Ken Chen0a015532019-01-02 14:59:38 +08002956 // Shutdown TLS server to get an error. It's similar to no response case but without waiting.
2957 tls.stopServer();
2958 dns.setEdns(test::DNSResponder::Edns::FORMERR_UNCOND);
2959
2960 const hostent* h_result = gethostbyname(host_name1);
2961 EXPECT_EQ(0U, GetNumQueries(dns, host_name1));
2962 ASSERT_TRUE(h_result == nullptr);
2963 ASSERT_EQ(HOST_NOT_FOUND, h_errno);
2964
2965 addrinfo hints = {.ai_family = AF_INET, .ai_socktype = SOCK_DGRAM};
2966 ScopedAddrinfo ai_result = safe_getaddrinfo(host_name2, nullptr, &hints);
2967 EXPECT_TRUE(ai_result == nullptr);
2968 EXPECT_EQ(0U, GetNumQueries(dns, host_name2));
2969}
2970
nuccachena26cc2a2018-07-17 18:07:23 +08002971TEST_F(ResolverTest, GetAddrInfo_Dns64Synthesize) {
2972 constexpr char listen_addr[] = "::1";
nuccachena26cc2a2018-07-17 18:07:23 +08002973 constexpr char dns64_name[] = "ipv4only.arpa.";
2974 constexpr char host_name[] = "v4only.example.com.";
Xiao Ma09b71022018-12-11 17:56:32 +09002975 const std::vector<DnsRecord> records = {
2976 {dns64_name, ns_type::ns_t_aaaa, "64:ff9b::192.0.0.170"},
2977 {host_name, ns_type::ns_t_a, "1.2.3.4"},
2978 };
nuccachena26cc2a2018-07-17 18:07:23 +08002979
Xiao Ma09b71022018-12-11 17:56:32 +09002980 test::DNSResponder dns(listen_addr);
Xiao Ma09b71022018-12-11 17:56:32 +09002981 StartDns(dns, records);
nuccachena26cc2a2018-07-17 18:07:23 +08002982
2983 std::vector<std::string> servers = {listen_addr};
Xiao Ma09b71022018-12-11 17:56:32 +09002984 ASSERT_TRUE(mDnsClient.SetResolversForNetwork(servers));
nuccachena26cc2a2018-07-17 18:07:23 +08002985
Lorenzo Colittid39345c2019-02-18 10:59:29 +09002986 // Start NAT64 prefix discovery and wait for it to complete.
Luke Huang5bd827c2019-03-14 16:10:04 +08002987 EXPECT_TRUE(mDnsClient.resolvService()->startPrefix64Discovery(TEST_NETID).isOk());
Hungming Chene8f970c2019-04-10 17:34:06 +08002988 EXPECT_TRUE(WaitForNat64Prefix(EXPECT_FOUND));
nuccachena26cc2a2018-07-17 18:07:23 +08002989
2990 // hints are necessary in order to let netd know which type of addresses the caller is
2991 // interested in.
Xiao Ma09b71022018-12-11 17:56:32 +09002992 const addrinfo hints = {.ai_family = AF_UNSPEC};
nuccachena26cc2a2018-07-17 18:07:23 +08002993 ScopedAddrinfo result = safe_getaddrinfo("v4only", nullptr, &hints);
2994 EXPECT_TRUE(result != nullptr);
Lorenzo Colittid39345c2019-02-18 10:59:29 +09002995 // TODO: BUG: there should only be two queries, one AAAA (which returns no records) and one A
2996 // (which returns 1.2.3.4). But there is an extra AAAA.
2997 EXPECT_EQ(3U, GetNumQueries(dns, host_name));
nuccachena26cc2a2018-07-17 18:07:23 +08002998
2999 std::string result_str = ToString(result);
3000 EXPECT_EQ(result_str, "64:ff9b::102:304");
3001
Lorenzo Colittid39345c2019-02-18 10:59:29 +09003002 // Stopping NAT64 prefix discovery disables synthesis.
Luke Huang5bd827c2019-03-14 16:10:04 +08003003 EXPECT_TRUE(mDnsClient.resolvService()->stopPrefix64Discovery(TEST_NETID).isOk());
Hungming Chene8f970c2019-04-10 17:34:06 +08003004 EXPECT_TRUE(WaitForNat64Prefix(EXPECT_NOT_FOUND));
nuccachena26cc2a2018-07-17 18:07:23 +08003005
Lorenzo Colittid39345c2019-02-18 10:59:29 +09003006 dns.clearQueries();
nuccachena26cc2a2018-07-17 18:07:23 +08003007
3008 result = safe_getaddrinfo("v4only", nullptr, &hints);
3009 EXPECT_TRUE(result != nullptr);
Lorenzo Colittid39345c2019-02-18 10:59:29 +09003010 // TODO: BUG: there should only be one query, an AAAA (which returns no records), because the
3011 // A is already cached. But there is an extra AAAA.
3012 EXPECT_EQ(2U, GetNumQueries(dns, host_name));
nuccachena26cc2a2018-07-17 18:07:23 +08003013
3014 result_str = ToString(result);
3015 EXPECT_EQ(result_str, "1.2.3.4");
3016}
3017
nuccachena26cc2a2018-07-17 18:07:23 +08003018TEST_F(ResolverTest, GetAddrInfo_Dns64QuerySpecified) {
3019 constexpr char listen_addr[] = "::1";
nuccachena26cc2a2018-07-17 18:07:23 +08003020 constexpr char dns64_name[] = "ipv4only.arpa.";
3021 constexpr char host_name[] = "v4only.example.com.";
Xiao Ma09b71022018-12-11 17:56:32 +09003022 const std::vector<DnsRecord> records = {
3023 {dns64_name, ns_type::ns_t_aaaa, "64:ff9b::192.0.0.170"},
3024 {host_name, ns_type::ns_t_a, "1.2.3.4"},
3025 };
nuccachena26cc2a2018-07-17 18:07:23 +08003026
Xiao Ma09b71022018-12-11 17:56:32 +09003027 test::DNSResponder dns(listen_addr);
3028 StartDns(dns, records);
nuccachena26cc2a2018-07-17 18:07:23 +08003029 const std::vector<std::string> servers = {listen_addr};
Xiao Ma09b71022018-12-11 17:56:32 +09003030 ASSERT_TRUE(mDnsClient.SetResolversForNetwork(servers));
nuccachena26cc2a2018-07-17 18:07:23 +08003031
Lorenzo Colittid39345c2019-02-18 10:59:29 +09003032 // Start NAT64 prefix discovery and wait for it to complete.
Luke Huang5bd827c2019-03-14 16:10:04 +08003033 EXPECT_TRUE(mDnsClient.resolvService()->startPrefix64Discovery(TEST_NETID).isOk());
Hungming Chene8f970c2019-04-10 17:34:06 +08003034 EXPECT_TRUE(WaitForNat64Prefix(EXPECT_FOUND));
nuccachena26cc2a2018-07-17 18:07:23 +08003035
3036 // Ensure to synthesize AAAA if AF_INET6 is specified, and not to synthesize AAAA
3037 // in AF_INET case.
3038 addrinfo hints;
3039 memset(&hints, 0, sizeof(hints));
3040 hints.ai_family = AF_INET6;
3041 ScopedAddrinfo result = safe_getaddrinfo("v4only", nullptr, &hints);
3042 EXPECT_TRUE(result != nullptr);
3043 std::string result_str = ToString(result);
3044 EXPECT_EQ(result_str, "64:ff9b::102:304");
3045
3046 hints.ai_family = AF_INET;
3047 result = safe_getaddrinfo("v4only", nullptr, &hints);
3048 EXPECT_TRUE(result != nullptr);
3049 EXPECT_LE(2U, GetNumQueries(dns, host_name));
3050 result_str = ToString(result);
3051 EXPECT_EQ(result_str, "1.2.3.4");
3052}
nuccachena26cc2a2018-07-17 18:07:23 +08003053
3054TEST_F(ResolverTest, GetAddrInfo_Dns64QueryUnspecifiedV6) {
3055 constexpr char listen_addr[] = "::1";
nuccachena26cc2a2018-07-17 18:07:23 +08003056 constexpr char dns64_name[] = "ipv4only.arpa.";
3057 constexpr char host_name[] = "v4v6.example.com.";
Xiao Ma09b71022018-12-11 17:56:32 +09003058 const std::vector<DnsRecord> records = {
3059 {dns64_name, ns_type::ns_t_aaaa, "64:ff9b::192.0.0.170"},
3060 {host_name, ns_type::ns_t_a, "1.2.3.4"},
3061 {host_name, ns_type::ns_t_aaaa, "2001:db8::1.2.3.4"},
3062 };
nuccachena26cc2a2018-07-17 18:07:23 +08003063
Xiao Ma09b71022018-12-11 17:56:32 +09003064 test::DNSResponder dns(listen_addr);
3065 StartDns(dns, records);
nuccachena26cc2a2018-07-17 18:07:23 +08003066 const std::vector<std::string> servers = {listen_addr};
Xiao Ma09b71022018-12-11 17:56:32 +09003067 ASSERT_TRUE(mDnsClient.SetResolversForNetwork(servers));
nuccachena26cc2a2018-07-17 18:07:23 +08003068
Lorenzo Colittid39345c2019-02-18 10:59:29 +09003069 // Start NAT64 prefix discovery and wait for it to complete.
Luke Huang5bd827c2019-03-14 16:10:04 +08003070 EXPECT_TRUE(mDnsClient.resolvService()->startPrefix64Discovery(TEST_NETID).isOk());
Hungming Chene8f970c2019-04-10 17:34:06 +08003071 EXPECT_TRUE(WaitForNat64Prefix(EXPECT_FOUND));
nuccachena26cc2a2018-07-17 18:07:23 +08003072
Xiao Ma09b71022018-12-11 17:56:32 +09003073 const addrinfo hints = {.ai_family = AF_UNSPEC};
nuccachena26cc2a2018-07-17 18:07:23 +08003074 ScopedAddrinfo result = safe_getaddrinfo("v4v6", nullptr, &hints);
3075 EXPECT_TRUE(result != nullptr);
3076 EXPECT_LE(2U, GetNumQueries(dns, host_name));
3077
3078 // In AF_UNSPEC case, do not synthesize AAAA if there's at least one AAAA answer.
Xiao Ma09b71022018-12-11 17:56:32 +09003079 const std::vector<std::string> result_strs = ToStrings(result);
nuccachena26cc2a2018-07-17 18:07:23 +08003080 for (const auto& str : result_strs) {
3081 EXPECT_TRUE(str == "1.2.3.4" || str == "2001:db8::102:304")
3082 << ", result_str='" << str << "'";
3083 }
3084}
3085
3086TEST_F(ResolverTest, GetAddrInfo_Dns64QueryUnspecifiedNoV6) {
3087 constexpr char listen_addr[] = "::1";
nuccachena26cc2a2018-07-17 18:07:23 +08003088 constexpr char dns64_name[] = "ipv4only.arpa.";
3089 constexpr char host_name[] = "v4v6.example.com.";
Xiao Ma09b71022018-12-11 17:56:32 +09003090 const std::vector<DnsRecord> records = {
3091 {dns64_name, ns_type::ns_t_aaaa, "64:ff9b::192.0.0.170"},
3092 {host_name, ns_type::ns_t_a, "1.2.3.4"},
3093 };
nuccachena26cc2a2018-07-17 18:07:23 +08003094
Xiao Ma09b71022018-12-11 17:56:32 +09003095 test::DNSResponder dns(listen_addr);
3096 StartDns(dns, records);
nuccachena26cc2a2018-07-17 18:07:23 +08003097 const std::vector<std::string> servers = {listen_addr};
Xiao Ma09b71022018-12-11 17:56:32 +09003098 ASSERT_TRUE(mDnsClient.SetResolversForNetwork(servers));
nuccachena26cc2a2018-07-17 18:07:23 +08003099
Lorenzo Colittid39345c2019-02-18 10:59:29 +09003100 // Start NAT64 prefix discovery and wait for it to complete.
Luke Huang5bd827c2019-03-14 16:10:04 +08003101 EXPECT_TRUE(mDnsClient.resolvService()->startPrefix64Discovery(TEST_NETID).isOk());
Hungming Chene8f970c2019-04-10 17:34:06 +08003102 EXPECT_TRUE(WaitForNat64Prefix(EXPECT_FOUND));
nuccachena26cc2a2018-07-17 18:07:23 +08003103
Xiao Ma09b71022018-12-11 17:56:32 +09003104 const addrinfo hints = {.ai_family = AF_UNSPEC};
nuccachena26cc2a2018-07-17 18:07:23 +08003105 ScopedAddrinfo result = safe_getaddrinfo("v4v6", nullptr, &hints);
3106 EXPECT_TRUE(result != nullptr);
3107 EXPECT_LE(2U, GetNumQueries(dns, host_name));
3108
3109 // In AF_UNSPEC case, synthesize AAAA if there's no AAAA answer.
3110 std::string result_str = ToString(result);
3111 EXPECT_EQ(result_str, "64:ff9b::102:304");
3112}
3113
3114TEST_F(ResolverTest, GetAddrInfo_Dns64QuerySpecialUseIPv4Addresses) {
3115 constexpr char THIS_NETWORK[] = "this_network";
3116 constexpr char LOOPBACK[] = "loopback";
3117 constexpr char LINK_LOCAL[] = "link_local";
3118 constexpr char MULTICAST[] = "multicast";
3119 constexpr char LIMITED_BROADCAST[] = "limited_broadcast";
3120
3121 constexpr char ADDR_THIS_NETWORK[] = "0.0.0.1";
3122 constexpr char ADDR_LOOPBACK[] = "127.0.0.1";
3123 constexpr char ADDR_LINK_LOCAL[] = "169.254.0.1";
3124 constexpr char ADDR_MULTICAST[] = "224.0.0.1";
3125 constexpr char ADDR_LIMITED_BROADCAST[] = "255.255.255.255";
3126
3127 constexpr char listen_addr[] = "::1";
nuccachena26cc2a2018-07-17 18:07:23 +08003128 constexpr char dns64_name[] = "ipv4only.arpa.";
3129
Xiao Ma09b71022018-12-11 17:56:32 +09003130 test::DNSResponder dns(listen_addr);
3131 StartDns(dns, {{dns64_name, ns_type::ns_t_aaaa, "64:ff9b::"}});
nuccachena26cc2a2018-07-17 18:07:23 +08003132 const std::vector<std::string> servers = {listen_addr};
Xiao Ma09b71022018-12-11 17:56:32 +09003133 ASSERT_TRUE(mDnsClient.SetResolversForNetwork(servers));
nuccachena26cc2a2018-07-17 18:07:23 +08003134
Lorenzo Colittid39345c2019-02-18 10:59:29 +09003135 // Start NAT64 prefix discovery and wait for it to complete.
Luke Huang5bd827c2019-03-14 16:10:04 +08003136 EXPECT_TRUE(mDnsClient.resolvService()->startPrefix64Discovery(TEST_NETID).isOk());
Hungming Chene8f970c2019-04-10 17:34:06 +08003137 EXPECT_TRUE(WaitForNat64Prefix(EXPECT_FOUND));
nuccachena26cc2a2018-07-17 18:07:23 +08003138
Luke Huangf8215372019-11-22 11:53:41 +08003139 // clang-format off
nuccachena26cc2a2018-07-17 18:07:23 +08003140 static const struct TestConfig {
3141 std::string name;
3142 std::string addr;
3143
3144 std::string asHostName() const { return StringPrintf("%s.example.com.", name.c_str()); }
3145 } testConfigs[]{
3146 {THIS_NETWORK, ADDR_THIS_NETWORK},
3147 {LOOPBACK, ADDR_LOOPBACK},
3148 {LINK_LOCAL, ADDR_LINK_LOCAL},
3149 {MULTICAST, ADDR_MULTICAST},
3150 {LIMITED_BROADCAST, ADDR_LIMITED_BROADCAST}
3151 };
Luke Huangf8215372019-11-22 11:53:41 +08003152 // clang-format on
nuccachena26cc2a2018-07-17 18:07:23 +08003153
3154 for (const auto& config : testConfigs) {
3155 const std::string testHostName = config.asHostName();
3156 SCOPED_TRACE(testHostName);
3157
3158 const char* host_name = testHostName.c_str();
3159 dns.addMapping(host_name, ns_type::ns_t_a, config.addr.c_str());
3160
3161 addrinfo hints;
3162 memset(&hints, 0, sizeof(hints));
3163 hints.ai_family = AF_INET6;
3164 ScopedAddrinfo result = safe_getaddrinfo(config.name.c_str(), nullptr, &hints);
3165 // In AF_INET6 case, don't return IPv4 answers
3166 EXPECT_TRUE(result == nullptr);
3167 EXPECT_LE(2U, GetNumQueries(dns, host_name));
3168 dns.clearQueries();
3169
3170 memset(&hints, 0, sizeof(hints));
3171 hints.ai_family = AF_UNSPEC;
3172 result = safe_getaddrinfo(config.name.c_str(), nullptr, &hints);
3173 EXPECT_TRUE(result != nullptr);
3174 // Expect IPv6 query only. IPv4 answer has been cached in previous query.
3175 EXPECT_LE(1U, GetNumQueries(dns, host_name));
3176 // In AF_UNSPEC case, don't synthesize special use IPv4 address.
3177 std::string result_str = ToString(result);
3178 EXPECT_EQ(result_str, config.addr.c_str());
3179 dns.clearQueries();
3180 }
3181}
3182
3183TEST_F(ResolverTest, GetAddrInfo_Dns64QueryWithNullArgumentHints) {
3184 constexpr char listen_addr[] = "::1";
nuccachena26cc2a2018-07-17 18:07:23 +08003185 constexpr char dns64_name[] = "ipv4only.arpa.";
3186 constexpr char host_name[] = "v4only.example.com.";
3187 constexpr char host_name2[] = "v4v6.example.com.";
Xiao Ma09b71022018-12-11 17:56:32 +09003188 const std::vector<DnsRecord> records = {
3189 {dns64_name, ns_type::ns_t_aaaa, "64:ff9b::192.0.0.170"},
3190 {host_name, ns_type::ns_t_a, "1.2.3.4"},
3191 {host_name2, ns_type::ns_t_a, "1.2.3.4"},
3192 {host_name2, ns_type::ns_t_aaaa, "2001:db8::1.2.3.4"},
3193 };
nuccachena26cc2a2018-07-17 18:07:23 +08003194
Xiao Ma09b71022018-12-11 17:56:32 +09003195 test::DNSResponder dns(listen_addr);
3196 StartDns(dns, records);
nuccachena26cc2a2018-07-17 18:07:23 +08003197 const std::vector<std::string> servers = {listen_addr};
Xiao Ma09b71022018-12-11 17:56:32 +09003198 ASSERT_TRUE(mDnsClient.SetResolversForNetwork(servers));
nuccachena26cc2a2018-07-17 18:07:23 +08003199
Lorenzo Colittid39345c2019-02-18 10:59:29 +09003200 // Start NAT64 prefix discovery and wait for it to complete.
Luke Huang5bd827c2019-03-14 16:10:04 +08003201 EXPECT_TRUE(mDnsClient.resolvService()->startPrefix64Discovery(TEST_NETID).isOk());
Hungming Chene8f970c2019-04-10 17:34:06 +08003202 EXPECT_TRUE(WaitForNat64Prefix(EXPECT_FOUND));
nuccachena26cc2a2018-07-17 18:07:23 +08003203
3204 // Assign argument hints of getaddrinfo() as null is equivalent to set ai_family AF_UNSPEC.
3205 // In AF_UNSPEC case, synthesize AAAA if there has A answer only.
3206 ScopedAddrinfo result = safe_getaddrinfo("v4only", nullptr, nullptr);
3207 EXPECT_TRUE(result != nullptr);
3208 EXPECT_LE(2U, GetNumQueries(dns, host_name));
3209 std::string result_str = ToString(result);
3210 EXPECT_EQ(result_str, "64:ff9b::102:304");
3211 dns.clearQueries();
3212
3213 // In AF_UNSPEC case, do not synthesize AAAA if there's at least one AAAA answer.
3214 result = safe_getaddrinfo("v4v6", nullptr, nullptr);
3215 EXPECT_TRUE(result != nullptr);
3216 EXPECT_LE(2U, GetNumQueries(dns, host_name2));
3217 std::vector<std::string> result_strs = ToStrings(result);
3218 for (const auto& str : result_strs) {
3219 EXPECT_TRUE(str == "1.2.3.4" || str == "2001:db8::102:304")
3220 << ", result_str='" << str << "'";
3221 }
3222}
3223
3224TEST_F(ResolverTest, GetAddrInfo_Dns64QueryNullArgumentNode) {
3225 constexpr char ADDR_ANYADDR_V4[] = "0.0.0.0";
3226 constexpr char ADDR_ANYADDR_V6[] = "::";
3227 constexpr char ADDR_LOCALHOST_V4[] = "127.0.0.1";
3228 constexpr char ADDR_LOCALHOST_V6[] = "::1";
3229
3230 constexpr char PORT_NAME_HTTP[] = "http";
3231 constexpr char PORT_NUMBER_HTTP[] = "80";
3232
3233 constexpr char listen_addr[] = "::1";
nuccachena26cc2a2018-07-17 18:07:23 +08003234 constexpr char dns64_name[] = "ipv4only.arpa.";
3235
Xiao Ma09b71022018-12-11 17:56:32 +09003236 test::DNSResponder dns(listen_addr);
3237 StartDns(dns, {{dns64_name, ns_type::ns_t_aaaa, "64:ff9b::"}});
nuccachena26cc2a2018-07-17 18:07:23 +08003238 const std::vector<std::string> servers = {listen_addr};
Xiao Ma09b71022018-12-11 17:56:32 +09003239 ASSERT_TRUE(mDnsClient.SetResolversForNetwork(servers));
nuccachena26cc2a2018-07-17 18:07:23 +08003240
Lorenzo Colittid39345c2019-02-18 10:59:29 +09003241 // Start NAT64 prefix discovery and wait for it to complete.
Luke Huang5bd827c2019-03-14 16:10:04 +08003242 EXPECT_TRUE(mDnsClient.resolvService()->startPrefix64Discovery(TEST_NETID).isOk());
Hungming Chene8f970c2019-04-10 17:34:06 +08003243 EXPECT_TRUE(WaitForNat64Prefix(EXPECT_FOUND));
nuccachena26cc2a2018-07-17 18:07:23 +08003244
Luke Huangf8215372019-11-22 11:53:41 +08003245 // clang-format off
nuccachena26cc2a2018-07-17 18:07:23 +08003246 // If node is null, return address is listed by libc/getaddrinfo.c as follows.
3247 // - passive socket -> anyaddr (0.0.0.0 or ::)
3248 // - non-passive socket -> localhost (127.0.0.1 or ::1)
3249 static const struct TestConfig {
3250 int flag;
3251 std::string addr_v4;
3252 std::string addr_v6;
3253
3254 std::string asParameters() const {
3255 return StringPrintf("flag=%d, addr_v4=%s, addr_v6=%s", flag, addr_v4.c_str(),
3256 addr_v6.c_str());
3257 }
3258 } testConfigs[]{
3259 {0 /* non-passive */, ADDR_LOCALHOST_V4, ADDR_LOCALHOST_V6},
3260 {AI_PASSIVE, ADDR_ANYADDR_V4, ADDR_ANYADDR_V6}
3261 };
Luke Huangf8215372019-11-22 11:53:41 +08003262 // clang-format on
nuccachena26cc2a2018-07-17 18:07:23 +08003263
3264 for (const auto& config : testConfigs) {
3265 SCOPED_TRACE(config.asParameters());
3266
Xiao Ma09b71022018-12-11 17:56:32 +09003267 addrinfo hints = {
Nick Desaulnierscd6395a2019-10-11 09:15:24 -07003268 .ai_flags = config.flag,
Xiao Ma09b71022018-12-11 17:56:32 +09003269 .ai_family = AF_UNSPEC, // any address family
3270 .ai_socktype = 0, // any type
3271 .ai_protocol = 0, // any protocol
Xiao Ma09b71022018-12-11 17:56:32 +09003272 };
nuccachena26cc2a2018-07-17 18:07:23 +08003273
3274 // Assign hostname as null and service as port name.
3275 ScopedAddrinfo result = safe_getaddrinfo(nullptr, PORT_NAME_HTTP, &hints);
3276 ASSERT_TRUE(result != nullptr);
3277
3278 // Can't be synthesized because it should not get into Netd.
3279 std::vector<std::string> result_strs = ToStrings(result);
3280 for (const auto& str : result_strs) {
3281 EXPECT_TRUE(str == config.addr_v4 || str == config.addr_v6)
3282 << ", result_str='" << str << "'";
3283 }
3284
3285 // Assign hostname as null and service as numeric port number.
3286 hints.ai_flags = config.flag | AI_NUMERICSERV;
3287 result = safe_getaddrinfo(nullptr, PORT_NUMBER_HTTP, &hints);
3288 ASSERT_TRUE(result != nullptr);
3289
3290 // Can't be synthesized because it should not get into Netd.
3291 result_strs = ToStrings(result);
3292 for (const auto& str : result_strs) {
3293 EXPECT_TRUE(str == config.addr_v4 || str == config.addr_v6)
3294 << ", result_str='" << str << "'";
3295 }
3296 }
3297}
3298
3299TEST_F(ResolverTest, GetHostByAddr_ReverseDnsQueryWithHavingNat64Prefix) {
3300 struct hostent* result = nullptr;
3301 struct in_addr v4addr;
3302 struct in6_addr v6addr;
3303
3304 constexpr char listen_addr[] = "::1";
nuccachena26cc2a2018-07-17 18:07:23 +08003305 constexpr char dns64_name[] = "ipv4only.arpa.";
3306 constexpr char ptr_name[] = "v4v6.example.com.";
3307 // PTR record for IPv4 address 1.2.3.4
3308 constexpr char ptr_addr_v4[] = "4.3.2.1.in-addr.arpa.";
3309 // PTR record for IPv6 address 2001:db8::102:304
3310 constexpr char ptr_addr_v6[] =
3311 "4.0.3.0.2.0.1.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.8.b.d.0.1.0.0.2.ip6.arpa.";
Xiao Ma09b71022018-12-11 17:56:32 +09003312 const std::vector<DnsRecord> records = {
3313 {dns64_name, ns_type::ns_t_aaaa, "64:ff9b::192.0.0.170"},
3314 {ptr_addr_v4, ns_type::ns_t_ptr, ptr_name},
3315 {ptr_addr_v6, ns_type::ns_t_ptr, ptr_name},
3316 };
nuccachena26cc2a2018-07-17 18:07:23 +08003317
Xiao Ma09b71022018-12-11 17:56:32 +09003318 test::DNSResponder dns(listen_addr);
3319 StartDns(dns, records);
nuccachena26cc2a2018-07-17 18:07:23 +08003320 const std::vector<std::string> servers = {listen_addr};
Xiao Ma09b71022018-12-11 17:56:32 +09003321 ASSERT_TRUE(mDnsClient.SetResolversForNetwork(servers));
nuccachena26cc2a2018-07-17 18:07:23 +08003322
Lorenzo Colittid39345c2019-02-18 10:59:29 +09003323 // Start NAT64 prefix discovery and wait for it to complete.
Luke Huang5bd827c2019-03-14 16:10:04 +08003324 EXPECT_TRUE(mDnsClient.resolvService()->startPrefix64Discovery(TEST_NETID).isOk());
Hungming Chene8f970c2019-04-10 17:34:06 +08003325 EXPECT_TRUE(WaitForNat64Prefix(EXPECT_FOUND));
nuccachena26cc2a2018-07-17 18:07:23 +08003326
3327 // Reverse IPv4 DNS query. Prefix should have no effect on it.
3328 inet_pton(AF_INET, "1.2.3.4", &v4addr);
3329 result = gethostbyaddr(&v4addr, sizeof(v4addr), AF_INET);
3330 ASSERT_TRUE(result != nullptr);
3331 std::string result_str = result->h_name ? result->h_name : "null";
3332 EXPECT_EQ(result_str, "v4v6.example.com");
3333
3334 // Reverse IPv6 DNS query. Prefix should have no effect on it.
3335 inet_pton(AF_INET6, "2001:db8::102:304", &v6addr);
3336 result = gethostbyaddr(&v6addr, sizeof(v6addr), AF_INET6);
3337 ASSERT_TRUE(result != nullptr);
3338 result_str = result->h_name ? result->h_name : "null";
3339 EXPECT_EQ(result_str, "v4v6.example.com");
3340}
3341
3342TEST_F(ResolverTest, GetHostByAddr_ReverseDns64Query) {
3343 constexpr char listen_addr[] = "::1";
nuccachena26cc2a2018-07-17 18:07:23 +08003344 constexpr char dns64_name[] = "ipv4only.arpa.";
3345 constexpr char ptr_name[] = "v4only.example.com.";
3346 // PTR record for IPv4 address 1.2.3.4
3347 constexpr char ptr_addr_v4[] = "4.3.2.1.in-addr.arpa.";
3348 // PTR record for IPv6 address 64:ff9b::1.2.3.4
3349 constexpr char ptr_addr_v6_nomapping[] =
3350 "4.0.3.0.2.0.1.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.b.9.f.f.4.6.0.0.ip6.arpa.";
3351 constexpr char ptr_name_v6_synthesis[] = "v6synthesis.example.com.";
3352 // PTR record for IPv6 address 64:ff9b::5.6.7.8
3353 constexpr char ptr_addr_v6_synthesis[] =
3354 "8.0.7.0.6.0.5.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.b.9.f.f.4.6.0.0.ip6.arpa.";
Xiao Ma09b71022018-12-11 17:56:32 +09003355 const std::vector<DnsRecord> records = {
3356 {dns64_name, ns_type::ns_t_aaaa, "64:ff9b::192.0.0.170"},
3357 {ptr_addr_v4, ns_type::ns_t_ptr, ptr_name},
3358 {ptr_addr_v6_synthesis, ns_type::ns_t_ptr, ptr_name_v6_synthesis},
3359 };
nuccachena26cc2a2018-07-17 18:07:23 +08003360
Xiao Ma09b71022018-12-11 17:56:32 +09003361 test::DNSResponder dns(listen_addr);
3362 StartDns(dns, records);
nuccachena26cc2a2018-07-17 18:07:23 +08003363 // "ptr_addr_v6_nomapping" is not mapped in DNS server
nuccachena26cc2a2018-07-17 18:07:23 +08003364 const std::vector<std::string> servers = {listen_addr};
Xiao Ma09b71022018-12-11 17:56:32 +09003365 ASSERT_TRUE(mDnsClient.SetResolversForNetwork(servers));
nuccachena26cc2a2018-07-17 18:07:23 +08003366
Lorenzo Colittid39345c2019-02-18 10:59:29 +09003367 // Start NAT64 prefix discovery and wait for it to complete.
Luke Huang5bd827c2019-03-14 16:10:04 +08003368 EXPECT_TRUE(mDnsClient.resolvService()->startPrefix64Discovery(TEST_NETID).isOk());
Hungming Chene8f970c2019-04-10 17:34:06 +08003369 EXPECT_TRUE(WaitForNat64Prefix(EXPECT_FOUND));
nuccachena26cc2a2018-07-17 18:07:23 +08003370
3371 // Synthesized PTR record doesn't exist on DNS server
3372 // Reverse IPv6 DNS64 query while DNS server doesn't have an answer for synthesized address.
3373 // After querying synthesized address failed, expect that prefix is removed from IPv6
3374 // synthesized address and do reverse IPv4 query instead.
3375 struct in6_addr v6addr;
3376 inet_pton(AF_INET6, "64:ff9b::1.2.3.4", &v6addr);
3377 struct hostent* result = gethostbyaddr(&v6addr, sizeof(v6addr), AF_INET6);
3378 ASSERT_TRUE(result != nullptr);
3379 EXPECT_LE(1U, GetNumQueries(dns, ptr_addr_v6_nomapping)); // PTR record not exist
3380 EXPECT_LE(1U, GetNumQueries(dns, ptr_addr_v4)); // PTR record exist
3381 std::string result_str = result->h_name ? result->h_name : "null";
3382 EXPECT_EQ(result_str, "v4only.example.com");
3383 // Check that return address has been mapped from IPv4 to IPv6 address because Netd
3384 // removes NAT64 prefix and does IPv4 DNS reverse lookup in this case. Then, Netd
3385 // fakes the return IPv4 address as original queried IPv6 address.
3386 result_str = ToString(result);
3387 EXPECT_EQ(result_str, "64:ff9b::102:304");
3388 dns.clearQueries();
3389
3390 // Synthesized PTR record exists on DNS server
3391 // Reverse IPv6 DNS64 query while DNS server has an answer for synthesized address.
3392 // Expect to Netd pass through synthesized address for DNS queries.
3393 inet_pton(AF_INET6, "64:ff9b::5.6.7.8", &v6addr);
3394 result = gethostbyaddr(&v6addr, sizeof(v6addr), AF_INET6);
3395 ASSERT_TRUE(result != nullptr);
3396 EXPECT_LE(1U, GetNumQueries(dns, ptr_addr_v6_synthesis));
3397 result_str = result->h_name ? result->h_name : "null";
3398 EXPECT_EQ(result_str, "v6synthesis.example.com");
3399}
3400
3401TEST_F(ResolverTest, GetHostByAddr_ReverseDns64QueryFromHostFile) {
3402 constexpr char dns64_name[] = "ipv4only.arpa.";
3403 constexpr char host_name[] = "localhost";
3404 // The address is synthesized by prefix64:localhost.
3405 constexpr char host_addr[] = "64:ff9b::7f00:1";
nuccachena26cc2a2018-07-17 18:07:23 +08003406 constexpr char listen_addr[] = "::1";
Xiao Ma09b71022018-12-11 17:56:32 +09003407
3408 test::DNSResponder dns(listen_addr);
3409 StartDns(dns, {{dns64_name, ns_type::ns_t_aaaa, "64:ff9b::192.0.0.170"}});
nuccachena26cc2a2018-07-17 18:07:23 +08003410 const std::vector<std::string> servers = {listen_addr};
Xiao Ma09b71022018-12-11 17:56:32 +09003411 ASSERT_TRUE(mDnsClient.SetResolversForNetwork(servers));
nuccachena26cc2a2018-07-17 18:07:23 +08003412
Lorenzo Colittid39345c2019-02-18 10:59:29 +09003413 // Start NAT64 prefix discovery and wait for it to complete.
Luke Huang5bd827c2019-03-14 16:10:04 +08003414 EXPECT_TRUE(mDnsClient.resolvService()->startPrefix64Discovery(TEST_NETID).isOk());
Hungming Chene8f970c2019-04-10 17:34:06 +08003415 EXPECT_TRUE(WaitForNat64Prefix(EXPECT_FOUND));
nuccachena26cc2a2018-07-17 18:07:23 +08003416
3417 // Using synthesized "localhost" address to be a trick for resolving host name
3418 // from host file /etc/hosts and "localhost" is the only name in /etc/hosts. Note that this is
3419 // not realistic: the code never synthesizes AAAA records for addresses in 127.0.0.0/8.
3420 struct in6_addr v6addr;
3421 inet_pton(AF_INET6, host_addr, &v6addr);
3422 struct hostent* result = gethostbyaddr(&v6addr, sizeof(v6addr), AF_INET6);
3423 ASSERT_TRUE(result != nullptr);
3424 // Expect no DNS queries; localhost is resolved via /etc/hosts.
3425 EXPECT_EQ(0U, GetNumQueries(dns, host_name));
3426
Luke Huangf8215372019-11-22 11:53:41 +08003427 ASSERT_EQ(sizeof(in6_addr), (unsigned)result->h_length);
nuccachena26cc2a2018-07-17 18:07:23 +08003428 ASSERT_EQ(AF_INET6, result->h_addrtype);
3429 std::string result_str = ToString(result);
3430 EXPECT_EQ(result_str, host_addr);
3431 result_str = result->h_name ? result->h_name : "null";
3432 EXPECT_EQ(result_str, host_name);
3433}
3434
Hungming Chen9e6185a2019-06-04 16:09:19 +08003435TEST_F(ResolverTest, GetHostByAddr_cnamesClasslessReverseDelegation) {
3436 // IPv4 addresses in the subnet with notation '/' or '-'.
3437 constexpr char addr_slash[] = "192.0.2.1";
3438 constexpr char addr_hyphen[] = "192.0.3.1";
3439
3440 // Used to verify DNS reverse query for classless reverse lookup zone. See detail in RFC 2317
3441 // section 4.
3442 const static std::vector<DnsRecord> records = {
3443 // The records for reverse querying "192.0.2.1" in the subnet with notation '/'.
3444 {"1.2.0.192.in-addr.arpa.", ns_type::ns_t_cname, "1.0/25.2.0.192.in-addr.arpa."},
3445 {"1.0/25.2.0.192.in-addr.arpa.", ns_type::ns_t_ptr, kHelloExampleCom},
3446
3447 // The records for reverse querying "192.0.3.1" in the subnet with notation '-'.
3448 {"1.3.0.192.in-addr.arpa.", ns_type::ns_t_cname, "1.0-127.3.0.192.in-addr.arpa."},
3449 {"1.0-127.3.0.192.in-addr.arpa.", ns_type::ns_t_ptr, kHelloExampleCom},
3450 };
3451
3452 test::DNSResponder dns;
3453 StartDns(dns, records);
3454 ASSERT_TRUE(mDnsClient.SetResolversForNetwork());
3455
3456 for (const auto& address : {addr_slash, addr_hyphen}) {
3457 SCOPED_TRACE(address);
3458
3459 in_addr v4addr;
3460 ASSERT_TRUE(inet_pton(AF_INET, address, &v4addr));
3461 hostent* result = gethostbyaddr(&v4addr, sizeof(v4addr), AF_INET);
3462 ASSERT_TRUE(result != nullptr);
3463 EXPECT_STREQ("hello.example.com", result->h_name);
3464 }
3465}
3466
nuccachena26cc2a2018-07-17 18:07:23 +08003467TEST_F(ResolverTest, GetNameInfo_ReverseDnsQueryWithHavingNat64Prefix) {
3468 constexpr char listen_addr[] = "::1";
nuccachena26cc2a2018-07-17 18:07:23 +08003469 constexpr char dns64_name[] = "ipv4only.arpa.";
3470 constexpr char ptr_name[] = "v4v6.example.com.";
3471 // PTR record for IPv4 address 1.2.3.4
3472 constexpr char ptr_addr_v4[] = "4.3.2.1.in-addr.arpa.";
3473 // PTR record for IPv6 address 2001:db8::102:304
3474 constexpr char ptr_addr_v6[] =
3475 "4.0.3.0.2.0.1.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.8.b.d.0.1.0.0.2.ip6.arpa.";
Xiao Ma09b71022018-12-11 17:56:32 +09003476 const std::vector<DnsRecord> records = {
3477 {dns64_name, ns_type::ns_t_aaaa, "64:ff9b::192.0.0.170"},
3478 {ptr_addr_v4, ns_type::ns_t_ptr, ptr_name},
3479 {ptr_addr_v6, ns_type::ns_t_ptr, ptr_name},
3480 };
nuccachena26cc2a2018-07-17 18:07:23 +08003481
Xiao Ma09b71022018-12-11 17:56:32 +09003482 test::DNSResponder dns(listen_addr);
3483 StartDns(dns, records);
nuccachena26cc2a2018-07-17 18:07:23 +08003484 const std::vector<std::string> servers = {listen_addr};
Xiao Ma09b71022018-12-11 17:56:32 +09003485 ASSERT_TRUE(mDnsClient.SetResolversForNetwork(servers));
nuccachena26cc2a2018-07-17 18:07:23 +08003486
Lorenzo Colittid39345c2019-02-18 10:59:29 +09003487 // Start NAT64 prefix discovery and wait for it to complete.
Luke Huang5bd827c2019-03-14 16:10:04 +08003488 EXPECT_TRUE(mDnsClient.resolvService()->startPrefix64Discovery(TEST_NETID).isOk());
Hungming Chene8f970c2019-04-10 17:34:06 +08003489 EXPECT_TRUE(WaitForNat64Prefix(EXPECT_FOUND));
nuccachena26cc2a2018-07-17 18:07:23 +08003490
Luke Huangf8215372019-11-22 11:53:41 +08003491 // clang-format off
nuccachena26cc2a2018-07-17 18:07:23 +08003492 static const struct TestConfig {
3493 int flag;
3494 int family;
3495 std::string addr;
3496 std::string host;
3497
3498 std::string asParameters() const {
3499 return StringPrintf("flag=%d, family=%d, addr=%s, host=%s", flag, family, addr.c_str(),
3500 host.c_str());
3501 }
3502 } testConfigs[]{
3503 {NI_NAMEREQD, AF_INET, "1.2.3.4", "v4v6.example.com"},
3504 {NI_NUMERICHOST, AF_INET, "1.2.3.4", "1.2.3.4"},
3505 {0, AF_INET, "1.2.3.4", "v4v6.example.com"},
3506 {0, AF_INET, "5.6.7.8", "5.6.7.8"}, // unmapped
3507 {NI_NAMEREQD, AF_INET6, "2001:db8::102:304", "v4v6.example.com"},
3508 {NI_NUMERICHOST, AF_INET6, "2001:db8::102:304", "2001:db8::102:304"},
3509 {0, AF_INET6, "2001:db8::102:304", "v4v6.example.com"},
3510 {0, AF_INET6, "2001:db8::506:708", "2001:db8::506:708"}, // unmapped
3511 };
Luke Huangf8215372019-11-22 11:53:41 +08003512 // clang-format on
nuccachena26cc2a2018-07-17 18:07:23 +08003513
3514 // Reverse IPv4/IPv6 DNS query. Prefix should have no effect on it.
3515 for (const auto& config : testConfigs) {
3516 SCOPED_TRACE(config.asParameters());
3517
3518 int rv;
3519 char host[NI_MAXHOST];
3520 struct sockaddr_in sin;
3521 struct sockaddr_in6 sin6;
3522 if (config.family == AF_INET) {
3523 memset(&sin, 0, sizeof(sin));
3524 sin.sin_family = AF_INET;
3525 inet_pton(AF_INET, config.addr.c_str(), &sin.sin_addr);
Luke Huangf8215372019-11-22 11:53:41 +08003526 rv = getnameinfo((const struct sockaddr*)&sin, sizeof(sin), host, sizeof(host), nullptr,
3527 0, config.flag);
nuccachena26cc2a2018-07-17 18:07:23 +08003528 if (config.flag == NI_NAMEREQD) EXPECT_LE(1U, GetNumQueries(dns, ptr_addr_v4));
3529 } else if (config.family == AF_INET6) {
3530 memset(&sin6, 0, sizeof(sin6));
3531 sin6.sin6_family = AF_INET6;
3532 inet_pton(AF_INET6, config.addr.c_str(), &sin6.sin6_addr);
Luke Huangf8215372019-11-22 11:53:41 +08003533 rv = getnameinfo((const struct sockaddr*)&sin6, sizeof(sin6), host, sizeof(host),
nuccachena26cc2a2018-07-17 18:07:23 +08003534 nullptr, 0, config.flag);
3535 if (config.flag == NI_NAMEREQD) EXPECT_LE(1U, GetNumQueries(dns, ptr_addr_v6));
3536 }
3537 ASSERT_EQ(0, rv);
3538 std::string result_str = host;
3539 EXPECT_EQ(result_str, config.host);
3540 dns.clearQueries();
3541 }
3542}
3543
3544TEST_F(ResolverTest, GetNameInfo_ReverseDns64Query) {
3545 constexpr char listen_addr[] = "::1";
nuccachena26cc2a2018-07-17 18:07:23 +08003546 constexpr char dns64_name[] = "ipv4only.arpa.";
3547 constexpr char ptr_name[] = "v4only.example.com.";
3548 // PTR record for IPv4 address 1.2.3.4
3549 constexpr char ptr_addr_v4[] = "4.3.2.1.in-addr.arpa.";
3550 // PTR record for IPv6 address 64:ff9b::1.2.3.4
3551 constexpr char ptr_addr_v6_nomapping[] =
3552 "4.0.3.0.2.0.1.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.b.9.f.f.4.6.0.0.ip6.arpa.";
3553 constexpr char ptr_name_v6_synthesis[] = "v6synthesis.example.com.";
3554 // PTR record for IPv6 address 64:ff9b::5.6.7.8
3555 constexpr char ptr_addr_v6_synthesis[] =
3556 "8.0.7.0.6.0.5.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.b.9.f.f.4.6.0.0.ip6.arpa.";
Xiao Ma09b71022018-12-11 17:56:32 +09003557 const std::vector<DnsRecord> records = {
3558 {dns64_name, ns_type::ns_t_aaaa, "64:ff9b::192.0.0.170"},
3559 {ptr_addr_v4, ns_type::ns_t_ptr, ptr_name},
3560 {ptr_addr_v6_synthesis, ns_type::ns_t_ptr, ptr_name_v6_synthesis},
3561 };
nuccachena26cc2a2018-07-17 18:07:23 +08003562
Xiao Ma09b71022018-12-11 17:56:32 +09003563 test::DNSResponder dns(listen_addr);
3564 StartDns(dns, records);
nuccachena26cc2a2018-07-17 18:07:23 +08003565 const std::vector<std::string> servers = {listen_addr};
Xiao Ma09b71022018-12-11 17:56:32 +09003566 ASSERT_TRUE(mDnsClient.SetResolversForNetwork(servers));
nuccachena26cc2a2018-07-17 18:07:23 +08003567
Lorenzo Colittid39345c2019-02-18 10:59:29 +09003568 // Start NAT64 prefix discovery and wait for it to complete.
Luke Huang5bd827c2019-03-14 16:10:04 +08003569 EXPECT_TRUE(mDnsClient.resolvService()->startPrefix64Discovery(TEST_NETID).isOk());
Hungming Chene8f970c2019-04-10 17:34:06 +08003570 EXPECT_TRUE(WaitForNat64Prefix(EXPECT_FOUND));
nuccachena26cc2a2018-07-17 18:07:23 +08003571
Luke Huangf8215372019-11-22 11:53:41 +08003572 // clang-format off
nuccachena26cc2a2018-07-17 18:07:23 +08003573 static const struct TestConfig {
3574 bool hasSynthesizedPtrRecord;
3575 int flag;
3576 std::string addr;
3577 std::string host;
3578
3579 std::string asParameters() const {
3580 return StringPrintf("hasSynthesizedPtrRecord=%d, flag=%d, addr=%s, host=%s",
3581 hasSynthesizedPtrRecord, flag, addr.c_str(), host.c_str());
3582 }
3583 } testConfigs[]{
3584 {false, NI_NAMEREQD, "64:ff9b::102:304", "v4only.example.com"},
3585 {false, NI_NUMERICHOST, "64:ff9b::102:304", "64:ff9b::102:304"},
3586 {false, 0, "64:ff9b::102:304", "v4only.example.com"},
3587 {true, NI_NAMEREQD, "64:ff9b::506:708", "v6synthesis.example.com"},
3588 {true, NI_NUMERICHOST, "64:ff9b::506:708", "64:ff9b::506:708"},
3589 {true, 0, "64:ff9b::506:708", "v6synthesis.example.com"}
3590 };
Luke Huangf8215372019-11-22 11:53:41 +08003591 // clang-format on
nuccachena26cc2a2018-07-17 18:07:23 +08003592
3593 // hasSynthesizedPtrRecord = false
3594 // Synthesized PTR record doesn't exist on DNS server
3595 // Reverse IPv6 DNS64 query while DNS server doesn't have an answer for synthesized address.
3596 // After querying synthesized address failed, expect that prefix is removed from IPv6
3597 // synthesized address and do reverse IPv4 query instead.
3598 //
3599 // hasSynthesizedPtrRecord = true
3600 // Synthesized PTR record exists on DNS server
3601 // Reverse IPv6 DNS64 query while DNS server has an answer for synthesized address.
3602 // Expect to just pass through synthesized address for DNS queries.
3603 for (const auto& config : testConfigs) {
3604 SCOPED_TRACE(config.asParameters());
3605
3606 char host[NI_MAXHOST];
3607 struct sockaddr_in6 sin6;
3608 memset(&sin6, 0, sizeof(sin6));
3609 sin6.sin6_family = AF_INET6;
3610 inet_pton(AF_INET6, config.addr.c_str(), &sin6.sin6_addr);
Luke Huangf8215372019-11-22 11:53:41 +08003611 int rv = getnameinfo((const struct sockaddr*)&sin6, sizeof(sin6), host, sizeof(host),
nuccachena26cc2a2018-07-17 18:07:23 +08003612 nullptr, 0, config.flag);
3613 ASSERT_EQ(0, rv);
3614 if (config.flag == NI_NAMEREQD) {
3615 if (config.hasSynthesizedPtrRecord) {
3616 EXPECT_LE(1U, GetNumQueries(dns, ptr_addr_v6_synthesis));
3617 } else {
3618 EXPECT_LE(1U, GetNumQueries(dns, ptr_addr_v6_nomapping)); // PTR record not exist.
3619 EXPECT_LE(1U, GetNumQueries(dns, ptr_addr_v4)); // PTR record exist.
3620 }
3621 }
3622 std::string result_str = host;
3623 EXPECT_EQ(result_str, config.host);
3624 dns.clearQueries();
3625 }
3626}
3627
3628TEST_F(ResolverTest, GetNameInfo_ReverseDns64QueryFromHostFile) {
3629 constexpr char dns64_name[] = "ipv4only.arpa.";
3630 constexpr char host_name[] = "localhost";
3631 // The address is synthesized by prefix64:localhost.
3632 constexpr char host_addr[] = "64:ff9b::7f00:1";
nuccachena26cc2a2018-07-17 18:07:23 +08003633 constexpr char listen_addr[] = "::1";
Xiao Ma09b71022018-12-11 17:56:32 +09003634
3635 test::DNSResponder dns(listen_addr);
Bernie Innocenti0ad80e92020-01-23 22:20:44 +09003636
Xiao Ma09b71022018-12-11 17:56:32 +09003637 StartDns(dns, {{dns64_name, ns_type::ns_t_aaaa, "64:ff9b::192.0.0.170"}});
nuccachena26cc2a2018-07-17 18:07:23 +08003638 const std::vector<std::string> servers = {listen_addr};
Xiao Ma09b71022018-12-11 17:56:32 +09003639 ASSERT_TRUE(mDnsClient.SetResolversForNetwork(servers));
nuccachena26cc2a2018-07-17 18:07:23 +08003640
Lorenzo Colittid39345c2019-02-18 10:59:29 +09003641 // Start NAT64 prefix discovery and wait for it to complete.
Luke Huang5bd827c2019-03-14 16:10:04 +08003642 EXPECT_TRUE(mDnsClient.resolvService()->startPrefix64Discovery(TEST_NETID).isOk());
Hungming Chene8f970c2019-04-10 17:34:06 +08003643 EXPECT_TRUE(WaitForNat64Prefix(EXPECT_FOUND));
nuccachena26cc2a2018-07-17 18:07:23 +08003644
3645 // Using synthesized "localhost" address to be a trick for resolving host name
3646 // from host file /etc/hosts and "localhost" is the only name in /etc/hosts. Note that this is
3647 // not realistic: the code never synthesizes AAAA records for addresses in 127.0.0.0/8.
3648 char host[NI_MAXHOST];
Xiao Ma09b71022018-12-11 17:56:32 +09003649 struct sockaddr_in6 sin6 = {.sin6_family = AF_INET6};
nuccachena26cc2a2018-07-17 18:07:23 +08003650 inet_pton(AF_INET6, host_addr, &sin6.sin6_addr);
Luke Huangf8215372019-11-22 11:53:41 +08003651 int rv = getnameinfo((const struct sockaddr*)&sin6, sizeof(sin6), host, sizeof(host), nullptr,
nuccachena26cc2a2018-07-17 18:07:23 +08003652 0, NI_NAMEREQD);
3653 ASSERT_EQ(0, rv);
3654 // Expect no DNS queries; localhost is resolved via /etc/hosts.
3655 EXPECT_EQ(0U, GetNumQueries(dns, host_name));
3656
3657 std::string result_str = host;
3658 EXPECT_EQ(result_str, host_name);
3659}
3660
Hungming Chen9e6185a2019-06-04 16:09:19 +08003661TEST_F(ResolverTest, GetNameInfo_cnamesClasslessReverseDelegation) {
3662 // IPv4 addresses in the subnet with notation '/' or '-'.
3663 constexpr char addr_slash[] = "192.0.2.1";
3664 constexpr char addr_hyphen[] = "192.0.3.1";
3665
3666 // Used to verify DNS reverse query for classless reverse lookup zone. See detail in RFC 2317
3667 // section 4.
3668 const static std::vector<DnsRecord> records = {
3669 // The records for reverse querying "192.0.2.1" in the subnet with notation '/'.
3670 {"1.2.0.192.in-addr.arpa.", ns_type::ns_t_cname, "1.0/25.2.0.192.in-addr.arpa."},
3671 {"1.0/25.2.0.192.in-addr.arpa.", ns_type::ns_t_ptr, kHelloExampleCom},
3672
3673 // The records for reverse querying "192.0.3.1" in the subnet with notation '-'.
3674 {"1.3.0.192.in-addr.arpa.", ns_type::ns_t_cname, "1.0-127.3.0.192.in-addr.arpa."},
3675 {"1.0-127.3.0.192.in-addr.arpa.", ns_type::ns_t_ptr, kHelloExampleCom},
3676 };
3677
3678 test::DNSResponder dns;
3679 StartDns(dns, records);
3680 ASSERT_TRUE(mDnsClient.SetResolversForNetwork());
3681
3682 for (const auto& address : {addr_slash, addr_hyphen}) {
3683 SCOPED_TRACE(address);
3684
3685 char host[NI_MAXHOST];
3686 sockaddr_in sin = {.sin_family = AF_INET};
3687 ASSERT_TRUE(inet_pton(AF_INET, address, &sin.sin_addr));
3688 int rv = getnameinfo((const sockaddr*)&sin, sizeof(sin), host, sizeof(host), nullptr, 0,
3689 NI_NAMEREQD);
3690 ASSERT_EQ(0, rv);
3691 EXPECT_STREQ("hello.example.com", host);
3692 }
3693}
3694
nuccachena26cc2a2018-07-17 18:07:23 +08003695TEST_F(ResolverTest, GetHostByName2_Dns64Synthesize) {
Xiao Ma09b71022018-12-11 17:56:32 +09003696 constexpr char listen_addr[] = "::1";
nuccachena26cc2a2018-07-17 18:07:23 +08003697 constexpr char dns64_name[] = "ipv4only.arpa.";
3698 constexpr char host_name[] = "ipv4only.example.com.";
Xiao Ma09b71022018-12-11 17:56:32 +09003699 const std::vector<DnsRecord> records = {
3700 {dns64_name, ns_type::ns_t_aaaa, "64:ff9b::192.0.0.170"},
3701 {host_name, ns_type::ns_t_a, "1.2.3.4"},
3702 };
nuccachena26cc2a2018-07-17 18:07:23 +08003703
Xiao Ma09b71022018-12-11 17:56:32 +09003704 test::DNSResponder dns(listen_addr);
3705 StartDns(dns, records);
nuccachena26cc2a2018-07-17 18:07:23 +08003706 const std::vector<std::string> servers = {listen_addr};
Xiao Ma09b71022018-12-11 17:56:32 +09003707 ASSERT_TRUE(mDnsClient.SetResolversForNetwork(servers));
nuccachena26cc2a2018-07-17 18:07:23 +08003708
Lorenzo Colittid39345c2019-02-18 10:59:29 +09003709 // Start NAT64 prefix discovery and wait for it to complete.
Luke Huang5bd827c2019-03-14 16:10:04 +08003710 EXPECT_TRUE(mDnsClient.resolvService()->startPrefix64Discovery(TEST_NETID).isOk());
Hungming Chene8f970c2019-04-10 17:34:06 +08003711 EXPECT_TRUE(WaitForNat64Prefix(EXPECT_FOUND));
nuccachena26cc2a2018-07-17 18:07:23 +08003712
3713 // Query an IPv4-only hostname. Expect that gets a synthesized address.
3714 struct hostent* result = gethostbyname2("ipv4only", AF_INET6);
3715 ASSERT_TRUE(result != nullptr);
3716 EXPECT_LE(1U, GetNumQueries(dns, host_name));
3717 std::string result_str = ToString(result);
3718 EXPECT_EQ(result_str, "64:ff9b::102:304");
3719}
nuccachena26cc2a2018-07-17 18:07:23 +08003720
3721TEST_F(ResolverTest, GetHostByName2_DnsQueryWithHavingNat64Prefix) {
3722 constexpr char dns64_name[] = "ipv4only.arpa.";
3723 constexpr char host_name[] = "v4v6.example.com.";
nuccachena26cc2a2018-07-17 18:07:23 +08003724 constexpr char listen_addr[] = "::1";
Xiao Ma09b71022018-12-11 17:56:32 +09003725 const std::vector<DnsRecord> records = {
3726 {dns64_name, ns_type::ns_t_aaaa, "64:ff9b::192.0.0.170"},
3727 {host_name, ns_type::ns_t_a, "1.2.3.4"},
3728 {host_name, ns_type::ns_t_aaaa, "2001:db8::1.2.3.4"},
3729 };
3730
3731 test::DNSResponder dns(listen_addr);
3732 StartDns(dns, records);
nuccachena26cc2a2018-07-17 18:07:23 +08003733 const std::vector<std::string> servers = {listen_addr};
Xiao Ma09b71022018-12-11 17:56:32 +09003734 ASSERT_TRUE(mDnsClient.SetResolversForNetwork(servers));
nuccachena26cc2a2018-07-17 18:07:23 +08003735
Lorenzo Colittid39345c2019-02-18 10:59:29 +09003736 // Start NAT64 prefix discovery and wait for it to complete.
Luke Huang5bd827c2019-03-14 16:10:04 +08003737 EXPECT_TRUE(mDnsClient.resolvService()->startPrefix64Discovery(TEST_NETID).isOk());
Hungming Chene8f970c2019-04-10 17:34:06 +08003738 EXPECT_TRUE(WaitForNat64Prefix(EXPECT_FOUND));
nuccachena26cc2a2018-07-17 18:07:23 +08003739
3740 // IPv4 DNS query. Prefix should have no effect on it.
3741 struct hostent* result = gethostbyname2("v4v6", AF_INET);
3742 ASSERT_TRUE(result != nullptr);
3743 EXPECT_LE(1U, GetNumQueries(dns, host_name));
3744 std::string result_str = ToString(result);
3745 EXPECT_EQ(result_str, "1.2.3.4");
3746 dns.clearQueries();
3747
3748 // IPv6 DNS query. Prefix should have no effect on it.
3749 result = gethostbyname2("v4v6", AF_INET6);
3750 ASSERT_TRUE(result != nullptr);
3751 EXPECT_LE(1U, GetNumQueries(dns, host_name));
3752 result_str = ToString(result);
3753 EXPECT_EQ(result_str, "2001:db8::102:304");
3754}
3755
3756TEST_F(ResolverTest, GetHostByName2_Dns64QuerySpecialUseIPv4Addresses) {
3757 constexpr char THIS_NETWORK[] = "this_network";
3758 constexpr char LOOPBACK[] = "loopback";
3759 constexpr char LINK_LOCAL[] = "link_local";
3760 constexpr char MULTICAST[] = "multicast";
3761 constexpr char LIMITED_BROADCAST[] = "limited_broadcast";
3762
3763 constexpr char ADDR_THIS_NETWORK[] = "0.0.0.1";
3764 constexpr char ADDR_LOOPBACK[] = "127.0.0.1";
3765 constexpr char ADDR_LINK_LOCAL[] = "169.254.0.1";
3766 constexpr char ADDR_MULTICAST[] = "224.0.0.1";
3767 constexpr char ADDR_LIMITED_BROADCAST[] = "255.255.255.255";
3768
3769 constexpr char listen_addr[] = "::1";
nuccachena26cc2a2018-07-17 18:07:23 +08003770 constexpr char dns64_name[] = "ipv4only.arpa.";
3771
Xiao Ma09b71022018-12-11 17:56:32 +09003772 test::DNSResponder dns(listen_addr);
3773 StartDns(dns, {{dns64_name, ns_type::ns_t_aaaa, "64:ff9b::"}});
nuccachena26cc2a2018-07-17 18:07:23 +08003774 const std::vector<std::string> servers = {listen_addr};
Xiao Ma09b71022018-12-11 17:56:32 +09003775 ASSERT_TRUE(mDnsClient.SetResolversForNetwork(servers));
nuccachena26cc2a2018-07-17 18:07:23 +08003776
Lorenzo Colittid39345c2019-02-18 10:59:29 +09003777 // Start NAT64 prefix discovery and wait for it to complete.
Luke Huang5bd827c2019-03-14 16:10:04 +08003778 EXPECT_TRUE(mDnsClient.resolvService()->startPrefix64Discovery(TEST_NETID).isOk());
Hungming Chene8f970c2019-04-10 17:34:06 +08003779 EXPECT_TRUE(WaitForNat64Prefix(EXPECT_FOUND));
nuccachena26cc2a2018-07-17 18:07:23 +08003780
Luke Huangf8215372019-11-22 11:53:41 +08003781 // clang-format off
nuccachena26cc2a2018-07-17 18:07:23 +08003782 static const struct TestConfig {
3783 std::string name;
3784 std::string addr;
3785
3786 std::string asHostName() const {
Luke Huangf8215372019-11-22 11:53:41 +08003787 return StringPrintf("%s.example.com.", name.c_str());
nuccachena26cc2a2018-07-17 18:07:23 +08003788 }
3789 } testConfigs[]{
3790 {THIS_NETWORK, ADDR_THIS_NETWORK},
3791 {LOOPBACK, ADDR_LOOPBACK},
3792 {LINK_LOCAL, ADDR_LINK_LOCAL},
3793 {MULTICAST, ADDR_MULTICAST},
3794 {LIMITED_BROADCAST, ADDR_LIMITED_BROADCAST}
3795 };
Luke Huangf8215372019-11-22 11:53:41 +08003796 // clang-format on
nuccachena26cc2a2018-07-17 18:07:23 +08003797
3798 for (const auto& config : testConfigs) {
3799 const std::string testHostName = config.asHostName();
3800 SCOPED_TRACE(testHostName);
3801
3802 const char* host_name = testHostName.c_str();
3803 dns.addMapping(host_name, ns_type::ns_t_a, config.addr.c_str());
3804
3805 struct hostent* result = gethostbyname2(config.name.c_str(), AF_INET6);
3806 EXPECT_LE(1U, GetNumQueries(dns, host_name));
3807
3808 // In AF_INET6 case, don't synthesize special use IPv4 address.
3809 // Expect to have no answer
3810 EXPECT_EQ(nullptr, result);
3811
3812 dns.clearQueries();
3813 }
Bernie Innocenti2fef2b82018-12-20 15:56:40 +09003814}
Mike Yuf14e1a92019-05-10 13:54:58 +08003815
3816TEST_F(ResolverTest, PrefixDiscoveryBypassTls) {
3817 constexpr char listen_addr[] = "::1";
3818 constexpr char cleartext_port[] = "53";
3819 constexpr char tls_port[] = "853";
3820 constexpr char dns64_name[] = "ipv4only.arpa.";
3821 const std::vector<std::string> servers = {listen_addr};
3822
3823 test::DNSResponder dns(listen_addr);
3824 StartDns(dns, {{dns64_name, ns_type::ns_t_aaaa, "64:ff9b::192.0.0.170"}});
3825 test::DnsTlsFrontend tls(listen_addr, tls_port, listen_addr, cleartext_port);
3826 ASSERT_TRUE(tls.startServer());
3827
3828 // Setup OPPORTUNISTIC mode and wait for the validation complete.
waynema0e73c2e2019-07-31 15:04:08 +08003829 ASSERT_TRUE(mDnsClient.SetResolversWithTls(servers, kDefaultSearchDomains, kDefaultParams, ""));
Mike Yu724f77d2019-08-16 11:14:50 +08003830 EXPECT_TRUE(WaitForPrivateDnsValidation(tls.listen_address(), true));
Bernie Innocenti0ad80e92020-01-23 22:20:44 +09003831 EXPECT_TRUE(tls.waitForQueries(1));
Mike Yuf14e1a92019-05-10 13:54:58 +08003832 tls.clearQueries();
3833
3834 // Start NAT64 prefix discovery and wait for it complete.
3835 EXPECT_TRUE(mDnsClient.resolvService()->startPrefix64Discovery(TEST_NETID).isOk());
Hungming Chene8f970c2019-04-10 17:34:06 +08003836 EXPECT_TRUE(WaitForNat64Prefix(EXPECT_FOUND));
Mike Yuf14e1a92019-05-10 13:54:58 +08003837
3838 // Verify it bypassed TLS even though there's a TLS server available.
Bernie Innocenti0ad80e92020-01-23 22:20:44 +09003839 EXPECT_EQ(0, tls.queries()) << dns.dumpQueries();
3840 EXPECT_EQ(1U, GetNumQueries(dns, dns64_name)) << dns.dumpQueries();
Mike Yuf14e1a92019-05-10 13:54:58 +08003841
3842 // Restart the testing network to reset the cache.
3843 mDnsClient.TearDown();
3844 mDnsClient.SetUp();
3845 dns.clearQueries();
3846
3847 // Setup STRICT mode and wait for the validation complete.
waynema0e73c2e2019-07-31 15:04:08 +08003848 ASSERT_TRUE(mDnsClient.SetResolversWithTls(servers, kDefaultSearchDomains, kDefaultParams,
3849 kDefaultPrivateDnsHostName));
Mike Yu724f77d2019-08-16 11:14:50 +08003850 EXPECT_TRUE(WaitForPrivateDnsValidation(tls.listen_address(), true));
Bernie Innocenti0ad80e92020-01-23 22:20:44 +09003851 EXPECT_TRUE(tls.waitForQueries(1));
Mike Yuf14e1a92019-05-10 13:54:58 +08003852 tls.clearQueries();
3853
3854 // Start NAT64 prefix discovery and wait for it to complete.
3855 EXPECT_TRUE(mDnsClient.resolvService()->startPrefix64Discovery(TEST_NETID).isOk());
Hungming Chene8f970c2019-04-10 17:34:06 +08003856 EXPECT_TRUE(WaitForNat64Prefix(EXPECT_FOUND));
Mike Yuf14e1a92019-05-10 13:54:58 +08003857
3858 // Verify it bypassed TLS despite STRICT mode.
Bernie Innocenti0ad80e92020-01-23 22:20:44 +09003859 EXPECT_EQ(0, tls.queries()) << dns.dumpQueries();
3860 EXPECT_EQ(1U, GetNumQueries(dns, dns64_name)) << dns.dumpQueries();
Mike Yuf14e1a92019-05-10 13:54:58 +08003861}
Luke Huang9807e6b2019-05-20 16:17:12 +08003862
Lorenzo Colittie51091d2020-05-20 02:48:44 +09003863TEST_F(ResolverTest, SetAndClearNat64Prefix) {
3864 constexpr char host_name[] = "v4.example.com.";
3865 constexpr char listen_addr[] = "::1";
3866 const std::vector<DnsRecord> records = {
3867 {host_name, ns_type::ns_t_a, "1.2.3.4"},
3868 };
3869 const std::string kNat64Prefix1 = "64:ff9b::/96";
3870 const std::string kNat64Prefix2 = "2001:db8:6464::/96";
3871
3872 test::DNSResponder dns(listen_addr);
3873 StartDns(dns, records);
3874 const std::vector<std::string> servers = {listen_addr};
3875 ASSERT_TRUE(mDnsClient.SetResolversForNetwork(servers));
3876
3877 auto resolvService = mDnsClient.resolvService();
3878 addrinfo hints = {.ai_family = AF_INET6};
3879
3880 // No NAT64 prefix, no AAAA record.
3881 ScopedAddrinfo result = safe_getaddrinfo("v4.example.com", nullptr, &hints);
3882 ASSERT_TRUE(result == nullptr);
3883
3884 // Set the prefix, and expect to get a synthesized AAAA record.
3885 EXPECT_TRUE(resolvService->setPrefix64(TEST_NETID, kNat64Prefix2).isOk());
3886 result = safe_getaddrinfo("v4.example.com", nullptr, &hints);
3887 ASSERT_FALSE(result == nullptr);
3888 EXPECT_EQ("2001:db8:6464::102:304", ToString(result));
3889
3890 // Update the prefix, expect to see AAAA records from the new prefix.
3891 EXPECT_TRUE(resolvService->setPrefix64(TEST_NETID, kNat64Prefix1).isOk());
3892 result = safe_getaddrinfo("v4.example.com", nullptr, &hints);
3893 ASSERT_FALSE(result == nullptr);
3894 EXPECT_EQ("64:ff9b::102:304", ToString(result));
3895
3896 // Non-/96 prefixes are ignored.
3897 auto status = resolvService->setPrefix64(TEST_NETID, "64:ff9b::/64");
3898 EXPECT_FALSE(status.isOk());
3899 EXPECT_EQ(EX_SERVICE_SPECIFIC, status.getExceptionCode());
3900 EXPECT_EQ(EINVAL, status.getServiceSpecificError());
3901
3902 // Invalid prefixes are ignored.
3903 status = resolvService->setPrefix64(TEST_NETID, "192.0.2.0/24");
3904 EXPECT_FALSE(status.isOk());
3905 EXPECT_EQ(EX_SERVICE_SPECIFIC, status.getExceptionCode());
3906 EXPECT_EQ(EINVAL, status.getServiceSpecificError());
3907
3908 status = resolvService->setPrefix64(TEST_NETID, "192.0.2.1");
3909 EXPECT_FALSE(status.isOk());
3910 EXPECT_EQ(EX_SERVICE_SPECIFIC, status.getExceptionCode());
3911 EXPECT_EQ(EINVAL, status.getServiceSpecificError());
3912
3913 status = resolvService->setPrefix64(TEST_NETID, "hello");
3914 EXPECT_FALSE(status.isOk());
3915 EXPECT_EQ(EX_SERVICE_SPECIFIC, status.getExceptionCode());
3916 EXPECT_EQ(EINVAL, status.getServiceSpecificError());
3917
3918 // DNS64 synthesis is still working.
3919 result = safe_getaddrinfo("v4.example.com", nullptr, &hints);
3920 ASSERT_FALSE(result == nullptr);
3921 EXPECT_EQ("64:ff9b::102:304", ToString(result));
3922
3923 // Clear the prefix. No AAAA records any more.
3924 EXPECT_TRUE(resolvService->setPrefix64(TEST_NETID, "").isOk());
3925 result = safe_getaddrinfo("v4.example.com", nullptr, &hints);
3926 EXPECT_TRUE(result == nullptr);
3927
3928 // Calling startPrefix64Discovery clears the prefix.
3929 EXPECT_TRUE(resolvService->setPrefix64(TEST_NETID, kNat64Prefix1).isOk());
3930 result = safe_getaddrinfo("v4.example.com", nullptr, &hints);
3931 ASSERT_FALSE(result == nullptr);
3932 EXPECT_EQ("64:ff9b::102:304", ToString(result));
3933
3934 EXPECT_TRUE(resolvService->startPrefix64Discovery(TEST_NETID).isOk());
3935 result = safe_getaddrinfo("v4.example.com", nullptr, &hints);
3936 ASSERT_TRUE(result == nullptr);
3937
3938 // setPrefix64 fails if prefix discovery is started, even if no prefix is yet discovered...
3939 status = resolvService->setPrefix64(TEST_NETID, kNat64Prefix1);
3940 EXPECT_FALSE(status.isOk());
3941 EXPECT_EQ(EX_SERVICE_SPECIFIC, status.getExceptionCode());
3942 EXPECT_EQ(EEXIST, status.getServiceSpecificError());
3943
3944 // .. and clearing the prefix also has no effect.
3945 status = resolvService->setPrefix64(TEST_NETID, "");
3946 EXPECT_FALSE(status.isOk());
3947 EXPECT_EQ(EX_SERVICE_SPECIFIC, status.getExceptionCode());
3948 EXPECT_EQ(ENOENT, status.getServiceSpecificError());
3949
3950 // setPrefix64 succeeds again when prefix discovery is stopped.
3951 EXPECT_TRUE(resolvService->stopPrefix64Discovery(TEST_NETID).isOk());
3952 EXPECT_TRUE(resolvService->setPrefix64(TEST_NETID, kNat64Prefix1).isOk());
3953 result = safe_getaddrinfo("v4.example.com", nullptr, &hints);
3954 ASSERT_FALSE(result == nullptr);
3955 EXPECT_EQ("64:ff9b::102:304", ToString(result));
3956
3957 // Calling stopPrefix64Discovery clears the prefix.
3958 EXPECT_TRUE(resolvService->stopPrefix64Discovery(TEST_NETID).isOk());
3959 result = safe_getaddrinfo("v4.example.com", nullptr, &hints);
3960 ASSERT_TRUE(result == nullptr);
3961
3962 // Set up NAT64 prefix discovery.
3963 constexpr char dns64_name[] = "ipv4only.arpa.";
3964 const std::vector<DnsRecord> newRecords = {
3965 {host_name, ns_type::ns_t_a, "1.2.3.4"},
3966 {dns64_name, ns_type::ns_t_aaaa, "64:ff9b::192.0.0.170"},
3967 };
3968 dns.stopServer();
3969 StartDns(dns, newRecords);
3970
3971 EXPECT_TRUE(resolvService->startPrefix64Discovery(TEST_NETID).isOk());
3972 EXPECT_TRUE(WaitForNat64Prefix(EXPECT_FOUND));
3973 result = safe_getaddrinfo("v4.example.com", nullptr, &hints);
3974 ASSERT_FALSE(result == nullptr);
3975 EXPECT_EQ("64:ff9b::102:304", ToString(result));
3976
3977 // setPrefix64 fails if NAT64 prefix discovery has succeeded, and the discovered prefix
3978 // continues to be used.
3979 status = resolvService->setPrefix64(TEST_NETID, kNat64Prefix2);
3980 EXPECT_FALSE(status.isOk());
3981 EXPECT_EQ(EX_SERVICE_SPECIFIC, status.getExceptionCode());
3982 EXPECT_EQ(EEXIST, status.getServiceSpecificError());
3983
3984 // Clearing the prefix also has no effect if discovery is started.
3985 status = resolvService->setPrefix64(TEST_NETID, "");
3986 EXPECT_FALSE(status.isOk());
3987 EXPECT_EQ(EX_SERVICE_SPECIFIC, status.getExceptionCode());
3988 EXPECT_EQ(ENOENT, status.getServiceSpecificError());
3989
3990 result = safe_getaddrinfo("v4.example.com", nullptr, &hints);
3991 ASSERT_FALSE(result == nullptr);
3992 EXPECT_EQ("64:ff9b::102:304", ToString(result));
3993
3994 EXPECT_TRUE(resolvService->stopPrefix64Discovery(TEST_NETID).isOk());
3995 EXPECT_TRUE(WaitForNat64Prefix(EXPECT_NOT_FOUND));
Lorenzo Colitti61f796b2020-05-21 00:57:49 +09003996
3997 EXPECT_EQ(0, sDnsMetricsListener->getUnexpectedNat64PrefixUpdates());
Lorenzo Colittie51091d2020-05-20 02:48:44 +09003998}
3999
Luke Huang9807e6b2019-05-20 16:17:12 +08004000namespace {
4001
Luke Huang0d592bc2019-05-25 18:24:03 +08004002class ScopedSetNetworkForProcess {
4003 public:
4004 explicit ScopedSetNetworkForProcess(unsigned netId) {
4005 mStoredNetId = getNetworkForProcess();
4006 if (netId == mStoredNetId) return;
4007 EXPECT_EQ(0, setNetworkForProcess(netId));
4008 }
4009 ~ScopedSetNetworkForProcess() { EXPECT_EQ(0, setNetworkForProcess(mStoredNetId)); }
4010
4011 private:
4012 unsigned mStoredNetId;
4013};
4014
4015class ScopedSetNetworkForResolv {
4016 public:
4017 explicit ScopedSetNetworkForResolv(unsigned netId) { EXPECT_EQ(0, setNetworkForResolv(netId)); }
4018 ~ScopedSetNetworkForResolv() { EXPECT_EQ(0, setNetworkForResolv(NETID_UNSET)); }
4019};
4020
Luke Huang9807e6b2019-05-20 16:17:12 +08004021void sendCommand(int fd, const std::string& cmd) {
4022 ssize_t rc = TEMP_FAILURE_RETRY(write(fd, cmd.c_str(), cmd.size() + 1));
4023 EXPECT_EQ(rc, static_cast<ssize_t>(cmd.size() + 1));
4024}
4025
4026int32_t readBE32(int fd) {
4027 int32_t tmp;
4028 int n = TEMP_FAILURE_RETRY(read(fd, &tmp, sizeof(tmp)));
4029 EXPECT_TRUE(n > 0);
4030 return ntohl(tmp);
4031}
4032
Luke Huang0d592bc2019-05-25 18:24:03 +08004033int readResponseCode(int fd) {
Luke Huang9807e6b2019-05-20 16:17:12 +08004034 char buf[4];
4035 int n = TEMP_FAILURE_RETRY(read(fd, &buf, sizeof(buf)));
4036 EXPECT_TRUE(n > 0);
4037 // The format of response code is that 4 bytes for the code & null.
4038 buf[3] = '\0';
4039 int result;
4040 EXPECT_TRUE(ParseInt(buf, &result));
4041 return result;
4042}
4043
Luke Huang0d592bc2019-05-25 18:24:03 +08004044bool checkAndClearUseLocalNameserversFlag(unsigned* netid) {
4045 if (netid == nullptr || ((*netid) & NETID_USE_LOCAL_NAMESERVERS) == 0) {
4046 return false;
4047 }
4048 *netid = (*netid) & ~NETID_USE_LOCAL_NAMESERVERS;
4049 return true;
4050}
4051
Luke Huangf8215372019-11-22 11:53:41 +08004052aidl::android::net::UidRangeParcel makeUidRangeParcel(int start, int stop) {
4053 aidl::android::net::UidRangeParcel res;
Luke Huang0d592bc2019-05-25 18:24:03 +08004054 res.start = start;
4055 res.stop = stop;
4056
4057 return res;
4058}
4059
4060void expectNetIdWithLocalNameserversFlag(unsigned netId) {
4061 unsigned dnsNetId = 0;
4062 EXPECT_EQ(0, getNetworkForDns(&dnsNetId));
4063 EXPECT_TRUE(checkAndClearUseLocalNameserversFlag(&dnsNetId));
4064 EXPECT_EQ(netId, static_cast<unsigned>(dnsNetId));
4065}
4066
4067void expectDnsNetIdEquals(unsigned netId) {
4068 unsigned dnsNetId = 0;
4069 EXPECT_EQ(0, getNetworkForDns(&dnsNetId));
4070 EXPECT_EQ(netId, static_cast<unsigned>(dnsNetId));
4071}
4072
Lorenzo Colittieb9aeec2019-06-26 19:53:55 +09004073void expectDnsNetIdIsDefaultNetwork(INetd* netdService) {
Luke Huang0d592bc2019-05-25 18:24:03 +08004074 int currentNetid;
4075 EXPECT_TRUE(netdService->networkGetDefault(&currentNetid).isOk());
4076 expectDnsNetIdEquals(currentNetid);
4077}
4078
Lorenzo Colittieb9aeec2019-06-26 19:53:55 +09004079void expectDnsNetIdWithVpn(INetd* netdService, unsigned vpnNetId, unsigned expectedNetId) {
Luke Huang0d592bc2019-05-25 18:24:03 +08004080 EXPECT_TRUE(netdService->networkCreateVpn(vpnNetId, false /* secure */).isOk());
4081 uid_t uid = getuid();
4082 // Add uid to VPN
4083 EXPECT_TRUE(netdService->networkAddUidRanges(vpnNetId, {makeUidRangeParcel(uid, uid)}).isOk());
4084 expectDnsNetIdEquals(expectedNetId);
4085 EXPECT_TRUE(netdService->networkDestroy(vpnNetId).isOk());
4086}
4087
Luke Huang9807e6b2019-05-20 16:17:12 +08004088} // namespace
4089
4090TEST_F(ResolverTest, getDnsNetId) {
4091 // We've called setNetworkForProcess in SetupOemNetwork, so reset to default first.
4092 setNetworkForProcess(NETID_UNSET);
Luke Huang0d592bc2019-05-25 18:24:03 +08004093
4094 expectDnsNetIdIsDefaultNetwork(mDnsClient.netdService());
4095 expectDnsNetIdWithVpn(mDnsClient.netdService(), TEST_VPN_NETID, TEST_VPN_NETID);
Luke Huang9807e6b2019-05-20 16:17:12 +08004096
4097 // Test with setNetworkForProcess
Luke Huang0d592bc2019-05-25 18:24:03 +08004098 {
4099 ScopedSetNetworkForProcess scopedSetNetworkForProcess(TEST_NETID);
4100 expectDnsNetIdEquals(TEST_NETID);
4101 }
4102
4103 // Test with setNetworkForProcess with NETID_USE_LOCAL_NAMESERVERS
4104 {
4105 ScopedSetNetworkForProcess scopedSetNetworkForProcess(TEST_NETID |
4106 NETID_USE_LOCAL_NAMESERVERS);
4107 expectNetIdWithLocalNameserversFlag(TEST_NETID);
4108 }
Luke Huang9807e6b2019-05-20 16:17:12 +08004109
4110 // Test with setNetworkForResolv
Luke Huang0d592bc2019-05-25 18:24:03 +08004111 {
4112 ScopedSetNetworkForResolv scopedSetNetworkForResolv(TEST_NETID);
4113 expectDnsNetIdEquals(TEST_NETID);
4114 }
4115
4116 // Test with setNetworkForResolv with NETID_USE_LOCAL_NAMESERVERS
4117 {
4118 ScopedSetNetworkForResolv scopedSetNetworkForResolv(TEST_NETID |
4119 NETID_USE_LOCAL_NAMESERVERS);
4120 expectNetIdWithLocalNameserversFlag(TEST_NETID);
4121 }
4122
4123 // Test with setNetworkForResolv under bypassable vpn
4124 {
4125 ScopedSetNetworkForResolv scopedSetNetworkForResolv(TEST_NETID);
4126 expectDnsNetIdWithVpn(mDnsClient.netdService(), TEST_VPN_NETID, TEST_NETID);
4127 }
Luke Huang9807e6b2019-05-20 16:17:12 +08004128
4129 // Create socket connected to DnsProxyListener
4130 int fd = dns_open_proxy();
4131 EXPECT_TRUE(fd > 0);
4132 unique_fd ufd(fd);
4133
4134 // Test command with wrong netId
4135 sendCommand(fd, "getdnsnetid abc");
Luke Huang0d592bc2019-05-25 18:24:03 +08004136 EXPECT_EQ(ResponseCode::DnsProxyQueryResult, readResponseCode(fd));
Luke Huang9807e6b2019-05-20 16:17:12 +08004137 EXPECT_EQ(-EINVAL, readBE32(fd));
4138
4139 // Test unsupported command
4140 sendCommand(fd, "getdnsnetidNotSupported");
4141 // Keep in sync with FrameworkListener.cpp (500, "Command not recognized")
Luke Huang0d592bc2019-05-25 18:24:03 +08004142 EXPECT_EQ(500, readResponseCode(fd));
Luke Huang9807e6b2019-05-20 16:17:12 +08004143}
Sehee Park2c118782019-05-07 13:02:45 +09004144
4145TEST_F(ResolverTest, BlockDnsQueryWithUidRule) {
Lorenzo Colittieb9aeec2019-06-26 19:53:55 +09004146 // This test relies on blocking traffic on loopback, which xt_qtaguid does not do.
4147 // See aosp/358413 and b/34444781 for why.
4148 SKIP_IF_BPF_NOT_SUPPORTED;
4149
Sehee Park2c118782019-05-07 13:02:45 +09004150 constexpr char listen_addr1[] = "127.0.0.4";
4151 constexpr char listen_addr2[] = "::1";
4152 constexpr char host_name[] = "howdy.example.com.";
4153 const std::vector<DnsRecord> records = {
4154 {host_name, ns_type::ns_t_a, "1.2.3.4"},
4155 {host_name, ns_type::ns_t_aaaa, "::1.2.3.4"},
4156 };
Lorenzo Colittieb9aeec2019-06-26 19:53:55 +09004157 INetd* netdService = mDnsClient.netdService();
Sehee Park2c118782019-05-07 13:02:45 +09004158
4159 test::DNSResponder dns1(listen_addr1);
4160 test::DNSResponder dns2(listen_addr2);
4161 StartDns(dns1, records);
4162 StartDns(dns2, records);
4163
4164 std::vector<std::string> servers = {listen_addr1, listen_addr2};
4165 ASSERT_TRUE(mDnsClient.SetResolversForNetwork(servers));
4166 dns1.clearQueries();
4167 dns2.clearQueries();
4168
Luke Huangeb618ef2020-05-26 14:17:02 +08004169 ScopeBlockedUIDRule scopeBlockUidRule(netdService, TEST_UID);
Sehee Park2c118782019-05-07 13:02:45 +09004170 // Dns Query
4171 int fd1 = resNetworkQuery(TEST_NETID, host_name, ns_c_in, ns_t_a, 0);
4172 int fd2 = resNetworkQuery(TEST_NETID, host_name, ns_c_in, ns_t_aaaa, 0);
4173 EXPECT_TRUE(fd1 != -1);
4174 EXPECT_TRUE(fd2 != -1);
4175
Luke Huang5729afc2020-07-30 23:12:17 +08004176 uint8_t buf1[MAXPACKET] = {};
4177 uint8_t buf2[MAXPACKET] = {};
Sehee Park2c118782019-05-07 13:02:45 +09004178 int rcode;
Luke Huang5729afc2020-07-30 23:12:17 +08004179 int res2 = getAsyncResponse(fd2, &rcode, buf2, MAXPACKET);
4180 int res1 = getAsyncResponse(fd1, &rcode, buf1, MAXPACKET);
4181 // If API level >= 30 (R+), these queries should be blocked.
4182 if (isAtLeastR) {
4183 EXPECT_EQ(res2, -ECONNREFUSED);
4184 EXPECT_EQ(res1, -ECONNREFUSED);
4185 ExpectDnsEvent(INetdEventListener::EVENT_RES_NSEND, EAI_SYSTEM, "howdy.example.com", {});
4186 ExpectDnsEvent(INetdEventListener::EVENT_RES_NSEND, EAI_SYSTEM, "howdy.example.com", {});
4187 } else {
4188 EXPECT_GT(res2, 0);
4189 EXPECT_EQ("::1.2.3.4", toString(buf2, res2, AF_INET6));
4190 EXPECT_GT(res1, 0);
4191 EXPECT_EQ("1.2.3.4", toString(buf1, res1, AF_INET));
4192 // To avoid flaky test, do not evaluate DnsEvent since event order is not guaranteed.
4193 }
Sehee Park2c118782019-05-07 13:02:45 +09004194}
Mike Yua772c202019-09-23 17:47:21 +08004195
Ken Chenbc481b82020-05-21 23:30:01 +08004196TEST_F(ResolverTest, EnforceDnsUid) {
4197 SKIP_IF_BPF_NOT_SUPPORTED;
4198
4199 constexpr char listen_addr1[] = "127.0.0.4";
4200 constexpr char listen_addr2[] = "::1";
4201 constexpr char host_name[] = "howdy.example.com.";
4202 const std::vector<DnsRecord> records = {
4203 {host_name, ns_type::ns_t_a, "1.2.3.4"},
4204 {host_name, ns_type::ns_t_aaaa, "::1.2.3.4"},
4205 };
4206 INetd* netdService = mDnsClient.netdService();
4207
4208 test::DNSResponder dns1(listen_addr1);
4209 test::DNSResponder dns2(listen_addr2);
4210 StartDns(dns1, records);
4211 StartDns(dns2, records);
4212
4213 // switch uid of DNS queries from applications to AID_DNS
4214 ResolverParamsParcel parcel = DnsResponderClient::GetDefaultResolverParamsParcel();
4215 parcel.servers = {listen_addr1, listen_addr2};
4216 ASSERT_TRUE(mDnsClient.resolvService()->setResolverConfiguration(parcel).isOk());
4217
4218 uint8_t buf[MAXPACKET] = {};
Luke Huang5729afc2020-07-30 23:12:17 +08004219 uint8_t buf2[MAXPACKET] = {};
Ken Chenbc481b82020-05-21 23:30:01 +08004220 int rcode;
4221 {
4222 ScopeBlockedUIDRule scopeBlockUidRule(netdService, TEST_UID);
4223 // Dns Queries should be blocked
Luke Huang5729afc2020-07-30 23:12:17 +08004224 const int fd1 = resNetworkQuery(TEST_NETID, host_name, ns_c_in, ns_t_a, 0);
4225 const int fd2 = resNetworkQuery(TEST_NETID, host_name, ns_c_in, ns_t_aaaa, 0);
Ken Chenbc481b82020-05-21 23:30:01 +08004226 EXPECT_TRUE(fd1 != -1);
4227 EXPECT_TRUE(fd2 != -1);
4228
Luke Huang5729afc2020-07-30 23:12:17 +08004229 const int res2 = getAsyncResponse(fd2, &rcode, buf2, MAXPACKET);
4230 const int res1 = getAsyncResponse(fd1, &rcode, buf, MAXPACKET);
4231 // If API level >= 30 (R+), the query should be blocked.
4232 if (isAtLeastR) {
4233 EXPECT_EQ(res2, -ECONNREFUSED);
4234 EXPECT_EQ(res1, -ECONNREFUSED);
4235 } else {
4236 EXPECT_GT(res2, 0);
4237 EXPECT_EQ("::1.2.3.4", toString(buf2, res2, AF_INET6));
4238 EXPECT_GT(res1, 0);
4239 EXPECT_EQ("1.2.3.4", toString(buf, res1, AF_INET));
4240 }
Ken Chenbc481b82020-05-21 23:30:01 +08004241 }
4242
Luke Huang5729afc2020-07-30 23:12:17 +08004243 memset(buf, 0, MAXPACKET);
Ken Chenbc481b82020-05-21 23:30:01 +08004244 parcel.resolverOptions.enforceDnsUid = true;
4245 ASSERT_TRUE(mDnsClient.resolvService()->setResolverConfiguration(parcel).isOk());
4246 {
4247 ScopeBlockedUIDRule scopeBlockUidRule(netdService, TEST_UID);
4248 // Dns Queries should NOT be blocked
4249 int fd1 = resNetworkQuery(TEST_NETID, host_name, ns_c_in, ns_t_a, 0);
4250 int fd2 = resNetworkQuery(TEST_NETID, host_name, ns_c_in, ns_t_aaaa, 0);
4251 EXPECT_TRUE(fd1 != -1);
4252 EXPECT_TRUE(fd2 != -1);
4253
4254 int res = getAsyncResponse(fd2, &rcode, buf, MAXPACKET);
4255 EXPECT_EQ("::1.2.3.4", toString(buf, res, AF_INET6));
4256
4257 memset(buf, 0, MAXPACKET);
4258 res = getAsyncResponse(fd1, &rcode, buf, MAXPACKET);
4259 EXPECT_EQ("1.2.3.4", toString(buf, res, AF_INET));
4260
4261 // @TODO: So far we know that uid of DNS queries are no more set to DNS requester. But we
4262 // don't check if they are actually being set to AID_DNS, because system uids are always
4263 // allowed in bpf_owner_match(). Audit by firewallSetUidRule(AID_DNS) + sending queries is
4264 // infeasible. Fix it if the behavior of bpf_owner_match() is changed in the future, or if
4265 // we have better idea to deal with this.
4266 }
4267}
4268
Mike Yua772c202019-09-23 17:47:21 +08004269TEST_F(ResolverTest, ConnectTlsServerTimeout) {
Mike Yu40e67072019-10-09 21:14:09 +08004270 constexpr char hostname1[] = "query1.example.com.";
4271 constexpr char hostname2[] = "query2.example.com.";
Mike Yua772c202019-09-23 17:47:21 +08004272 const std::vector<DnsRecord> records = {
Mike Yu40e67072019-10-09 21:14:09 +08004273 {hostname1, ns_type::ns_t_a, "1.2.3.4"},
4274 {hostname2, ns_type::ns_t_a, "1.2.3.5"},
Mike Yua772c202019-09-23 17:47:21 +08004275 };
4276
Mike Yu40e67072019-10-09 21:14:09 +08004277 // The resolver will adjust the timeout value to 1000ms since the value is too small.
4278 ScopedSystemProperties scopedSystemProperties(kDotConnectTimeoutMsFlag, "100");
Mike Yua772c202019-09-23 17:47:21 +08004279
Mike Yue93d9ae2020-08-25 19:09:51 +08004280 static const struct TestConfig {
4281 bool asyncHandshake;
Mike Yubb499092020-08-28 19:18:42 +08004282 int maxRetries;
4283
4284 // if asyncHandshake:
4285 // expectedTimeout = dotConnectTimeoutMs * maxRetries
4286 // otherwise:
4287 // expectedTimeout = dotConnectTimeoutMs
Mike Yue93d9ae2020-08-25 19:09:51 +08004288 int expectedTimeout;
4289 } testConfigs[] = {
Mike Yubb499092020-08-28 19:18:42 +08004290 // Test mis-configured dot_maxtries flag.
4291 {false, 0, 1000}, {true, 0, 1000},
Mike Yua772c202019-09-23 17:47:21 +08004292
Mike Yubb499092020-08-28 19:18:42 +08004293 {false, 1, 1000}, {false, 3, 1000}, {true, 1, 1000}, {true, 3, 3000},
Mike Yue93d9ae2020-08-25 19:09:51 +08004294 };
Mike Yua772c202019-09-23 17:47:21 +08004295
Mike Yue93d9ae2020-08-25 19:09:51 +08004296 for (const auto& config : testConfigs) {
Mike Yubb499092020-08-28 19:18:42 +08004297 SCOPED_TRACE(fmt::format("testConfig: [{}, {}]", config.asyncHandshake, config.maxRetries));
Mike Yua772c202019-09-23 17:47:21 +08004298
Mike Yue93d9ae2020-08-25 19:09:51 +08004299 // Because a DnsTlsTransport lasts at least 5 minutes in spite of network
4300 // destroyed, let the resolver creates an unique DnsTlsTransport every time
4301 // so that the DnsTlsTransport won't interfere the other tests.
4302 const std::string addr = getUniqueIPv4Address();
4303 test::DNSResponder dns(addr);
4304 StartDns(dns, records);
4305 test::DnsTlsFrontend tls(addr, "853", addr, "53");
4306 ASSERT_TRUE(tls.startServer());
Mike Yua772c202019-09-23 17:47:21 +08004307
Mike Yubb499092020-08-28 19:18:42 +08004308 ScopedSystemProperties scopedSystemProperties1(kDotAsyncHandshakeFlag,
4309 config.asyncHandshake ? "1" : "0");
4310 ScopedSystemProperties scopedSystemProperties2(kDotMaxretriesFlag,
4311 std::to_string(config.maxRetries));
Mike Yue93d9ae2020-08-25 19:09:51 +08004312 resetNetwork();
Mike Yu40e67072019-10-09 21:14:09 +08004313
Mike Yue93d9ae2020-08-25 19:09:51 +08004314 // Set up resolver to opportunistic mode.
4315 auto parcel = DnsResponderClient::GetDefaultResolverParamsParcel();
4316 parcel.servers = {addr};
4317 parcel.tlsServers = {addr};
4318 ASSERT_TRUE(mDnsClient.SetResolversFromParcel(parcel));
4319 EXPECT_TRUE(WaitForPrivateDnsValidation(tls.listen_address(), true));
4320 EXPECT_TRUE(tls.waitForQueries(1));
4321 tls.clearQueries();
4322 dns.clearQueries();
Mike Yu40e67072019-10-09 21:14:09 +08004323
Mike Yue93d9ae2020-08-25 19:09:51 +08004324 // The server becomes unresponsive to the handshake request.
4325 tls.setHangOnHandshakeForTesting(true);
Mike Yu40e67072019-10-09 21:14:09 +08004326
Mike Yue93d9ae2020-08-25 19:09:51 +08004327 // Expect the things happening in getaddrinfo():
4328 // 1. Connect to the private DNS server.
4329 // 2. SSL handshake times out.
4330 // 3. Fallback to UDP transport, and then get the answer.
4331 const addrinfo hints = {.ai_family = AF_INET, .ai_socktype = SOCK_DGRAM};
4332 auto [result, timeTakenMs] = safe_getaddrinfo_time_taken(hostname1, nullptr, hints);
4333
4334 EXPECT_NE(nullptr, result);
4335 EXPECT_EQ(0, tls.queries());
4336 EXPECT_EQ(1U, GetNumQueries(dns, hostname1));
4337 EXPECT_EQ(records.at(0).addr, ToString(result));
4338
4339 // A loose upper bound is set by adding 1000ms buffer time. Theoretically, getaddrinfo()
4340 // should just take a bit more than expetTimeout milliseconds.
4341 EXPECT_GE(timeTakenMs, config.expectedTimeout);
4342 EXPECT_LE(timeTakenMs, config.expectedTimeout + 1000);
4343
4344 // Set the server to be responsive. Verify that the resolver will attempt to reconnect
4345 // to the server and then get the result within the timeout.
4346 tls.setHangOnHandshakeForTesting(false);
4347 std::tie(result, timeTakenMs) = safe_getaddrinfo_time_taken(hostname2, nullptr, hints);
4348
4349 EXPECT_NE(nullptr, result);
4350 EXPECT_TRUE(tls.waitForQueries(1));
4351 EXPECT_EQ(1U, GetNumQueries(dns, hostname2));
4352 EXPECT_EQ(records.at(1).addr, ToString(result));
4353
4354 EXPECT_LE(timeTakenMs, 200);
4355 }
4356}
4357
4358TEST_F(ResolverTest, ConnectTlsServerTimeout_ConcurrentQueries) {
4359 constexpr uint32_t cacheFlag = ANDROID_RESOLV_NO_CACHE_LOOKUP;
4360 constexpr char hostname[] = "hello.example.com.";
4361 const std::vector<DnsRecord> records = {
4362 {hostname, ns_type::ns_t_a, "1.2.3.4"},
4363 };
4364
4365 static const struct TestConfig {
4366 bool asyncHandshake;
4367 int dotConnectTimeoutMs;
Mike Yubb499092020-08-28 19:18:42 +08004368 int maxRetries;
Mike Yue93d9ae2020-08-25 19:09:51 +08004369 int concurrency;
Mike Yubb499092020-08-28 19:18:42 +08004370
4371 // if asyncHandshake:
4372 // expectedTimeout = dotConnectTimeoutMs * maxRetries
4373 // otherwise:
4374 // expectedTimeout = dotConnectTimeoutMs * concurrency
Mike Yue93d9ae2020-08-25 19:09:51 +08004375 int expectedTimeout;
4376 } testConfigs[] = {
Mike Yubb499092020-08-28 19:18:42 +08004377 // clang-format off
4378 {false, 1000, 1, 5, 5000},
4379 {false, 1000, 3, 5, 5000},
4380 {true, 1000, 1, 5, 1000},
4381 {true, 2500, 1, 10, 2500},
4382 {true, 1000, 3, 5, 3000},
4383 // clang-format on
Mike Yue93d9ae2020-08-25 19:09:51 +08004384 };
4385
4386 // Launch query threads. Expected behaviors are:
4387 // - when dot_async_handshake is disabled, one of the query threads triggers a
4388 // handshake and then times out. Then same as another query thread, and so forth.
4389 // - when dot_async_handshake is enabled, only one handshake is triggered, and then
4390 // all of the query threads time out at the same time.
4391 for (const auto& config : testConfigs) {
4392 ScopedSystemProperties scopedSystemProperties1(kDotConnectTimeoutMsFlag,
4393 std::to_string(config.dotConnectTimeoutMs));
4394 ScopedSystemProperties scopedSystemProperties2(kDotAsyncHandshakeFlag,
4395 config.asyncHandshake ? "1" : "0");
Mike Yubb499092020-08-28 19:18:42 +08004396 ScopedSystemProperties scopedSystemProperties3(kDotMaxretriesFlag,
4397 std::to_string(config.maxRetries));
Mike Yue93d9ae2020-08-25 19:09:51 +08004398 resetNetwork();
4399
4400 for (const auto& dnsMode : {"OPPORTUNISTIC", "STRICT"}) {
4401 SCOPED_TRACE(fmt::format("testConfig: [{}, {}]", config.asyncHandshake, dnsMode));
4402
4403 // Because a DnsTlsTransport lasts at least 5 minutes in spite of network
4404 // destroyed, let the resolver creates an unique DnsTlsTransport every time
4405 // so that the DnsTlsTransport won't interfere the other tests.
4406 const std::string addr = getUniqueIPv4Address();
4407 test::DNSResponder dns(addr);
4408 StartDns(dns, records);
4409 test::DnsTlsFrontend tls(addr, "853", addr, "53");
4410 ASSERT_TRUE(tls.startServer());
4411
4412 auto parcel = DnsResponderClient::GetDefaultResolverParamsParcel();
4413 parcel.servers = {addr};
4414 parcel.tlsServers = {addr};
4415 if (dnsMode == "STRICT") parcel.tlsName = kDefaultPrivateDnsHostName;
4416 ASSERT_TRUE(mDnsClient.SetResolversFromParcel(parcel));
4417 EXPECT_TRUE(WaitForPrivateDnsValidation(tls.listen_address(), true));
4418 EXPECT_TRUE(tls.waitForQueries(1));
4419
4420 // The server becomes unresponsive to the handshake request.
4421 tls.setHangOnHandshakeForTesting(true);
4422
4423 Stopwatch s;
4424 std::vector<std::thread> threads(config.concurrency);
4425 for (std::thread& thread : threads) {
4426 thread = std::thread([&]() {
4427 int fd = resNetworkQuery(TEST_NETID, hostname, ns_c_in, ns_t_a, cacheFlag);
4428 dnsMode == "STRICT" ? expectAnswersNotValid(fd, -ETIMEDOUT)
4429 : expectAnswersValid(fd, AF_INET, "1.2.3.4");
4430 });
4431 }
4432 for (std::thread& thread : threads) {
4433 thread.join();
4434 }
4435
4436 const int timeTakenMs = s.timeTakenUs() / 1000;
4437 // A loose upper bound is set by adding 1000ms buffer time. Theoretically, it should
4438 // just take a bit more than expetTimeout milliseconds for the result.
4439 EXPECT_GE(timeTakenMs, config.expectedTimeout);
4440 EXPECT_LE(timeTakenMs, config.expectedTimeout + 1000);
4441
4442 // Recover the server from being unresponsive and try again.
4443 tls.setHangOnHandshakeForTesting(false);
4444 int fd = resNetworkQuery(TEST_NETID, hostname, ns_c_in, ns_t_a, cacheFlag);
4445 expectAnswersValid(fd, AF_INET, "1.2.3.4");
4446 }
4447 }
Mike Yua772c202019-09-23 17:47:21 +08004448}
Hungming Chenbb90ab32019-10-28 18:20:31 +08004449
Ken Chen766feae2019-10-30 15:13:44 +08004450TEST_F(ResolverTest, FlushNetworkCache) {
Luke Huang0b5a76c2019-11-23 03:00:00 +08004451 SKIP_IF_REMOTE_VERSION_LESS_THAN(mDnsClient.resolvService(), 4);
Ken Chen766feae2019-10-30 15:13:44 +08004452 test::DNSResponder dns;
4453 StartDns(dns, {{kHelloExampleCom, ns_type::ns_t_a, kHelloExampleComAddrV4}});
4454 ASSERT_TRUE(mDnsClient.SetResolversForNetwork());
4455
4456 const hostent* result = gethostbyname("hello");
4457 EXPECT_EQ(1U, GetNumQueriesForType(dns, ns_type::ns_t_a, kHelloExampleCom));
4458
4459 // get result from cache
4460 result = gethostbyname("hello");
4461 EXPECT_EQ(1U, GetNumQueriesForType(dns, ns_type::ns_t_a, kHelloExampleCom));
4462
4463 EXPECT_TRUE(mDnsClient.resolvService()->flushNetworkCache(TEST_NETID).isOk());
4464
4465 result = gethostbyname("hello");
4466 EXPECT_EQ(2U, GetNumQueriesForType(dns, ns_type::ns_t_a, kHelloExampleCom));
4467}
4468
4469TEST_F(ResolverTest, FlushNetworkCache_random) {
Luke Huang0b5a76c2019-11-23 03:00:00 +08004470 SKIP_IF_REMOTE_VERSION_LESS_THAN(mDnsClient.resolvService(), 4);
Ken Chen766feae2019-10-30 15:13:44 +08004471 constexpr int num_flush = 10;
4472 constexpr int num_queries = 20;
4473 test::DNSResponder dns;
4474 StartDns(dns, {{kHelloExampleCom, ns_type::ns_t_a, kHelloExampleComAddrV4}});
4475 ASSERT_TRUE(mDnsClient.SetResolversForNetwork());
4476 const addrinfo hints = {.ai_family = AF_INET};
4477
4478 std::thread t([this]() {
4479 for (int i = 0; i < num_flush; ++i) {
4480 unsigned delay = arc4random_uniform(10 * 1000); // 10ms
4481 usleep(delay);
4482 EXPECT_TRUE(mDnsClient.resolvService()->flushNetworkCache(TEST_NETID).isOk());
4483 }
4484 });
4485
4486 for (int i = 0; i < num_queries; ++i) {
4487 ScopedAddrinfo result = safe_getaddrinfo("hello", nullptr, &hints);
4488 EXPECT_TRUE(result != nullptr);
4489 EXPECT_EQ(kHelloExampleComAddrV4, ToString(result));
4490 }
4491 t.join();
4492}
4493
4494// flush cache while one query is wait-for-response, another is pending.
4495TEST_F(ResolverTest, FlushNetworkCache_concurrent) {
Luke Huang0b5a76c2019-11-23 03:00:00 +08004496 SKIP_IF_REMOTE_VERSION_LESS_THAN(mDnsClient.resolvService(), 4);
Ken Chen766feae2019-10-30 15:13:44 +08004497 const char* listen_addr1 = "127.0.0.9";
4498 const char* listen_addr2 = "127.0.0.10";
4499 test::DNSResponder dns1(listen_addr1);
4500 test::DNSResponder dns2(listen_addr2);
4501 StartDns(dns1, {{kHelloExampleCom, ns_type::ns_t_a, kHelloExampleComAddrV4}});
4502 StartDns(dns2, {{kHelloExampleCom, ns_type::ns_t_a, kHelloExampleComAddrV4}});
4503 addrinfo hints = {.ai_family = AF_INET};
4504
4505 // step 1: set server#1 into deferred responding mode
4506 dns1.setDeferredResp(true);
4507 std::thread t1([&listen_addr1, &hints, this]() {
4508 ASSERT_TRUE(mDnsClient.SetResolversForNetwork({listen_addr1}));
4509 // step 3: query
4510 ScopedAddrinfo result = safe_getaddrinfo("hello", nullptr, &hints);
4511 // step 9: check result
4512 EXPECT_TRUE(result != nullptr);
4513 EXPECT_EQ(kHelloExampleComAddrV4, ToString(result));
4514 });
4515
4516 // step 2: wait for the query to reach the server
4517 while (GetNumQueries(dns1, kHelloExampleCom) == 0) {
4518 usleep(1000); // 1ms
4519 }
4520
4521 std::thread t2([&listen_addr2, &hints, &dns2, this]() {
4522 ASSERT_TRUE(mDnsClient.SetResolversForNetwork({listen_addr2}));
4523 // step 5: query (should be blocked in resolver)
4524 ScopedAddrinfo result = safe_getaddrinfo("hello", nullptr, &hints);
4525 // step 7: check result
4526 EXPECT_TRUE(result != nullptr);
4527 EXPECT_EQ(kHelloExampleComAddrV4, ToString(result));
4528 EXPECT_EQ(1U, GetNumQueriesForType(dns2, ns_type::ns_t_a, kHelloExampleCom));
4529 });
4530
4531 // step 4: wait a bit for the 2nd query to enter pending state
4532 usleep(100 * 1000); // 100ms
4533 // step 6: flush cache (will unblock pending queries)
4534 EXPECT_TRUE(mDnsClient.resolvService()->flushNetworkCache(TEST_NETID).isOk());
4535 t2.join();
4536
4537 // step 8: resume server#1
4538 dns1.setDeferredResp(false);
4539 t1.join();
4540
4541 // step 10: verify if result is correctly cached
4542 dns2.clearQueries();
4543 ScopedAddrinfo result = safe_getaddrinfo("hello", nullptr, &hints);
4544 EXPECT_EQ(0U, GetNumQueries(dns2, kHelloExampleCom));
4545 EXPECT_EQ(kHelloExampleComAddrV4, ToString(result));
4546}
4547
waynema29253052019-08-20 11:26:08 +08004548// TODO: Perhaps to have a boundary conditions test for TCP and UDP.
4549TEST_F(ResolverTest, TcpQueryWithOversizePayload) {
4550 test::DNSResponder dns;
4551 StartDns(dns, {{kHelloExampleCom, ns_type::ns_t_a, kHelloExampleComAddrV4}});
4552 ASSERT_TRUE(mDnsClient.SetResolversForNetwork());
4553
4554 int fd = dns_open_proxy();
4555 ASSERT_TRUE(fd > 0);
4556
4557 // Sending DNS query over TCP once the packet sizes exceed 512 bytes.
4558 // The raw data is combined with Question section and Additional section
4559 // Question section : query "hello.example.com", type A, class IN
4560 // Additional section : type OPT (41), Option PADDING, Option Length 546
4561 // Padding option which allows DNS clients and servers to artificially
4562 // increase the size of a DNS message by a variable number of bytes.
4563 // See also RFC7830, section 3
4564 const std::string query =
4565 "+c0BAAABAAAAAAABBWhlbGxvB2V4YW1wbGUDY29tAAABAAEAACkgAAAAgAACJgAMAiIAAAAAAAAAAAAAAAAAA"
4566 "AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA"
4567 "AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA"
4568 "AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA"
4569 "AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA"
4570 "AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA"
4571 "AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA"
4572 "AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA"
4573 "AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA"
4574 "AAAAAAAAAAAAAAAAAAAAAAAAAAAAAA=";
4575 const std::string cmd =
4576 "resnsend " + std::to_string(TEST_NETID) + " 0 " /* ResNsendFlags */ + query + '\0';
4577 ssize_t rc = TEMP_FAILURE_RETRY(write(fd, cmd.c_str(), cmd.size()));
4578 EXPECT_EQ(rc, static_cast<ssize_t>(cmd.size()));
4579 expectAnswersValid(fd, AF_INET, kHelloExampleComAddrV4);
4580 EXPECT_EQ(1U, GetNumQueriesForProtocol(dns, IPPROTO_TCP, kHelloExampleCom));
4581 EXPECT_EQ(0U, GetNumQueriesForProtocol(dns, IPPROTO_UDP, kHelloExampleCom));
4582}
4583
Ken Chen99344882020-01-01 14:59:38 +08004584TEST_F(ResolverTest, TruncatedRspMode) {
4585 constexpr char listen_addr[] = "127.0.0.4";
4586 constexpr char listen_addr2[] = "127.0.0.5";
4587 constexpr char listen_srv[] = "53";
4588
4589 test::DNSResponder dns(listen_addr, listen_srv, static_cast<ns_rcode>(-1));
4590 test::DNSResponder dns2(listen_addr2, listen_srv, static_cast<ns_rcode>(-1));
4591 // dns supports UDP only, dns2 support UDP and TCP
4592 dns.setResponseProbability(0.0, IPPROTO_TCP);
4593 StartDns(dns, kLargeCnameChainRecords);
4594 StartDns(dns2, kLargeCnameChainRecords);
4595
4596 const struct TestConfig {
4597 const std::optional<int32_t> tcMode;
4598 const bool ret;
4599 const unsigned numQueries;
4600 std::string asParameters() const {
4601 return StringPrintf("tcMode: %d, ret: %s, numQueries: %u", tcMode.value_or(-1),
4602 ret ? "true" : "false", numQueries);
4603 }
4604 } testConfigs[]{
4605 // clang-format off
4606 {std::nullopt, true, 0}, /* mode unset */
4607 {aidl::android::net::IDnsResolver::TC_MODE_DEFAULT, true, 0}, /* default mode */
4608 {aidl::android::net::IDnsResolver::TC_MODE_UDP_TCP, true, 1}, /* alternative mode */
4609 {-666, false, 1}, /* invalid input */
4610 // clang-format on
4611 };
4612
4613 for (const auto& config : testConfigs) {
4614 SCOPED_TRACE(config.asParameters());
4615
4616 ResolverParamsParcel parcel = DnsResponderClient::GetDefaultResolverParamsParcel();
4617 parcel.servers = {listen_addr, listen_addr2};
4618 if (config.tcMode) {
Ken Chena6ac2a62020-04-07 17:25:56 +08004619 parcel.resolverOptions.tcMode = config.tcMode.value();
Ken Chen99344882020-01-01 14:59:38 +08004620 }
4621 ASSERT_EQ(mDnsClient.resolvService()->setResolverConfiguration(parcel).isOk(), config.ret);
4622
4623 const addrinfo hints = {.ai_family = AF_INET, .ai_socktype = SOCK_DGRAM};
4624 ScopedAddrinfo result = safe_getaddrinfo("hello", nullptr, &hints);
4625 ASSERT_TRUE(result != nullptr);
4626 EXPECT_EQ(ToString(result), kHelloExampleComAddrV4);
4627 // TC_MODE_DEFAULT: resolver retries on TCP-only on each name server.
4628 // TC_MODE_UDP_TCP: resolver retries on TCP on the same server, falls back to UDP from next.
4629 ASSERT_EQ(GetNumQueriesForProtocol(dns, IPPROTO_UDP, kHelloExampleCom), 1U);
4630 ASSERT_EQ(GetNumQueriesForProtocol(dns, IPPROTO_TCP, kHelloExampleCom), 1U);
4631 ASSERT_EQ(GetNumQueriesForProtocol(dns2, IPPROTO_UDP, kHelloExampleCom), config.numQueries);
4632 ASSERT_EQ(GetNumQueriesForProtocol(dns2, IPPROTO_TCP, kHelloExampleCom), 1U);
4633
4634 dns.clearQueries();
4635 dns2.clearQueries();
4636 ASSERT_TRUE(mDnsClient.resolvService()->flushNetworkCache(TEST_NETID).isOk());
Mike Yu61d17262020-02-15 18:56:22 +08004637
4638 // Clear the stats to make the resolver always choose the same server for the first query.
4639 parcel.servers.clear();
4640 parcel.tlsServers.clear();
4641 ASSERT_EQ(mDnsClient.resolvService()->setResolverConfiguration(parcel).isOk(), config.ret);
Ken Chen99344882020-01-01 14:59:38 +08004642 }
4643}
4644
Mike Yu153b5b82020-03-04 19:53:54 +08004645TEST_F(ResolverTest, RepeatedSetup_ResolverStatusRemains) {
4646 constexpr char unusable_listen_addr[] = "127.0.0.3";
4647 constexpr char listen_addr[] = "127.0.0.4";
4648 constexpr char hostname[] = "a.hello.query.";
4649 const auto repeatedSetResolversFromParcel = [&](const ResolverParamsParcel& parcel) {
4650 ASSERT_TRUE(mDnsClient.SetResolversFromParcel(parcel));
4651 ASSERT_TRUE(mDnsClient.SetResolversFromParcel(parcel));
4652 ASSERT_TRUE(mDnsClient.SetResolversFromParcel(parcel));
4653 };
4654
4655 test::DNSResponder dns(listen_addr);
4656 StartDns(dns, {{hostname, ns_type::ns_t_a, "1.2.3.3"}});
4657 test::DnsTlsFrontend tls1(listen_addr, "853", listen_addr, "53");
4658 ASSERT_TRUE(tls1.startServer());
4659
4660 // Private DNS off mode.
4661 ResolverParamsParcel parcel = DnsResponderClient::GetDefaultResolverParamsParcel();
4662 parcel.servers = {unusable_listen_addr, listen_addr};
4663 parcel.tlsServers.clear();
4664 ASSERT_TRUE(mDnsClient.SetResolversFromParcel(parcel));
4665
4666 // Send a query.
4667 const addrinfo hints = {.ai_family = AF_INET, .ai_socktype = SOCK_DGRAM};
4668 EXPECT_NE(safe_getaddrinfo(hostname, nullptr, &hints), nullptr);
4669
4670 // Check the stats as expected.
4671 const std::vector<NameserverStats> expectedCleartextDnsStats = {
4672 NameserverStats(unusable_listen_addr).setInternalErrors(1),
4673 NameserverStats(listen_addr).setSuccesses(1),
4674 };
Mike Yu61d17262020-02-15 18:56:22 +08004675 EXPECT_TRUE(expectStatsEqualTo(expectedCleartextDnsStats));
Mike Yu153b5b82020-03-04 19:53:54 +08004676 EXPECT_EQ(GetNumQueries(dns, hostname), 1U);
4677
4678 // The stats is supposed to remain as long as the list of cleartext DNS servers is unchanged.
4679 static const struct TestConfig {
4680 std::vector<std::string> servers;
4681 std::vector<std::string> tlsServers;
4682 std::string tlsName;
4683 } testConfigs[] = {
4684 // Private DNS opportunistic mode.
4685 {{listen_addr, unusable_listen_addr}, {listen_addr, unusable_listen_addr}, ""},
4686 {{unusable_listen_addr, listen_addr}, {unusable_listen_addr, listen_addr}, ""},
4687
4688 // Private DNS strict mode.
4689 {{listen_addr, unusable_listen_addr}, {"127.0.0.100"}, kDefaultPrivateDnsHostName},
4690 {{unusable_listen_addr, listen_addr}, {"127.0.0.100"}, kDefaultPrivateDnsHostName},
4691
4692 // Private DNS off mode.
4693 {{unusable_listen_addr, listen_addr}, {}, ""},
4694 {{listen_addr, unusable_listen_addr}, {}, ""},
4695 };
4696
4697 for (const auto& config : testConfigs) {
4698 SCOPED_TRACE(fmt::format("testConfig: [{}] [{}] [{}]", fmt::join(config.servers, ","),
4699 fmt::join(config.tlsServers, ","), config.tlsName));
4700 parcel = DnsResponderClient::GetDefaultResolverParamsParcel();
4701 parcel.servers = config.servers;
4702 parcel.tlsServers = config.tlsServers;
4703 parcel.tlsName = config.tlsName;
4704 repeatedSetResolversFromParcel(parcel);
Mike Yu61d17262020-02-15 18:56:22 +08004705 EXPECT_TRUE(expectStatsEqualTo(expectedCleartextDnsStats));
Mike Yu153b5b82020-03-04 19:53:54 +08004706
4707 // The stats remains when the list of search domains changes.
4708 parcel.domains.push_back("tmp.domains");
4709 repeatedSetResolversFromParcel(parcel);
Mike Yu61d17262020-02-15 18:56:22 +08004710 EXPECT_TRUE(expectStatsEqualTo(expectedCleartextDnsStats));
Mike Yu153b5b82020-03-04 19:53:54 +08004711
4712 // The stats remains when the parameters change (except maxSamples).
4713 parcel.sampleValiditySeconds++;
4714 parcel.successThreshold++;
4715 parcel.minSamples++;
4716 parcel.baseTimeoutMsec++;
4717 parcel.retryCount++;
4718 repeatedSetResolversFromParcel(parcel);
Mike Yu61d17262020-02-15 18:56:22 +08004719 EXPECT_TRUE(expectStatsEqualTo(expectedCleartextDnsStats));
Mike Yu153b5b82020-03-04 19:53:54 +08004720 }
4721
4722 // The cache remains.
4723 EXPECT_NE(safe_getaddrinfo(hostname, nullptr, &hints), nullptr);
4724 EXPECT_EQ(GetNumQueries(dns, hostname), 1U);
4725}
4726
4727TEST_F(ResolverTest, RepeatedSetup_NoRedundantPrivateDnsValidation) {
4728 const std::string addr1 = getUniqueIPv4Address(); // For a workable DNS server.
4729 const std::string addr2 = getUniqueIPv4Address(); // For an unresponsive DNS server.
4730 const std::string unusable_addr = getUniqueIPv4Address();
Mike Yubc4b9502020-03-20 13:14:00 +08004731 const auto waitForPrivateDnsStateUpdated = []() {
4732 // A buffer time for the PrivateDnsConfiguration instance to update its map,
4733 // mPrivateDnsValidateThreads, which is used for tracking validation threads.
4734 // Since there is a time gap between when PrivateDnsConfiguration reports
4735 // onPrivateDnsValidationEvent and when PrivateDnsConfiguration updates the map, this is a
4736 // workaround to avoid the test starts a subsequent resolver setup during the time gap.
4737 // TODO: Report onPrivateDnsValidationEvent after all the relevant updates are complete.
4738 // Reference to b/152009023.
4739 std::this_thread::sleep_for(20ms);
4740 };
Mike Yu153b5b82020-03-04 19:53:54 +08004741
4742 test::DNSResponder dns1(addr1);
4743 test::DNSResponder dns2(addr2);
4744 StartDns(dns1, {});
4745 StartDns(dns2, {});
4746 test::DnsTlsFrontend workableTls(addr1, "853", addr1, "53");
4747 test::DnsTlsFrontend unresponsiveTls(addr2, "853", addr2, "53");
4748 unresponsiveTls.setHangOnHandshakeForTesting(true);
4749 ASSERT_TRUE(workableTls.startServer());
4750 ASSERT_TRUE(unresponsiveTls.startServer());
4751
4752 // First setup.
4753 ResolverParamsParcel parcel = DnsResponderClient::GetDefaultResolverParamsParcel();
4754 parcel.servers = {addr1, addr2, unusable_addr};
4755 parcel.tlsServers = {addr1, addr2, unusable_addr};
4756 ASSERT_TRUE(mDnsClient.SetResolversFromParcel(parcel));
4757
4758 // Check the validation results.
4759 EXPECT_TRUE(WaitForPrivateDnsValidation(workableTls.listen_address(), true));
4760 EXPECT_TRUE(WaitForPrivateDnsValidation(unusable_addr, false));
4761 EXPECT_EQ(unresponsiveTls.acceptConnectionsCount(), 1); // The validation is still in progress.
4762
4763 static const struct TestConfig {
4764 std::vector<std::string> tlsServers;
4765 std::string tlsName;
4766 } testConfigs[] = {
4767 {{addr1, addr2, unusable_addr}, ""},
4768 {{unusable_addr, addr1, addr2}, ""},
4769 {{unusable_addr, addr1, addr2}, kDefaultPrivateDnsHostName},
4770 {{addr1, addr2, unusable_addr}, kDefaultPrivateDnsHostName},
4771 };
4772
4773 std::string TlsNameLastTime;
4774 for (const auto& config : testConfigs) {
4775 SCOPED_TRACE(fmt::format("testConfig: [{}] [{}]", fmt::join(config.tlsServers, ","),
4776 config.tlsName));
4777 parcel.servers = config.tlsServers;
4778 parcel.tlsServers = config.tlsServers;
4779 parcel.tlsName = config.tlsName;
4780 parcel.caCertificate = config.tlsName.empty() ? "" : kCaCert;
4781
4782 const bool dnsModeChanged = (TlsNameLastTime != config.tlsName);
Mike Yubc4b9502020-03-20 13:14:00 +08004783
4784 waitForPrivateDnsStateUpdated();
Mike Yu153b5b82020-03-04 19:53:54 +08004785 ASSERT_TRUE(mDnsClient.SetResolversFromParcel(parcel));
4786
4787 for (const auto& serverAddr : parcel.tlsServers) {
4788 SCOPED_TRACE(serverAddr);
4789 if (serverAddr == workableTls.listen_address()) {
4790 if (dnsModeChanged) {
4791 // In despite of the identical IP address, the server is regarded as a different
4792 // server when DnsTlsServer.name is different. The resolver treats it as a
4793 // different object and begins the validation process.
4794 EXPECT_TRUE(WaitForPrivateDnsValidation(serverAddr, true));
4795 }
4796 } else if (serverAddr == unresponsiveTls.listen_address()) {
4797 // No revalidation needed for the server which have been marked as in_progesss.
4798 } else {
4799 // Must be unusable_addr.
4800 // In opportunistic mode, when a validation for a private DNS server fails, the
4801 // resolver just marks the server as failed and doesn't re-evaluate it, but the
4802 // server can be re-evaluated when setResolverConfiguration() is called.
4803 // However, in strict mode, the resolver automatically re-evaluates the server and
4804 // marks the server as in_progress until the validation succeeds, so repeated setup
4805 // makes no effect.
4806 if (dnsModeChanged || config.tlsName.empty() /* not in strict mode */) {
4807 EXPECT_TRUE(WaitForPrivateDnsValidation(serverAddr, false));
4808 }
4809 }
4810 }
4811
4812 // Repeated setups make no effect in strict mode.
Mike Yubc4b9502020-03-20 13:14:00 +08004813 waitForPrivateDnsStateUpdated();
Mike Yu153b5b82020-03-04 19:53:54 +08004814 ASSERT_TRUE(mDnsClient.SetResolversFromParcel(parcel));
4815 if (config.tlsName.empty()) {
4816 EXPECT_TRUE(WaitForPrivateDnsValidation(unusable_addr, false));
4817 }
Mike Yubc4b9502020-03-20 13:14:00 +08004818 waitForPrivateDnsStateUpdated();
Mike Yu153b5b82020-03-04 19:53:54 +08004819 ASSERT_TRUE(mDnsClient.SetResolversFromParcel(parcel));
4820 if (config.tlsName.empty()) {
4821 EXPECT_TRUE(WaitForPrivateDnsValidation(unusable_addr, false));
4822 }
4823
4824 EXPECT_EQ(unresponsiveTls.acceptConnectionsCount(), 1);
4825
4826 TlsNameLastTime = config.tlsName;
4827 }
4828
4829 // Check that all the validation results are caught.
4830 // Note: it doesn't mean no validation being in progress.
4831 EXPECT_FALSE(hasUncaughtPrivateDnsValidation(addr1));
4832 EXPECT_FALSE(hasUncaughtPrivateDnsValidation(addr2));
4833 EXPECT_FALSE(hasUncaughtPrivateDnsValidation(unusable_addr));
4834}
4835
4836TEST_F(ResolverTest, RepeatedSetup_KeepChangingPrivateDnsServers) {
4837 enum TlsServerState { WORKING, UNSUPPORTED, UNRESPONSIVE };
4838 const std::string addr1 = getUniqueIPv4Address();
4839 const std::string addr2 = getUniqueIPv4Address();
Mike Yu9a185882020-03-25 16:02:36 +08004840 const auto waitForPrivateDnsStateUpdated = []() {
4841 // A buffer time for PrivateDnsConfiguration to update its state. It prevents this test
4842 // being flaky. See b/152009023 for the reason.
4843 std::this_thread::sleep_for(20ms);
4844 };
Mike Yu153b5b82020-03-04 19:53:54 +08004845
4846 test::DNSResponder dns1(addr1);
4847 test::DNSResponder dns2(addr2);
4848 StartDns(dns1, {});
4849 StartDns(dns2, {});
4850 test::DnsTlsFrontend tls1(addr1, "853", addr1, "53");
4851 test::DnsTlsFrontend tls2(addr2, "853", addr2, "53");
4852 ASSERT_TRUE(tls1.startServer());
4853 ASSERT_TRUE(tls2.startServer());
4854
4855 static const struct TestConfig {
4856 std::string tlsServer;
4857 std::string tlsName;
4858 bool expectNothingHappenWhenServerUnsupported;
4859 bool expectNothingHappenWhenServerUnresponsive;
4860 std::string asTestName() const {
4861 return fmt::format("{}, {}, {}, {}", tlsServer, tlsName,
4862 expectNothingHappenWhenServerUnsupported,
4863 expectNothingHappenWhenServerUnresponsive);
4864 }
4865 } testConfigs[] = {
4866 {{addr1}, "", false, false},
4867 {{addr2}, "", false, false},
4868 {{addr1}, "", false, true},
4869 {{addr2}, "", false, true},
4870 {{addr1}, kDefaultPrivateDnsHostName, false, true},
4871 {{addr2}, kDefaultPrivateDnsHostName, false, true},
4872 {{addr1}, kDefaultPrivateDnsHostName, true, true},
4873 {{addr2}, kDefaultPrivateDnsHostName, true, true},
4874
4875 // There's no new validation to start because there are already two validation threads
4876 // running (one is for addr1, the other is for addr2). This is because the comparator
4877 // doesn't compare DnsTlsServer.name. Keep the design as-is until it's known to be
4878 // harmful.
4879 {{addr1}, "", true, true},
4880 {{addr2}, "", true, true},
4881 {{addr1}, "", true, true},
4882 {{addr2}, "", true, true},
4883 };
4884
4885 for (const auto& serverState : {WORKING, UNSUPPORTED, UNRESPONSIVE}) {
4886 int testIndex = 0;
4887 for (const auto& config : testConfigs) {
4888 SCOPED_TRACE(fmt::format("serverState:{} testIndex:{} testConfig:[{}]", serverState,
4889 testIndex++, config.asTestName()));
4890 auto& tls = (config.tlsServer == addr1) ? tls1 : tls2;
4891
4892 if (serverState == UNSUPPORTED && tls.running()) ASSERT_TRUE(tls.stopServer());
4893 if (serverState != UNSUPPORTED && !tls.running()) ASSERT_TRUE(tls.startServer());
4894
4895 tls.setHangOnHandshakeForTesting(serverState == UNRESPONSIVE);
4896 const int connectCountsBefore = tls.acceptConnectionsCount();
4897
Mike Yu9a185882020-03-25 16:02:36 +08004898 waitForPrivateDnsStateUpdated();
Mike Yu153b5b82020-03-04 19:53:54 +08004899 ResolverParamsParcel parcel = DnsResponderClient::GetDefaultResolverParamsParcel();
4900 parcel.servers = {config.tlsServer};
4901 parcel.tlsServers = {config.tlsServer};
4902 parcel.tlsName = config.tlsName;
4903 parcel.caCertificate = config.tlsName.empty() ? "" : kCaCert;
4904 ASSERT_TRUE(mDnsClient.SetResolversFromParcel(parcel));
4905
4906 if (serverState == WORKING) {
4907 EXPECT_TRUE(WaitForPrivateDnsValidation(config.tlsServer, true));
4908 } else if (serverState == UNSUPPORTED) {
4909 if (config.expectNothingHappenWhenServerUnsupported) {
4910 // It's possible that the resolver hasn't yet started to
4911 // connect. Wait a while.
4912 // TODO: See if we can get rid of the hard waiting time, such as comparing
4913 // the CountDiff across two tests.
4914 std::this_thread::sleep_for(100ms);
4915 EXPECT_EQ(tls.acceptConnectionsCount(), connectCountsBefore);
4916 } else {
4917 EXPECT_TRUE(WaitForPrivateDnsValidation(config.tlsServer, false));
4918 }
4919 } else {
4920 // Must be UNRESPONSIVE.
4921 // DnsTlsFrontend is the only signal for checking whether or not the resolver starts
4922 // another validation when the server is unresponsive.
4923 const int expectCountDiff =
4924 config.expectNothingHappenWhenServerUnresponsive ? 0 : 1;
4925 if (expectCountDiff == 0) {
4926 // It's possible that the resolver hasn't yet started to
4927 // connect. Wait a while.
4928 std::this_thread::sleep_for(100ms);
4929 }
4930 const auto condition = [&]() {
4931 return tls.acceptConnectionsCount() == connectCountsBefore + expectCountDiff;
4932 };
4933 EXPECT_TRUE(PollForCondition(condition));
4934 }
4935 }
4936
4937 // Set to off mode to reset the PrivateDnsConfiguration state.
4938 ResolverParamsParcel setupOffmode = DnsResponderClient::GetDefaultResolverParamsParcel();
4939 setupOffmode.tlsServers.clear();
4940 ASSERT_TRUE(mDnsClient.SetResolversFromParcel(setupOffmode));
4941 }
4942
4943 // Check that all the validation results are caught.
4944 // Note: it doesn't mean no validation being in progress.
4945 EXPECT_FALSE(hasUncaughtPrivateDnsValidation(addr1));
4946 EXPECT_FALSE(hasUncaughtPrivateDnsValidation(addr2));
4947}
4948
Ken Chen26dc2b02020-06-16 18:49:39 +08004949TEST_F(ResolverTest, PermissionCheckOnCertificateInjection) {
4950 ResolverParamsParcel parcel = DnsResponderClient::GetDefaultResolverParamsParcel();
4951 parcel.caCertificate = kCaCert;
4952 ASSERT_TRUE(mDnsClient.resolvService()->setResolverConfiguration(parcel).isOk());
4953
4954 for (const uid_t uid : {AID_SYSTEM, TEST_UID}) {
4955 ScopedChangeUID scopedChangeUID(uid);
4956 auto status = mDnsClient.resolvService()->setResolverConfiguration(parcel);
4957 EXPECT_EQ(status.getExceptionCode(), EX_SECURITY);
4958 }
4959}
4960
Hungming Chenbb90ab32019-10-28 18:20:31 +08004961// Parameterized tests.
4962// TODO: Merge the existing tests as parameterized test if possible.
4963// TODO: Perhaps move parameterized tests to an independent file.
4964enum class CallType { GETADDRINFO, GETHOSTBYNAME };
4965class ResolverParameterizedTest : public ResolverTest,
Hungming Chen63779052019-10-30 15:06:13 +08004966 public testing::WithParamInterface<CallType> {
4967 protected:
Hungming Chen22617fd2019-12-06 12:15:45 +08004968 void VerifyQueryHelloExampleComV4(const test::DNSResponder& dns, const CallType calltype,
4969 const bool verifyNumQueries = true) {
Hungming Chen63779052019-10-30 15:06:13 +08004970 if (calltype == CallType::GETADDRINFO) {
4971 const addrinfo hints = {.ai_family = AF_INET, .ai_socktype = SOCK_DGRAM};
4972 ScopedAddrinfo result = safe_getaddrinfo("hello", nullptr, &hints);
4973 ASSERT_TRUE(result != nullptr);
4974 EXPECT_EQ(kHelloExampleComAddrV4, ToString(result));
4975 } else if (calltype == CallType::GETHOSTBYNAME) {
4976 const hostent* result = gethostbyname("hello");
4977 ASSERT_TRUE(result != nullptr);
4978 ASSERT_EQ(4, result->h_length);
4979 ASSERT_FALSE(result->h_addr_list[0] == nullptr);
4980 EXPECT_EQ(kHelloExampleComAddrV4, ToString(result));
4981 EXPECT_TRUE(result->h_addr_list[1] == nullptr);
4982 } else {
4983 FAIL() << "Unsupported call type: " << static_cast<uint32_t>(calltype);
4984 }
Hungming Chen22617fd2019-12-06 12:15:45 +08004985 if (verifyNumQueries) EXPECT_EQ(1U, GetNumQueries(dns, kHelloExampleCom));
Hungming Chen63779052019-10-30 15:06:13 +08004986 }
4987};
Hungming Chenbb90ab32019-10-28 18:20:31 +08004988
Hungming Chen63779052019-10-30 15:06:13 +08004989INSTANTIATE_TEST_SUITE_P(QueryCallTest, ResolverParameterizedTest,
Hungming Chenbb90ab32019-10-28 18:20:31 +08004990 testing::Values(CallType::GETADDRINFO, CallType::GETHOSTBYNAME),
4991 [](const testing::TestParamInfo<CallType>& info) {
Hungming Chenbb90ab32019-10-28 18:20:31 +08004992 switch (info.param) {
4993 case CallType::GETADDRINFO:
Hungming Chen63779052019-10-30 15:06:13 +08004994 return "GetAddrInfo";
Hungming Chenbb90ab32019-10-28 18:20:31 +08004995 case CallType::GETHOSTBYNAME:
Hungming Chen63779052019-10-30 15:06:13 +08004996 return "GetHostByName";
Hungming Chenbb90ab32019-10-28 18:20:31 +08004997 default:
Hungming Chen63779052019-10-30 15:06:13 +08004998 return "InvalidParameter"; // Should not happen.
Hungming Chenbb90ab32019-10-28 18:20:31 +08004999 }
Hungming Chenbb90ab32019-10-28 18:20:31 +08005000 });
5001
5002TEST_P(ResolverParameterizedTest, AuthoritySectionAndAdditionalSection) {
5003 // DNS response may have more information in authority section and additional section.
5004 // Currently, getanswer() of packages/modules/DnsResolver/getaddrinfo.cpp doesn't parse the
5005 // content of authority section and additional section. Test these sections if they crash
5006 // the resolver, just in case. See also RFC 1035 section 4.1.
5007 const auto& calltype = GetParam();
5008 test::DNSHeader header(kDefaultDnsHeader);
5009
5010 // Create a DNS response which has a authoritative nameserver record in authority
5011 // section and its relevant address record in additional section.
5012 //
5013 // Question
5014 // hello.example.com. IN A
5015 // Answer
5016 // hello.example.com. IN A 1.2.3.4
5017 // Authority:
5018 // hello.example.com. IN NS ns1.example.com.
5019 // Additional:
5020 // ns1.example.com. IN A 5.6.7.8
5021 //
5022 // A response may have only question, answer, and authority section. Current testing response
5023 // should be able to cover this condition.
5024
5025 // Question section.
5026 test::DNSQuestion question{
5027 .qname = {.name = kHelloExampleCom},
5028 .qtype = ns_type::ns_t_a,
5029 .qclass = ns_c_in,
5030 };
5031 header.questions.push_back(std::move(question));
5032
5033 // Answer section.
5034 test::DNSRecord recordAnswer{
5035 .name = {.name = kHelloExampleCom},
5036 .rtype = ns_type::ns_t_a,
5037 .rclass = ns_c_in,
5038 .ttl = 0, // no cache
5039 };
Hungming Chen63779052019-10-30 15:06:13 +08005040 EXPECT_TRUE(test::DNSResponder::fillRdata(kHelloExampleComAddrV4, recordAnswer));
Hungming Chenbb90ab32019-10-28 18:20:31 +08005041 header.answers.push_back(std::move(recordAnswer));
5042
5043 // Authority section.
5044 test::DNSRecord recordAuthority{
5045 .name = {.name = kHelloExampleCom},
5046 .rtype = ns_type::ns_t_ns,
5047 .rclass = ns_c_in,
5048 .ttl = 0, // no cache
5049 };
5050 EXPECT_TRUE(test::DNSResponder::fillRdata("ns1.example.com.", recordAuthority));
5051 header.authorities.push_back(std::move(recordAuthority));
5052
5053 // Additional section.
5054 test::DNSRecord recordAdditional{
5055 .name = {.name = "ns1.example.com."},
5056 .rtype = ns_type::ns_t_a,
5057 .rclass = ns_c_in,
5058 .ttl = 0, // no cache
5059 };
5060 EXPECT_TRUE(test::DNSResponder::fillRdata("5.6.7.8", recordAdditional));
5061 header.additionals.push_back(std::move(recordAdditional));
5062
5063 // Start DNS server.
5064 test::DNSResponder dns(test::DNSResponder::MappingType::DNS_HEADER);
5065 dns.addMappingDnsHeader(kHelloExampleCom, ns_type::ns_t_a, header);
5066 ASSERT_TRUE(dns.startServer());
5067 ASSERT_TRUE(mDnsClient.SetResolversForNetwork());
5068 dns.clearQueries();
5069
5070 // Expect that get the address and the resolver doesn't crash.
Hungming Chen63779052019-10-30 15:06:13 +08005071 VerifyQueryHelloExampleComV4(dns, calltype);
5072}
5073
5074TEST_P(ResolverParameterizedTest, MessageCompression) {
5075 const auto& calltype = GetParam();
5076
5077 // The response with compressed domain name by a pointer. See RFC 1035 section 4.1.4.
5078 //
5079 // Ignoring the other fields of the message, the domain name of question section and answer
5080 // section are presented as:
5081 // +--+--+--+--+--+--+--+--+--+--+--+--+--+--+--+--+
5082 // 12 | 5 | h |
5083 // +--+--+--+--+--+--+--+--+--+--+--+--+--+--+--+--+
5084 // 14 | e | l |
5085 // +--+--+--+--+--+--+--+--+--+--+--+--+--+--+--+--+
5086 // 16 | l | o |
5087 // +--+--+--+--+--+--+--+--+--+--+--+--+--+--+--+--+
5088 // 18 | 7 | e |
5089 // +--+--+--+--+--+--+--+--+--+--+--+--+--+--+--+--+
5090 // 20 | x | a |
5091 // +--+--+--+--+--+--+--+--+--+--+--+--+--+--+--+--+
5092 // 22 | m | p |
5093 // +--+--+--+--+--+--+--+--+--+--+--+--+--+--+--+--+
5094 // 24 | l | e |
5095 // +--+--+--+--+--+--+--+--+--+--+--+--+--+--+--+--+
5096 // 26 | 3 | c |
5097 // +--+--+--+--+--+--+--+--+--+--+--+--+--+--+--+--+
5098 // 28 | o | m |
5099 // +--+--+--+--+--+--+--+--+--+--+--+--+--+--+--+--+
5100 // 30 | 0 | ... |
5101 // +--+--+--+--+--+--+--+--+--+--+--+--+--+--+--+--+
5102 //
5103 // +--+--+--+--+--+--+--+--+--+--+--+--+--+--+--+--+
5104 // 35 | 1 1| 12 |
5105 // +--+--+--+--+--+--+--+--+--+--+--+--+--+--+--+--+
5106 const std::vector<uint8_t> kResponseAPointer = {
5107 /* Header */
5108 0x00, 0x00, /* Transaction ID: 0x0000 */
5109 0x81, 0x80, /* Flags: qr rd ra */
5110 0x00, 0x01, /* Questions: 1 */
5111 0x00, 0x01, /* Answer RRs: 1 */
5112 0x00, 0x00, /* Authority RRs: 0 */
5113 0x00, 0x00, /* Additional RRs: 0 */
5114 /* Queries */
5115 0x05, 0x68, 0x65, 0x6c, 0x6c, 0x6f, 0x07, 0x65, 0x78, 0x61, 0x6d, 0x70, 0x6c, 0x65,
5116 0x03, 0x63, 0x6f, 0x6d, 0x00, /* Name: hello.example.com */
5117 0x00, 0x01, /* Type: A */
5118 0x00, 0x01, /* Class: IN */
5119 /* Answers */
5120 0xc0, 0x0c, /* Name: hello.example.com (a pointer) */
5121 0x00, 0x01, /* Type: A */
5122 0x00, 0x01, /* Class: IN */
5123 0x00, 0x00, 0x00, 0x00, /* Time to live: 0 */
5124 0x00, 0x04, /* Data length: 4 */
5125 0x01, 0x02, 0x03, 0x04 /* Address: 1.2.3.4 */
5126 };
5127
5128 // The response with compressed domain name by a sequence of labels ending with a pointer. See
5129 // RFC 1035 section 4.1.4.
5130 //
5131 // Ignoring the other fields of the message, the domain name of question section and answer
5132 // section are presented as:
5133 // +--+--+--+--+--+--+--+--+--+--+--+--+--+--+--+--+
5134 // 12 | 5 | h |
5135 // +--+--+--+--+--+--+--+--+--+--+--+--+--+--+--+--+
5136 // 14 | e | l |
5137 // +--+--+--+--+--+--+--+--+--+--+--+--+--+--+--+--+
5138 // 16 | l | o |
5139 // +--+--+--+--+--+--+--+--+--+--+--+--+--+--+--+--+
5140 // 18 | 7 | e |
5141 // +--+--+--+--+--+--+--+--+--+--+--+--+--+--+--+--+
5142 // 20 | x | a |
5143 // +--+--+--+--+--+--+--+--+--+--+--+--+--+--+--+--+
5144 // 22 | m | p |
5145 // +--+--+--+--+--+--+--+--+--+--+--+--+--+--+--+--+
5146 // 24 | l | e |
5147 // +--+--+--+--+--+--+--+--+--+--+--+--+--+--+--+--+
5148 // 26 | 3 | c |
5149 // +--+--+--+--+--+--+--+--+--+--+--+--+--+--+--+--+
5150 // 28 | o | m |
5151 // +--+--+--+--+--+--+--+--+--+--+--+--+--+--+--+--+
5152 // 30 | 0 | ... |
5153 // +--+--+--+--+--+--+--+--+--+--+--+--+--+--+--+--+
5154 //
5155 // +--+--+--+--+--+--+--+--+--+--+--+--+--+--+--+--+
5156 // 35 | 5 | h |
5157 // +--+--+--+--+--+--+--+--+--+--+--+--+--+--+--+--+
5158 // 37 | e | l |
5159 // +--+--+--+--+--+--+--+--+--+--+--+--+--+--+--+--+
5160 // 39 | l | o |
5161 // +--+--+--+--+--+--+--+--+--+--+--+--+--+--+--+--+
5162 // 41 | 1 1| 18 |
5163 // +--+--+--+--+--+--+--+--+--+--+--+--+--+--+--+--+
5164 const std::vector<uint8_t> kResponseLabelEndingWithAPointer = {
5165 /* Header */
5166 0x00, 0x00, /* Transaction ID: 0x0000 */
5167 0x81, 0x80, /* Flags: qr rd ra */
5168 0x00, 0x01, /* Questions: 1 */
5169 0x00, 0x01, /* Answer RRs: 1 */
5170 0x00, 0x00, /* Authority RRs: 0 */
5171 0x00, 0x00, /* Additional RRs: 0 */
5172 /* Queries */
5173 0x05, 0x68, 0x65, 0x6c, 0x6c, 0x6f, 0x07, 0x65, 0x78, 0x61, 0x6d, 0x70, 0x6c, 0x65,
5174 0x03, 0x63, 0x6f, 0x6d, 0x00, /* Name: hello.example.com */
5175 0x00, 0x01, /* Type: A */
5176 0x00, 0x01, /* Class: IN */
5177 /* Answers */
5178 0x05, 0x68, 0x65, 0x6c, 0x6c, 0x6f, 0xc0,
5179 0x12, /* Name: hello.example.com (a label ending with a pointer) */
5180 0x00, 0x01, /* Type: A */
5181 0x00, 0x01, /* Class: IN */
5182 0x00, 0x00, 0x00, 0x00, /* Time to live: 0 */
5183 0x00, 0x04, /* Data length: 4 */
5184 0x01, 0x02, 0x03, 0x04 /* Address: 1.2.3.4 */
5185 };
5186
5187 for (const auto& response : {kResponseAPointer, kResponseLabelEndingWithAPointer}) {
5188 SCOPED_TRACE(StringPrintf("Hex dump: %s", toHex(makeSlice(response)).c_str()));
5189
5190 test::DNSResponder dns(test::DNSResponder::MappingType::BINARY_PACKET);
5191 dns.addMappingBinaryPacket(kHelloExampleComQueryV4, response);
5192 StartDns(dns, {});
5193 ASSERT_TRUE(mDnsClient.SetResolversForNetwork());
5194
5195 // Expect no cache because the TTL of testing responses are 0.
5196 VerifyQueryHelloExampleComV4(dns, calltype);
Hungming Chenbb90ab32019-10-28 18:20:31 +08005197 }
Mike Yu40e67072019-10-09 21:14:09 +08005198}
Hungming Chen22617fd2019-12-06 12:15:45 +08005199
5200TEST_P(ResolverParameterizedTest, TruncatedResponse) {
5201 const auto& calltype = GetParam();
5202
Hungming Chen22617fd2019-12-06 12:15:45 +08005203 test::DNSResponder dns;
Ken Chen99344882020-01-01 14:59:38 +08005204 StartDns(dns, kLargeCnameChainRecords);
Hungming Chen22617fd2019-12-06 12:15:45 +08005205 ASSERT_TRUE(mDnsClient.SetResolversForNetwork());
5206
5207 // Expect UDP response is truncated. The resolver retries over TCP. See RFC 1035 section 4.2.1.
5208 VerifyQueryHelloExampleComV4(dns, calltype, false);
5209 EXPECT_EQ(1U, GetNumQueriesForProtocol(dns, IPPROTO_UDP, kHelloExampleCom));
5210 EXPECT_EQ(1U, GetNumQueriesForProtocol(dns, IPPROTO_TCP, kHelloExampleCom));
5211}
Luke Huang420ee622019-11-27 17:52:44 +08005212
5213TEST_F(ResolverTest, KeepListeningUDP) {
5214 constexpr char listen_addr1[] = "127.0.0.4";
5215 constexpr char listen_addr2[] = "127.0.0.5";
5216 constexpr char host_name[] = "howdy.example.com.";
5217 const std::vector<DnsRecord> records = {
5218 {host_name, ns_type::ns_t_aaaa, "::1.2.3.4"},
5219 };
5220 const std::vector<int> params = {300, 25, 8, 8, 1000 /* BASE_TIMEOUT_MSEC */,
5221 1 /* retry count */};
5222 const int delayTimeMs = 1500;
5223
5224 test::DNSResponder neverRespondDns(listen_addr2, "53", static_cast<ns_rcode>(-1));
5225 neverRespondDns.setResponseProbability(0.0);
5226 StartDns(neverRespondDns, records);
Luke Huangf40df9c2020-04-21 08:51:48 +08005227 ScopedSystemProperties scopedSystemProperties(
5228 "persist.device_config.netd_native.keep_listening_udp", "1");
5229 // Re-setup test network to make experiment flag take effect.
5230 resetNetwork();
Luke Huang420ee622019-11-27 17:52:44 +08005231
5232 ASSERT_TRUE(mDnsClient.SetResolversForNetwork({listen_addr1, listen_addr2},
5233 kDefaultSearchDomains, params));
5234 // There are 2 DNS servers for this test.
5235 // |delayedDns| will be blocked for |delayTimeMs|, then start to respond to requests.
5236 // |neverRespondDns| will never respond.
5237 // In the first try, resolver will send query to |delayedDns| but get timeout error
5238 // because |delayTimeMs| > DNS timeout.
5239 // Then it's the second try, resolver will send query to |neverRespondDns| and
5240 // listen on both servers. Resolver will receive the answer coming from |delayedDns|.
Luke Huang420ee622019-11-27 17:52:44 +08005241
Luke Huang420ee622019-11-27 17:52:44 +08005242 test::DNSResponder delayedDns(listen_addr1);
5243 delayedDns.setResponseDelayMs(delayTimeMs);
5244 StartDns(delayedDns, records);
5245
5246 // Specify hints to ensure resolver doing query only 1 round.
5247 const addrinfo hints = {.ai_family = AF_INET6, .ai_socktype = SOCK_DGRAM};
5248 ScopedAddrinfo result = safe_getaddrinfo(host_name, nullptr, &hints);
5249 EXPECT_TRUE(result != nullptr);
5250
5251 std::string result_str = ToString(result);
5252 EXPECT_TRUE(result_str == "::1.2.3.4") << ", result_str='" << result_str << "'";
5253}
Luke Huang0a0870d2020-02-12 20:41:10 +08005254
5255TEST_F(ResolverTest, GetAddrInfoParallelLookupTimeout) {
5256 constexpr char listen_addr[] = "127.0.0.4";
5257 constexpr char host_name[] = "howdy.example.com.";
5258 constexpr int TIMING_TOLERANCE_MS = 200;
5259 constexpr int DNS_TIMEOUT_MS = 1000;
5260 const std::vector<DnsRecord> records = {
5261 {host_name, ns_type::ns_t_a, "1.2.3.4"},
5262 {host_name, ns_type::ns_t_aaaa, "::1.2.3.4"},
5263 };
5264 const std::vector<int> params = {300, 25, 8, 8, DNS_TIMEOUT_MS /* BASE_TIMEOUT_MSEC */,
5265 1 /* retry count */};
5266 test::DNSResponder neverRespondDns(listen_addr, "53", static_cast<ns_rcode>(-1));
5267 neverRespondDns.setResponseProbability(0.0);
5268 StartDns(neverRespondDns, records);
Luke Huangf40df9c2020-04-21 08:51:48 +08005269 ScopedSystemProperties scopedSystemProperties(
5270 "persist.device_config.netd_native.parallel_lookup", "1");
Luke Huangd1d734f2020-04-30 12:25:40 +08005271 // The default value of parallel_lookup_sleep_time should be very small
5272 // that we can ignore in this test case.
Luke Huangf40df9c2020-04-21 08:51:48 +08005273 // Re-setup test network to make experiment flag take effect.
5274 resetNetwork();
Luke Huang0a0870d2020-02-12 20:41:10 +08005275
5276 ASSERT_TRUE(mDnsClient.SetResolversForNetwork({listen_addr}, kDefaultSearchDomains, params));
5277 neverRespondDns.clearQueries();
5278
Luke Huang0a0870d2020-02-12 20:41:10 +08005279 // Use a never respond DNS server to verify if the A/AAAA queries are sent in parallel.
5280 // The resolver parameters are set to timeout 1s and retry 1 times.
5281 // So we expect the safe_getaddrinfo_time_taken() might take ~1s to
5282 // return when parallel lookup is enabled. And the DNS server should receive 2 queries.
5283 const addrinfo hints = {.ai_family = AF_UNSPEC, .ai_socktype = SOCK_DGRAM};
5284 auto [result, timeTakenMs] = safe_getaddrinfo_time_taken(host_name, nullptr, hints);
5285
5286 EXPECT_TRUE(result == nullptr);
5287 EXPECT_NEAR(DNS_TIMEOUT_MS, timeTakenMs, TIMING_TOLERANCE_MS)
5288 << "took time should approximate equal timeout";
5289 EXPECT_EQ(2U, GetNumQueries(neverRespondDns, host_name));
Mike Yu532405f2020-06-17 17:46:44 +08005290 ExpectDnsEvent(INetdEventListener::EVENT_GETADDRINFO, RCODE_TIMEOUT, host_name, {});
Luke Huang0a0870d2020-02-12 20:41:10 +08005291}
Luke Huangd1d734f2020-04-30 12:25:40 +08005292
5293TEST_F(ResolverTest, GetAddrInfoParallelLookupSleepTime) {
5294 constexpr char listen_addr[] = "127.0.0.4";
5295 constexpr int TIMING_TOLERANCE_MS = 200;
5296 const std::vector<DnsRecord> records = {
5297 {kHelloExampleCom, ns_type::ns_t_a, kHelloExampleComAddrV4},
5298 {kHelloExampleCom, ns_type::ns_t_aaaa, kHelloExampleComAddrV6},
5299 };
5300 const std::vector<int> params = {300, 25, 8, 8, 1000 /* BASE_TIMEOUT_MSEC */,
5301 1 /* retry count */};
5302 test::DNSResponder dns(listen_addr);
5303 StartDns(dns, records);
5304 ScopedSystemProperties scopedSystemProperties1(
5305 "persist.device_config.netd_native.parallel_lookup", "1");
5306 constexpr int PARALLEL_LOOKUP_SLEEP_TIME_MS = 500;
5307 ScopedSystemProperties scopedSystemProperties2(
5308 "persist.device_config.netd_native.parallel_lookup_sleep_time",
5309 std::to_string(PARALLEL_LOOKUP_SLEEP_TIME_MS));
5310 // Re-setup test network to make experiment flag take effect.
5311 resetNetwork();
5312
5313 ASSERT_TRUE(mDnsClient.SetResolversForNetwork({listen_addr}, kDefaultSearchDomains, params));
5314 dns.clearQueries();
5315
5316 // Expect the safe_getaddrinfo_time_taken() might take ~500ms to return because we set
5317 // parallel_lookup_sleep_time to 500ms.
5318 const addrinfo hints = {.ai_family = AF_UNSPEC, .ai_socktype = SOCK_DGRAM};
5319 auto [result, timeTakenMs] = safe_getaddrinfo_time_taken(kHelloExampleCom, nullptr, hints);
5320
5321 EXPECT_NE(nullptr, result);
5322 EXPECT_THAT(ToStrings(result), testing::UnorderedElementsAreArray(
5323 {kHelloExampleComAddrV4, kHelloExampleComAddrV6}));
5324 EXPECT_NEAR(PARALLEL_LOOKUP_SLEEP_TIME_MS, timeTakenMs, TIMING_TOLERANCE_MS)
5325 << "took time should approximate equal timeout";
5326 EXPECT_EQ(2U, GetNumQueries(dns, kHelloExampleCom));
5327
5328 // Expect the PARALLEL_LOOKUP_SLEEP_TIME_MS won't affect the query under cache hit case.
5329 dns.clearQueries();
5330 std::tie(result, timeTakenMs) = safe_getaddrinfo_time_taken(kHelloExampleCom, nullptr, hints);
5331 EXPECT_NE(nullptr, result);
5332 EXPECT_THAT(ToStrings(result), testing::UnorderedElementsAreArray(
5333 {kHelloExampleComAddrV4, kHelloExampleComAddrV6}));
5334 EXPECT_GT(PARALLEL_LOOKUP_SLEEP_TIME_MS, timeTakenMs);
5335 EXPECT_EQ(0U, GetNumQueries(dns, kHelloExampleCom));
5336}
Luke Huangeb618ef2020-05-26 14:17:02 +08005337
5338TEST_F(ResolverTest, BlockDnsQueryUidDoesNotLeadToBadServer) {
5339 // This test relies on blocking traffic on loopback, which xt_qtaguid does not do.
5340 // See aosp/358413 and b/34444781 for why.
5341 SKIP_IF_BPF_NOT_SUPPORTED;
5342
5343 constexpr char listen_addr1[] = "127.0.0.4";
5344 constexpr char listen_addr2[] = "::1";
5345 test::DNSResponder dns1(listen_addr1);
5346 test::DNSResponder dns2(listen_addr2);
5347 StartDns(dns1, {});
5348 StartDns(dns2, {});
5349
5350 std::vector<std::string> servers = {listen_addr1, listen_addr2};
5351 ASSERT_TRUE(mDnsClient.SetResolversForNetwork(servers));
5352 dns1.clearQueries();
5353 dns2.clearQueries();
5354 {
5355 ScopeBlockedUIDRule scopeBlockUidRule(mDnsClient.netdService(), TEST_UID);
5356 // Start querying ten times.
5357 for (int i = 0; i < 10; i++) {
5358 std::string hostName = fmt::format("blocked{}.com", i);
5359 const addrinfo hints = {.ai_family = AF_INET, .ai_socktype = SOCK_DGRAM};
Luke Huang5729afc2020-07-30 23:12:17 +08005360 // The query result between R+ and Q would be different, but we don't really care
5361 // about the result here because this test is only used to ensure blocked uid rule
5362 // won't cause bad servers.
5363 safe_getaddrinfo(hostName.c_str(), nullptr, &hints);
Luke Huangeb618ef2020-05-26 14:17:02 +08005364 }
5365 }
Luke Huang5729afc2020-07-30 23:12:17 +08005366 ResolverParamsParcel setupParams = DnsResponderClient::GetDefaultResolverParamsParcel();
5367 // If api level >= 30 (R+), expect all query packets to be blocked, hence we should not see any
5368 // of their stats show up. Otherwise, all queries should succeed.
5369 const std::vector<NameserverStats> expectedDnsStats = {
5370 NameserverStats(listen_addr1).setSuccesses(isAtLeastR ? 0 : setupParams.maxSamples),
Luke Huangeb618ef2020-05-26 14:17:02 +08005371 NameserverStats(listen_addr2),
5372 };
Luke Huang5729afc2020-07-30 23:12:17 +08005373 expectStatsEqualTo(expectedDnsStats);
5374 // If api level >= 30 (R+), expect server won't receive any queries,
5375 // otherwise expect 20 == 10 * (setupParams.domains.size() + 1) queries.
5376 EXPECT_EQ(dns1.queries().size(), isAtLeastR ? 0U : 10 * (setupParams.domains.size() + 1));
Luke Huangeb618ef2020-05-26 14:17:02 +08005377 EXPECT_EQ(dns2.queries().size(), 0U);
5378}
Mike Yu6ce587d2019-12-19 21:30:22 +08005379
Mike Yu10832aa2020-08-25 19:13:11 +08005380TEST_F(ResolverTest, DnsServerSelection) {
5381 test::DNSResponder dns1("127.0.0.3");
5382 test::DNSResponder dns2("127.0.0.4");
5383 test::DNSResponder dns3("127.0.0.5");
5384
5385 dns1.setResponseDelayMs(10);
5386 dns2.setResponseDelayMs(25);
5387 dns3.setResponseDelayMs(50);
5388 StartDns(dns1, {{kHelloExampleCom, ns_type::ns_t_a, kHelloExampleComAddrV4}});
5389 StartDns(dns2, {{kHelloExampleCom, ns_type::ns_t_a, kHelloExampleComAddrV4}});
5390 StartDns(dns3, {{kHelloExampleCom, ns_type::ns_t_a, kHelloExampleComAddrV4}});
5391
5392 ScopedSystemProperties scopedSystemProperties(kSortNameserversFlag, "1");
5393
Mike Yueb8f22c2020-09-22 11:58:13 +08005394 // NOTE: the servers must be sorted alphabetically.
5395 std::vector<std::string> serverList = {
5396 dns1.listen_address(),
5397 dns2.listen_address(),
5398 dns3.listen_address(),
Mike Yu10832aa2020-08-25 19:13:11 +08005399 };
Mike Yueb8f22c2020-09-22 11:58:13 +08005400
5401 do {
Mike Yu10832aa2020-08-25 19:13:11 +08005402 SCOPED_TRACE(fmt::format("testConfig: [{}]", fmt::join(serverList, ", ")));
5403 const int queryNum = 50;
5404 int64_t accumulatedTime = 0;
5405
5406 // Restart the testing network to 1) make the flag take effect and 2) reset the statistics.
5407 resetNetwork();
5408
5409 // DnsServerSelection doesn't apply to private DNS.
5410 ResolverParamsParcel setupParams = DnsResponderClient::GetDefaultResolverParamsParcel();
5411 setupParams.servers = serverList;
5412 setupParams.tlsServers.clear();
5413 ASSERT_TRUE(mDnsClient.SetResolversFromParcel(setupParams));
5414
5415 // DNSResponder doesn't handle queries concurrently, so don't allow more than
5416 // one in-flight query.
5417 for (int i = 0; i < queryNum; i++) {
5418 Stopwatch s;
5419 int fd = resNetworkQuery(TEST_NETID, kHelloExampleCom, ns_c_in, ns_t_a,
5420 ANDROID_RESOLV_NO_CACHE_LOOKUP);
5421 expectAnswersValid(fd, AF_INET, kHelloExampleComAddrV4);
5422 accumulatedTime += s.timeTakenUs();
5423 }
5424
5425 const int dns1Count = dns1.queries().size();
5426 const int dns2Count = dns2.queries().size();
5427 const int dns3Count = dns3.queries().size();
5428
5429 // All of the servers have ever been selected. In addition, the less latency server
5430 // is selected more frequently.
5431 EXPECT_GT(dns1Count, 0);
5432 EXPECT_GT(dns2Count, 0);
5433 EXPECT_GT(dns3Count, 0);
5434 EXPECT_GT(dns1Count, dns2Count);
5435 EXPECT_GT(dns2Count, dns3Count);
5436
Mike Yueb8f22c2020-09-22 11:58:13 +08005437 const int averageTime = accumulatedTime / queryNum;
5438 LOG(INFO) << "ResolverTest#DnsServerSelection: averageTime " << averageTime << "us";
Mike Yu10832aa2020-08-25 19:13:11 +08005439
Mike Yueb8f22c2020-09-22 11:58:13 +08005440 // Since the average Time might differ depending on parameters, set [10ms, 20ms] as
Mike Yu10832aa2020-08-25 19:13:11 +08005441 // acceptable range.
Mike Yueb8f22c2020-09-22 11:58:13 +08005442 EXPECT_GE(averageTime, 10000);
5443 EXPECT_LE(averageTime, 20000);
Mike Yu10832aa2020-08-25 19:13:11 +08005444
5445 dns1.clearQueries();
5446 dns2.clearQueries();
5447 dns3.clearQueries();
Mike Yueb8f22c2020-09-22 11:58:13 +08005448 } while (std::next_permutation(serverList.begin(), serverList.end()));
Mike Yu10832aa2020-08-25 19:13:11 +08005449}
5450
Mike Yu6ce587d2019-12-19 21:30:22 +08005451// ResolverMultinetworkTest is used to verify multinetwork functionality. Here's how it works:
5452// The resolver sends queries to address A, and then there will be a TunForwarder helping forward
5453// the packets to address B, which is the address on which the testing server is listening. The
5454// answer packets responded from the testing server go through the reverse path back to the
5455// resolver.
5456//
5457// To achieve the that, it needs to set up a interface with routing rules. Tests are not
5458// supposed to initiate DNS servers on their own; instead, some utilities are added to the class to
5459// help the setup.
5460//
5461// An example of how to use it:
5462// TEST_F() {
Luke Huang81568fb2020-07-13 00:55:12 +08005463// ScopedPhysicalNetwork network = CreateScopedPhysicalNetwork(V4);
Mike Yu6ce587d2019-12-19 21:30:22 +08005464// network.init();
5465//
5466// auto dns = network.addIpv4Dns();
5467// StartDns(dns.dnsServer, {});
5468//
Luke Huang81568fb2020-07-13 00:55:12 +08005469// network.setDnsConfiguration();
Mike Yu6ce587d2019-12-19 21:30:22 +08005470// network.startTunForwarder();
5471//
5472// // Send queries here
5473// }
5474
5475class ResolverMultinetworkTest : public ResolverTest {
5476 protected:
5477 enum class ConnectivityType { V4, V6, V4V6 };
Luke Huang81568fb2020-07-13 00:55:12 +08005478 static constexpr int TEST_NETID_BASE = 10000;
Mike Yu6ce587d2019-12-19 21:30:22 +08005479
5480 struct DnsServerPair {
Luke Huang81568fb2020-07-13 00:55:12 +08005481 DnsServerPair(std::shared_ptr<test::DNSResponder> server, std::string addr)
5482 : dnsServer(server), dnsAddr(addr) {}
5483 std::shared_ptr<test::DNSResponder> dnsServer;
Mike Yu6ce587d2019-12-19 21:30:22 +08005484 std::string dnsAddr; // The DNS server address used for setResolverConfiguration().
5485 // TODO: Add test::DnsTlsFrontend* and std::string for DoT.
5486 };
5487
5488 class ScopedNetwork {
5489 public:
5490 ScopedNetwork(unsigned netId, ConnectivityType type, INetd* netdSrv,
Luke Huang81568fb2020-07-13 00:55:12 +08005491 IDnsResolver* dnsResolvSrv, const char* networkName)
Mike Yu6ce587d2019-12-19 21:30:22 +08005492 : mNetId(netId),
5493 mConnectivityType(type),
5494 mNetdSrv(netdSrv),
Luke Huang81568fb2020-07-13 00:55:12 +08005495 mDnsResolvSrv(dnsResolvSrv),
5496 mNetworkName(networkName) {
5497 mIfname = fmt::format("testtun{}", netId);
Mike Yu6ce587d2019-12-19 21:30:22 +08005498 }
Luke Huang81568fb2020-07-13 00:55:12 +08005499 virtual ~ScopedNetwork() {
5500 if (mNetdSrv != nullptr) mNetdSrv->networkDestroy(mNetId);
5501 if (mDnsResolvSrv != nullptr) mDnsResolvSrv->destroyNetworkCache(mNetId);
5502 }
Mike Yu6ce587d2019-12-19 21:30:22 +08005503
5504 Result<void> init();
Mike Yu6ce587d2019-12-19 21:30:22 +08005505 Result<DnsServerPair> addIpv4Dns() { return addDns(ConnectivityType::V4); }
5506 Result<DnsServerPair> addIpv6Dns() { return addDns(ConnectivityType::V6); }
5507 bool startTunForwarder() { return mTunForwarder->startForwarding(); }
Luke Huang81568fb2020-07-13 00:55:12 +08005508 bool setDnsConfiguration() const;
5509 bool clearDnsConfiguration() const;
Mike Yu6ce587d2019-12-19 21:30:22 +08005510 unsigned netId() const { return mNetId; }
Luke Huang81568fb2020-07-13 00:55:12 +08005511 std::string name() const { return mNetworkName; }
Mike Yu6ce587d2019-12-19 21:30:22 +08005512
Luke Huang81568fb2020-07-13 00:55:12 +08005513 protected:
5514 // Subclasses should implement it to decide which network should be create.
5515 virtual Result<void> createNetwork() const = 0;
Mike Yu6ce587d2019-12-19 21:30:22 +08005516
5517 const unsigned mNetId;
5518 const ConnectivityType mConnectivityType;
5519 INetd* mNetdSrv;
5520 IDnsResolver* mDnsResolvSrv;
Luke Huang81568fb2020-07-13 00:55:12 +08005521 const std::string mNetworkName;
Mike Yu6ce587d2019-12-19 21:30:22 +08005522 std::string mIfname;
5523 std::unique_ptr<TunForwarder> mTunForwarder;
Luke Huang81568fb2020-07-13 00:55:12 +08005524 std::vector<DnsServerPair> mDnsServerPairs;
5525
5526 private:
5527 Result<DnsServerPair> addDns(ConnectivityType connectivity);
5528 // Assuming mNetId is unique during ResolverMultinetworkTest, make the
5529 // address based on it to avoid conflicts.
5530 std::string makeIpv4AddrString(uint8_t n) const {
5531 return StringPrintf("192.168.%u.%u", (mNetId - TEST_NETID_BASE), n);
5532 }
5533 std::string makeIpv6AddrString(uint8_t n) const {
5534 return StringPrintf("2001:db8:%u::%u", (mNetId - TEST_NETID_BASE), n);
5535 }
5536 };
5537
5538 class ScopedPhysicalNetwork : public ScopedNetwork {
5539 public:
5540 ScopedPhysicalNetwork(unsigned netId, const char* networkName)
5541 : ScopedNetwork(netId, ConnectivityType::V4V6, nullptr, nullptr, networkName) {}
5542 ScopedPhysicalNetwork(unsigned netId, ConnectivityType type, INetd* netdSrv,
5543 IDnsResolver* dnsResolvSrv, const char* name = "Physical")
5544 : ScopedNetwork(netId, type, netdSrv, dnsResolvSrv, name) {}
5545
5546 protected:
5547 Result<void> createNetwork() const override {
5548 if (auto r = mNetdSrv->networkCreatePhysical(mNetId, INetd::PERMISSION_NONE);
5549 !r.isOk()) {
5550 return Error() << r.getMessage();
5551 }
5552 return {};
5553 }
5554 };
5555
5556 class ScopedVirtualNetwork : public ScopedNetwork {
5557 public:
5558 ScopedVirtualNetwork(unsigned netId, ConnectivityType type, INetd* netdSrv,
5559 IDnsResolver* dnsResolvSrv, const char* name, bool isSecure)
5560 : ScopedNetwork(netId, type, netdSrv, dnsResolvSrv, name), mIsSecure(isSecure) {}
5561 ~ScopedVirtualNetwork() {
5562 if (!mVpnIsolationUids.empty()) {
5563 const std::vector<int> tmpUids(mVpnIsolationUids.begin(), mVpnIsolationUids.end());
5564 mNetdSrv->firewallRemoveUidInterfaceRules(tmpUids);
5565 }
5566 }
5567 // Enable VPN isolation. Ensures that uid can only receive packets on mIfname.
5568 Result<void> enableVpnIsolation(int uid) {
5569 if (auto r = mNetdSrv->firewallAddUidInterfaceRules(mIfname, {uid}); !r.isOk()) {
5570 return Error() << r.getMessage();
5571 }
5572 mVpnIsolationUids.insert(uid);
5573 return {};
5574 }
5575 Result<void> disableVpnIsolation(int uid) {
5576 if (auto r = mNetdSrv->firewallRemoveUidInterfaceRules({static_cast<int>(uid)});
5577 !r.isOk()) {
5578 return Error() << r.getMessage();
5579 }
5580 mVpnIsolationUids.erase(uid);
5581 return {};
5582 }
5583 Result<void> addUser(uid_t uid) const { return addUidRange(uid, uid); }
5584 Result<void> addUidRange(uid_t from, uid_t to) const {
5585 if (auto r = mNetdSrv->networkAddUidRanges(mNetId, {makeUidRangeParcel(from, to)});
5586 !r.isOk()) {
5587 return Error() << r.getMessage();
5588 }
5589 return {};
5590 }
5591
5592 protected:
5593 Result<void> createNetwork() const override {
5594 if (auto r = mNetdSrv->networkCreateVpn(mNetId, mIsSecure); !r.isOk()) {
5595 return Error() << r.getMessage();
5596 }
5597 return {};
5598 }
5599
5600 bool mIsSecure = false;
5601 std::unordered_set<int> mVpnIsolationUids;
Mike Yu6ce587d2019-12-19 21:30:22 +08005602 };
5603
5604 void SetUp() override {
5605 ResolverTest::SetUp();
5606 ASSERT_NE(mDnsClient.netdService(), nullptr);
5607 ASSERT_NE(mDnsClient.resolvService(), nullptr);
5608 }
5609
Luke Huang81568fb2020-07-13 00:55:12 +08005610 void TearDown() override {
5611 ResolverTest::TearDown();
5612 // Restore default network
5613 if (mStoredDefaultNetwork >= 0) {
5614 mDnsClient.netdService()->networkSetDefault(mStoredDefaultNetwork);
5615 }
5616 }
Mike Yu6ce587d2019-12-19 21:30:22 +08005617
Luke Huang81568fb2020-07-13 00:55:12 +08005618 ScopedPhysicalNetwork CreateScopedPhysicalNetwork(ConnectivityType type,
5619 const char* name = "Physical") {
5620 return {getFreeNetId(), type, mDnsClient.netdService(), mDnsClient.resolvService(), name};
5621 }
5622 ScopedVirtualNetwork CreateScopedVirtualNetwork(ConnectivityType type, bool isSecure,
5623 const char* name = "Virtual") {
5624 return {getFreeNetId(), type, mDnsClient.netdService(), mDnsClient.resolvService(),
5625 name, isSecure};
5626 }
Mike Yu6ce587d2019-12-19 21:30:22 +08005627 void StartDns(test::DNSResponder& dns, const std::vector<DnsRecord>& records);
Luke Huang81568fb2020-07-13 00:55:12 +08005628 void setDefaultNetwork(int netId) {
5629 // Save current default network at the first call.
5630 std::call_once(defaultNetworkFlag, [&]() {
5631 ASSERT_TRUE(mDnsClient.netdService()->networkGetDefault(&mStoredDefaultNetwork).isOk());
5632 });
5633 ASSERT_TRUE(mDnsClient.netdService()->networkSetDefault(netId).isOk());
5634 }
5635 unsigned getFreeNetId() {
5636 if (mNextNetId == TEST_NETID_BASE + 256) mNextNetId = TEST_NETID_BASE;
5637 return mNextNetId++;
5638 }
Mike Yu6ce587d2019-12-19 21:30:22 +08005639
5640 private:
5641 // Use a different netId because this class inherits from the class ResolverTest which
Luke Huang81568fb2020-07-13 00:55:12 +08005642 // always creates TEST_NETID in setup. It's incremented when CreateScoped{Physical,
5643 // Virtual}Network() is called.
5644 // Note: 255 is the maximum number of (mNextNetId - TEST_NETID_BASE) here as mNextNetId
5645 // is used to create address.
5646 unsigned mNextNetId = TEST_NETID_BASE;
5647 // Use -1 to represent that default network was not modified because
5648 // real netId must be an unsigned value.
5649 int mStoredDefaultNetwork = -1;
5650 std::once_flag defaultNetworkFlag;
Mike Yu6ce587d2019-12-19 21:30:22 +08005651};
5652
Mike Yu6ce587d2019-12-19 21:30:22 +08005653Result<void> ResolverMultinetworkTest::ScopedNetwork::init() {
Luke Huang81568fb2020-07-13 00:55:12 +08005654 if (mNetdSrv == nullptr || mDnsResolvSrv == nullptr) return Error() << "srv not available";
Mike Yu6ce587d2019-12-19 21:30:22 +08005655 unique_fd ufd = TunForwarder::createTun(mIfname);
5656 if (!ufd.ok()) {
5657 return Errorf("createTun for {} failed", mIfname);
5658 }
5659 mTunForwarder = std::make_unique<TunForwarder>(std::move(ufd));
5660
Luke Huang81568fb2020-07-13 00:55:12 +08005661 if (auto r = createNetwork(); !r.ok()) {
5662 return r;
Mike Yu6ce587d2019-12-19 21:30:22 +08005663 }
5664 if (auto r = mDnsResolvSrv->createNetworkCache(mNetId); !r.isOk()) {
5665 return Error() << r.getMessage();
5666 }
5667 if (auto r = mNetdSrv->networkAddInterface(mNetId, mIfname); !r.isOk()) {
5668 return Error() << r.getMessage();
5669 }
5670
5671 if (mConnectivityType == ConnectivityType::V4 || mConnectivityType == ConnectivityType::V4V6) {
5672 const std::string v4Addr = makeIpv4AddrString(1);
5673 if (auto r = mNetdSrv->interfaceAddAddress(mIfname, v4Addr, 32); !r.isOk()) {
5674 return Error() << r.getMessage();
5675 }
5676 if (auto r = mNetdSrv->networkAddRoute(mNetId, mIfname, "0.0.0.0/0", ""); !r.isOk()) {
5677 return Error() << r.getMessage();
5678 }
5679 }
5680 if (mConnectivityType == ConnectivityType::V6 || mConnectivityType == ConnectivityType::V4V6) {
5681 const std::string v6Addr = makeIpv6AddrString(1);
5682 if (auto r = mNetdSrv->interfaceAddAddress(mIfname, v6Addr, 128); !r.isOk()) {
5683 return Error() << r.getMessage();
5684 }
5685 if (auto r = mNetdSrv->networkAddRoute(mNetId, mIfname, "::/0", ""); !r.isOk()) {
5686 return Error() << r.getMessage();
5687 }
5688 }
5689
5690 return {};
5691}
5692
Mike Yu6ce587d2019-12-19 21:30:22 +08005693void ResolverMultinetworkTest::StartDns(test::DNSResponder& dns,
5694 const std::vector<DnsRecord>& records) {
5695 ResolverTest::StartDns(dns, records);
5696
5697 // Bind the DNSResponder's sockets to the network if specified.
5698 if (std::optional<unsigned> netId = dns.getNetwork(); netId.has_value()) {
5699 setNetworkForSocket(netId.value(), dns.getUdpSocket());
5700 setNetworkForSocket(netId.value(), dns.getTcpSocket());
5701 }
5702}
5703
5704Result<ResolverMultinetworkTest::DnsServerPair> ResolverMultinetworkTest::ScopedNetwork::addDns(
5705 ConnectivityType type) {
Luke Huang81568fb2020-07-13 00:55:12 +08005706 const int index = mDnsServerPairs.size();
Mike Yu6ce587d2019-12-19 21:30:22 +08005707 const int prefixLen = (type == ConnectivityType::V4) ? 32 : 128;
5708
5709 const std::function<std::string(unsigned)> makeIpString =
5710 std::bind((type == ConnectivityType::V4) ? &ScopedNetwork::makeIpv4AddrString
5711 : &ScopedNetwork::makeIpv6AddrString,
5712 this, std::placeholders::_1);
5713
5714 std::string src1 = makeIpString(1); // The address from which the resolver will send.
Luke Huang81568fb2020-07-13 00:55:12 +08005715 std::string dst1 = makeIpString(
5716 index + 100 +
5717 (mNetId - TEST_NETID_BASE)); // The address to which the resolver will send.
Mike Yu6ce587d2019-12-19 21:30:22 +08005718 std::string src2 = dst1; // The address translated from src1.
Luke Huang81568fb2020-07-13 00:55:12 +08005719 std::string dst2 = makeIpString(
5720 index + 200 + (mNetId - TEST_NETID_BASE)); // The address translated from dst2.
Mike Yu6ce587d2019-12-19 21:30:22 +08005721
5722 if (!mTunForwarder->addForwardingRule({src1, dst1}, {src2, dst2}) ||
5723 !mTunForwarder->addForwardingRule({dst2, src2}, {dst1, src1})) {
5724 return Errorf("Failed to add the rules ({}, {}, {}, {})", src1, dst1, src2, dst2);
5725 }
5726
5727 if (!mNetdSrv->interfaceAddAddress(mIfname, dst2, prefixLen).isOk()) {
5728 return Errorf("interfaceAddAddress({}, {}, {}) failed", mIfname, dst2, prefixLen);
5729 }
5730
Luke Huang81568fb2020-07-13 00:55:12 +08005731 return mDnsServerPairs.emplace_back(std::make_shared<test::DNSResponder>(mNetId, dst2), dst1);
Mike Yu6ce587d2019-12-19 21:30:22 +08005732}
5733
Luke Huang81568fb2020-07-13 00:55:12 +08005734bool ResolverMultinetworkTest::ScopedNetwork::setDnsConfiguration() const {
5735 if (mDnsResolvSrv == nullptr) return false;
5736 ResolverParamsParcel parcel = DnsResponderClient::GetDefaultResolverParamsParcel();
5737 parcel.tlsServers.clear();
5738 parcel.netId = mNetId;
5739 parcel.servers.clear();
5740 for (const auto& pair : mDnsServerPairs) {
5741 parcel.servers.push_back(pair.dnsAddr);
5742 }
5743 return mDnsResolvSrv->setResolverConfiguration(parcel).isOk();
5744}
5745
5746bool ResolverMultinetworkTest::ScopedNetwork::clearDnsConfiguration() const {
5747 if (mDnsResolvSrv == nullptr) return false;
5748 return mDnsResolvSrv->destroyNetworkCache(mNetId).isOk() &&
5749 mDnsResolvSrv->createNetworkCache(mNetId).isOk();
5750}
5751
5752namespace {
5753
5754// Convenient wrapper for making getaddrinfo call like framework.
5755Result<ScopedAddrinfo> android_getaddrinfofornet_wrapper(const char* name, int netId) {
5756 // Use the same parameter as libcore/ojluni/src/main/java/java/net/Inet6AddressImpl.java.
5757 static const addrinfo hints = {
5758 .ai_flags = AI_ADDRCONFIG,
5759 .ai_family = AF_UNSPEC,
5760 .ai_socktype = SOCK_STREAM,
5761 };
5762 addrinfo* result = nullptr;
5763 if (int r = android_getaddrinfofornet(name, nullptr, &hints, netId, MARK_UNSET, &result)) {
5764 return Error() << r;
5765 }
5766 return ScopedAddrinfo(result);
5767}
5768
5769void expectDnsWorksForUid(const char* name, unsigned netId, uid_t uid,
5770 const std::vector<std::string>& expectedResult) {
5771 ScopedChangeUID scopedChangeUID(uid);
5772 auto result = android_getaddrinfofornet_wrapper(name, netId);
5773 ASSERT_RESULT_OK(result);
5774 ScopedAddrinfo ai_result(std::move(result.value()));
5775 std::vector<std::string> result_strs = ToStrings(ai_result);
5776 EXPECT_THAT(result_strs, testing::UnorderedElementsAreArray(expectedResult));
5777}
5778
5779} // namespace
5780
Mike Yu6ce587d2019-12-19 21:30:22 +08005781TEST_F(ResolverMultinetworkTest, GetAddrInfo_AI_ADDRCONFIG) {
5782 constexpr char host_name[] = "ohayou.example.com.";
5783
5784 const std::array<ConnectivityType, 3> allTypes = {
5785 ConnectivityType::V4,
5786 ConnectivityType::V6,
5787 ConnectivityType::V4V6,
5788 };
5789 for (const auto& type : allTypes) {
5790 SCOPED_TRACE(StringPrintf("ConnectivityType: %d", type));
5791
5792 // Create a network.
Luke Huang81568fb2020-07-13 00:55:12 +08005793 ScopedPhysicalNetwork network = CreateScopedPhysicalNetwork(type);
Mike Yu6ce587d2019-12-19 21:30:22 +08005794 ASSERT_RESULT_OK(network.init());
5795
5796 // Add a testing DNS server.
5797 const Result<DnsServerPair> dnsPair =
5798 (type == ConnectivityType::V4) ? network.addIpv4Dns() : network.addIpv6Dns();
5799 ASSERT_RESULT_OK(dnsPair);
Luke Huang81568fb2020-07-13 00:55:12 +08005800 StartDns(*dnsPair->dnsServer, {{host_name, ns_type::ns_t_a, "192.0.2.0"},
5801 {host_name, ns_type::ns_t_aaaa, "2001:db8:cafe:d00d::31"}});
Mike Yu6ce587d2019-12-19 21:30:22 +08005802
5803 // Set up resolver and start forwarding.
Luke Huang81568fb2020-07-13 00:55:12 +08005804 ASSERT_TRUE(network.setDnsConfiguration());
Mike Yu6ce587d2019-12-19 21:30:22 +08005805 ASSERT_TRUE(network.startTunForwarder());
5806
Luke Huang81568fb2020-07-13 00:55:12 +08005807 auto result = android_getaddrinfofornet_wrapper(host_name, network.netId());
5808 ASSERT_RESULT_OK(result);
5809 ScopedAddrinfo ai_result(std::move(result.value()));
Mike Yu6ce587d2019-12-19 21:30:22 +08005810 std::vector<std::string> result_strs = ToStrings(ai_result);
5811 std::vector<std::string> expectedResult;
5812 size_t expectedQueries = 0;
5813
5814 if (type == ConnectivityType::V6 || type == ConnectivityType::V4V6) {
5815 expectedResult.emplace_back("2001:db8:cafe:d00d::31");
5816 expectedQueries++;
5817 }
5818 if (type == ConnectivityType::V4 || type == ConnectivityType::V4V6) {
Luke Huang81568fb2020-07-13 00:55:12 +08005819 expectedResult.emplace_back("192.0.2.0");
Mike Yu6ce587d2019-12-19 21:30:22 +08005820 expectedQueries++;
5821 }
5822 EXPECT_THAT(result_strs, testing::UnorderedElementsAreArray(expectedResult));
Luke Huang81568fb2020-07-13 00:55:12 +08005823 EXPECT_EQ(GetNumQueries(*dnsPair->dnsServer, host_name), expectedQueries);
Mike Yu6ce587d2019-12-19 21:30:22 +08005824 }
5825}
5826
5827TEST_F(ResolverMultinetworkTest, NetworkDestroyedDuringQueryInFlight) {
5828 constexpr char host_name[] = "ohayou.example.com.";
5829
5830 // Create a network and add an ipv4 DNS server.
Luke Huang81568fb2020-07-13 00:55:12 +08005831 auto network = std::make_unique<ScopedPhysicalNetwork>(getFreeNetId(), ConnectivityType::V4V6,
5832 mDnsClient.netdService(),
5833 mDnsClient.resolvService());
Mike Yu6ce587d2019-12-19 21:30:22 +08005834 ASSERT_RESULT_OK(network->init());
5835 const Result<DnsServerPair> dnsPair = network->addIpv4Dns();
5836 ASSERT_RESULT_OK(dnsPair);
5837
5838 // Set the DNS server unresponsive.
Luke Huang81568fb2020-07-13 00:55:12 +08005839 dnsPair->dnsServer->setResponseProbability(0.0);
5840 dnsPair->dnsServer->setErrorRcode(static_cast<ns_rcode>(-1));
5841 StartDns(*dnsPair->dnsServer, {});
Mike Yu6ce587d2019-12-19 21:30:22 +08005842
5843 // Set up resolver and start forwarding.
Luke Huang81568fb2020-07-13 00:55:12 +08005844 ASSERT_TRUE(network->setDnsConfiguration());
Mike Yu6ce587d2019-12-19 21:30:22 +08005845 ASSERT_TRUE(network->startTunForwarder());
5846
5847 // Expect the things happening in order:
5848 // 1. The thread sends the query to the dns server which is unresponsive.
5849 // 2. The network is destroyed while the thread is waiting for the response from the dns server.
5850 // 3. After the dns server timeout, the thread retries but fails to connect.
5851 std::thread lookup([&]() {
5852 int fd = resNetworkQuery(network->netId(), host_name, ns_c_in, ns_t_a, 0);
5853 EXPECT_TRUE(fd != -1);
5854 expectAnswersNotValid(fd, -ETIMEDOUT);
5855 });
5856
5857 // Tear down the network as soon as the dns server receives the query.
Luke Huang81568fb2020-07-13 00:55:12 +08005858 const auto condition = [&]() { return GetNumQueries(*dnsPair->dnsServer, host_name) == 1U; };
Mike Yu6ce587d2019-12-19 21:30:22 +08005859 EXPECT_TRUE(PollForCondition(condition));
5860 network.reset();
5861
5862 lookup.join();
5863}
5864
5865TEST_F(ResolverMultinetworkTest, OneCachePerNetwork) {
5866 SKIP_IF_REMOTE_VERSION_LESS_THAN(mDnsClient.resolvService(), 4);
5867 constexpr char host_name[] = "ohayou.example.com.";
5868
Luke Huang81568fb2020-07-13 00:55:12 +08005869 ScopedPhysicalNetwork network1 = CreateScopedPhysicalNetwork(ConnectivityType::V4V6);
5870 ScopedPhysicalNetwork network2 = CreateScopedPhysicalNetwork(ConnectivityType::V4V6);
Mike Yu6ce587d2019-12-19 21:30:22 +08005871 ASSERT_RESULT_OK(network1.init());
5872 ASSERT_RESULT_OK(network2.init());
5873
5874 const Result<DnsServerPair> dnsPair1 = network1.addIpv4Dns();
5875 const Result<DnsServerPair> dnsPair2 = network2.addIpv4Dns();
5876 ASSERT_RESULT_OK(dnsPair1);
5877 ASSERT_RESULT_OK(dnsPair2);
Luke Huang81568fb2020-07-13 00:55:12 +08005878 StartDns(*dnsPair1->dnsServer, {{host_name, ns_type::ns_t_a, "192.0.2.0"}});
5879 StartDns(*dnsPair2->dnsServer, {{host_name, ns_type::ns_t_a, "192.0.2.1"}});
Mike Yu6ce587d2019-12-19 21:30:22 +08005880
5881 // Set up resolver for network 1 and start forwarding.
Luke Huang81568fb2020-07-13 00:55:12 +08005882 ASSERT_TRUE(network1.setDnsConfiguration());
Mike Yu6ce587d2019-12-19 21:30:22 +08005883 ASSERT_TRUE(network1.startTunForwarder());
5884
5885 // Set up resolver for network 2 and start forwarding.
Luke Huang81568fb2020-07-13 00:55:12 +08005886 ASSERT_TRUE(network2.setDnsConfiguration());
Mike Yu6ce587d2019-12-19 21:30:22 +08005887 ASSERT_TRUE(network2.startTunForwarder());
5888
5889 // Send the same queries to both networks.
5890 int fd1 = resNetworkQuery(network1.netId(), host_name, ns_c_in, ns_t_a, 0);
5891 int fd2 = resNetworkQuery(network2.netId(), host_name, ns_c_in, ns_t_a, 0);
5892
Luke Huang81568fb2020-07-13 00:55:12 +08005893 expectAnswersValid(fd1, AF_INET, "192.0.2.0");
5894 expectAnswersValid(fd2, AF_INET, "192.0.2.1");
5895 EXPECT_EQ(GetNumQueries(*dnsPair1->dnsServer, host_name), 1U);
5896 EXPECT_EQ(GetNumQueries(*dnsPair2->dnsServer, host_name), 1U);
Mike Yu6ce587d2019-12-19 21:30:22 +08005897
5898 // Flush the cache of network 1, and send the queries again.
5899 EXPECT_TRUE(mDnsClient.resolvService()->flushNetworkCache(network1.netId()).isOk());
5900 fd1 = resNetworkQuery(network1.netId(), host_name, ns_c_in, ns_t_a, 0);
5901 fd2 = resNetworkQuery(network2.netId(), host_name, ns_c_in, ns_t_a, 0);
5902
Luke Huang81568fb2020-07-13 00:55:12 +08005903 expectAnswersValid(fd1, AF_INET, "192.0.2.0");
5904 expectAnswersValid(fd2, AF_INET, "192.0.2.1");
5905 EXPECT_EQ(GetNumQueries(*dnsPair1->dnsServer, host_name), 2U);
5906 EXPECT_EQ(GetNumQueries(*dnsPair2->dnsServer, host_name), 1U);
5907}
5908
5909TEST_F(ResolverMultinetworkTest, DnsWithVpn) {
5910 SKIP_IF_REMOTE_VERSION_LESS_THAN(mDnsClient.resolvService(), 4);
5911 SKIP_IF_BPF_NOT_SUPPORTED;
5912 constexpr char host_name[] = "ohayou.example.com.";
5913 constexpr char ipv4_addr[] = "192.0.2.0";
5914 constexpr char ipv6_addr[] = "2001:db8:cafe:d00d::31";
5915
5916 const std::pair<ConnectivityType, std::vector<std::string>> testPairs[] = {
5917 {ConnectivityType::V4, {ipv4_addr}},
5918 {ConnectivityType::V6, {ipv6_addr}},
5919 {ConnectivityType::V4V6, {ipv6_addr, ipv4_addr}},
5920 };
5921 for (const auto& [type, result] : testPairs) {
5922 SCOPED_TRACE(StringPrintf("ConnectivityType: %d", type));
5923
5924 // Create a network.
5925 ScopedPhysicalNetwork underlyingNetwork = CreateScopedPhysicalNetwork(type, "Underlying");
5926 ScopedVirtualNetwork bypassableVpnNetwork =
5927 CreateScopedVirtualNetwork(type, false, "BypassableVpn");
5928 ScopedVirtualNetwork secureVpnNetwork = CreateScopedVirtualNetwork(type, true, "SecureVpn");
5929
5930 ASSERT_RESULT_OK(underlyingNetwork.init());
5931 ASSERT_RESULT_OK(bypassableVpnNetwork.init());
5932 ASSERT_RESULT_OK(secureVpnNetwork.init());
5933 ASSERT_RESULT_OK(bypassableVpnNetwork.addUser(TEST_UID));
5934 ASSERT_RESULT_OK(secureVpnNetwork.addUser(TEST_UID2));
5935
5936 auto setupDnsFn = [&](std::shared_ptr<test::DNSResponder> dnsServer,
5937 ScopedNetwork* nw) -> void {
5938 StartDns(*dnsServer, {{host_name, ns_type::ns_t_a, ipv4_addr},
5939 {host_name, ns_type::ns_t_aaaa, ipv6_addr}});
5940 ASSERT_TRUE(nw->setDnsConfiguration());
5941 ASSERT_TRUE(nw->startTunForwarder());
5942 };
5943 // Add a testing DNS server to networks.
5944 const Result<DnsServerPair> underlyingPair = (type == ConnectivityType::V4)
5945 ? underlyingNetwork.addIpv4Dns()
5946 : underlyingNetwork.addIpv6Dns();
5947 ASSERT_RESULT_OK(underlyingPair);
5948 const Result<DnsServerPair> bypassableVpnPair = (type == ConnectivityType::V4)
5949 ? bypassableVpnNetwork.addIpv4Dns()
5950 : bypassableVpnNetwork.addIpv6Dns();
5951 ASSERT_RESULT_OK(bypassableVpnPair);
5952 const Result<DnsServerPair> secureVpnPair = (type == ConnectivityType::V4)
5953 ? secureVpnNetwork.addIpv4Dns()
5954 : secureVpnNetwork.addIpv6Dns();
5955 ASSERT_RESULT_OK(secureVpnPair);
5956 // Set up resolver and start forwarding for networks.
5957 setupDnsFn(underlyingPair->dnsServer, &underlyingNetwork);
5958 setupDnsFn(bypassableVpnPair->dnsServer, &bypassableVpnNetwork);
5959 setupDnsFn(secureVpnPair->dnsServer, &secureVpnNetwork);
5960
5961 setDefaultNetwork(underlyingNetwork.netId());
5962 const unsigned underlyingNetId = underlyingNetwork.netId();
5963 const unsigned bypassableVpnNetId = bypassableVpnNetwork.netId();
5964 const unsigned secureVpnNetId = secureVpnNetwork.netId();
5965 // We've called setNetworkForProcess in SetupOemNetwork, so reset to default first.
5966 ScopedSetNetworkForProcess scopedSetNetworkForProcess(NETID_UNSET);
5967 auto expectDnsQueryCountsFn = [&](size_t count,
5968 std::shared_ptr<test::DNSResponder> dnsServer,
5969 unsigned expectedDnsNetId) -> void {
5970 EXPECT_EQ(GetNumQueries(*dnsServer, host_name), count);
5971 EXPECT_TRUE(mDnsClient.resolvService()->flushNetworkCache(expectedDnsNetId).isOk());
5972 dnsServer->clearQueries();
5973 // Give DnsResolver some time to clear cache to avoid race.
5974 usleep(5 * 1000);
5975 };
5976
5977 // Create a object to represent default network, do not init it.
5978 ScopedPhysicalNetwork defaultNetwork{NETID_UNSET, "Default"};
5979
5980 // Test VPN with DNS server under 4 different network selection scenarios.
5981 // See the test config for the expectation.
5982 const struct TestConfig {
5983 ScopedNetwork* selectedNetwork;
5984 unsigned expectedDnsNetId;
5985 std::shared_ptr<test::DNSResponder> expectedDnsServer;
5986 } vpnWithDnsServerConfigs[]{
5987 // clang-format off
5988 // Queries use the bypassable VPN by default.
5989 {&defaultNetwork, bypassableVpnNetId, bypassableVpnPair->dnsServer},
5990 // Choosing the underlying network works because the VPN is bypassable.
5991 {&underlyingNetwork, underlyingNetId, underlyingPair->dnsServer},
5992 // Selecting the VPN sends the query on the VPN.
5993 {&bypassableVpnNetwork, bypassableVpnNetId, bypassableVpnPair->dnsServer},
5994 // TEST_UID does not have access to the secure VPN.
5995 {&secureVpnNetwork, bypassableVpnNetId, bypassableVpnPair->dnsServer},
5996 // clang-format on
5997 };
5998 for (const auto& config : vpnWithDnsServerConfigs) {
5999 SCOPED_TRACE(fmt::format("Bypassble VPN with DnsServer, selectedNetwork = {}",
6000 config.selectedNetwork->name()));
6001 expectDnsWorksForUid(host_name, config.selectedNetwork->netId(), TEST_UID, result);
6002 expectDnsQueryCountsFn(result.size(), config.expectedDnsServer,
6003 config.expectedDnsNetId);
6004 }
6005
6006 std::vector<ScopedNetwork*> nwVec{&defaultNetwork, &underlyingNetwork,
6007 &bypassableVpnNetwork, &secureVpnNetwork};
6008 // Test the VPN without DNS server with the same combination as before.
6009 ASSERT_TRUE(bypassableVpnNetwork.clearDnsConfiguration());
6010 // Test bypassable VPN, TEST_UID
6011 for (const auto* selectedNetwork : nwVec) {
6012 SCOPED_TRACE(fmt::format("Bypassble VPN without DnsServer, selectedNetwork = {}",
6013 selectedNetwork->name()));
6014 expectDnsWorksForUid(host_name, selectedNetwork->netId(), TEST_UID, result);
6015 expectDnsQueryCountsFn(result.size(), underlyingPair->dnsServer, underlyingNetId);
6016 }
6017
6018 // The same test scenario as before plus enableVpnIsolation for secure VPN, TEST_UID2.
6019 for (bool enableVpnIsolation : {false, true}) {
6020 SCOPED_TRACE(fmt::format("enableVpnIsolation = {}", enableVpnIsolation));
6021 if (enableVpnIsolation) {
6022 EXPECT_RESULT_OK(secureVpnNetwork.enableVpnIsolation(TEST_UID2));
6023 }
6024
6025 // Test secure VPN without DNS server.
6026 ASSERT_TRUE(secureVpnNetwork.clearDnsConfiguration());
6027 for (const auto* selectedNetwork : nwVec) {
6028 SCOPED_TRACE(fmt::format("Secure VPN without DnsServer, selectedNetwork = {}",
6029 selectedNetwork->name()));
6030 expectDnsWorksForUid(host_name, selectedNetwork->netId(), TEST_UID2, result);
6031 expectDnsQueryCountsFn(result.size(), underlyingPair->dnsServer, underlyingNetId);
6032 }
6033
6034 // Test secure VPN with DNS server.
6035 ASSERT_TRUE(secureVpnNetwork.setDnsConfiguration());
6036 for (const auto* selectedNetwork : nwVec) {
6037 SCOPED_TRACE(fmt::format("Secure VPN with DnsServer, selectedNetwork = {}",
6038 selectedNetwork->name()));
6039 expectDnsWorksForUid(host_name, selectedNetwork->netId(), TEST_UID2, result);
6040 expectDnsQueryCountsFn(result.size(), secureVpnPair->dnsServer, secureVpnNetId);
6041 }
6042
6043 if (enableVpnIsolation) {
6044 EXPECT_RESULT_OK(secureVpnNetwork.disableVpnIsolation(TEST_UID2));
6045 }
6046 }
6047 }
Mike Yu6ce587d2019-12-19 21:30:22 +08006048}