commit 1a855aef3f57b4024e9c36d61cbb5e5e3064320f
author Mike Lockwood <lockwood@android.com> Sat Sep 19 16:52:58 2009 -0400
committer Mike Lockwood <lockwood@android.com> Sat Sep 19 17:49:57 2009 -0400
tree 716db2c80c5e4185bbc21bc03de43848f2ba4f92
parent 69f4c1052f32150a5fb717f4d055d37810d7f1e9

adb: Clean up argument passing for create_service_thread()

Change-Id: Id68b312e76215e8e217b42ca0301713dbddfee9e
Signed-off-by: Mike Lockwood <lockwood@android.com>

services.c

diff --git a/services.c b/services.c
index cd02b36..b5df554 100644
--- a/services.c
+++ b/services.c
@@ -63,6 +63,7 @@
 
     adb_mutex_lock(&dns_lock);
     hp = gethostbyname(hostname);
+    free(cookie);
     if(hp == 0) {
         writex(fd, &zero, 4);
     } else {
@@ -184,6 +185,7 @@
         snprintf(buf, sizeof(buf), "reboot failed: %s\n", strerror(errno));
         writex(fd, buf, strlen(buf));
     }
+    free(arg);
     adb_close(fd);
 }
 
@@ -386,10 +388,9 @@
     } else if(!strncmp(name, "remount:", 8)) {
         ret = create_service_thread(remount_service, NULL);
     } else if(!strncmp(name, "reboot:", 7)) {
-        const char* arg = name + 7;
-        if (*name == 0)
-            arg = NULL;
-        ret = create_service_thread(reboot_service, (void *)arg);
+        void* arg = strdup(name + 7);
+        if(arg == 0) return -1;
+        ret = create_service_thread(reboot_service, arg);
     } else if(!strncmp(name, "root:", 5)) {
         ret = create_service_thread(restart_root_service, NULL);
     } else if(!strncmp(name, "tcpip:", 6)) {