Gitiles
Code Review Sign In
gerrit-public.fairphone.software / platform / packages / modules / adb / 35b817b64b56ca64fe334f460fa3fa05b1ea8b0b
commit35b817b64b56ca64fe334f460fa3fa05b1ea8b0b[log] [tgz]
authorBowgo Tsai <bowgotsai@google.com>Tue Mar 12 04:25:33 2019 +0800
committerBowgo Tsai <bowgotsai@google.com>Fri Mar 15 03:04:46 2019 +0800
treef6d24c7e1fb2cb791ad581c4f7d819588135b412
parent4ce212e2dc60c674aa8b81df8d4bf6651f4cbda8 [diff]
adbd: allowing adb root when the device is unlocked

As there is no security guarantee when the device is unlocked,
allowing adb root gives us more rooms to debug a USER build images.

Also, this makes it possible to run VTS on a USER build GSI, with
setting ro.debuggable=1 and unlocking the device.

This basically re-lands a reverted change:
https://android-review.googlesource.com/c/platform/system/core/+/437815

Which isn't needed after we moved /sbin/adbd to /system/bin/adbd in
USERDEBUG GSI. But it's still needed for USER build GSI.

Bug: 126493225
Test: unlock a USER build device, check 'adb root' can work
Change-Id: I93f12c8a3fe65c96c947e4602795eadfe591c521
2 files changed
tree: f6d24c7e1fb2cb791ad581c4f7d819588135b412
  1. client/
  2. daemon/
  3. fastdeploy/
  4. sysdeps/
  5. .clang-format ⇨ ../.clang-format-4
  6. adb.bash
  7. adb.cpp
  8. adb.h
  9. adb_auth.h
  10. adb_integration_test_adb.xml
  11. adb_integration_test_device.xml
  12. adb_io.cpp
  13. adb_io.h
  14. adb_io_test.cpp
  15. adb_listeners.cpp
  16. adb_listeners.h
  17. adb_listeners_test.cpp
  18. adb_mdns.h
  19. adb_trace.cpp
  20. adb_trace.h
  21. adb_unique_fd.cpp
  22. adb_unique_fd.h
  23. adb_utils.cpp
  24. adb_utils.h
  25. adb_utils_test.cpp
  26. Android.bp
  27. benchmark_device.py
  28. bugreport_test.cpp
  29. fdevent.cpp
  30. fdevent.h
  31. fdevent_test.cpp
  32. fdevent_test.h
  33. file_sync_protocol.h
  34. MODULE_LICENSE_APACHE2
  35. NOTICE
  36. OVERVIEW.TXT
  37. OWNERS
  38. protocol.txt
  39. security_log_tags.h
  40. services.cpp
  41. services.h
  42. SERVICES.TXT
  43. shell_protocol.h
  44. shell_service_protocol.cpp
  45. shell_service_protocol_test.cpp
  46. socket.h
  47. socket_spec.cpp
  48. socket_spec.h
  49. socket_spec_test.cpp
  50. socket_test.cpp
  51. sockets.cpp
  52. sockets.dia
  53. SYNC.TXT
  54. sysdeps.h
  55. sysdeps_test.cpp
  56. sysdeps_unix.cpp
  57. sysdeps_win32.cpp
  58. sysdeps_win32_test.cpp
  59. test_adb.py
  60. test_device.py
  61. trace.sh
  62. transport.cpp
  63. transport.h
  64. transport_benchmark.cpp
  65. transport_fd.cpp
  66. transport_local.cpp
  67. transport_test.cpp
  68. transport_usb.cpp
  69. types.h
  70. types_test.cpp
  71. usb.h