commit 382ea6e97dcf4a33e98359e92ae7a1bb44ca512a
author Josh Gao <jmgao@google.com> Fri Feb 12 14:31:15 2016 -0800
committer Josh Gao <jmgao@google.com> Mon Feb 22 15:57:08 2016 -0800
tree 7083bed3c036f01f16c80da7baec717914258734
parent 0f80e09962d6c00d63f7d5a7986f180616b2d7fb

adb: make adb_thread_func_t return void, add adb_thread_exit.

Windows restricts the return value of threads to 32-bits, even on 64-bit
platforms. Since we don't actually return meaningful values from thread,
resolve this inconsistency with POSIX by making adb's thread abstraction
only take void functions.

Change-Id: I5c23b4432314f13bf16d606fd5e6b6b7b6ef98b5
(cherry picked from commit 7d40525cb2e6ab7bc1c2dd940dcb7418701e46e3)

usb_linux_client.cpp

diff --git a/usb_linux_client.cpp b/usb_linux_client.cpp
index a4f1a70..c863ed2 100644
--- a/usb_linux_client.cpp
+++ b/usb_linux_client.cpp
@@ -232,10 +232,7 @@
     },
 };
 
-
-
-static void *usb_adb_open_thread(void *x)
-{
+static void usb_adb_open_thread(void* x) {
     struct usb_handle *usb = (struct usb_handle *)x;
     int fd;
 
@@ -270,7 +267,7 @@
     }
 
     // never gets here
-    return 0;
+    abort();
 }
 
 static int usb_adb_write(usb_handle *h, const void *data, int len)
@@ -434,8 +431,7 @@
     return;
 }
 
-static void *usb_ffs_open_thread(void *x)
-{
+static void usb_ffs_open_thread(void* x) {
     struct usb_handle *usb = (struct usb_handle *)x;
 
     adb_thread_setname("usb ffs open");
@@ -462,7 +458,7 @@
     }
 
     // never gets here
-    return 0;
+    abort();
 }
 
 static int usb_ffs_write(usb_handle* h, const void* data, int len) {