Gitiles
Code Review Sign In
gerrit-public.fairphone.software / platform / packages / modules / adb / 3d9072bfe6e85b479575bd9600c6b5c04e5499c9
commit3d9072bfe6e85b479575bd9600c6b5c04e5499c9[log] [tgz]
authorDavid Pursell <dpursell@google.com>Fri Sep 25 13:04:21 2015 -0700
committerDavid Pursell <dpursell@google.com>Fri Sep 25 13:10:17 2015 -0700
treea6083574db28238bf6bd6502308ac1e5dc570eee
parent19bec5b329fe202795688bfb76d77f4560adf2c6 [diff]
adb: fix adbd feature parsing for no features.

Previously the transport features list was only overwritten if a
new feature list was found. However, adbd can reuse the same atransport
object even if the adb server is killed and restarted, so the feature
list was not cleared properly if the newly started adb server didn't
provide one.

This CL fixes the bug by clearing the transport features list whenever
a connection banner is parsed.

Bug: http://b/24405971
Change-Id: Ia6ee6c9a46a621534681f6d4d7df77156b885eb9
3 files changed
tree: a6083574db28238bf6bd6502308ac1e5dc570eee
  1. client/
  2. daemon/
  3. .clang-format
  4. adb.cpp
  5. adb.h
  6. adb_auth.cpp
  7. adb_auth.h
  8. adb_auth_client.cpp
  9. adb_auth_host.cpp
  10. adb_client.cpp
  11. adb_client.h
  12. adb_io.cpp
  13. adb_io.h
  14. adb_io_test.cpp
  15. adb_listeners.cpp
  16. adb_listeners.h
  17. adb_trace.cpp
  18. adb_trace.h
  19. adb_utils.cpp
  20. adb_utils.h
  21. adb_utils_test.cpp
  22. Android.mk
  23. commandline.cpp
  24. console.cpp
  25. CPPLINT.cfg
  26. fdevent.cpp
  27. fdevent.h
  28. fdevent_test.cpp
  29. file_sync_client.cpp
  30. file_sync_service.cpp
  31. file_sync_service.h
  32. framebuffer_service.cpp
  33. get_my_path_darwin.cpp
  34. get_my_path_linux.cpp
  35. jdwp_service.cpp
  36. MODULE_LICENSE_APACHE2
  37. mutex_list.h
  38. NOTICE
  39. OVERVIEW.TXT
  40. protocol.txt
  41. remount_service.cpp
  42. remount_service.h
  43. services.cpp
  44. SERVICES.TXT
  45. set_verity_enable_state_service.cpp
  46. shell_service.cpp
  47. shell_service.h
  48. shell_service_protocol.cpp
  49. shell_service_protocol_test.cpp
  50. shell_service_test.cpp
  51. socket.h
  52. socket_test.cpp
  53. sockets.cpp
  54. sockets.dia
  55. SYNC.TXT
  56. sysdeps.h
  57. sysdeps_win32.cpp
  58. sysdeps_win32_test.cpp
  59. test_adb.py
  60. test_track_devices.cpp
  61. transport.cpp
  62. transport.h
  63. transport_local.cpp
  64. transport_test.cpp
  65. transport_usb.cpp
  66. usb_linux.cpp
  67. usb_linux_client.cpp
  68. usb_osx.cpp
  69. usb_windows.cpp