Gitiles
Code Review Sign In
gerrit-public.fairphone.software / platform / packages / modules / adb / 6d5fad3fd225f1aecb407730c2d24eb339c0d6e6
commit6d5fad3fd225f1aecb407730c2d24eb339c0d6e6[log] [tgz]
authorDavid Pursell <dpursell@google.com>Fri Sep 25 08:37:13 2015 -0700
committerDavid Pursell <dpursell@google.com>Fri Sep 25 09:59:31 2015 -0700
tree7d0cd186ed324a40c4f441b8139d4aefa3101436
parent19bec5b329fe202795688bfb76d77f4560adf2c6 [diff]
adb: bump server version to prevent feature mismatch.

Devices get a list of supported features from the adb server, not the
client, so a mismatch between client and server features can cause the
device to use an incorrect feature set.

Bumping the server version is the easiest way to make sure the client
and server features match and seems like the best solution at the
moment.

A more automated fix could be to compare client/server features on each
connection and restart if they don't match. This requires an extra
client <-> server round-trip per command, but removes the need to
manually bump the server version number on feature change. Unless the
feature set changes often it didn't seem worth the extra overhead.

Bug: http://b/24370690
Change-Id: I4e43825d1c15c61e5d924fc8d4110b467debde37
2 files changed
tree: 7d0cd186ed324a40c4f441b8139d4aefa3101436
  1. client/
  2. daemon/
  3. .clang-format
  4. adb.cpp
  5. adb.h
  6. adb_auth.cpp
  7. adb_auth.h
  8. adb_auth_client.cpp
  9. adb_auth_host.cpp
  10. adb_client.cpp
  11. adb_client.h
  12. adb_io.cpp
  13. adb_io.h
  14. adb_io_test.cpp
  15. adb_listeners.cpp
  16. adb_listeners.h
  17. adb_trace.cpp
  18. adb_trace.h
  19. adb_utils.cpp
  20. adb_utils.h
  21. adb_utils_test.cpp
  22. Android.mk
  23. commandline.cpp
  24. console.cpp
  25. CPPLINT.cfg
  26. fdevent.cpp
  27. fdevent.h
  28. fdevent_test.cpp
  29. file_sync_client.cpp
  30. file_sync_service.cpp
  31. file_sync_service.h
  32. framebuffer_service.cpp
  33. get_my_path_darwin.cpp
  34. get_my_path_linux.cpp
  35. jdwp_service.cpp
  36. MODULE_LICENSE_APACHE2
  37. mutex_list.h
  38. NOTICE
  39. OVERVIEW.TXT
  40. protocol.txt
  41. remount_service.cpp
  42. remount_service.h
  43. services.cpp
  44. SERVICES.TXT
  45. set_verity_enable_state_service.cpp
  46. shell_service.cpp
  47. shell_service.h
  48. shell_service_protocol.cpp
  49. shell_service_protocol_test.cpp
  50. shell_service_test.cpp
  51. socket.h
  52. socket_test.cpp
  53. sockets.cpp
  54. sockets.dia
  55. SYNC.TXT
  56. sysdeps.h
  57. sysdeps_win32.cpp
  58. sysdeps_win32_test.cpp
  59. test_adb.py
  60. test_track_devices.cpp
  61. transport.cpp
  62. transport.h
  63. transport_local.cpp
  64. transport_test.cpp
  65. transport_usb.cpp
  66. usb_linux.cpp
  67. usb_linux_client.cpp
  68. usb_osx.cpp
  69. usb_windows.cpp